Re: [PATCH] Ensure std::getline always 0-terminates string.

On 21.11.2017, at 03:54, Volodymyr Sapsai wrote: > >> If (exceptions()) != 0 then the exception is rethrown. > And looks like libstdc++ rethrows exception even if badbit is not set. Thanks for looking all that up, I was in a hurry. > If you feel comfortable, I can finish

Re: r318722 - Re-revert "Refactor debuginfo-tests."

On Mon, Nov 20, 2017 at 5:20 PM, Zachary Turner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: zturner > Date: Mon Nov 20 17:20:28 2017 > New Revision: 318722 > > URL: http://llvm.org/viewvc/llvm-project?rev=318722=rev > Log: > Re-revert "Refactor debuginfo-tests." > > This is

[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

ogoffart updated this revision to Diff 123720. ogoffart added a comment. Herald added a subscriber: klimek. I added a test. I did not add such test before because i know that calling Reset() on the diagnostics is kind of a hack. This change does not have any behavioral difference normally, it

[PATCH] D39936: [OpenCL] Add extensions cl_intel_subgroups and cl_intel_subgroups_short

AlexeySotkin updated this revision to Diff 123716. AlexeySotkin added a comment. Replacing #define macros with explicit declarations https://reviews.llvm.org/D39936 Files: include/clang/Basic/OpenCLExtensions.def lib/Headers/opencl-c.h test/SemaOpenCL/extension-version.cl Index:

[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

aaron.ballman added a comment. In https://reviews.llvm.org/D40242#931173, @ogoffart wrote: > > You should add a test case that demonstrates code which would otherwise > > trigger an analysis-based warning but doesn't due to disabling all warnings. > > No warnings are triggered. Because the

[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

ogoffart marked an inline comment as done. ogoffart added a comment. > You should add a test case that demonstrates code which would otherwise > trigger an analysis-based warning but doesn't due to disabling all warnings. No warnings are triggered. Because the diagnostic engine ignores them.

[PATCH] D40270: [Modules TS] Added re-export support

boris added a comment. LGTM. Will be happy to also run our re-export tests in build2 once this is merged. https://reviews.llvm.org/D40270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

aaron.ballman added a comment. Did you decide on fuchsia instead of zircon for the module name, or is that decision still up in the air? Comment at: clang-tidy/fuchsia/DefaultArgumentsCheck.cpp:22 + // Calling a function which uses default arguments is disallowed. +

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

krytarowski added a comment. In https://reviews.llvm.org/D35755#930789, @fedor.sergeev wrote: > In https://reviews.llvm.org/D35755#930030, @ro wrote: > > > What's the status here? This patch is required for my WIP > > sanitizers-on-Solaris work. > > > since @tstellar just resolved the only

[PATCH] D40280: [CMake][libcxx] Include AddLLVM needed for tests in the right context

phosek created this revision. Herald added a subscriber: mgorny. AddLLVM is needed for several functions that are used in tests and as such needs to be included from the right context which previously wasn't the case. Repository: rL LLVM https://reviews.llvm.org/D40280 Files:

[PATCH] D40257: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add

phosek updated this revision to Diff 123710. Repository: rL LLVM https://reviews.llvm.org/D40257 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -653,7 +653,7 @@

[PATCH] D40230: Add -mprefer-vector-width driver option and attribute during CodeGen.

craig.topper updated this revision to Diff 123709. craig.topper added a comment. Still pass the attribute the backend if the value is 'none'. We actually need this to know if the user specified the command line option at all. The value of 'none' should disable limits and prevents needing to

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

tcanens added inline comments. Comment at: include/__functional_base:396 +!is_same<__uncvref_t<_Up>, reference_wrapper>::value +>::type, bool _IsNothrow = noexcept(__bind(_VSTD::declval<_Up>()))> +_LIBCPP_INLINE_VISIBILITY reference_wrapper(_Up&& __u)

[PATCH] D40267: WG14 DR496

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! https://reviews.llvm.org/D40267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40279: [libcxxabi][demangler] Add demangling for __attribute__((abi_tag))

erik.pilkington created this revision. This patch adds demangling support for `__attribute__((abi_tag))`. I.e, the following function: `__attribute__((abi_tag("foo"))) void f() {}` mangles to `_Z1fB3foov`, and now demangles to `f[abi:foo]()` (this syntax is the same as GCC's demangler). This

Re: [PATCH] Ensure std::getline always 0-terminates string.

On Nov 20, 2017, at 16:33, Reimar Döffinger wrote: > > On 20 November 2017 22:19:04 CET, Volodymyr Sapsai > wrote: >> On Nov 20, 2017, at 11:32, Reimar Döffinger >> wrote: >>> >>> On Mon, Nov

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth added a comment. Forgot to mention this last patch also added support for displaying function comments above the function definition displayed. https://reviews.llvm.org/D35894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40261: Add default argument AST matcher

juliehockett added a comment. It'd be great if you could commit it -- I don't have commit privileges. Much appreciated! https://reviews.llvm.org/D40261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40261: Add default argument AST matcher

juliehockett updated this revision to Diff 123701. juliehockett marked an inline comment as done. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2188 + !Context.getTargetInfo().isVLASupported() && + shouldDiagnoseTargetSupportFromOpenMP()) { + // Some targets don't support VLAs. Please write this

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

compnerd added inline comments. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:419 +Features.push_back("-fullfp16"); + +const bool HasNeon = (std::find(ItBegin, ItEnd, "+neon") != ItEnd); It would be nice to not have these explicitly listed. But at

r318723 - [MS] Increase default new alignment for win64 and test it

Author: rnk Date: Mon Nov 20 17:25:56 2017 New Revision: 318723 URL: http://llvm.org/viewvc/llvm-project?rev=318723=rev Log: [MS] Increase default new alignment for win64 and test it Summary: This raises __STDCPP_DEFAULT_NEW_ALIGNMENT__ from 8 to 16 on Win64. This matches platforms that follow

[PATCH] D40277: [MS] Increase default new alignment for win64 and test it

This revision was automatically updated to reflect the committed changes. Closed by commit rL318723: [MS] Increase default new alignment for win64 and test it (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D40277?vs=123692=123698#toc Repository: rL LLVM

[PATCH] D40270: [Modules TS] Added re-export support

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, looks great. Comment at: test/CXX/modules-ts/dcl.dcl/dcl.module/dcl.module.export/p1.cpp:22 +} +#endif + Maybe consider adding one more module to

[PATCH] D39963: [RISCV][RFC] Add initial RISC-V target and driver support

apazos added a comment. Can you push this as a patch to review/commit instead of RFC? It has received a lot of comments/corrections already and I think it is getting in a shape we can merge. Comment at: lib/Driver/ToolChains/RISCV.cpp:86 +CmdArgs.push_back("-lc"); +

r318722 - Re-revert "Refactor debuginfo-tests."

Author: zturner Date: Mon Nov 20 17:20:28 2017 New Revision: 318722 URL: http://llvm.org/viewvc/llvm-project?rev=318722=rev Log: Re-revert "Refactor debuginfo-tests." This is still breaking greendragon. At this point I give up until someone can fix the greendragon bots, and I will probably

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

tra updated this revision to Diff 123694. tra added a comment. Updates CUDA's VLA test to use nvptx triple. https://reviews.llvm.org/D40275 Files: clang/lib/Sema/SemaType.cpp clang/test/SemaCUDA/vla.cu Index: clang/test/SemaCUDA/vla.cu

[PATCH] D40277: [MS] Increase default new alignment for win64 and test it

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks fine to me, but I think the alignment numbers in your summary are off by a factor of two. https://reviews.llvm.org/D40277 ___ cfe-commits

r318719 - FormatInternal.h: Add missing includes.

Author: dblaikie Date: Mon Nov 20 17:09:17 2017 New Revision: 318719 URL: http://llvm.org/viewvc/llvm-project?rev=318719=rev Log: FormatInternal.h: Add missing includes. Modified: cfe/trunk/lib/Format/FormatInternal.h Modified: cfe/trunk/lib/Format/FormatInternal.h URL:

r318720 - ASTMatchers{, Macros}.h: Add some extra macros to use for decl/def of matchers

Author: dblaikie Date: Mon Nov 20 17:09:18 2017 New Revision: 318720 URL: http://llvm.org/viewvc/llvm-project?rev=318720=rev Log: ASTMatchers{,Macros}.h: Add some extra macros to use for decl/def of matchers Fix ODR violations caused by using internal linkage variables in non-internal inline

[PATCH] D39953: [CodeGen] Generate TBAA type descriptors in a more reliable manner

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, looks good. https://reviews.llvm.org/D39953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40023: [RISCV] Implement ABI lowering

mgrang added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:8790 +private: + unsigned XLen; + static const int NumArgGPRs = 8; rjmccall wrote: > Is "XLen" a term that anyone working with RISCV would recognize? Because > even if it is, it feels like

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

Hahnfeld added a comment. In https://reviews.llvm.org/D40275#930981, @tra wrote: > In https://reviews.llvm.org/D40275#930948, @Hahnfeld wrote: > > > In https://reviews.llvm.org/D39505 @rjmccall requested that the check > > should be made independent of the language. To preserve this, I think

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

tra added a comment. In https://reviews.llvm.org/D40275#930982, @Hahnfeld wrote: > And please add a regression test which is apparently missing for the case > that a VLA is **NOT** diagnosed in CUDA mode Hmm. We do have test/SemaCUDA/vla.cu which should've triggered the error. Let me see why

[PATCH] D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization.

rsmith added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:4567 - if (Kind <= BTT_Last) + // Evaluate BTT_ReferenceBindsToTemporary along side the IsConstructible + // traits to avoid duplication. "alongside" is a single word.

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

tra added a comment. In https://reviews.llvm.org/D40275#930948, @Hahnfeld wrote: > In https://reviews.llvm.org/D39505 @rjmccall requested that the check should > be made independent of the language. To preserve this, I think the CUDA > specific checks should be added to the generic case

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

Hahnfeld added a comment. And please add a regression test which is apparently missing for the case that a VLA is **NOT** diagnosed in CUDA mode https://reviews.llvm.org/D40275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40277: [MS] Increase default new alignment for win64 and test it

rnk created this revision. This raises __STDCPP_DEFAULT_NEW_ALIGNMENT__ from 16 to 32 on Win64. This matches platforms that follow the usual `2 * sizeof(void*)` alignment requirement for malloc. We might want to consider making that the default rather than relying on long double alignment. Fixes

[PATCH] D40276: Add -finstrument-function-entry-bare flag

hans created this revision. This is an instrumentation flag, similar to -finstrument-functions, but it only inserts calls on function entry, the calls are inserted post-inlining, and they don't take any arugments. This is intended for users who want to instrument function entry with minimal

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

gtbercea accepted this revision. gtbercea added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D40250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

Hahnfeld requested changes to this revision. Hahnfeld added a comment. This revision now requires changes to proceed. In https://reviews.llvm.org/D39505 @rjmccall requested that the check should be made independent of the language. To preserve this, I think the CUDA specific checks should be

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

tra updated this revision to Diff 123690. tra added a comment. Folded OpenCL check under `if (T->isVariableArrayType())` https://reviews.llvm.org/D40275 Files: clang/lib/Sema/SemaType.cpp Index: clang/lib/Sema/SemaType.cpp ===

Re: r318601 - [OpenMP] Show error if VLAs are not supported

I'm sorry, I didn't get a notification for that failure. I'll reply to the Phabricator. Am 2017-11-20 19:37, schrieb Artem Belevich: Proposed fix: https://reviews.llvm.org/D40275 On Mon, Nov 20, 2017 at 4:13 PM, Artem Belevich wrote: This change breaks CUDA as clang now

Re: r318601 - [OpenMP] Show error if VLAs are not supported

Proposed fix: https://reviews.llvm.org/D40275 On Mon, Nov 20, 2017 at 4:13 PM, Artem Belevich wrote: > This change breaks CUDA as clang now reports an error during device-side > compilation when VLA is used in the *host-side* code. >

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

tra created this revision. Herald added a subscriber: sanjoy. This fixes erroneously reported CUDA compilation errors in host-side code during device-side compilation. I've also restricted OpenMP-specific checks to trigger only if we're compiling with OpenMP enabled.

Re: [PATCH] Ensure std::getline always 0-terminates string.

On 20 November 2017 22:19:04 CET, Volodymyr Sapsai wrote: >On Nov 20, 2017, at 11:32, Reimar Döffinger >wrote: >> >> On Mon, Nov 20, 2017 at 11:02:13AM -0800, Volodymyr Sapsai wrote: catch (...) { +if (__n > 0) +

r318716 - [X86] Remove 'mm3now' from isValidFeatureName.

Author: ctopper Date: Mon Nov 20 16:33:26 2017 New Revision: 318716 URL: http://llvm.org/viewvc/llvm-project?rev=318716=rev Log: [X86] Remove 'mm3now' from isValidFeatureName. The correct spelling is '3dnow' which is already in the list. Modified: cfe/trunk/lib/Basic/Targets/X86.cpp

[PATCH] D40224: [X86] Control-Flow Enforcement Technology - Shadow Stack and Indirect Branch Tracking support (Clang side)

craig.topper added inline comments. Comment at: include/clang/Basic/BuiltinsX86.def:642 +// SHSTK +TARGET_BUILTIN(__builtin_ia32_incsspd, "vUi","u","shstk") +TARGET_BUILTIN(__builtin_ia32_rdsspd, "UiUi","Un","shstk") Space after commas to match the rest of the

Re: r318601 - [OpenMP] Show error if VLAs are not supported

This change breaks CUDA as clang now reports an error during device-side compilation when VLA is used in the *host-side* code. http://lab.llvm.org:8011/builders/clang-cuda-build/builds/15591/steps/ninja%20build%20simple%20CUDA%20tests/logs/stdio E.g. I would expect this code to compile

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

K-ballo updated this revision to Diff 123679. K-ballo added a comment. Addressed review comments. Added tests for SFINAE, noexcept, deduction guide. https://reviews.llvm.org/D40259 Files: include/__functional_base include/functional

[PATCH] D40187: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for' on host

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 318692. Repository: rL LLVM https://reviews.llvm.org/D40187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123677. juliehockett marked 8 inline comments as done. juliehockett added a comment. Moved AST matcher out to ASTMatchers.h (see D40261 ), fixing comments https://reviews.llvm.org/D40108 Files:

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/DefaultArgumentsCheck.cpp:22 + // Calling a function which uses default arguments is disallowed. + Finder->addMatcher(cxxDefaultArgExpr().bind("stmt"), this); + // Declaring default parameters is disallowed.

[PATCH] D40228: [Target] Keep the TargetOptions feature list sorted instead of sorting during CodeGen

echristo added a comment. No strong opinion. I think I like that one more though. https://reviews.llvm.org/D40228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40228: [Target] Keep the TargetOptions feature list sorted instead of sorting during CodeGen

craig.topper added a comment. Yeah don't like it either, but was surprised to find that CodeGen even had a non-const reference to TargetOptions. Would it be better to make a copy and sort the copy during CodeGen? https://reviews.llvm.org/D40228

[PATCH] D40228: [Target] Keep the TargetOptions feature list sorted instead of sorting during CodeGen

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This seems strictly more difficult to keep under control? Though I guess the assert helps. Feel free to go ahead, but... https://reviews.llvm.org/D40228

[PATCH] D40270: [Modules TS] Added re-export support

hamzasood created this revision. This patch adds support for re-exporting modules as described in `[dcl.modules.export]` https://reviews.llvm.org/D40270 Files: include/clang/Parse/Parser.h lib/Parse/ParseObjc.cpp lib/Parse/Parser.cpp lib/Sema/SemaDecl.cpp

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

This revision was automatically updated to reflect the committed changes. Closed by commit rL318705: [analyzer] Diagnose stack leaks via block captures (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D39438?vs=123392=123664#toc Repository: rL LLVM

r318705 - [analyzer] Diagnose stack leaks via block captures

Author: alexshap Date: Mon Nov 20 14:53:30 2017 New Revision: 318705 URL: http://llvm.org/viewvc/llvm-project?rev=318705=rev Log: [analyzer] Diagnose stack leaks via block captures This diff extends StackAddrEscapeChecker to catch stack addresses leaks via block captures if the block is executed

[PATCH] D40144: Implement `std::launder`

mclow.lists updated this revision to Diff 123663. mclow.lists added a comment. Un-c++17'ed the internal function `__launder` https://reviews.llvm.org/D40144 Files: include/__config include/new test/std/language.support/support.dynamic/ptr.launder/launder.nodiscard.fail.cpp

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth updated this revision to Diff 123662. Nebiroth marked 10 inline comments as done. Nebiroth added a comment. Removed all std::pair objects Fixed and updated all tests findHover doesn't call findDefinitions anymore DeclarationLocationsFinder fills two Decl and MacroInfos vectors instead of

[PATCH] D40144: Implement `std::launder`

mclow.lists added inline comments. Comment at: include/new:260 +static_assert (!is_function<_Tp>::value, "can't launder functions" ); +static_assert (!is_same_v>, "can't launder cv-void" ); +#ifdef _LIBCPP_COMPILER_HAS_BUILTIN_LAUNDER

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

rjmccall accepted this revision. rjmccall added a comment. Yes, LGTM. Repository: rL LLVM https://reviews.llvm.org/D39947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39279: Stringizing raw string literals containing newline

twoh updated this revision to Diff 123658. twoh added a comment. Addressing @vsapsai's comments. Thank you for the suggestion! Added test case actually finds an off-by-one error in the original patch. I improved the comments as well. https://reviews.llvm.org/D39279 Files:

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev marked an inline comment as not done. fedor.sergeev added a comment. In https://reviews.llvm.org/D35755#930030, @ro wrote: > What's the status here? This patch is required for my WIP > sanitizers-on-Solaris work. since @tstellar just resolved the only remaining question I will

[PATCH] D40261: Add default argument AST matcher

juliehockett updated this revision to Diff 123654. juliehockett added a comment. Removed spurious semicolons https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[clang-tools-extra] r318702 - Revert 318668, which is associated with a broken patch

Author: erichkeane Date: Mon Nov 20 14:10:28 2017 New Revision: 318702 URL: http://llvm.org/viewvc/llvm-project?rev=318702=rev Log: Revert 318668, which is associated with a broken patch Modified: clang-tools-extra/trunk/test/pp-trace/pp-trace-pragma-general.cpp

[PATCH] D40181: [libcxx] Allow to set locale on Windows.

mstorsjo added a comment. In order to make this work with MinGW (more or less), I had to change the `_LIBCPP_MSVCRT` into `_LIBCPP_MSVCRT_LIKE` both in `include/__locale` and in `include/__config` (where `_LIBCPP_LOCALE__L_EXTENSIONS` is defined). Normal mingw that uses msvcrt.dll doesn't have

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

efriedma added a comment. Oh, I see, for some silly reason there are actually *three* -mfloat-abi options: hard, soft, and softfp. hard means float instructions and a hard-float calling convention, soft means no floating-point and a soft-float convention, and softfp means float instructions

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

tra added a comment. Looks OK to me. I'll defer to gtbercea@ for the final stamp. Comment at: test/Driver/openmp-offload-gpu.c:34 +/// Check cubin file generation and usage by nvlink when toolchain has BindArchAction +// RUN: %clang -### -no-canonical-prefixes -target

[PATCH] D35470: [libcxx] Implement std::to_address for C++20

glenjofe added inline comments. Comment at: test/std/utilities/memory/pointer.conversion/to_address.pass.cpp:119 +ASSERT_NOEXCEPT(std::to_address(p4)); +assert(std::to_address(p4) == ); +} EricWF wrote: > Shouldn't one of these tests hit a non-noexcept

r318698 - Revert r318669/318694

Author: erichkeane Date: Mon Nov 20 13:46:29 2017 New Revision: 318698 URL: http://llvm.org/viewvc/llvm-project?rev=318698=rev Log: Revert r318669/318694 Broke some libclang tests, so reverting for now. Removed: cfe/trunk/test/Driver/Inputs/stdc-predef/

[PATCH] D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good, thanks for the heads up Repository: rL LLVM https://reviews.llvm.org/D38445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

Hahnfeld updated this revision to Diff 123649. Hahnfeld marked 13 inline comments as done. Hahnfeld added a comment. Address reviewers' comments. https://reviews.llvm.org/D40250 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains/Clang.cpp

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

Hahnfeld added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5341-5344 +if (const auto *OA = dyn_cast(JA.getInputs()[I])) { + OA->doOnEachDependence( + [&](Action *, const ToolChain *TC, const char *) { CurTC = TC; }); +} tra

r318697 - Resubmit "Refactor debuginfo-tests" again.

Author: zturner Date: Mon Nov 20 13:41:36 2017 New Revision: 318697 URL: http://llvm.org/viewvc/llvm-project?rev=318697=rev Log: Resubmit "Refactor debuginfo-tests" again. This was reverted due to the tests being run twice on some build bots. Each run had a slightly different configuration due

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

asb added subscribers: llvm-commits, asb. asb added a comment. It would have been much cleaner if it worked as @efriedma suggests and -mfloat-abi was only concerned with the ABI (as its name would suggest), but sadly the -mfloat-abi=soft option seems to be defined in GCC to control more than

[PATCH] D40267: WG14 DR496

aaron.ballman created this revision. This DR was discussed at the WG14 meeting in Albuquerque and the outcome was that member-designator wording could safely be replaced by "subobject", which will be the Proposed Technical Corrigendum coming out of that meeting. This patch removes the

[PATCH] D40261: Add default argument AST matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor nit with the comments leading to the public docs, LGTM! Comment at: include/clang/ASTMatchers/ASTMatchers.h:5825-5826 +/// \code +/// void

[PATCH] D40144: Implement `std::launder`

tcanens added inline comments. Comment at: include/new:260 +static_assert (!is_function<_Tp>::value, "can't launder functions" ); +static_assert (!is_same_v>, "can't launder cv-void" ); +#ifdef _LIBCPP_COMPILER_HAS_BUILTIN_LAUNDER

[PATCH] D40261: Add default argument AST matcher

juliehockett updated this revision to Diff 123646. juliehockett added a comment. Updated Registry.cpp to include new matcher. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

rengolin added a comment. Wasn't that the mess about -mfpu=softfp? https://reviews.llvm.org/D40256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] Ensure std::getline always 0-terminates string.

On Nov 20, 2017, at 11:32, Reimar Döffinger wrote: > > On Mon, Nov 20, 2017 at 11:02:13AM -0800, Volodymyr Sapsai wrote: >>> catch (...) >>> { >>> +if (__n > 0) >>> +*__s = char_type(); >>> this->__set_badbit_and_consider_rethrow();

r318694 - Include test files for rL318668

Author: erichkeane Date: Mon Nov 20 13:15:01 2017 New Revision: 318694 URL: http://llvm.org/viewvc/llvm-project?rev=318694=rev Log: Include test files for rL318668 Forgotten when doing my SVN commit. Added: cfe/trunk/test/Driver/Inputs/stdc-predef/

[PATCH] D40144: Implement `std::launder`

mclow.lists updated this revision to Diff 123644. mclow.lists added a comment. Made an internal function `__launder` which is not c++17 specific. Fixed some wording for the standard asserts. https://reviews.llvm.org/D40144 Files: include/__config include/new

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

efriedma added a comment. -mfpu controls what floating-point/vector instructions the compiler generates. -mfloat-abi controls whether floating-point arguments to functions are passed in floating-point registers. These are completely independent, and we need to support using both of them

[PATCH] D40257: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add

phosek updated this revision to Diff 123640. Repository: rL LLVM https://reviews.llvm.org/D40257 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -653,7 +653,7 @@

[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

aaron.ballman added a comment. You should add a test case that demonstrates code which would otherwise trigger an analysis-based warning but doesn't due to disabling all warnings. https://reviews.llvm.org/D40242 ___ cfe-commits mailing list

[PATCH] D40261: Add default argument AST matcher

aaron.ballman added a comment. You should also update lib\ASTMatchers\Dynamic\Registry.cpp to have the new matcher (be sure to keep the new matcher alphabetized as well). https://reviews.llvm.org/D40261 ___ cfe-commits mailing list

[PATCH] D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization.

EricWF added a comment. @rsmith Ping. https://reviews.llvm.org/D29930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r318690 - Fix std::string::data() symbol during library build.

Author: ericwf Date: Mon Nov 20 12:23:27 2017 New Revision: 318690 URL: http://llvm.org/viewvc/llvm-project?rev=318690=rev Log: Fix std::string::data() symbol during library build. The non-const data() member of std::string is only exposed in C++17 and beyond. However std::string is externally

[PATCH] D40181: [libcxx] Allow to set locale on Windows.

mstorsjo added a comment. In https://reviews.llvm.org/D40181#930602, @EricWF wrote: > This LGTM. I would love if another party interested in Windows could review > it though. I can test this in a MinGW context and see if what it uses happens to be available there or not.

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

tcanens added inline comments. Comment at: include/__functional_base:377 +inline _LIBCPP_INLINE_VISIBILITY +_Tp& __lvref_bind(_Tp& r) _NOEXCEPT { return r; } + I'd make these member functions of a class template, to avoid having to reason about partial ordering

[PATCH] D40181: [libcxx] Allow to set locale on Windows.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This LGTM. I would love if another party interested in Windows could review it though. https://reviews.llvm.org/D40181 ___ cfe-commits mailing

[PATCH] D40261: Add default argument AST matcher

juliehockett created this revision. Herald added a subscriber: klimek. Adds AST matcher for declarations with default arguments. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D35470: [libcxx] Implement std::to_address for C++20

EricWF added inline comments. Comment at: test/std/utilities/memory/pointer.conversion/to_address.pass.cpp:119 +ASSERT_NOEXCEPT(std::to_address(p4)); +assert(std::to_address(p4) == ); +} Shouldn't one of these tests hit a non-noexcept function?

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

EricWF added a comment. Also, you're lacking tests for `noexcept` and the deduction guide. https://reviews.llvm.org/D40259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. I would much rather take this change in all dialects except for C++03. Comment at: include/__functional_base:398 +!is_same<__uncvref_t<_Up>,

Re: [PATCH] Ensure std::getline always 0-terminates string.

On Mon, Nov 20, 2017 at 11:02:13AM -0800, Volodymyr Sapsai wrote: > > catch (...) > > { > > +if (__n > 0) > > +*__s = char_type(); > > this->__set_badbit_and_consider_rethrow(); > > } > > or maybe something else? That one (note that the

[PATCH] D40218: [Clang] Add __builtin_launder

EricWF updated this revision to Diff 123627. EricWF added a comment. - Improve quality of tests. - Format code. https://reviews.llvm.org/D40218 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td lib/AST/ExprConstant.cpp lib/CodeGen/CGBuiltin.cpp

  1   2   >