ilya-biryukov created this revision.
Herald added a subscriber: mgorny.
It will be used to pass around things like Logger and Tracer throughout
clangd classes.
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
clangd/Context.h
clangd/TypedValueMap.h
Author: d0k
Date: Mon Nov 27 04:48:26 2017
New Revision: 319022
URL: http://llvm.org/viewvc/llvm-project?rev=319022=rev
Log:
Make helper function static. NFC.
Modified:
clang-tools-extra/trunk/clangd/Protocol.cpp
Modified: clang-tools-extra/trunk/clangd/Protocol.cpp
URL:
hokein accepted this revision.
hokein added a comment.
LGTM.
https://reviews.llvm.org/D40487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov planned changes to this revision.
ilya-biryukov added inline comments.
Comment at: clangd/JSONRPCDispatcher.h:80
+ // Ctx must be before Tracer!
Context Ctx;
JSONOutput
This is still wrong, `Context` is used by `Tracer` internally and
Author: krasimir
Date: Mon Nov 27 05:23:45 2017
New Revision: 319024
URL: http://llvm.org/viewvc/llvm-project?rev=319024=rev
Log:
[clang-format] Add option to group multiple #include blocks when sorting
includes
Summary:
This patch allows grouping multiple #include blocks together and sort all
malaperle requested changes to this revision.
malaperle added a comment.
This revision now requires changes to proceed.
There were some things I missed, sorry about that!
Comment at: clangd/main.cpp:1
+#define MACRO 1
+namespace ns1 {
This files needs to be
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D40230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: alexfh
Date: Mon Nov 27 04:42:04 2017
New Revision: 319021
URL: http://llvm.org/viewvc/llvm-project?rev=319021=rev
Log:
[clang-tidy] readability-non-const-parameter fixes should update all
declarations
Fixes http://llvm.org/PR34410.
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319024: [clang-format] Add option to group multiple #include
blocks when sorting… (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D40288?vs=123924=124361#toc
Repository:
rL
Author: alexfh
Date: Mon Nov 27 07:17:13 2017
New Revision: 319034
URL: http://llvm.org/viewvc/llvm-project?rev=319034=rev
Log:
[clang-tidy] Fix link error in clang-tidy after the recent check renames.
Modified:
clang-tools-extra/trunk/clang-tidy/cert/CMakeLists.txt
Modified:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D40487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG, if this still works under Python 2.
https://reviews.llvm.org/D37482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bkramer requested changes to this revision.
bkramer added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/Context.h:79
+/// Otherwise returns an empty Context.
+Context ();
+
This is a giant code smell. If we want the context
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clangd/Trace.h:41
+ /// Context.
static PtrKey CtxKey;
luckygeck wrote:
> This is a (1)static non-pod member in an (2) interface. Is it really a good
> idea?
Author: xazax
Date: Mon Nov 27 07:05:24 2017
New Revision: 319033
URL: http://llvm.org/viewvc/llvm-project?rev=319033=rev
Log:
[clang-tidy] Misc redundant expressions check updated for overloaded operators
Patch by: Lilla Barancsuk
Differential Revision: https://reviews.llvm.org/D39243
Author: vedranm
Date: Mon Nov 27 03:14:06 2017
New Revision: 319017
URL: http://llvm.org/viewvc/llvm-project?rev=319017=rev
Log:
configure.py: Add gfx900 (Vega, Raven)
Sort amdgcn-- and amdgcn--amdhsa in a consistent way.
Modified:
libclc/trunk/configure.py
Modified:
Author: AlexeySotkin
Date: Mon Nov 27 01:14:17 2017
New Revision: 319011
URL: http://llvm.org/viewvc/llvm-project?rev=319011=rev
Log:
[OpenCL] Add extensions cl_intel_subgroups and cl_intel_subgroups_short
Reviewers: yaxunl, Anastasia, bader
Reviewed By: Anastasia, bader
Subscribers:
luckygeck added inline comments.
Comment at: clangd/Trace.h:41
+ /// Context.
static PtrKey CtxKey;
This is a (1)static non-pod member in an (2) interface. Is it really a good
idea? If we plan to have only one ctxkey, then maybe let's make it not bound to
Hahnfeld added reviewers: tra, jlebar.
Hahnfeld added a comment.
The change looks good in general and is small enough and last in the candidates
list to not break working setups.
What concerns me is that we have to do the same for every distribution (I know
that Arch Linux for example has CUDA
ilya-biryukov updated this revision to Diff 124371.
ilya-biryukov added a comment.
- Fixed a typo.
https://reviews.llvm.org/D40489
Files:
clangd/Trace.cpp
clangd/Trace.h
Index: clangd/Trace.h
===
--- clangd/Trace.h
+++
ilya-biryukov created this revision.
https://reviews.llvm.org/D40488
Files:
clangd/ClangdUnit.cpp
clangd/JSONRPCDispatcher.cpp
clangd/JSONRPCDispatcher.h
clangd/ProtocolHandlers.cpp
clangd/Trace.cpp
clangd/Trace.h
clangd/tool/ClangdMain.cpp
unittests/clangd/TraceTests.cpp
Index:
malaperle added a comment.
@Nebiroth , Will this be compatible with your patch to change
CompilationDatabase at runtime? https://reviews.llvm.org/D39571
https://reviews.llvm.org/D40450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov created this revision.
https://reviews.llvm.org/D40486
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/ClangdUnitStore.cpp
clangd/ClangdUnitStore.h
clangd/GlobalCompilationDatabase.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319026: [lit] Set shlibpath_var on Solaris (authored by
fedor.sergeev).
Changed prior to commit:
https://reviews.llvm.org/D39640?vs=121626=124363#toc
Repository:
rL LLVM
Author: fedor.sergeev
Date: Mon Nov 27 05:33:19 2017
New Revision: 319026
URL: http://llvm.org/viewvc/llvm-project?rev=319026=rev
Log:
[lit] Set shlibpath_var on Solaris
Summary:
During make check-all on Solaris, lit complains
llvm-lit:
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
Please add test cases for this new functionality.
Comment at: lib/CodeGen/TargetInfo.cpp:7665
+static llvm::APSInt getConstexprInt(const Expr *E,
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
(Sorry for losing track of this and the delay!)
Repository:
rL LLVM
https://reviews.llvm.org/D39706
___
cfe-commits mailing list
bkramer added a comment.
There are a few users of the C++ API out there, do we have migration path for
them?
https://reviews.llvm.org/D40439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov created this revision.
Introduced begin_event, end_event and instant_event instead of a
string phase name.
https://reviews.llvm.org/D40489
Files:
clangd/Trace.cpp
clangd/Trace.h
Index: clangd/Trace.h
===
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE319023: [clang-tidy] Move checks from misc- to
performance- (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D40487?vs=124356=124359#toc
Repository:
rCTE Clang Tools Extra
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:79
+/// Otherwise returns an empty Context.
+Context ();
+
bkramer wrote:
> This is a giant code smell. If we want the context route, please pass
> contexts everywhere. I really don't want this
alexfh added a comment.
Is anything holding this patch?
https://reviews.llvm.org/D39803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vvassilev
Date: Mon Nov 27 07:32:00 2017
New Revision: 319037
URL: http://llvm.org/viewvc/llvm-project?rev=319037=rev
Log:
Constify. NFC.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Sema.h
URL:
klimek added a comment.
Restructured to make the invariants clearer based on a chat with Krasimir.
https://reviews.llvm.org/D40310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Mon Nov 27 08:17:19 2017
New Revision: 319042
URL: http://llvm.org/viewvc/llvm-project?rev=319042=rev
Log:
Fix failure on C++03 bots
Modified:
libcxx/trunk/include/ostream
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.special/io.fail.cpp
Author: abataev
Date: Mon Nov 27 08:54:08 2017
New Revision: 319046
URL: http://llvm.org/viewvc/llvm-project?rev=319046=rev
Log:
[OPENMP] Improve handling of cancel directives in target-based
constructs, NFC.
Improved handling of cancel|cancellation point directives inside
target-based for
benhamilton created this revision.
Herald added a subscriber: cfe-commits.
We want to automatically copy the appropriate mailing list
for review requests to the libc++abi repository.
For context, see the proposal and discussion here:
mcrosier added a comment.
Am I correct in assuming this is going to be a problem for Falkor and Saphira
as well? If so, can you add solutions for those as well? Cortex-a57 should be
good enough for those targets as well.
https://reviews.llvm.org/D40476
NoQ added a comment.
Sorry, i wanted to quickly look at why this thing is lvalue, but this didn't
seem to be happening, so i guess i'd just commit for now.
Repository:
rL LLVM
https://reviews.llvm.org/D39800
___
cfe-commits mailing list
Hahnfeld added a comment.
In that case I don't see a way to be "clever", so we have to add the static
candidate. I'll let @tra or @jlebar have a final look.
https://reviews.llvm.org/D40453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pirama updated this revision to Diff 124410.
pirama added a comment.
Address review comments.
https://reviews.llvm.org/D40476
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/as-mcpu.c
Index: test/Driver/as-mcpu.c
===
---
lebedev.ri added a comment.
How about also matching on call to functions with no-return attribute?
i.e.
[[noreturn]] my_die();
void do_stuff();
void fn(int x) {
if(!x)
my_die();
else // <- since `my_die()` will never return, `else` is not really needed.
do_stuff();
pirama updated this revision to Diff 124417.
pirama added a comment.
Normalize falkor and saphira as well.
https://reviews.llvm.org/D40476
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/as-mcpu.c
Index: test/Driver/as-mcpu.c
klimek updated this revision to Diff 124381.
klimek added a comment.
Restructure based on code review feedback.
https://reviews.llvm.org/D40310
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTest.cpp
benhamilton created this revision.
Herald added a subscriber: cfe-commits.
We want to automatically copy the appropriate mailing list
for review requests to the libc++ repository.
For context, see the proposal and discussion here:
sepavloff created this revision.
Herald added a subscriber: JDevlieghere.
If a source file extensively uses templates, resulting LLVM IR may have
types with huge names. It may occur if a record type is defined in a class.
In this case its type name contains all declaration contexts and, if a
Author: alexfh
Date: Mon Nov 27 09:59:26 2017
New Revision: 319062
URL: http://llvm.org/viewvc/llvm-project?rev=319062=rev
Log:
[clang-tidy] Rename qualified references to check class + support inconsistent
names
Modified:
clang-tools-extra/trunk/clang-tidy/rename_check.py
Modified:
benhamilton created this revision.
We want to automatically copy cfe-commits@ on review requests
to the clang repository.
Similar to https://reviews.llvm.org/D40179, I set up a new Diffusion repository
with callsign
"C" for clang:
https://reviews.llvm.org/source/clang/
This explicitly updates
malcolm.parsons created this revision.
Herald added subscribers: cfe-commits, xazax.hun, klimek.
The readability-else-after-return check was not warning about
an else after a throw of an exception that had arguments that needed
to be cleaned up.
Repository:
rCTE Clang Tools Extra
Author: marshall
Date: Mon Nov 27 07:51:36 2017
New Revision: 319038
URL: http://llvm.org/viewvc/llvm-project?rev=319038=rev
Log:
Implement LWG#2948: unique_ptr does not define operator<< for stream output
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319055: [analyzer] pr34404: Fix a crash on modeling pointers
to indirect members. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D39800?vs=122087=124404#toc
Repository:
beanz added a comment.
@phosek, I would love to see compiler-rt fully refactored so that we target one
triple at a time always. I'd also love to see the clang driver refactored so
that the code to resolve paths to runtime libraries was shared so we follow the
same conventions across all driver
srhines added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:661
Arg *A;
-if ((A = Args.getLastArg(options::OPT_mcpu_EQ)) &&
-StringRef(A->getValue()).equals_lower("krait"))
- CmdArgs.push_back("-mcpu=cortex-a15");
-else
-
juliehockett updated this revision to Diff 124397.
juliehockett marked 7 inline comments as done.
juliehockett added a comment.
Added new tests and updated wording in warning.
https://reviews.llvm.org/D40108
Files:
clang-tidy/CMakeLists.txt
clang-tidy/fuchsia/CMakeLists.txt
Author: benhamilton
Date: Mon Nov 27 09:21:24 2017
New Revision: 319052
URL: http://llvm.org/viewvc/llvm-project?rev=319052=rev
Log:
[clang] Set up .arcconfig to point to new Diffusion C repository
Summary:
We want to automatically copy cfe-commits@ on review requests
to the clang repository.
Author: dergachev
Date: Mon Nov 27 09:31:16 2017
New Revision: 319055
URL: http://llvm.org/viewvc/llvm-project?rev=319055=rev
Log:
[analyzer] pr34404: Fix a crash on modeling pointers to indirect members.
We were crashing whenever a C++ pointer-to-member was taken, that was pointing
to a member
benhamilton added inline comments.
Comment at: clang-tidy/objc/AvoidSpinlockCheck.cpp:22-24
+ if (!getLangOpts().ObjC1 && !getLangOpts().ObjC2) {
+return;
+ }
Why? `OSSpinLock()` calls should also be avoided in C++.
I think you should remove this.
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D40258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D40280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexfh added a comment.
Is anything holding this patch?
https://reviews.llvm.org/D39800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: benhamilton
Date: Mon Nov 27 07:58:26 2017
New Revision: 319040
URL: http://llvm.org/viewvc/llvm-project?rev=319040=rev
Log:
[clang-tools-extra] Fix small typo in docs/ReleaseNotes.rst
Summary:
This is mainly a test diff to check the new Herald rule I
added in LLVM Phabricator to
Author: benhamilton
Date: Mon Nov 27 07:58:25 2017
New Revision: 319039
URL: http://llvm.org/viewvc/llvm-project?rev=319039=rev
Log:
[clang-tools-extra] Set up .arcconfig to point to new Diffusion CTE repository
Summary:
I'm testing out a new Diffusion repository `CTE`:
dcoughlin accepted this revision.
dcoughlin added a comment.
LGTM, but as noted inline you should update the new llvm_unreachable() to have
a more descriptive error message.
Do you have commit access or do you need someone to commit this for you?
Comment at:
Nebiroth updated this revision to Diff 124391.
Nebiroth marked an inline comment as done.
Nebiroth added a comment.
Herald added a subscriber: klimek.
Removed temporary test file
Updated test to account for read-access symbol verification
Repository:
rCTE Clang Tools Extra
srhines added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:660
+// of a cpu flag.
+Arg *A = Args.getLastArg(options::OPT_mcpu_EQ);
+if (A) {
Is it better to sink A into the if condition again?
Comment at:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319058: [analyzer] pr34766: Fix a crash on explicit
std::initializer_list constructor. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D39803?vs=122094=124406#toc
Nebiroth marked 12 inline comments as done.
Nebiroth added inline comments.
Comment at: test/clangd/did-change-configuration.test:33
+
luckygeck added inline comments.
Comment at: clangd/Trace.h:41
+ /// Context.
static PtrKey CtxKey;
ilya-biryukov wrote:
> luckygeck wrote:
> > This is a (1)static non-pod member in an (2) interface. Is it really a good
> > idea? If we plan to have only
inspirer added inline comments.
Comment at: clangd/FuzzyMatch.cpp:254
+ // Penalty: matching inside a segment (and previous char wasn't matched).
+ if (WordRole[W] == Tail && P && !Matched[P - 1][W - 1])
+S -= 3;
You need a third boolean dimension in your
sylvestre.ledru added a comment.
Debian packages don't update the PATH and we are aiming at providing packages
working out of the box.
In general, yeah, we have to do that for every distros... :/
https://reviews.llvm.org/D40453
___
cfe-commits
pirama updated this revision to Diff 124415.
pirama added a comment.
Sink 'Arg *' declaration.
https://reviews.llvm.org/D40476
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/as-mcpu.c
Index: test/Driver/as-mcpu.c
===
---
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/fuchsia-default-arguments.rst:6
+
+Warns if a function is declared or called with default arguments.
+
Please synchronize with text in Release Notes.
https://reviews.llvm.org/D40108
malcolm.parsons added a comment.
In https://reviews.llvm.org/D40505#936170, @lebedev.ri wrote:
> How about also matching on call to functions with no-return attribute?
Great idea!
But I'll keep this patch for just the throw bugfix.
Repository:
rCTE Clang Tools Extra
Wizard marked 4 inline comments as done.
Wizard added inline comments.
Comment at: clang-tidy/objc/CMakeLists.txt:4
add_clang_library(clangTidyObjCModule
+ AvoidSpinlockCheck.cpp
ForbiddenSubclassingCheck.cpp
benhamilton wrote:
> IMHO this is really a check
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D40329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev updated this revision to Diff 124430.
ABataev added a comment.
Added codegen for `distribute parallel for simd` construct.
https://reviews.llvm.org/D39457
Files:
docs/OpenMPSupport.rst
docs/index.rst
Index: docs/index.rst
benhamilton added a comment.
Thanks, looks good. Just one question about the test.
Comment at: test/clang-tidy/objc-avoid-spinlock.m:4
+typedef int OSSpinLock;
+void OSSpinlockTry(OSSpinLock *__lock) {}
+
Not sure why you declared (and defined?) this one but
jakehehrlich updated this revision to Diff 124422.
jakehehrlich added a comment.
This test was failing on windows machines. I'm hoping this change (adding
"_cc1" to "%clang") will resolve this because %clang_cc1 shouldn't behave any
differently on windows.
Repository:
rC Clang
juliehockett updated this revision to Diff 124421.
juliehockett marked an inline comment as done.
juliehockett added a comment.
Updating docs
https://reviews.llvm.org/D40108
Files:
clang-tidy/CMakeLists.txt
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/DefaultArgumentsCheck.cpp
benhamilton added inline comments.
Comment at: test/clang-tidy/objc-avoid-spinlock.m:4
+typedef int OSSpinLock;
+void OSSpinlockTry(OSSpinLock *__lock) {}
+
Wizard wrote:
> benhamilton wrote:
> > Not sure why you declared (and defined?) this one but not the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319077: Switch CPU names not recognized by GNU assembler
(authored by pirama).
Repository:
rL LLVM
https://reviews.llvm.org/D40476
Files:
cfe/trunk/lib/Driver/ToolChains/Gnu.cpp
Author: marshall
Date: Mon Nov 27 11:03:30 2017
New Revision: 319074
URL: http://llvm.org/viewvc/llvm-project?rev=319074=rev
Log:
Fix PR#35438 - bitset constructor does not zero unused bits
Modified:
libcxx/trunk/include/bitset
phosek added a comment.
Can you please take a look at this one as well (this one is Clang, the other
one was LLVM)?
Repository:
rL LLVM
https://reviews.llvm.org/D40257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
phosek created this revision.
Herald added subscribers: mgorny, dberris.
Don't link tests against libgcc when compiler-rt is being used.
Repository:
rL LLVM
https://reviews.llvm.org/D40513
Files:
test/CMakeLists.txt
test/lit.site.cfg.in
utils/libcxx/test/target_info.py
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319088: [CMake][Fuchsia] Disable terminfo database in
Fuchsia toolchain (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40329?vs=123875=124441#toc
Repository:
rL LLVM
Author: phosek
Date: Mon Nov 27 12:29:13 2017
New Revision: 319088
URL: http://llvm.org/viewvc/llvm-project?rev=319088=rev
Log:
[CMake][Fuchsia] Disable terminfo database in Fuchsia toolchain
It's used to determine whether terminal supports colors, but within LLVM
it's only used in handful of
Wizard updated this revision to Diff 124448.
Wizard added a comment.
fix test
https://reviews.llvm.org/D40325
Files:
clang-tidy/objc/AvoidSpinlockCheck.cpp
clang-tidy/objc/AvoidSpinlockCheck.h
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/ObjCTidyModule.cpp
docs/ReleaseNotes.rst
Wizard marked an inline comment as done.
Wizard added inline comments.
Comment at: test/clang-tidy/objc-avoid-spinlock.m:4
+typedef int OSSpinLock;
+void OSSpinlockTry(OSSpinLock *__lock) {}
+
benhamilton wrote:
> Not sure why you declared (and defined?) this
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D40257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bruno added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:954
if (DstTy->isFloatingPointTy()) {
- if (!CGF.getContext().getLangOpts().HalfArgsAndReturns)
+ if (CGF.getContext().getTargetInfo().useFP16ConversionIntrinsics())
return
bcain added a comment.
I'd like to understand/resurrect this change, so I'll try to summarize. Please
correct this as appropriate:
1. We got here because libc++ has code that triggers a warning for some targets
(those whose `int` and `long` have the same size).
2. This change would "move" the
arphaman created this revision.
This patch extends libclang by allowing it to record parsing operations to a
temporary JSON file. The file is deleted after parsing succeeds. When a crash
happens during parsing, the file is preserved and the client will be able to
use it to generate a
rnk added a comment.
It's not clear to me that this abbreviation functionality should live in
Support. Clang probably wants enough control over this (assuming we're doing
it) that the logic should live in clang.
I also think we might want to try solving this a completely different way: just
mcrosier added a comment.
In https://reviews.llvm.org/D40476#936372, @pirama wrote:
> Thanks for the review. Now let's just hope the windows bots stay happy :)
Actually, I just checked and it looks like falkor and saphira were both added
as of a few weeks ago. I'll revert this part of the
efriedma added inline comments.
Comment at: test/Driver/arm-mfpu.c:301
+// RUN: | FileCheck --check-prefix=CHECK-SOFT-ABI-FP %s
+// R-UN: %clang -target armv4-linux-gnueabi -mfloat-abi=soft -mfpu=none %s
-### -c 2>&1 \
+// R-UN: | FileCheck --check-prefix=CHECK-SOFT-ABI-FP
bcain added a comment.
I think some of the `XFAIL: availability` may be wrong here. I'd submit a
patch, but it's not clear to me what the appropriate fix is.
Comment at: libcxx/trunk/utils/libcxx/test/config.py:400
+if self.use_system_cxx_lib or
yvvan added inline comments.
Comment at: tools/libclang/CIndex.cpp:6888
+ const SourceLocation fixedEnd =
+ RefNameRange.getEnd().getLocWithOffset(-1);
+ RefNameRange = SourceRange(RefNameRange.getBegin(), fixedEnd);
nik wrote:
> yvvan wrote:
Hello everyone,
Below are some buildbot numbers for the last week of 11/19/2017 -
11/25/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
Hello everyone,
Below are some buildbot numbers for the week of 11/12/2017 - 11/18/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
ro added a comment.
It's been another two weeks, so: could someone please commit this for me?
Thanks.
https://reviews.llvm.org/D39640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
1 - 100 of 141 matches
Mail list logo
