[clang-tools-extra] r324363 - [clangd] Fixed a bug in the new threading implementation.

Author: ibiryukov Date: Tue Feb 6 09:22:58 2018 New Revision: 324363 URL: http://llvm.org/viewvc/llvm-project?rev=324363=rev Log: [clangd] Fixed a bug in the new threading implementation. This should fix the buildbots. Modified: clang-tools-extra/trunk/clangd/Threading.cpp Modified:

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg marked 4 inline comments as done. massberg added a comment. Thanks for the comments! I double-checked that the renaming went well and hope that I haven't missed anything this time ... https://reviews.llvm.org/D42730 ___ cfe-commits

[PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

compnerd updated this revision to Diff 133030. compnerd added a comment. Add additional test, update docs Repository: rC Clang https://reviews.llvm.org/D42758 Files: docs/LanguageExtensions.rst lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/Parse/ParsePragma.cpp

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay added a comment. In https://reviews.llvm.org/D42895#998617, @yvvan wrote: > I feel quite ok about this patch. > > Can you please add unit-tests? Added // CHECK: [indexEntityReference]: kind: field | name: y | {{.*}} | loc: 70:5 | {{.*}} | role: ref write // CHECK:

[libclc] r324372 - vstore_half: Consolidate declarations

Author: jvesely Date: Tue Feb 6 10:44:41 2018 New Revision: 324372 URL: http://llvm.org/viewvc/llvm-project?rev=324372=rev Log: vstore_half: Consolidate declarations Add support for rounding suffix Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r324371 - vstore_half: Add support for custom rounding functions

Author: jvesely Date: Tue Feb 6 10:44:39 2018 New Revision: 324371 URL: http://llvm.org/viewvc/llvm-project?rev=324371=rev Log: vstore_half: Add support for custom rounding functions Add another layer of indirection This will be used for specific rounding modes Reviewer: Jeroen Ketema

[libclc] r324373 - Add vstore_half_rtz implementation

Author: jvesely Date: Tue Feb 6 10:44:43 2018 New Revision: 324373 URL: http://llvm.org/viewvc/llvm-project?rev=324373=rev Log: Add vstore_half_rtz implementation Passes CTS on carrizo Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified:

[libclc] r324370 - vstore_half: Make sure the helper function is always inline

Author: jvesely Date: Tue Feb 6 10:44:35 2018 New Revision: 324370 URL: http://llvm.org/viewvc/llvm-project?rev=324370=rev Log: vstore_half: Make sure the helper function is always inline Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified:

[libclc] r324374 - Add vstore_half_rtn implementation

Author: jvesely Date: Tue Feb 6 10:44:45 2018 New Revision: 324374 URL: http://llvm.org/viewvc/llvm-project?rev=324374=rev Log: Add vstore_half_rtn implementation Passes CTS on carrizo Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified:

r324377 - Pass around function pointers as CGCallees, not bare llvm::Value*s.

Author: rjmccall Date: Tue Feb 6 10:52:44 2018 New Revision: 324377 URL: http://llvm.org/viewvc/llvm-project?rev=324377=rev Log: Pass around function pointers as CGCallees, not bare llvm::Value*s. The intention here is to make it easy to write frontend-assisted CFI systems by propagating extra

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

Typz added a comment. Indeed, I have yet find more precisely documented coding rules which require this format, but I thought I could at least address the non-precise aspect of the patch itself in the mean-time. https://reviews.llvm.org/D32525

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

krasimir added a comment. I don't understand why do we introduce an enum option if we are keeping the default behavior for Google style. IMO we should have a single behavior for any style and enforce it. Repository: rC Clang https://reviews.llvm.org/D42650

[PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Just 1 format question, otherwise Looks good. Comment at: docs/LanguageExtensions.rst:2732 + +The ``#pragma comment(lib, ...)`` directive is supported on all ELF

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark updated this revision to Diff 133034. simark added a comment. Fix assertion about parsing a document that is not open As found by Ilya, the getActiveFiles method would return the documents that were previously opened and then closed. Repository: rCTE Clang Tools Extra

[libclc] r324375 - Add vstore_half_rtp implementation

Author: jvesely Date: Tue Feb 6 10:44:47 2018 New Revision: 324375 URL: http://llvm.org/viewvc/llvm-project?rev=324375=rev Log: Add vstore_half_rtp implementation Passes CTS on carrizo Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified:

[libclc] r324376 - Add vstore_half_rte implementation

Author: jvesely Date: Tue Feb 6 10:44:50 2018 New Revision: 324376 URL: http://llvm.org/viewvc/llvm-project?rev=324376=rev Log: Add vstore_half_rte implementation Passes CTS on carrizo Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified:

[PATCH] D42945: [libc++] Fix misleading indentation.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Committed as revision 324378 Repository: rCXX libc++ https://reviews.llvm.org/D42945 ___ cfe-commits mailing list

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133050. MaskRay added a comment. Simplify Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h test/Index/index-decls.m test/Index/index-refs.cpp test/Index/index-subscripting-literals.m

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

benhamilton marked an inline comment as done. benhamilton added a comment. > I don't understand why do we introduce an enum option if we are keeping the > default behavior for Google style. IMO we should have a single behavior for > any style and enforce it. https://reviews.llvm.org/D42708

[PATCH] D42864: [clang-format] Add more tests for Objective-C 2.0 generic alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rC324364: [clang-format] Add more tests for Objective-C 2.0 generic alignment (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42864?vs=132654=133036#toc

[PATCH] D42864: [clang-format] Add more tests for Objective-C 2.0 generic alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL324364: [clang-format] Add more tests for Objective-C 2.0 generic alignment (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133038. MaskRay added a comment. Update c-index-test.c and clang/test/Index tests Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h test/Index/index-decls.m test/Index/index-refs.cpp

[PATCH] D42945: [libc++] Fix misleading indentation.

mclow.lists added a comment. The second change is not quite right. There's a couple of lines that need indentation changes. Phab is not really good about changes like this. "This file was changed only by adding or removing whitespace" I'll just make these changes myself - thanks for calling

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 133008. devnexen added a comment. Both Linux/Darwin unit tests passed. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/Driver/ToolChains/FreeBSD.cpp

[PATCH] D42640: [clangd] Prototype: collect symbol #include & insert #include in global code completion.

ioeric added a comment. Thanks for the comments! I addressed comments in the symbol collect part (I think?). Will add tests in a followup patch. Comment at: clangd/index/HeaderMapCollector.h:48 + // A map from header patterns to header names. + // The header names are not

[PATCH] D42640: [clangd] Prototype: collect symbol #include & insert #include in global code completion.

ioeric added a comment. Thanks for the comments! I have addressed comments in the symbol collect side (I think?). Will add tests in a followup patch. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42640 ___ cfe-commits mailing

[PATCH] D42972: Look for 32-bit libraries in /usr/lib32 for MIPS O32 on FreeBSD.

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM, though a test case would be nice (could be added to `tools/clang/test/Driver/freebsd.c`) Repository: rC Clang https://reviews.llvm.org/D42972

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 133027. massberg edited the summary of this revision. massberg added a comment. Addressed comments and renamed test to modernize-deprecated-functional https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/CMakeLists.txt

[PATCH] D42964: [clangd] Add Revision field to Symbol.

sammccall added a comment. Discussed offline a bit: it's not clear that this field is going to be generally useful - we don't have a plan to read this from open-source code. (Google's internal index wants to be able to individually version symbols for distributed-system reasons, but we can add

[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

mikhail.ramalho created this revision. mikhail.ramalho added reviewers: arphaman, rsmith. Herald added a subscriber: cfe-commits. Small change on how the USRGen code prints the location. The patch fixes an issue when there are #line directives or linemarkes in the file, e.g.: #line 3 int

[clang-tools-extra] r324354 - [clangd] Remove unused variable. NFC

Author: ioeric Date: Tue Feb 6 07:27:43 2018 New Revision: 324354 URL: http://llvm.org/viewvc/llvm-project?rev=324354=rev Log: [clangd] Remove unused variable. NFC Modified: clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp Modified: clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp

[PATCH] D42969: [Sema] Fix decltype of static data members

miyuki created this revision. miyuki added reviewers: faisalv, rsmith. miyuki edited the summary of this revision. According to the C++11 standard [dcl.type.simple]p4: The type denoted by decltype(e) is defined as follows: - if e is an unparenthesized id-expression or an unparenthesized

[PATCH] D42915: [clangd] Use URIs in index symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324358: [clangd] Use URIs in index symbols. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42915 Files:

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42915: [clangd] Use URIs in index symbols.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: unittests/clangd/SymbolCollectorTests.cpp:280 runSymbolCollector(Header.code(), /*Main=*/""); - EXPECT_THAT(Symbols, -

r324362 - [analyzer] [tests] Show function name in CmpRuns output

Author: george.karpenkov Date: Tue Feb 6 09:22:09 2018 New Revision: 324362 URL: http://llvm.org/viewvc/llvm-project?rev=324362=rev Log: [analyzer] [tests] Show function name in CmpRuns output Combined with enabled flag for stable filenames, this greatly simplifies finding the offending report.

r324364 - [clang-format] Add more tests for Objective-C 2.0 generic alignment

Author: benhamilton Date: Tue Feb 6 10:01:47 2018 New Revision: 324364 URL: http://llvm.org/viewvc/llvm-project?rev=324364=rev Log: [clang-format] Add more tests for Objective-C 2.0 generic alignment Summary: In r236412, @djasper added a comment: // FIXME: We likely want to do this for

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133051. MaskRay added a comment. . Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h test/Index/index-decls.m test/Index/index-refs.cpp test/Index/index-subscripting-literals.m

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values

erichkeane added a comment. LLVM patch here: https://reviews.llvm.org/D42979 Repository: rC Clang https://reviews.llvm.org/D42978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values

erichkeane created this revision. erichkeane added reviewers: aaron.ballman, craig.topper, echristo. Herald added subscribers: fedor.sergeev, kbarton, aheejin, kristof.beyls, jgravelle-google, sbc100, javed.absar, nhaehnle, nemanjai, sdardis, dylanmckay, jyknight, dschuff, jfb, aemerson,

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

benhamilton requested changes to this revision. benhamilton added a comment. This revision now requires changes to proceed. Can you add test cases for non-plural acronyms in the middle of the string and plural acronyms at the start/end of the string, please? Comment at:

[libcxx] r324378 - Fix misleading indentation; replace a couple of NULLs with nullptr. Resolves https://reviews.llvm.org/D42945 ; thanks to Bruce Mitchener for the patch.

Author: marshall Date: Tue Feb 6 10:58:05 2018 New Revision: 324378 URL: http://llvm.org/viewvc/llvm-project?rev=324378=rev Log: Fix misleading indentation; replace a couple of NULLs with nullptr. Resolves https://reviews.llvm.org/D42945 ; thanks to Bruce Mitchener for the patch. Modified:

[clang-tools-extra] r324382 - [clangd] Attempt to unbreak windows buildbots.

Author: ibiryukov Date: Tue Feb 6 11:09:44 2018 New Revision: 324382 URL: http://llvm.org/viewvc/llvm-project?rev=324382=rev Log: [clangd] Attempt to unbreak windows buildbots. Some buildbots are breaking on trace.test due to using Linux's path separators. This commit should unbreak them.

[PATCH] D42942: [clangd] Collect definitions when indexing.

ioeric added a comment. looks good Comment at: clangd/index/Index.h:25 struct SymbolLocation { // The absolute path of the source file where a symbol occurs. It might be worth mentioning here whether the range covers the entire declaration/definition

[PATCH] D42942: [clangd] Collect definitions when indexing.

hokein added a comment. I like where the patch is going now. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67 + // XXX this is just to make running the tool fast during dev! + bool BeginInvocation(CompilerInstance ) override { +const

[PATCH] D42913: [clangd] Fix incorrect file path for symbols defined by the compile command-line option.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324328: [clangd] Fix incorrect file path for symbols defined by the compile command… (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

Re: r323904 - [clang-format] Align preprocessor comments with #

Merged in r324329. On Wed, Jan 31, 2018 at 9:05 PM, Mark Zeren via cfe-commits wrote: > Author: mzeren-vmw > Date: Wed Jan 31 12:05:50 2018 > New Revision: 323904 > > URL: http://llvm.org/viewvc/llvm-project?rev=323904=rev > Log: > [clang-format] Align preprocessor

Re: r324246 - [clang-format] Re-land: Fixup #include guard indents after parseFile()

Merged to 6.0 in r324331. On Mon, Feb 5, 2018 at 4:59 PM, Mark Zeren via cfe-commits wrote: > Author: mzeren-vmw > Date: Mon Feb 5 07:59:00 2018 > New Revision: 324246 > > URL: http://llvm.org/viewvc/llvm-project?rev=324246=rev > Log: > [clang-format] Re-land: Fixup

[PATCH] D42742: [clangd] Use pthread instead of thread_local to support more runtimes.

FireBurn added a comment. This breaks compilation for me on Gentoo's clang-.ebuild The following patch fixes things for me commit a4c071b16bbbc84bbb96d90b51bed8a12127 (HEAD -> master) Author: Mike Lothian Date: Tue Feb 6 09:55:41 2018 +

[PATCH] D42915: [clangd] Use URIs in index symbols.

ioeric updated this revision to Diff 132958. ioeric marked 2 inline comments as done. ioeric added a comment. - Make URIScheme customizable in SymbolCollector. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42915 Files: clangd/index/Index.cpp clangd/index/Index.h

[PATCH] D42915: [clangd] Use URIs in index symbols.

ioeric added inline comments. Comment at: clangd/index/Index.h:27 + // The URI of the source file where a symbol occurs. + llvm::StringRef FileUri; // The 0-based offset to the first character of the symbol from the beginning sammccall wrote: > nit:

[PATCH] D42915: [clangd] Use URIs in index symbols.

sammccall added a comment. Great, this all makes sense. I think we can/should make the scheme selection a bit more robust (we shouldn't crash if we get unexpected filenames). And... Uri or URI (I really think this is a usability issue - i had a scarring experience with a codebase that couldn't

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

Typz updated this revision to Diff 132963. Typz added a comment. Split the option into 3 separate options: SpaceBeforeCtorInitializerColon, SpaceBeforeInheritanceColon and SpaceBeforeRangeBasedForLoopColon. This makes each option clearer and more consistent, with no ambiguities due to

[PATCH] D42727: [clang-format] Adds space around angle brackets in text protos

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Repository: rC Clang https://reviews.llvm.org/D42727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41102: Setup clang-doc frontend framework

Athosvk added inline comments. Comment at: tools/clang-doc/ClangDocReporter.h:39 // Info for named types (parameters, members). struct NamedType { std::string Type; Storing the type information seems more suitable than storing just the name and type as a

[PATCH] D42573: [clangd] The new threading implementation

ilya-biryukov updated this revision to Diff 132967. ilya-biryukov marked 21 inline comments as done. ilya-biryukov added a comment. - Renamed File to AST. - Introduced startTask(). - Moved small methods of ASTWorkerHandle to have inline definitions. - Removed constructor of FileData. - Replaced

[PATCH] D42573: [clangd] The new threading implementation

ilya-biryukov added inline comments. Comment at: clangd/ASTWorker.cpp:102 + // not waste time on it. + LastUpdateCF->cancel(); +} sammccall wrote: > ilya-biryukov wrote: > > sammccall wrote: > > > This strategy has some upsides: > > > - we

r324337 - [clang-format] Adds space around angle brackets in text protos

Author: krasimir Date: Tue Feb 6 03:34:34 2018 New Revision: 324337 URL: http://llvm.org/viewvc/llvm-project?rev=324337=rev Log: [clang-format] Adds space around angle brackets in text protos Summary: This patch adds spaces around angle brackets in text proto Google style. Previously these were

[PATCH] D42727: [clang-format] Adds space around angle brackets in text protos

This revision was automatically updated to reflect the committed changes. Closed by commit rL324337: [clang-format] Adds space around angle brackets in text protos (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D42901: Test commit - fixing a comment.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Try committing it now! Repository: rC Clang https://reviews.llvm.org/D42901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132969. Herald added a subscriber: emaste. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/Driver/ToolChains/FreeBSD.cpp lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

miyuki added a comment. ping https://reviews.llvm.org/D42545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

miyuki added a comment. ping^3 https://reviews.llvm.org/D41992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42918: [clang-tidy] Update fuchsia-multiple-inheritance to check for templates

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D42918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42913: [clangd] Fix incorrect file path for symbols defined by the compile command-line option.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg Comment at: clangd/index/SymbolCollector.cpp:132 +// * symbols controlled and defined by a compile command-line option +// `-DName=foo`, the spelling

[PATCH] D42919: [clangd] Support simpler JSON-RPC stream parsing for lit tests.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. LGTM Have we kept a lit test that uses content-length? It's unclear from the patch. Comment at: clangd/tool/ClangdMain.cpp:89 +static llvm::cl::opt Test( +"test", +

[PATCH] D42915: [clangd] Use URIs in index symbols.

ioeric added a comment. I was thinking about leaving URI scheme customization to the postprocessing phase, but you are right, it would be better to make the URI scheme extendable in SymbolCollector. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42915

[PATCH] D42919: [clangd] Support simpler JSON-RPC stream parsing for lit tests.

sammccall updated this revision to Diff 132960. sammccall marked an inline comment as done. sammccall added a comment. -test -> -lit-test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42919 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D42913: [clangd] Fix incorrect file path for symbols defined by the compile command-line option.

hokein updated this revision to Diff 132956. hokein edited the summary of this revision. hokein added a comment. Fix a typo Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42913 Files: clangd/index/SymbolCollector.cpp unittests/clangd/SymbolCollectorTests.cpp Index:

[clang-tools-extra] r324328 - [clangd] Fix incorrect file path for symbols defined by the compile command-line option.

Author: hokein Date: Tue Feb 6 01:50:35 2018 New Revision: 324328 URL: http://llvm.org/viewvc/llvm-project?rev=324328=rev Log: [clangd] Fix incorrect file path for symbols defined by the compile command-line option. Summary: Reviewers: ioeric Reviewed By: ioeric Subscribers: klimek,

[PATCH] D42645: New simple Checker for mmap calls

a.sidorin added a comment. Hello David, I have looked into mmap constant definitions in different implementations and found them pretty inconsistent. For example, MMAP_EXEC can be 0x01, 0x04 and I even found 0x00 in some file (https://www.cs.cmu.edu/~dga/crypto/priveth/libethash/mmap.h).

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#998732, @a.sidorin wrote: > Hello David, > > I have looked into mmap constant definitions in different implementations and > found them pretty inconsistent. For example, MMAP_EXEC can be 0x01, 0x04 and > I even found 0x00 in some

[PATCH] D42915: [clangd] Use URIs in index symbols.

hokein added inline comments. Comment at: clangd/index/Index.h:27 + // The URI of the source file where a symbol occurs. + llvm::StringRef FileUri; // The 0-based offset to the first character of the symbol from the beginning sammccall wrote: > ioeric

[PATCH] D42919: [clangd] Support simpler JSON-RPC stream parsing for lit tests.

sammccall marked an inline comment as done. sammccall added a comment. In https://reviews.llvm.org/D42919#998695, @ioeric wrote: > LGTM > > Have we kept a lit test that uses content-length? It's unclear from the patch. Yes, `protocol.test` tests the real protocol parser. (The other tests that

[clang-tools-extra] r324334 - [clangd] Cut input-mirror.test down to size. NFC

Author: sammccall Date: Tue Feb 6 02:51:22 2018 New Revision: 324334 URL: http://llvm.org/viewvc/llvm-project?rev=324334=rev Log: [clangd] Cut input-mirror.test down to size. NFC Modified: clang-tools-extra/trunk/test/clangd/input-mirror.test Modified:

[PATCH] D42915: [clangd] Use URIs in index symbols.

ioeric added inline comments. Comment at: clangd/index/Index.h:27 + // The URI of the source file where a symbol occurs. + llvm::StringRef FileUri; // The 0-based offset to the first character of the symbol from the beginning hokein wrote: > sammccall

[PATCH] D41102: Setup clang-doc frontend framework

Athosvk added a comment. As we had discussed before, we're interested in the development as well! As an overall comment, I speak from experience that maintaining a large degree of documentation throughout the source code of the tool can provide an excellent test-case. We sure hope this will

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

djasper added a comment. You still haven't addressed my comment about there not being a publicly accessible style guide recommending these. https://reviews.llvm.org/D32525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42727: [clang-format] Adds space around angle brackets in text protos

krasimir updated this revision to Diff 132964. krasimir marked an inline comment as done. krasimir added a comment. - Address review comments Repository: rC Clang https://reviews.llvm.org/D42727 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

xazax.hun added a comment. Overall looks good. Was this tested on large software? I would also be grateful if you could run the regression tests with templight always being enabled to see if they uncover any assertions/crashes. Comment at:

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

rogfer01 added a comment. I understand you're fixing the narrowing check from "unscoped enum/integer type" → float. But you have also extended some tests which are "unscoped enum" → integer type (lines 153, 170 and 173). So I presume they were already handled correctly before your patch. Can

[PATCH] D42901: Test commit - fixing a comment.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324338: Test commit - fixing a comment. (authored by jolesiak, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42901 Files:

Re: [PATCH] D42742: [clangd] Use pthread instead of thread_local to support more runtimes.

It probably tries doing a standalone build of clang without LLVM. clang/config.h doesn't seem to include the HAVE_PTHREAD_GETSPECIFIC used in Context.cpp. We can either add the corresponding macro to clang's config.h or follow jyknight's suggestions and figure out if we can remove pthread-specific

[PATCH] D42987: [libc++abi] fix compilation in C++17 mode

rsmith created this revision. rsmith added reviewers: EricWF, mclow.lists. Herald added a subscriber: sanjoy. C++17 removes `std::unexpected_handler`, but libc++abi needs it to define `__cxa_exception`. When building against libc++, this is easily rectified by telling libc++ we're building the

[libcxx] r324423 - Remove more of the std::experimental bits that are now in std::. All the _v type aliases, conjunction/disjunction, apply, etc. See https://libcxx.llvm.org/TS_deprecation.html

Author: marshall Date: Tue Feb 6 15:13:48 2018 New Revision: 324423 URL: http://llvm.org/viewvc/llvm-project?rev=324423=rev Log: Remove more of the std::experimental bits that are now in std::. All the _v type aliases, conjunction/disjunction, apply, etc. See

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:24 + +StringRef CheckPPC(StringRef Name) { + if (Name.startswith("vec_")) Please make

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133109. MaskRay added a comment. Remove private section Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:77 +void SIMDIntrinsicsCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( +

[PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

compnerd added inline comments. Comment at: docs/LanguageExtensions.rst:2732 + +The ``#pragma comment(lib, ...)`` directive is supported on all ELF targets. +The second parameter is the library name (without the traditional Unix prefix of erichkeane wrote: >

[clang-tools-extra] r324386 - Revert "[clangd] The new threading implementation" (r324356)

Author: ibiryukov Date: Tue Feb 6 11:22:40 2018 New Revision: 324386 URL: http://llvm.org/viewvc/llvm-project?rev=324386=rev Log: Revert "[clangd] The new threading implementation" (r324356) And the follow-up changes r324361 and r324363. These changes seem to break two buildbots: -

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay updated this revision to Diff 133083. MaskRay added a comment. Add test/clang-tidy/readability-simd-intrinsics.cpp Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

r324420 - [Myriad] Define __ma2x5x and __ma2x8x

Author: waltl Date: Tue Feb 6 14:39:47 2018 New Revision: 324420 URL: http://llvm.org/viewvc/llvm-project?rev=324420=rev Log: [Myriad] Define __ma2x5x and __ma2x8x Summary: Add architecture defines for ma2x5x and ma2x8x. Reviewers: jyknight Subscribers: fedor.sergeev, MartinO Differential

r324419 - [Lex] Fix handling numerical literals ending with ' and signed exponent.

Author: vsapsai Date: Tue Feb 6 14:39:25 2018 New Revision: 324419 URL: http://llvm.org/viewvc/llvm-project?rev=324419=rev Log: [Lex] Fix handling numerical literals ending with ' and signed exponent. For input `0'e+1` lexer tokenized as numeric constant only `0'e`. Later NumericLiteralParser

[PATCH] D42457: [analyzer] Don't communicate evaluation failures through memregion hierarchy.

NoQ added a comment. > Functional change here is accidental - by communicating array destructor > situation properly, we're able to fix an old FIXME. Minor temporary insanity. This test was "fixed" because in `mayInlineCall()` for destructors i started to look for the flag that i never set for

r324425 - [Sema][ObjC] Use SmallSetVector to fix a failing test on the reverse

Author: ahatanak Date: Tue Feb 6 15:44:40 2018 New Revision: 324425 URL: http://llvm.org/viewvc/llvm-project?rev=324425=rev Log: [Sema][ObjC] Use SmallSetVector to fix a failing test on the reverse iteration bot. This commit reverts r315639, which was causing clang to print diagnostics that

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

Eugene.Zelenko added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:77 +void SIMDIntrinsicsCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(callee(functionDecl(matchesName("^::(_mm_|_mm256_|_mm512_|vec_)"))),

r324430 - [NFC] Correct a typo'ed comment and reworded, since it is awkward.

Author: erichkeane Date: Tue Feb 6 16:19:58 2018 New Revision: 324430 URL: http://llvm.org/viewvc/llvm-project?rev=324430=rev Log: [NFC] Correct a typo'ed comment and reworded, since it is awkward. Modified: cfe/trunk/lib/Driver/Driver.cpp Modified: cfe/trunk/lib/Driver/Driver.cpp URL:

[PATCH] D42918: [clang-tidy] Update fuchsia-multiple-inheritance to check for templates

This revision was automatically updated to reflect the committed changes. Closed by commit rL324432: [clang-tidy] Update fuchsia-multiple-inheritance to check for templates (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[clang-tools-extra] r324432 - [clang-tidy] Update fuchsia-multiple-inheritance to check for templates

Author: juliehockett Date: Tue Feb 6 16:33:50 2018 New Revision: 324432 URL: http://llvm.org/viewvc/llvm-project?rev=324432=rev Log: [clang-tidy] Update fuchsia-multiple-inheritance to check for templates Updating fuchsia-multiple-inheritance to not crash when a record inherits a template.

  1   2   3   >