[PATCH] D42704: [clang-format] Do not break Objective-C string literals inside array literals

This revision was automatically updated to reflect the committed changes. Closed by commit rC324618: [clang-format] Do not break Objective-C string literals inside array literals (authored by benhamilton, committed by ). Changed prior to commit:

[PATCH] D43068: [clangd] Remove codeComplete that returns std::future<>

ilya-biryukov added inline comments. Comment at: unittests/clangd/SyncAPI.h:8 +// +//===-===// +#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H ioeric wrote: > Any reason not to put

[libcxx] r324624 - Once more, with feeling. Spell 'clang-4.0' correctly this time

Author: marshall Date: Thu Feb 8 09:06:08 2018 New Revision: 324624 URL: http://llvm.org/viewvc/llvm-project?rev=324624=rev Log: Once more, with feeling. Spell 'clang-4.0' correctly this time Modified: libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp

[PATCH] D43078: Fix crash on array initializer with non-0 alloca addrspace

arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added a subscriber: wdng. https://reviews.llvm.org/D43078 Files: lib/CodeGen/CGDecl.cpp test/CodeGenOpenCL/address-space-constant-initializers.cl test/CodeGenOpenCL/private-array-initialization.cl Index:

[PATCH] D43068: [clangd] Remove codeComplete that returns std::future<>

ioeric added inline comments. Comment at: unittests/clangd/SyncAPI.h:8 +// +//===-===// +#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H ilya-biryukov wrote: > ioeric wrote: > >

[PATCH] D42745: [analyzer] Add support for __builtin_constant_p to BuiltinFunctionChecker

sp4r74n-117 updated this revision to Diff 133447. sp4r74n-117 added a comment. Thanks for the explanation, seems like I was on the wrong track. I now do realize that my initial approach was in fact duplicating the logic of 'BI__builtin_object_size'. I've removed most of the changes applied to

[PATCH] D43074: [Analyzer] Fix a typo about `categories::MemoryError` in `MallocChecker.cpp`

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D43074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43068: [clangd] Remove codeComplete that returns std::future<>

ioeric added inline comments. Comment at: unittests/clangd/SyncAPI.h:8 +// +//===-===// +#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H ilya-biryukov wrote: > ioeric wrote: > > Any

r324618 - [clang-format] Do not break Objective-C string literals inside array literals

Author: benhamilton Date: Thu Feb 8 08:07:25 2018 New Revision: 324618 URL: http://llvm.org/viewvc/llvm-project?rev=324618=rev Log: [clang-format] Do not break Objective-C string literals inside array literals Summary: Concatenating Objective-C string literals inside an array literal raises the

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay marked 4 inline comments as done. MaskRay added inline comments. Comment at: include/clang-c/Index.h:6159 + */ + CXSymbolRole role; } CXIdxEntityRefInfo; ilya-biryukov wrote: > MaskRay wrote: > > ilya-biryukov wrote: > > > Why do we need to store

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133441. MaskRay added a comment. Don't deprecate CXIdxEntityRefInfo Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h include/clang/Index/IndexSymbol.h test/Index/index-decls.m test/Index/index-refs.cpp

[PATCH] D40284: [Sema] Improve diagnostics for template arg deduction

jtbandes updated this revision to Diff 133440. jtbandes added a comment. Using a slightly more invasive fix. I haven't come up with any other test cases that exhibit the problem, which makes me unsure this fix is needed in all these locations. Maybe someone with more knowledge of this function

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133455. MaskRay added a comment. Add option `Enabled` which defaults to 0. Suggest std::simd (-std=c++2a) or std::experimental::std (-std=c++11) only if enabled. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files:

[PATCH] D43041: Add X86 Support to ValidCPUList (enabling march notes)

erichkeane updated this revision to Diff 133443. erichkeane added a comment. removed careless newline, also rebases off ARM patch. https://reviews.llvm.org/D43041 Files: lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h test/Misc/target-invalid-cpu-note.c Index:

[PATCH] D43041: Add X86 Support to ValidCPUList (enabling march notes)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D43041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43041: Add X86 Support to ValidCPUList (enabling march notes)

Hahnfeld added inline comments. Comment at: lib/Basic/Targets/X86.cpp:1670-1672 +#define PROC_ALIAS(ENUM, ALIAS) \ + if (checkCPUKind(getCPUKind(ALIAS))) \ +Values.emplace_back(ALIAS);

[PATCH] D42844: [OpenCL] Add test for atomic pointers.

Anastasia added a comment. Sorry for delay... Does this test anything OpenCL specific? As far as I remember we don't have any changes to `PointerType` with an atomic pointee type. Repository: rC Clang https://reviews.llvm.org/D42844 ___

[PATCH] D42841: [docs] Improve help for OpenMP options

gtbercea accepted this revision. gtbercea added a comment. LG https://reviews.llvm.org/D42841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37057: [clang] Require address space to be specified when creating functions (3/3)

arichardson added a comment. Looks good to me but I guess someone else should approve the change. I added a bunch of hacks in our fork to ensure that functions end up being in address space 200 but this would be much better. Repository: rC Clang https://reviews.llvm.org/D37057

[PATCH] D41597: Driver: ignore -mbig-obj like /bigobj

rnk accepted this revision. rnk added a comment. lgtm This works even though we pass -Wa,-mbig-obj? Repository: rC Clang https://reviews.llvm.org/D41597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43013: ASan+operator new[]: Fix operator new[] cookie poisoning

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks. LGTM. Repository: rC Clang https://reviews.llvm.org/D43013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43068: [clangd] Remove codeComplete that returns std::future<>

ilya-biryukov added inline comments. Comment at: unittests/clangd/SyncAPI.h:8 +// +//===-===// +#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H ioeric wrote: > ilya-biryukov wrote: > >

[PATCH] D43041: Add X86 Support to ValidCPUList (enabling march notes)

Hahnfeld added inline comments. Comment at: lib/Basic/Targets/X86.cpp:1670-1672 +#define PROC_ALIAS(ENUM, ALIAS) \ + if (checkCPUKind(getCPUKind(ALIAS))) \ +Values.emplace_back(ALIAS);

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked 9 inline comments as done. MaskRay added a comment. The check must be manually enabled now: % clang-tidy -checks='-*,readability-simd-intrinsics' a.cc -- -std=c++2a # Not enabled by default % clang-tidy -checks='-*,readability-simd-intrinsics' -config='{CheckOptions:

[PATCH] D43078: Fix crash on array initializer with non-0 alloca addrspace

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D43078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43045: Add NVPTX Support to ValidCPUList (enabling march notes)

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM with an inline comment. Comment at: include/clang/Basic/Cuda.h:49 SM_72, + LAST, }; We have last, invalid, etc... maybe we should pick one

[libcxx] r324640 - The apple versions of clang don't support deduction guides yet.

Author: marshall Date: Thu Feb 8 11:33:03 2018 New Revision: 324640 URL: http://llvm.org/viewvc/llvm-project?rev=324640=rev Log: The apple versions of clang don't support deduction guides yet. Modified: libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp

[PATCH] D43045: Add NVPTX Support to ValidCPUList (enabling march notes)

tra added inline comments. Comment at: test/Misc/target-invalid-cpu-note.c:38 +// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35, +// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72 Nit: Generally speaking

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133476. MaskRay added a comment. .rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/SIMDIntrinsicsCheck.cpp

[PATCH] D42745: [analyzer] Add support for __builtin_constant_p to BuiltinFunctionChecker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Tests look good. You can't test deadcode :) https://reviews.llvm.org/D42745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43045: Add NVPTX Support to ValidCPUList (enabling march notes)

erichkeane added inline comments. Comment at: test/Misc/target-invalid-cpu-note.c:38 +// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35, +// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72 tra wrote: > Nit:

[PATCH] D43045: Add NVPTX Support to ValidCPUList (enabling march notes)

erichkeane updated this revision to Diff 133458. erichkeane added a comment. rebased, reflowed tests. https://reviews.llvm.org/D43045 Files: include/clang/Basic/Cuda.h lib/Basic/Cuda.cpp lib/Basic/Targets/NVPTX.cpp lib/Basic/Targets/NVPTX.h test/Misc/target-invalid-cpu-note.c

[PATCH] D43057: Add Rest of Targets Support to ValidCPUList (enabling march notes)

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. I've glanced at this and didn't notice anything. I think any problems can be fixed in post-commit review if necessary. https://reviews.llvm.org/D43057

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42300: [Analyzer] Add PreStmt and PostStmt callbacks for OffsetOfExpr

MTC added a comment. @NoQ Sorry to bother you again. It seems that this patch is useless to analyzer temporarily, if you think so, I will abandon it : ). Repository: rC Clang https://reviews.llvm.org/D42300 ___ cfe-commits mailing list

[PATCH] D42645: New simple Checker for mmap calls

NoQ added a comment. Hmm, maybe it'd also be a good idea to disable the check completely when a likely-correct value for the macro cannot be determined. Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:74-75 + mgr.registerChecker(); + Mwec->ProtExecOv =

[PATCH] D43041: Add X86 Support to ValidCPUList (enabling march notes)

erichkeane updated this revision to Diff 133456. erichkeane added a comment. Cleaned up the test as suggested. https://reviews.llvm.org/D43041 Files: lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h test/Misc/target-invalid-cpu-note.c Index: test/Misc/target-invalid-cpu-note.c

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

rjmccall added a comment. Thanks, that looks a lot better. One minor piece of feedback, but otherwise LGTM. Comment at: lib/Sema/SemaExpr.cpp:4402 +Qualifiers MemberQuals = +Context.getCanonicalType(ResultType).getQualifiers(); +Qualifiers Combined =

Re: [PATCH] D43045: Add NVPTX Support to ValidCPUList (enabling march notes)

Fair. Did you want to handle this a different way? I thought the list at least seemed reasonable for spelling. On Thu, Feb 8, 2018, 11:44 AM Artem Belevich via Phabricator < revi...@reviews.llvm.org> wrote: > tra added inline comments. > > > > Comment at:

[PATCH] D43045: Add NVPTX Support to ValidCPUList (enabling march notes)

tra added inline comments. Comment at: test/Misc/target-invalid-cpu-note.c:38 +// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35, +// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72 erichkeane wrote: > tra

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133474. MaskRay added a comment. Herald added subscribers: kbarton, nemanjai. Split test/clang-tidy/readability-simd-intrinsics.cpp to x86 and ppc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files:

[PATCH] D43062: [analyzer] Support CXXTemporaryObjectExpr constructors that have destructors.

NoQ updated this revision to Diff 133475. NoQ added a comment. Add a simple test for a class with no destructor. https://reviews.llvm.org/D43062 Files: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp test/Analysis/temporaries.cpp Index: test/Analysis/temporaries.cpp

[PATCH] D43089: clang: Add ARCTargetInfo

petecoup created this revision. petecoup added a reviewer: tatyana-krasnukha. Herald added subscribers: hintonda, mgorny. https://reviews.llvm.org/D43089 Files: clang/lib/Basic/CMakeLists.txt clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/ARC.cpp clang/lib/Basic/Targets/ARC.h

[PATCH] D35894: [clangd] Code hover for Clangd

simark added inline comments. Comment at: unittests/clangd/XRefsTests.cpp:231 +TEST(Hover, All) { + + struct OneTest { ilya-biryukov wrote: > NIT: remove empty line at the start of the function Done. Comment at:

[PATCH] D35894: [clangd] Code hover for Clangd

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:325 +void ClangdLSPServer::onHover(TextDocumentPositionParams ) { + + llvm::Expected H = ilya-biryukov wrote: > NIT: remove the empty line at the start of function Done.

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133457. MaskRay added a comment. Set `Enabled` to 1 in test/clang-tidy/readability-simd-intrinsics.cpp Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D42549: [CodeGen] Use the zero initializer instead of storing an all zero representation.

rjmccall added a comment. I'm somewhat surprised LLVM doesn't already canonicalize this, but ok. Should we also do this when building a constant struct? Comment at: lib/CodeGen/CGExprConstant.cpp:873 Elts.push_back(C); + if (!C->isNullValue()) +

[PATCH] D43078: Fix crash on array initializer with non-0 alloca addrspace

arsenm closed this revision. arsenm added a comment. r324641 https://reviews.llvm.org/D43078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r324641 - Fix crash on array initializer with non-0 alloca addrspace

Author: arsenm Date: Thu Feb 8 11:37:09 2018 New Revision: 324641 URL: http://llvm.org/viewvc/llvm-project?rev=324641=rev Log: Fix crash on array initializer with non-0 alloca addrspace Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp

[PATCH] D42552: [analyzer] dump() environment frame-by-frame.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL324660: [analyzer] Self-debug: Dump environment frame-by-frame. (authored by dergachev, committed by ). Herald added a

r324647 - [X86] Replace kortest intrinsics with native IR.

Author: ctopper Date: Thu Feb 8 12:16:17 2018 New Revision: 324647 URL: http://llvm.org/viewvc/llvm-project?rev=324647=rev Log: [X86] Replace kortest intrinsics with native IR. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/CodeGen/avx512f-builtins.c Modified:

[PATCH] D42300: [Analyzer] Add PreStmt and PostStmt callbacks for OffsetOfExpr

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. All right, i guess we already do have a pair of callbacks for `IntegerLiteral` and it doesn't hurt, especially because here they'd eventually be actually useful. I think it should land, just to

[PATCH] D42560: [analyzer] dump() ExprEngine's internal traits into the ExplodedGraph view.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324663: [analyzer] Self-debug: Dump the cores internal state traits to the egraph. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D42560 Files:

r324663 - [analyzer] Self-debug: Dump the core's internal state traits to the egraph.

Author: dergachev Date: Thu Feb 8 14:32:38 2018 New Revision: 324663 URL: http://llvm.org/viewvc/llvm-project?rev=324663=rev Log: [analyzer] Self-debug: Dump the core's internal state traits to the egraph. It is useful for debugging problems with C++ operator new() or temporaries. Differential

r324651 - PR36307: Consume the #pragma options align annotation token after

Author: arphaman Date: Thu Feb 8 13:20:43 2018 New Revision: 324651 URL: http://llvm.org/viewvc/llvm-project?rev=324651=rev Log: PR36307: Consume the #pragma options align annotation token after semantic analysis to prevent incorrect -Wpragma-pack warning for an included file rdar://37354951

r324652 - [analyzer] [tests] Test different projects concurrently

Author: george.karpenkov Date: Thu Feb 8 13:22:42 2018 New Revision: 324652 URL: http://llvm.org/viewvc/llvm-project?rev=324652=rev Log: [analyzer] [tests] Test different projects concurrently Differential Revision: https://reviews.llvm.org/D43031 Modified:

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ added a comment. All right, so this change is indeed safe, i.e. no crashes or changes in analyzer behavior so far on my large codebase run. Will commit now. https://reviews.llvm.org/D42672 ___ cfe-commits mailing list

[PATCH] D43074: [Analyzer] Fix a typo about `categories::MemoryError` in `MallocChecker.cpp`

NoQ accepted this revision. NoQ added a comment. Woohoo thanks nice. Repository: rC Clang https://reviews.llvm.org/D43074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r324660 - [analyzer] Self-debug: Dump environment frame-by-frame.

Author: dergachev Date: Thu Feb 8 14:24:38 2018 New Revision: 324660 URL: http://llvm.org/viewvc/llvm-project?rev=324660=rev Log: [analyzer] Self-debug: Dump environment frame-by-frame. It makes it easier to discriminate between values of similar expressions in different stack frames. It also

[PATCH] D43057: Add Rest of Targets Support to ValidCPUList (enabling march notes)

erichkeane updated this revision to Diff 133459. erichkeane added a comment. rebased, reflowed tests. https://reviews.llvm.org/D43057 Files: lib/Basic/Targets/AMDGPU.cpp lib/Basic/Targets/AMDGPU.h lib/Basic/Targets/AVR.cpp lib/Basic/Targets/AVR.h lib/Basic/Targets/BPF.cpp

r324644 - Fix improper indentation issue in CodeGenModule [NFC]

Author: erichkeane Date: Thu Feb 8 12:04:22 2018 New Revision: 324644 URL: http://llvm.org/viewvc/llvm-project?rev=324644=rev Log: Fix improper indentation issue in CodeGenModule [NFC] Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp URL:

[PATCH] D35894: [clangd] Code hover for Clangd

simark added a comment. In https://reviews.llvm.org/D35894#1001875, @ilya-biryukov wrote: > Thanks for picking this up! > I have just one major comment related to how we generate the hover text. > > Current implementation tries to get the actual source code for every > declaration and then

Re: r324419 - [Lex] Fix handling numerical literals ending with ' and signed exponent.

Merged to 6.0 in r324579. On Tue, Feb 6, 2018 at 11:39 PM, Volodymyr Sapsai via cfe-commits wrote: > Author: vsapsai > Date: Tue Feb 6 14:39:25 2018 > New Revision: 324419 > > URL: http://llvm.org/viewvc/llvm-project?rev=324419=rev > Log: > [Lex] Fix handling

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall updated this revision to Diff 133502. sammccall added a comment. Revert hack in global-symbol-builder to filter the input files. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42942 Files: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp

r324674 - Add X86 Support to ValidCPUList (enabling march notes)

Author: erichkeane Date: Thu Feb 8 15:15:02 2018 New Revision: 324674 URL: http://llvm.org/viewvc/llvm-project?rev=324674=rev Log: Add X86 Support to ValidCPUList (enabling march notes) A followup to: https://reviews.llvm.org/D42978 This patch adds X86 and X86_64 support for enabling the march

r324673 - Make march/target-cpu print a note with the list of valid values for ARM

Author: erichkeane Date: Thu Feb 8 15:14:15 2018 New Revision: 324673 URL: http://llvm.org/viewvc/llvm-project?rev=324673=rev Log: Make march/target-cpu print a note with the list of valid values for ARM When rejecting a march= or target-cpu command line parameter, the message is quite lacking.

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall added a comment. Thanks for the comments! And sorry for the delay, I was haunted by useless gtest messages, which https://reviews.llvm.org/D43091 should fix. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:159 + // Output phase: emit YAML for

[PATCH] D43068: [clangd] Remove codeComplete that returns std::future<>

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. One down! I'd like to know what you think about a generic "block the call and capture the result" mechanism rather than method-specific wrappers. But if you're not convinced or just

[PATCH] D43105: [RISCV] Enable __int128_t and uint128_t through clang flag

mgrang created this revision. mgrang added reviewers: asb, kito-cheng, apazos. Herald added subscribers: cfe-commits, niosHD, sabuasal, jordy.potman.lists, simoncook, johnrusso, rbar, aheejin, jgravelle-google, sbc100, sdardis, dschuff, jfb. If the flag -fuse-int128 is passed, it will enable

[PATCH] D43108: Support for the mno-stack-arg-probe flag

nruslan created this revision. nruslan added a reviewer: clang. Herald added a subscriber: cfe-commits. Adds support for this flag. There is also another piece for llvm (separate review). More info: https://bugs.llvm.org/show_bug.cgi?id=36221 Repository: rC Clang

[PATCH] D43104: [analyzer] Find correct region for simple temporary destructor calls and inline them if possible.

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:939 std::make_pair(D.getBindTemporaryExpr(), Pred->getStackFrame())); +// *MRPtr may still be null when the construction context for the temporary +// was not implemented.

[PATCH] D43047: [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions.

EricWF updated this revision to Diff 133517. EricWF retitled this revision from "[Builtins] Overload __builtin_operator_new/delete to accept an optional alignment parameter." to "[Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions.".

[PATCH] D43074: [Analyzer] Fix a typo about `categories::MemoryError` in `MallocChecker.cpp`

This revision was automatically updated to reflect the committed changes. Closed by commit rL324680: [analyzer] MallocChecker: Fix one more bug category. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43095: Make attribute-target on a Definition-after-use update the LLVM attributes

erichkeane created this revision. erichkeane added reviewers: echristo, craig.topper, aaron.ballman. Herald added a subscriber: mgrang. As reported here: https://bugs.llvm.org/show_bug.cgi?id=36301 The issue is that the 'use' causes the plain declaration to emit the attributes to LLVM-IR.

[PATCH] D43074: [Analyzer] Fix a typo about `categories::MemoryError` in `MallocChecker.cpp`

This revision was automatically updated to reflect the committed changes. Closed by commit rC324680: [analyzer] MallocChecker: Fix one more bug category. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D43074?vs=133423=133521#toc Repository: rC

r324682 - Add size to constexpr Arrays

Author: erichkeane Date: Thu Feb 8 15:49:40 2018 New Revision: 324682 URL: http://llvm.org/viewvc/llvm-project?rev=324682=rev Log: Add size to constexpr Arrays What seems to be a bug in older versions of MSVC, constexpr member arrays with a redefinition (to force emission) require their initial

r324687 - Fix UBSan issue with PPC::isValidCPUName

Author: erichkeane Date: Thu Feb 8 16:13:49 2018 New Revision: 324687 URL: http://llvm.org/viewvc/llvm-project?rev=324687=rev Log: Fix UBSan issue with PPC::isValidCPUName Apparently storing the pointer to a StringLiteral as a StringRef caused this section of code to issue a ubsan warning.

[PATCH] D42549: [CodeGen] Use the zero initializer instead of storing an all zero representation.

mattd updated this revision to Diff 133540. mattd added a comment. Thanks for the test tips. I realize the original was a bit carried away, my apologies for that. This updated test visits the same code path that we're trying to test, and is much more concise.

r324701 - AST: support ObjC lifetime qualifiers in MS ABI

Author: compnerd Date: Thu Feb 8 19:23:54 2018 New Revision: 324701 URL: http://llvm.org/viewvc/llvm-project?rev=324701=rev Log: AST: support ObjC lifetime qualifiers in MS ABI Adjust the ObjC protocol conformance workaround to be more extensible. Use a synthetic type for the protocol (`struct

[PATCH] D43074: [Analyzer] Fix a typo about `categories::MemoryError` in `MallocChecker.cpp`

NoQ added a comment. I guess this happened due to a race with https://reviews.llvm.org/rL301913. My bad anyways^^ Repository: rC Clang https://reviews.llvm.org/D43074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43045: Add NVPTX Support to ValidCPUList (enabling march notes)

This revision was automatically updated to reflect the committed changes. Closed by commit rL324675: Add NVPTX Support to ValidCPUList (enabling march notes) (authored by erichkeane, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43057: Add Rest of Targets Support to ValidCPUList (enabling march notes)

This revision was automatically updated to reflect the committed changes. Closed by commit rC324676: Add Rest of Targets Support to ValidCPUList (enabling march notes) (authored by erichkeane, committed by ). Changed prior to commit: https://reviews.llvm.org/D43057?vs=133459=133509#toc

r324676 - Add Rest of Targets Support to ValidCPUList (enabling march notes)

Author: erichkeane Date: Thu Feb 8 15:16:55 2018 New Revision: 324676 URL: http://llvm.org/viewvc/llvm-project?rev=324676=rev Log: Add Rest of Targets Support to ValidCPUList (enabling march notes) A followup to: https://reviews.llvm.org/D42978 Most of the rest of the Targets were pretty rote,

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

Hahnfeld added inline comments. Comment at: test/Misc/target-invalid-cpu-note.c:1 +// RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix ARM +// ARM: error: unknown target CPU 'not-a-cpu' Is there a

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane updated this revision to Diff 133442. erichkeane marked an inline comment as done. erichkeane added a comment. Removed extra newline. https://reviews.llvm.org/D42978 Files: include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane added a comment. That makes sense. I changed the ARM one to check ONLY the first one, since in each case that seems like the oldest anyway. It at least makes sure that the lists are distinct, and avoids this cross-repo fragility. https://reviews.llvm.org/D42978

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane updated this revision to Diff 133435. erichkeane added a comment. Simplified ARM tests as requested. https://reviews.llvm.org/D42978 Files: include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp lib/Basic/Targets/AArch64.cpp

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM thanks. Please wait a day or so with committing so others can raise additional concerns. Comment at: test/Misc/target-invalid-cpu-note.c:8 +// AARCH64: note: valid

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane added inline comments. Comment at: test/Misc/target-invalid-cpu-note.c:1 +// RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix ARM +// ARM: error: unknown target CPU 'not-a-cpu' Hahnfeld

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane updated this revision to Diff 133452. erichkeane added a comment. Relaxed the test further. https://reviews.llvm.org/D42978 Files: include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp lib/Basic/Targets/AArch64.cpp

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane added inline comments. Comment at: test/Misc/target-invalid-cpu-note.c:1 +// RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix ARM +// ARM: error: unknown target CPU 'not-a-cpu' erichkeane

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

sammccall added a comment. Some comments on the insert side, which looks pretty good. I'll take another look at indexing tomorrow. Comment at: clangd/ClangdServer.cpp:465 +auto = Clang->getPreprocessor().getHeaderSearchInfo(); +std::string Suggested =

r324695 - [modules] Fix incorrect diagnostic mapping computation when a module changes

Author: rsmith Date: Thu Feb 8 17:15:13 2018 New Revision: 324695 URL: http://llvm.org/viewvc/llvm-project?rev=324695=rev Log: [modules] Fix incorrect diagnostic mapping computation when a module changes diagnostic settings using _Pragma within a macro. The AST writer had previously been

[PATCH] D43105: [RISCV] Enable __int128_t and uint128_t through clang flag

mgrang added a comment. Related compiler-rt patch: https://reviews.llvm.org/D43106 Repository: rC Clang https://reviews.llvm.org/D43105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43105: [RISCV] Enable __int128_t and uint128_t through clang flag

efriedma added a comment. > This flag can then be used to build compiler-rt for RISCV32. Can you give a little more context for why this is necessary? As far as I know, compiler-rt generally supports building for targets which don't have __int128_t. (If all riscv targets are supposed to

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

rnk created this revision. rnk added a reviewer: rsmith. This fixes a flaw in our AST: PR27098 MSVC always gives plain enums the underlying type 'int'. Clang does this as well, but we claim the enum is "fixed", as if the user actually wrote ': int'. It means we end up emitting spurious

r324675 - Add NVPTX Support to ValidCPUList (enabling march notes)

Author: erichkeane Date: Thu Feb 8 15:16:00 2018 New Revision: 324675 URL: http://llvm.org/viewvc/llvm-project?rev=324675=rev Log: Add NVPTX Support to ValidCPUList (enabling march notes) A followup to: https://reviews.llvm.org/D42978 This patch adds NVPTX support for enabling the march notes.

[PATCH] D43041: Add X86 Support to ValidCPUList (enabling march notes)

This revision was automatically updated to reflect the committed changes. Closed by commit rL324674: Add X86 Support to ValidCPUList (enabling march notes) (authored by erichkeane, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43089: clang: Add ARCTargetInfo

Eugene.Zelenko added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:8220 + +} // End anonymous namespace. Please change to // namespace https://reviews.llvm.org/D43089 ___ cfe-commits mailing list

[PATCH] D43033: [WinEH] Put funclet bundles on inline asm calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL324689: [WinEH] Put funclet bundles on inline asm calls (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

  1   2   >