Re: r323998 - PR36157: When injecting an implicit function declaration in C89, find the right

Merged to 6.0 in r325104 as suggested in PR36368. On Thu, Feb 1, 2018 at 9:01 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Feb 1 12:01:49 2018 > New Revision: 323998 > > URL: http://llvm.org/viewvc/llvm-project?rev=323998=rev > Log: >

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

ilya-biryukov added a comment. In https://reviews.llvm.org/D43227#1006584, @sammccall wrote: > I wonder whether we want to introduce `using Callback = > UniqueFunction` for readability at some point... I agree that's a good idea, will come up with a CL doing that.

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

oren_ben_simhon updated this revision to Diff 134175. oren_ben_simhon added a comment. Implemented comments posted until 2/14 (Thanks Aaron and Craig) Repository: rL LLVM https://reviews.llvm.org/D41880 Files: include/clang/AST/Type.h include/clang/Basic/Attr.td

r325116 - [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

Author: a.sidorin Date: Wed Feb 14 03:18:00 2018 New Revision: 325116 URL: http://llvm.org/viewvc/llvm-project?rev=325116=rev Log: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl Also minor refactoring in related functions was done. Differential Revision:

[PATCH] D43246: [clangd] Assert path is absolute when assigning to URIForFile.

ilya-biryukov updated this revision to Diff 134194. ilya-biryukov added a comment. - Remove URIForFile::setFile(), rely on copy and move constructors instead. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43246 Files: clangd/ClangdLSPServer.cpp clangd/Protocol.cpp

[PATCH] D43246: [clangd] Assert path is absolute when assigning to URIForFile.

ilya-biryukov added a comment. In https://reviews.llvm.org/D43246#1006525, @ioeric wrote: > I think another option to prevent the bug in r325029 from happening would be > providing a canonical approach for retrieving (absolute) paths from > `FileManager`. We already have code in symbol

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

Szelethus updated this revision to Diff 134174. Szelethus added a comment. Renamed the checker from `misc-throw-keyword-missing` to `bugprone-throw-keyword-missing`. https://reviews.llvm.org/D43120 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

ioeric accepted this revision. ioeric added a comment. lg Comment at: clangd/ClangdServer.cpp:209 + auto Action = [Contents, Pos, TaggedFS, + PCHs](Path File, decltype(Callback) Callback, + llvm::Expected IP) {

r325118 - Quick fix for 325116 buildbots: move template specialization into namespace

Author: a.sidorin Date: Wed Feb 14 03:39:33 2018 New Revision: 325118 URL: http://llvm.org/viewvc/llvm-project?rev=325118=rev Log: Quick fix for 325116 buildbots: move template specialization into namespace Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified:

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

ilya-biryukov added a comment. In https://reviews.llvm.org/D39571#1006667, @simark wrote: > It seems to me like > > changes in command line arguments (adding -DMACRO=1) are not taken into > account > when changing configuration. It looks like a bug in the preamble handling. (It does not

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D43120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r325123 - [AST] Fix passing large-array-init.cpp on builds without asserts

Author: kosarev Date: Wed Feb 14 05:27:48 2018 New Revision: 325123 URL: http://llvm.org/viewvc/llvm-project?rev=325123=rev Log: [AST] Fix passing large-array-init.cpp on builds without asserts Differential Revision: https://reviews.llvm.org/D43187 Modified:

[PATCH] D43272: [clangd] Fix tracing now that spans lifetimes can overlap on a thread.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LG with a few NITs. Comment at: clangd/Trace.cpp:133 +std::atomic EndTime; // Filled in by endSpan(). +std::string Name; +const uint64_t TID;

r325117 - [Sema] Fix decltype of static data members

Author: miyuki Date: Wed Feb 14 03:34:25 2018 New Revision: 325117 URL: http://llvm.org/viewvc/llvm-project?rev=325117=rev Log: [Sema] Fix decltype of static data members Summary: According to the C++11 standard [dcl.type.simple]p4: The type denoted by decltype(e) is defined as follows: - if

[libcxx] r325087 - Fix incorrect indentation.

Author: brucem Date: Tue Feb 13 16:29:38 2018 New Revision: 325087 URL: http://llvm.org/viewvc/llvm-project?rev=325087=rev Log: Fix incorrect indentation. Reviewers: mclow.lists Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D43167 Modified:

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov created this revision. dfukalov added reviewers: b-sumner, arsenm. dfukalov added a project: AMDGPU. Herald added subscribers: cfe-commits, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, kzhuravl. 1. removed addrspace 3 specifications from builtins description strings since it's not

[PATCH] D38639: [clangd] #include statements support for Open definition

ilya-biryukov added inline comments. Comment at: unittests/clangd/XRefsTests.cpp:53 +class IgnoreDiagnostics : public DiagnosticsConsumer { + void onDiagnosticsReady( malaperle wrote: > ilya-biryukov wrote: > > NIT: remove this class, use `IgnoreDiagnostics`

[PATCH] D43246: [clangd] Assert path is absolute when assigning to URIForFile.

ioeric added inline comments. Comment at: clangd/Protocol.h:52 struct URIForFile { + URIForFile() = default; ilya-biryukov wrote: > sammccall wrote: > > I don't like how the API changes here take us further away from the other > > structs in this file. > >

r325120 - [AST] Refine the condition for element-dependent array fillers

Author: kosarev Date: Wed Feb 14 05:10:35 2018 New Revision: 325120 URL: http://llvm.org/viewvc/llvm-project?rev=325120=rev Log: [AST] Refine the condition for element-dependent array fillers This patch fixes clang to not consider braced initializers for aggregate elements of arrays to be

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark added a comment. In https://reviews.llvm.org/D39571#1007291, @ilya-biryukov wrote: > It looks like a bug in the preamble handling. (It does not check if macros > were redefined). > You can workaround that by making sure the preamble ends before your code > starts (preamble only

[PATCH] D42969: [Sema] Fix decltype of static data members

This revision was automatically updated to reflect the committed changes. Closed by commit rC325117: [Sema] Fix decltype of static data members (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D42969 Files: lib/Sema/SemaType.cpp

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

aaron.ballman added a comment. One thing I notice is that GCC trunk requires passing the `-fcf-protection` flag in order to enable the attribute. Do we wish to do the same? Comment at: include/clang/Basic/Attr.td:2089 +def AnyX86NoCfCheck : InheritableAttr,

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

miyuki added a comment. ping https://reviews.llvm.org/D42545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

miyuki added a comment. ping https://reviews.llvm.org/D42693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

oren_ben_simhon marked 6 inline comments as done. oren_ben_simhon added inline comments. Comment at: include/clang/Basic/Attr.td:2089 +def AnyX86NoCfCheck : InheritableAttr, TargetSpecificAttr{ + let Spellings = [GCC<"nocf_check">]; + let Documentation = [AnyX86NoCfCheckDocs];

[PATCH] D43124: [clang-format] Improve ObjC headers detection

jolesiak updated this revision to Diff 134180. jolesiak added a comment. This revision is now accepted and ready to land. Added support for ObjC characteristic keywords starting a new line. Repository: rC Clang https://reviews.llvm.org/D43124 Files: lib/Format/Format.cpp

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

ilya-biryukov updated this revision to Diff 134169. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Use llvm::Optional<> in capture() helper to avoid confusion with llvm::Expected. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43227 Files:

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D43279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43230: [clangd] Explicitly initialize all primitive fields in Protocol.h

ilya-biryukov added a comment. In https://reviews.llvm.org/D43230#1006498, @ioeric wrote: > I think it would probably depend on whether we could find a sensible default > value for a field (e.g. is 0 a better default value than UINT_MAX for line > number?) and whether we expect users to always

[PATCH] D43230: [clangd] Explicitly initialize all primitive fields in Protocol.h

ilya-biryukov updated this revision to Diff 134179. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Removed initializers for Optional<> fields, they are not problematic - Remove ctor from Position, initialize on per-field basis instead. Repository: rCTE Clang

[clang-tools-extra] r325113 - [clangd] Explicitly initialize all primitive fields in Protocol.h

Author: ibiryukov Date: Wed Feb 14 02:52:04 2018 New Revision: 325113 URL: http://llvm.org/viewvc/llvm-project?rev=325113=rev Log: [clangd] Explicitly initialize all primitive fields in Protocol.h Summary: Some of the existing structs had primimtive fields that were not explicitly initialized on

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen created this revision. devnexen added reviewers: vitalybuka, krytarowski. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, dberris, emaste. Similarly to the GNU driver version, adding proper compile and linker flags. Repository: rC

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen added a comment. Counterpart of the compiler-rt work here https://reviews.llvm.org/D43278 Repository: rC Clang https://reviews.llvm.org/D43279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r325097 - [clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag

Personally, I'm not a big fan of environment variables. There are harder to discover than command-line flags and I still have to change editor config often to switch between different builds of clangd. I know it may sound weird, but maybe we could have both the flag and the environment variables?

[PATCH] D43230: [clangd] Explicitly initialize all primitive fields in Protocol.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL325113: [clangd] Explicitly initialize all primitive fields in Protocol.h (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

Szelethus added a comment. Just noticed that I can't mark your inline comment as done, since the file got renamed. The typo is also fixed (Classname -> Class name). https://reviews.llvm.org/D43120 ___ cfe-commits mailing list

[PATCH] D36492: [time-report] Add preprocessor timer

modocache abandoned this revision. modocache added inline comments. Comment at: include/clang/Lex/PreprocessorOptions.h:165 public: - PreprocessorOptions() : UsePredefines(true), DetailedRecord(false), + PreprocessorOptions() : PPTimer("preprocessor", "Preprocessing"), +

[PATCH] D40925: Add option -fkeep-static-consts

eandrews added a comment. I think we can use CodeGenModule::addUsedGlobal for this purpose. I noticed this is what attribute 'used' calls. I need to look into it though. https://reviews.llvm.org/D40925 ___ cfe-commits mailing list

[PATCH] D43290: clang-format: tweak formatting of variable initialization blocks

Typz created this revision. Typz added reviewers: krasimir, djasper, klimek. This patch changes the behavior of PenaltyBreakBeforeFirstCallParameter so that is does not apply when the brace comes after an assignment. This way, variable initialization is wrapped more like an initializer than like

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

b-sumner added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:9866 + case AMDGPU::BI__builtin_amdgcn_ds_fmax: { +llvm::SmallVector Args; +for (unsigned I = 0; I != 5; ++I) Can the pointer argument address space be checked here? Repository:

r325136 - [CUDA] Allow external variables in separate compilation

Author: hahnfeld Date: Wed Feb 14 08:04:03 2018 New Revision: 325136 URL: http://llvm.org/viewvc/llvm-project?rev=325136=rev Log: [CUDA] Allow external variables in separate compilation According to the CUDA Programming Guide this is prohibited in whole program compilation mode. This makes sense

[clang-tools-extra] r325132 - [clangd] Fix data race in ClangdThreadingTest.StressTest

Author: ibiryukov Date: Wed Feb 14 07:19:20 2018 New Revision: 325132 URL: http://llvm.org/viewvc/llvm-project?rev=325132=rev Log: [clangd] Fix data race in ClangdThreadingTest.StressTest Prior to this patch, same instance of VFS was shared for concurrent processing of the files in

r325133 - Revert r324991 "Fix for PR32992. Static const classes not exported."

Author: hans Date: Wed Feb 14 07:19:46 2018 New Revision: 325133 URL: http://llvm.org/viewvc/llvm-project?rev=325133=rev Log: Revert r324991 "Fix for PR32992. Static const classes not exported." This broke the Chromium build on Windows; see https://crbug.com/812231 > Fix for PR32992. Static

[PATCH] D43204: [OpenMP] Fix trailing space when printing pragmas

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D43204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r324991 - Fix for PR32992. Static const classes not exported.

I ended up having to revert this in r325133 as it broke the Chromium build. Please see https://bugs.chromium.org/p/chromium/issues/detail?id=812231#c1 for a reproducer. On Tue, Feb 13, 2018 at 10:19 AM, Hans Wennborg via cfe-commits wrote: > Author: hans > Date: Tue

[PATCH] D42923: [CUDA] Allow external variables in separate compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rC325136: [CUDA] Allow external variables in separate compilation (authored by Hahnfeld, committed by ). Changed prior to commit: https://reviews.llvm.org/D42923?vs=132866=134230#toc Repository: rL

[PATCH] D42923: [CUDA] Allow external variables in separate compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rL325136: [CUDA] Allow external variables in separate compilation (authored by Hahnfeld, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43294: [clang-format] Recognize percents as format specifiers in protos

krasimir created this revision. krasimir added a reviewer: djasper. Herald added subscribers: cfe-commits, klimek. Frequently, a percent in protos denotes a formatting specifier for string replacement. Thus it is desirable to keep the percent together with what follows after it. Repository:

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 134235. gtbercea added a comment. Move unix specific test to new file. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c

r325145 - [OpenMP] Fix trailing space when printing pragmas, by Joel. E. Denny

Author: abataev Date: Wed Feb 14 09:38:47 2018 New Revision: 325145 URL: http://llvm.org/viewvc/llvm-project?rev=325145=rev Log: [OpenMP] Fix trailing space when printing pragmas, by Joel. E. Denny Summary: -ast-print prints omp pragmas with a trailing space. While this behavior is likely of

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

Hahnfeld added inline comments. Comment at: test/Driver/unix-openmp-offload-gpu.c:15 +/// bitcode library that will be found via the LIBRARY_PATH. +// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc +// RUN: env LIBRARY_PATH=/tmp gtbercea wrote: > Hahnfeld

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 134238. gtbercea added a comment. Fix tmp folder name. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

Hahnfeld added inline comments. Comment at: test/Driver/openmp-offload-gpu.c:150 +/// bitcode library that will be found via the LIBRARY_PATH. +// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc +// RUN: LIBRARY_PATH=/tmp %clang -### -fopenmp=libomp

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen added inline comments. Comment at: FreeBSD.cpp:139 + CmdArgs.push_back("--no-as-needed"); + CmdArgs.push_back("-lpthread"); + CmdArgs.push_back("-lrt"); krytarowski wrote: > `-pthread`? Did not seem needed maybe it s different for NetBSD ?

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

krytarowski added inline comments. Comment at: FreeBSD.cpp:139 + CmdArgs.push_back("--no-as-needed"); + CmdArgs.push_back("-lpthread"); + CmdArgs.push_back("-lrt"); devnexen wrote: > krytarowski wrote: > > `-pthread`? > Did not seem needed maybe it s

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen updated this revision to Diff 134244. devnexen added a comment. Changing to pthread flag. https://reviews.llvm.org/D43279 Files: lib/Driver/ToolChains/FreeBSD.cpp Index: lib/Driver/ToolChains/FreeBSD.cpp === ---

[PATCH] D43290: clang-format: tweak formatting of variable initialization blocks

djasper added a comment. What you are doing makes sense to me. My only hesitation is whether we should maybe completely disallow breaking between = and { when Cpp11BracedListStyle is false instead of solving this via penalties. Specifically, | 80

RE: r325081 - Implement function attribute artificial

Thanks Richard. I’ll update the documentation and submit a new patch for review. Elizabeth From: Keane, Erich Sent: Wednesday, February 14, 2018 11:33 AM To: Richard Smith ; Andrews, Elizabeth Cc: cfe-commits

[PATCH] D43094: AMDGPU: Enable PIC by default for amdgcn

kzhuravl added a comment. Ping. https://reviews.llvm.org/D43094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r325081 - Implement function attribute artificial

Thanks for your comments Richard, I’ve added the author to this email so that she can take a look. From: Richard Smith [mailto:rich...@metafoo.co.uk] Sent: Tuesday, February 13, 2018 5:39 PM To: Keane, Erich Cc: cfe-commits Subject: Re:

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea added inline comments. Comment at: test/Driver/unix-openmp-offload-gpu.c:15 +/// bitcode library that will be found via the LIBRARY_PATH. +// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc +// RUN: env LIBRARY_PATH=/tmp Hahnfeld wrote: > Hahnfeld

[PATCH] D43089: clang: Add ARCTargetInfo

petecoup added a comment. Hi Tatyana, Thanks for taking a look here, and sorry for the delay. I tried to follow the other target's usage patterns here. I'm happy to update/change this...I'll add a couple of clang reviewers here to weigh in? https://reviews.llvm.org/D43089

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

krytarowski added inline comments. Comment at: FreeBSD.cpp:139 + CmdArgs.push_back("--no-as-needed"); + CmdArgs.push_back("-lpthread"); + CmdArgs.push_back("-lrt"); `-pthread`? Repository: rC Clang https://reviews.llvm.org/D43279

[PATCH] D36802: AMDGPU: Cleanup most of the macros

kzhuravl added a comment. Ping. https://reviews.llvm.org/D36802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43204: [OpenMP] Fix trailing space when printing pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rL325145: [OpenMP] Fix trailing space when printing pragmas, by Joel. E. Denny (authored by ABataev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43204: [OpenMP] Fix trailing space when printing pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rC325145: [OpenMP] Fix trailing space when printing pragmas, by Joel. E. Denny (authored by ABataev, committed by ). Repository: rC Clang https://reviews.llvm.org/D43204 Files:

[PATCH] D43012: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL325116: [ASTImporter] Fix lexical DC for templated decls; support… (authored by a.sidorin, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43187: [AST] Refine the condition for element-dependent array fillers

This revision was automatically updated to reflect the committed changes. Closed by commit rL325120: [AST] Refine the condition for element-dependent array fillers (authored by kosarev, committed by ). Changed prior to commit: https://reviews.llvm.org/D43187?vs=133846=134200#toc Repository:

[PATCH] D43089: clang: Add ARCTargetInfo

tatyana-krasnukha added a comment. Sorry, =default is not applicable in these cases, of course. Comment at: clang/lib/CodeGen/TargetInfo.cpp:8123 +public: + ARCABIInfo(CodeGen::CodeGenTypes ) : DefaultABIInfo(CGT) {} + tatyana-krasnukha wrote: > Better use '=

[PATCH] D36492: [time-report] Add preprocessor timer

avt77 added inline comments. Comment at: include/clang/Lex/PreprocessorOptions.h:165 public: - PreprocessorOptions() : UsePredefines(true), DetailedRecord(false), + PreprocessorOptions() : PPTimer("preprocessor", "Preprocessing"), +

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle updated this revision to Diff 134296. malaperle added a comment. Fix some NITs, add more tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Protocol.h clangd/SourceCode.cpp clangd/SourceCode.h

r325171 - Clean up -fdiscard-value-name handling

Author: ericwf Date: Wed Feb 14 12:56:52 2018 New Revision: 325171 URL: http://llvm.org/viewvc/llvm-project?rev=325171=rev Log: Clean up -fdiscard-value-name handling Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL:

[PATCH] D42813: [Debug] Annotate compiler generated range-for loop variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rC325175: [Debug] Annotate compiler generated range-for loop variables. (authored by mattd, committed by ). Repository: rC Clang https://reviews.llvm.org/D42813 Files: include/clang/Sema/Scope.h

r325175 - [Debug] Annotate compiler generated range-for loop variables.

Author: mattd Date: Wed Feb 14 13:22:11 2018 New Revision: 325175 URL: http://llvm.org/viewvc/llvm-project?rev=325175=rev Log: [Debug] Annotate compiler generated range-for loop variables. Summary: This change aims to simplify debugging by annotating the range-for loop artificial variables

[PATCH] D42606: [Coroutines] Use allocator overload when available

modocache updated this revision to Diff 134304. modocache added a comment. Thanks for the review, @GorNishanov, and for pointing out that part of the standard! I added a reference to the implicit object parameter, as well as some tests for that behavior. And thanks for pointing out the flaw in

r325184 - Moved CHECK in test closer to source code

Author: vitalybuka Date: Wed Feb 14 14:52:49 2018 New Revision: 325184 URL: http://llvm.org/viewvc/llvm-project?rev=325184=rev Log: Moved CHECK in test closer to source code Modified: cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll Modified:

[PATCH] D42611: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/CodeGen/thinlto-distributed-cfi-devirt.ll:59 + ; Check that the call was devirtualized. + ; CHECK-IR: %call = tail call i32 @_ZN1A1nEi + %1 = tail call { i8*, i1 }

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rnk created this revision. rnk added a reviewer: rsmith. When the C++ committee changed the wording around non-type template arguments, they naively thought that every global declarations address would be a constant expression, but this is not the case. There is no PE/COFF relocation that allows

[PATCH] D43321: Improve documentation for attribute artificial

eandrews created this revision. eandrews added reviewers: rsmith, aaron.ballman, erichkeane. This patch is related to https://reviews.llvm.org/rC325081 The patch improves documentation for the attribute and removes reference to GCC documentation. https://reviews.llvm.org/D43321 Files:

[PATCH] D43321: Improve documentation for attribute artificial

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D43321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r325186 - Improve documentation for attribute artificial

Author: erichkeane Date: Wed Feb 14 15:00:31 2018 New Revision: 325186 URL: http://llvm.org/viewvc/llvm-project?rev=325186=rev Log: Improve documentation for attribute artificial This patch is related to https://reviews.llvm.org/rC325081 The patch improves documentation for the attribute and

[PATCH] D43105: [RISCV] Enable __int128_t and uint128_t through clang flag

apazos added inline comments. Comment at: lib/Basic/Targets/RISCV.h:85 + bool hasInt128Type(const LangOptions ) const override { +return Opts.UseInt128; + } kito-cheng wrote: > efriedma wrote: > > Maybe make this a cross-platform flag, rather than

[PATCH] D43321: Improve documentation for attribute artificial

This revision was automatically updated to reflect the committed changes. Closed by commit rC325186: Improve documentation for attribute artificial (authored by erichkeane, committed by ). Repository: rC Clang https://reviews.llvm.org/D43321 Files: include/clang/Basic/AttrDocs.td Index:

[PATCH] D43148: Adding msan support for FreeBSD

krytarowski added inline comments. Comment at: FreeBSD.cpp:397 Res |= SanitizerKind::FuzzerNoLink; +if (IsX86_64) +Res |= SanitizerKind::Memory; I would keep it in a dedicated `if (IsX86_64)` (similar to NetBSD). Otherwise it looks fine.

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone created this revision. Quuxplusone added a project: clang. Herald added a subscriber: cfe-commits. This patch adds two new diagnostics, which are off by default: **-Wreturn-std-move** Diagnose cases of `return x` or `throw x`, where `x` is the name of a local variable or parameter,

[PATCH] D43148: Adding msan support for FreeBSD

devnexen updated this revision to Diff 134331. https://reviews.llvm.org/D43148 Files: lib/Driver/ToolChains/FreeBSD.cpp Index: lib/Driver/ToolChains/FreeBSD.cpp === --- lib/Driver/ToolChains/FreeBSD.cpp +++

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:23 +def warn_return_std_move : Warning< + "adding 'std::move' here would select a better conversion sequence">, + InGroup, DefaultIgnore; Can we say something like "local

[PATCH] D36802: AMDGPU: Cleanup most of the macros

kzhuravl updated this revision to Diff 134335. kzhuravl edited the summary of this revision. kzhuravl added a comment. Address review feedback. https://reviews.llvm.org/D36802 Files: lib/Basic/Targets/AMDGPU.cpp lib/Basic/Targets/AMDGPU.h test/Driver/amdgpu-macros.cl Index:

[PATCH] D36802: AMDGPU: Cleanup most of the macros

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

Hahnfeld added inline comments. Comment at: test/Driver/unix-openmp-offload-gpu.c:15 +/// bitcode library that will be found via the LIBRARY_PATH. +// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc +// RUN: env LIBRARY_PATH=/tmp I don't see how that solves the

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: test/Driver/openmp-offload-gpu.c:150 +/// bitcode library that will be found via the LIBRARY_PATH. +// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc +// RUN: LIBRARY_PATH=/tmp %clang -###

[PATCH] D43204: [OpenMP] Fix trailing space when printing pragmas

jdenny added a comment. In https://reviews.llvm.org/D43204#1007502, @ABataev wrote: > LG Alexey: Thanks for accepting. I do not have commit privileges. Would you please commit for me? https://reviews.llvm.org/D43204 ___ cfe-commits mailing list

[PATCH] D43294: [clang-format] Recognize percents as format specifiers in protos

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Ok.. I guess ;) Repository: rC Clang https://reviews.llvm.org/D43294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43298: [clang-format] Support repeated field lists in protos

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This patch adds support for list initialization of proto repeated fields: keys: [1, 2, 3] Repository: rC Clang https://reviews.llvm.org/D43298 Files: lib/Format/TokenAnnotator.cpp

[libcxx] r325147 - Add a catch for std::length_error for the case where the string can't handle 2GB. (like say 32-bit big-endian)

Author: marshall Date: Wed Feb 14 10:05:25 2018 New Revision: 325147 URL: http://llvm.org/viewvc/llvm-project?rev=325147=rev Log: Add a catch for std::length_error for the case where the string can't handle 2GB. (like say 32-bit big-endian) Modified:

[PATCH] D43294: [clang-format] Recognize percents as format specifiers in protos

This revision was automatically updated to reflect the committed changes. Closed by commit rC325159: [clang-format] Recognize percents as format specifiers in protos (authored by krasimir, committed by ). Changed prior to commit: https://reviews.llvm.org/D43294?vs=134232=134286#toc

r325159 - [clang-format] Recognize percents as format specifiers in protos

Author: krasimir Date: Wed Feb 14 11:47:58 2018 New Revision: 325159 URL: http://llvm.org/viewvc/llvm-project?rev=325159=rev Log: [clang-format] Recognize percents as format specifiers in protos Summary: Frequently, a percent in protos denotes a formatting specifier for string replacement. Thus

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea added a comment. In https://reviews.llvm.org/D43197#1007918, @Hahnfeld wrote: > I'm still not sure we can't run this test on Windows. I think lots of other > tests use `touch`, even some specific to Windows... Let me know what you'd like me to do. I can add the test back. I do see

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 134292. gtbercea added a comment. Revert. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index:

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 134295. gtbercea added a comment. Fix test. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index:

  1   2   >