[PATCH] D40218: [Clang] Add __builtin_launder

EricWF updated this revision to Diff 134986. EricWF added a comment. Ping. https://reviews.llvm.org/D40218 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td lib/AST/ExprConstant.cpp lib/CodeGen/CGBuiltin.cpp lib/Sema/SemaChecking.cpp

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone added a comment. @rsmith and/or @rtrieu, please take another look? All my TODOs are done now: there are fixits, and the wording of the diagnostic changes if it's a "throw" instead of a "return", and the wording has been updated per Richard Smith's suggestions. I have one very

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

aprantl added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:2969 +if (!DD && RD->isBeingDefined()) + return nullptr; Perhaps add a comment explaining what's going on in this early exit? https://reviews.llvm.org/D43494

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone updated this revision to Diff 134999. Quuxplusone edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D43322 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h

r325545 - Fix some -Wexceptions false positives.

Author: rsmith Date: Mon Feb 19 18:32:30 2018 New Revision: 325545 URL: http://llvm.org/viewvc/llvm-project?rev=325545=rev Log: Fix some -Wexceptions false positives. Reimplement the "noexcept function actually throws" warning to properly handle nested try-blocks. In passing, change 'throw;'

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/ClangDoc.cpp:32 + ECtx.reportResult( + Name, Mapper.emitInfo(D, getComment(D), Name, getLine(D), getFile(D))); +} lebedev.ri wrote: > I wonder if `Name` should be `std::move()`'d ? Or not,

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135009. juliehockett marked 27 inline comments as done. juliehockett added a comment. 1. Decoupled the mapper implementation from the main program, exposing only the function to generate the action factory 2. Implemented the matchers into a

[PATCH] D43047: [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions.

EricWF updated this revision to Diff 134989. EricWF added a comment. Ping. https://reviews.llvm.org/D43047 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/CodeGen/CGBuiltin.cpp lib/CodeGen/CGExprCXX.cpp

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF updated this revision to Diff 134987. EricWF added a comment. Ping. https://reviews.llvm.org/D37035 Files: docs/LanguageExtensions.rst include/clang/AST/Expr.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h include/clang/AST/SourceLocExprScope.h

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone updated this revision to Diff 135005. Quuxplusone added a comment. Removed a redundant check for LValueReferenceType in the CWG1579 codepath. (In that branch, we know that standard C++ *did* perform the copy-to-move transformation, so obviously we can't have had an lvalue reference

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

vsapsai created this revision. vsapsai added reviewers: rsmith, bruno. Herald added a subscriber: jkorous-apple. During reading C++ definition data for lambda we can access CXXRecordDecl representing lambda before we finished reading the definition data. This can happen by reading a captured

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

compnerd added a comment. Is there a need for this given the changes for 6.0? https://reviews.llvm.org/D34365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43497: [analyzer] Introduce correct lifetime extension behavior in simple cases.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. This patch uses the reference to `MaterializeTemporaryExpr` stored in the construction context since https://reviews.llvm.org/D43477 in

r325544 - [Sema] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Mon Feb 19 18:16:28 2018 New Revision: 325544 URL: http://llvm.org/viewvc/llvm-project?rev=325544=rev Log: [Sema] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Sema/AttributeList.h

[PATCH] D43273: [libcxx] [test] Fix MSVC warnings and errors.

mclow.lists added inline comments. Comment at: test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp:80 { std::vector v(10); std::iota(v.begin(), v.end(), 1); What if we just made the containers `vector` ? (and `triangle`)

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

vsapsai updated this revision to Diff 135003. vsapsai added a comment. Herald added a subscriber: christof. - Add back existing test but run it only when file system supports min time. https://reviews.llvm.org/D42755 Files:

[PATCH] D42645: New simple Checker for mmap calls

NoQ added a comment. I believe we should relocate this checker into `alpha.security` in order to indicate that this is still in development, so that you (or anyone else) could provide auto-detection for the macro values later as an incremental improvement, and then it will be back in

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added inline comments. Comment at: clang-doc/ClangDocBinary.cpp:72 + assert(Abbrevs.find(recordID) == Abbrevs.end() && + "Abbreviation already set."); + Abbrevs[recordID] = abbrevID; juliehockett wrote: > lebedev.ri wrote: > > lebedev.ri

[PATCH] D43500: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule created this revision. jdemeule added a reviewer: alexfh. Herald added subscribers: cfe-commits, mgorny. 'modernize-user-default-member-init' does not automatically ask to remove comma and colon when replacements are produced. It seems, when they are apply directly from clang-tidy, the

r325560 - [X86] Remove mask from 512 bit pmulhrsw/pmulhw/pmulhuw builtins.

Author: ctopper Date: Mon Feb 19 23:28:18 2018 New Revision: 325560 URL: http://llvm.org/viewvc/llvm-project?rev=325560=rev Log: [X86] Remove mask from 512 bit pmulhrsw/pmulhw/pmulhuw builtins. We now use a vselect node in IR around an unmasked builtin. This makes it consistent with the 128 and

r325553 - [Sema] Fix -Wunused-variable

Author: sammccall Date: Mon Feb 19 23:21:56 2018 New Revision: 325553 URL: http://llvm.org/viewvc/llvm-project?rev=325553=rev Log: [Sema] Fix -Wunused-variable Modified: cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp Modified: cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp URL:

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

kosarev added a comment. John, the patch hangs for about a month now and Hal still seems to be extremely busy. Can we commit this with the constant to be whatever you think is most correct and the fix it as needed and if needed later? At this very moment we don't analyze the size fields of

[PATCH] D43388: [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks

This revision was automatically updated to reflect the committed changes. Closed by commit rL325480: [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r325475 - [cxx_dr_status] Tests for CWG issues 641-687.

Author: rsmith Date: Mon Feb 19 01:05:48 2018 New Revision: 325475 URL: http://llvm.org/viewvc/llvm-project?rev=325475=rev Log: [cxx_dr_status] Tests for CWG issues 641-687. Modified: cfe/trunk/test/CXX/drs/dr6xx.cpp cfe/trunk/www/cxx_dr_status.html Modified:

[PATCH] D43385: [clangd] Add "clangd.trace" VSCode setting to enable tracing.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325477: [clangd] Add clangd.trace VSCode setting to enable tracing. (authored by sammccall, committed by ). Changed

[PATCH] D43452: [clangd] Bump vs-code clangd extension v0.0.3

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43452 Files: clangd/clients/clangd-vscode/package.json Index:

[PATCH] D43388: [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325480: [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks (authored by sammccall, committed by ). Changed prior to commit:

Re: r324991 - Fix for PR32992. Static const classes not exported.

Reduced repro: $ clang -cc1 -triple i386-pc-windows-msvc19.11.0 -emit-pch -fms-extensions -fms-compatibility -fms-compatibility-version=19.11 -std=c++14 -fdelayed-template-parsing -x c++-header a.ii -o /dev/null a.ii: namespace a { enum b { c }; } template class d { static constexpr a::b e =

r325478 - [CodeGen] Initialize large arrays by copying from a global

Author: kosarev Date: Mon Feb 19 01:49:11 2018 New Revision: 325478 URL: http://llvm.org/viewvc/llvm-project?rev=325478=rev Log: [CodeGen] Initialize large arrays by copying from a global Currently, clang compiles explicit initializers for array elements into series of store instructions. For

[clang-tools-extra] r325477 - [clangd] Add "clangd.trace" VSCode setting to enable tracing.

Author: sammccall Date: Mon Feb 19 01:43:46 2018 New Revision: 325477 URL: http://llvm.org/viewvc/llvm-project?rev=325477=rev Log: [clangd] Add "clangd.trace" VSCode setting to enable tracing. Summary: Setting the CLANGD_TRACE environment variable directly is awkward with VSCode's "reload from

[PATCH] D43181: [CodeGen] Initialize large arrays by copying from a global

This revision was automatically updated to reflect the committed changes. Closed by commit rL325478: [CodeGen] Initialize large arrays by copying from a global (authored by kosarev, committed by ). Changed prior to commit: https://reviews.llvm.org/D43181?vs=134590=134865#toc Repository: rL

[PATCH] D43385: [clangd] Add "clangd.trace" VSCode setting to enable tracing.

hokein added a comment. Will make a new release for clangd vscode extension today. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r325476 - [clangd] Fix use-after-free in SymbolYAML: strings are owned by yaml::Input!

Author: sammccall Date: Mon Feb 19 01:31:26 2018 New Revision: 325476 URL: http://llvm.org/viewvc/llvm-project?rev=325476=rev Log: [clangd] Fix use-after-free in SymbolYAML: strings are owned by yaml::Input! Summary: There are a few implementation options here - alternatives are either both

[PATCH] D43381: [clangd] Fix use-after-free in SymbolYAML: strings are owned by yaml::Input!

This revision was automatically updated to reflect the committed changes. Closed by commit rL325476: [clangd] Fix use-after-free in SymbolYAML: strings are owned by yaml::Input! (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43385: [clangd] Add "clangd.trace" VSCode setting to enable tracing.

ilya-biryukov added a subscriber: hokein. ilya-biryukov added a comment. LGTM. We'll need to publish new version of VSCode extensions. +@hokein, who did that before. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43385 ___

[PATCH] D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Sema/CodeCompleteConsumer.h:355 +/// \brief Get string representation of \p Kind, useful for for debugging. +llvm::StringRef

[clang-tools-extra] r325480 - [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks

Author: sammccall Date: Mon Feb 19 01:56:28 2018 New Revision: 325480 URL: http://llvm.org/viewvc/llvm-project?rev=325480=rev Log: [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks Summary: This has a bit of a blast radius, but I think there's enough value in

[PATCH] D43452: [clangd] Bump vs-code clangd extension v0.0.3

This revision was automatically updated to reflect the committed changes. Closed by commit rL325484: [clangd] Bump vs-code clangd extension v0.0.3 (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43452 Files:

[PATCH] D43454: [clangd] Do not reuse preamble if compile args changed

ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, sammccall. Herald added subscribers: cfe-commits, jkorous-apple, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43454 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

ilya-biryukov added a comment. In https://reviews.llvm.org/D39571#1011842, @ilya-biryukov wrote: > In https://reviews.llvm.org/D39571#1007393, @simark wrote: > > > If I do it in this order, I get one diagnostic both times, when I don't > > expect one the second time the file is parsed. But if

[PATCH] D43440: clang-format: [JS] fix `of` detection.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325489: clang-format: [JS] fix `of` detection. (authored by mprobst, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43440 Files:

r325489 - clang-format: [JS] fix `of` detection.

Author: mprobst Date: Mon Feb 19 04:32:13 2018 New Revision: 325489 URL: http://llvm.org/viewvc/llvm-project?rev=325489=rev Log: clang-format: [JS] fix `of` detection. Summary: `of` is only a keyword when after an identifier, but not when after an actual keyword. Before: return of (a, b,

[clang-tools-extra] r325503 - [clangd] Correct the doc, password => Personal Access Token.

Author: hokein Date: Mon Feb 19 06:26:55 2018 New Revision: 325503 URL: http://llvm.org/viewvc/llvm-project?rev=325503=rev Log: [clangd] Correct the doc, password => Personal Access Token. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/README.md Modified:

[clang-tools-extra] r325484 - [clangd] Bump vs-code clangd extension v0.0.3

Author: hokein Date: Mon Feb 19 02:49:12 2018 New Revision: 325484 URL: http://llvm.org/viewvc/llvm-project?rev=325484=rev Log: [clangd] Bump vs-code clangd extension v0.0.3 Reviewers: sammccall Subscribers: klimek, ilya-biryukov, jkorous-apple, cfe-commits, ioeric Differential Revision:

[clang-tools-extra] r325486 - [clangd] Mark non-changing fields of CppFile as const. NFC

Author: ibiryukov Date: Mon Feb 19 03:15:33 2018 New Revision: 325486 URL: http://llvm.org/viewvc/llvm-project?rev=325486=rev Log: [clangd] Mark non-changing fields of CppFile as const. NFC Modified: clang-tools-extra/trunk/clangd/ClangdUnit.h Modified:

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

mgorny added a comment. Ping for the third time. https://reviews.llvm.org/D34365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r325493 - [clangd] Invert return value of fuzzyFind() (fix MemIndex's return value)

Author: sammccall Date: Mon Feb 19 05:04:41 2018 New Revision: 325493 URL: http://llvm.org/viewvc/llvm-project?rev=325493=rev Log: [clangd] Invert return value of fuzzyFind() (fix MemIndex's return value) Have had way too many bugs by converting between "isComplete" and "isIncomplete". LSP is

[PATCH] D43455: [clangd] Add brief instructions on how to make a release for vscode-clangd extension.

hokein updated this revision to Diff 134900. hokein marked an inline comment as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43455 Files: clangd/clients/clangd-vscode/README.md Index:

[PATCH] D43455: [clangd] Add brief instructions on how to make a release for vscode-clangd extension.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clangd/clients/clangd-vscode/README.md:61 +* Make sure install the `vsce` command (`npm install -g vsce`) +* `llvm-vs-code-extensions` account + sammccall wrote: > increase the

[PATCH] D43459: [X86] Disable CLWB in Cannon Lake

GBuella created this revision. GBuella added reviewers: craig.topper, zvi, echristo. Herald added a subscriber: cfe-commits. Cannon Lake does not support CLWB, therefore it does not include all features listed under SKX. Repository: rC Clang https://reviews.llvm.org/D43459 Files:

[PATCH] D43459: [X86] Disable CLWB in Cannon Lake

GBuella added a comment. See also: https://reviews.llvm.org/D43380 Repository: rC Clang https://reviews.llvm.org/D43459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43455: [clangd] Add brief instructions on how to make a release for vscode-clangd extension.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rCTE325499: [clangd] Add brief instructions on how to make a release for vscode-clangd… (authored by hokein, committed by ). Changed prior to commit:

[clang-tools-extra] r325499 - [clangd] Add brief instructions on how to make a release for vscode-clangd extension.

Author: hokein Date: Mon Feb 19 06:01:52 2018 New Revision: 325499 URL: http://llvm.org/viewvc/llvm-project?rev=325499=rev Log: [clangd] Add brief instructions on how to make a release for vscode-clangd extension. Reviewers: sammccall Subscribers: klimek, ilya-biryukov, jkorous-apple, ioeric,

[PATCH] D43461: [CUDA] Include single GPU binary, NFCI.

Hahnfeld created this revision. Hahnfeld added reviewers: jlebar, tra. Herald added a subscriber: cfe-commits. Binaries for multiple architectures are combined by fatbinary, so the current code was effectively not needed. Repository: rC Clang https://reviews.llvm.org/D43461 Files:

Re: r325375 - [MS] Make constexpr static data members implicitly inline

Merged to 6.0 in r325500. On Fri, Feb 16, 2018 at 8:44 PM, Reid Kleckner via cfe-commits wrote: > Author: rnk > Date: Fri Feb 16 11:44:47 2018 > New Revision: 325375 > > URL: http://llvm.org/viewvc/llvm-project?rev=325375=rev > Log: > [MS] Make constexpr static data

[PATCH] D43462: [clangd] Fixes for #include insertion.

ioeric created this revision. ioeric added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, jkorous-apple, klimek. o Avoid inserting a header include into the header itself. o Avoid inserting non-header files. o Canonicalize include paths for symbols in dynamic index.

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

miyuki added a comment. No, I'll commit it myself. Thank you for the review. https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

CarlosAlbertoEnciso added a subscriber: aheejin. CarlosAlbertoEnciso added a comment. Thanks @aheejin Repository: rL LLVM https://reviews.llvm.org/D42640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r325483 - [AVR] Set the program address space in the data layout

Author: dylanmckay Date: Mon Feb 19 02:46:16 2018 New Revision: 325483 URL: http://llvm.org/viewvc/llvm-project?rev=325483=rev Log: [AVR] Set the program address space in the data layout This is accompanied by r325481 in LLVM. Modified: cfe/trunk/lib/Basic/Targets/AVR.h Modified:

[PATCH] D43440: clang-format: [JS] fix `of` detection.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Repository: rC Clang https://reviews.llvm.org/D43440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind

ilya-biryukov updated this revision to Diff 134888. ilya-biryukov added a comment. - Rename printCompletionKind to getCompletionKindString Repository: rC Clang https://reviews.llvm.org/D43379 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/CodeCompleteConsumer.cpp Index:

[PATCH] D43377: [clangd] Attach more information about Sema completion to traces

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325491: [clangd] Attach more information about Sema completion to traces (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D43377?vs=134889=134892#toc

r325496 - [CodeComplete] Avoid name clashes of 'Kind' inside CodeCompletionContext. NFC

Author: ibiryukov Date: Mon Feb 19 05:53:49 2018 New Revision: 325496 URL: http://llvm.org/viewvc/llvm-project?rev=325496=rev Log: [CodeComplete] Avoid name clashes of 'Kind' inside CodeCompletionContext. NFC CodeCompletionContext had declarations of field and enum inside, both named 'Kind'. It

[PATCH] D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind

sammccall added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:355 +/// \brief Get string representation of \p Kind, useful for for debugging. +llvm::StringRef printCompletionKind(enum CodeCompletionContext::Kind Kind); + ilya-biryukov

[clang-tools-extra] r325491 - [clangd] Attach more information about Sema completion to traces

Author: ibiryukov Date: Mon Feb 19 04:35:57 2018 New Revision: 325491 URL: http://llvm.org/viewvc/llvm-project?rev=325491=rev Log: [clangd] Attach more information about Sema completion to traces Reviewers: hokein, ioeric, sammccall Reviewed By: sammccall Subscribers: klimek, cfe-commits,

r325490 - [CodeComplete] Add a helper to print CodeCompletionContext::Kind

Author: ibiryukov Date: Mon Feb 19 04:35:33 2018 New Revision: 325490 URL: http://llvm.org/viewvc/llvm-project?rev=325490=rev Log: [CodeComplete] Add a helper to print CodeCompletionContext::Kind Summary: Will be used in clangd. See D43377. Reviewers: sammccall Reviewed By: sammccall

[PATCH] D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind

This revision was automatically updated to reflect the committed changes. Closed by commit rC325490: [CodeComplete] Add a helper to print CodeCompletionContext::Kind (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D43379?vs=134888=134891#toc

[PATCH] D42569: [ARM] disable FPU features when using soft floating point.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325492: [ARM] disable FPU features when using soft floating point. (authored by kwalker, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43455: [clangd] Add brief instructions on how to make a release for vscode-clangd extension.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. thanks! couple of nits Comment at: clangd/clients/clangd-vscode/README.md:55 + +Everytime you make a change to `clangd-vscode`, you are expected to publish a +new

[PATCH] D43452: [clangd] Bump vs-code clangd extension v0.0.3

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (Do we need to bump this for the market to update properly? How do we decide when to bump it?) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43452

[PATCH] D43452: [clangd] Bump vs-code clangd extension v0.0.3

hokein added a comment. In https://reviews.llvm.org/D43452#1011825, @sammccall wrote: > (Do we need to bump this for the market to update properly? How do we decide > when to bump it?) Yes, every time we need to make a new release extension to vscode market, we need to bump the version.

Re: [PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

I've sent r325482 which (hopefully) fixes the failure. I'll keep an eye on the bot to make sure this is fixed ASAP. Sorry about the inconvenience! o Eric On Mon, Feb 19, 2018 at 11:39 AM Carlos Alberto Enciso via Phabricator < revi...@reviews.llvm.org> wrote: > CarlosAlbertoEnciso added a

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

kosarev updated this revision to Diff 134877. kosarev edited the summary of this revision. kosarev added a comment. Do not change the size field of may-alias TBAA descriptors for now. https://reviews.llvm.org/D42366 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenTBAA.cpp

[clang-tools-extra] r325482 - [clangd] Try to fix build bot failure caused by r325343: escape regex string.

Author: ioeric Date: Mon Feb 19 02:45:48 2018 New Revision: 325482 URL: http://llvm.org/viewvc/llvm-project?rev=325482=rev Log: [clangd] Try to fix build bot failure caused by r325343: escape regex string. Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp Modified:

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

ilya-biryukov added a comment. In https://reviews.llvm.org/D39571#1007393, @simark wrote: > If I do it in this order, I get one diagnostic both times, when I don't > expect one the second time the file is parsed. But if I do it the other way > (first parse with no errors, second parse with an

[PATCH] D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind

ilya-biryukov added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:355 +/// \brief Get string representation of \p Kind, useful for for debugging. +llvm::StringRef printCompletionKind(enum CodeCompletionContext::Kind Kind); + sammccall

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. Great work! Some more review... Comment at: clang-doc/ClangDoc.cpp:32 + ECtx.reportResult( + Name, Mapper.emitInfo(D, getComment(D), Name, getLine(D), getFile(D))); +} I wonder if `Name` should be `std::move()`'d ? Or not,

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added inline comments. Comment at: clang-doc/ClangDocBinary.h:82 + +static std::map BlockIdNameMap = { + {NAMESPACE_BLOCK_ID, "NamespaceBlock"}, lebedev.ri wrote: > Nice! > Some thoughts: > 1. I agree it makes sense to keep it

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

lebedev.ri added a comment. clang 6.0 defaults to C++14, BTW. https://reviews.llvm.org/D34365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43455: [clangd] Add brief instructions on how to make a release for vscode-clangd extension.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43455 Files: clangd/clients/clangd-vscode/README.md Index:

[PATCH] D43377: [clangd] Attach more information about Sema completion to traces

ilya-biryukov updated this revision to Diff 134889. ilya-biryukov added a comment. - Rename usage of printCompletionKind to getCompletionKindString - Remove tracing of the filename, TUScheduler now provides those traces Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43377

r325492 - [ARM] disable FPU features when using soft floating point.

Author: kwalker Date: Mon Feb 19 04:40:26 2018 New Revision: 325492 URL: http://llvm.org/viewvc/llvm-project?rev=325492=rev Log: [ARM] disable FPU features when using soft floating point. To be compatible with GCC if soft floating point is in effect any FPU specified is effectively ignored, eg,

[PATCH] D43462: [clangd] Fixes for #include insertion.

ioeric updated this revision to Diff 134932. ioeric marked 6 inline comments as done. ioeric added a comment. - Stop indexing main files in dynamic index; addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43462 Files: clangd/ClangdServer.cpp

[PATCH] D43462: [clangd] Fixes for #include insertion.

ioeric added inline comments. Comment at: clangd/Headers.cpp:45 +bool hasHeaderExtension(PathRef Path) { + constexpr static const char *HeaderExtensions[] = {".h", ".hpp", ".hh", + ".hxx"}; ilya-biryukov

[PATCH] D43465: [clang-format] Fixup a case of text proto message attributes

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This patch fixes a case where a proto message attribute is wrongly identified as an text proto extension. Repository: rC Clang https://reviews.llvm.org/D43465 Files: lib/Format/TokenAnnotator.cpp

[PATCH] D43465: [clang-format] Fixup a case of text proto message attributes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL325509: [clang-format] Fixup a case of text proto message attributes (authored by krasimir, committed by ). Herald added

[PATCH] D43454: [clangd] Do not reuse preamble if compile args changed

simark accepted this revision. simark added a comment. This revision is now accepted and ready to land. I don't have the setup to test at the moment, but the code looks good to me. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43454

[PATCH] D41102: Setup clang-doc frontend framework

sammccall added a comment. Naming conventions tend to stick around for a while - `clang-doc/ClangDocXYZ.h` seems a bit unwieldy compared to `clang-doc/XYZ.h` - might be worth considering. Comment at: clang-doc/ClangDoc.cpp:37 + Context = Result.Context; + if (const auto *M

[PATCH] D43465: [clang-format] Fixup a case of text proto message attributes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC325509: [clang-format] Fixup a case of text proto message attributes (authored by krasimir, committed by ). Changed

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX325510: [libcxx] Improve accuracy of complex asinh and acosh (authored by miyuki, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D41629 Files: include/complex

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I'm fine with that plan. LGTM. https://reviews.llvm.org/D42366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43430: Omit nullptr check for sufficiently simple delete-expressions

rjmccall added a comment. Discourse nitpick: I would encourage you to just use the ordinary phrase "null pointer", or just "null", when referring to a pointer value that happens to be null and to reserve "nullptr" for *statically* null pointers, especially the `nullptr` expression. If the

[PATCH] D42840: [docs] Fix duplicate arguments for JoinedAndSeparate

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but you should wait a few days in case Richard has thoughts or concerns. Repository: rC Clang https://reviews.llvm.org/D42840

[PATCH] D43459: [X86] Disable CLWB in Cannon Lake

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D43459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

tbourvon updated this revision to Diff 134936. tbourvon added a comment. This updates the patch to use `clang::tooling::fixit::getText()` instead of the custom `getStmtText`. This also adds a macro unit test. https://reviews.llvm.org/D37014 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D43462: [clangd] Fixes for #include insertion.

sammccall added inline comments. Comment at: clangd/Headers.h:26 /// /// \param Header is an absolute file path. +/// \return A quoted "path" or . This returns an empty string if: File also needs to be absolute. (May want to add asserts for this at the start

[PATCH] D43462: [clangd] Fixes for #include insertion.

ioeric updated this revision to Diff 134944. ioeric marked 2 inline comments as done. ioeric added a comment. - added a comment about thread safety Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43462 Files: clangd/ClangdServer.cpp clangd/Headers.cpp clangd/Headers.h

[PATCH] D43462: [clangd] Fixes for #include insertion.

ioeric updated this revision to Diff 134943. ioeric marked 3 inline comments as done. ioeric added a comment. - addressed comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43462 Files: clangd/ClangdServer.cpp clangd/Headers.cpp clangd/Headers.h

[PATCH] D43462: [clangd] Fixes for #include insertion.

ioeric marked 5 inline comments as done. ioeric added inline comments. Comment at: clangd/Headers.cpp:60 Argv.push_back(S.c_str()); IgnoringDiagConsumer IgnoreDiags; auto CI = clang::createInvocationFromCommandLine( ilya-biryukov wrote: > Not related

[PATCH] D43462: [clangd] Fixes for #include insertion.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325523: [clangd] Fixes for #include insertion. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D43462?vs=134947=134952#toc Repository: rL LLVM

  1   2   >