[PATCH] D46758: [clang-format] Move #include related style to libToolingCore

ilya-biryukov added a comment. LG. Just a quick comment about possibly unrelated change. Comment at: lib/Format/Format.cpp:2277 auto Replace = -Includes.insert(trimInclude(IncludeName), IncludeName.startswith("<")); +

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

lebedev.ri added a comment. In https://reviews.llvm.org/D45766#1097797, @ksu.shadura wrote: > Thank you for the test example! I got your point, but I wanted to ask if it > should be like this for commutative operations? > In our case it is actually matrix, and subtraction of matrices is not

[PATCH] D46639: [CodeComplete] Provide completion in decls even for incomplete types

This revision was automatically updated to reflect the committed changes. Closed by commit rL332244: [CodeComplete] Provide completion in decls even for incomplete types (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r332244 - [CodeComplete] Provide completion in decls even for incomplete types

Author: ibiryukov Date: Mon May 14 06:50:36 2018 New Revision: 332244 URL: http://llvm.org/viewvc/llvm-project?rev=332244=rev Log: [CodeComplete] Provide completion in decls even for incomplete types Summary: This change fixes lack of completions in the following case ('^'designates completion

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

ilya-biryukov added inline comments. Comment at: tools/libclang/CIndexCodeCompletion.cpp:309 + /// before that result for the corresponding completion item. + std::vector FixItsVector; }; yvvan wrote: > ilya-biryukov wrote: > > Storing

[PATCH] D46112: Allow _Atomic to be specified on incomplete types

aaron.ballman marked 8 inline comments as done. aaron.ballman added inline comments. Comment at: lib/Sema/SemaType.cpp:7604-7608 + // When instantiating a class template and reaching an atomic type, the check + // for type completeness should occur on the underlying type and

[PATCH] D46112: Allow _Atomic to be specified on incomplete types

aaron.ballman updated this revision to Diff 146594. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review comments. https://reviews.llvm.org/D46112 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Type.cpp

[PATCH] D46497: [clangd] Populate #include insertions as additional edits in completion items.

sammccall added inline comments. Comment at: clangd/CodeComplete.cpp:247 +// Calculates include path and insertion edit for a new header. +class IncludeInserter { +public: Do you think it would make sense to move this class to Headers.h? This would reduce the

[PATCH] D46524: [clangd] Extract scoring/ranking logic, and shave yaks.

sammccall updated this revision to Diff 146591. sammccall marked an inline comment as done. sammccall added a comment. Doxygen Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46524 Files: clangd/CMakeLists.txt clangd/CodeComplete.cpp clangd/Quality.cpp clangd/Quality.h

[PATCH] D46398: [ASTImporterTest] Fix potential use-after-free

a.sidorin updated this revision to Diff 146589. a.sidorin added a comment. Add forgotten context. Repository: rC Clang https://reviews.llvm.org/D46398 Files: unittests/AST/ASTImporterTest.cpp Index: unittests/AST/ASTImporterTest.cpp

[PATCH] D46398: [ASTImporterTest] Fix potential use-after-free

a.sidorin updated this revision to Diff 146587. a.sidorin added a comment. After a number of attempts of Twine'ifying all Code samples, I decided to restore the initial state of this code. Repository: rC Clang https://reviews.llvm.org/D46398 Files: unittests/AST/ASTImporterTest.cpp

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

ksu.shadura added a comment. Thank you for the test example! I got your point, but I wanted to ask if it should be like this for commutative operations? In our case it is actually matrix, and subtraction of matrices is not commutative operation.. Repository: rL LLVM

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. In https://reviews.llvm.org/D41537#1097763, @ilya-biryukov wrote: > I should've suggested splitting the change into two earlier. Next time I will do that from the beginning :) Comment at: tools/libclang/CIndexCodeCompletion.cpp:309 + /// before that

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

ilya-biryukov added a comment. In https://reviews.llvm.org/D41537#1097601, @yvvan wrote: > I hope this review will be over some day :) Sorry for keeping it that long. FWIW, I think we keep jumping back and forth between the clang and libclang changes here. I should've suggested splitting the

[PATCH] D46524: [clangd] Extract scoring/ranking logic, and shave yaks.

sammccall updated this revision to Diff 146584. sammccall added a comment. fix diffbase? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46524 Files: clangd/CMakeLists.txt clangd/CodeComplete.cpp clangd/Quality.cpp clangd/Quality.h unittests/clangd/CMakeLists.txt

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

lebedev.ri added a comment. In https://reviews.llvm.org/D45766#1097736, @ksu.shadura wrote: > Hi, Hi. > we see the false-positive behavior of -Wno-self-assign-overloaded flag in > case of subtraction assignment operator. > The minimal reproducer that we got: https://godbolt.org/g/8PQMpR >

[PATCH] D46805: If some platforms do not support an attribute, we should exclude the platform

HLJ2009 marked 4 inline comments as done. HLJ2009 added inline comments. Comment at: include/clang/Basic/Attr.td:327 +def TargetDarwinNegative : TargetArch<["x86", "x86_64"]> { + let OSes = ["MacOSX"]; + let Negated = 1; aaron.ballman wrote: > I would expect

[PATCH] D46675: [clangd] Add helper for collecting #include directives in file.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE332237: [clangd] Add helper for collecting #include directives in file. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D46675?vs=146581=146583#toc Repository:

[clang-tools-extra] r332237 - [clangd] Add helper for collecting #include directives in file.

Author: ioeric Date: Mon May 14 05:19:16 2018 New Revision: 332237 URL: http://llvm.org/viewvc/llvm-project?rev=332237=rev Log: [clangd] Add helper for collecting #include directives in file. Summary: Separate unit tests for the new function will be added in followup patch which will further

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

ksu.shadura added a comment. Hi, we see the false-positive behavior of -Wno-self-assign-overloaded flag in case of subtraction assignment operator. The minimal reproducer that we got: https://godbolt.org/g/8PQMpR typedef int Int_t; typedef double Double_t; class TObject {}; template

r332236 - Redirect output to /dev/null in the tests added in r332160.

Author: ioeric Date: Mon May 14 05:07:56 2018 New Revision: 332236 URL: http://llvm.org/viewvc/llvm-project?rev=332236=rev Log: Redirect output to /dev/null in the tests added in r332160. Modified: cfe/trunk/test/Driver/clang-abi-compat.cpp Modified:

[PATCH] D46675: [clangd] Add helper for collecting #include directives in file.

ioeric updated this revision to Diff 146581. ioeric marked an inline comment as done. ioeric added a comment. - Merged with origin/master - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46675 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h

[clang-tools-extra] r332233 - [clangd] Fix warning after fully covered enum switch. NFC.

Author: ibiryukov Date: Mon May 14 04:47:30 2018 New Revision: 332233 URL: http://llvm.org/viewvc/llvm-project?rev=332233=rev Log: [clangd] Fix warning after fully covered enum switch. NFC. By adding llvm_unreachable. Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified:

[PATCH] D46675: [clangd] Add helper for collecting #include directives in file.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/ClangdUnit.h:53 std::vector Diags; - InclusionLocations IncLocations; + std::vector Inclusions; }; this might be a good

r332232 - Revert "[CodeGen] Disable aggressive structor optimizations at -O0"

Author: labath Date: Mon May 14 04:35:44 2018 New Revision: 332232 URL: http://llvm.org/viewvc/llvm-project?rev=332232=rev Log: Revert "[CodeGen] Disable aggressive structor optimizations at -O0" It breaks the sanitizer build

r332228 - [CodeGen] Disable aggressive structor optimizations at -O0

Author: labath Date: Mon May 14 04:02:23 2018 New Revision: 332228 URL: http://llvm.org/viewvc/llvm-project?rev=332228=rev Log: [CodeGen] Disable aggressive structor optimizations at -O0 Summary: Removing the full structor and replacing all usages with the base one can degrade debug quality as

[PATCH] D46685: [CodeGen] Disable structor optimizations at -O0

This revision was automatically updated to reflect the committed changes. Closed by commit rC332228: [CodeGen] Disable aggressive structor optimizations at -O0 (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D46685?vs=146309=146578#toc Repository: rC

[PATCH] D46685: [CodeGen] Disable structor optimizations at -O0

labath added a comment. Thank you for the quick review. Repository: rC Clang https://reviews.llvm.org/D46685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46795: [clangd] Don't query index when completing inside classes

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE332226: [clangd] Dont query index when completing inside classes (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D46795?vs=146571=146574#toc Repository:

[clang-tools-extra] r332226 - [clangd] Don't query index when completing inside classes

Author: ibiryukov Date: Mon May 14 03:50:04 2018 New Revision: 332226 URL: http://llvm.org/viewvc/llvm-project?rev=332226=rev Log: [clangd] Don't query index when completing inside classes Summary: We used to query the index when completing after class qualifiers, e.g. 'ClassName::^'. We should

[PATCH] D46795: [clangd] Don't query index when completing inside classes

ilya-biryukov added inline comments. Comment at: unittests/clangd/CodeCompleteTests.cpp:829 +TEST(CompletionTest, NoIndexCompletionsInsideClasses) { + // clang-format off + auto Completions = completions(R"cpp( sammccall wrote: > Can we avoid disabling

[PATCH] D46795: [clangd] Don't query index when completing inside classes

ilya-biryukov updated this revision to Diff 146571. ilya-biryukov marked 5 inline comments as done. ilya-biryukov added a comment. - Address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46795 Files: clangd/CodeComplete.cpp

[PATCH] D46742: [X86] Use __builtin_convertvector to replace some of the avx512 truncate builtins.

GBuella accepted this revision. GBuella added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D46742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella requested review of this revision. GBuella added a comment. Oops, accepted this by accident. Repository: rC Clang https://reviews.llvm.org/D45616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella accepted this revision. GBuella added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46824: [clang-format] Continue after non-scope-closers in getLengthToMatchingParen

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC332225: [clang-format] Continue after non-scope-closers in getLengthToMatchingParen (authored by krasimir, committed by

r332225 - [clang-format] Continue after non-scope-closers in getLengthToMatchingParen

Author: krasimir Date: Mon May 14 03:33:40 2018 New Revision: 332225 URL: http://llvm.org/viewvc/llvm-project?rev=332225=rev Log: [clang-format] Continue after non-scope-closers in getLengthToMatchingParen Summary: This fixes a regression introduced by `r331857` where we stop the search for the

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. ping I hope this review won't take forever :) https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46694: [diagtool] Install diagtool

JDevlieghere added a comment. In https://reviews.llvm.org/D46694#1094617, @dexonsmith wrote: > This SGTM, but I wouldn't mind hearing from others. I wonder if this is > worth a quick RFC on cfe-dev? Sounds good, I've created a thread here:

[PATCH] D46824: [clang-format] Continue after non-scope-closers in getLengthToMatchingParen

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This fixes a regression introduced by `r331857` where we stop the search for the End token as soon as we hit a non-scope-closer, which prematurely stops before semicolons for example, which should otherwise be

[PATCH] D33844: [clang-tidy] terminating continue check

This revision was automatically updated to reflect the committed changes. Closed by commit rL332223: [clang-tidy] Add terminating continue check (authored by xazax, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[PATCH] D46823: [analyzer] const init: handle non-explicit cases more accurately

r.stahl created this revision. r.stahl added reviewers: NoQ, xazax.hun, george.karpenkov. Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet. If the access is out of bounds, return UndefinedVal. If it is missing an explicit init, return the implicit zero value it must have.

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

asb created this revision. asb added reviewers: efriedma, phosek, apazos. Herald added subscribers: mgrang, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, jordy.potman.lists, simoncook, johnrusso, rbar, arichardson, mgorny, emaste. Herald added a reviewer: espindola. This patch

[PATCH] D46820: Fix __uuidof handling on non-type template parameter in C++17

tzik created this revision. tzik added reviewers: rsmith, thakis. Herald added a subscriber: cfe-commits. Clang used to pass the base lvalue of a non-type template parameter to the template instantiation phase when the base part is __uuidof and it's running in C++17 mode. However, that drops its

r332222 - [RISCV][NFC] Use more appropriate label for CHECK lines

Author: asb Date: Mon May 14 02:14:43 2018 New Revision: 33 URL: http://llvm.org/viewvc/llvm-project?rev=33=rev Log: [RISCV][NFC] Use more appropriate label for CHECK lines 'CC1' was a misleading prefix. Committing so as to simplify the diff for a patch I'm about to put up for review.

[PATCH] D46001: [CodeComplete] Expose helpers to get RawComment of completion result.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is pretty small and seems unlikely to be controversial. I think it's OK to commit at this point, it's been a few weeks. Comment at:

[PATCH] D45999: [clangd] Retrieve minimally formatted comment text in completion.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Looks good, nits as always and I think you want a new test case. Comment at: clangd/CodeComplete.cpp:817 Result.IncludeGlobals = true; -

[PATCH] D46795: [clangd] Don't query index when completing inside classes

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/CodeComplete.cpp:810 +return false; + auto Scope = CC.getCXXScopeSpecifier(); + if (!Scope) we could use a high level

<    1   2