As a near term fix, I've tried to shorten the path in r334574. Let's
see if the bot likes it.
On Wed, Jun 13, 2018 at 6:34 AM, Galina Kistanova via cfe-commits
wrote:
> That could be the case. However, the bot shall not be left red.
>
> Hans, could you revert the patch for now, till the problem
ebevhan added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:1187
+
+ uint64_t Base = (radix == 16) ? 2 : 10;
+ if (BaseShift > 0) {
leonardchan wrote:
> ebevhan wrote:
> > I don't think loops are needed here. BaseShift is essentially Exponent so
> >
Quuxplusone added inline comments.
Comment at: include/experimental/memory_resource:489
+memory_resource* __res_;
+size_t __next_buffer_size_;
+};
Quuxplusone wrote:
> I've discovered that Boost.Container does not bother to preserve this state
> across
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48083
___
cfe-commits mailing list
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.h:38
llvm::Optional CompileCommandsDir,
- const ClangdServer::Options );
+ const ClangdServer::Options , bool
CacheCompileCommands);
ethanhs accepted this revision.
ethanhs added a comment.
Works great!
https://reviews.llvm.org/D47672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik updated this revision to Diff 151116.
nik added a comment.
Addressed comments.
Repository:
rC Clang
https://reviews.llvm.org/D48116
Files:
include/clang-c/Index.h
include/clang/Basic/Diagnostic.h
lib/Basic/DiagnosticIDs.cpp
test/Index/ignore-warnings-from-headers.cpp
ilya-biryukov added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:141
+ "come from the compilation databases."),
+llvm::cl::init(false), llvm::cl::Hidden);
+
sammccall wrote:
> ilya-biryukov wrote:
> > sammccall wrote:
> > >
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a few nits. And comment requests for things that were unclear when
reading the code.
Comment at: clangd/FuzzyMatch.cpp:269
+ :
Author: ibiryukov
Date: Wed Jun 13 02:20:41 2018
New Revision: 334585
URL: http://llvm.org/viewvc/llvm-project?rev=334585=rev
Log:
[clangd] Move caching of compile args out of ClangdServer.
Summary:
Caching is now handled by ClangdLSPServer and hidden behind the
GlobalCompilationDatabase
lebedev.ri added a comment.
In https://reviews.llvm.org/D45679#1122826, @shuaiwang wrote:
> Thanks a lot for the review!
>
> Could you also help commit this diff as well? Thanks!
There are at least two previous accepted differentials
(https://reviews.llvm.org/D17586,
sammccall added a comment.
@ilya-biryukov ping. I'm excited about this change :-)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nik created this revision.
Herald added a subscriber: cfe-commits.
Depending on the included files and the used warning flags, e.g. -
Weverything, a huge number of warnings can be reported for included
files. As processing that many diagnostics comes with a performance
impact and not all clients
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE334585: [clangd] Move caching of compile args out of
ClangdServer. (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48068?vs=151113=151114#toc
Repository:
ebevhan added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:89
+ // corresponding unsaturated types.
+ unsigned char ShortAccumFBits, ShortAccumIBits;
+ unsigned char AccumFBits, AccumIBits;
leonardchan wrote:
> ebevhan wrote:
> > leonardchan
Quuxplusone updated this revision to Diff 151112.
Quuxplusone added a comment.
Herald added a subscriber: christof.
- Shrink monotonic_buffer_resource, and make release() not "leak" allocation
size.
Repeatedly calling allocate() and release() in a loop should not blow up. I
originally
nik added inline comments.
Comment at: include/clang-c/Index.h:5302
+CXCodeCompleteResults *results, unsigned completion_index,
+unsigned fixit_index, CXSourceRange *replacement_range);
+
Please document the parameters. It's more important here than for
Author: hans
Date: Tue Jun 12 23:48:40 2018
New Revision: 334574
URL: http://llvm.org/viewvc/llvm-project?rev=334574=rev
Log:
crash-report-modules.m: Shorten path length to make Windows bot happy
Modified:
cfe/trunk/test/Driver/crash-report-modules.m
Modified:
The bot turned green:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10234
On Wed, Jun 13, 2018 at 8:54 AM, Hans Wennborg wrote:
> As a near term fix, I've tried to shorten the path in r334574. Let's
> see if the bot likes it.
>
> On Wed, Jun 13, 2018 at 6:34 AM,
hans added a comment.
Ross, do you have commit access or do you need someone to commit this for you?
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Nice! Looks good to me.
https://reviews.llvm.org/D47672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yvvan added a comment.
Cool! That's actually quite a small change with big outcome!
Comment at: include/clang/Basic/Diagnostic.h:216
+ // Suppress warnings from all included files.
+ bool SuppressWarningsFromIncludedFiles = false;
Probably mention that it
Author: sammccall
Date: Tue Jun 12 23:25:36 2018
New Revision: 334572
URL: http://llvm.org/viewvc/llvm-project?rev=334572=rev
Log:
[clangd] Log completion context type. NFC
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp
sammccall added a comment.
Generally LG.
I guess you might be able to test this by starting with a/compile_flags.txt and
a/b/x.cc, and then adding a/b/compile_flags.txt?
Comment at: clangd/ClangdLSPServer.h:38
llvm::Optional CompileCommandsDir,
-
Author: void
Date: Tue Jun 12 23:33:59 2018
New Revision: 334573
URL: http://llvm.org/viewvc/llvm-project?rev=334573=rev
Log:
Remove extraneous semicolon.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
krasimir requested changes to this revision.
krasimir added a comment.
This revision now requires changes to proceed.
Sorry, I'm not familiar with this tool. Could you elaborate:
- why is this switch necessary?
- what's expected to be supported with it?
- how do I test it?
sammccall updated this revision to Diff 151104.
sammccall added a comment.
Fix completion tests. (Simplify a bit - no need to re-test all the nuances of
fuzzy matching there).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47950
Files:
clangd/FuzzyMatch.cpp
Author: ctopper
Date: Wed Jun 13 00:19:28 2018
New Revision: 334577
URL: http://llvm.org/viewvc/llvm-project?rev=334577=rev
Log:
[X86] Remove masking from avx512vbmi2 concat and shift by immediate builtins.
Use select builtins instead.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
ilya-biryukov updated this revision to Diff 151113.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48068
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
ilya-biryukov added inline comments.
Comment at: clangd/GlobalCompilationDatabase.cpp:137
+ // 'It' may be invalid at this point, recompute it.
+ It = Cached.find(File);
+ if (It != Cached.end())
sammccall wrote:
> `return try_emplace(File,
sammccall added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:141
+ "come from the compilation databases."),
+llvm::cl::init(false), llvm::cl::Hidden);
+
ilya-biryukov wrote:
> sammccall wrote:
> > init(true) to avoid changing
chill added a comment.
Ping?
https://reviews.llvm.org/D46013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yvvan updated this revision to Diff 151124.
yvvan added a comment.
Diff with unix line endings
https://reviews.llvm.org/D46862
Files:
include/clang-c/Index.h
include/clang/Sema/CodeCompleteConsumer.h
test/Index/complete-arrow-dot.cpp
tools/c-index-test/c-index-test.c
SjoerdMeijer added a comment.
Nits title:
- Think you can simplify the title to something along the lines of: "[AArch64]
Support the FP16 VCVTA_U16 intrinsic". No need to mention tests are added in
the subject (tests should always be added).
Nits summary:
- Arm v8.2a -> Armv8.2-A
- Aarch64
Author: yvvan
Date: Wed Jun 13 05:37:08 2018
New Revision: 334593
URL: http://llvm.org/viewvc/llvm-project?rev=334593=rev
Log:
[libclang] Optionally add code completion results for arrow instead of dot
Follow up for D41537 - libclang part.
Differential Revision: https://reviews.llvm.org/D46862
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334593: [libclang] Optionally add code completion results
for arrow instead of dot (authored by yvvan, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46862?vs=151124=151133#toc
LukeGeeson marked an inline comment as done.
LukeGeeson added a comment.
address Nit's and code comments, please see above.
Comment at: CodeGen/arm-v8.2a-neon-intrinsics.c:170
+// CHECK: ret <4 x i16> [[VCVT]]
+int16x4_t test_vcvta_u16_f16 (float16x4_t a) {
+ return
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Thanks. Looks like a straightforward fix to me.
Comment at: CodeGen/arm-v8.2a-neon-intrinsics.c:170
+// CHECK: ret <4 x i16> [[VCVT]]
+int16x4_t
yvvan updated this revision to Diff 151123.
yvvan marked 2 inline comments as done.
yvvan added a comment.
Address comments about Index.h new functions parameters
https://reviews.llvm.org/D46862
Files:
include/clang-c/Index.h
include/clang/Sema/CodeCompleteConsumer.h
r.stahl updated this revision to Diff 151138.
r.stahl added a comment.
remove stray include
Repository:
rC Clang
https://reviews.llvm.org/D47698
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334597: Correct behavior of __builtin_*_overflow and
constexpr. (authored by erichkeane, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48053
Files:
lib/Sema/SemaChecking.cpp
alexfh added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DeadStatusChecker.cpp:33
+
+const Expr *hasNullptr(const BinaryOperator *BO) const {
+ const Expr *ret = nullptr;
george.karpenkov wrote:
> Could this be rewritten as a matcher
LukeGeeson created this revision.
LukeGeeson added a reviewer: SjoerdMeijer.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.
-Added support for existing IP for vcvta_u16_f16 instrinsic for Arm v8.2a
-CGBuiltin simply adds cases for this intrinsic to gen the clang
Author: sammccall
Date: Wed Jun 13 04:31:20 2018
New Revision: 334589
URL: http://llvm.org/viewvc/llvm-project?rev=334589=rev
Log:
Revert "[clangd] Log completion context type. NFC"
This reverts commit r334572, which has a potential use-after-free.
Modified:
ebevhan added inline comments.
Comment at: test/Frontend/fixed_point_bit_widths.c:44
+
+// CHECK-NEXT: @size_SsF = dso_local global i{{[0-9]+}} 2
+// CHECK-NEXT: @size_SF = dso_local global i{{[0-9]+}} 4
Wait; should these dso_local be `{{.*}}`?
Repository:
ebevhan accepted this revision.
ebevhan added a comment.
This revision is now accepted and ready to land.
LGTM, but I'm not a code owner so maybe someone else should chime in if they
have any input.
Repository:
rC Clang
https://reviews.llvm.org/D46911
Author: erichkeane
Date: Wed Jun 13 06:25:11 2018
New Revision: 334597
URL: http://llvm.org/viewvc/llvm-project?rev=334597=rev
Log:
Correct behavior of __builtin_*_overflow and constexpr.
Enable these builtins to be called across a lambda
boundary with captureless const/constexpr, as brought up
spatel added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10090-10100
+// _CMP_TRUE_UQ, _CMP_TRUE_US produce -1,-1... vector
+// on any input and _CMP_FALSE_OQ, _CMP_FALSE_OS produce 0, 0...
+if (CC == 0xf || CC == 0xb || CC == 0x1b || CC == 0x1f) {
+
Prazek added a comment.
Friendly ping @hfinkel @rsmith
Repository:
rL LLVM
https://reviews.llvm.org/D47103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ebevhan added inline comments.
Comment at: lib/AST/ExprConstant.cpp:9437
+ }
+ return Success(-Value, E);
+}
This looks very suspect to me as well... This might not respect padding on
types whose sign bit is not the MSB, such as _Fract. The same
Author: stefanp
Date: Wed Jun 13 09:05:05 2018
New Revision: 334613
URL: http://llvm.org/viewvc/llvm-project?rev=334613=rev
Log:
[PowerPC] The __float128 type should only be available on Power9
Diasble the use of the type __float128 for PPC machines older
than Power9.
The use of -mfloat128 for
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:32
check::PostCall> {
- CallDescription CStrFn;
+ const llvm::SmallVector CStrFnFamily = {
+
mgrang created this revision.
mgrang added reviewers: mstorsjo, compnerd.
Herald added a reviewer: javed.absar.
Herald added subscribers: chrib, kristof.beyls.
These intrinsics result in hint instructions. They are provided here for MSVC
ARM64 compatibility.
Repository:
rC Clang
Author: aaronballman
Date: Wed Jun 13 08:02:34 2018
New Revision: 334606
URL: http://llvm.org/viewvc/llvm-project?rev=334606=rev
Log:
Reverting r334604 due to failing tests.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/31500
Removed:
leonardchan updated this revision to Diff 151184.
leonardchan marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D46911
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/AST/Type.h
Author: aaronballman
Date: Wed Jun 13 07:41:42 2018
New Revision: 334604
URL: http://llvm.org/viewvc/llvm-project?rev=334604=rev
Log:
Add a new class to analyze whether an expression is mutated within a statement.
ExprMutationAnalyzer is a generally useful helper that can be used in different
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r334604 with one minor change -- I added an include for
to the unit test so that `std::isspace()` would compile properly on all
platforms.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
takuto.ikuta added a comment.
Thank you!
https://reviews.llvm.org/D47578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman reopened this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I had to revert due to failing tests. The revert was done in r334606 and this
is an example of a failing bot:
ioeric updated this revision to Diff 151172.
ioeric added a comment.
- Rebased.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47935
Files:
clangd/CodeComplete.cpp
clangd/FindSymbols.cpp
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd/QualityTests.cpp
erichkeane updated this revision to Diff 151151.
erichkeane added a comment.
Separated out the other patch as Eli suggested (which has now been committed),
and rebased this patch on top of it.
https://reviews.llvm.org/D48040
Files:
lib/AST/ExprConstant.cpp
Author: prazek
Date: Wed Jun 13 06:55:42 2018
New Revision: 334600
URL: http://llvm.org/viewvc/llvm-project?rev=334600=rev
Log:
Add -fforce-emit-vtables
Summary:
In many cases we can't devirtualize
because definition of vtable is not present. Most of the
time it is caused by inline virtual
This revision was automatically updated to reflect the committed changes.
Prazek marked an inline comment as done.
Closed by commit rC334600: Add -fforce-emit-vtables (authored by Prazek,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47108?vs=150735=151154#toc
Repository:
MTC updated this revision to Diff 151166.
MTC added a comment.
- Use `hasName` matcher to match the qualified name.
- Use the full name, like `std::basic_string::c_str` instead of `c_str`
to match the `c_str` method in `DanglingInternalBufferChecker.cpp`.
Repository:
rC Clang
hans added a comment.
In https://reviews.llvm.org/D47578#1127749, @takuto.ikuta wrote:
> Rui-san, can I ask you to merge this?
Committed here:
http://llvm.org/viewvc/llvm-project?view=revision=334602
https://reviews.llvm.org/D47578
___
ioeric added a comment.
In https://reviews.llvm.org/D47935#1129987, @sammccall wrote:
> Sorry for the delay on this change. There's a bunch of complexity in this
> problem that I haven't seen how to slice through:
>
> 1. the signals needed seem like a weird fit for the Symbol*Signals structs
>
Author: morehouse
Date: Wed Jun 13 09:00:39 2018
New Revision: 334612
URL: http://llvm.org/viewvc/llvm-project?rev=334612=rev
Log:
[libclang] Make c-index-test.c ISO C90 compliant.
Fixes a build bot breakage caused by r334593.
Modified:
cfe/trunk/tools/c-index-test/c-index-test.c
Modified:
leonardchan added inline comments.
Comment at: test/Frontend/fixed_point_bit_widths.c:44
+
+// CHECK-NEXT: @size_SsF = dso_local global i{{[0-9]+}} 2
+// CHECK-NEXT: @size_SF = dso_local global i{{[0-9]+}} 4
ebevhan wrote:
> Wait; should these dso_local be
malaperle added a comment.
Does this change affect the switching of compilation database, through
workspace/didChangeConfiguration ?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48071
___
cfe-commits mailing list
ioeric updated this revision to Diff 151169.
ioeric added a comment.
- Introduced a one-per-query structure for relevance signals; use
multiplication for proximity; simplify tests a bit; separate index and sema
proximity scores.
Repository:
rCTE Clang Tools Extra
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334613: [PowerPC] The __float128 type should only be
available on Power9 (authored by stefanp, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
GBuella updated this revision to Diff 151203.
GBuella edited the summary of this revision.
GBuella added a comment.
Ignoring signaling behviour - and rounding mode with it.
Also lowering `__builtin_ia32_cmpsd` and `__builtin_ia32_cmpss`.
https://reviews.llvm.org/D45616
Files:
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
I'd like to see a couple of testcases ensuring the return value is correct on
overflow (we had a problem with that for __builtin_mul_overflow in the past).
Otherwise LGTM.
Author: tstellar
Date: Wed Jun 13 09:57:18 2018
New Revision: 334621
URL: http://llvm.org/viewvc/llvm-project?rev=334621=rev
Log:
Merging r323390:
r323390 | ericwf | 2018-01-24 16:02:48 -0800 (Wed, 24 Jan 2018) | 9 lines
Author: george.karpenkov
Date: Wed Jun 13 11:32:19 2018
New Revision: 334636
URL: http://llvm.org/viewvc/llvm-project?rev=334636=rev
Log:
[analyzer] Fix offset overflow check in MemRegion
rdar://39593879
https://bugs.llvm.org/show_bug.cgi?id=37142
Differential Revision:
erichkeane added a comment.
I believe my tests DO validate the return value correctly, don't they? It uses
a sentinel, but the ternary should check that return value, right?
Or is there an obvious thing I'm missing?
https://reviews.llvm.org/D48040
Author: d0k
Date: Wed Jun 13 09:45:12 2018
New Revision: 334619
URL: http://llvm.org/viewvc/llvm-project?rev=334619=rev
Log:
[Basic] Fix -Wreorder warning
Just use field initializers that don't suffer from this problem
Modified:
cfe/trunk/lib/Basic/Targets/PPC.h
Modified:
jlebar added a comment.
> Last comment in the bug pointed out that those overloads should be constexpr
> in c++14. Maybe in a separate patch, though.
Yeah, would prefer to do it in a separate patch. It's possible that having
constexpr min/max in C++14 mode *without a C++14 standard library*
spatel created this revision.
spatel added reviewers: gfalcon, lebedev.ri.
Herald added a subscriber: mcrosier.
https://bugs.llvm.org/show_bug.cgi?id=37778
...shows a miscompile resulting from marking nan builtins as 'const'.
The nan libcalls/builtins take a pointer argument:
ormris closed this revision.
ormris added a comment.
This change has been committed, so I'm closing this review.
https://reviews.llvm.org/rC334554
Repository:
rC Clang
https://reviews.llvm.org/D47044
___
cfe-commits mailing list
Author: spatel
Date: Wed Jun 13 10:54:52 2018
New Revision: 334628
URL: http://llvm.org/viewvc/llvm-project?rev=334628=rev
Log:
[CodeGen] make nan builtins pure rather than const (PR37778)
https://bugs.llvm.org/show_bug.cgi?id=37778
...shows a miscompile resulting from marking nan builtins as
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334628: [CodeGen] make nan builtins pure rather than const
(PR37778) (authored by spatel, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
george.karpenkov added a comment.
> This change has been committed, so I'm closing this review.
@ormris The process which should be followed here is to add a line (exactly)
"Differential Revision: https://reviews.llvm.org/D47044; to the bottom of your
commit message, so that the phabricator
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334639: [COFF] Add ARM64 intrinsics: __yield, __wfe, __wfi,
__sev, __sevl (authored by mgrang, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: mgrang
Date: Wed Jun 13 11:49:35 2018
New Revision: 334639
URL: http://llvm.org/viewvc/llvm-project?rev=334639=rev
Log:
[COFF] Add ARM64 intrinsics: __yield, __wfe, __wfi, __sev, __sevl
Summary: These intrinsics result in hint instructions. They are provided here
for MSVC ARM64
rkirsling added a comment.
I'll need someone to commit. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added a comment.
Ack.
https://reviews.llvm.org/D48036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GBuella added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10090-10100
+// _CMP_TRUE_UQ, _CMP_TRUE_US produce -1,-1... vector
+// on any input and _CMP_FALSE_OQ, _CMP_FALSE_OS produce 0, 0...
+if (CC == 0xf || CC == 0xb || CC == 0x1b || CC == 0x1f) {
+
leonardchan added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:89
+ // corresponding unsaturated types.
+ unsigned char ShortAccumFBits, ShortAccumIBits;
+ unsigned char AccumFBits, AccumIBits;
ebevhan wrote:
> leonardchan wrote:
> > ebevhan
spatel added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10107-10112
+case 0x0b: // FALSE_OQ
+case 0x1b: // FALSE_OS
+ return llvm::Constant::getNullValue(ConvertType(E->getType()));
+case 0x0f: // TRUE_UQ
+case 0x1f: // TRUE_US
+ return
ormris added a comment.
Thanks @george.karpenkov . I was wondering why it didn't close automatically.
Repository:
rC Clang
https://reviews.llvm.org/D47044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Meinersbur updated this revision to Diff 151209.
Meinersbur added a comment.
- Remove obsolete comment
- Refactor getOrderedEnableIfAttrs
Repository:
rC Clang
https://reviews.llvm.org/D48100
Files:
include/clang/Sema/AttributeList.h
lib/AST/ItaniumMangle.cpp
lib/Parse/ParseDecl.cpp
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D48132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
baloghadamsoftware added a comment.
Herald added a subscriber: mikhail.ramalho.
Any idea how to proceed?
https://reviews.llvm.org/D35110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Makes sense.
https://reviews.llvm.org/D48134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
craig.topper added a comment.
FWIW, I found a cfe-dev thread about adding HLE support
http://lists.llvm.org/pipermail/cfe-dev/2013-February/028031.html And a bunch
of dead patches in phabricator https://reviews.llvm.org/people/revisions/110/
I also spoke to Andi Kleen here at Intel to make
malaperle created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
This allows hovering on keywords that refer to deduced types.
This should cover most useful cases. Not covered:
- auto template parameters: Since this can be instantiated with many
rsmith added a comment.
Can we mark these as `argmemonly`?
Repository:
rL LLVM
https://reviews.llvm.org/D48134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
In https://reviews.llvm.org/D48134#1131626, @rsmith wrote:
> Can we mark these as `argmemonly`?
Header comment in `include/clang/Basic/Builtins.def` does not list that as a
possibility.
Repository:
rL LLVM
https://reviews.llvm.org/D48134
shuaiwang added a comment.
In https://reviews.llvm.org/D45679#1131115, @aaron.ballman wrote:
> I had to revert due to failing tests. The revert was done in r334606 and this
> is an example of a failing bot:
>
1 - 100 of 153 matches
Mail list logo
