This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335459: [clang-format] Keep @message together in text protos
(authored by krasimir, committed by ).
Changed prior to
chill updated this revision to Diff 152679.
chill added a comment.
Update: use "unadjusted alignment" instead of "natural alignment", rename
things accordingly.
https://reviews.llvm.org/D46013
Files:
include/clang/AST/ASTContext.h
include/clang/AST/RecordLayout.h
lib/AST/ASTContext.cpp
martong updated this revision to Diff 152660.
martong marked 2 inline comments as done.
martong added a comment.
- Clang format the test code snippet.
Repository:
rC Clang
https://reviews.llvm.org/D47534
Files:
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/CERTTidyModule.cpp:44
"cert-dcl54-cpp");
-CheckFactories.registerCheck(
-"cert-dcl58-cpp");
+
CheckFactories.registerCheck("cert-dcl58-cpp");
CheckFactories.registerCheck(
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335480: [ASTImporter] Import the whole redecl chain of
functions (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47532?vs=152691=152693#toc
Repository:
rC
Author: martong
Date: Mon Jun 25 07:41:58 2018
New Revision: 335480
URL: http://llvm.org/viewvc/llvm-project?rev=335480=rev
Log:
[ASTImporter] Import the whole redecl chain of functions
Summary:
With this patch when any `FunctionDecl` of a redeclaration chain is imported
then we bring in the
martong updated this revision to Diff 152674.
martong added a comment.
- Update commit comment and fix broken format in a comment.
Repository:
rC Clang
https://reviews.llvm.org/D47367
Files:
unittests/AST/ASTImporterTest.cpp
unittests/AST/Language.cpp
unittests/AST/Language.h
Index:
martong updated this revision to Diff 152691.
martong marked 3 inline comments as done.
martong added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D47532
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
lib/AST/DeclBase.cpp
Author: krasimir
Date: Mon Jun 25 04:08:24 2018
New Revision: 335449
URL: http://llvm.org/viewvc/llvm-project?rev=335449=rev
Log:
[clang-format] Fix end-of-file comments text proto formatting
Summary:
The case of end-of-file comments was formatted badly:
```
key: value
# end-of-file comment
klimek added inline comments.
Comment at: unittests/Format/FormatTest.cpp:4359
+ "return 3;\n"
+ " }).as("");\n"
+ "}");
ank wrote:
> klimek wrote:
> > What would be interesting is tests that:
> > a) have another
Author: martong
Date: Mon Jun 25 04:38:43 2018
New Revision: 335455
URL: http://llvm.org/viewvc/llvm-project?rev=335455=rev
Log:
[ASTImporter] Add new tests about templated-described swing
Summary:
Add a new test about importing a partial specialization (of a class). Also,
this patch adds new
hans updated this revision to Diff 152659.
hans added a comment.
Added special-casing for explicit template instantiations, and missing test
case suggested by Nico.
Please take another look.
https://reviews.llvm.org/D48426
Files:
include/clang/AST/ExternalASTSource.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335455: [ASTImporter] Add new tests about
templated-described swing (authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47534
martong added a comment.
I addressed the comments, thanks for the review!
Repository:
rC Clang
https://reviews.llvm.org/D47534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Herald added a subscriber: the_o.
Comment at: lib/Sema/SemaDeclAttr.cpp:5280
+ // Check the attribute arguments.
+ if (AL.getNumArgs() > 1) {
+S.Diag(AL.getLoc(), diag::err_attribute_too_many_arguments)
apazos wrote:
>
hans added inline comments.
Comment at: test/CodeGen/pch-dllexport.cpp:55
+template void __declspec(dllexport)
explicitInstantiationDefAfterDecl(T) {}
+extern template void explicitInstantiationDefAfterDecl(int);
+
thakis wrote:
> This has two interesting
thakis added inline comments.
Comment at: test/CodeGen/pch-dllexport.cpp:55
+template void __declspec(dllexport)
explicitInstantiationDefAfterDecl(T) {}
+extern template void explicitInstantiationDefAfterDecl(int);
+
hans wrote:
> thakis wrote:
> > This has
Author: martong
Date: Mon Jun 25 06:04:37 2018
New Revision: 335464
URL: http://llvm.org/viewvc/llvm-project?rev=335464=rev
Log:
[ASTImporter] Add ms compatibility to tests which use the TestBase
Summary:
In order to avoid build failures on MS, we use -fms-compatibility too in
the tests which
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335464: [ASTImporter] Add ms compatibility to tests which
use the TestBase (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47367?vs=152674=152675#toc
arichardson created this revision.
arichardson added a reviewer: atanasyan.
Herald added subscribers: cfe-commits, sdardis, emaste.
Repository:
rC Clang
https://reviews.llvm.org/D48549
Files:
lib/Basic/Targets/Mips.cpp
lib/Basic/Targets/Mips.h
lib/Driver/ToolChains/Arch/Mips.cpp
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM. the only minor nit
Comment at: lib/Driver/ToolChains/FreeBSD.cpp:321
// back to '/usr/lib' if it doesn't exist.
- if ((Triple.getArch() == llvm::Triple::x86
ank added a comment.
Is there any chance to get this change or a similar one in so we get same
behaviour as in release_40, even though it does not correct all of the problems?
Repository:
rC Clang
https://reviews.llvm.org/D45719
___
cfe-commits
yamaguchi added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
Author: ioeric
Date: Mon Jun 25 04:50:11 2018
New Revision: 335458
URL: http://llvm.org/viewvc/llvm-project?rev=335458=rev
Log:
[clangd] Always remove dots before converting paths to URIs in symbol collector.
Modified:
clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp
Modified:
ank added inline comments.
Comment at: unittests/Format/FormatTest.cpp:4359
+ "return 3;\n"
+ " }).as("");\n"
+ "}");
klimek wrote:
> ank wrote:
> > klimek wrote:
> > > What would be interesting is tests that:
> > >
erik.pilkington added a comment.
Ping! If it'd make this easier to review, I'd be happy to split this up a bit.
https://reviews.llvm.org/D46845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
thakis added a comment.
Still looks good, ship it! One more suggestion about additional test coverage
(but maybe it's already there and I'm just missing it).
Comment at: test/CodeGen/pch-dllexport.cpp:55
+template void __declspec(dllexport)
marco-c added a comment.
In https://reviews.llvm.org/D45454#1070884, @belleyb wrote:
> @chh I had a chance to try out your proposed changes. It's not causing us any
> trouble. In fact, `__gcov_flush()` is not even used at all (at least in LLVM
> 5.0.1).. I can recompile llvm, compiler_rt and
martong added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:2021
+
+TEST_P(ImportFriendFunctions,
+ DISABLED_ImportFriendFunctionRedeclChainDefWithClass_ImportTheProto) {
a_sidorin wrote:
> Could you add comments why these tests are
ebevhan added a comment.
Would it be possible to add some form of target hook (perhaps to
CodeGenABIInfo, which is already accessed with `getTargetHooks`) for
fixed-point operations (maybe even some conversions)? As I've mentioned
earlier, we emit both IR and intrinsics for many of these
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335466: [clang-cl] Dont emit dllexport inline
functions etc. from pch files (PR37801) (authored by hans, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48426
Files:
Author: hans
Date: Mon Jun 25 06:23:49 2018
New Revision: 335466
URL: http://llvm.org/viewvc/llvm-project?rev=335466=rev
Log:
[clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801)
With MSVC, PCH files are created along with an object file that needs to
be linked into the
krasimir created this revision.
Herald added a subscriber: cfe-commits.
The case of end-of-file comments was formatted badly:
key: value
# end-of-file comment
This patch fixes that formatting:
key: value
# end-of-file comment
Repository:
rC Clang
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335449: [clang-format] Fix end-of-file comments text proto
formatting (authored by krasimir, committed by ).
Herald added
yamaguchi updated this revision to Diff 152664.
yamaguchi added a comment.
use %clang_cc1 instead of %clang
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/ModuleMap.h
clang/lib/Lex/HeaderSearch.cpp
clang/test/Modules/Inputs/autoload-subdirectory/a.h
krasimir created this revision.
Herald added a subscriber: cfe-commits.
In C++ code snippets of the form `@field` are common. This makes clang-format
keep them together in text protos, whereas before it would break them.
Repository:
rC Clang
https://reviews.llvm.org/D48543
Files:
Author: krasimir
Date: Mon Jun 25 05:43:12 2018
New Revision: 335459
URL: http://llvm.org/viewvc/llvm-project?rev=335459=rev
Log:
[clang-format] Keep @message together in text protos
Summary:
In C++ code snippets of the form `@field` are common. This makes clang-format
keep them together in text
MTC updated this revision to Diff 152702.
MTC added a comment.
Sorry for the long long delay, I was on the Dragon Boat Festival a few days ago.
This update has two parts:
- Use the `matchesName` to match the AST node with the specified name,
`matchesName` use regex to match the specified name.
martong added a comment.
@labath
Sure, looking into it.
Repository:
rC Clang
https://reviews.llvm.org/D47532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martong added a comment.
This is not trivial to fix. Reverting until we can reproduce and fix it.
Reverted with commit: r335491
Repository:
rC Clang
https://reviews.llvm.org/D47532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnkovacs updated this revision to Diff 152719.
rnkovacs added a comment.
Fixed the constness of `c_str()` in the test file.
https://reviews.llvm.org/D48522
Files:
lib/StaticAnalyzer/Checkers/AllocationState.h
lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp
chh added a comment.
In https://reviews.llvm.org/D45454#1142197, @marco-c wrote:
> In https://reviews.llvm.org/D45454#1070884, @belleyb wrote:
>
> > @chh I had a chance to try out your proposed changes. It's not causing us
> > any trouble. In fact, `__gcov_flush()` is not even used at all (at
Author: paquette
Date: Mon Jun 25 10:27:51 2018
New Revision: 335503
URL: http://llvm.org/viewvc/llvm-project?rev=335503=rev
Log:
[MachineOutliner] Make last of -moutline/-mno-outline win
The expected behaviour of command-line flags to clang is to have
the last of -m(whatever) and
Author: paquette
Date: Mon Jun 25 10:36:05 2018
New Revision: 335504
URL: http://llvm.org/viewvc/llvm-project?rev=335504=rev
Log:
[MachineOutliner] Outline from linkonceodrs by default in LTO when -moutline is
passed
Pass -enable-linkonceodr-outlining by default when LTO is enabled.
The
martong updated this revision to Diff 152703.
martong added a comment.
- Rebase from master.
Repository:
rC Clang
https://reviews.llvm.org/D47632
Files:
include/clang/AST/ASTImporter.h
include/clang/AST/DeclBase.h
lib/AST/ASTImporter.cpp
lib/AST/ExternalASTMerger.cpp
Index:
labath added subscribers: aprantl, labath.
labath added a comment.
This has broken the LLDB bot
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/25132.
Could you take a look?
Repository:
rC Clang
https://reviews.llvm.org/D47532
xazax.hun added inline comments.
Comment at: test/Analysis/dangling-internal-buffer.cpp:10
const CharT *c_str();
+ const CharT *data();
};
Note that these methods are const according to the standard. Even if it does
not make any difference for this check
klimek added inline comments.
Comment at: unittests/Format/FormatTest.cpp:4359
+ "return 3;\n"
+ " }).as("");\n"
+ "}");
ank wrote:
> klimek wrote:
> > ank wrote:
> > > klimek wrote:
> > > > What would be
Author: ioeric
Date: Mon Jun 25 09:29:19 2018
New Revision: 335492
URL: http://llvm.org/viewvc/llvm-project?rev=335492=rev
Log:
[clang-format] Add a default format style that can be used by users of
`getStyle`
Summary:
Tools that reformat code often call `getStyle` to decide the format style
to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335492: [clang-format] Add a default format style that can
be used by users of… (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
Author: arichardson
Date: Mon Jun 25 09:49:52 2018
New Revision: 335495
URL: http://llvm.org/viewvc/llvm-project?rev=335495=rev
Log:
Use Triple::isMIPS() instead of enumerating all Triples. NFC
Reviewed By: atanasyan
Differential Revision: https://reviews.llvm.org/D48549
Modified:
gregrodgers added a comment.
Why not provide a specific list of --hip-device-lib= for VDI builds? I am not
sure about defining functions inside headers instead of using a hip bc lib.
Repository:
rC Clang
https://reviews.llvm.org/D48455
___
Author: abataev
Date: Mon Jun 25 08:32:05 2018
New Revision: 335483
URL: http://llvm.org/viewvc/llvm-project?rev=335483=rev
Log:
[OPENMP] Do not consider address constant vars as possibly
threadprivate.
Do not delay emission of the address constant variables in OpenMP mode
as they cannot be
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: martong
Date: Mon Jun 25 09:25:30 2018
New Revision: 335491
URL: http://llvm.org/viewvc/llvm-project?rev=335491=rev
Log:
Revert "[ASTImporter] Import the whole redecl chain of functions"
This reverts commit r335480.
Modified:
cfe/trunk/include/clang/AST/ASTImporter.h
arichardson updated this revision to Diff 152696.
arichardson added a comment.
Ran clang-format on the diff
Repository:
rC Clang
https://reviews.llvm.org/D48549
Files:
lib/Basic/Targets/Mips.cpp
lib/Basic/Targets/Mips.h
lib/Driver/ToolChains/Arch/Mips.cpp
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LG!
Repository:
rC Clang
https://reviews.llvm.org/D48532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335495: Use Triple::isMIPS() instead of enumerating all
Triples. NFC (authored by arichardson, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48549?vs=152696=152713#toc
Repository:
Author: sbc
Date: Mon Jun 25 11:47:32 2018
New Revision: 335510
URL: http://llvm.org/viewvc/llvm-project?rev=335510=rev
Log:
[WebAssembly] Add no-prototype attribute to prototype-less C functions
The WebAssembly backend in particular benefits from being
able to distinguish between varargs
rnkovacs updated this revision to Diff 152737.
rnkovacs marked an inline comment as done.
https://reviews.llvm.org/D48532
Files:
lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp
test/Analysis/dangling-internal-buffer.cpp
Index: test/Analysis/dangling-internal-buffer.cpp
rnkovacs added inline comments.
Comment at: test/Analysis/dangling-internal-buffer.cpp:10
const CharT *c_str();
+ const CharT *data();
};
xazax.hun wrote:
> Note that these methods are const according to the standard. Even if it does
> not make any
echristo added subscribers: dlj, echristo.
echristo added a comment.
I've added a couple of inline comments here - between this and the comments in
the post-commit review from dlj it seems like we might want to revert this for
now and figure out the best way forward.
Thanks!
-eric
jkorous created this revision.
jkorous added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, MaskRay, ioeric, ilya-biryukov, mgorny.
This is a self-contained pair of utility functions for the XPC transport layer.
It's not dependent on but following the refactoring patch:
Hi Nico,
Yes, I reverted because it broke one of the lldb build bots.
Next time I'll include the reason in the revert commit.
Gábor
On Mon, 25 Jun 2018, 22:50 Nico Weber, wrote:
> When reverting things, please say why in the commit message. (In this
> case, apparently because it broke the
ahatanak added a comment.
Yes, that is the case. It doesn't change overloading resolution, it is just
producing a diagnostic.
Repository:
rC Clang
https://reviews.llvm.org/D47757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vsapsai added a comment.
Ping.
https://reviews.llvm.org/D48342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335546: Add an option to support debug fission on implicit
ThinLTO. (authored by yunlian, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Meinersbur added a comment.
In https://reviews.llvm.org/D48100#1142866, @erichkeane wrote:
> I'm currently attempting to remove the AttributeList's linked-listness.
Thank you. This should also resolve the non-optimal asymptotic execution time
to append new attributes at the end of the list.
I don't have an objection having another interface which is just a simple
wrapper to __gcov_flush but with default visibility. Also clearly document
its usage and behavior.
David
On Mon, Jun 25, 2018 at 10:12 AM, Chih-Hung Hsieh via Phabricator via
llvm-commits wrote:
> chh added a comment.
>
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1241
if (const llvm::APSInt *I =
- SVB.getKnownValue(State, nonloc::SymbolVal(S)))
+ SVB.getKnownValue(State, SVB.makeSymbolVal(S)))
return
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1241
if (const llvm::APSInt *I =
- SVB.getKnownValue(State, nonloc::SymbolVal(S)))
+ SVB.getKnownValue(State, SVB.makeSymbolVal(S)))
return
smeenai added a comment.
Ah, the documentation is confusing, but CMAKE_FIND_ROOT_PATH and
CMAKE_FIND_ROOT_PATH_MODE_PACKAGE only have an effect when using the config
mode of find_package, whereas this invocation is using the module mode. That's
a bummer, and definitely makes custom sysroots
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: paquette
Date: Mon Jun 25 16:20:18 2018
New Revision: 335549
URL: http://llvm.org/viewvc/llvm-project?rev=335549=rev
Log:
[MachineOutliner] NFC - simplify -moutline/-mno-outline logic
It's a bit cleaner to use `hasFlag` instead of nested ifs. This
just refactors the
Author: dergachev
Date: Mon Jun 25 16:43:45 2018
New Revision: 33
URL: http://llvm.org/viewvc/llvm-project?rev=33=rev
Log:
[analyzer] Fix invalidation on C++ const methods with arrow syntax.
Conservative evaluation of a C++ method call would invalidate the object,
as long as the method
This revision was automatically updated to reflect the committed changes.
Closed by commit rC33: [analyzer] Fix invalidation on C++ const methods
with arrow syntax. (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48460?vs=152391=152805#toc
Author: ctopper
Date: Mon Jun 25 17:44:02 2018
New Revision: 335564
URL: http://llvm.org/viewvc/llvm-project?rev=335564=rev
Log:
[X86] Redefine avx512 packed fpclass intrinsics to return a vXi1 mask and
implement the mask input argument using an 'and' IR instruction.
Additional IR is emitted to
Author: bruno
Date: Mon Jun 25 15:24:17 2018
New Revision: 335542
URL: http://llvm.org/viewvc/llvm-project?rev=335542=rev
Log:
Warning for framework include violation from Headers to PrivateHeaders
Framework vendors usually layout their framework headers in the
following way:
Author: bruno
Date: Mon Jun 25 15:25:48 2018
New Revision: 335543
URL: http://llvm.org/viewvc/llvm-project?rev=335543=rev
Log:
Fix tests from r335542 to use %hmaptool
Modified:
cfe/trunk/test/Modules/framework-public-includes-private.m
Modified:
devnexen created this revision.
devnexen added a reviewer: dberris.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
- Base GNU ld is pretty old and does not support --dynamic-list flag.
- For conveniency we can add it automatically when compile
vsapsai added a comment.
Ping.
https://reviews.llvm.org/D47341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yunlian updated this revision to Diff 152794.
https://reviews.llvm.org/D44788
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/lto-dwo.c
Index: test/Driver/lto-dwo.c
===
--- /dev/null
+++ test/Driver/lto-dwo.c
@@ -0,0
srhines accepted this revision.
srhines added a comment.
Agree. This is the first time anyone is linking against static sanitizers on
Android, so this is just something that we missed updating in the past.
Repository:
rC Clang
https://reviews.llvm.org/D48570
Author: yunlian
Date: Mon Jun 25 16:05:27 2018
New Revision: 335546
URL: http://llvm.org/viewvc/llvm-project?rev=335546=rev
Log:
Add an option to support debug fission on implicit ThinLTO.
Summary:
This adds an option -gsplit-dwarf=. LLVM can create .dwo files in the
given directory
during the
Whenever possible, do include context for why a patch is being reverted in
the commit message - buildbot links, but also potentially
describing/copy-pasting inline whatever the problem(s) are. This makes it
easier for people tracking the state of upstream to know whether they may
need to pull in
bruno closed this revision.
bruno added a comment.
Committed r335542
https://reviews.llvm.org/D47301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Actually, I would imagine that if you're cross-compiling or using a custom
sysroot, you should probably also specify CMAKE_FIND_ROOT_PATH and set
CMAKE_FIND_ROOT_PATH_MODE_PACKAGE to ONLY, to limit all these searches to the
desired directories?
(I'm actually playing
Author: dergachev
Date: Mon Jun 25 16:55:07 2018
New Revision: 335559
URL: http://llvm.org/viewvc/llvm-project?rev=335559=rev
Log:
[analyzer] Track null and undef values through expressions with cleanups.
ExprWithCleanups wraps full-expressions that require temporary destructors
and highlights
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335559: [analyzer] Track null and undef values through
expressions with cleanups. (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48204?vs=151450=152810#toc
dblaikie added a comment.
This doesn't seem to build for me - so hard to debug/probe it:
llvm/src/tools/clang/lib/CodeGen/CGBuiltin.cpp:1264:65: error: no viable
conversion from 'clang::QualType' to 'llvm::Type *'
CGF.CGM.getDataLayout().getTypeSizeInBits(CanonicalType),
yunlian marked 2 inline comments as done.
yunlian added a comment.
ping?
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
In https://reviews.llvm.org/D47757#1142886, @ahatanak wrote:
> I mean ToT clang (without my patch applied) seems to select the non-sized
> host version 'T::operator delete(void*)'.
OK, if this is just making an error out of something which previously silently
didn't
rtrieu added a comment.
Running this, I see that it causes a regression in one of the other ODR Hash
tests. Specifically, the diagnostics on line 1150 & 1151 of
test/Modules/odr_hash.cpp are not seen. Was that an expected side-effect of
this patch?
Repository:
rC Clang
(Sorry for the late reply...)
On Mon, Jun 25, 2018 at 2:45 PM Michael Kruse via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I just revert if to have further discussions (r335516)
>
> Michael
>
> 2018-06-25 14:58 GMT-05:00 Eric Christopher :
> >
> >
> > On Mon, Jun 25, 2018 at 12:21 PM
smeenai added a comment.
Okay, upon playing with this further, the following seems to do what I want
(for a custom sysroot), and seems to be a pretty common pattern as well:
set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY)
set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY)
On 23 June 2018 at 22:34, Michael Kruse via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> multiple comments in the code indicate that the attribute order was
> surprising and probably has lead to bugs, and will lead to bugs in the
> future. The order had to be explicitly reversed to
jlebar added a comment.
@rsmith friendly ping on this one.
https://reviews.llvm.org/D48036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added inline comments.
Comment at: xpc/test-client/ClangdXPCTestClient.cpp:51
+ dlHandle, "clangd_xpc_get_bundle_identifier");
+ xpc_connection_t conn =
+ xpc_connection_create(clangd_xpc_get_bundle_identifier(), NULL);
We should probably
I just revert if to have further discussions (r335516)
Michael
2018-06-25 14:58 GMT-05:00 Eric Christopher :
>
>
> On Mon, Jun 25, 2018 at 12:21 PM Richard Smith via cfe-commits
> wrote:
>>
>> On 23 June 2018 at 22:34, Michael Kruse via cfe-commits
>> wrote:
>>>
>>> Hi,
>>>
>>> multiple
bruno added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
1 - 100 of 150 matches
Mail list logo
