On Thu, 2 Aug 2018, 06:10 Martin Storsjö via Phabricator via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> mstorsjo added a comment.
>
> This change made clang to start trigger failed asserts for me (although
> they seem to not be reproducible with all compilers building clang), see
>
This revision was automatically updated to reflect the committed changes.
vsapsai marked an inline comment as done.
Closed by commit rL338741: [c-index-test] Use correct executable path to
discover resource directory. (authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
NoQ accepted this revision.
NoQ added a comment.
All this stuff looks great! Please commit.
https://reviews.llvm.org/D49361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Jul 30, 2018 at 5:44 PM Reka Kovacs via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rkovacs
> Date: Mon Jul 30 08:43:45 2018
> New Revision: 338259
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338259=rev
> Log:
> [analyzer] Add support for more invalidating functions in
ioeric updated this revision to Diff 158761.
ioeric added a comment.
- minor update to comment.
Repository:
rC Clang
https://reviews.llvm.org/D50189
Files:
lib/Tooling/Core/Lookup.cpp
unittests/Tooling/LookupTest.cpp
Index: unittests/Tooling/LookupTest.cpp
Szelethus updated this revision to Diff 158760.
Szelethus added a comment.
Forgot `git add` and `-U`.
https://reviews.llvm.org/D49438
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/Analysis/cxx-uninitialized-object-inheritance.cpp
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric.
Added functionality to suggest FixIts for conversion of '->' to '.' and vice
versa.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50193
scott.linder added a comment.
I still don't quite see what you describe; with that change all of the
lifetime.end calls pile up just before the enclosing function returns, not
after each call to enqueue_kernel. Looking at
https://clang.llvm.org/doxygen/EHScopeStack_8h_source.html#l00078 I
Author: vsapsai
Date: Thu Aug 2 10:29:53 2018
New Revision: 338741
URL: http://llvm.org/viewvc/llvm-project?rev=338741=rev
Log:
[c-index-test] Use correct executable path to discover resource directory.
Driver builds resource directory path based on provided executable path.
Instead of string
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:173
+ int s = getSize((char *) func_ptr);
+ memcpy(mem, func_ptr, s);
+}
emmettneyman wrote:
> morehouse wrote:
> > Why do we need to copy the function somewhere
ioeric created this revision.
ioeric added reviewers: ilya-biryukov, hokein.
Herald added a subscriber: cfe-commits.
For example, when renaming `a::b::x::foo` to `y::foo` below, replacing
`x::foo()` with `y::foo()` can cause ambiguity. In such cases, we simply fully
qualify the name with leading
ilya-biryukov added inline comments.
Comment at: lib/Tooling/Core/Lookup.cpp:137
+ StringRef TrimmedQName = QName.substr(2);
+ for (auto I = UseNamespaces.begin(), E = UseNamespaces.end(); I != E; ++I) {
+const NamespaceDecl *NS = *I;
maybe use
emmettneyman created this revision.
emmettneyman added reviewers: kcc, morehouse.
Herald added subscribers: cfe-commits, mgorny.
Added corpus of arrays to use as inputs for the functions. Check that the two
functions modify the inputted arrays in the same way.
Repository:
rC Clang
mclow.lists added a comment.
That certainly ***looks*** more correct to me.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D50170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:173
+ int s = getSize((char *) func_ptr);
+ memcpy(mem, func_ptr, s);
+}
Why do we need to copy the function somewhere else? Looks very error-prone and
Author: maskray
Date: Thu Aug 2 09:29:36 2018
New Revision: 338732
URL: http://llvm.org/viewvc/llvm-project?rev=338732=rev
Log:
[analyzer] Make RegionVector use const reference
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
Modified:
Author: epilk
Date: Thu Aug 2 10:45:01 2018
New Revision: 338747
URL: http://llvm.org/viewvc/llvm-project?rev=338747=rev
Log:
[itanium demangler] Support dot suffixes on block invocation functions
rdar://32378759
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
Author: george.karpenkov
Date: Thu Aug 2 11:17:01 2018
New Revision: 338753
URL: http://llvm.org/viewvc/llvm-project?rev=338753=rev
Log:
[analyzer] Forward arguments in registerChecker to avoid accidental copies
Differential Revision: https://reviews.llvm.org/D50108
Modified:
Author: arsenm
Date: Thu Aug 2 11:24:55 2018
New Revision: 338754
URL: http://llvm.org/viewvc/llvm-project?rev=338754=rev
Log:
AMDGPU: Fix missing declaration of queue ptr builtin
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn.cl
ahatanak updated this revision to Diff 158774.
ahatanak marked 3 inline comments as done.
ahatanak added a comment.
Address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D50152
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGBlocks.h
lib/CodeGen/CGNonTrivialStruct.cpp
ahatanak added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1638
+switch (E.Kind) {
+case BlockCaptureEntityKind::CXXRecord: {
+ Name += "c";
rjmccall wrote:
> I forget whether this case has already filtered out trivial
>
yaxunl added a comment.
In https://reviews.llvm.org/D50104#1185920, @scott.linder wrote:
> I still don't quite see what you describe; with that change all of the
> lifetime.end calls pile up just before the enclosing function returns, not
> after each call to enqueue_kernel. Looking at
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338743: __c11_atomic_loads _Atomic can be const
(authored by jfb, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47618
Files:
Author: jfb
Date: Thu Aug 2 10:35:46 2018
New Revision: 338743
URL: http://llvm.org/viewvc/llvm-project?rev=338743=rev
Log:
__c11_atomic_load's _Atomic can be const
Summary:
C++11 onwards specs the non-member functions atomic_load and
atomic_load_explicit as taking the atomic by const
bricci added a comment.
The static_assert itself cannot be in the bitfield since the whole point is to
avoid including Basic/IdentifierTable.h just for this.
I originally put the static_assert in ObjCMethodDecl and everything worked fine
when tested with GCC but I then saw just
after you
xazax.hun accepted this revision.
xazax.hun added a comment.
We could also print something about the ReturnStmt, like source location or
pretty print of its expressions so we can check that we picked the right one in
case we have multiple.
But consider this as an optional task if you have
juliehockett marked 2 inline comments as done.
juliehockett added inline comments.
Comment at: clang-tools-extra/test/clang-doc/bc-linkage.cpp:106
+// CHECK-0-NEXT:
+// CHECK-0-NEXT:
+// CHECK-0-NEXT:blob data = 'InnerClass'
ioeric wrote:
> juliehockett
vsapsai added a comment.
Thanks for the review!
Repository:
rL LLVM
https://reviews.llvm.org/D50160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
emmettneyman added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:173
+ int s = getSize((char *) func_ptr);
+ memcpy(mem, func_ptr, s);
+}
morehouse wrote:
> Why do we need to copy the function somewhere else? Looks very
emmettneyman updated this revision to Diff 158800.
emmettneyman added a comment.
Replaced hardcoded numbers with variables
Repository:
rC Clang
https://reviews.llvm.org/D50194
Files:
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/ExampleClangLLVMProtoFuzzer.cpp
Author: mstorsjo
Date: Thu Aug 2 11:12:08 2018
New Revision: 338749
URL: http://llvm.org/viewvc/llvm-project?rev=338749=rev
Log:
Work around more GCC miscompiles exposed by r338464.
This is the same fix as in r338478, for another occurrance of the
same pattern from r338464.
See
efriedma added inline comments.
Comment at: lib/Driver/ToolChains/Arch/AArch64.cpp:200
+ //
+ // TODO: implement this logic in TargetParser.
+
Yes, this logic should be in TargetParser, not here. Trying to rewrite the
target features afterwards is messy at
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3489
+
+``noderef`` is currently only supported for C style pointers and arrays and
not usable for
+references or Objective-C pointers.
I would drop the "C style" and just say it's
Quuxplusone added inline comments.
Comment at: compiler-explorer-llvm-commit.sh:1
+# This is the commit of LLVM that we're currently based on.
+git reset --hard 1fa19f68007cd126a04448093c171f40e556087e
Rakete wrote:
> What's this file? A mistake?
Yeah, it's
dblaikie added a comment.
Hi - sorry about the stalled opaque pointer types effort.
For my money - ideally - if someone comes across a bug caused by incorrect
pointee types, ideally that would be fixed by adjusting whatever piece of code
was depending on that pointee type being correct to not
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
The attribute itself is looking reasonable aside from some minor nits, but this
should not be committed until the clang-tidy functionality is approved (since
it has no utility
aaron.ballman accepted this revision.
aaron.ballman added a comment.
I am still okay with this, and agree that the ordering issues are a separate
thing to tackle.
Repository:
rC Clang
https://reviews.llvm.org/D48100
___
cfe-commits mailing list
Author: rsmith
Date: Thu Aug 2 13:30:52 2018
New Revision: 338766
URL: http://llvm.org/viewvc/llvm-project?rev=338766=rev
Log:
Fix assertion failure when emitting code for a merged lambda.
Modified:
cfe/trunk/lib/AST/DeclCXX.cpp
cfe/trunk/test/Modules/merge-lambdas.cpp
Modified:
Rakete added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:6187
+Record->dropAttr();
+ } else if (Record->needsImplicitMoveConstructor() &&
+ Record->defaultedMoveConstructorIsDeleted()) {
Rakete wrote:
> Quuxplusone
Rakete added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:6174
+ Record->hasAttr() &&
+ !isTemplateInstantiation(Record->getTemplateSpecializationKind())) {
+if (Record->getDefinition() && !Record->isDependentContext() &&
The call to
andrew.w.kaylor added a comment.
I hope I'm not coming across as too argumentative here. I don't really have
strong feelings about this function pointer type patch and ultimately I see
that you are right, but the objections you are raising here would equally apply
to what I'm working on with
mstorsjo created this revision.
mstorsjo added reviewers: rnk, compnerd, pcc, pirama.
Repository:
rC Clang
https://reviews.llvm.org/D50199
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/Options.td
lib/Basic/Targets.cpp
lib/Driver/ToolChains/Clang.cpp
mstorsjo added inline comments.
Comment at: CMakeLists.txt:363
-add_subdirectory(test)
+if (EXISTS ${LLVM_CMAKE_PATH})
+ add_subdirectory(test)
phosek wrote:
> libcxx seems to be using a different condition: `IS_DIRECTORY
>
pirama added a comment.
In https://reviews.llvm.org/D50199#1186164, @rnk wrote:
> Does this do anything other than -DUNICODE? Maybe just translate it at the
> driver level and skip the -cc1 flag?
It seems odd to include predefined macros at the driver, which AFAIK is just a
bridge to the
george.karpenkov added a comment.
> Dereferencing is disabled by default
Great! Thank you!
> but I haven't seen the current version of the checker crash due to pointer
> chasing.
@NoQ saw quite a few crashes during evaluation, right?
> This might be a little nit-picking, but I don't think
ldionne created this revision.
ldionne added reviewers: EricWF, vsapsai.
Herald added subscribers: cfe-commits, dexonsmith, christof.
The aligned allocation and deallocation functions were added in the dylib
in Mac OSX 10.13. This commit does two things: first, it adds availability
markup to
rnk added a comment.
Does this do anything other than -DUNICODE? Maybe just translate it at the
driver level and skip the -cc1 flag?
Repository:
rC Clang
https://reviews.llvm.org/D50199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mstorsjo updated this revision to Diff 158827.
mstorsjo added a comment.
Simplified the patch to just handle the flag within the driver, without making
it a flag to cc1.
https://reviews.llvm.org/D50199
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/mingw.cpp
Index:
simoncook added a comment.
It seems the ability to link objects has been broken by this change. As an
example from our nightly tests:
Executing on host: riscv32-unknown-elf-clang
/data/jenkins/workspace/riscv32-llvm-gcc/gcc-tests/gcc/testsuite/gcc.c-torture/execute/20080502-1.c
Author: rkovacs
Date: Thu Aug 2 15:19:57 2018
New Revision: 338775
URL: http://llvm.org/viewvc/llvm-project?rev=338775=rev
Log:
[analyzer] Add a safety check to InnerPointerChecker.
Do not crash if the CXXRecordDecl of an object is not available.
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338777: [analyzer] Obtain a ReturnStmt from a
CFGAutomaticObjDtor. (authored by rkovacs, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49811
Files:
Author: rkovacs
Date: Thu Aug 2 15:31:03 2018
New Revision: 338777
URL: http://llvm.org/viewvc/llvm-project?rev=338777=rev
Log:
[analyzer] Obtain a ReturnStmt from a CFGAutomaticObjDtor.
The CoreEngine only gives us a ReturnStmt if the last element in the
CFGBlock is a CFGStmt, otherwise the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338780: [analyzer] Detect pointers escaped after ReturnStmt
execution in MallocChecker. (authored by rkovacs, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: rkovacs
Date: Thu Aug 2 16:02:08 2018
New Revision: 338780
URL: http://llvm.org/viewvc/llvm-project?rev=338780=rev
Log:
[analyzer] Detect pointers escaped after ReturnStmt execution in MallocChecker.
Objects local to a function are destroyed right after the statement returning
(part of)
scott.linder updated this revision to Diff 158816.
scott.linder added a comment.
Emit lifetime intrinsics for the sizes temp, and update test
https://reviews.llvm.org/D50104
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/cl20-device-side-enqueue.cl
aaron.ballman added inline comments.
Comment at: test/SemaCXX/warn-thread-safety-analysis.cpp:4081-4085
+ void unlockExclusive() EXCLUSIVE_UNLOCK_FUNCTION(mu_) {
+mu_.Unlock();
+ }
+
+ void unlockShared() SHARED_UNLOCK_FUNCTION(mu_) {
Nothing calls either
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Great! The comment should be updated though.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:32
+// `-analyzer-config \
Thanks for the notice. Have you managed to get the repro? I haven't
succeeded in constructing one yet, but I've committed a check for the
CXXRecordDecl. I hope that fixes the crashes.
Alexander Kornienko ezt írta (időpont: 2018. aug. 2.,
Cs, 11:07):
>
>
> On Mon, Jul 30, 2018 at 5:44 PM Reka
ahatanak added a comment.
I just wanted to make sure that this doesn't have the same problem as
https://reviews.llvm.org/D34556. Is that correct?
The patch was reverted in r306859. https://reviews.llvm.org/D34574#791158
explains why the approach taken in the patch was wrong.
Repository:
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1638
+switch (E.Kind) {
+case BlockCaptureEntityKind::CXXRecord: {
+ Name += "c";
ahatanak wrote:
> rjmccall wrote:
> > I forget whether this case has already filtered out trivial
Hans,
I think this commit should be merged to the 7.0 release branch; the first
half of the GCC workaround made it in before the branch happened, but
there was another identical case missing.
// Martin
On Thu, 2 Aug 2018, Martin Storsjo via cfe-commits wrote:
Author: mstorsjo
Date: Thu
On Thu, 2 Aug 2018, Richard Smith via cfe-commits wrote:
On Thu, 2 Aug 2018, 06:10 Martin Storsjö via Phabricator via cfe-commits,
wrote:
mstorsjo added a comment.
This change made clang to start trigger failed asserts for me
(although they seem to not be reproducible with
Rakete added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:6187
+Record->dropAttr();
+ } else if (Record->needsImplicitMoveConstructor() &&
+ Record->defaultedMoveConstructorIsDeleted()) {
Quuxplusone wrote:
> Rakete
mstorsjo added a comment.
In https://reviews.llvm.org/D50199#1186164, @rnk wrote:
> Does this do anything other than -DUNICODE? Maybe just translate it at the
> driver level and skip the -cc1 flag?
Yes, that also works. Initially I looked at where to place that in
phosek added inline comments.
Comment at: CMakeLists.txt:363
-add_subdirectory(test)
+if (EXISTS ${LLVM_CMAKE_PATH})
+ add_subdirectory(test)
libcxx seems to be using a different condition: `IS_DIRECTORY
"${CMAKE_CURRENT_SOURCE_DIR}/test"`, should this be
(+Hans) +1
On Thu, 2 Aug 2018 at 11:37, Martin Storsjö via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hans,
>
> I think this commit should be merged to the 7.0 release branch; the first
> half of the GCC workaround made it in before the branch happened, but
> there was another identical
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338771: [WebAssembly] Support for atomic.wait / atomic.wake
builtins (authored by aheejin, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49396
mstorsjo added a comment.
In https://reviews.llvm.org/D50199#1186282, @cdavis5x wrote:
> I actually believe this is supposed to have one other effect: it sets the
> entry point to `wmainCRTStartup()`/`wWinMainCRTStartup()`, making the user
> entry point `wmain()`/`wWinMain()`, which take wide
Author: aheejin
Date: Thu Aug 2 14:44:40 2018
New Revision: 338771
URL: http://llvm.org/viewvc/llvm-project?rev=338771=rev
Log:
[WebAssembly] Support for atomic.wait / atomic.wake builtins
Summary:
Add support for atomic.wait / atomic.wake builtins based on the Wasm
thread proposal.
Reviewers:
The attached patch adds support for @files to ccc-analyzer (which is used
by scan-build). This feature is a commonly accepted compiler option that
clang, gcc, and cl.exe (microsoft's compiler) all already support. This
will allow scan-build to support it too (assuming that the perl version of
Quuxplusone updated this revision to Diff 158822.
Quuxplusone marked 20 inline comments as done.
Quuxplusone added a comment.
Further removal of dead code based on @Rakete's feedback.
Repository:
rC Clang
https://reviews.llvm.org/D50119
Files:
docs/LanguageExtensions.rst
cdavis5x added a comment.
Are you sure this shouldn't also define `_UNICODE`? //looks// Hmm... GCC
doesn't define it. I wonder if we should anyway. A user who set `-municode` may
also be using ``, and thus may want those macros set to their Unicode
counterparts.
I actually believe this is
shuaiwang updated this revision to Diff 158856.
shuaiwang marked 2 inline comments as done.
shuaiwang added a comment.
Update comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50102
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
shuaiwang added inline comments.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:108
return;
+ if (const auto *Ctor = dyn_cast(Function)) {
+for (const auto *Init : Ctor->inits()) {
hokein wrote:
> Is this a new fix or a special case
rjmccall added inline comments.
Comment at: lib/Sema/SemaCast.cpp:1050
+ SrcType->getAs()->getPointeeType().getAddressSpace() !=
+
DestType->getAs()->getPointeeType().getAddressSpace();
+}
yaxunl wrote:
> rjmccall wrote:
> > yaxunl wrote:
>
Author: george.karpenkov
Date: Thu Aug 2 11:41:25 2018
New Revision: 338756
URL: http://llvm.org/viewvc/llvm-project?rev=338756=rev
Log:
[analyzer] Fix tests.
Modified:
cfe/trunk/test/Analysis/analyzer-config.c
cfe/trunk/test/Analysis/analyzer-config.cpp
Modified:
Meinersbur created this revision.
Herald added subscribers: cfe-commits, eraman.
Attempt to solve the the diagnostic marker order ('note: previous declaration
here' pointing to a source location before the main error marker) from
https://reviews.llvm.org/D48100.
The approach is to pass a
Author: mwu
Date: Thu Aug 2 21:21:25 2018
New Revision: 338808
URL: http://llvm.org/viewvc/llvm-project?rev=338808=rev
Log:
[libclang 3/8] Add support for AttributedType
Summary:
This patch adds support to the libclang API for identifying AttributedTypes in
CXTypes and reading the modified
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338808: [libclang 3/8] Add support for AttributedType
(authored by mwu, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49081?vs=154609=158909#toc
Repository:
rC Clang
Author: meinersbur
Date: Thu Aug 2 21:42:52 2018
New Revision: 338810
URL: http://llvm.org/viewvc/llvm-project?rev=338810=rev
Log:
[CodeGen] Emit parallel_loop_access for each loop in the loop stack.
Summary:
Emit !llvm.mem.parallel_loop_access metadata for memory accesses even if the
parallel
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338810: [CodeGen] Emit parallel_loop_access for each loop in
the loop stack. (authored by Meinersbur, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48808?vs=155288=158912#toc
michaelwu added a comment.
Some of the CHECKs in the test will be reordered to pass, but it's still the
same test.
Repository:
rC Clang
https://reviews.llvm.org/D49127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: mwu
Date: Thu Aug 2 22:38:29 2018
New Revision: 338816
URL: http://llvm.org/viewvc/llvm-project?rev=338816=rev
Log:
[libclang 7/8] Add support for getting property setter and getter names
Summary: This allows libclang to access the actual names of property setters
and getters without
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338816: [libclang 7/8] Add support for getting property
setter and getter names (authored by mwu, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49634?vs=156691=158919#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338819: [CMake] Allow building standalone without any
llvm-config available (authored by mstorsjo, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
Author: mstorsjo
Date: Thu Aug 2 22:51:31 2018
New Revision: 338819
URL: http://llvm.org/viewvc/llvm-project?rev=338819=rev
Log:
[CMake] Allow building standalone without any llvm-config available
This is the same as libcxxabi/libcxx do.
Differential Revision: https://reviews.llvm.org/D50135
bviyer updated this revision to Diff 158870.
bviyer added a comment.
Simplified the case a bit more as requested by Erik. I also induced some errors
in the test so that if someone symbolic-linked clang to /bin/true, the test
will fail.
Repository:
rC Clang
https://reviews.llvm.org/D50122
Quuxplusone marked an inline comment as done.
Quuxplusone added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:6091
+ for (auto *F : Record->fields()) {
+if (F->isMutable()) {
Rakete wrote:
> Can you move this in `ActOnFields`? That way we
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338807: [libclang 2/8] Add support for ObjCTypeParam
(authored by mwu, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49066
Files:
include/clang-c/Index.h
test/Index/print-type.m
Author: mwu
Date: Thu Aug 2 21:02:40 2018
New Revision: 338807
URL: http://llvm.org/viewvc/llvm-project?rev=338807=rev
Log:
[libclang 2/8] Add support for ObjCTypeParam
Summary:
This patch adds support to the libclang API for identifying ObjCTypeParams in
CXTypes.
This patch depends on D49063
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338815: [libclang 6/8] Add support for reading implicit
attributes (authored by mwu, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49631?vs=15=158918#toc
Repository:
rC
Author: mwu
Date: Thu Aug 2 22:20:23 2018
New Revision: 338815
URL: http://llvm.org/viewvc/llvm-project?rev=338815=rev
Log:
[libclang 6/8] Add support for reading implicit attributes
Summary:
Having access to implicit attributes is sometimes useful so users of libclang
don't have to duplicate
Hello everyone,
Below are some buildbot numbers for the last week of 7/22/2018 - 7/28/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
Hello everyone,
Below are some buildbot numbers for the week of 7/15/2018 - 7/21/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
juliehockett updated this revision to Diff 158872.
https://reviews.llvm.org/D50208
Files:
clang-tools-extra/clang-doc/Serialize.cpp
Index: clang-tools-extra/clang-doc/Serialize.cpp
===
---
Author: meinersbur
Date: Thu Aug 2 18:21:16 2018
New Revision: 338800
URL: http://llvm.org/viewvc/llvm-project?rev=338800=rev
Log:
Append new attributes to the end of an AttributeList.
Recommit of r335084 after revert in r335516.
... instead of prepending it at the beginning (the original
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks!
https://reviews.llvm.org/D50104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Thu Aug 2 19:58:16 2018
New Revision: 338803
URL: http://llvm.org/viewvc/llvm-project?rev=338803=rev
Log:
Make my new test harness work w/c++03
Modified:
libcxx/trunk/test/support/test_comparisons.h
Modified: libcxx/trunk/test/support/test_comparisons.h
URL:
sdmitriev created this revision.
sdmitriev added reviewers: ABataev, hfinkel.
Herald added subscribers: cfe-commits, mgrang, guansong.
Encoding offload target triples onto comdat group key for offload
initialization code guarantees that it will be executed once per each unique
combination of
Author: mwu
Date: Thu Aug 2 21:38:04 2018
New Revision: 338809
URL: http://llvm.org/viewvc/llvm-project?rev=338809=rev
Log:
[libclang 4/8] Add the clang_Type_getNullability() API
Summary:
This patch adds a clang-c API for querying the nullability of an AttributedType.
The test here also tests
1 - 100 of 179 matches
Mail list logo
