Author: echristo
Date: Thu Sep 20 10:21:56 2018
New Revision: 342667
URL: http://llvm.org/viewvc/llvm-project?rev=342667=rev
Log:
r342177 introduced a hint in cases where an #included file is not found. It
tries to find a suggestion by removing leading or trailing non-alphanumeric
characters
sammccall added a comment.
Very nice!
I think the data structures can be slightly tighter, and some of the
implementation could be easier to follow. But this seems like a nice win.
Right-sizing the vectors seems like an important optimization.
Comment at:
baloghadamsoftware created this revision.
baloghadamsoftware added reviewers: alexfh, aaron.ballman, flx.
The three checks mentioned in the Title are two noisy if the code uses
intrusive smart (reference counting) pointers. LLVM/Clang is such a code, it
has lots of such types, e.g. StringRef,
Author: mikerice
Date: Thu Sep 20 10:19:41 2018
New Revision: 342666
URL: http://llvm.org/viewvc/llvm-project?rev=342666=rev
Log:
[OPENMP] Fix spelling of getLoopCounter (NFC)
Modified:
cfe/trunk/include/clang/AST/OpenMPClause.h
cfe/trunk/lib/AST/OpenMPClause.cpp
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
If that helps you, then sure.
I'm not sure I understand why having warnings causes the collection process to
fail, but I guess ultimately it's not important.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342667: r342177 introduced a hint in cases where an
#included file is not found. It… (authored by echristo, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52280?vs=166184=166327#toc
ilya-biryukov added a comment.
Also not sure about the trick:
- Would be surprising to see the "ms" instead of "mbytes"
- Time tends to vary between runs, so using Google Benchmark's capabilities to
run multiple times and report aggregated times seems useful. Not so much for
the memory usage:
Author: abataev
Date: Thu Sep 20 06:54:02 2018
New Revision: 342648
URL: http://llvm.org/viewvc/llvm-project?rev=342648=rev
Log:
[OPENMP] Add support for mapping memory pointed by member pointer.
Added support for map(s, s.ptr[0:1]) kind of mapping.
Modified:
ilya-biryukov added a comment.
In https://reviews.llvm.org/D52261#1240143, @yvvan wrote:
> I tried that first but did not I find a way just to copy an expression (we
> basically need the same expr for such case). Do you know how to properly
> generate a copy of expression or some other way to
JonasToth added inline comments.
Comment at: unittests/Analysis/ExprMutationAnalyzerTest.cpp:67
+if (const auto *DRE = dyn_cast(E)) {
+ if (DRE->getNameInfo().getAsString()[0] == 'p')
+Finder = PointeeMutationFinder;
shuaiwang wrote:
> JonasToth
lebedev.ri added a comment.
This looks questionable to me.
I don't disagree with the reasons stated about llvm types.
But is that *always* true?
I would personally be very surprized, and consider this a false-positive.
This should at least be optional.
Not sure about the default, but setting the
It looks like we don't do anything special if you run clang-cl -O0 or /O0,
but it's not an error. I don't have my computer and can't run a test, but
from the outside, it looks like clang-cl -O0 does generate unoptimized code
without warning about an unrecognized flag, but it doesn't disable FP
riccibruno updated this revision to Diff 166324.
riccibruno marked 9 inline comments as done.
riccibruno added a comment.
Address rjmccall comments:
1. Renamed `CXXSpecialName` to `CXXSpecialNameExtra`
2. Introduced a constant `IdentifierInfoAlignment` for
`alignas(IdentifierInfoAlignment)`
3.
lewissbaker added inline comments.
Comment at: test/std/experimental/task/sync_wait.hpp:36-37
+ __isSet_ = true;
+}
+__cv_.notify_all();
+ }
The call to `notify_all()` needs to be inside the lock.
Otherwise, it's possible the waiting thread may see
riccibruno added a comment.
Addressed some inline comments.
Comment at: include/clang/AST/DeclarationName.h:46
-/// DeclarationName - The name of a declaration. In the common case,
-/// this just stores an IdentifierInfo pointer to a normal
-/// name. However, it also
flx added inline comments.
Comment at: clang-tidy/utils/TypeTraits.cpp:49
+ if (Context.getTypeSize(Type) <= Context.getTypeSize(Context.VoidPtrTy))
+return false;
+
This early return now ignores the fact that the type has non-trivial copy
constructors,
101 - 116 of 116 matches
Mail list logo
