Hahnfeld added a comment.
Should we also change the default `schedule` to `static, 1`? I know that's not
really needed for `teams distribute parallel for` (because the new default
`dist_schedule` only leaves one iteration per thread), but this doesn't happen
for `target parallel for`.
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D52434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
gtbercea updated this revision to Diff 167326.
gtbercea added a comment.
Fix type of chunk size.
Repository:
rC Clang
https://reviews.llvm.org/D52434
Files:
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGOpenMPRuntimeNVPTX.h
Author: ioeric
Date: Thu Sep 27 07:50:24 2018
New Revision: 343224
URL: http://llvm.org/viewvc/llvm-project?rev=343224=rev
Log:
[Tooling] Get rid of uses of llvm::Twine::str which is slow. NFC
Modified:
cfe/trunk/lib/Tooling/Inclusions/HeaderIncludes.cpp
Modified:
kbobyrev added inline comments.
Comment at: clangd/index/dex/Dex.cpp:171
}
+ if (Req.AnyScope)
+ScopeIterators.push_back(createBoost(createTrue(Symbols.size()), 0.2));
Probably also check `!ScopeIterators.empty()`: otherwise the latency might
increase
lebedev.ri added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+ << static_cast(
kbobyrev wrote:
> JonasToth wrote:
> > kbobyrev
kbobyrev added inline comments.
Comment at: clangd/index/dex/Dex.cpp:143
"There must be no :: in query.");
+ trace::Span Tracer("Dex fuzzyFind");
FuzzyMatcher Filter(Req.Query);
sammccall wrote:
> We should attach the query tree to the span here.
>
kbobyrev added a comment.
Also, regarding error handling and `llvm::Option` vs `llvm::Expected`: I think
the case where the check most likely wouldn't be able to provide useful
diagnostics and perform enough analysis is when there are macro expansions
within inspected statement `SourceRange`.
Author: ioeric
Date: Thu Sep 27 07:27:02 2018
New Revision: 343223
URL: http://llvm.org/viewvc/llvm-project?rev=343223=rev
Log:
[clangd] Make IncludeInserter less slow. NFC
Modified:
clang-tools-extra/trunk/clangd/Headers.cpp
clang-tools-extra/trunk/clangd/Headers.h
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343220: [AArch64][v8.5A] Test optional Armv8.5-A random
number extension (authored by olista01, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52492?vs=166909=167322#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343221: Tell whether file/folder for include completions.
(authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52547?vs=167320=167321#toc
Repository:
rCTE
Author: kadircet
Date: Thu Sep 27 07:21:07 2018
New Revision: 343221
URL: http://llvm.org/viewvc/llvm-project?rev=343221=rev
Log:
Tell whether file/folder for include completions.
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: ilya-biryukov, ioeric, jkorous, arphaman, cfe-commits
Author: olista01
Date: Thu Sep 27 07:20:59 2018
New Revision: 343220
URL: http://llvm.org/viewvc/llvm-project?rev=343220=rev
Log:
[AArch64][v8.5A] Test optional Armv8.5-A random number extension
The implementation of this is in TargetParser, so we only need to add a
test for it in clang.
Patch
kadircet updated this revision to Diff 167320.
kadircet marked 2 inline comments as done.
kadircet added a comment.
Preparing the patch to respect client capabilities.
- Add other itemkinds as well.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52547
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/Merge.cpp:42
// 3) now yield all the dynamic symbols we haven't processed.
+ trace::Span Tracer("MergedIndex fuzzyFind");
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D52547#1247794, @kadircet wrote:
> In https://reviews.llvm.org/D52547#1246701, @ilya-biryukov wrote:
>
> > A drive-by comment.
> > Would it be cleaner to
kbobyrev added a comment.
A lot of good improvements and many test cases, thank you!
The comments are mostly nits.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52611
Files:
clangd/index/MemIndex.cpp
clangd/index/Merge.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343207: [OpenCL] Improve extension-version.cl and
to_addr_builtin.cl tests (authored by svenvh, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: svenvh
Date: Thu Sep 27 06:20:29 2018
New Revision: 343207
URL: http://llvm.org/viewvc/llvm-project?rev=343207=rev
Log:
[OpenCL] Improve extension-version.cl and to_addr_builtin.cl tests
Add cl_khr_depth_images to extension-version.cl.
Extend to_addr_builtin.cl to additionally test the
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D51686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
JonasToth added a comment.
In https://reviews.llvm.org/D52334#1247809, @steveire wrote:
> @JonasToth Once again - `clangStaticAnalyzerCheckers` is not `clangAnalysis`.
> Also, that commit changes the `mpi` plugin, which is excluded by this patch.
I pinged because of the MPI thing, i did not
Szelethus added inline comments.
Comment at:
cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h:82-84
+ // TODO: This destructor shouldn't be virtual, but breaks buildbots with
+ // -Werror -Wnon-virtual-dtor.
+ virtual ~FieldNode() = default;
Author: szelethus
Date: Thu Sep 27 05:46:37 2018
New Revision: 343205
URL: http://llvm.org/viewvc/llvm-project?rev=343205=rev
Log:
Revert untintentionally commited changes
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
Modified:
steveire added a comment.
@JonasToth Once again - `clangStaticAnalyzerCheckers` is not `clangAnalysis`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343204: [Lex] TokenConcatenation now takes const
Preprocessor (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
kadircet added a comment.
In https://reviews.llvm.org/D52547#1246701, @ilya-biryukov wrote:
> A drive-by comment.
> Would it be cleaner to pass this information from clang? Relying on
> completion label seems shaky.
Actually I also wanted to do that at first, but then wasn't really sure
Author: szelethus
Date: Thu Sep 27 05:40:16 2018
New Revision: 343204
URL: http://llvm.org/viewvc/llvm-project?rev=343204=rev
Log:
[Lex] TokenConcatenation now takes const Preprocessor
Differential Revision: https://reviews.llvm.org/D52502
Modified:
Author: jonastoth
Date: Thu Sep 27 05:30:44 2018
New Revision: 343201
URL: http://llvm.org/viewvc/llvm-project?rev=343201=rev
Log:
[clang-tidy] use CHECK-NOTES in tests for bugprone suspicious-enum-usage
Reviewers: alexfh, aaron.ballman, hokein
Subscribers: xazax.hun, cfe-commits
Differential
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343201: [clang-tidy] use CHECK-NOTES in tests for bugprone
suspicious-enum-usage (authored by JonasToth, committed by ).
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343199: [clang-tidy] use CHECK-NOTES in tests for
bugprone-use-after-move (authored by JonasToth, committed by ).
Herald
Author: jonastoth
Date: Thu Sep 27 05:22:48 2018
New Revision: 343199
URL: http://llvm.org/viewvc/llvm-project?rev=343199=rev
Log:
[clang-tidy] use CHECK-NOTES in tests for bugprone-use-after-move
Reviewers: alexfh, aaron.ballman, hokein
Subscribers: xazax.hun, cfe-commits
Differential
atanasyan added a comment.
Could you please update the patch against the current trunk?
Repository:
rC Clang
https://reviews.llvm.org/D50850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343198: [clang-tidy] use CHECK-NOTES in tests for
bugprone-forward-declaration-namespace (authored by JonasToth,
Author: jonastoth
Date: Thu Sep 27 05:17:59 2018
New Revision: 343198
URL: http://llvm.org/viewvc/llvm-project?rev=343198=rev
Log:
[clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace
Reviewers: aaron.ballman, alexfh, hokein
Subscribers: xazax.hun, cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343197: Improve diagnostics range reporting. (authored by
kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52544
Files:
Author: kadircet
Date: Thu Sep 27 05:12:42 2018
New Revision: 343197
URL: http://llvm.org/viewvc/llvm-project?rev=343197=rev
Log:
Improve diagnostics range reporting.
Summary:
If we have some range information coming from clang diagnostic, promote
that one even if it doesn't contain diagnostic
kadircet added inline comments.
Comment at: unittests/clangd/ClangdUnitTests.cpp:82
o]]();
- foo()$semicolon[[]]
+ foo()$semicolon[[]]//with comments
$unk[[unknown]]();
ioeric wrote:
> What is this `//with comments` for? Maybe explain it in the
kadircet updated this revision to Diff 167283.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52544
Files:
clangd/Diagnostics.cpp
unittests/clangd/ClangdUnitTests.cpp
Index:
JonasToth updated this revision to Diff 167282.
JonasToth marked 3 inline comments as done.
JonasToth added a comment.
- add space after clang-tidy in banner
- refactor slightly, add better in-code comments to explain whats happening,
add more TODOs and FIXMEs
Repository:
rCTE Clang Tools
JonasToth updated this revision to Diff 167270.
JonasToth marked 6 inline comments as done.
JonasToth added a comment.
- move lexer stuff into LexerUtils
- remove custom string handling function
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51949
JonasToth added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:21
+
+#define PRINT_DEBUG 1
+
kbobyrev wrote:
> Do you plan to submit the patch with debugging messages or are you just using
> these for better local debugging experience?
Anastasia created this revision.
Anastasia added reviewers: rjmccall, yaxunl.
C style cast in OpenCL C++ was ignoring the address space conversions from
OpenCL C and as a result accepting incorrect code to compile. This commit adds
correctness checking for address spaces. This makes all OpenCL
JonasToth added a comment.
LGTM, with a few nits and a question. Please wait a bit if @aaron.ballman or
@george.karpenkov have any comments before committing.
Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:88
+bool isPointeeMutable(const Expr *Exp, const ASTContext ) {
+
kbobyrev updated this revision to Diff 167267.
kbobyrev added a comment.
Pass data from I/O to `readIndexFile(StringRef)`.
https://reviews.llvm.org/D52047
Files:
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
Index: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
ioeric added a comment.
This looks like a great improvement. The design looks reasonable to me. The
cache states were a bit confusing at first, but I think more documentation when
polishing the prototype could help.
I'd be really interested in seeing some profiles before/after this
peter.smith created this revision.
peter.smith added reviewers: falstaff84, nickdesaulniers, rengolin, labrinea.
Herald added a reviewer: javed.absar.
Herald added subscribers: chrib, kristof.beyls.
Review https://reviews.llvm.org/D52594 will change the default in llvm for
armv6k from the
JonasToth added a comment.
There has been a commit that seems related: https://reviews.llvm.org/rL343168
@steveire could you please take a look at how it affects this patch?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52334
___
lebedev.ri updated this revision to Diff 167255.
lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.
- Split off the NFC preparatory changes.
- Rebased.
Repository:
rC Clang
https://reviews.llvm.org/D50901
Files:
docs/UndefinedBehaviorSanitizer.rst
jwilk added a comment.
Any reason this hasn't been merged yet?
https://reviews.llvm.org/D35170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:665
+// Add path to lib / lib64 folder.
+SmallString<256> DefaultLibPath =
Hahnfeld wrote:
> ABataev wrote:
> > You're changing the order of the lookup for the paths. Is this
Hahnfeld updated this revision to Diff 167250.
Hahnfeld marked 2 inline comments as done.
Hahnfeld added a comment.
Add `const` per review comments.
https://reviews.llvm.org/D51686
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
owenpan created this revision.
owenpan added reviewers: sammccall, klimek, djasper, krasimir.
Herald added a subscriber: cfe-commits.
https://bugs.llvm.org/show_bug.cgi?id=39067
Repository:
rC Clang
https://reviews.llvm.org/D52591
Files:
lib/Format/UnwrappedLineParser.cpp
lebedev.ri created this revision.
lebedev.ri added reviewers: vsk, vitalybuka, filcab.
Repository:
rC Clang
https://reviews.llvm.org/D52589
Files:
test/CodeGen/catch-implicit-integer-conversions-basics.c
test/CodeGen/catch-implicit-integer-truncations-basics-negatives.c
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/Diagnostics.cpp:55
// Accept the first range that contains the location.
+ llvm::Optional PossibleRange;
for (const auto : D.getRanges()) {
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343184: [Sema] Handle __va_start for Windows/ARM64 in the
same way as for ARM (authored by mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: mstorsjo
Date: Thu Sep 27 01:24:15 2018
New Revision: 343184
URL: http://llvm.org/viewvc/llvm-project?rev=343184=rev
Log:
[Sema] Handle __va_start for Windows/ARM64 in the same way as for ARM
This fixes PR39090.
Differential Revision: https://reviews.llvm.org/D52571
Modified:
vitalybuka reopened this revision.
vitalybuka added a comment.
Reverted in r343183
https://bugs.llvm.org/show_bug.cgi?id=39094
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/29356/steps/build%20release%20tsan%20with%20clang/logs/stdio
Repository:
rL LLVM
Author: vitalybuka
Date: Thu Sep 27 01:15:24 2018
New Revision: 343183
URL: http://llvm.org/viewvc/llvm-project?rev=343183=rev
Log:
Revert "[DebugInfo] Generate debug information for labels."
This reverts commit r343148.
It crashes on sanitizer-x86_64-linux-autoconf.
Removed:
mstorsjo added a comment.
The latest reland of this change still causes compilation crashes, see PR
39094. I'll revert this change for now to fix compilation again.
Repository:
rL LLVM
https://reviews.llvm.org/D45045
___
cfe-commits mailing
theraven added a comment.
> I would have done the same for the GNUstep RTTI here, except I don't actually
> see the code for that anywhere, and no tests seem to break either, so I
> believe it's not upstreamed yet.
I'm not sure I understand this comment. The compiler code is in LLVM and the
theraven added a comment.
In https://reviews.llvm.org/D47233#1129810, @DHowett-MSFT wrote:
> We ran into some critical issues with this approach on x64. The pointers in
> the exception record are supposed to be image-relative instead of absolute,
> so I tried to make them absolute to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343179: clang-format: [JS] conditional types. (authored by
mprobst, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52536
Files:
Author: mprobst
Date: Wed Sep 26 23:48:13 2018
New Revision: 343179
URL: http://llvm.org/viewvc/llvm-project?rev=343179=rev
Log:
clang-format: [JS] conditional types.
Summary:
This change adds some rudimentary support for conditional types.
Specifically it avoids breaking before `extends` and
mprobst updated this revision to Diff 167239.
mprobst added a comment.
- comment in test
Repository:
rC Clang
https://reviews.llvm.org/D52536
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
101 - 165 of 165 matches
Mail list logo
