sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks for the fix!
Comment at: clangd/tool/ClangdMain.cpp:261
} else {
-CompileCommandsDirPath = CompileCommandsDir;
+// If the compile-commands-dir arg
phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added a subscriber: cfe-commits.
When using sanitizers, add //lib/
to the list of library paths to support using sanitized version of
runtime libraries if available.
Repository:
rC Clang
https://reviews.llvm.org/D53487
edward-jones updated this revision to Diff 170373.
edward-jones added a comment.
I've incorporated your suggested changes and added riscv32/64-linux-gnu entrys
to the Triple + LibDirs lists.
Is it worth also updating the riscv32-toolchain.c test in this patch to rename
Author: ioeric
Date: Mon Oct 22 01:47:31 2018
New Revision: 344889
URL: http://llvm.org/viewvc/llvm-project?rev=344889=rev
Log:
[CodeComplete] Fix accessibility of protected members when accessing members
implicitly.
Reviewers: ilya-biryukov
Subscribers: arphaman, cfe-commits
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344889: [CodeComplete] Fix accessibility of protected
members when accessing members… (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53369?vs=169995=170377#toc
xazax.hun added a comment.
Overall looks good if the community agrees with the directions. Some comments
inline.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:243
+ /// specified.
+ StringRef getStringOption(StringRef Name, StringRef DefaultVal);
Author: vmiklos
Date: Sun Oct 21 23:36:30 2018
New Revision: 344885
URL: http://llvm.org/viewvc/llvm-project?rev=344885=rev
Log:
ReleaseNotes: move readability-redundant-smartptr-get part down below new checks
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified:
xazax.hun added a comment.
Overall looks good, minor comments inline.
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp:166
+ "\n\n";
+ out << " clang [CLANG_OPTIONS] -analyzer-config OPTION1=VALUE, "
+ "-analyzer-config OPTION2=VALUE,
gchatelet created this revision.
gchatelet added a reviewer: hokein.
Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53488
Files:
clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp
lebedev.ri added a comment.
@rsmith ping.
Repository:
rC Clang
https://reviews.llvm.org/D50250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HsiangKai added a comment.
In https://reviews.llvm.org/D45045#1247427, @vitalybuka wrote:
> Reverted in r343183
> https://bugs.llvm.org/show_bug.cgi?id=39094
>
>
edward-jones updated this revision to Diff 170374.
edward-jones marked 2 inline comments as done.
https://reviews.llvm.org/D53392
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/Inputs/basic_riscv64_tree/bin/riscv64-unknown-elf-ld
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
This will make it possible to add non-exclusive mode output.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53501
Files:
clang-query/Query.cpp
aprantl updated this revision to Diff 170434.
aprantl added a comment.
further simplify testcase
https://reviews.llvm.org/D53459
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenCXX/ubsan-check-debuglocs.cpp
Index: test/CodeGenCXX/ubsan-check-debuglocs.cpp
steveire updated this revision to Diff 170435.
steveire retitled this revision from "[clang-query] Add non-exclusive output
API " to "[clang-query] Add non-exclusive output API".
steveire added a comment.
New design
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
ioeric added inline comments.
Comment at: clangd/index/FileIndex.h:49
+/// rename the existing FileSymbols to something else e.g. TUSymbols?
+class SymbolsGroupedByFiles {
+public:
sammccall wrote:
> `FileSymbols` isn't actually that opinionated about the data
ioeric updated this revision to Diff 170440.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- address review comments
- minor cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53433
Files:
clangd/index/Background.cpp
clangd/index/Background.h
steveire updated this revision to Diff 170439.
steveire added a comment.
Update docs
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QueryParser.h
Szelethus updated this revision to Diff 170417.
Szelethus added a comment.
- Removed redundant information (like the type or default value of the command
line argument), these are now auto-generated in followup patches
- Added description for `"model-path"`.
https://reviews.llvm.org/D53277
ymandel added a comment.
Correction: the code *catches* the trailing return cases, I just couldn't find
a way to *fix* them; specifically, I was not able to get the necessary source
ranges to re-lex the trailing return type.
Repository:
rCTE Clang Tools Extra
aprantl added a comment.
In https://reviews.llvm.org/D45045#1270442, @HsiangKai wrote:
> In https://reviews.llvm.org/D45045#1247427, @vitalybuka wrote:
>
> > Reverted in r343183
> > https://bugs.llvm.org/show_bug.cgi?id=39094
> >
> >
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks!
https://reviews.llvm.org/D53459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: adrian
Date: Mon Oct 22 09:27:41 2018
New Revision: 344915
URL: http://llvm.org/viewvc/llvm-project?rev=344915=rev
Log:
Ensure sanitizer check function calls have a !dbg location
Function calls without a !dbg location inside a function that has a
DISubprogram make it impossible to
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344915: Ensure sanitizer check function calls have a !dbg
location (authored by adrian, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53459
Files:
lib/CodeGen/CGExpr.cpp
On Tue, Oct 2, 2018 at 10:33 AM Christof Douma
wrote:
> Hi Marshall.
>
> I think that this patch breaks backwards compatibility. Assumes that the
> header file "version" is used by C++ projects that use a C++ standard that
> did not specify a 'version' header. Many toolchains will put search
Szelethus updated this revision to Diff 170432.
Szelethus edited the summary of this revision.
Szelethus added a comment.
Fixes according to inline comments, type and default value are generated now.
https://reviews.llvm.org/D53296
Files:
include/clang/Driver/CC1Options.td
aprantl updated this revision to Diff 170433.
aprantl added a comment.
Simplify testcase
https://reviews.llvm.org/D53459
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenCXX/ubsan-check-debuglocs.cpp
Index: test/CodeGenCXX/ubsan-check-debuglocs.cpp
xazax.hun added a comment.
I agree with NoQ. Forward and backward compatibility might be important for
CodeChecker as well.
But I wonder if it make sense to have analyzer-config compatibility mode on a
per config basis?
E.g., if we have two configs:
- One did not exist in earlier clang
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
This will make it possible to easily
- Add new commands which accept parameters
- Extend the list of features
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53498
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Future development can then dump other content than AST.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53500
Files:
clang-query/Query.cpp
clang-query/Query.h
ymandel marked an inline comment as done.
ymandel added inline comments.
Comment at: test/clang-tidy/readability-const-value-return.cpp:174
+int **const * n_multiple_ptr();
+int *const & n_pointer_ref();
aaron.ballman wrote:
> I'd like to see some more complex
steveire updated this revision to Diff 170431.
steveire added a comment.
Update tests
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53501
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
ymandel updated this revision to Diff 170418.
ymandel added a comment.
Expanded test cases.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck.cpp
steveire updated this revision to Diff 170419.
steveire added a comment.
Format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53498
Files:
clang-query/Query.cpp
Index: clang-query/Query.cpp
===
---
steveire updated this revision to Diff 170420.
steveire added a comment.
Format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53500
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
Index: clang-query/QueryParser.cpp
ebevhan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2026
+return EmitScalarConversion(Visit(E), E->getType(), DestTy,
+CE->getExprLoc());
rjmccall wrote:
> Why are you pushing these casts through
ymandel updated this revision to Diff 170423.
ymandel marked an inline comment as done.
ymandel added a comment.
Fix some message comments in tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53503
Files:
clangd/index/Background.cpp
clangd/index/Background.h
steveire updated this revision to Diff 170427.
steveire added a comment.
Update tests
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53500
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
unittests/clang-query/QueryEngineTest.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344912: [clangd] Support URISchemes configuration in
BackgroundIndex. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53503
Author: ioeric
Date: Mon Oct 22 08:37:58 2018
New Revision: 344912
URL: http://llvm.org/viewvc/llvm-project?rev=344912=rev
Log:
[clangd] Support URISchemes configuration in BackgroundIndex.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Szelethus updated this revision to Diff 170438.
https://reviews.llvm.org/D53296
Files:
include/clang/Driver/CC1Options.td
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyzer/Frontend/FrontendActions.h
lib/Frontend/CompilerInvocation.cpp
EricWF created this revision.
EricWF added a reviewer: rsmith.
When -faligned-allocation is specified in C++03 libc++ defines std::align_val_t
as an unscoped enumeration type (because Clang didn't provide scoped
enumerations as an extension until 8.0).
Unfortunately Clang confuses the
kadircet added inline comments.
Comment at: clangd/CodeComplete.cpp:700
+ unsigned DiagLoc = Loc.second;
+ if (DiagLoc < StartOfLine || DiagLoc > Offset)
+ return;
There are also a lot of cases where we can't find an include file(usually due
to
rsmith added a comment.
I'm very happy with reducing our configuration space like this, if the
distinction is indeed unused (which it appears to be). (If compiling in ObjC1
mode actually is useful, we should instead have a command-line flag for that
and tests; the fact that we don't tells us
Author: yaxunl
Date: Mon Oct 22 19:05:31 2018
New Revision: 344996
URL: http://llvm.org/viewvc/llvm-project?rev=344996=rev
Log:
Add gfx904 and gfx906 to GPU Arch
Differential Revision: https://reviews.llvm.org/D53472
Modified:
cfe/trunk/include/clang/Basic/Cuda.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344996: Add gfx904 and gfx906 to GPU Arch (authored by
yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53472?vs=170311=170560#toc
george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:202
+ void finalizeConstraints() {
+
Higuoxing added a comment.
In https://reviews.llvm.org/D47687#1266893, @vsapsai wrote:
> Sorry about the delay. The change seems to be correct but `ninja check-clang`
> reveals the test "Misc/caret-diags-macros.c" is failing. Can you please look
> into that?
Hi, It's because the expression
DaanDeMeyer updated this revision to Diff 170384.
DaanDeMeyer added a comment.
Updated diff according to comments.
https://reviews.llvm.org/D53481
Files:
clangd/tool/ClangdMain.cpp
Index: clangd/tool/ClangdMain.cpp
===
---
peter.smith added a comment.
Added LLVM_FALLTHROUGH; in r344890.
Repository:
rC Clang
https://reviews.llvm.org/D52784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344891: [OpenCL] Fix definitions of
__builtin_(add|sub|mul)_overflow (authored by mantognini, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52875
Files:
Author: mantognini
Date: Mon Oct 22 03:41:07 2018
New Revision: 344891
URL: http://llvm.org/viewvc/llvm-project?rev=344891=rev
Log:
[OpenCL] Fix definitions of __builtin_(add|sub|mul)_overflow
Ensure __builtin_(add|sub|mul)_overflow return bool instead of void as per
specification
Author: psmith
Date: Mon Oct 22 03:40:52 2018
New Revision: 344890
URL: http://llvm.org/viewvc/llvm-project?rev=344890=rev
Log:
[ARM][AArch64] Add LLVM_FALLTHROUGH to silence warning [NFC]
A follow up to D52784 to add in LLVM_FALLTHROUGH where there is an
intentional fall through in a switch
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: greened
Date: Mon Oct 22 06:46:12 2018
New Revision: 344901
URL: http://llvm.org/viewvc/llvm-project?rev=344901=rev
Log:
Always search sysroot for GCC installs
Previously, if clang was configured with -DGCC_INSTALL_PREFIX, then it
would not search a provided sysroot for a gcc install.
mantognini added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D52879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: rnk, rsmith, zturner, mstorsjo, majnemer.
aleksandr.urakov added a project: clang.
Herald added a subscriber: cfe-commits.
The patch removes alignment of virtual bases when an external layout is used.
We have two cases:
-
Author: ioeric
Date: Mon Oct 22 05:48:49 2018
New Revision: 344897
URL: http://llvm.org/viewvc/llvm-project?rev=344897=rev
Log:
[change-namespace] Enhance detection of conflicting namespaces.
Summary:
For example:
```
namespace util { class Base; }
namespace new {
namespace util { class
erichkeane added a comment.
Yikes, good catch!
Repository:
rL LLVM
https://reviews.llvm.org/D53460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rksimon
Date: Mon Oct 22 03:46:37 2018
New Revision: 344892
URL: http://llvm.org/viewvc/llvm-project?rev=344892=rev
Log:
Fix MSVC "not all control paths return a value" warning. NFCI.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp
Modified:
Author: aaronballman
Date: Mon Oct 22 06:05:53 2018
New Revision: 344898
URL: http://llvm.org/viewvc/llvm-project?rev=344898=rev
Log:
Silence the -Wshadow warning for enumerators shadowing a type.
Amends r344259 so that enumerators shadowing types are not diagnosed, as
shadowing under those
aaron.ballman added a comment.
In https://reviews.llvm.org/D52400#1267731, @aaron.ballman wrote:
> In https://reviews.llvm.org/D52400#1267499, @sberg wrote:
>
> > (and in any case, "declaration shadows a variable" sounds wrong when the
> > shadowed entity is a class type. thats why I thought
xazax.hun added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:445
+
+ANALYZER_OPTION_GEN_FN(StringRef, ModelPath, "model-path", "", "",
getModelPath)
+
Should we explain the feature in the commad line path?
The description
ioeric created this revision.
ioeric added a reviewer: hokein.
Herald added a subscriber: cfe-commits.
For example:
namespace util { class Base; }
namespace new {
namespace util { class Internal; }
}
namespace old {
util::Base b1;
}
When changing `old::` to `new::`, `util::`
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344897: [change-namespace] Enhance detection of conflicting
namespaces. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
greened closed this revision.
greened added a comment.
Fixed in r344901.
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
I think `RetainCountChecker` is the only checker that maintains such maps and
does such cleanup:
https://github.com/llvm-mirror/clang/blob/efe41bf98/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.h#L288
I didn't know it does that until today.
mstorsjo added a comment.
Ping @rnk
https://reviews.llvm.org/D53066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth updated this revision to Diff 170470.
JonasToth marked 4 inline comments as done.
JonasToth added a comment.
- address review nits
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41648
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
patricklyster added inline comments.
Comment at: clang/include/clang/AST/OpenMPClause.h:930
+ /// Returns location of clause kind.
+ SourceLocation getAtomicDefaultMemOrderKindKwLoc() const { return KindKwLoc;
}
+
ABataev wrote:
> Again, probably too long
JonasToth updated this revision to Diff 170471.
JonasToth added a comment.
- add missing private
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41648
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
Author: jonastoth
Date: Mon Oct 22 12:20:01 2018
New Revision: 344940
URL: http://llvm.org/viewvc/llvm-project?rev=344940=rev
Log:
[clang-tidy] implement cppcoreguidelines macro rules
Summary:
In short macros are discouraged by multiple rules (and sometimes reference
randomly). [Enum.1],
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344940: [clang-tidy] implement cppcoreguidelines macro
rules (authored by JonasToth, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41648?vs=170472=170473#toc
Repository:
rCTE
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: krasimir.
reported here https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911561
clang-format-7 -style="{BreakBeforeBraces: Stroustrup}" wasn't doing
the same as the doc
Repository:
rC Clang
tekknolagi updated this revision to Diff 170475.
tekknolagi added a comment.
Make the test case a little easier to read
Repository:
rC Clang
https://reviews.llvm.org/D53206
Files:
lib/StaticAnalyzer/Checkers/PaddingChecker.cpp
test/Analysis/padding_inherit.cpp
Index:
erik.pilkington created this revision.
erik.pilkington added reviewers: bruno, rsmith.
Herald added a subscriber: dexonsmith.
This patch makes clang include headers found in modulemap files in the `.d`
file. This is necessary to capture symlinked headers, which previously were
ignored, since
steveire added a comment.
> This is already not the case with set output diag etc.
Oh, I'm wrong here. I misread your post, sorry.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
___
cfe-commits mailing list
JonasToth added a comment.
Please add a short sentence to the release notes and adjust the documentation
to that check to cover the changes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53488
___
cfe-commits mailing list
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:58
+ const QualType Rhs) {
+ assert(Lhs->isRealType()); // Either integer or floating point.
+ assert(Rhs->isFloatingType()); // Floating point
Author: danalbert
Date: Mon Oct 22 13:16:21 2018
New Revision: 344946
URL: http://llvm.org/viewvc/llvm-project?rev=344946=rev
Log:
[Driver] Reland again: Default Android toolchains to libc++.
Some of the test data went missing last time I tried to submit this,
causing the tests to fail when the
justice_adams added a comment.
@cfe-commits ping requesting a review on this patch
https://reviews.llvm.org/D50563
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
patricklyster created this revision.
patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice,
kkwli0, hfinkel, gtbercea.
patricklyster added projects: clang, OpenMP.
Herald added subscribers: cfe-commits, jfb, arphaman, guansong.
Added new `atomic_default_mem_order` clause
rnk added a comment.
In https://reviews.llvm.org/D53457#1269769, @hans wrote:
> I haven't started looking at the code yet.
>
> I'm not completely convinced that we want this. So far we've used the
> strategy of promoting clang options that are also useful in clang-cl to core
> options, and if
t.p.northover created this revision.
Herald added a subscriber: mcrosier.
The size of an os_log buffer is known at any stage of compilation, so making it
a constant expression means that the common idiom of declaring a buffer for it
won't result in a VLA. That allows the compiler to skip saving
ABataev added a comment.
Check the code formatting, please. There should be lines longer than 80 symbols.
Comment at: clang/include/clang/AST/OpenMPClause.h:886
+ /// \param K Kind of clause.
+ void setAtomicDefaultMemOrderKind(OpenMPAtomicDefaultMemOrderClauseKind K) {
+
tekknolagi added inline comments.
Comment at: test/Analysis/padding_cpp.cpp:204-212
+// expected-warning@+1{{Excessive padding in 'struct FakeIntSandwich'}}
+struct FakeIntSandwich {
+ char c1;
+ int i;
+ char c2;
+};
+
bcraig wrote:
> Looking at this
leonardchan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2026
+return EmitScalarConversion(Visit(E), E->getType(), DestTy,
+CE->getExprLoc());
ebevhan wrote:
> rjmccall wrote:
> > Why are you pushing
Author: sylvestre
Date: Mon Oct 22 12:07:29 2018
New Revision: 344939
URL: http://llvm.org/viewvc/llvm-project?rev=344939=rev
Log:
Hopefully fix the documentation generation issue
Modified:
cfe/trunk/docs/ClangFormatStyleOptions.rst
cfe/trunk/include/clang/Format/Format.h
Modified:
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/MacroUsageCheck.h:34-35
+ void registerPPCallbacks(CompilerInstance ) override;
+ void warnMacro(const MacroDirective *MD);
+ void warnNaming(const MacroDirective *MD);
+
aaron.ballman
steveire added a comment.
> This seems confusing to me because I would expect set foo bar to set the
> value of a variable foo to bar,
This is already not the case with `set output diag` etc.
That said, I don't mind spelling this ` output foo`. It's not
my decision. It's up to the reviewers.
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D53513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: eugenezelenko
Date: Mon Oct 22 12:55:52 2018
New Revision: 344943
URL: http://llvm.org/viewvc/llvm-project?rev=344943=rev
Log:
[Documentation] Fix grammar related to Clang-tidy cppcoreguidelines-macro-usage.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Author: dergachev
Date: Mon Oct 22 13:11:10 2018
New Revision: 344944
URL: http://llvm.org/viewvc/llvm-project?rev=344944=rev
Log:
[analyzer] Fix dumping for SymbolConjured conjured at no particular statement.
Added:
cfe/trunk/test/Analysis/dump_egraph.cpp
Modified:
pcc added a comment.
I'm not really involved in clang-query development these days, so this is more
of a drive-by comment. It wasn't really obvious to me what the wording of the
help text for `set enable-output` meant:
> Set whether to enable content non-exclusively.
I figured out from the
JonasToth updated this revision to Diff 170472.
JonasToth added a comment.
- [Doc] add missing release notes
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41648
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
tekknolagi added inline comments.
Comment at: test/Analysis/padding_cpp.cpp:204-212
+// expected-warning@+1{{Excessive padding in 'struct FakeIntSandwich'}}
+struct FakeIntSandwich {
+ char c1;
+ int i;
+ char c2;
+};
+
tekknolagi wrote:
> bcraig wrote:
> >
danalbert accepted this revision.
danalbert added a comment.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D53463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344941: [Driver] allow Android triples to alias for non
Android targets (authored by nickdesaulniers, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53463?vs=170283=170478#toc
Author: nickdesaulniers
Date: Mon Oct 22 12:48:08 2018
New Revision: 344941
URL: http://llvm.org/viewvc/llvm-project?rev=344941=rev
Log:
[Driver] allow Android triples to alias for non Android targets
Summary:
Partial revert of r330873 ('[Driver] Reland "Android triples are not
aliases for other
1 - 100 of 167 matches
Mail list logo
