[PATCH] D53066: [RFC] [Driver] Use forward slashes in most linker arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL345004: [Driver] Use forward slashes in most linker arguments (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r345003 - [MinGW] Link to correct openmp library

Author: mstorsjo Date: Mon Oct 22 23:33:22 2018 New Revision: 345003 URL: http://llvm.org/viewvc/llvm-project?rev=345003=rev Log: [MinGW] Link to correct openmp library Patch by Peiyuan Song! Differential Revision: https://reviews.llvm.org/D53397 Modified:

r345004 - [Driver] Use forward slashes in most linker arguments

Author: mstorsjo Date: Mon Oct 22 23:33:26 2018 New Revision: 345004 URL: http://llvm.org/viewvc/llvm-project?rev=345004=rev Log: [Driver] Use forward slashes in most linker arguments libtool inspects the output of $CC -v to detect what object files and libraries are linked in by default. When

[PATCH] D53397: [MinGW] Link to correct openmp library

This revision was automatically updated to reflect the committed changes. Closed by commit rL345003: [MinGW] Link to correct openmp library (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53397 Files:

r345005 - Revert "[Driver] Use forward slashes in most linker arguments"

Author: mstorsjo Date: Tue Oct 23 00:01:55 2018 New Revision: 345005 URL: http://llvm.org/viewvc/llvm-project?rev=345005=rev Log: Revert "[Driver] Use forward slashes in most linker arguments" This reverts commit r345004, as it broke tests when actually run on windows; see e.g.

[PATCH] D52400: Improve -Wshadow warnings with enumerators

sberg added a comment. > I've silenced this scenario in r344898, thank you for raising the issue! thanks! works fine for me https://reviews.llvm.org/D52400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

AlexeySotkin added a comment. In https://reviews.llvm.org/D43783#1215573, @Anastasia wrote: > In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote: > > > In https://reviews.llvm.org/D43783#1204353, @svenvh wrote: > > > > > Sorry for digging up an old commit... > > > > > > Apparently this

r345009 - [DebugInfo] Generate debug information for labels. (After fix PR39094)

Author: hsiangkai Date: Tue Oct 23 01:06:21 2018 New Revision: 345009 URL: http://llvm.org/viewvc/llvm-project?rev=345009=rev Log: [DebugInfo] Generate debug information for labels. (After fix PR39094) Generate DILabel metadata and call llvm.dbg.label after label statement to associate the

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC345009: [DebugInfo] Generate debug information for labels. (After fix PR39094) (authored by HsiangKai, committed by ).

[PATCH] D53497: [AST] Do not align virtual bases in `MicrosoftRecordLayoutBuilder` when an external layout is used

aleksandr.urakov added a comment. Thank you! Repository: rC Clang https://reviews.llvm.org/D53497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53497: [AST] Do not align virtual bases in `MicrosoftRecordLayoutBuilder` when an external layout is used

This revision was automatically updated to reflect the committed changes. Closed by commit rC345012: [AST] Do not align virtual bases in `MicrosoftRecordLayoutBuilder` when (authored by aleksandr.urakov, committed by ). Repository: rC Clang https://reviews.llvm.org/D53497 Files:

[PATCH] D53558: Add gfx909 to GPU Arch

tpr created this revision. Herald added subscribers: cfe-commits, jholewinski. tpr added reviewers: yaxunl, kzhuravl. Repository: rC Clang https://reviews.llvm.org/D53558 Files: include/clang/Basic/Cuda.h lib/Basic/Cuda.cpp lib/Basic/Targets/NVPTX.cpp Index:

r345012 - [AST] Do not align virtual bases in `MicrosoftRecordLayoutBuilder` when

Author: aleksandr.urakov Date: Tue Oct 23 01:23:22 2018 New Revision: 345012 URL: http://llvm.org/viewvc/llvm-project?rev=345012=rev Log: [AST] Do not align virtual bases in `MicrosoftRecordLayoutBuilder` when an external layout is used Summary: The patch removes alignment of virtual bases

[PATCH] D53439: [clangd] Remove caching of compilation database commands.

sammccall added a comment. Ping - this seems straightforward, and blocks further cleanups. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53561: [clang] Fix a null pointer dereference.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Can you construct an example and add a simple lit test? https://reviews.llvm.org/rL344133 is a recent similar change. Repository: rC Clang https://reviews.llvm.org/D53561

[PATCH] D53488: [clang-tidy] Catching narrowing from double to float.

gchatelet updated this revision to Diff 170605. gchatelet marked 2 inline comments as done. gchatelet added a comment. - Addressing comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53488 Files: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp

[PATCH] D53457: clang-cl: Add "/Xdriver:" pass-through arg support.

hans added a comment. In https://reviews.llvm.org/D53457#1271046, @neerajksingh wrote: > In https://reviews.llvm.org/D53457#1269769, @hans wrote: > > > I'm not completely convinced that we want this. So far we've used the > > strategy of promoting clang options that are also useful in clang-cl

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

hans added a comment. In https://reviews.llvm.org/D51340#1266312, @takuto.ikuta wrote: > Hans, I addressed all your comments. > How do you think about current implementation? Just a few questions, but I think it's pretty good. Comment at:

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

Szelethus added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:182 + /// constraint being changed. + bool isChanged(const Stmt *Cond, StringRef Message) { +ConstraintMap::iterator I = Constraints.find(Cond);

[clang-tools-extra] r345020 - Fix range length comparison in DraftStore::UpdateDraft when Unicode characters are removed from the document

Author: sammccall Date: Tue Oct 23 04:51:53 2018 New Revision: 345020 URL: http://llvm.org/viewvc/llvm-project?rev=345020=rev Log: Fix range length comparison in DraftStore::UpdateDraft when Unicode characters are removed from the document Summary: See

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

hans accepted this revision. hans added a comment. Looks good to me. Repository: rC Clang https://reviews.llvm.org/D53476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52857: [clang-query] Add non-exclusive output API

steveire added a comment. I prefer the API from Peter. I think it's a good additional step from where Aaron and I reached in IRC discussion (this patch currently). I can change the patch to use that later if you agree Aaron? Repository: rCTE Clang Tools Extra

[clang-tools-extra] r345024 - [clangd] Remove caching of compilation database commands.

Author: sammccall Date: Tue Oct 23 06:14:02 2018 New Revision: 345024 URL: http://llvm.org/viewvc/llvm-project?rev=345024=rev Log: [clangd] Remove caching of compilation database commands. Summary: The CDB implementations used in open-source code are fast, and our private slow CDB will soon do

Re: r345009 - [DebugInfo] Generate debug information for labels. (After fix PR39094)

This broke Chromium again. I've reverted in rr345026 See https://bugs.chromium.org/p/chromium/issues/detail?id=898152#c1 for the reproducer. On Tue, Oct 23, 2018 at 1:06 AM, Hsiangkai Wang via cfe-commits wrote: > Author: hsiangkai > Date: Tue Oct 23 01:06:21 2018 > New Revision: 345009 > >

r345026 - Revert r345009 "[DebugInfo] Generate debug information for labels. (After fix PR39094)"

Author: hans Date: Tue Oct 23 06:17:13 2018 New Revision: 345026 URL: http://llvm.org/viewvc/llvm-project?rev=345026=rev Log: Revert r345009 "[DebugInfo] Generate debug information for labels. (After fix PR39094)" This broke the Chromium build. See

[PATCH] D53066: [RFC] [Driver] Use forward slashes in most linker arguments

mstorsjo reopened this revision. mstorsjo added a comment. This revision is now accepted and ready to land. So, this failed due to some tests expecting to find the exact same path substring in different parts of the output (used with FileCheck captured variables):

[PATCH] D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls

AlexeySachkov updated this revision to Diff 170601. AlexeySachkov added a comment. Updated tests https://reviews.llvm.org/D53200 Files: lib/Serialization/ASTWriter.cpp test/SemaOpenCL/extension-begin.cl test/SemaOpenCL/extension-begin.h Index: test/SemaOpenCL/extension-begin.h

[PATCH] D53527: Fix range length comparison in DraftStore::UpdateDraft when Unicode characters are removed from the document

This revision was automatically updated to reflect the committed changes. Closed by commit rL345020: Fix range length comparison in DraftStore::UpdateDraft when Unicode characters… (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D53439: [clangd] Remove caching of compilation database commands.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345024: [clangd] Remove caching of compilation database commands. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D53191: [clang] Introduce new completion context types

kadircet added a comment. There are still some contexts where both a new name and an existing name is permissible, going to add a comment on those to leave some traces for the next person who cares Repository: rC Clang https://reviews.llvm.org/D53191

[PATCH] D53527: Fix range length comparison in DraftStore::UpdateDraft when Unicode characters are removed from the document

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for the fix! Just comment nits. Comment at: clangd/DraftStore.cpp:85 + +// The difference between EndIndex and StartIndex gives the range length in +//

[PATCH] D53481: [clangd] Support passing a relative path to -compile-commands-dir

DaanDeMeyer added a comment. You can commit them. Thanks for all the quick responses! https://reviews.llvm.org/D53481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53558: Add gfx909 to GPU Arch

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D53558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r345022 - [clangd] Support passing a relative path to -compile-commands-dir

Author: sammccall Date: Tue Oct 23 04:54:36 2018 New Revision: 345022 URL: http://llvm.org/viewvc/llvm-project?rev=345022=rev Log: [clangd] Support passing a relative path to -compile-commands-dir Summary: This is useful when using clangd with CMake based projects in Visual Studio Code since

[PATCH] D53498: Re-word command help for clang-query

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor wording nits. Comment at: clang-query/Query.cpp:53 +" print " +"pretty-print bound

[PATCH] D53481: [clangd] Support passing a relative path to -compile-commands-dir

sammccall added a comment. It looks like these are your first couple of LLVM patches. So, welcome :-) And do you want me to commit them for you? Typically your first few patches get landed by someone else, and then you ask for commit access:

[PATCH] D53561: [clang] Fix a null pointer dereference.

kadircet updated this revision to Diff 170608. kadircet added a comment. Herald added a subscriber: arphaman. - Add tests. Repository: rC Clang https://reviews.llvm.org/D53561 Files: lib/Sema/SemaCodeComplete.cpp test/Index/complete-switch.c Index: test/Index/complete-switch.c

[PATCH] D53481: [clangd] Support passing a relative path to -compile-commands-dir

This revision was automatically updated to reflect the committed changes. Closed by commit rL345022: [clangd] Support passing a relative path to -compile-commands-dir (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D53561: [clang] Fix a null pointer dereference.

kadircet created this revision. kadircet added reviewers: sammccall, ioeric, hokein. Herald added a subscriber: cfe-commits. Sometimes expression inside switch statement can be invalid, for example type might be incomplete. In those cases code were causing a null pointer dereference. This patch

[PATCH] D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1

filcab added a comment. Ping! Thank you, Filipe Repository: rC Clang https://reviews.llvm.org/D52615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

grimar added a comment. Maybe `-gno-dwo`? So we would write `-genable-split-dwarf -gno-dwo`? https://reviews.llvm.org/D52296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet updated this revision to Diff 170626. kadircet added a comment. - Rebase and take in new changes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp clangd/index/SymbolCollector.cpp unittests/clangd/CodeCompleteTests.cpp Index:

[PATCH] D53527: Fix range length comparison in DraftStore::UpdateDraft when Unicode characters are removed from the document

DaanDeMeyer updated this revision to Diff 170603. DaanDeMeyer added a comment. Update diff according to comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53527 Files: clangd/DraftStore.cpp clangd/SourceCode.cpp clangd/SourceCode.h

[PATCH] D53500: Add 'detailed-ast' output as an alias for 'dump'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some fixes to the wording. Comment at: clang-query/Query.cpp:57 +" detailed-ast " +"Detailed AST output for

[PATCH] D52857: [clang-query] Add non-exclusive output API

aaron.ballman added a comment. In https://reviews.llvm.org/D52857#1272276, @steveire wrote: > I prefer the API from Peter. I think it's a good additional step from where > Aaron and I reached in IRC discussion (this patch currently). > > I can change the patch to use that later if you agree

[PATCH] D53191: [clang] Use Statement and Namespace instead of Name and PotentiallyQualifiedName

kadircet updated this revision to Diff 170628. kadircet added a comment. Herald added a subscriber: arphaman. - Use new types - Rebase Repository: rC Clang https://reviews.llvm.org/D53191 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Frontend/ASTUnit.cpp

[PATCH] D53399: [clangd] Ensure that we reply to each call exactly once. NFC (I think!)

sammccall updated this revision to Diff 170593. sammccall added a comment. Make ReplyOnce move-only. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53399 Files: clangd/ClangdLSPServer.cpp Index: clangd/ClangdLSPServer.cpp

[PATCH] D53501: [clang-query] Refactor Output settings to booleans

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from minor commenting nits. Comment at: clang-query/Query.h:17 #include "llvm/ADT/Optional.h" + #include Spurious newline, or

[PATCH] D53488: [clang-tidy] Catching narrowing from double to float.

hokein added a comment. Could you also update the check documentation `clang-tidy/checks/cppcoreguidelines-narrowing-conversions.rst`? Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:83 + } else { +llvm_unreachable("Invalid state"); }

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

AlexeySachkov updated this revision to Diff 170630. AlexeySachkov added a comment. Rebase to the ToT https://reviews.llvm.org/D52654 Files: include/clang/AST/OperationKinds.def include/clang/Sema/Initialization.h lib/AST/Expr.cpp lib/AST/ExprConstant.cpp lib/CodeGen/CGExpr.cpp

[PATCH] D53191: [clang] Introduce new completion context types

kadircet updated this revision to Diff 170631. kadircet added a comment. - Add comments. Repository: rC Clang https://reviews.llvm.org/D53191 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Frontend/ASTUnit.cpp lib/Sema/CodeCompleteConsumer.cpp lib/Sema/SemaCodeComplete.cpp

[PATCH] D53543: [analyzer] MallocChecker: pr39348: Realize that sized delete isn't a custom delete.

MTC added inline comments. Comment at: test/Analysis/NewDelete-custom.cpp:7 -#if !(LEAKS && !ALLOCATOR_INLINING) // expected-no-diagnostics Should we continue to keep this line? Comment at: test/Analysis/NewDelete-sized-deallocation.cpp:1

[clang-tools-extra] r345031 - [clangd] Lazily create CDB, remove setCompileCommandsDir.

Author: sammccall Date: Tue Oct 23 07:19:54 2018 New Revision: 345031 URL: http://llvm.org/viewvc/llvm-project?rev=345031=rev Log: [clangd] Lazily create CDB, remove setCompileCommandsDir. Summary: The only way to actually set the directory is at initialize time, so now CDB is lazy we can pass

[PATCH] D53572: [clangd] Lazily create CDB, remove setCompileCommandsDir.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53577: [clangd] Hide position line and column fields.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53577 Files: clangd/index/Index.h Index: clangd/index/Index.h

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

asavonic closed this revision. asavonic added a comment. Committed revision 345044 https://reviews.llvm.org/D51402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53339: [clang-tidy] Add the abseil-duration-factory-float check

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. @alexfh you did comment before, do you want to add more? I have no issues left. Please give alex the opportunity to react, but if he doesn't (he has a lot to do) you can commit in 3

[PATCH] D53571: [clangd] Don't show base class versions of members as completions.

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. These are available via qualifiers, but signal to noise level is low. Keep required quailifier machinery around though, for cross-ns

[PATCH] D53561: [clang] Fix a null pointer dereference.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345029: [clang] Fix a null pointer dereference. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53561 Files:

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet updated this revision to Diff 170634. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp clangd/index/SymbolCollector.cpp

[PATCH] D53578: [CodeGen] Fix clang test for gcov profiling (follow-up of D51974)

calixte created this revision. calixte added a reviewer: vsk. Herald added a subscriber: cfe-commits. After patch https://reviews.llvm.org/D51974 has landed, this one is required to fix a test. Repository: rC Clang https://reviews.llvm.org/D53578 Files: test/CodeGen/code-coverage.c

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov updated this revision to Diff 170657. AlexeySachkov added a comment. Applied comments. Rebased to ToT https://reviews.llvm.org/D51484 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/OpenCLExtensionTypes.def

r345044 - [OpenCL] Add cl_intel_planar_yuv extension

Author: asavonic Date: Tue Oct 23 09:13:16 2018 New Revision: 345044 URL: http://llvm.org/viewvc/llvm-project?rev=345044=rev Log: [OpenCL] Add cl_intel_planar_yuv extension Just adding a preprocessor #define for the extension. Patch by Alexey Sotkin and Dmitry Sidorov Phabricator review:

[PATCH] D53308: [Fixed Point Arithmetic] Fixed Point to Boolean Cast

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2026 +return EmitScalarConversion(Visit(E), E->getType(), DestTy, +

Re: r345009 - [DebugInfo] Generate debug information for labels. (After fix PR39094)

I found another assert (two really) caused by this patch. Reproducer for one of them here: https://bugs.chromium.org/p/chromium/issues/detail?id=898160#c3 On Tue, Oct 23, 2018 at 6:19 AM, Hans Wennborg wrote: > This broke Chromium again. I've reverted in rr345026 > > See

[PATCH] D53433: [clangd] auto-index stores symbols per-file instead of per-TU.

ioeric added inline comments. Comment at: clangd/index/IndexAction.h:33 +std::function RefsCallback, +std::function FileDigestsCallback); sammccall wrote: > thinking about what we eventually want here: > - the index action needs to tell the

[PATCH] D52949: [Diagnostics] Implement -Wsizeof-pointer-div

MTC added a comment. In https://reviews.llvm.org/D52949#1268640, @xbolva00 wrote: > Second thought, I don't think we should recommend std::size here (maybe it > should be okay for clang static analyzers) > > uint32_t data[] = {10, 20, 30, 40}; > len = sizeof(data)/sizeof(*data); // "warn" on

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet updated this revision to Diff 170678. kadircet added a comment. - Use new enum types. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp clangd/index/SymbolCollector.cpp unittests/clangd/CodeCompleteTests.cpp Index:

[PATCH] D53191: [clang] Introduce new completion context types

kadircet updated this revision to Diff 170677. kadircet marked 2 inline comments as done. kadircet added a comment. - Use Symol, SymbolOrNewName, NewName - Address comments. Repository: rC Clang https://reviews.llvm.org/D53191 Files: include/clang/Sema/CodeCompleteConsumer.h

[PATCH] D53587: [clangd] Truncate SymbolID to 16 bytes.

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. The goal is 8 bytes, which has a nonzero risk of collisions with huge indexes. This patch should shake out any issues with truncation

[PATCH] D53572: [clangd] Lazily create CDB, remove setCompileCommandsDir.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345031: [clangd] Lazily create CDB, remove setCompileCommandsDir. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53572

[PATCH] D52857: [clang-query] Add non-exclusive output API

aaron.ballman added a comment. In https://reviews.llvm.org/D52857#1272420, @steveire wrote: > Yep, that's the suggestion. That will result in commands such as: > > - `enable output detailed-ast` > - `disable output detailed-ast` > - `set output detailed-ast` > - `enable output diag` > - `disable

[PATCH] D53482: Add clang-format stability check with FormatTests

vglavnyy updated this revision to Diff 170663. vglavnyy added a comment. A twice-format problem: the format of format isn't format. This commit surface an instability problem in clang-format at unit-tests level. The patch adds double-checking format method for all test and adds a stub for tests

[PATCH] D53586: Implement Function Multiversioning for Non-ELF Systems.

erichkeane created this revision. erichkeane added reviewers: echristo, rnk, aaron.ballman. erichkeane added a subscriber: mibintc. Similar to how ICC handles CPU-Dispatch on Windows, this patch uses the resolver function directly to forward the call to the proper function. This is not nearly as

r345029 - [clang] Fix a null pointer dereference.

Author: kadircet Date: Tue Oct 23 06:49:37 2018 New Revision: 345029 URL: http://llvm.org/viewvc/llvm-project?rev=345029=rev Log: [clang] Fix a null pointer dereference. Summary: Sometimes expression inside switch statement can be invalid, for example type might be incomplete. In those cases

[PATCH] D53153: [OpenCL] Mark namespace scope variables and kernel functions with default visibility

scott.linder added a comment. In https://reviews.llvm.org/D53153#1263882, @rsmith wrote: > In https://reviews.llvm.org/D53153#1263848, @scott.linder wrote: > > > Beyond constructors/destructors I believe an API which we implement through > > access to dynamic symbols for global variable is > >

[PATCH] D53339: [clang-tidy] Add the abseil-duration-factory-float check

hwright added inline comments. Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.h:19 + +/// Prefer integer Duration factories when possible. +/// JonasToth wrote: > Please add more to the doc here, like `This check finds ... and transforms > these calls

[PATCH] D53339: [clang-tidy] Add the abseil-duration-factory-float check

hwright updated this revision to Diff 170659. hwright marked 5 inline comments as done. hwright added a comment. Address reviewer comments https://reviews.llvm.org/D53339 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

atanasyan added a comment. In https://reviews.llvm.org/D52418#1271779, @brad wrote: > How is it going with regard to N32 fixes / testing? I'm in the process of building/testing LLVM/Clang binaries for N32 ABI. Repository: rC Clang https://reviews.llvm.org/D52418

[PATCH] D53572: [clangd] Lazily create CDB, remove setCompileCommandsDir.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. The only way to actually set the directory is at initialize time, so now CDB is lazy we can pass it to the constructor.

[PATCH] D53153: [OpenCL] Mark namespace scope variables and kernel functions with default visibility

scott.linder updated this revision to Diff 170637. scott.linder added a comment. Don't mark namespace-scope global variable declarations in OpenCL with explicit default visibility https://reviews.llvm.org/D53153 Files: lib/AST/Decl.cpp test/CodeGenOpenCL/visibility.cl Index:

[PATCH] D53191: [clang] Introduce new completion context types

sammccall added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:277 + +/// Code completion occurred where an existing name is expected. +CCC_ExistingName, It's not obvious what "name" means here, e.g. what distinguishes this from

[PATCH] D52857: [clang-query] Add non-exclusive output API

steveire added a comment. Yep, that's the suggestion. That will result in commands such as: - `enable output detailed-ast` - `disable output detailed-ast` - `set output detailed-ast` - `enable output diag` - `disable output diag` - `set output diag` etc, which I think addresses all concerns.

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

djasper added inline comments. Comment at: unittests/Format/FormatTest.cpp:11604 + " x.end(), //\n" + " [&](int, int) { return 1; });\n" "}\n"); oleg.smolsky wrote: > krasimir wrote: > > This looks a bit

r345038 - [OpenCL][NFC] Unify ZeroToOCL* cast types

Author: asavonic Date: Tue Oct 23 08:19:20 2018 New Revision: 345038 URL: http://llvm.org/viewvc/llvm-project?rev=345038=rev Log: [OpenCL][NFC] Unify ZeroToOCL* cast types Reviewers: Anastasia, yaxunl Reviewed By: Anastasia Subscribers: asavonic, cfe-commits Differential Revision:

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

This revision was automatically updated to reflect the committed changes. Closed by commit rC345038: [OpenCL][NFC] Unify ZeroToOCL* cast types (authored by asavonic, committed by ). Repository: rC Clang https://reviews.llvm.org/D52654 Files: include/clang/AST/OperationKinds.def

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov marked 2 inline comments as done. AlexeySachkov added inline comments. Comment at: lib/Headers/opencl-c.h:16197 +#ifdef cl_intel_device_side_avc_motion_estimation +#pragma OPENCL EXTENSION cl_intel_device_side_avc_motion_estimation : enable +

[PATCH] D53482: Add clang-format stability check with FormatTests

vglavnyy added a comment. @krasimir thank you for review. The patch code has been updated. I hope this patch will help to start to fix this issue. Probably will be helpful to add an optional debug flag will enable a twice-run checking for every run of clang-format.

[PATCH] D53295: Mark store and load of block invoke function as invariant.group

rjmccall added a reviewer: Prazek. rjmccall added a comment. In https://reviews.llvm.org/D53295#1271590, @Anastasia wrote: > Btw, blocks w/o captures are already optimized into regular calls? That's a very easy optimization for the optimizer to do because the global can be marked constant.

[clang-tools-extra] r345049 - [clang-tidy] Add a separate section for NOLINT(NEXTLINE)? doc.

Author: alexfh Date: Tue Oct 23 09:48:16 2018 New Revision: 345049 URL: http://llvm.org/viewvc/llvm-project?rev=345049=rev Log: [clang-tidy] Add a separate section for NOLINT(NEXTLINE)? doc. Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst Modified:

[PATCH] D53589: [bash-autocompletion] Fix bug when a flag ends with '='

yamaguchi created this revision. yamaguchi added reviewers: teemperor, ruiu. There was a bug that when a flag ends with '=' and no value was suggested, clang autocompletes the flag itself. For example, in bash, it looked like this: $ clang -fmodule-file=[tab] -> $clang

r345063 - [Fixed Point Arithmetic] Fixed Point to Boolean Cast

Author: leonardchan Date: Tue Oct 23 10:55:35 2018 New Revision: 345063 URL: http://llvm.org/viewvc/llvm-project?rev=345063=rev Log: [Fixed Point Arithmetic] Fixed Point to Boolean Cast This patch is a part of https://reviews.llvm.org/D48456 in an attempt to split the casting logic up into

[PATCH] D53543: [analyzer] MallocChecker: pr39348: Realize that sized delete isn't a custom delete.

george.karpenkov added a comment. > because the guard that prevents it from working is useless and can be removed > as well Should we remove it then? Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:729 + SourceLocation L = FD->getLocation(); + return !L.isValid()

[PATCH] D53308: [Fixed Point Arithmetic] Fixed Point to Boolean Cast

This revision was automatically updated to reflect the committed changes. Closed by commit rC345063: [Fixed Point Arithmetic] Fixed Point to Boolean Cast (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D53308?vs=169863=170699#toc Repository: rC

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky marked 2 inline comments as done. oleg.smolsky added inline comments. Comment at: unittests/Format/FormatTest.cpp:11604 + " x.end(), //\n" + " [&](int, int) { return 1; });\n" "}\n"); djasper

[PATCH] D53547: NFC: Remove the ObjC1/ObjC2 distinction from clang (and related projects)

erik.pilkington updated this revision to Diff 170703. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Fix some spacing mistakes. Thanks! https://reviews.llvm.org/D53547 Files: clang-tools-extra/clang-tidy/google/AvoidCStyleCastsCheck.cpp

[PATCH] D53547: NFC: Remove the ObjC1/ObjC2 distinction from clang (and related projects)

erik.pilkington added a subscriber: jingham. erik.pilkington added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:166-167 // in non-arc mode. - if (LangOpts.ObjC2 && (Flags & KEYARC)) return KS_Enabled; - if (LangOpts.ObjC2 && (Flags & KEYOBJC2)) return

[PATCH] D53591: Support the __gnu__ scoped attribute token

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie, echristo. Herald added a subscriber: krytarowski. GCC is currently considering a patch to accept `__gnu__` as a scoped attribute namespace that aliases to `gnu`. This is useful for libstdc++ so that they don't

[PATCH] D53543: [analyzer] MallocChecker: pr39348: Realize that sized delete isn't a custom delete.

NoQ updated this revision to Diff 170704. NoQ marked an inline comment as done. NoQ added a comment. Add tests for different versions of the standard and for different ways to declare operator delete. > Should we remove it then? > why it's fine to remove this branch? Because these two

[PATCH] D53547: NFC: Remove the ObjC1/ObjC2 distinction from clang (and related projects)

theraven accepted this revision. theraven added a comment. This revision is now accepted and ready to land. Looks good for me, and removing all of the code describing Objective-C 4 as ObjC1 makes me happy. Comment at:

  1   2   >