[PATCH] D54438: [analyzer][WIP] Reimplement dependencies between checkers

Szelethus added a comment. In https://reviews.llvm.org/D54438#1296239, @NoQ wrote: > Mm, i don't understand. I mean, what prevents you from cutting it off even > earlier and completely omitting that part of the patch? Somebody will get to > this later in order to see how exactly does the

[PATCH] D54402: Extract method to allow re-use

steveire added a comment. This is just a NFC change, which is normal to appear without tests. The consensus on IRC is that this is fine. Repository: rC Clang https://reviews.llvm.org/D54402 ___ cfe-commits mailing list

[PATCH] D54246: [clang-tidy] Add the abseil-duration-factory-scale check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/DurationFactoryScaleCheck.cpp:57-58 +// One and only one of `IntLit` and `FloatLit` should be provided. +static double GetValue(const IntegerLiteral *IntLit, + const FloatingLiteral

[PATCH] D54405: Record whether a AST Matcher constructs a Node

zturner added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename

[PATCH] D53982: Output "rule" information in SARIF

aaron.ballman added inline comments. Comment at: lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:237-242 +#define GET_CHECKERS +#define CHECKER(FULLNAME, CLASS, CXXFILE, HELPTEXT, GROUPINDEX, HIDDEN) \ + .Case(FULLNAME, HELPTEXT) +#include

[PATCH] D32577: CMake: Replace open-coded find_package

This revision was automatically updated to reflect the committed changes. Closed by commit rL346731: CMake: Replace open-coded find_package (authored by tstellar, committed by ). Repository: rL LLVM https://reviews.llvm.org/D32577 Files: cfe/trunk/CMakeLists.txt Index:

r346731 - CMake: Replace open-coded find_package

Author: tstellar Date: Mon Nov 12 19:16:45 2018 New Revision: 346731 URL: http://llvm.org/viewvc/llvm-project?rev=346731=rev Log: CMake: Replace open-coded find_package Reviewers: beanz, mgorny Reviewed By: mgorny Subscribers: cfe-commits, chapuni, llvm-commits Differential Revision:

[PATCH] D54438: [analyzer][WIP] Reimplement dependencies between checkers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok, so the point is to fix the current checker name problem, right? I guess let's land it then :) Code looks great. I'm thinking aloud in inline comments a little bit, but don't mind me.

[PATCH] D54372: [analyzer] MisusedMovedObject: NFC: Remove dead code after D18860

NoQ updated this revision to Diff 173779. NoQ added a comment. Bring back the early return for destructors. Cleaning up the state might be unnecessary, but calling a destructor on a moved object is still fine and should not cause a warning. Add a test because this wasn't caught by tests.

[PATCH] D54438: [analyzer][WIP] Reimplement dependencies between checkers

Szelethus added a comment. Actually, no. The main problem here is that `InnerPointerChecker` doesn't only want to register `MallocBase`, it needs to modify the checker object. In any case, either `MallocChecker.cpp` needs the definition of `InnerPointerChecker`, or vice versa. Sure, I could

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1792 + let Spellings = [GNU<"aarch64_vector_pcs">, + CXX11<"clang", "aarch64_vector_pcs">, + Keyword<"__aarch64_vector_pcs">, Rather than using GNU

[PATCH] D54459: [analyzer] Dump reproducible identifiers for objects under construction.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, baloghadamsoftware. This continues the work that was started in

[PATCH] D54407: Record the matcher type when storing a binding

steveire updated this revision to Diff 173774. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54407 Files: include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/ASTMatchersInternal.cpp lib/Tooling/RefactoringCallbacks.cpp

[PATCH] D54407: Record the matcher type when storing a binding

steveire added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:154 +bool operator<(const NodeEntry ) const { + return DynNode < other.DynNode && NodeKind < other.NodeKind; +} aaron.ballman wrote: > This doesn't provide

[PATCH] D54407: Record the matcher type when storing a binding

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor formatting nit, LGTM. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:154 +bool operator<(const NodeEntry ) const { +

[PATCH] D54453: Remove myself as owner of clang-query.

pcc created this revision. pcc added reviewers: klimek, alexfh. Herald added a subscriber: llvm-commits. I haven't been involved with the project for years, so it's probably best for someone else to be the code owner. Repository: rL LLVM https://reviews.llvm.org/D54453 Files:

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

dblaikie added a comment. Could you fix the modulemap (might amount to reverting the change Eric made in r342827? or maybe it's more involved than that) & validate that the modules build is working with this change (probably undo Eric's change, validate that you see the breakage that Eric was

[PATCH] D54405: Record whether a AST Matcher constructs a Node

zturner added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename

[PATCH] D51531: [analyzer][UninitializedObjectChecker] Uninit regions are only reported once

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Mm, ok, i admit that i don't know what specific de-duplication do we want to have and what are the usability implications of it. If we want de-duplication for the same region reported in different

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/altivec-generic-overload.c:74 + convert1(gv1); + // CHECK: call void @_Z8convert1Dv16_a(<16 x i8> %{{[0-9]+}}) + convert1(gv2); Checking that the call is to the expected target in

[PATCH] D54408: Add matchers available through casting to derived

aaron.ballman added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:645 +getNodeConstructorType(MatcherCtor targetCtor) { + auto const = RegistryData->nodeConstructors(); + Don't use `auto` here (and if you did. the `const` would go on the

[PATCH] D54453: Remove myself as owner of clang-query.

aaron.ballman added a comment. Thank you for all of your hard work on clang-query! I'm happy to pick up the torch as I seem to do a fair amount of the reviews for the tool, but I'm also happy to let Manuel or Alex pick it up if they would prefer. Repository: rL LLVM

[PATCH] D54402: Extract method to allow re-use

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D54402#1296273, @steveire wrote: > This is just a NFC change, which is normal to appear without tests. The > consensus on IRC is that this is fine.

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

This revision was automatically updated to reflect the committed changes. Closed by commit rC346732: CMake: Deprecate using llvm-config to detect llvm installation (authored by tstellar, committed by ). Changed prior to commit: https://reviews.llvm.org/D51714?vs=167413=173808#toc Repository:

r346732 - CMake: Deprecate using llvm-config to detect llvm installation

Author: tstellar Date: Mon Nov 12 19:42:46 2018 New Revision: 346732 URL: http://llvm.org/viewvc/llvm-project?rev=346732=rev Log: CMake: Deprecate using llvm-config to detect llvm installation Summary: clang currently uses llvm-config to determine the installation paths for llvm's headers and

r346733 - [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

Author: tikuta Date: Mon Nov 12 20:14:09 2018 New Revision: 346733 URL: http://llvm.org/viewvc/llvm-project?rev=346733=rev Log: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag Summary: /Zc:dllexportInlines with /fallback may cause unexpected linker error. It is

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

This revision was automatically updated to reflect the committed changes. Closed by commit rC346733: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag (authored by tikuta, committed by ). Changed prior to commit: https://reviews.llvm.org/D54426?vs=173810=173811#toc

[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

aaron.ballman added a comment. In https://reviews.llvm.org/D54258#1295158, @richardmembarth wrote: > There are external tools (e.g. hipacc ) that > generate Clang AST. This AST uses `LangAS` annotations and emits incorrect > memory space specifiers for CUDA when

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

NoQ created this revision. NoQ added reviewers: george.karpenkov, rsmith. Herald added a subscriber: cfe-commits. This follows https://reviews.llvm.org/D51822 and https://reviews.llvm.org/D52113 to add a cheap way of obtaining a unique and relatively stable* numeric identifier for

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

george.karpenkov accepted this revision. george.karpenkov added inline comments. This revision is now accepted and ready to land. Comment at: lib/AST/DeclCXX.cpp:2249 +int64_t CXXCtorInitializer::getID(const ASTContext ) const { + Optional Out =

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

rsmith added a comment. Thank you, this is looking really good. Comment at: include/clang/Parse/Parser.h:2054 +case DeclSpecContext::DSC_template_param: +case DeclSpecContext::DSC_template_type_arg: +case DeclSpecContext::DSC_normal: Rakete

[PATCH] D54463: [CMake] Support cross-compiling with Fuchsia toolchain build

phosek created this revision. phosek added reviewers: beanz, mcgrathr. Herald added subscribers: cfe-commits, mgorny. When second stage is being cross-compiled for a different platform we need to build enough of first stage runtimes to get a working compiler. Repository: rC Clang

[PATCH] D54166: [AST] Store the string data in StringLiteral in a trailing array of chars

dblaikie added a comment. In https://reviews.llvm.org/D54166#1295730, @riccibruno wrote: > @dblaikie Thanks for looking at this patch ! > > I have a set of patches shrinking the other statements/expressions. > Can I add you to review some of these too ? Most of them consists of just > moving >

[PATCH] D54405: Record whether a AST Matcher constructs a Node

aaron.ballman added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

takuto.ikuta updated this revision to Diff 173810. takuto.ikuta marked an inline comment as done. takuto.ikuta added a comment. rebase Repository: rL LLVM https://reviews.llvm.org/D54426 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Clang.cpp

[clang-tools-extra] r346638 - [clangd] Fix compile on very old glibc

Author: sammccall Date: Mon Nov 12 00:17:49 2018 New Revision: 346638 URL: http://llvm.org/viewvc/llvm-project?rev=346638=rev Log: [clangd] Fix compile on very old glibc Modified: clang-tools-extra/trunk/clangd/Threading.cpp Modified: clang-tools-extra/trunk/clangd/Threading.cpp URL:

[PATCH] D54416: [GCOV] fix test after patch rL346642

calixte created this revision. calixte added a reviewer: marco-c. Herald added a subscriber: cfe-commits. Test is failing under windows, so fix it Repository: rC Clang https://reviews.llvm.org/D54416 Files: test/CodeGen/code-coverage-filter.c Index: test/CodeGen/code-coverage-filter.c

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:11 +// Pretend clang is installed beside the mock library that we provided. +// RUN: echo

[PATCH] D54269: Introduce shard storage to auto-index.

sammccall added inline comments. Comment at: clangd/index/Background.cpp:252 + +auto Hash = FilesToUpdate.lookup(Path); +// Put shards into storage for subsequent use. nit: i'd suggest doing the writes *after* updating the index, as the latter is

r346644 - [GCOV] fix test after patch rL346642

Author: calixte Date: Mon Nov 12 01:52:14 2018 New Revision: 346644 URL: http://llvm.org/viewvc/llvm-project?rev=346644=rev Log: [GCOV] fix test after patch rL346642 Summary: Test is failing under windows, so fix it. Should fix:

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:11 +// Pretend clang is installed beside the mock library that we provided. +// RUN: echo

[PATCH] D54416: [GCOV] fix test after patch rL346642

This revision was automatically updated to reflect the committed changes. Closed by commit rL346644: [GCOV] fix test after patch rL346642 (authored by calixte, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54416 Files:

[PATCH] D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'

alexfh added inline comments. Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:33-36 + anyOf(hasAncestor( +functionTemplateDecl(HasMatchingDependentDescendant)), +hasAncestor( +

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:11 +// Pretend clang is installed beside the mock library that we provided. +// RUN: echo

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov updated this revision to Diff 173630. ilya-biryukov added a comment. - Updated the test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54311 Files: test/clang-tidy/Inputs/mock-libcxx/include/c++/v1/mock_vector test/clang-tidy/clang-tidy-mac-libcxx.cpp

r346639 - clang-cl: Add documentation for /Zc:dllexportInlines-

Author: hans Date: Mon Nov 12 00:38:10 2018 New Revision: 346639 URL: http://llvm.org/viewvc/llvm-project?rev=346639=rev Log: clang-cl: Add documentation for /Zc:dllexportInlines- Differential revision: https://reviews.llvm.org/D54319 Modified: cfe/trunk/docs/UsersManual.rst

[PATCH] D54319: clang-cl: Add documentation for /Zc:dllexportInlines-

This revision was automatically updated to reflect the committed changes. Closed by commit rL346639: clang-cl: Add documentation for /Zc:dllexportInlines- (authored by hans, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

richardmembarth added a comment. There are external tools (e.g. hipacc ) that generate Clang AST. This AST uses `LangAS` annotations and emits incorrect memory space specifiers for CUDA when pretty-printed. Repository: rC Clang https://reviews.llvm.org/D54258

r346642 - [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

Author: calixte Date: Mon Nov 12 01:12:27 2018 New Revision: 346642 URL: http://llvm.org/viewvc/llvm-project?rev=346642=rev Log: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov Summary: These options are taking regex separated

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

This revision was automatically updated to reflect the committed changes. Closed by commit rC346642: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to… (authored by calixte, committed by ). Changed prior to commit: https://reviews.llvm.org/D52034?vs=173623=173627#toc

Re: r346491 - [clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with /fallback

Hmm, maybe I misunderstood your initial request for this. The current implementation does what the warnings says: If the compiler falls back to cl.exe, /Zc:dllexportInlines- will be ignored. This suggests to the user that it's a bad idea, but they can go ahead if they want to. It sounds like

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:252 + +auto Hash = FilesToUpdate.lookup(Path); +// Put shards into storage for subsequent use. sammccall wrote: > nit: i'd suggest doing the writes *after* updating the index, as the

Re: r346491 - [clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with /fallback

On Mon, Nov 12, 2018 at 4:58 AM Hans Wennborg wrote: > Hmm, maybe I misunderstood your initial request for this. > > The current implementation does what the warnings says: If the > compiler falls back to cl.exe, /Zc:dllexportInlines- will be ignored. > This suggests to the user that it's a bad

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

calixte updated this revision to Diff 173623. calixte added a comment. Forgot the ellipsis in the release notes. Repository: rC Clang https://reviews.llvm.org/D52034 Files: docs/ReleaseNotes.rst docs/UsersManual.rst include/clang/Driver/Options.td

[PATCH] D52273: [clangd] Initial implementation of expected types

ioeric added inline comments. Comment at: clangd/ExpectedTypes.cpp:27 +return llvm::None; + auto *VD = llvm::dyn_cast(R.Declaration); + if (!VD) maybe add a comment what `ValueDecl` covers roughly? E.g. functions, classes, variables etc.

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

calixte updated this revision to Diff 173622. calixte added a comment. Update ReleaseNotes Repository: rC Clang https://reviews.llvm.org/D52034 Files: docs/ReleaseNotes.rst docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov added a comment. In https://reviews.llvm.org/D52273#1294767, @malaperle wrote: > What is the goal for doing this without the AST? Is the goal to not have to > keep the AST and save memory? We don't have AST for index completions. Repository: rCTE Clang Tools Extra

[PATCH] D54253: [OpenCL][NFC] Improve test coverage of test/Index/opencl-types.cl

AlexeySachkov added a comment. If I understand correctly, not all extensions are available on non-x86 targets and some declarations are marked as `(invalid)` - that is the only difference I saw Repository: rC Clang https://reviews.llvm.org/D54253

[clang-tools-extra] r346648 - [clangd] Remember to serialize AnyScope in FuzzyFindRequest json.

Author: ioeric Date: Mon Nov 12 04:24:08 2018 New Revision: 346648 URL: http://llvm.org/viewvc/llvm-project?rev=346648=rev Log: [clangd] Remember to serialize AnyScope in FuzzyFindRequest json. Modified: clang-tools-extra/trunk/clangd/index/Index.cpp Modified:

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov updated this revision to Diff 173659. ilya-biryukov added a comment. - Check with a clang-tidy warning instead of a clang error Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54311 Files: test/clang-tidy/Inputs/mock-libcxx/include/c++/v1/mock_vector

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

MTC added a comment. I'm totally fine with this patch personally. However I am not familiar with this part, so can't give substantial help :). Comment at: lib/StaticAnalyzer/Core/CheckerRegistry.cpp:51 -/// Collects the checkers for the supplied \p opt option into \p

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

ilya-biryukov updated this revision to Diff 173660. ilya-biryukov added a comment. - Added a test with a compiler path relative to the working dir Repository: rC Clang https://reviews.llvm.org/D54310 Files: include/clang/Lex/HeaderSearchOptions.h

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen created this revision. sdesmalen added reviewers: ributzka, rjmccall, rnk, aaron.ballman. Herald added subscribers: arphaman, kristof.beyls, javed.absar. This is the Clang patch to complement the following LLVM patches: https://reviews.llvm.org/D51477

[PATCH] D54300: [clangd] Respect shouldIndexFile when collecting symbols.

hokein added inline comments. Comment at: clangd/index/SymbolCollector.cpp:217 +bool shouldIndexFile(const Decl& D, const SymbolCollector::Options , + llvm::DenseMap *FilesToIndexCache) { ioeric wrote: > nit: this is very easily confused

[PATCH] D52984: [analyzer] Checker reviewer's checklist

xazax.hun updated this revision to Diff 173654. xazax.hun added a comment. - Use the term `checker` instead of `check`. https://reviews.llvm.org/D52984 Files: www/analyzer/checker_dev_manual.html Index: www/analyzer/checker_dev_manual.html

r346652 - Make clang-based tools find libc++ on MacOS

Author: ibiryukov Date: Mon Nov 12 05:55:55 2018 New Revision: 346652 URL: http://llvm.org/viewvc/llvm-project?rev=346652=rev Log: Make clang-based tools find libc++ on MacOS Summary: When they read compiler args from compile_commands.json. This change allows to run clang-based tools, like

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1101 case CC_AAPCS: + case CC_AArch64VectorCall: return llvm::dwarf::DW_CC_LLVM_AAPCS; I wasn't really sure whether this requires a corresponding DW_CC_LLVM_AAVPCS record in LLVM,

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

This revision was automatically updated to reflect the committed changes. Closed by commit rL346652: Make clang-based tools find libc++ on MacOS (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54310 Files:

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE346653: Add a test checking clang-tidy can find libc++ on Mac (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D54311?vs=173659=173664#toc Repository: rCTE

[PATCH] D54404: Exclude matchers which can have multiple results

steveire added a comment. I acknowledge and share the future-proofing concern. We could possibly use something trait-based instead and put the trait beside the matcher definition in ASTMatchers.h, but that doesn't really solve the problem. It only moves the problem. Repository: rC Clang

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet added inline comments. Comment at: clangd/index/Background.h:39 + retrieveShard(llvm::StringRef ShardIdentifier, FileDigest Hash) const = 0; + virtual bool initialize(llvm::StringRef Directory) = 0; +}; sammccall wrote: > kadircet wrote: > > sammccall

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 173653. JonasToth added a comment. - Merge branch 'master' into check_const Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D54300: [clangd] Respect shouldIndexFile when collecting symbols.

hokein updated this revision to Diff 173662. hokein marked 3 inline comments as done. hokein added a comment. Update the patch based on offline discussion. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54300 Files: clangd/index/SymbolCollector.cpp

[PATCH] D54326: [AST] Pack CXXThrowExpr, CXXDefaultArgExpr and CXXDefaultInitExpr

riccibruno updated this revision to Diff 173652. Repository: rC Clang https://reviews.llvm.org/D54326 Files: include/clang/AST/ExprCXX.h include/clang/AST/Stmt.h lib/AST/ExprCXX.cpp lib/Serialization/ASTReaderStmt.cpp Index: lib/Serialization/ASTReaderStmt.cpp

[clang-tools-extra] r346653 - Add a test checking clang-tidy can find libc++ on Mac

Author: ibiryukov Date: Mon Nov 12 05:56:09 2018 New Revision: 346653 URL: http://llvm.org/viewvc/llvm-project?rev=346653=rev Log: Add a test checking clang-tidy can find libc++ on Mac Reviewers: sammccall, arphaman, EricWF Reviewed By: sammccall Subscribers: christof, cfe-commits

[PATCH] D54269: Introduce shard storage to auto-index.

sammccall added inline comments. Comment at: clangd/index/Background.cpp:252 + +auto Hash = FilesToUpdate.lookup(Path); +// Put shards into storage for subsequent use. kadircet wrote: > sammccall wrote: > > nit: i'd suggest doing the writes *after*

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

grimar updated this revision to Diff 173643. grimar retitled this revision from "[Clang] - Add -fdwarf-fission=split,single option." to "[Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option.". grimar edited the summary of this revision. grimar added a comment.

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov added a comment. @ioeric, thanks for the review round! Answering the most important comments, will shortly send changes to actually address the rest. Comment at: clangd/ExpectedTypes.cpp:40 + +llvm::Optional encodeType(ASTContext , QualType T) { +

[PATCH] D54402: Extract method to allow re-use

steveire added a comment. I think this commit is fine without tests. The new method remains internal to the file but follow-up commits add public interface and tests. I'll push the commits separately. I'll not be squashing them. Repository: rC Clang https://reviews.llvm.org/D54402

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

takuto.ikuta updated this revision to Diff 173670. takuto.ikuta added a comment. short diag Repository: rL LLVM https://reviews.llvm.org/D54426 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D54427: [clangd] Allow symbols from AnyScope in dexp.

hokein added inline comments. Comment at: clangd/index/dex/dexp/Dexp.cpp:55 FuzzyFindRequest Request; + Request.AnyScope = true; // Remove leading "::" qualifier as FuzzyFind doesn't need leading "::" ioeric wrote: > I don't think you would want AnyScope

[PATCH] D54427: [clangd] Allow symbols from AnyScope in dexp.

hokein updated this revision to Diff 173676. hokein marked 2 inline comments as done. hokein added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54427 Files: clangd/index/dex/dexp/Dexp.cpp Index: clangd/index/dex/dexp/Dexp.cpp

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL346665: [clang-tidy] new check: bugprone-too-small-loop-variable (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53974

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

JonasToth added a comment. Committed r346665. Thank you very much for the patch! Repository: rL LLVM https://reviews.llvm.org/D53974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54429: Creating standard shpinx documentation for Clang Static Analyzer

Szelethus added a subscriber: xazax.hun. Szelethus added a comment. I'll read through this as soon as possible, but a HUGE thank you for this. This is what the Static Analyzer desperately needed for years. This will trivialize documenting, so conversations about the inner workings of the

r346659 - Revert rL346644, rL346642: the added test test/CodeGen/code-coverage-filter.c is failing under windows

Author: calixte Date: Mon Nov 12 06:57:17 2018 New Revision: 346659 URL: http://llvm.org/viewvc/llvm-project?rev=346659=rev Log: Revert rL346644, rL346642: the added test test/CodeGen/code-coverage-filter.c is failing under windows Removed:

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D54426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54427: [clangd] Allow symbols from AnyScope in dexp.

ioeric added inline comments. Comment at: clangd/index/dex/dexp/Dexp.cpp:55 FuzzyFindRequest Request; + Request.AnyScope = true; // Remove leading "::" qualifier as FuzzyFind doesn't need leading "::" I don't think you would want AnyScope here. For

[clang-tools-extra] r346665 - [clang-tidy] new check: bugprone-too-small-loop-variable

Author: jonastoth Date: Mon Nov 12 08:01:39 2018 New Revision: 346665 URL: http://llvm.org/viewvc/llvm-project?rev=346665=rev Log: [clang-tidy] new check: bugprone-too-small-loop-variable The new checker searches for those for loops which has a loop variable with a "too small" type which means

[PATCH] D54407: Record the matcher type when storing a binding

steveire added a comment. In https://reviews.llvm.org/D54407#129, @sbenza wrote: > In https://reviews.llvm.org/D54407#1294934, @aaron.ballman wrote: > > > Adding @sbenza in case he has opinions on this approach. I think it's > > reasonable, but I also know that changes to the the AST

[PATCH] D52984: [analyzer] Checker reviewer's checklist

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Let's continue the conversation about coding standards somewhere else. Can you please mark inlines as done? https://reviews.llvm.org/D52984

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

jkorous created this revision. jkorous added reviewers: arphaman, sammccall. Herald added subscribers: cfe-commits, kadircet, dexonsmith, MaskRay, ioeric, ilya-biryukov, mgorny. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54428 Files: CMakeLists.txt Features.inc.in

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

hans added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:164 -def warn_drv_non_fallback_argument_clang_cl : Warning< - "option '%0' is ignored when /fallback happens">, - InGroup; +def

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a comment. Thanks for taking a look! ^-^ Comment at: lib/StaticAnalyzer/Core/CheckerRegistry.cpp:51 -/// Collects the checkers for the supplied \p opt option into \p collected. -static void collectCheckers(const CheckerRegistry::CheckerInfoList , -

[PATCH] D54427: [clangd] Allow symbols from AnyScope in dexp.

hokein created this revision. hokein added a reviewer: ioeric. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. We should allow symbols from any scope in dexp results, othewise `find StringRef` doesn't return any results (llvm::StringRef). Repository: rCTE Clang

[PATCH] D54407: Record the matcher type when storing a binding

sbenza added a comment. In https://reviews.llvm.org/D54407#1294934, @aaron.ballman wrote: > Adding @sbenza in case he has opinions on this approach. I think it's > reasonable, but I also know that changes to the the AST matcher internals > sometimes have unintended side effects with the

[clang-tools-extra] r346666 - [clangd] Allow symbols from AnyScope in dexp.

Author: hokein Date: Mon Nov 12 08:03:59 2018 New Revision: 34 URL: http://llvm.org/viewvc/llvm-project?rev=34=rev Log: [clangd] Allow symbols from AnyScope in dexp. Summary: We should allow symbols from any scope in dexp results, othewise `find StringRef` doesn't return any results

  1   2   3   >