r347658 - Derive builtin return type from its definition

Author: mantognini Date: Tue Nov 27 06:54:58 2018 New Revision: 347658 URL: http://llvm.org/viewvc/llvm-project?rev=347658=rev Log: Derive builtin return type from its definition Summary: Prior to this patch, OpenCL code such as the following would attempt to create a BranchInst with a non-bool

[PATCH] D54799: [clangd] textDocument/SymbolInfo method

jkorous added a comment. Going to split `SymbolID.h ` as a NFC commit per Alex's suggestion and land this. Thanks everyone! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54799/new/ https://reviews.llvm.org/D54799 ___ cfe-commits mailing

[PATCH] D52879: Derive builtin return type from its definition

This revision was automatically updated to reflect the committed changes. Closed by commit rC347658: Derive builtin return type from its definition (authored by mantognini, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52879/new/

[PATCH] D54817: [clangd] Put direct headers into srcs section.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Only really significant thing is I think the name "build graph" is confusing, and we should specifically mention includes. Rest is just nits to take or leave...

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

sammccall added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours},

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong updated this revision to Diff 175482. martong marked 5 inline comments as done. martong added a comment. - Address several minor review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53655/new/ https://reviews.llvm.org/D53655 Files:

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong marked 20 inline comments as done. martong added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:1169 +/// matches 'a'. +extern const internal::VariadicDynCastAllOfMatcher +indirectFieldDecl; aaron.ballman wrote: > Be sure to

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

sammccall added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours},

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh added a comment. Should this chapter be a separate page linked from index.md? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 ___ cfe-commits mailing

[PATCH] D53708: [ASTImporter] Add importer specific lookup

martong updated this revision to Diff 175495. martong marked 5 inline comments as done. martong added a comment. - Address Alexei's comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53708/new/ https://reviews.llvm.org/D53708 Files:

[PATCH] D53708: [ASTImporter] Add importer specific lookup

martong marked 18 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:7605 + +ASTImporter::ASTImporter(ASTImporterLookupTable *LookupTable, + ASTContext , FileManager , a_sidorin wrote: > It's

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

donat.nagy updated this revision to Diff 175502. donat.nagy added a comment. Remove braces, move if parent checking to ASTMatcher, other minor improvements Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54757/new/ https://reviews.llvm.org/D54757

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

donat.nagy marked 15 inline comments as done. donat.nagy added a comment. I will add tests for macro handling later. Comment at: clang-tidy/bugprone/BranchCloneCheck.cpp:71 +// Check whether this `if` is part of an `else if`: +if (const auto *IP = +

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

mikael marked an inline comment as done. mikael added inline comments. Comment at: lib/CodeGen/CGCall.cpp:4035 + V = Builder.CreatePointerBitCastOrAddrSpaceCast(V, DestTy); +} rjmccall wrote: > Always use the `performAddrSpaceConversion`

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours},

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

cameron.mcinally added a comment. Digressing a bit, but has anyone given thought to how this implementation will play out with libraries? When running with traps enabled, libraries must be compiled for trap-safety. E.g. optimizations on a lib's code could introduce a NaN or cause a trap that

[libclc] r347666 - r600: Remove empty OVERRIDES file

Author: jvesely Date: Tue Nov 27 08:01:16 2018 New Revision: 347666 URL: http://llvm.org/viewvc/llvm-project?rev=347666=rev Log: r600: Remove empty OVERRIDES file Signed-off-by: Jan Vesely Reviewer: Aaron Watry Removed: libclc/trunk/r600/lib/OVERRIDES Removed:

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:4035 + V = Builder.CreatePointerBitCastOrAddrSpaceCast(V, DestTy); +} mikael wrote: > rjmccall wrote: > > Always use the `performAddrSpaceConversion` target hook if there's a

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:50 + static const std::unordered_map> + InverseMap( hwright wrote: > hwright wrote: > > JonasToth wrote: > > > This variable is a little hard to read. Could you make

[PATCH] D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/readability-implicit-bool-conversion.rst:77-78 -- boolean expression/literal to integer, +- boolean expression/literal to integer (conversion from boolean to a single + bit bitfield is explicitly

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours},

[PATCH] D54817: [clangd] Put direct headers into srcs section.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347669: [clangd] Put direct headers into srcs section. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D54817?vs=175483=175486#toc Repository: rCTE Clang

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationRewriter.h:62 + +AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher, + DurationConversionFunction) { JonasToth wrote: > I think you can even make this an

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

sammccall added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours}, hwright

[PATCH] D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: docs/clang-tidy/checks/readability-implicit-bool-conversion.rst:77-78 -- boolean expression/literal to integer, +- boolean expression/literal to integer

[libclc] r347664 - configure: Add target specific asm rule.

Author: jvesely Date: Tue Nov 27 08:01:10 2018 New Revision: 347664 URL: http://llvm.org/viewvc/llvm-project?rev=347664=rev Log: configure: Add target specific asm rule. Run the file through target specific preprocessing stage. Signed-off-by: Jan Vesely Reviewer: Aaron Watry Modified:

[libclc] r347663 - configure: provide llvm_as helper variable

Author: jvesely Date: Tue Nov 27 08:01:01 2018 New Revision: 347663 URL: http://llvm.org/viewvc/llvm-project?rev=347663=rev Log: configure: provide llvm_as helper variable Signed-off-by: Jan Vesely Reviewer: Aaron Watry Modified: libclc/trunk/configure.py Modified:

[clang-tools-extra] r347669 - [clangd] Put direct headers into srcs section.

Author: kadircet Date: Tue Nov 27 08:08:53 2018 New Revision: 347669 URL: http://llvm.org/viewvc/llvm-project?rev=347669=rev Log: [clangd] Put direct headers into srcs section. Summary: Currently, there's no way of knowing about header files using compilation database, since it doesn't contain

[libclc] r347667 - Add cmake build system

Author: jvesely Date: Tue Nov 27 08:07:19 2018 New Revision: 347667 URL: http://llvm.org/viewvc/llvm-project?rev=347667=rev Log: Add cmake build system Add cmake support for CLC and ll asm language, the latter includes clang preprocessing stage. Add ctests to check for external function calls.

[libclc] r347668 - travis: Add cmake build

Author: jvesely Date: Tue Nov 27 08:07:21 2018 New Revision: 347668 URL: http://llvm.org/viewvc/llvm-project?rev=347668=rev Log: travis: Add cmake build Reviewer: Aaron Watry Signed-off-by: Jan Vesely Modified: libclc/trunk/.travis.yml Modified: libclc/trunk/.travis.yml URL:

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationRewriter.h:62 + +AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher, + DurationConversionFunction) { I think you can even make this an `AST_MATCHER(FunctionDecl,

[PATCH] D53280: [analyzer] Emit an error for invalid -analyzer-config inputs

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Overall looks good to me, some minor comments inline. Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:231 #define ANALYZER_OPTION(TYPE, NAME, CMDFLAG,

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

hwright added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours}, JonasToth

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

hwright updated this revision to Diff 175476. hwright marked 10 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54737/new/ https://reviews.llvm.org/D54737 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D52879: Derive builtin return type from its definition

riccibruno added a comment. I see plenty of `TheCall->setType` left in `Sema::CheckBuiltinFunctionCall` (`Builtin::BI__builtin_classify_type`, `Builtin::BI__builtin_constant_p`, `Builtin::BI__builtin_dump_struct` and so on...). Is there a reason for not removing them ? Repository: rC Clang

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet updated this revision to Diff 175483. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments. - Move digest and digestFile into SourceCode.h Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54817/new/

[PATCH] D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion

malcolm.parsons marked an inline comment as done. malcolm.parsons added inline comments. Comment at: docs/clang-tidy/checks/readability-implicit-bool-conversion.rst:77-78 -- boolean expression/literal to integer, +- boolean expression/literal to integer (conversion from

[libclc] r347665 - amdgcn: Consolidate atomic minmax helpers

Author: jvesely Date: Tue Nov 27 08:01:13 2018 New Revision: 347665 URL: http://llvm.org/viewvc/llvm-project?rev=347665=rev Log: amdgcn: Consolidate atomic minmax helpers Removes most overrides Signed-off-by: Jan Vesely Reviewer: Aaron Watry Removed: libclc/trunk/amdgcn/lib/OVERRIDES

[PATCH] D54952: [clangd] DO NOT SUBMIT. Draft interfaces for build system integration.

ilya-biryukov created this revision. ilya-biryukov added reviewers: klimek, sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. A proposal for the interface of the new build system integration. Similar to CompilationDatabase, but will provide more functionality and

[PATCH] D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rL347671: [clang-tidy] Ignore bool - single bit bitfield conversion in readability… (authored by malcolm.parsons, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

[PATCH] D53329: Generate DIFile with main program if source is not available

scott.linder added a comment. See https://reviews.llvm.org/D54953 for the Verifier work. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53329/new/ https://reviews.llvm.org/D53329 ___ cfe-commits mailing list

[clang-tools-extra] r347671 - [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion

Author: malcolm.parsons Date: Tue Nov 27 08:23:39 2018 New Revision: 347671 URL: http://llvm.org/viewvc/llvm-project?rev=347671=rev Log: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion Summary: There is no ambiguity / information loss in this

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

martong marked 2 inline comments as done. martong added inline comments. Comment at: lib/AST/ExternalASTMerger.cpp:154 ToContainer->setHasExternalLexicalStorage(); - ToContainer->setMustBuildLookupTable(); +

[PATCH] D54799: [clangd][WIP] textDocument/SymbolInfo method

jkorous updated this revision to Diff 175475. jkorous added a comment. Finished tests and fixed operator<<(SymbolDetails) for containerNames that aren't part of fully qualified name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54799/new/ https://reviews.llvm.org/D54799 Files:

[clang-tools-extra] r347674 - [clangd][NFC] Move SymbolID to a separate file

Author: jkorous Date: Tue Nov 27 08:40:34 2018 New Revision: 347674 URL: http://llvm.org/viewvc/llvm-project?rev=347674=rev Log: [clangd][NFC] Move SymbolID to a separate file Prerequisity for textDocument/SymbolInfo Differential Revision: https://reviews.llvm.org/D54799 Added:

[clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

Author: jkorous Date: Tue Nov 27 08:40:46 2018 New Revision: 347675 URL: http://llvm.org/viewvc/llvm-project?rev=347675=rev Log: [clangd] textDocument/SymbolInfo extension New method returning symbol info for given source position. Differential Revision: https://reviews.llvm.org/D54799

[PATCH] D54799: [clangd] textDocument/SymbolInfo method

This revision was automatically updated to reflect the committed changes. Closed by commit rL347674: [clangd][NFC] Move SymbolID to a separate file (authored by jkorous, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52879: Derive builtin return type from its definition

mantognini added a comment. In D52879#1309734 , @riccibruno wrote: > I see plenty of `TheCall->setType` left in `Sema::CheckBuiltinFunctionCall` > (`Builtin::BI__builtin_classify_type`, `Builtin::BI__builtin_constant_p`, >

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37813/new/ https://reviews.llvm.org/D37813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50147: clang-format: support external styles

Typz added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50147/new/ https://reviews.llvm.org/D50147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r347689 - Revert "[RISCV] Mark unit tests as "requires: riscv-registered-target""

Author: mgrang Date: Tue Nov 27 11:13:52 2018 New Revision: 347689 URL: http://llvm.org/viewvc/llvm-project?rev=347689=rev Log: Revert "[RISCV] Mark unit tests as "requires: riscv-registered-target"" This reverts commit 1a6a0c9ea2716378d55858c11adf5941608531f8. Added:

r347688 - [RISCV] Mark unit tests as "requires: riscv-registered-target"

Author: mgrang Date: Tue Nov 27 11:13:13 2018 New Revision: 347688 URL: http://llvm.org/viewvc/llvm-project?rev=347688=rev Log: [RISCV] Mark unit tests as "requires: riscv-registered-target" Summary: Some of these tests break if the RISCV backend has not been built. Reviewers: asb, apazos,

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan marked an inline comment as done. leonardchan added a comment. In D53738#1309171 , @ebevhan wrote: > In D53738#1308314 , @leonardchan > wrote: > > > > Generally I think it's good! One final note; I

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. ping ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri updated this revision to Diff 175494. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. Address @rjmccall review notes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589 Files:

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

rjmccall added inline comments. Comment at: docs/ReleaseNotes.rst:310 + char **passthrough(__attribute__((align_value(1024))) char **x) { +return x; // <- check the + } unfinished Comment at:

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589 ___

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri added a comment. In D54589#1309929 , @rjmccall wrote: > LGTM. Thank you for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589

[PATCH] D53751: [ASTImporter] Added Import functions for transition to new API.

balazske updated this revision to Diff 175529. balazske added a comment. - Corrected Import_New(const Attr *) - Added missing Import_New with Selector and DeclarationName. - Split long lines. - Split long lines (ASTImporter.cpp). Rebase to newest master. Repository: rC Clang CHANGES SINCE

[PATCH] D54961: [AArch64] Add command-line option for SSBS

pbarrio created this revision. pbarrio added reviewers: olista01, samparker, aemerson. Herald added subscribers: kristof.beyls, javed.absar. SSBS (Speculative Store Bypass Safe) is only mandatory from 8.5 onwards but is optional from Armv8.0-A. This patch adds testing for the ssbs command line

[PATCH] D54923: [Modules] Remove non-determinism while serializing DECL_CONTEXT_LEXICAL and DECL_RECORD

bruno added a comment. Although we can't synthesize a testcase for inclusion in the patch. Here is how one should attempt to reproduce the problem in macOS 10.14. echo '@import Foundation;' > test.m clang -fmodules test.m -o test.o -c \ -fmodules-cache-path=/tmp/cache \

[PATCH] D54816: [RISCV] Mark unit tests as "requires: riscv-registered-target"

mgrang added a comment. Ping for reviews please. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54816/new/ https://reviews.llvm.org/D54816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54958: [OPENMP] remove redundant ColonExpected flag in ParseOpenMP.cpp - (NFC)

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54958/new/ https://reviews.llvm.org/D54958 ___ cfe-commits

[PATCH] D52578: Thread safety analysis: Allow scoped releasing of capabilities

pwnall added a comment. In D52578#1307145 , @aaronpuchert wrote: > To be clear, I'm not a big fan of this change myself, I just wanted to see if > it was feasible. My personal opinion, as I wrote in the bug report, is that > scoped releasing of mutexes

[PATCH] D54816: [RISCV] Mark unit tests as "requires: riscv-registered-target"

This revision was automatically updated to reflect the committed changes. Closed by commit rL347688: [RISCV] Mark unit tests as requires: riscv-registered-target (authored by mgrang, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder updated this revision to Diff 175540. scott.linder added a comment. Update documentation for new option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54489/new/ https://reviews.llvm.org/D54489 Files: docs/ClangCommandLineReference.rst

[PATCH] D54958: [OPENMP] remove redundant ColonExpected flag in ParseOpenMP.cpp - (NFC)

saghir created this revision. saghir added reviewers: ABataev, kkwli0, RaviNarayanaswamy, mikerice, Hahnfeld, hfinkel, gtbercea. saghir added a project: OpenMP. Herald added subscribers: cfe-commits, guansong. In ParseOpenMP.cpp: bool ColonExpected = false; ... ... ... else if (ColonExpected)

[PATCH] D53280: [analyzer] Emit an error for invalid -analyzer-config inputs

Szelethus added a comment. Thanks! I'll commit around friday (with the requested fixes) to leave enough time for everyone to object. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53280/new/ https://reviews.llvm.org/D53280

[PATCH] D50147: clang-format: support external styles

sammccall added a comment. In D50147#1309880 , @Typz wrote: > ping? Sorry for losing track of this. I think `-style=` is a logical extension of the current options. I'm less sure of supporting it in BasedOnStyle, but happy to go either way. Referring

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

This revision was automatically updated to reflect the committed changes. Closed by commit rC347677: Fix linker option for -fprofile-arcs -ftest-coverage (authored by marco, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54195/new/

r347677 - Fix linker option for -fprofile-arcs -ftest-coverage

Author: marco Date: Tue Nov 27 09:31:08 2018 New Revision: 347677 URL: http://llvm.org/viewvc/llvm-project?rev=347677=rev Log: Fix linker option for -fprofile-arcs -ftest-coverage Summary: Linux toolchain accidentally added "-u__llvm_runtime_variable" when "-fprofile-arcs -ftest-coverage", this

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours},

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

hwright marked 12 inline comments as done. hwright added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours",

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

sammccall added a comment. In D54945#1309467 , @JonasToth wrote: > I like the overview, maybe a link to `clangd` here might help, as there is > currently a lot of effort of integrating `clang-tidy` into it. (@sammccall > WDYT?) This would be great!

r347676 - Revert "[clang] - Simplify tools::SplitDebugName."

Author: jonastoth Date: Tue Nov 27 09:28:38 2018 New Revision: 347676 URL: http://llvm.org/viewvc/llvm-project?rev=347676=rev Log: Revert "[clang] - Simplify tools::SplitDebugName." This reverts commit r347035 as it introduced assertion failures under certain conditions. More information can be

[PATCH] D54792: add -march=cascadelake support in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC347682: [X86] Add -march=cascadelake support in clang. (authored by ctopper, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54792/new/

r347682 - [X86] Add -march=cascadelake support in clang.

Author: ctopper Date: Tue Nov 27 10:05:14 2018 New Revision: 347682 URL: http://llvm.org/viewvc/llvm-project?rev=347682=rev Log: [X86] Add -march=cascadelake support in clang. This is skylake-avx512 with the addition of avx512vnni ISA. Patch by Jianping Chen Differential Revision:

[PATCH] D52879: Derive builtin return type from its definition

riccibruno added a comment. In D52879#1309856 , @mantognini wrote: > In D52879#1309734 , @riccibruno > wrote: > > > I see plenty of `TheCall->setType` left in `Sema::CheckBuiltinFunctionCall` > >

[PATCH] D53751: [ASTImporter] Added Import functions for transition to new API.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347685: [ASTImporter] Added Import functions for transition to new API. (authored by balazske, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

r347685 - [ASTImporter] Added Import functions for transition to new API.

Author: balazske Date: Tue Nov 27 10:36:31 2018 New Revision: 347685 URL: http://llvm.org/viewvc/llvm-project?rev=347685=rev Log: [ASTImporter] Added Import functions for transition to new API. Summary: These Import_New functions should be used in the ASTImporter, and the old Import functions

[PATCH] D54964: Add test about __builtin_constant_p

MaskRay created this revision. MaskRay added reviewers: rsmith, void, shafik. Herald added subscribers: cfe-commits, kristina. Repository: rC Clang https://reviews.llvm.org/D54964 Files: test/SemaCXX/constant-expression-cxx1y.cpp Index: test/SemaCXX/constant-expression-cxx1y.cpp

r347692 - Don't speculatively emit VTTs for classes unless we are able to correctly emit references to all the functions they will (directly or indirectly) reference.

Author: rsmith Date: Tue Nov 27 11:33:49 2018 New Revision: 347692 URL: http://llvm.org/viewvc/llvm-project?rev=347692=rev Log: Don't speculatively emit VTTs for classes unless we are able to correctly emit references to all the functions they will (directly or indirectly) reference. Summary:

[PATCH] D54768: Don't speculatively emit VTTs for classes unless we are able to correctly emit references to all the functions they will (directly or indirectly) reference.

This revision was automatically updated to reflect the committed changes. Closed by commit rC347692: Dont speculatively emit VTTs for classes unless we are able to correctly emit… (authored by rsmith, committed by ). Changed prior to commit: https://reviews.llvm.org/D54768?vs=174822=175545#toc

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

nickdesaulniers added a comment. Bump, this is still listed as a TODO in the Linux kernel that works around the issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38479/new/ https://reviews.llvm.org/D38479 ___ cfe-commits mailing list

[PATCH] D53100: clang: Add ARCTargetInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rC347699: [clang][ARC] Add ARCTargetInfo (authored by tkrasnukha, committed by ). Changed prior to commit: https://reviews.llvm.org/D53100?vs=175290=175549#toc Repository: rC Clang CHANGES SINCE LAST

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54489/new/ https://reviews.llvm.org/D54489 ___ cfe-commits mailing list

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete updated this revision to Diff 175553. Rakete added a comment. Rebase and friendly ping! :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: include/clang/Basic/DiagnosticSemaKinds.td

r347715 - [OPENMP][NVPTX]Basic support for reductions across the teams.

Author: abataev Date: Tue Nov 27 13:24:54 2018 New Revision: 347715 URL: http://llvm.org/viewvc/llvm-project?rev=347715=rev Log: [OPENMP][NVPTX]Basic support for reductions across the teams. Added basic codegen support for the reductions across the teams. Modified:

[PATCH] D54970: [OpenMP] Add a new version of the SPMD deinit kernel function

gtbercea updated this revision to Diff 175573. gtbercea added a comment. Add constant values to function calls. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54970/new/ https://reviews.llvm.org/D54970 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:4241 + if (SemaRef.getLangOpts().OpenCL && T.getType()->isTemplateTypeParmType()) +Quals.removeAddressSpace(); + rjmccall wrote: > When do you

r347701 - [clang][slh] add attribute for speculative load hardening

Author: zbrid Date: Tue Nov 27 11:56:46 2018 New Revision: 347701 URL: http://llvm.org/viewvc/llvm-project?rev=347701=rev Log: [clang][slh] add attribute for speculative load hardening Summary: Resubmit this with no changes because I think the build was broken by a different diff. - The

[PATCH] D54816: [RISCV] Mark unit tests as "requires: riscv-registered-target"

asb added a comment. I'm a bit confused - what in these tests requires that lib/Target/RISCV was built? These tests obviously don't fail on the standard builders for instance. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54816/new/

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added a comment. Alright, will patch it into my fork in a bit and try it out, if everything looks good, I'll land the stack. (Again huge sorry about this taking some time, have lots on my hands at the moment) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D53751: [ASTImporter] Added Import functions for transition to new API.

aaron.ballman added a comment. In D53751#1301551 , @shafik wrote: > I think these changes make sense at a high level but I am not sure about the > refactoring strategy. I am especially concerned we may end up in place where > all the effected users of

r347705 - [clang][ARC] Fix test for commit r347699

Author: tkrasnukha Date: Tue Nov 27 12:56:30 2018 New Revision: 347705 URL: http://llvm.org/viewvc/llvm-project?rev=347705=rev Log: [clang][ARC] Fix test for commit r347699 Modified: cfe/trunk/test/CodeGen/arc/arguments.c Modified: cfe/trunk/test/CodeGen/arc/arguments.c URL:

[PATCH] D54970: [OpenMP] Add a new version of the SPMD deinit kernel function

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. gtbercea added a parent revision: D54969: [OpenMP][libomptarget] Add new version of SPMD deinit kernel function with argument. This patch adds a new runtime

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

aaron.ballman accepted this revision. aaron.ballman added a comment. This seems mostly reasonable to me, but @rsmith is more well-versed in this area and may have further comments. You should give him a few days to chime in before committing. Comment at:

r347699 - [clang][ARC] Add ARCTargetInfo

Author: tkrasnukha Date: Tue Nov 27 11:52:10 2018 New Revision: 347699 URL: http://llvm.org/viewvc/llvm-project?rev=347699=rev Log: [clang][ARC] Add ARCTargetInfo Based-on-patch-by: Pete Couperus Differential Revision: https://reviews.llvm.org/D53100 Added:

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

Anastasia added inline comments. Comment at: lib/CodeGen/CGCall.cpp:80 +// used with the same version of generated operators. +RecTy = Context.getAddrSpaceQualType(RecTy, LangAS::opencl_generic); + rjmccall wrote: > Anastasia wrote: > > rjmccall wrote: >

[PATCH] D54970: [OpenMP] Add a new version of the SPMD deinit kernel function

ABataev added inline comments. Comment at: test/OpenMP/nvptx_target_parallel_codegen.cpp:71 // CHECK: [[DONE]] - // CHECK: call void @__kmpc_spmd_kernel_deinit() + // CHECK: call void @__kmpc_spmd_kernel_deinit_v2( // CHECK: br label {{%?}}[[EXIT:.+]]

  1   2   >