[PATCH] D56555: Add Attribute to define nonlazy objc classes

rjmccall added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3506 +add the class to the list of non-lazily initialized classes. These are classes +that are realized at objc_init() time rather than when first referenced. + }]; aaron.ballman

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman added a reviewer: majnemer. aaron.ballman added a subscriber: majnemer. aaron.ballman added inline comments. Comment at: test/Sema/dllexport.c:70 +// const variables +__declspec(dllexport) int const x = 3; zahiraam wrote: > aaron.ballman wrote: >

[PATCH] D57509: [clangd] Append "(fix available)" to diagnostic message when fixes are present.

ilya-biryukov added a comment. > I don't think it's pure noise. Vscode displays diagnostics in the "PROBLEMS" > tab. A suffix allows you to tell whether fixes are available without hovering > on the errors. And it shows bulb icons when you hover over diagnostics in this dialog too. To be

[PATCH] D57527: Do not copy floating pointer format from aux target

rjmccall added a comment. Okay, so you silently have an incompatible ABI for anything in the system headers that mentions `long double`. Do you have any plans to address or work around that, or is the hope that it just doesn't matter? I feel like this should be a special case for AMDGPU

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov added a comment. I'm not sure who the owners of c-index-test are, so adding people who touched the file recently or might be interested in this landing. Suggestions for other reviewers are **very** welcome. Still struggling to make one test pass: `Index/index-file.cu` fails with:

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTDumpTraverser.h:31 + +ASTDumpTraverser traverses the Clang AST for dumping purposes + Missing full stop at the end of the sentence. Comment at:

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

arphaman requested changes to this revision. arphaman added a comment. This revision now requires changes to proceed. Do you know if this have an effect on the output of completion results or other tooling-based output? A couple of requests: - This behavior should be controlled by a printing

Re: r352793 - [WebAssembly] Add bulk memory target feature

And another review that omitted lists. On Fri, Feb 1, 2019 at 12:02 AM Thomas Lively via cfe-commits wrote: > > Author: tlively > Date: Thu Jan 31 13:02:19 2019 > New Revision: 352793 > > URL: http://llvm.org/viewvc/llvm-project?rev=352793=rev > Log: > [WebAssembly] Add bulk memory target

[PATCH] D57488: [CUDA] add support for the new kernel launch API in CUDA-9.2+.

This revision was automatically updated to reflect the committed changes. Closed by commit rC352799: [CUDA] add support for the new kernel launch API in CUDA-9.2+. (authored by tra, committed by ). Changed prior to commit: https://reviews.llvm.org/D57488?vs=184592=184598#toc Repository: rC

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

sgraenitz added a comment. In case compiler-rt abandons `llvm-config` in favor of `find_package(LLVM)` one day, we could drop the `COMPILER_RT_HAS_LLVMTESTINGSUPPORT` logic here and use imported target properties instead. It seems a cleaner solution to me and avoids issues like D57521

[PATCH] D57488: [CUDA] add support for the new kernel launch API in CUDA-9.2+.

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:239 +CGM.Error(CGF.CurFuncDecl->getLocation(), + "Can't find declaration for cudaLaunchKernel()"); // FIXME. +return; jlebar wrote: > Unfixed FIXME? Fixed the comment. :-)

[PATCH] D57509: [clangd] Append "(fix available)" to diagnostic message when fixes are present.

sammccall added a comment. FWIW, I don't think this is worth adding an option or protocol extensions for at this point. There are pros and cons to showing this in VSCode (pros are visibility without hovering, particularly in problems view and cross-editor consistency, cons are certainly noise

[PATCH] D57509: [clangd] Append "(fix available)" to diagnostic message when fixes are present.

ioeric added a subscriber: hokein. ioeric added a comment. In D57509#1378978 , @ilya-biryukov wrote: > In D57509#1378943 , @ioeric wrote: > > > Yes, but a new option seems a bit of an overkill here. The text is

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov created this revision. ilya-biryukov added reviewers: thakis, ioeric. Herald added a reviewer: EricWF. Herald added subscribers: llvm-commits, arphaman. Herald added a project: clang. Specifically, the version of libc++ that lives alongside the c-index-test binary. After r348365

[PATCH] D57527: Do not copy long double and 128-bit fp format from aux target for AMDGPU

yaxunl updated this revision to Diff 184569. yaxunl retitled this revision from "Do not copy floating pointer format from aux target" to "Do not copy long double and 128-bit fp format from aux target for AMDGPU". yaxunl edited the summary of this revision. yaxunl added a comment. Herald added

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

arphaman added a comment. Yes, that should work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r352793 - [WebAssembly] Add bulk memory target feature

Author: tlively Date: Thu Jan 31 13:02:19 2019 New Revision: 352793 URL: http://llvm.org/viewvc/llvm-project?rev=352793=rev Log: [WebAssembly] Add bulk memory target feature Summary: Also clean up some preexisting target feature code. Reviewers: aheejin Subscribers: dschuff, sbc100,

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345 ___ cfe-commits mailing list

[PATCH] D57527: Do not copy long double and 128-bit fp format from aux target for AMDGPU

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC352801: Do not copy long double and 128-bit fp format from aux target for AMDGPU (authored by yaxunl, committed by ).

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a commenting request. Comment at: test/clang-tidy/google-objc-function-naming.m:5-8 +static void TestImplicitlyDefinedFunction(int a) { +

[PATCH] D57527: Do not copy floating pointer format from aux target

yaxunl added a comment. In D57527#1379065 , @rjmccall wrote: > Okay, so you silently have an incompatible ABI for anything in the system > headers that mentions `long double`. Do you have any plans to address or > work around that, or is the hope that

[PATCH] D57527: Do not copy long double and 128-bit fp format from aux target for AMDGPU

yaxunl added a comment. In D57527#1379159 , @rjmccall wrote: > In D57527#1379088 , @yaxunl wrote: > > > In D57527#1379065 , @rjmccall > > wrote: > > > > > Okay, so you

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I think let's get this up and running and slowly redirect links from the front page to the new docs until only the front page is left? Comment at:

[PATCH] D57315: [opaque pointer types] Add a FunctionCallee wrapper type, and use it.

This revision was automatically updated to reflect the committed changes. Closed by commit rC352791: [opaque pointer types] Add a FunctionCallee wrapper type, and use it. (authored by jyknight, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:7033 + // member of an ObjC pointer type, except when it has an in-class initializer, + // it doesn't make the defaulted default constructor defined as deleted. + if (!FieldType.hasNonTrivialObjCLifetime()

[PATCH] D57540: [C++17] Don't crash while diagnosing different access specifier of a deduction guide.

Rakete created this revision. Rakete added a reviewer: rsmith. This fixes PR40552 by not showing the diagnostic that complains about different access specifiers, since the template does not have one. Repository: rC Clang https://reviews.llvm.org/D57540 Files:

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

arphaman requested changes to this revision. arphaman added a comment. This revision now requires changes to proceed. The real problem is that `clang_parseTranslationUnit2` is broken, so this just fixes one client, `c-index-test`. All other macOS clients that call that function will still be

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

sammccall added inline comments. Comment at: clangd/IncludeFixer.cpp:74 +break; + default: +assert(RecordTypo); "default" looks a bit scary - could still end up with false positives. Can we cover a few of the most common cases (even if we know they're

[PATCH] D57509: [clangd] Append "(fix available)" to diagnostic message when fixes are present.

ioeric added a comment. In D57509#1378928 , @ilya-biryukov wrote: > Could this be made optional for VSCode? > As mentioned in the discussion before, I would personally prefer to turn it > off, even though I do acknowledge the need for this for some

[PATCH] D57507: [clang] Add getCommentHandler to PreambleCallbacks

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, just a few nits Comment at: include/clang/Frontend/PrecompiledPreamble.h:286 virtual std::unique_ptr createPPCallbacks(); + /// Adds the returned

[PATCH] D57509: [clangd] Append "(fix available)" to diagnostic message when fixes are present.

ilya-biryukov added a comment. In D57509#1378943 , @ioeric wrote: > Yes, but a new option seems a bit of an overkill here. The text is appended > and doesn't seem to affect the readability of original diagnostic message > much (IMO). Could you

[PATCH] D57527: Do not copy floating pointer format from aux target

rjmccall added a comment. In D57527#1379088 , @yaxunl wrote: > In D57527#1379065 , @rjmccall wrote: > > > Okay, so you silently have an incompatible ABI for anything in the system > > headers that mentions `long

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.h:63 +/// Turns a token range into a half-open range and checks its correctness. +/// The resulting range will have only valid source location on both sides, both sammccall

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 184588. ilya-biryukov marked 8 inline comments as done. ilya-biryukov added a comment. Herald added a project: clang. Herald added a subscriber: llvm-commits. - Remove Dummy.cpp - Add halfOpenRangeTouches - Add a comment about file vs expansion

[PATCH] D57487: [CUDA] Propagate detected version of CUDA to cc1

This revision was automatically updated to reflect the committed changes. Closed by commit rL352798: [CUDA] Propagate detected version of CUDA to cc1 (authored by tra, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r352798 - [CUDA] Propagate detected version of CUDA to cc1

Author: tra Date: Thu Jan 31 13:32:24 2019 New Revision: 352798 URL: http://llvm.org/viewvc/llvm-project?rev=352798=rev Log: [CUDA] Propagate detected version of CUDA to cc1 ..and use it to control that parts of CUDA compilation that depend on the specific version of CUDA SDK. This patch has a

[PATCH] D57528: [tools] Fix python DeprecationWarning: invalid escape sequence

MarcoFalke created this revision. Herald added subscribers: cfe-commits, whisperity. Herald added a reviewer: serge-sans-paille. The python documentation says "it’s highly recommended that you use raw strings for all but the simplest expressions." (https://docs.python.org/3/library/re.html) So

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

stephanemoore marked 3 inline comments as done. stephanemoore added a comment. Thanks for the review! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57207/new/ https://reviews.llvm.org/D57207 ___

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

stephanemoore updated this revision to Diff 184553. stephanemoore marked an inline comment as done. stephanemoore added a comment. Add comment explaining that builtin function call generates implicit function declaration and update calling function name for improved clarity. Repository: rCTE

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Basic/SourceManager.h:1466 +// its spelling is the scratch memory, so we take the parent context. +

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis updated this revision to Diff 184593. thakis edited the summary of this revision. thakis added a comment. shared function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345 Files: clang/include/clang/Driver/Driver.h

r352799 - [CUDA] add support for the new kernel launch API in CUDA-9.2+.

Author: tra Date: Thu Jan 31 13:34:03 2019 New Revision: 352799 URL: http://llvm.org/viewvc/llvm-project?rev=352799=rev Log: [CUDA] add support for the new kernel launch API in CUDA-9.2+. Instead of calling CUDA runtime to arrange function arguments, the new API constructs arguments in a local

r352800 - Revert "[opaque pointer types] Add a FunctionCallee wrapper type, and use it."

Author: jyknight Date: Thu Jan 31 13:51:58 2019 New Revision: 352800 URL: http://llvm.org/viewvc/llvm-project?rev=352800=rev Log: Revert "[opaque pointer types] Add a FunctionCallee wrapper type, and use it." This reverts commit f47d6b38c7a61d50db4566b02719de05492dcef1 (r352791). Seems to run

[PATCH] D57509: [clangd] Append "(fix available)" to diagnostic message when fixes are present.

ilya-biryukov added a comment. Could this be made optional for VSCode? As mentioned in the discussion before, I would personally prefer to turn it off, even though I do acknowledge the need for this for some clients, e.g. vim. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D57488: [CUDA] add support for the new kernel launch API in CUDA-9.2+.

tra updated this revision to Diff 184543. tra marked 8 inline comments as done. tra edited the summary of this revision. tra added a comment. Addressed Justin's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57488/new/ https://reviews.llvm.org/D57488 Files:

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Makes sense. The comments aren't really enforceable though, can we just factor this out into one function in lib/Basic that can be shared between all sites? It seems like there's nothing

[PATCH] D57524: Fix ICE on attempt to add an addr space qual to a type qualified by an addr space

rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:4693 +T2Quals.addAddressSpace(AS2); + QualType WithAScv1T4 = S.Context.getQualifiedType(IgnoreAScv2T2, T1Quals); + Sequence.AddQualificationConversionStep(WithAScv1T4, ValueKind);

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, + clang::ast_matchers::internal::Matcher,

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis added a comment. Could it be somewhere in lib/Driver? libclang depends on lib/Frontend which depends on lib/Driver -- is there any reason libclang can't depend on lib/Driver? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345

r352791 - [opaque pointer types] Add a FunctionCallee wrapper type, and use it.

Author: jyknight Date: Thu Jan 31 12:35:56 2019 New Revision: 352791 URL: http://llvm.org/viewvc/llvm-project?rev=352791=rev Log: [opaque pointer types] Add a FunctionCallee wrapper type, and use it. The FunctionCallee type is effectively a {FunctionType*,Value*} pair, and is a useful

[PATCH] D57488: [CUDA] add support for the new kernel launch API in CUDA-9.2+.

tra updated this revision to Diff 184592. tra added a comment. Updated ASTMatchers unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57488/new/ https://reviews.llvm.org/D57488 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h

r352801 - Do not copy long double and 128-bit fp format from aux target for AMDGPU

Author: yaxunl Date: Thu Jan 31 13:57:51 2019 New Revision: 352801 URL: http://llvm.org/viewvc/llvm-project?rev=352801=rev Log: Do not copy long double and 128-bit fp format from aux target for AMDGPU rC352620 caused regressions because it copied floating point format from aux target. floating

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

Would it be better if we disallowed trivial_abi if the class’ copy and move destructors were all deleted (and revert r350920)? I think that would make it easier to reason about when you are allowed to use trivial_abi and what effect the attribute has (which is to override the trivialness for

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

morehouse added inline comments. Comment at: docs/SanitizerCoverage.rst:149 +(``-Wl,-gc-sections``), thus resulting in a significant binary size overhead. +See `Bug 34636 `_ for more info. + Maybe add "for linkers

[PATCH] D57527: Do not copy floating pointer format from aux target

yaxunl created this revision. yaxunl added a reviewer: rjmccall. rC352620 caused regressions because it copied floating point format from aux target. floating point format decides whether extended long double is supported. It is x86_fp80 on x86 but IEEE

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1300 + void setStmtExpr(Stmt *S) { +assert(!body_empty() && "setStmtExpr"); +unsigned ExprResult = getLastNonNullStmt(); domdom wrote: > getLastNonNullStmt asserts anyway,

r352788 - [CodeComplete] Propagate preferred types through parser in more cases

Author: ibiryukov Date: Thu Jan 31 12:20:32 2019 New Revision: 352788 URL: http://llvm.org/viewvc/llvm-project?rev=352788=rev Log: [CodeComplete] Propagate preferred types through parser in more cases Preferred types are used by code completion for ranking. This commit considerably increases the

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

This revision was automatically updated to reflect the committed changes. Closed by commit rC352788: [CodeComplete] Propagate preferred types through parser in more cases (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D56723?vs=184038=184568#toc

[PATCH] D57527: Do not copy long double and 128-bit fp format from aux target for AMDGPU

rjmccall added a comment. Explanatory comment, please. Otherwise LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57527/new/ https://reviews.llvm.org/D57527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57527: Do not copy long double and 128-bit fp format from aux target for AMDGPU

yaxunl added a comment. In D57527#1379287 , @rjmccall wrote: > Explanatory comment, please. Otherwise LGTM. will do when committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57527/new/ https://reviews.llvm.org/D57527

[clang-tools-extra] r352796 - [clangd] A code action to swap branches of an if statement

Author: ibiryukov Date: Thu Jan 31 13:30:05 2019 New Revision: 352796 URL: http://llvm.org/viewvc/llvm-project?rev=352796=rev Log: [clangd] A code action to swap branches of an if statement Reviewers: sammccall Reviewed By: sammccall Subscribers: llvm-commits, mgorny, ioeric, MaskRay, jkorous,

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

This revision was automatically updated to reflect the committed changes. Closed by commit rL352796: [clangd] A code action to swap branches of an if statement (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D56611?vs=184588=184594#toc Repository:

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

thakis added a comment. Looking at D54630 , it seems arphaman and dexonsmith are probalby good reviewers for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444 case BO_NE: +return Builder.CreateICmpNE(FullLHS, FullRHS); + case BO_Mul: Are padding bits guaranteed zero or unspecified? Or are we just not really supporting padding

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On 31 Jan 2019, at 16:57, Akira Hatanaka wrote: Would it be better if we disallowed trivial_abi if the class’ copy and move destructors were all deleted (and revert r350920)? I think that would make it easier to reason about when you are allowed to use trivial_abi and what effect the

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

Just wanted to point out that r350920 is on the 8.0 release branch as well. I don't know if there are any additional considerations there. On 1/31/19, 2:20 PM, "cfe-commits on behalf of John McCall via cfe-commits" wrote: On 31 Jan 2019, at 16:57, Akira Hatanaka wrote:

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan updated this revision to Diff 184612. leonardchan marked 3 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57219/new/ https://reviews.llvm.org/D57219 Files: clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444 case BO_NE: +return Builder.CreateICmpNE(FullLHS, FullRHS); + case BO_Mul: rjmccall wrote: > Are padding bits guaranteed zero or unspecified? Or are we just not

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

justice_adams added a comment. @stella.stamenova @thakis Thanks for the feedback all, I will go ahead and make this change to the way I'm representing directories, open a new diff for review, and add you as a reviewer. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57521/new/ https://reviews.llvm.org/D57521 ___

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

This revision was automatically updated to reflect the committed changes. Closed by commit rL352803: Make clang/test/Index/pch-from-libclang.c pass in more places (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r352803 - Make clang/test/Index/pch-from-libclang.c pass in more places

Author: nico Date: Thu Jan 31 14:15:32 2019 New Revision: 352803 URL: http://llvm.org/viewvc/llvm-project?rev=352803=rev Log: Make clang/test/Index/pch-from-libclang.c pass in more places - fixes the test on macOS with LLVM_ENABLE_PIC=OFF - together with D57343, gets the test to pass on Windows

[PATCH] D57553: [Fixed Point Arithmetic] Check against source value when converting during saturation

leonardchan created this revision. leonardchan added reviewers: rjmccall, ebevhan, bjope. leonardchan added a project: clang. When converting to a saturating fixed point type, compare against the source value instead of our container value. This allows us to not create a container, and save up

Re: r351629 - Emit !callback metadata and introduce the callback attribute

Thanks for the clarifications. I'll fix all mentioned points asap. From: Eli Friedman Sent: Thursday, January 31, 2019 18:17 To: Doerfert, Johannes; Chandler Carruth; cfe-commits@lists.llvm.org Cc: Raja Venkateswaran Subject: RE: r351629 - Emit !callback metadata

r352824 - [analyzer] [RetainCountChecker] Fix object type for CF/Obj-C bridged casts

Author: george.karpenkov Date: Thu Jan 31 18:13:02 2019 New Revision: 352824 URL: http://llvm.org/viewvc/llvm-project?rev=352824=rev Log: [analyzer] [RetainCountChecker] Fix object type for CF/Obj-C bridged casts Having an incorrect type for a cast causes the checker to incorrectly dismiss the

r352827 - [opaque pointer types] Add a FunctionCallee wrapper type, and use it.

Author: jyknight Date: Thu Jan 31 18:28:03 2019 New Revision: 352827 URL: http://llvm.org/viewvc/llvm-project?rev=352827=rev Log: [opaque pointer types] Add a FunctionCallee wrapper type, and use it. Recommit r352791 after tweaking DerivedTypes.h slightly, so that gcc doesn't choke on it,

[PATCH] D57502: [ASTDump] Make template specialization tests more exact

This revision was automatically updated to reflect the committed changes. Closed by commit rL352804: [ASTDump] Make template specialization tests more exact (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

r352804 - [ASTDump] Make template specialization tests more exact

Author: steveire Date: Thu Jan 31 14:28:38 2019 New Revision: 352804 URL: http://llvm.org/viewvc/llvm-project?rev=352804=rev Log: [ASTDump] Make template specialization tests more exact Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D57502

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumpTraverser.h:83 + + NodeVisitorType () { return getDerived().doGetNodeVisitor(); } + Derived () { return *static_cast(this); } aaron.ballman wrote: >

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

Given that there's uncertainty as to how to proceed and this patch affects the ABI, I would prefer that we revert it for trunk and 8.0. The suggested alternative of disallowing trivial_abi in the case where all copy/move constructors are deleted seems reasonable to me. On Thu, 31 Jan 2019 at

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444 case BO_NE: +return Builder.CreateICmpNE(FullLHS, FullRHS); + case BO_Mul: leonardchan wrote: > rjmccall wrote: > > Are padding bits guaranteed zero or unspecified? Or

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_conversions.c:437 + // DEFAULT-NEXT: [[RES:%[a-z0-9]+]] = trunc i39 [[SATMIN]] to i16 + // DEFAULT-NEXT: store i16 [[RES]], i16* %sat_sa, align 2 +

RE: r351629 - Emit !callback metadata and introduce the callback attribute

(Comments inline.) > -Original Message- > From: cfe-commits On Behalf Of > Doerfert, Johannes Rudolf via cfe-commits > Sent: Tuesday, January 22, 2019 9:29 AM > To: Chandler Carruth > Cc: cfe-commits cfe > Subject: Re: r351629 - Emit !callback metadata and introduce the callback >

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

nridge added a comment. Herald added a project: LLVM. This commit is causing clangd to fail to link, with errors like this: tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTweaks.dir/SwapIfBranches.cpp.o:SwapIfBranches.cpp:function

Re: [PATCH] D56611: [clangd] A code action to swap branches of an if statement

Thanks! I suspect shared libraries makes a difference here, because the tweaks use an unusual library type (object library) to force linking. On Fri, Feb 1, 2019 at 3:01 AM Nathan Ridge via Phabricator < revi...@reviews.llvm.org> wrote: > nridge added a comment. > > Fix here:

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

ahatanak updated this revision to Diff 184665. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57438/new/ https://reviews.llvm.org/D57438 Files:

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

ahatanak added inline comments. Comment at: test/SemaObjCXX/arc-0x.mm:164 +union { + union { // expected-note 2 {{'S1' is implicitly deleted because variant field '' has a non-trivial}} expected-note 4 {{'S1' is implicitly deleted because field '' has a deleted}} +

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

beanz added a reviewer: phosek. beanz added a subscriber: phosek. beanz added a comment. Herald added a project: clang. @phosek, does LLVM’s runtime directory do this correctly? At some point we should try and deprecate and remove this option in favor of the LLVM directory because the LLVM

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

sammccall added a comment. In D56611#1379785 , @nridge wrote: > This commit is causing clangd to fail to link, with errors like this: > > >

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

nridge added a comment. The complete commands that's failing is: /usr/bin/clang++-8 -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic

r352809 - Re-disable pch-from-libclang.c after 352803, some buildbots are still unhappy

Author: nico Date: Thu Jan 31 14:57:52 2019 New Revision: 352809 URL: http://llvm.org/viewvc/llvm-project?rev=352809=rev Log: Re-disable pch-from-libclang.c after 352803, some buildbots are still unhappy Modified: cfe/trunk/test/Index/pch-from-libclang.c Modified:

Re: r352690 - [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

Thank you, Eric, for the reproducer and instructions. Actionable and much appreciated.Can you test my updated patch on your build before I try again? updated_patch.patch Description: Binary data delta.diff Description: Binary data On Jan 31, 2019, at 6:19 AM, Eric Liu

r352822 - Revert "[Sema] Make canPassInRegisters return true if the CXXRecordDecl passed"

Author: ahatanak Date: Thu Jan 31 16:12:06 2019 New Revision: 352822 URL: http://llvm.org/viewvc/llvm-project?rev=352822=rev Log: Revert "[Sema] Make canPassInRegisters return true if the CXXRecordDecl passed" This reverts commit r350920 as it is not clear whether we should force a class to be

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

+Hans for managing the 8.0 branch. On 1/31/19, 4:15 PM, "ahatan...@apple.com on behalf of Akira Hatanaka" wrote: Reverted patch in r352822. I’ll send a new patch later that disallows trivial_abi on classes without non-deleted copy or move constructors. > On Jan 31, 2019, at 3:52

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

sbc100 added a comment. Herald added a project: LLVM. I think this broke the BUILD_SHARED_LIBS build: https://reviews.llvm.org/D57556 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345

[PATCH] D57032: [SemaCXX] Param diagnostic matches overload logic

modocache marked an inline comment as done. modocache added a comment. Herald added a project: clang. Friendly ping! Is there anything I can do to improve this patch? I think it's a clear improvement of the diagnostic, with a test case to boot! Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

NoQ added a comment. P.S. I also support the idea to have a separate page per checker. It encourages people to write as much documentation as necessary and continously expand it. Otherwise there's a perception that all docs need to be roughly of the same size and shape in order to make the

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire updated this revision to Diff 184616. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57472/new/ https://reviews.llvm.org/D57472 Files: include/clang/AST/ASTDumpTraverser.h lib/AST/ASTDumper.cpp Index:

r352818 - [sanitizer-coverage] prune trace-cmp instrumentation for CMP isntructions that feed into the backedge branch. Instrumenting these CMP instructions is almost always useless (and harmful) for

Author: kcc Date: Thu Jan 31 15:43:00 2019 New Revision: 352818 URL: http://llvm.org/viewvc/llvm-project?rev=352818=rev Log: [sanitizer-coverage] prune trace-cmp instrumentation for CMP isntructions that feed into the backedge branch. Instrumenting these CMP instructions is almost always

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

Reverted patch in r352822. I’ll send a new patch later that disallows trivial_abi on classes without non-deleted copy or move constructors. > On Jan 31, 2019, at 3:52 PM, Richard Smith wrote: > > Given that there's uncertainty as to how to proceed and this patch > affects the ABI, I would

  1   2   >