[PATCH] D60179: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC

ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Instead of tooling::Replacement. To avoid the need to have contents of the file at the caller site. This

[PATCH] D60183: Fix typos in tests. NFC.

Higuoxing created this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, kubamracek. Herald added projects: clang, Sanitizers, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60183 Files: clang/test/Analysis/analyzer-list-configs.c

[PATCH] D60179: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL357561: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

MarinaKalashina updated this revision to Diff 193441. MarinaKalashina added a comment. added a link to CLion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 Files: docs/ClangFormat.rst Index: docs/ClangFormat.rst

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

MarinaKalashina added a comment. @sylvestre.ledru Thanks a lot for your help Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 ___ cfe-commits mailing list

r357567 - [clang-format] Regroup #includes into blocks for Google style

Author: ioeric Date: Wed Apr 3 02:25:16 2019 New Revision: 357567 URL: http://llvm.org/viewvc/llvm-project?rev=357567=rev Log: [clang-format] Regroup #includes into blocks for Google style Summary: Regrouping #includes in blocks separated by blank lines when sorting C++ #include headers was

[clang-tools-extra] r357561 - [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC

Author: ibiryukov Date: Wed Apr 3 00:18:43 2019 New Revision: 357561 URL: http://llvm.org/viewvc/llvm-project?rev=357561=rev Log: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC Summary: Instead of tooling::Replacement. To avoid the need to have contents of the file at the caller

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM with the new changes. Specifying the `clang::Expr` type explicitly when calling `change` looks a bit less clear than the original approach, but also looks pretty clear to me. Repository: rG LLVM Github Monorepo

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

MarinaKalashina marked an inline comment as done. MarinaKalashina added a comment. @sylvestre.ledru Thank you! Could you please explain how I should proceed with the accepted revision now (without commit access, do I need to ask someone to make the commit for me)? CHANGES SINCE LAST ACTION

[PATCH] D60116: [clang-format] Regroup #includes into blocks for Google style

This revision was automatically updated to reflect the committed changes. Closed by commit rC357567: [clang-format] Regroup #includes into blocks for Google style (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D60116?vs=193446=193452#toc Repository:

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-size check

DennisL updated this revision to Diff 193454. DennisL added a comment. Remove debug output CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60139/new/ https://reviews.llvm.org/D60139 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

r357562 - [libclang][test] Suppress annoying 'LIBCLANG TOOLING ERROR' output

Author: maskray Date: Wed Apr 3 00:25:04 2019 New Revision: 357562 URL: http://llvm.org/viewvc/llvm-project?rev=357562=rev Log: [libclang][test] Suppress annoying 'LIBCLANG TOOLING ERROR' output check-all invokes check-clang-python which prints the annoying message: LIBCLANG TOOLING ERROR:

[PATCH] D60186: Support CLANG_ENABLE_DEFAULT_PIE like gcc --enable-default-pie

jiangyi created this revision. Herald added subscribers: cfe-commits, mstorsjo, aheejin, jgravelle-google, sbc100, mgorny, dschuff, emaste. Herald added a project: clang. GCC 6 added the --enable-defaut-pie flag, which would provide better security with ASLR enabled. --enable-defaut-pie is

r357566 - Adding 'CLion integration' to clang-format doc

Author: sylvestre Date: Wed Apr 3 01:56:30 2019 New Revision: 357566 URL: http://llvm.org/viewvc/llvm-project?rev=357566=rev Log: Adding 'CLion integration' to clang-format doc Summary: This commit adds a chapter 'CLion integration' to ClangFormat.rst. The official announcement of clang-format

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

This revision was automatically updated to reflect the committed changes. Closed by commit rC357566: Adding CLion integration to clang-format doc (authored by sylvestre, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

sylvestre.ledru added a comment. You are welcome, thanks for your contribution! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 ___ cfe-commits mailing list

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-size check

DennisL updated this revision to Diff 193449. DennisL marked 13 inline comments as done. DennisL added a comment. Updated patch to address reviewer feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60139/new/ https://reviews.llvm.org/D60139 Files: clang-tidy/misc/CMakeLists.txt

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

hokein marked an inline comment as done. hokein added a comment. As discussed offline, the current approach only works for checks provide a single fix, providing such API is somehow misleading. Instead, we'd emit the check fix and the fix description via diagnostic::Note, rather than attaching

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. works for me, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 ___

[PATCH] D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py

zinovy.nis added a comment. @alexfh, do you still have any objections? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59449/new/ https://reviews.llvm.org/D59449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60116: [clang-format] Regroup #includes into blocks for Google style

ioeric updated this revision to Diff 193446. ioeric added a comment. - Improved test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60116/new/ https://reviews.llvm.org/D60116 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

sylvestre.ledru added a comment. Sure, i will do it for you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

martong added a comment. Ping @shafik @a_sidorin Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

Anastasia added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + : Builder.CreatePointerCast(EventList, EventPtrTy);

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-size check

DennisL updated this revision to Diff 193471. DennisL added a comment. Simplify logic CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60139/new/ https://reviews.llvm.org/D60139 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D60130: gn build: Add build files for clangd xpc framework code

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. Really nice work and thanks for the thread on gn-dev about create_bundle! LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60130/new/ https://reviews.llvm.org/D60130

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia created this revision. Anastasia added reviewers: rjmccall, ebevhan. Herald added a subscriber: yaxunl. This change adds extra cast operator `addrspace_cast` described earlier in this RFC: http://lists.llvm.org/pipermail/cfe-dev/2018-December/060546.html This operator is intended for

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: include/clang/Basic/TokenKinds.def:564 +// OpenCL addrspace_cast operator +KEYWORD(addrspace_cast , KEYOPENCLCXX) + If I mark it as CXX keyword this will make

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + :

[PATCH] D60194: [Tooling] add a Heuristic field indicating that a CompileCommand was guessed.

sammccall created this revision. sammccall added reviewers: ilya-biryukov, klimek. Herald added subscribers: cfe-commits, kadircet, ioeric. Herald added a project: clang. Use cases: - a tool that dumps the heuristic used for each header in a project can be used to evaluate changes to the

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ABataev added a comment. You need to provide -DBUILD_SHARED_LIBS=true to cmake. Unfortunately, there is a dependency from the libToolingRefactor to libTooling. I don't think it will be easy to fix this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/

[PATCH] D60213: Add clangTooling dependency to fix the build.

ymandel created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Fixes https://reviews.llvm.org/D59371, which broke the build for shared libraries. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60213 Files:

[PATCH] D60213: Add clangTooling dependency to fix the build.

ABataev added a comment. Nope, it won't work. There is a cyclic dependency, unfortunately. clangTooling depends on clangToolingRefactor already. You need to revert your commit and refactor it to remove the cyclic dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60213: Add clangTooling dependency to fix the build.

ABataev added a comment. Reverted in r357612 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60213/new/ https://reviews.llvm.org/D60213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; alexfh wrote: > hintonda wrote: > > aaron.ballman

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3177-3178 return false; // Don't split tagged template literal so there is a break between the tag // identifier and template

[PATCH] D59797: [COFF] Reduce the size of Chunk and SectionChunk, NFC

rnk added a comment. In D59797#1452440 , @MaskRay wrote: > > this reduces the sum of heap allocations ... These numbers exclude memory > > mapped files > > May I ask how you counted the memory usage minus memory mapped files? I'm using the Visual

[PATCH] D24639: [Sema] Warn when returning a lambda that captures a local variable by reference

erik.pilkington added a comment. In D24639#1453795 , @bgianfo wrote: > Is there a reason why this was never merged? > Has the functionality been folded in in some other revision? > > I saw a bug recently which would have been caught by exactly this,

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel updated this revision to Diff 193584. ymandel added a subscriber: ABataev. ymandel added a comment. Sever dependency of clangToolingRefactor on clangTooling via FixIt. Transformer used FixIt, which causes a problematic dependency. This diff copies the (minimal) code from FixIt to

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel added a comment. Ilya, this diff fixes the breakage. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ https://reviews.llvm.org/D59376 ___ cfe-commits mailing list

[PATCH] D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60201/new/ https://reviews.llvm.org/D60201 ___ cfe-commits mailing list

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

Hui added inline comments. Comment at: test/CodeGenCXX/debug-info-composite-triviality.cpp:88 - -// CHECK-DAG: !DICompositeType({{.*}}, name: "NonTrivialE",{{.*}}flags: {{.*}}DIFlagNonTrivial -struct NonTrivialE : Trivial, NonTrivial { probinson wrote: > This

[libunwind] r357640 - [libunwind] Export the unw_* symbols as weak symbols

Author: phosek Date: Wed Apr 3 14:50:03 2019 New Revision: 357640 URL: http://llvm.org/viewvc/llvm-project?rev=357640=rev Log: [libunwind] Export the unw_* symbols as weak symbols libunwind defines the _Unwind_* ABI used by libc++abi. This ABI is a stable quasi-standard common between multiple

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda updated this revision to Diff 193604. hintonda added a comment. Herald added subscribers: arphaman, mgorny. - Rename llvm directory to llvm_project. - Change llvm- to llvm-project-. - Rename files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, dexonsmith, mehdi_amini, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. ASan provides its own operator new/delete to intercept all allocations and deallocations.

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.h:25 +/// TODO: Generalize to handle libclc. +class RocmInstallationDetector { +private: yaxunl wrote: > I don't think we should detect ROCm

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

arphaman created this revision. arphaman added a reviewer: Bigcheese. Herald added subscribers: jfb, dexonsmith, jkorous, mgorny. Herald added a project: clang. This patch introduces an outline for the `clang-scan-deps` tool that will be used to implement fast dependency discovery phase using

[PATCH] D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, djasper, JonasToth, russellmcc, reuk. MyDeveloperDay added a project: clang-tools-extra. Code::Blocks and Qt Creator code uses a style guide which recommends indenting the next line after the access modifier e.g.

[PATCH] D59852: [IR] Create new method in the Function class (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rC357638: [IR] Create new method in `Function` class (NFC) (authored by evandro, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

r357638 - [IR] Create new method in `Function` class (NFC)

Author: evandro Date: Wed Apr 3 14:27:03 2019 New Revision: 357638 URL: http://llvm.org/viewvc/llvm-project?rev=357638=rev Log: [IR] Create new method in `Function` class (NFC) Create method `optForNone()` testing for the function level equivalent of `-O0` and refactor appropriately.

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato added inline comments. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:93 +llvm::BasicBlock::iterator InsertPoint, llvm::Value *Dst, +CharUnits Alignment, QualType QT); + rjmccall wrote: > Hmm. I think it might be better to just have

r357629 - [OPENMP]Add codegen for reduction vars with allocate clause, NFC.

Author: abataev Date: Wed Apr 3 12:59:09 2019 New Revision: 357629 URL: http://llvm.org/viewvc/llvm-project?rev=357629=rev Log: [OPENMP]Add codegen for reduction vars with allocate clause, NFC. Added test for the reduction variables with the allocate clause. Modified:

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

rjmccall added inline comments. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:93 +llvm::BasicBlock::iterator InsertPoint, llvm::Value *Dst, +CharUnits Alignment, QualType QT); + Hmm. I think it might be better to just have this return a

r357625 - [OPENMP]Add codegen for lastprivate vars with allocate clause, NFC.

Author: abataev Date: Wed Apr 3 12:12:47 2019 New Revision: 357625 URL: http://llvm.org/viewvc/llvm-project?rev=357625=rev Log: [OPENMP]Add codegen for lastprivate vars with allocate clause, NFC. Added test for the lastprivatized variables with the allocate clause. Modified:

[PATCH] D24639: [Sema] Warn when returning a lambda that captures a local variable by reference

bgianfo added a comment. Herald added subscribers: dexonsmith, jkorous. Is there a reason why this was never merged? Has the functionality been folded in in some other revision? I saw a bug recently where this warning would have been great. How can we get this merged? CHANGES SINCE LAST ACTION

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker marked 3 inline comments as done. lewissbaker added inline comments. Comment at: include/experimental/task:160 +__get_allocator<_CharAlloc>(__pointer, __size); +_CharAlloc __allocatorOnStack = _VSTD::move(__allocatorInFrame); +

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel reopened this revision. ymandel added a comment. This revision is now accepted and ready to land. Reopening to fix the breakage caused by previous attempt at commit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ https://reviews.llvm.org/D59376

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

arphaman added a comment. @Bigcheese Initial tool posted to https://reviews.llvm.org/D60233 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55463/new/ https://reviews.llvm.org/D55463 ___ cfe-commits mailing list

[PATCH] D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

thakis created this revision. thakis added a reviewer: bkramer. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. This allows building it even if no fuzzer is enabled. (Sadly, it only builds on Linux at the moment.) https://reviews.llvm.org/D60201

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

hokein updated this revision to Diff 193510. hokein added a comment. Emit the check fix description via diagnostic::note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59932/new/ https://reviews.llvm.org/D59932 Files:

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; aaron.ballman

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. Note that with: 1. https://reviews.llvm.org/D60208 ("[X86] Extend boolean arguments to inline-asm according to getBooleanType") 2. https://reviews.llvm.org/D58260 ("[INLINER] allow inlining of blockaddresses if sole uses are callbrs") 3.

r357620 - Revert "[analyzer] Toning down invalidation a bit".

Author: dergachev Date: Wed Apr 3 11:21:16 2019 New Revision: 357620 URL: http://llvm.org/viewvc/llvm-project?rev=357620=rev Log: Revert "[analyzer] Toning down invalidation a bit". This reverts commit r352473. The overall idea is great, but it seems to cause unintented consequences when not

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; hintonda wrote: > aaron.ballman wrote: > > I do not

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

hokein added a comment. Running out of time today, the patch is not finished yet, but it should be good for another initial review/comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59932/new/ https://reviews.llvm.org/D59932

[libunwind] r357606 - [libunwind] Do not share an object library to create the static/shared libraries

Author: phosek Date: Wed Apr 3 09:59:33 2019 New Revision: 357606 URL: http://llvm.org/viewvc/llvm-project?rev=357606=rev Log: [libunwind] Do not share an object library to create the static/shared libraries This change is similar to r356150, with the same motivation. Modified:

[PATCH] D33841: [clang-tidy] redundant keyword check

alexfh added inline comments. Comment at: docs/clang-tidy/checks/readability-redundant-keyword.rst:8 + +`extern` is redundant in function declarations + koldaniel wrote: > alexfh wrote: > > xazax.hun wrote: > > > alexfh wrote: > > > > Could you explain, why you

r357585 - Add a new attribute documentation category for declarations.

Author: aaronballman Date: Wed Apr 3 07:26:32 2019 New Revision: 357585 URL: http://llvm.org/viewvc/llvm-project?rev=357585=rev Log: Add a new attribute documentation category for declarations. This moves documentation for some attributes into new categories that are hopefully a bit more

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin added a comment. Alternative way to fix it is to use `isNullPointerConstant` like we do in `SemaOpenCLBuiltinEnqueueKernel`. So in case we have a zero literal value we can emit `ConstantPointerNull` directly, without `EmitScalarExpr` . Repository: rC Clang CHANGES SINCE LAST

Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

I'll revert the change. On Wed, Apr 3, 2019 at 1:00 PM Yitzhak Mandelbaum wrote: > https://reviews.llvm.org/D60213 for the record > > On Wed, Apr 3, 2019 at 12:55 PM Yitzhak Mandelbaum > wrote: > >> Thanks. Do you have build command I can run before/after to verify my >> fix before I submit?

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

emankov created this revision. emankov added a reviewer: tra. emankov added a project: clang. Herald added a subscriber: cfe-commits. Last fix for the clang Bug 38811 "Clang fails to compile with CUDA-9.x on Windows". **[IMPORTANT]** With that last

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:81-90 +__DEVICE__ bool isinf(long double __x) { return ::__isinfl(__x); } __DEVICE__ bool isfinite(float __x) { return ::__finitef(__x); } // For inscrutable reasons, __finite(), the double-precision

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

NoQ added a comment. Reverted D57230 in rC357620 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58121/new/ https://reviews.llvm.org/D58121 ___ cfe-commits mailing list

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

ioeric added inline comments. Comment at: unittests/Format/SortIncludesTest.cpp:28 std::string sort(StringRef Code, std::vector Ranges, + llvm::Optional ExpectedNumRanges = llvm::None, StringRef FileName = "input.cc") {

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda added a comment. In D60151#1453099 , @alexfh wrote: > The change looks fine, but I don't understand the description of this > revision. Could you clarify which checkers you're talking about and which bug > you observe? Sorry for not being

[PATCH] D60203: Updating Chromium's Java import order

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! (Test?) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60203/new/ https://reviews.llvm.org/D60203 ___

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; aaron.ballman

[PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk marked 2 inline comments as done. rnk added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 ___ cfe-commits mailing list

r357610 - Bug-40323: MS ABI adding template static member in the linker directive section to make sure init function can be called before main.

Author: jyu2 Date: Wed Apr 3 10:21:40 2019 New Revision: 357610 URL: http://llvm.org/viewvc/llvm-project?rev=357610=rev Log: Bug-40323: MS ABI adding template static member in the linker directive section to make sure init function can be called before main. Added:

r357612 - Revert "[LibTooling] Add Transformer, a library for source-to-source transformations."

Author: abataev Date: Wed Apr 3 10:34:04 2019 New Revision: 357612 URL: http://llvm.org/viewvc/llvm-project?rev=357612=rev Log: Revert "[LibTooling] Add Transformer, a library for source-to-source transformations." This reverts commit r357576 to fix the problem with the cyclic dependencies

Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

Alexey, thanks for reverting the change. Can you expand on why a dependency from libToolingRefactor to libTooling causes a cycle in the dep graph? In particular, I can't find the reverse dependency libTooling -> libToolingRefactor. If you can expand on that (I presume its a chain rather than a

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

yaxunl added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.h:25 +/// TODO: Generalize to handle libclc. +class RocmInstallationDetector { +private: I don't think we should detect ROCm installation here. We are compiling code for amdgpu not only on

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

ashi1 added a comment. Thank you, I submitted a clang-formatted fix for the if statement. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60141/new/ https://reviews.llvm.org/D60141 ___ cfe-commits mailing list

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 193496. ymandel added a comment. Sever dependency on NodeId and some general cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59371/new/ https://reviews.llvm.org/D59371 Files:

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

sammccall added a comment. Got here trying to understand how D60126 works. It seems there's two fairly independent changes here: - the one described, allow actions to run without a preamble - defer the blocking getCompileCommand() call until we're building the

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ABataev added a comment. Patch breaks the build with the shared libraries, for example, http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/9498. Seems to me, you need to add an extra dependency on clangTooling. clangToolingCore is not enough. Repository: rC Clang

Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

Thanks. Do you have build command I can run before/after to verify my fix before I submit? On Wed, Apr 3, 2019 at 12:43 PM Alexey Bataev via Phabricator < revi...@reviews.llvm.org> wrote: > ABataev added a comment. > > Patch breaks the build with the shared libraries, for example, >

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

alexfh added a comment. This looks like a more promising direction. Thanks for the readiness to experiment with this. See the comments inline. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:130 + + // If we have alternative fixes (attached via

[PATCH] D60213: Add clangTooling dependency to fix the build.

ABataev added a comment. I can revert it for you, if you want Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60213/new/ https://reviews.llvm.org/D60213 ___ cfe-commits mailing list

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; hintonda wrote: > aaron.ballman wrote: > > hintonda wrote:

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1116 +def ObjCClassStubDocs : Documentation { +let Category = DocCatFunction; +let Content = [{ aaron.ballman wrote: > slavapestov wrote: > > aaron.ballman wrote: > > > This

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

This revision was automatically updated to reflect the committed changes. Closed by commit rC357599: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK (authored by krasimir, committed by ). Changed prior to commit:

[PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193526. rnk added a comment. - final updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 Files: lld/COFF/PDB.cpp

r357589 - Whitespace and formatting changes; NFC.

Author: aaronballman Date: Wed Apr 3 07:40:00 2019 New Revision: 357589 URL: http://llvm.org/viewvc/llvm-project?rev=357589=rev Log: Whitespace and formatting changes; NFC. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.td URL:

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 193498. ymandel added a comment. Remove noisy default-defined constructors/operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59371/new/ https://reviews.llvm.org/D59371 Files:

[PATCH] D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py

alexfh added a comment. In D59449#1449664 , @zinovy.nis wrote: > > Why not just use clang-tidy-diff.py? The clang-tidy-diff.py script has a > > distinct and somewhat self-documenting name and a very specific purpose > > (find clang-tidy regressions in a

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

krasimir updated this revision to Diff 193500. krasimir added a comment. - Address review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60199/new/ https://reviews.llvm.org/D60199 Files: lib/Format/Format.cpp unittests/Format/SortIncludesTest.cpp

r357599 - [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

Author: krasimir Date: Wed Apr 3 08:16:04 2019 New Revision: 357599 URL: http://llvm.org/viewvc/llvm-project?rev=357599=rev Log: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK Summary: Currently clang-format would always emit a replacement for multi-block

[PATCH] D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main.

jyu2 closed this revision. jyu2 added a comment. Closed by commit rG0b28b8b09be7 : Bug-40323: MS ABI adding template static member in the linker directive section… (authored by jyu2). Repository: rL LLVM CHANGES SINCE

[PATCH] D60203: Updating Chromium's Java import order

SamMaier created this revision. SamMaier added a reviewer: thakis. Herald added subscribers: cfe-commits, srhines. Herald added a project: clang. Adding in androidx as another import group. Repository: rC Clang https://reviews.llvm.org/D60203 Files: lib/Format/Format.cpp Index:

  1   2   >