[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda added a comment. ping, and should we add new warning messages as suggested by @Rakete ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59754/new/ https://reviews.llvm.org/D59754 ___

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang added a comment. If no more changes need to be made, is this okay to be merged in? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

Ywicheng updated this revision to Diff 194614. Ywicheng marked an inline comment as done. Ywicheng edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:85 + +std::string Left = (ConsDecl) ? "auto " + NameRef.str() + " = " : ""; +std::string NewText = I don't think that you need round brackets around ConsDecl. Same

[PATCH] D17407: [Sema] PR25755 Handle out of order designated initializers

hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17407/new/ https://reviews.llvm.org/D17407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: Notice: The buildbot bb.pgr.jp will be suspended within a few days

Takumi, I am very sorry it took me almost 18 months to respond to this note. I'm sorry to see you had to shutter bb.pgr.jp. It was a very helpful resource to the community. Thank you very much for your contribution of effort and resources to make bb.pgr.jp available to the LLVM community for as

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194621. Dosi-Dough marked 2 inline comments as done. Dosi-Dough added a comment. added whitespace to check doc Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files:

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194622. Dosi-Dough added a comment. added white space to check doc. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D60409: [clangd] Add -header-insertion=never flag to disable include insertion in code completion

MaskRay added a comment. In D60409#1461579 , @phosek wrote: > Our Mac builders have started failing after this change with the following: > > [3145/3502] Building CXX object > tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o >

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

jkorous marked an inline comment as done. jkorous added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:372 D = adjustDeclToTemplate(D); + const Decl* CanonicalDecl = D->getCanonicalDecl(); gribozavr wrote: > jkorous wrote: > > arphaman wrote: >

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

Ywicheng updated this revision to Diff 194623. Ywicheng marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

Ywicheng updated this revision to Diff 194631. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/SafelyScopedCheck.cpp

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda updated this revision to Diff 194633. hintonda edited the summary of this revision. hintonda added a comment. - Fix bug in updateArgStr() where it didn't handle isInAllSubCommands() correctly, and refactored code based on how SubCommands work. Repository: rG LLVM Github Monorepo

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194608. Dosi-Dough added a comment. fixed docs and white spacing Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r358104 - Don't emit an unreachable return block.

On 10 Apr 2019, at 21:50, wolfgang.p...@sony.com wrote: Hi, This commit seems to be causing a test failure on several buildbots (e.g. http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/26305). instrprof-shared-gcov-flush.test is failing because of differences in profile

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 

stephanemoore created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stephanemoore added a reviewer: aaron.ballman. This change adds a new AST matcher to detect Objective-C classes that are subclasses of matching Objective-C interfaces. Test Notes: Ran

[PATCH] D60544: Support objc_nonlazy_class attribute on Objective-C implementations

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, aaron.ballman. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. Fixes rdar://49523079 Repository: rC Clang https://reviews.llvm.org/D60544 Files:

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59121/new/ https://reviews.llvm.org/D59121 ___ cfe-commits mailing

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, I am

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

jkorous updated this revision to Diff 194609. jkorous added a comment. rename RawCommentAndCacheFlags -> CommentAndOrigin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60432/new/ https://reviews.llvm.org/D60432 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D55409: [clang-tidy] check for using declarations not in an anonymous namespace when there exists one

Naysh marked an inline comment as done. Naysh added inline comments. Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:41 +// to the vector containing all candidate using declarations. +if (AnonymousNamespaceDecl) { +

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194618. Dosi-Dough marked 3 inline comments as done. Dosi-Dough added a comment. removed parens from turnary, added whitespace. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/

RE: r358104 - Don't emit an unreachable return block.

Hi, This commit seems to be causing a test failure on several buildbots (e.g. http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/26305). instrprof-shared-gcov-flush.test is failing because of differences in profile info. The test passes when I revert your change, so perhaps it's

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

jkorous updated this revision to Diff 194604. jkorous added a comment. Second attempt on reducing the cache size and number of operations. I try in this order 1. cache lookup for the specific provided declaration 2. try to find comment attached to the specific provided declaration without

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194607. Dosi-Dough marked an inline comment as done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/abseil-wrap-unique.rst:5 +== +Looks for instances of factory functions which uses a non-public constructor +that returns a ``std::unqiue_ptr`` then recommends using ``absl::wrap_unique(new

[PATCH] D60552: Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

liutianle created this revision. liutianle added reviewers: craig.topper, smaslov, LuoYuanke, wxiao3, annita.zhang. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. 1. Enable infrastructure of AVX512_BF16, which is supported for BFLOAT16 in Cooper Lake; 2. Enable

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb added a comment. One downside to alloca is that we can's use `__attribute__((uninitialized))` because it's a builtin. Maybe we need a separate uninitialized alloca? What do you all think? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60548/new/

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb created this revision. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. alloca isn’t auto-init’d right now because it’s a different path in clang that all the other stuff we support (it’s a builtin, not an expression). Interestingly, alloca doesn’t

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

qiucf marked an inline comment as done. qiucf added a comment. Part of a function signature can also match where it is called, so the test failed. I did the changes to pass the test but diff file was generated locally so it didn't contain this change. Sorry for the mistake. Repository: rC

[PATCH] D60302: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358048: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of (authored by ahatanak, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r358048 - [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of

Author: ahatanak Date: Tue Apr 9 23:20:23 2019 New Revision: 358048 URL: http://llvm.org/viewvc/llvm-project?rev=358048=rev Log: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata. This fixes a bug where ARC contract wasn't inserting the retainRV marker when LTO

[PATCH] D60503: [clangd] Don't insert extra namespace qualifiers when Sema gets lost.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clangd/CodeComplete.cpp:545 const CodeCompleteOptions ) { - auto GetAllAccessibleScopes = [](CodeCompletionContext ) { -SpecifiedScope Info; -for (auto *Context :

[PATCH] D60463: [ASTImporter] Add check for correct import of source locations.

balazske added a comment. This test will work theoretically only if the order of every imported Decl (and not only FieldDecl) is correct, this is not the case now. So probably a better solution for the problem should be found: Enumerate and match (the From and To) SourceLocations with AST

[PATCH] D60029: Add const children() accessors to all AST nodes.

nicolas added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60029/new/ https://reviews.llvm.org/D60029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60055: Check i < FD->getNumParams() before querying

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. This fix makes sense to me, however, Richard Smith @rsmith is the best person to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

gribozavr added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:756 /// lazily. mutable llvm::DenseMap RedeclComments; The name of this variable (and `RawCommentAndCacheFlags`) don't make sense after the change.

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

ilya-biryukov added inline comments. Comment at: clangd/Diagnostics.cpp:271 + if (!Note.AbsFile) { +log("Dropping note from unknown file: {0}", Note); +continue; Maybe `vlog`? This is what we use for dropped diagnostics, should probably

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

ilya-biryukov added inline comments. Comment at: clangd/Protocol.cpp:280 R.DiagnosticFixes = *CodeActions; + if (auto CodeActions = Diagnostics->getBoolean("relatedInformation")) +R.DiagnosticRelatedInformation = *CodeActions; kadircet

[clang-tools-extra] r358074 - [clangd] Refactor speculateCompletionFilter and also extract scope.

Author: sammccall Date: Wed Apr 10 04:50:40 2019 New Revision: 358074 URL: http://llvm.org/viewvc/llvm-project?rev=358074=rev Log: [clangd] Refactor speculateCompletionFilter and also extract scope. Summary: Intent is to use the heuristically-parsed scope in cases where we get bogus results from

[PATCH] D60500: [clangd] Refactor speculateCompletionFilter and also extract scope.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clangd/CodeComplete.cpp:1542 + assert(Offset <= Content.size()); + StringRef Suffix = Content.take_front(Offset); + CompletionPrefix Result; ioeric wrote: > `Suffix` is

[PATCH] D60500: [clangd] Refactor speculateCompletionFilter and also extract scope.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rL358074: [clangd] Refactor speculateCompletionFilter and also extract scope. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a

[PATCH] D60503: [clangd] Don't insert extra namespace qualifiers when Sema gets lost.

sammccall updated this revision to Diff 194486. sammccall added a comment. Update comment Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60503/new/ https://reviews.llvm.org/D60503 Files: clangd/CodeComplete.cpp

[PATCH] D60500: [clangd] Refactor speculateCompletionFilter and also extract scope.

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Intent is to use the heuristically-parsed scope in cases where we get bogus results from sema, such as

[PATCH] D60503: [clangd] Don't insert extra namespace qualifiers when Sema gets lost.

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. There are cases where Sema can't tell that "foo" in foo::Bar is a namespace qualifier, like in

[PATCH] D60500: [clangd] Refactor speculateCompletionFilter and also extract scope.

sammccall updated this revision to Diff 194462. sammccall added a comment. Handle edge-case correctly. Add test for leading :: case. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60500/new/ https://reviews.llvm.org/D60500 Files:

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

ilya-biryukov added inline comments. Comment at: clangd/Diagnostics.cpp:185 OS << Note.Message; - OS << "\n\n"; - printDiag(OS, Main); + // If there's no structured link between the note and the original diagnostic + // then emit the main diagnostic to give context.

[PATCH] D60500: [clangd] Refactor speculateCompletionFilter and also extract scope.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Comment at: clangd/CodeComplete.cpp:1542 + assert(Offset <= Content.size()); + StringRef Suffix = Content.take_front(Offset); + CompletionPrefix Result;

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

kadircet added inline comments. Comment at: clangd/Protocol.cpp:280 R.DiagnosticFixes = *CodeActions; + if (auto CodeActions = Diagnostics->getBoolean("relatedInformation")) +R.DiagnosticRelatedInformation = *CodeActions;

[PATCH] D59599: [clangd] Fix a crash while printing Template Arguments

kadircet updated this revision to Diff 194470. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59599/new/ https://reviews.llvm.org/D59599 Files: clangd/AST.cpp

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

DavidSpickett added a comment. Do we need a separate file for that one "__arm_mte_ptrdiff" test? Wouldn't it be easier to wrap the whole function in "__cplusplus" and put it in the same file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485

[PATCH] D60409: [clangd] Add -header-insertion=never flag to disable include insertion in code completion

sammccall accepted this revision. sammccall marked 2 inline comments as done. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/CodeComplete.cpp:1176 // This is available after Sema has run. - llvm::Optional Inserter; //

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. ASTImporter contained wrong or missing imports of

[PATCH] D60500: [clangd] Refactor speculateCompletionFilter and also extract scope.

sammccall updated this revision to Diff 194463. sammccall added a comment. Fix terrible variable name. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60500/new/ https://reviews.llvm.org/D60500 Files: clangd/CodeComplete.cpp

r358136 - Fix a test, NFC

Author: epilk Date: Wed Apr 10 14:18:21 2019 New Revision: 358136 URL: http://llvm.org/viewvc/llvm-project?rev=358136=rev Log: Fix a test, NFC This test was duplicated, and the last declaration had some syntax errors since the invalid attribute caused the @implementation to be skipped by the

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

amyk created this revision. amyk added reviewers: ilya-biryukov, sammccall, ioeric, hokein, akyrtzi, yvvan. amyk added projects: clang, LLVM. Herald added subscribers: kadircet, arphaman, dexonsmith, jkorous. On one of the platforms that we build on, we build with the CMake macro,

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Generally it's a good thing for our test suite to be robust against changes to Clang's default language mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60539/new/

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

dblaikie added a comment. In D59673#1460605 , @aaronpuchert wrote: > Ok, here is an idea. We introduce `-split-dwarf-output` in Clang instead of > `-fsplit-dwarf-dwo-name-attr`. If given, it overrides the output file name > for the Split DWARF file,

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Approved pending the LLVM side changes/discussion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59347/new/ https://reviews.llvm.org/D59347

[PATCH] D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Okay, I played around with this patch, I see now where this is going! LGTM! > Do you think i should document it somehow? Aye, the description you gave was enlightening, thanks! If you

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus added inline comments. Comment at: docs/analyzer/checkers.rst:225-226 +``std::string``s, by recognizing member functions that may re/deallocate the buffer +before use. In the future, it would be great to add support for other STL and +non-STL containers, and most

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

Szelethus added a comment. Sorry, I rushed my earlier comment -- I definitely think that we should get rid of the `UINT_MAX` thing before landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

Szelethus added a comment. Hmmm, interesting. Could there be an issue with `NoteTag` not being trivially destructible? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58367/new/ https://reviews.llvm.org/D58367

[PATCH] D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive

dchai created this revision. dchai added a reviewer: krasimir. Herald added a project: clang. Herald added a subscriber: cfe-commits. AnnotatingParser::next() is needed to implicitly set TT_BlockComment versus TT_LineComment. On most other paths through AnnotatingParser::parseLine(), all tokens

[PATCH] D60542: Add support for attributes on @implementations in Objective-C

erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, rjmccall. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. We want to make `objc_nonlazy_class` apply to implementations, but ran into this. There doesn't seem to be any reason

[PATCH] D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check

DennisL marked 12 inline comments as done. DennisL added a comment. In D60139#1460233 , @JonasToth wrote: > Hey Dennis, > > my 2cents on the check. I think it is very good to have! Did you check coding > guidelines if they say something to this issue?

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

DavidSpickett added a comment. What's the motivation for this change, are you working towards common flags for both platforms? The current way to select crypto on AArch64 is '-march=armv8.x-a+crypto/nocrypto'. I can see that would be an issue if Power PC doesn't support that syntax, or doesn't

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

manojgupta added a comment. In D60472#1461351 , @peter.smith wrote: > > Is that not a limitation of the build system? I'd expect a package to be able > to locally override a global default rather than vice-versa. Although crypto > might be the area

[PATCH] D60513: [HIP] Use -mlink-builtin-bitcode to link device library

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Herald added a subscriber: jdoerfert. Use -mlink-builtin-bitcode instead of llvm-link to link device library so that device library bitcode and user device code can be compiled in a consistent way. This is the same approach used

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on MacOS.

fhahn created this revision. fhahn added reviewers: anemet, tejohnson, thegameg. Herald added subscribers: cfe-commits, dang, dexonsmith, steven_wu, hiraditya, inglorion, mehdi_amini. Herald added projects: clang, LLVM. Gold and ld on Linux already support saving stats, but the infrastructure is

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong added a comment. Ping @a_sidorin @shafik Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692/new/ https://reviews.llvm.org/D59692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong updated this revision to Diff 194527. martong marked an inline comment as done. martong added a comment. - Put back the call to GetOriginalDecl Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692/new/ https://reviews.llvm.org/D59692 Files:

[clang-tools-extra] r358094 - [clangd] Use #if CLANGD_BUILD_XPC because it may be defined as 0

Author: maskray Date: Wed Apr 10 08:45:54 2019 New Revision: 358094 URL: http://llvm.org/viewvc/llvm-project?rev=358094=rev Log: [clangd] Use #if CLANGD_BUILD_XPC because it may be defined as 0 Modified: clang-tools-extra/trunk/clangd/Transport.h Modified:

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 194528. kadircet marked 10 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 Files:

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato updated this revision to Diff 194530. allevato added a comment. - Rename generate* to get* and cleanup param names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/ https://reviews.llvm.org/D60161 Files:

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

sbenza added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:45 + /// Evaluates this part to a string and appends it to `result`. + virtual llvm::Error eval(const ast_matchers::MatchFinder::MatchResult , + std::string

[clang-tools-extra] r358098 - [clangd] Fix non-indexing of builtin functions like printf when the TU is C

Author: sammccall Date: Wed Apr 10 09:26:58 2019 New Revision: 358098 URL: http://llvm.org/viewvc/llvm-project?rev=358098=rev Log: [clangd] Fix non-indexing of builtin functions like printf when the TU is C Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp

[clang-tools-extra] r358091 - [clangd] Don't insert extra namespace qualifiers when Sema gets lost.

Author: sammccall Date: Wed Apr 10 08:16:54 2019 New Revision: 358091 URL: http://llvm.org/viewvc/llvm-project?rev=358091=rev Log: [clangd] Don't insert extra namespace qualifiers when Sema gets lost. Summary: There are cases where Sema can't tell that "foo" in foo::Bar is a namespace qualifier,

[PATCH] D59746: [LibTooling] Fix '-h' option

jhenderson added a comment. Just chiming in from a LLVM binutils developer perspective. Some of the binutils are missing -h as an alias, when they really should have it for compatibility (specifically I checked llvm-nm and llvm-symbolizer). As a result, a solution that auto-adds -h as an alias

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato marked 2 inline comments as done. allevato added a comment. Thanks for the review! This is ready to go on my end if there aren't any other comments. Comment at: clang/lib/CodeGen/CGNonTrivialStruct.cpp:845 + // actually use them (it overwrites them with the

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/ https://reviews.llvm.org/D60161

[PATCH] D60503: [clangd] Don't insert extra namespace qualifiers when Sema gets lost.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358091: [clangd] Dont insert extra namespace qualifiers when Sema gets lost. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[clang-tools-extra] r358093 - clangd: repair the build after SVN r358091

Author: compnerd Date: Wed Apr 10 08:45:05 2019 New Revision: 358093 URL: http://llvm.org/viewvc/llvm-project?rev=358093=rev Log: clangd: repair the build after SVN r358091 Fix the name of the variable being checked. NFCI. Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet added inline comments. Comment at: clangd/Diagnostics.cpp:396 + for (llvm::StringRef Inc : IncludeStack) +OS << "In file included from: " << Inc << ":\n"; +} ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: >

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato added a comment. Oh, and in case I need to mention this (I don't contribute to llvm/clang frequently), I don't have commit access so I'll need someone else to merge it in. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

peter.smith added a comment. In D60472#1461336 , @manojgupta wrote: > The motivation for this change is to make "crypto" setting an additive option > e.g. like "-mavx" used in many media packages. Some packages in Chrome want > to enable crypto

[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

pgousseau added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59221/new/ https://reviews.llvm.org/D59221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

hans added a comment. I don't feel like I have enough background on what you're trying to do to review this. It sounds related to clangd issues maybe? "If the source file path contains directory junctions, and we resolve them when printing diagnostic messages" I didn't think Clang tried to

[PATCH] D60503: [clangd] Don't insert extra namespace qualifiers when Sema gets lost.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Feel free to land this. I'll rebase D60126 on this when it's in. Comment at: clangd/CodeComplete.cpp:580 + // Case 3: sema saw and

[PATCH] D60055: Check i < FD->getNumParams() before querying

gribozavr added a comment. I'd be happy to land it, but I do want @rsmith to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 ___ cfe-commits

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This check searches for copy assignment operators which might not handle self-assignment properly. There are three patterns of handling a self assignment situation: self check,

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:102 "bugprone-too-small-loop-variable"); +CheckFactories.registerCheck( +"bugprone-unhandled-self-assignment"); please order this list

[PATCH] D60510: [ADT] Fix template parameter names of llvm::{upper|lower}_bound

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Rename template parameter for a search value from 'ForwardIt' to 'T'. While here, also use perfect forwarding to pass the value to STL

r358087 - clang-cl: Fix parsing of the /F option (PR41405)

Author: hans Date: Wed Apr 10 07:27:47 2019 New Revision: 358087 URL: http://llvm.org/viewvc/llvm-project?rev=358087=rev Log: clang-cl: Fix parsing of the /F option (PR41405) Modified: cfe/trunk/include/clang/Driver/CLCompatOptions.td cfe/trunk/test/Driver/cl-options.c Modified:

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

manojgupta added a comment. The motivation for this change is to make "crypto" setting an additive option e.g. like "-mavx" used in many media packages. Some packages in Chrome want to enable crypto conditionally for a few files to allow crypto feature to be used based on runtime cpu

[PATCH] D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check

DennisL updated this revision to Diff 194505. DennisL marked an inline comment as done. DennisL added a comment. Changed the following - addressed reviewer feedback - fetch the placement parameter as written - add further test cases as requested - stylistic changes - add nothrow parameter

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. Thanks. Can you land it for me? I'm a newcommer without landing privilege. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 ___

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

peter.smith added a comment. I'm not in favour of adding AArch64 support to -mcrypto -mnocrypto for a few reasons: - Arm are trying to keep the options for controlling target features as consistent as possible with GCC and this option isn't supported in GCC

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

manojgupta added a comment. In D60472#1461351 , @peter.smith wrote: > > Is that not a limitation of the build system? I'd expect a package to be able > to locally override a global default rather than vice-versa. Although crypto > might be the area

  1   2   >