[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus added inline comments. Comment at: docs/analyzer/checkers.rst:225-226 +``std::string``s, by recognizing member functions that may re/deallocate the buffer +before use. In the future, it would be great to add support for other STL and +non-STL containers, and most notab

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

Szelethus added a comment. Hmmm, interesting. Could there be an issue with `NoteTag` not being trivially destructible? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58367/new/ https://reviews.llvm.org/D58367

[PATCH] D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive

dchai created this revision. dchai added a reviewer: krasimir. Herald added a project: clang. Herald added a subscriber: cfe-commits. AnnotatingParser::next() is needed to implicitly set TT_BlockComment versus TT_LineComment. On most other paths through AnnotatingParser::parseLine(), all tokens a

[PATCH] D60542: Add support for attributes on @implementations in Objective-C

erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, rjmccall. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. We want to make `objc_nonlazy_class` apply to implementations, but ran into this. There doesn't seem to be any reason that

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 🔍

stephanemoore created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stephanemoore added a reviewer: aaron.ballman. This change adds a new AST matcher to detect Objective-C classes that are subclasses of matching Objective-C interfaces. Test Notes: Ran clang

[PATCH] D60544: Support objc_nonlazy_class attribute on Objective-C implementations

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, aaron.ballman. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. Fixes rdar://49523079 Repository: rC Clang https://reviews.llvm.org/D60544 Files: clang/include/clang/Basic/Attr.td

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59121/new/ https://reviews.llvm.org/D59121 ___ cfe-commits mailing lis

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 🔍

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, I am still

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda added a comment. ping, and should we add new warning messages as suggested by @Rakete ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59754/new/ https://reviews.llvm.org/D59754 ___ cfe-com

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

jkorous marked an inline comment as done. jkorous added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:372 D = adjustDeclToTemplate(D); + const Decl* CanonicalDecl = D->getCanonicalDecl(); gribozavr wrote: > jkorous wrote: > > arphaman wrote: > >

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb created this revision. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. alloca isn’t auto-init’d right now because it’s a different path in clang that all the other stuff we support (it’s a builtin, not an expression). Interestingly, alloca doesn’t h

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb added a comment. One downside to alloca is that we can's use `__attribute__((uninitialized))` because it's a builtin. Maybe we need a separate uninitialized alloca? What do you all think? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60548/new/ https://revi

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

jkorous updated this revision to Diff 194604. jkorous added a comment. Second attempt on reducing the cache size and number of operations. I try in this order 1. cache lookup for the specific provided declaration 2. try to find comment attached to the specific provided declaration without using

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194607. Dosi-Dough marked an inline comment as done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194608. Dosi-Dough added a comment. fixed docs and white spacing Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp cla

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

jkorous updated this revision to Diff 194609. jkorous added a comment. rename RawCommentAndCacheFlags -> CommentAndOrigin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60432/new/ https://reviews.llvm.org/D60432 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cp

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:85 + +std::string Left = (ConsDecl) ? "auto " + NameRef.str() + " = " : ""; +std::string NewText = I don't think that you need round brackets around ConsDecl. Same bel

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang added a comment. If no more changes need to be made, is this okay to be merged in? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17407: [Sema] PR25755 Handle out of order designated initializers

hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17407/new/ https://reviews.llvm.org/D17407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

Ywicheng updated this revision to Diff 194614. Ywicheng marked an inline comment as done. Ywicheng edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/ab

[PATCH] D55409: [clang-tidy] check for using declarations not in an anonymous namespace when there exists one

Naysh marked an inline comment as done. Naysh added inline comments. Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:41 +// to the vector containing all candidate using declarations. +if (AnonymousNamespaceDecl) { + diag(MatchedUsingDecl->get

Re: Notice: The buildbot bb.pgr.jp will be suspended within a few days

Takumi, I am very sorry it took me almost 18 months to respond to this note. I'm sorry to see you had to shutter bb.pgr.jp. It was a very helpful resource to the community. Thank you very much for your contribution of effort and resources to make bb.pgr.jp available to the LLVM community for as

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194618. Dosi-Dough marked 3 inline comments as done. Dosi-Dough added a comment. removed parens from turnary, added whitespace. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.or

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/abseil-wrap-unique.rst:5 +== +Looks for instances of factory functions which uses a non-public constructor +that returns a ``std::unqiue_ptr`` then recommends using ``absl::wrap_unique(new

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194621. Dosi-Dough marked 2 inline comments as done. Dosi-Dough added a comment. added whitespace to check doc Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files:

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194622. Dosi-Dough added a comment. added white space to check doc. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

Ywicheng updated this revision to Diff 194623. Ywicheng marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/Safely

RE: r358104 - Don't emit an unreachable return block.

Hi, This commit seems to be causing a test failure on several buildbots (e.g. http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/26305). instrprof-shared-gcov-flush.test is failing because of differences in profile info. The test passes when I revert your change, so perhaps it's j

[PATCH] D60552: Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

liutianle created this revision. liutianle added reviewers: craig.topper, smaslov, LuoYuanke, wxiao3, annita.zhang. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. 1. Enable infrastructure of AVX512_BF16, which is supported for BFLOAT16 in Cooper Lake; 2. Enable int

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

Ywicheng updated this revision to Diff 194631. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/SafelyScopedCheck.cpp clang-tidy/abseil/SafelyS

[PATCH] D60409: [clangd] Add -header-insertion=never flag to disable include insertion in code completion

MaskRay added a comment. In D60409#1461579 , @phosek wrote: > Our Mac builders have started failing after this change with the following: > > [3145/3502] Building CXX object > tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o >

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda updated this revision to Diff 194633. hintonda edited the summary of this revision. hintonda added a comment. - Fix bug in updateArgStr() where it didn't handle isInAllSubCommands() correctly, and refactored code based on how SubCommands work. Repository: rG LLVM Github Monorepo CHA

Re: r358104 - Don't emit an unreachable return block.

On 10 Apr 2019, at 21:50, wolfgang.p...@sony.com wrote: Hi, This commit seems to be causing a test failure on several buildbots (e.g. http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/26305). instrprof-shared-gcov-flush.test is failing because of differences in profile info.

r358151 - [OpenCL] Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

Author: alexeysotkin Date: Wed Apr 10 23:18:17 2019 New Revision: 358151 URL: http://llvm.org/viewvc/llvm-project?rev=358151&view=rev Log: [OpenCL] Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function Summary: https://reviews.llvm.org/D53809 fixed

[PATCH] D59985: [OpenCL] Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

This revision was automatically updated to reflect the committed changes. Closed by commit rL358151: [OpenCL] Re-fix invalid address space generation for clk_event_t arguments of… (authored by AlexeySotkin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Cha

r358152 - Add { } to silence compiler warning [NFC]

Author: uabelho Date: Wed Apr 10 23:57:12 2019 New Revision: 358152 URL: http://llvm.org/viewvc/llvm-project?rev=358152&view=rev Log: Add { } to silence compiler warning [NFC] At least clang 3.6 warns on the original code: ../tools/clang/lib/CodeGen/CGNonTrivialStruct.cpp:829:34: error: suggest

<    1   2