[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

kent08ian added a comment. In D10833#1405416 , @wipascal wrote: > In D10833#1394154 , @dyhe83 wrote: > > > In D10833#970906 , @milianw wrote: > > > > > still looks good to

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

gribozavr added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:728 - class RawCommentAndCacheFlags { + class CommentAndOrigin { public: `RawCommentAndOrigin`? Comment at: clang/include/clang/AST/ASTContext.h:751 -

[PATCH] D60257: [Lookup] Invisible decls should not be ambiguous when renaming.

hokein added inline comments. Comment at: unittests/Tooling/LookupTest.cpp:215 + + // Potentially ambiguous symbols that are not visible at reference location + // are not considered ambiguous. The test seems hard to understand what it actually does, could you

[PATCH] D59599: [clangd] Fix a crash while printing Template Arguments

kadircet abandoned this revision. kadircet added a comment. It is incorporated into D59639 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59599/new/ https://reviews.llvm.org/D59599

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

This revision was automatically updated to reflect the committed changes. Closed by commit rL358273: [clangd] Add TemplateArgumentList into Symbol (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59639: [clangd] Print template arguments helper

This revision was automatically updated to reflect the committed changes. Closed by commit rL358272: [clangd] Print template arguments helper (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses

This revision was automatically updated to reflect the committed changes. Closed by commit rL358274: [clangd] Show template argument list in workspacesymbols and documentsymbols… (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive

This revision was automatically updated to reflect the committed changes. Closed by commit rC358275: [clang-format] Use SpacesBeforeTrailingComments for option directive (authored by krasimir, committed by ). Changed prior to commit: https://reviews.llvm.org/D60541?vs=194595=194834#toc

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

hokein added a comment. Thanks, looks better now. I saw there are still a few undone comments, please mark them done when you address them. Comment at: docs/clang-tidy/checks/abseil-make-unique.rst:19 + +per the Abseil tips and guidelines at https://abseil.io/tips/126.

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

kadircet updated this revision to Diff 194820. kadircet marked 2 inline comments as done. kadircet added a comment. - Fill in the TemplateSpecializationArgs in all code paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59640/new/

r358276 - [Aarch64] Add v8.2-a half precision element extract intrinsics

Author: dnsampaio Date: Fri Apr 12 03:43:48 2019 New Revision: 358276 URL: http://llvm.org/viewvc/llvm-project?rev=358276=rev Log: [Aarch64] Add v8.2-a half precision element extract intrinsics Summary: Implements the intrinsics define on the ACLE to extract half precision fp scalar elements

[PATCH] D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses

kadircet updated this revision to Diff 194810. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59641/new/ https://reviews.llvm.org/D59641 Files: clang-tools-extra/clangd/FindSymbols.cpp

Re: [PATCH] D59605: [clangd] Introduce background-indexer

Replies inline. On Thu, Apr 11, 2019 at 7:59 PM Sam McCall wrote: > Thanks - I think there's quite a lot of background missing here: > Indeed, here are clarifications. > what/who is this for, > Building the index for clangd without actually running clangd it seems useful, e.g. for cases when

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60272/new/ https://reviews.llvm.org/D60272 ___

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL358276: [Aarch64] Add v8.2-a half precision element extract intrinsics (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/AST.cpp:112 if (!Out.str().empty()) { -// FIXME(ibiryukov): do

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

klimek added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:101 + SmallVector DefaultOptions; + A comment explaining what this contains and how it'll be used would help. Comment at: llvm/lib/Support/CommandLine.cpp:152 +

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:566 +printTemplateSpecializationArgs(ND); +S.TemplateSpecializationArgs = TemplateSpecializationArgs; if (Opts.StoreAllDocumentation) kadircet

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ilya-biryukov added a comment. Sorry for the delay. There seem to be a few changes that are unrelated to the actual patch. Could we separate various non-functional changes (moving code around, etc.) into a separate change to keep the diff for this one minimal? Comment at:

[PATCH] D60560: [clangd] Enable clang-tidy by default.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Yay! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60560/new/ https://reviews.llvm.org/D60560

[PATCH] D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive

krasimir added a comment. I'll merge this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60541/new/ https://reviews.llvm.org/D60541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

dnsampaio updated this revision to Diff 194826. dnsampaio marked 2 inline comments as done. dnsampaio added a comment. - Used clang-format-diff Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60272/new/ https://reviews.llvm.org/D60272 Files:

r358275 - [clang-format] Use SpacesBeforeTrailingComments for "option" directive

Author: krasimir Date: Fri Apr 12 03:11:34 2019 New Revision: 358275 URL: http://llvm.org/viewvc/llvm-project?rev=358275=rev Log: [clang-format] Use SpacesBeforeTrailingComments for "option" directive Summary: AnnotatingParser::next() is needed to implicitly set TT_BlockComment versus

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Core/Diagnostic.h:67-71 + // Get the chosen fix to apply for this diagnostic. + // FIXME: currently we choose the first non-empty fix, extend it to support + // fix selection. + const llvm::StringMap

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

hokein updated this revision to Diff 194817. hokein marked an inline comment as done. hokein added a comment. Update and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59932/new/ https://reviews.llvm.org/D59932 Files:

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59640/new/ https://reviews.llvm.org/D59640

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

kadircet added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59640/new/ https://reviews.llvm.org/D59640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:566 +printTemplateSpecializationArgs(ND); +S.TemplateSpecializationArgs = TemplateSpecializationArgs; if (Opts.StoreAllDocumentation) Any reason

[PATCH] D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:112 if (!Out.str().empty()) { -// FIXME(ibiryukov): do not show args not explicitly written by the user. -if (auto *ArgList =

[clang-tools-extra] r358274 - [clangd] Show template argument list in workspacesymbols and documentsymbols responses

Author: kadircet Date: Fri Apr 12 03:09:37 2019 New Revision: 358274 URL: http://llvm.org/viewvc/llvm-project?rev=358274=rev Log: [clangd] Show template argument list in workspacesymbols and documentsymbols responses Summary: Last part of re-landing rC356541. Puts TemplateArgumentsList into

[clang-tools-extra] r358273 - [clangd] Add TemplateArgumentList into Symbol

Author: kadircet Date: Fri Apr 12 03:09:24 2019 New Revision: 358273 URL: http://llvm.org/viewvc/llvm-project?rev=358273=rev Log: [clangd] Add TemplateArgumentList into Symbol Summary: Part of re-landing rC356541 with D59599. Changes the way we store template arguments, previous patch was

r358272 - [clangd] Print template arguments helper

Author: kadircet Date: Fri Apr 12 03:09:14 2019 New Revision: 358272 URL: http://llvm.org/viewvc/llvm-project?rev=358272=rev Log: [clangd] Print template arguments helper Summary: Prepares ground for printing template arguments as written in the source code, part of re-landing rC356541 with

[clang-tools-extra] r358272 - [clangd] Print template arguments helper

Author: kadircet Date: Fri Apr 12 03:09:14 2019 New Revision: 358272 URL: http://llvm.org/viewvc/llvm-project?rev=358272=rev Log: [clangd] Print template arguments helper Summary: Prepares ground for printing template arguments as written in the source code, part of re-landing rC356541 with

Re: r357340 - Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps.

Hi Nico, yes, you are right, current implementation is mostly focused on frontend. Yes, I can impove BE time output after getting feedback like yours one. Do you need detailed info about BE passes times? Btw, did you try -ftime-report option? It could give you detailed info on BE passes

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 194811. saar.raz marked 3 inline comments as done. saar.raz added a comment. Moved from getLocStart, getLocEnd to getBeginLoc, getEndLoc. Rebase onto master/trunk. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41217/new/

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:566 +printTemplateSpecializationArgs(ND); +S.TemplateSpecializationArgs = TemplateSpecializationArgs; if

[PATCH] D60620: [HIP] Support -offloading-target-id

tra added a subscriber: arsenm. tra added a comment. @arsenm Matt, FYI, this patch seems to be a continuation of D59863 you've commented on. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60620/new/ https://reviews.llvm.org/D60620

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric marked an inline comment as done. ioeric added inline comments. Comment at: clangd/TUScheduler.cpp:552 +const tooling::CompileCommand ::getCurrentCompileCommand() const { + return FileInputs.CompileCommand; +} ilya-biryukov wrote: > ioeric wrote: > >

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expression.

riccibruno added a comment. Friendly ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58579/new/ https://reviews.llvm.org/D58579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clangd] Print template arguments helper

Thanks Bruno, sent out rL358293 to address the issue. On Fri, Apr 12, 2019 at 5:21 PM Bruno Ricci wrote: > Hi, > > It seems that one of r358272, r358273 or r358274 is causing some asan > failure on my machine. Not sure why it is not spotted by the bots. > > Failure log attached. > > Bruno >

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:552 +const tooling::CompileCommand ::getCurrentCompileCommand() const { + return FileInputs.CompileCommand; +} ioeric wrote: > ilya-biryukov wrote: > > ioeric wrote: > > > ilya-biryukov

[PATCH] D40577: Clang support for simd functions

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9615 + + std::string Buffer; + if (Fn->hasFnAttribute("vector-variants")) { 1. Why this change is required? 2. Why not a `SmallString`? Comment at:

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric created this revision. ioeric added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, javed.absar. Herald added a project: clang. This makes addDocument non-blocking and would also allow code completion (in fallback mode) to

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric added inline comments. Comment at: clangd/TUScheduler.cpp:338 + Barrier(Barrier), Done(false) { + FileInputs.CompileCommand = CDB.getFallbackCommand(FileName); +} ilya-biryukov wrote: > The command is filled with a fallback by `ClangdServer`, right?

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric updated this revision to Diff 194850. ioeric marked 7 inline comments as done. ioeric added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60607/new/ https://reviews.llvm.org/D60607 Files:

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric updated this revision to Diff 194851. ioeric added a comment. - Add missing comment to TUScheduler.h Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60607/new/ https://reviews.llvm.org/D60607 Files: clangd/ClangdServer.cpp

r358288 - [AST][NFC] Add const children() accessors to all AST nodes

Author: brunoricci Date: Fri Apr 12 08:36:02 2019 New Revision: 358288 URL: http://llvm.org/viewvc/llvm-project?rev=358288=rev Log: [AST][NFC] Add const children() accessors to all AST nodes Systematically add the const-qualified version of children() to all statement/expression nodes.

[PATCH] D60029: Add const children() accessors to all AST nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358288: [AST][NFC] Add const children() accessors to all AST nodes (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D60029?vs=193288=194897#toc Repository:

r358290 - [HIP] Use -mlink-builtin-bitcode to link device library

Author: yaxunl Date: Fri Apr 12 09:23:31 2019 New Revision: 358290 URL: http://llvm.org/viewvc/llvm-project?rev=358290=rev Log: [HIP] Use -mlink-builtin-bitcode to link device library Use -mlink-builtin-bitcode instead of llvm-link to link device library so that device library bitcode and user

[clang-tools-extra] r358293 - [clangd] Fix an overflow inside a test

Author: kadircet Date: Fri Apr 12 09:40:54 2019 New Revision: 358293 URL: http://llvm.org/viewvc/llvm-project?rev=358293=rev Log: [clangd] Fix an overflow inside a test Modified: clang-tools-extra/trunk/unittests/clangd/PrintASTTests.cpp Modified:

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:80 +// \endcode +struct TextChange { + // The (bound) id of the node whose source will be replaced. This id should ymandel wrote: > ilya-biryukov wrote: > >

[PATCH] D60620: [HIP] Support -offloading-target-id

tra added a subscriber: echristo. tra added a comment. It looks like you are solving two problems here. a) you want to create multiple device passes for the same GPU, but with different options. b) you may want to pass different compiler options to different device compilations. The patch

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda updated this revision to Diff 194899. hintonda added a comment. - Fix comments and add isDefaultOption per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746 Files:

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

compnerd added inline comments. Comment at: lld/ELF/InputFiles.cpp:662 } + case SHT_LLVM_DEPLIBS: { +if (Config->Relocatable) Can you make the flag here reflect the name as well? (`SHT_LLVM_DEPENDENT_LIBRARIES`) Comment at:

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:552 +const tooling::CompileCommand ::getCurrentCompileCommand() const { + return FileInputs.CompileCommand; +} ioeric wrote: > ilya-biryukov wrote: > > ioeric wrote: > > > ilya-biryukov

[PATCH] D40577: Clang support for simd functions

mmasten updated this revision to Diff 194917. mmasten added a comment. Rebased and updated test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40577/new/ https://reviews.llvm.org/D40577 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_simd_codegen.cpp Index:

Re: [clangd] Print template arguments helper

Hi, It seems that one of r358272, r358273 or r358274 is causing some asan failure on my machine. Not sure why it is not spotted by the bots. Failure log attached. Bruno FAIL: Extra Tools Unit Tests :: clangd/./ClangdTests/ASTUtilsTests/ASTUtils.PrintTemplateArgs/1 (878 of 1313)

[PATCH] D60620: [HIP] Support -offloading-target-id

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner, ashi1, scchan, t-tye. Herald added a subscriber: mgorny. This patch introduces a new option -offloading-target-id for HIP. Offloading target id is a generalization of CUDA/HIP GPU arch. It is a device name plus optional feature

[PATCH] D60513: [HIP] Use -mlink-builtin-bitcode to link device library

This revision was automatically updated to reflect the committed changes. Closed by commit rL358290: [HIP] Use -mlink-builtin-bitcode to link device library (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ilya-biryukov added a comment. In D60408#1464364 , @ymandel wrote: > I've done that as far as I can tell. Please let me know if I've missed > anything. Many thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60626: [clang] Aligned allocation is actually supported in macosx 10.13

ldionne created this revision. ldionne added a reviewer: ahatanak. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. In r350649, I changed aligned allocation from being available starting in macosx10.13 to macosx10.14. However, aligned allocation is indeed

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 194921. ztamas added a comment. Updated the code based on reviewer comments: - Alphabetical order in `BugproneTidyModule.cpp` - Handling of `auto_ptr` - Test cases for template classes (I made the check ignore these case otherwise this can lead to false

[PATCH] D40577: Clang support for simd functions

mmasten marked 2 inline comments as done. mmasten added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9615 + + std::string Buffer; + if (Fn->hasFnAttribute("vector-variants")) { ABataev wrote: > 1. Why this change is required? > 2. Why not

[PATCH] D60560: [clangd] Enable clang-tidy by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358282: [clangd] Enable clang-tidy by default. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60029: Add const children() accessors to all AST nodes.

riccibruno added a comment. Sorry for the delay. Thanks a lot for the patch! Some of these casts are rather questionable. However this has nothing to do with your patch since you are just adding the const-qualified version of `children()`. Therefore I believe this patch looks good. Do you want

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 194886. ymandel added a comment. More code movement (putting things back). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/ https://reviews.llvm.org/D60408 Files:

[PATCH] D60316: [clangd] Include insertion: require header guards, drop other heuristics, treat .def like .inc.

ioeric requested changes to this revision. ioeric added a comment. This revision now requires changes to proceed. in case you missed this patch :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60316/new/ https://reviews.llvm.org/D60316

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. Herald added a subscriber: jsji. I don't think this is a suitable fix :-( There are lots of places where we construct command-lines in tests, it may be true today that this is

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ilya-biryukov added a comment. This is long overdue Comment at: clangd/TUScheduler.cpp:338 + Barrier(Barrier), Done(false) { + FileInputs.CompileCommand = CDB.getFallbackCommand(FileName); +} The command is filled with a fallback by `ClangdServer`,

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan updated this revision to Diff 194844. yvvan retitled this revision from "[clang-format] Introduce the flag which allows not to shrink lines" to "[clang-format] Create a new tool for IDEs based on clang-format". yvvan edited the summary of this revision. yvvan added a reviewer: arphaman.

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. Use native llvm JSON library update: https://reviews.llvm.org/D60609 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 ___ cfe-commits mailing

r358283 - [AST] Forbid copy/move of statements/types

Author: brunoricci Date: Fri Apr 12 06:26:55 2019 New Revision: 358283 URL: http://llvm.org/viewvc/llvm-project?rev=358283=rev Log: [AST] Forbid copy/move of statements/types Statements, expressions and types are not supposed to be copied/moved, and trying to do so is only going to result in

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon updated this revision to Diff 194878. Fznamznon added a comment. Applied comments from @aaron.ballman and @keryell - Introduce a C++11 and C2x style spelling in the clang namespace I didn't find path to add two namespaces to attribute (like [[clang::sycl::device]] so

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

sammccall created this revision. sammccall added reviewers: ilya-biryukov, hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, mgorny. Herald added a project: clang. The existing implementation (which triggers on }) is fairly simple and has flaws: -

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

mstorsjo added a comment. In D60417#1459249 , @mstorsjo wrote: > Given that, the suggested form of this patch is indeed correct - sorry for > the noise. > > I can commit the patch for you, but I'd need approval by either of @EricWF, > @ldionne or

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

sammccall updated this revision to Diff 194855. sammccall added a comment. Unit tests. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60605/new/ https://reviews.llvm.org/D60605 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: test/CXX/basic/basic.lookup/basic.lookup.argdep/p2-associated-namespaces-classes.cpp:304 +static_assert(f(g3) == 4, "");// FIXME: Also well-formed from the union rule. +

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric updated this revision to Diff 194891. ioeric marked 5 inline comments as done. ioeric added a comment. - address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60607/new/ https://reviews.llvm.org/D60607 Files:

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric added inline comments. Comment at: clangd/TUScheduler.cpp:338 + Barrier(Barrier), Done(false) { + FileInputs.CompileCommand = CDB.getFallbackCommand(FileName); +} ilya-biryukov wrote: > ioeric wrote: > > ilya-biryukov wrote: > > > The command is

r358285 - [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

Author: pgousseau Date: Fri Apr 12 07:14:58 2019 New Revision: 358285 URL: http://llvm.org/viewvc/llvm-project?rev=358285=rev Log: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract. Disabled by default as this is still an experimental feature.

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:338 + Barrier(Barrier), Done(false) { + FileInputs.CompileCommand = CDB.getFallbackCommand(FileName); +} ioeric wrote: > ilya-biryukov wrote: > > The command is filled with a fallback

[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358285: [asan] Add gcc 8s driver option -fsanitize=pointer-compare and… (authored by pgousseau, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

pgousseau marked an inline comment as done. pgousseau added inline comments. Comment at: test/Driver/fsanitize.c:837 +// RUN: %clang -target x86_64-linux-gnu -fsanitize=pointer-compare -fno-sanitize=pointer-compare %s -### 2>&1 | FileCheck %s

Re: r357340 - Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps.

I haven't tried -ftime-report here. I tried it in the past and found it difficult to interpret, as the blog post you link to correctly says :) I thought -ftime-trace was supposed to be more usable, so I figured I'd try that instead. And for frontend stuff, it does look much better! Ideas on how

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

AlexEichenberger requested changes to this revision. AlexEichenberger added a comment. This revision now requires changes to proceed. see note above; apologies if it is already done and hiding somewhere I did not see Comment at: lib/CodeGen/CGOpenMPRuntime.h:641 + ///

[PATCH] D60123: [AST] Forbid copy/move of statements/types.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358283: [AST] Forbid copy/move of statements/types (authored by brunoricci, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60123/new/

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 194887. ymandel added a comment. Final code shifting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/ https://reviews.llvm.org/D60408 Files: clang/include/clang/Tooling/Refactoring/Transformer.h

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel added a comment. In D60408#1463909 , @ilya-biryukov wrote: > Sorry for the delay. > There seem to be a few changes that are unrelated to the actual patch. Could > we separate various non-functional changes (moving code around, etc.) into a >

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 194883. ymandel marked 2 inline comments as done. ymandel added a comment. Restore code ordering for unrelated code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/ https://reviews.llvm.org/D60408

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

bader accepted this revision. bader added inline comments. Comment at: clang/test/SemaSYCL/device-attributes-on-non-sycl.cpp:5 + +#if defined(EXPECT_WARNINGS) +// expected-warning@+8 {{'sycl_kernel' attribute ignored}} I think you can use `__SYCL_DEVICE_ONLY__`

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:473 + /// atomic_default_mem_order seq_cst clause. + OMP_REQ_ATOMIC_DEFAULT_SEQ_CST = 0x008, + /// atomic_default_mem_order acq_rel clause. YOu don't need al these flags, add only

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

Quuxplusone added inline comments. Comment at: test/CXX/basic/basic.lookup/basic.lookup.argdep/p2-associated-namespaces-classes.cpp:304 +static_assert(f(g3) == 4, "");// FIXME: Also well-formed from the union rule. + //

[PATCH] D60257: [Lookup] Invisible decls should not be ambiguous when renaming.

ioeric updated this revision to Diff 194841. ioeric marked 2 inline comments as done. ioeric added a comment. - Add test comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60257/new/ https://reviews.llvm.org/D60257 Files:

[PATCH] D60257: [Lookup] Invisible decls should not be ambiguous when renaming.

ioeric added inline comments. Comment at: unittests/Tooling/LookupTest.cpp:215 + + // Potentially ambiguous symbols that are not visible at reference location + // are not considered ambiguous. hokein wrote: > The test seems hard to understand what it actually

[clang-tools-extra] r358282 - [clangd] Enable clang-tidy by default.

Author: hokein Date: Fri Apr 12 06:07:48 2019 New Revision: 358282 URL: http://llvm.org/viewvc/llvm-project?rev=358282=rev Log: [clangd] Enable clang-tidy by default. Summary: We have turned on the flag internally for a while, and we don't receive complains. Should be good to turn it on now.

[PATCH] D60029: Add const children() accessors to all AST nodes.

nicolas added a comment. Yes, thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60029/new/ https://reviews.llvm.org/D60029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

NoQ added a comment. This new approach is clearly useful to other checkers as well, not only the Taint checker. I believe we should strongly consider generalizing it somehow, it's just too awesome to restrict to a single checker. There's also a closely related technology called "API Notes"

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ added inline comments. Comment at: docs/analyzer/checkers.rst:225-226 +``std::string``s, by recognizing member functions that may re/deallocate the buffer +before use. In the future, it would be great to add support for other STL and +non-STL containers, and most notably,

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 194995. stephanemoore added a comment. Update check to avoid emitting a fix if the expression is in a macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59806/new/ https://reviews.llvm.org/D59806

Buildbot numbers for the week of 03/24/2019 - 03/30/2019

Hello everyone, Below are some buildbot numbers for the week of 03/24/2019 - 03/30/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

  1   2   >