[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

ilya-biryukov added a comment. I guess using `Edit Related Object -> Edit Commits` should do the trick. I'm not sure what the "Lean Into Action" is either. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

svenvh added a comment. In D53023#1499942 , @AlexeySotkin wrote: > LGTM! @joey, any idea when it will be landed? This work is being continued in https://reviews.llvm.org/D60763 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53023/new/

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

umanwizard added a comment. Ignore me. I didn't read the previous discussion before commenting. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61724/new/ https://reviews.llvm.org/D61724 ___ cfe-commits mailing list

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

gamesh411 marked an inline comment as done. gamesh411 added a comment. I could greatly simplify the API of getCrossTUDefinition by injecting the threshold value in the constructor. A minor drawback with this approach is that testing code is a bit more complicated, as I had to patch the

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

jdoerfert added a comment. Two small changes and then it is fine with me. @tra ? 1. we need to use ifdef to not define clock 2. Can you switch the include order in `test/Headers/nvptx_device_math_functions.cpp`? P.S. I'm currently at the OpenMP standard meeting to get the OpenMP variants

[PATCH] D61804: Support building shared and static libraries simultaneously

tstellar added a comment. Not sure if this would be relevant for your use case, but it would be really nice to have a libCLANG.so with all the C++ symbols, like we do for llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61804/new/

[PATCH] D61804: Support building shared and static libraries simultaneously

beanz added a comment. In D61804#1499275 , @winksaville wrote: > When you say you don't think the build system should do this, what do you > mean? `llvm_add_library` supports both, because there are places where we consciously choose to build both.

[PATCH] D61858: Make `__is_base_of` more friendly with unions

mclow.lists created this revision. mclow.lists added reviewers: rsmith, t.p.northover, EricWF, ldionne. mclow.lists added a project: clang. Herald added a subscriber: dexonsmith. Unions are never base classes, and never have base classes. It doesn't matter if they are complete or not. See

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong added a comment. @aprantl Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r360539 - make -ftime-trace also print template arguments

Author: llunak Date: Sun May 12 03:39:21 2019 New Revision: 360539 URL: http://llvm.org/viewvc/llvm-project?rev=360539=rev Log: make -ftime-trace also print template arguments Without this, I get e.g. 'PerformPendingInstantiations' -> 'std::fill', now I get 'std::fill'. Differential Revision:

Re: r360559 - [c++20] P1064R0: Allow virtual function calls in constant expression

Here's a creduced repro: -- class a {}; class b : virtual a { virtual bool c(const void *, int); }; class C : b { public: bool c(const void *, int); }; int d; bool e() { C f; if (f.c(, d)) ; } -- $ clang.bad -cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -std=c++14 a.cc The

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

dkrupp added a comment. In D57858#1499414 , @Szelethus wrote: > In D57858#1498640 , @NoQ wrote: > > > So, like, the global picture is as follows. In our case the Driver (i.e., > > --analyze) is not much more user

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

gamesh411 updated this revision to Diff 199278. gamesh411 added a comment. Revert unnecessary clang-formating of AnalysisConsumer.cpp Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59798/new/ https://reviews.llvm.org/D59798 Files:

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

AlexeySotkin added a comment. LGTM! @joey, any idea when it will be landed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53023/new/ https://reviews.llvm.org/D53023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet added a comment. In D61634#1498376 , @efriedma wrote: > I still think there are really two things you're trying to accomplish here, > which should be handled separately. > > 1. Add a function attribute that works like -fno-builtin-memcpy

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 

aaron.ballman added reviewers: klimek, alexfh. aaron.ballman added a comment. Adding some more AST matcher reviewers to see if there are other options that we've not considered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60543/new/

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. @compnerd Any other test cases you'd like before the first drop? @jakehehrlich @rupprecht Do things here look good to you guys? Both formats are marked experimental, I plan to work on a merge action next. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

umanwizard added inline comments. Comment at: clang-tools-extra/trunk/clangd/index/Background.cpp:164 stop(); - for (auto : ThreadPool) -Thread.join(); + ThreadPool.wait(); } This is already called in `~AsyncTaskRunner`. Repository: rL LLVM

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3885 + if (ArgNo) { +auto *PD = dyn_cast(VD); +ParmCache[PD].reset(D); A `dyn_cast` followed by an unconditional use seems strange. I would expect either a `cast` or an `if (PD)`

[PATCH] D59465: [analyzer] Add a test plugin for checker option handling

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

vsapsai added a comment. In D61621#1497027 , @rnk wrote: > lgtm, thanks! > > In D61621#1496978 , @vsapsai wrote: > > > Didn't use `-fms-compatibility` in the test and it seems to be working fine. > > Don't know if

r360626 - [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

Author: gbercea Date: Mon May 13 15:11:44 2019 New Revision: 360626 URL: http://llvm.org/viewvc/llvm-project?rev=360626=rev Log: [OpenMP][Clang][BugFix] Split declares and math functions inclusion. Summary: This patches fixes an issue in which the __clang_cuda_cmath.h header is being included

[PATCH] D61804: Support building shared and static libraries simultaneously

winksaville added a comment. @beanz I found what I think is the reason libclang_shared.so isn't being created. I added a bunch of debug output using `message` to add_llvm_subdirectory: 1041 function(add_llvm_subdirectory project type name) 1042message(STATUS "add_llvm_subdirectory

Buildbot numbers for the week of 05/05/2019 - 05/11/2019

Hello everyone, Below are some buildbot numbers for the last week of 05/05/2019 - 05/11/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Below are some buildbot numbers for the week of 04/28/2019 - 05/04/2019

Hello everyone, Below are some buildbot numbers for the week of 04/28/2019 - 05/04/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot cleaning for github migration

Hello everyone, As all of you know, we migrate to github monorepo. I'm working on preparing the build bot for this transition. We would do our best to make the transition as smooth and transparent to the majority of LLVM community, as possible. As the next step, I'll be cleaning zorg. I'm

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 199358. trixirt added a comment. llvm-header-guard is an alias to bugprone-header-guard. The style is passed through the option 'GuardStyle' A regression test was added for llvm-header-guard. llvm unit tests were modified to the new class and option

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 added a comment. Yes, the ABI bug will cause SEGV in Linux where a lot of libraries are built by GCC. I have restricted the fix to Linux only in the latest revision. Any other comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748

r360630 - [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

Author: vsapsai Date: Mon May 13 15:40:11 2019 New Revision: 360630 URL: http://llvm.org/viewvc/llvm-project?rev=360630=rev Log: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`. Currently `immintrin.h` includes `pconfigintrin.h` and `sgxintrin.h` which contain

[PATCH] D61845: [builtin] Fixed definitions of builtins that rely on the int/long long type is 32/64 bits

efriedma added a comment. Adding "Z" makes sense. If you're going to mess with the 64-bit builtins, it's probably worth adding a testcase that can be built with gcc to show that int64_t is actually correct. You should be able to write a C++ testcase using decltype (declare a variable of type

[PATCH] D61845: [builtin] Fixed definitions of builtins that rely on the int/long long type is 32/64 bits

efriedma added inline comments. Comment at: test/CodeGen/avr-builtins.c:1 +// REQUIRES: avr-registered-target +// RUN: %clang_cc1 -triple avr-unknown-unknown -emit-llvm -o - %s | FileCheck %s I don't think this needs avr-registered-target; it doesn't actually

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka created this revision. Herald added subscribers: llvm-commits, cfe-commits, jfb, dexonsmith, steven_wu, modocache, hiraditya, eraman, mgorny, mehdi_amini. Herald added projects: clang, LLVM. vitalybuka planned changes to this revision. I don't want to invest into improving this patch.

r360625 - Make language option `GNUAsm` discoverable with `__has_extension` macro.

Author: vsapsai Date: Mon May 13 15:11:10 2019 New Revision: 360625 URL: http://llvm.org/viewvc/llvm-project?rev=360625=rev Log: Make language option `GNUAsm` discoverable with `__has_extension` macro. This can be used for better support of `-fno-gnu-inline-asm` builds. rdar://problem/49540880

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. In D57858#1500635 , @NoQ wrote: > In D57858#146 , @dkrupp wrote: > > > Some alpha checkers are considerably more mature than others and are quite > > usable. In our experience, there

r360634 - [AMDGPU] gfx1010 clang target

Author: rampitec Date: Mon May 13 16:15:59 2019 New Revision: 360634 URL: http://llvm.org/viewvc/llvm-project?rev=360634=rev Log: [AMDGPU] gfx1010 clang target Differential Revision: https://reviews.llvm.org/D61875 Modified: cfe/trunk/docs/ClangCommandLineReference.rst

r360635 - [c++20] P1064R0: Allow virtual function calls in constant expression

Author: rsmith Date: Mon May 13 16:35:21 2019 New Revision: 360635 URL: http://llvm.org/viewvc/llvm-project?rev=360635=rev Log: [c++20] P1064R0: Allow virtual function calls in constant expression evaluation. This reinstates r360559, reverted in r360580, with a fix to avoid crashing if

r360637 - PR41817: Fix regression in r359260 that caused the MS compatibility

Author: rsmith Date: Mon May 13 17:27:16 2019 New Revision: 360637 URL: http://llvm.org/viewvc/llvm-project?rev=360637=rev Log: PR41817: Fix regression in r359260 that caused the MS compatibility extension allowing a "static" declaration to follow an "extern" declaration to stop working. Added:

[PATCH] D61875: [AMDGPU] gfx1010 clang target

This revision was automatically updated to reflect the committed changes. Closed by commit rC360634: [AMDGPU] gfx1010 clang target (authored by rampitec, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 updated this revision to Diff 199360. wxiao3 edited the summary of this revision. Herald added a subscriber: krytarowski. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 Files: lib/CodeGen/TargetInfo.cpp

[PATCH] D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.

vsapsai added a comment. Thanks for the review, Aaron. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61619/new/ https://reviews.llvm.org/D61619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

stephanemoore accepted this revision. stephanemoore added a comment. I believe that all the feedback from @gribozavr has been addressed modulo one small nit. Once that nit has been addressed, I can land this. Comment at:

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

mwyman updated this revision to Diff 199338. mwyman added a comment. Update for comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61350/new/ https://reviews.llvm.org/D61350 Files: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360626: [OpenMP][Clang][BugFix] Split declares and math functions inclusion. (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61765?vs=199304=199340#toc

[PATCH] D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360625: Make language option `GNUAsm` discoverable with `__has_extension` macro. (authored by vsapsai, committed by ). Herald added a project: clang. Changed prior to commit:

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

stephanemoore requested changes to this revision. stephanemoore marked an inline comment as done. stephanemoore added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp:112 +

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360630: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

mwyman updated this revision to Diff 199341. mwyman added a comment. Added +new declaration for ProxyFoo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61350/new/ https://reviews.llvm.org/D61350 Files: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp

[PATCH] D61136: [Analyzer] Refactor begin and end symbol creation

NoQ accepted this revision. NoQ added a comment. Thx! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61136/new/ https://reviews.llvm.org/D61136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r360628 - Removing an unused member variable; NFC.

Author: aaronballman Date: Mon May 13 15:29:16 2019 New Revision: 360628 URL: http://llvm.org/viewvc/llvm-project?rev=360628=rev Log: Removing an unused member variable; NFC. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h URL:

[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

NoQ added a comment. > Note that a similar functionality is necessary for destructors of virtual > bases, but it remains to be done for now. We should be able to re-use the > same terminator kind. It's not really that important because virtual base destructors don't have sub-expressions that

[PATCH] D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses.

NoQ updated this revision to Diff 199351. NoQ added a comment. Improve note text so that to avoid the singular/plural problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61817/new/ https://reviews.llvm.org/D61817 Files:

[PATCH] D61804: Support building shared and static libraries simultaneously

tstellar added a comment. > ! In D61804#149 , @beanz wrote: > I apologize that I missed your thread on the dev list, because that would > have been a much better place to have this conversation. Having gone back and > read it now, it sounds to me

[PATCH] D61804: Support building shared and static libraries simultaneously

MaskRay added a comment. @winksaville I asked why on Arch Linux, extra/clang is built with `-DBUILD_SHARED_LIBS=ON` while extra/llvm extra/lldb are built with `-DBUILD_SHARED_LIBS=ON` https://bugs.archlinux.org/task/60512 . I think `extra/clang` is just not suitable for development. If you

<    1   2