[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

a_sidorin added a comment. Hi Gabor, This looks fine, but could you please add a test showing how decl shadowing is handled? I.e. if we have Arg in one TU and both Arg and N::Arg in another TU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. > I guess my comment was that you patche introduces a lot of code duplication, > could the small amount of code you added be say put into a lambda and past in > based on style? Yes, I will add that and submit a patch soon. Repository: rC Clang CHANGES SINCE

[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

balazske added a comment. The problem is already corrected in clang9 but maybe not in clang8. Something similar is fixed in https://reviews.llvm.org/rC357329. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64628/new/ https://reviews.llvm.org/D64628

[PATCH] D64477: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest.

balazske updated this revision to Diff 209768. balazske added a comment. - Change to Lang_CXX14. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64477/new/ https://reviews.llvm.org/D64477 Files: unittests/AST/ASTImporterVisibilityTest.cpp Index:

[PATCH] D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:36 +// must be deduplicated. +std::sort(Tokens.begin(), Tokens.end()); +for (unsigned I = 1; I < Tokens.size(); ++I) {

[PATCH] D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists

jvikstrom updated this revision to Diff 209775. jvikstrom added a comment. Removed return type hint for lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64634/new/ https://reviews.llvm.org/D64634 Files:

[PATCH] D64677: [SemaTemplate] Fix uncorrected typos after pack expansion

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:622 << Pattern->getSourceRange(); +CorrectDelayedTyposInExpr(Pattern); return ExprError(); kadircet wrote: > why not

Re: r365954 - Reland [clang] DirectoryWatcher

Hi Jan, > +elseif(CMAKE_SYSTEM_NAME MATCHES "Linux") > + check_include_files("sys/inotify.h" HAVE_INOTIFY) > + if(HAVE_INOTIFY) > +list(APPEND DIRECTORY_WATCHER_SOURCES linux/DirectoryWatcher-linux.cpp) > +find_package(Threads REQUIRED) > + endif() I don't think the above is

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

rkgibson2 added a comment. I don't think I have commit access. Could someone land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 ___ cfe-commits

[PATCH] D64477: [ASTImporter] Using Lang_CXX11 in ASTImporterVisibilityTest.

balazske added a comment. Probably change to CXX14? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64477/new/ https://reviews.llvm.org/D64477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64624: [clangd] Added highlighting to enum constants.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:257 + case HighlightingKind::EnumConstant: +return "constant.other.enum.cpp"; case HighlightingKind::Namespace:

[clang-tools-extra] r366045 - [clangd] Added highlighting to enum constants.

Author: jvikstrom Date: Mon Jul 15 00:41:12 2019 New Revision: 366045 URL: http://llvm.org/viewvc/llvm-project?rev=366045=rev Log: [clangd] Added highlighting to enum constants. Summary: VSCode does not have a scope for enum constants. So they were placed under "constant.other.enum" as that

[PATCH] D64624: [clangd] Added highlighting to enum constants.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366045: [clangd] Added highlighting to enum constants. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

rkgibson2 updated this revision to Diff 209777. rkgibson2 added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D64617: [clangd] Added highlighting for members and methods

This revision was automatically updated to reflect the committed changes. Closed by commit rL366047: [clangd] Added highlighting for members and methods. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added inline comments. Comment at: unittests/Format/SortIncludesTest.cpp:709 + "#include \"pathnames.h\"\n", + sort("#include \n" + "#include \n" MyDeveloperDay wrote: > should you add a test which has groups

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 209776. Manikishan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: include/clang/Format/Format.h lib/Format/Format.cpp Index:

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64712 Files:

[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

martong added a comment. In D64628#1584969 , @balazske wrote: > The mentioned commit has a test that reproduces the same problem, so this > revision is not needed (abandon it?). I think we should have this change, because it tests also if we can import

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

Anastasia added a comment. In D64083#1583110 , @rjmccall wrote: > In D64083#1583109 , @rjmccall wrote: > > > Okay, so it sounds like *from the language perspective* all block pointers > > are actually pointers

r366044 - [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

Author: maskray Date: Mon Jul 15 00:25:11 2019 New Revision: 366044 URL: http://llvm.org/viewvc/llvm-project?rev=366044=rev Log: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble gcc PowerPC supports 3 representations of long double: * -mlong-double-64 long double has the same

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

baloghadamsoftware added a comment. Hmm, I still fail to understand the problem with the current `VirtualCall` checker. Is it unstable? Does it report many false positives? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64274/new/ https://reviews.llvm.org/D64274

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

This revision was automatically updated to reflect the committed changes. Closed by commit rL366044: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r366047 - [clangd] Added highlighting for members and methods.

Author: jvikstrom Date: Mon Jul 15 01:12:21 2019 New Revision: 366047 URL: http://llvm.org/viewvc/llvm-project?rev=366047=rev Log: [clangd] Added highlighting for members and methods. Summary: Added highlighting for members and methods. Reviewers: hokein, sammccall, ilya-biryukov Subscribers:

[PATCH] D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists

jvikstrom updated this revision to Diff 209774. jvikstrom added a comment. Readded newline that was removed accidentaly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64634/new/ https://reviews.llvm.org/D64634 Files:

[PATCH] D64477: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest.

martong accepted this revision. martong added a comment. Does it really matter if it is CXX11 or CXX14, in the child patch we use a CXX11 using directive. Anyway, CXX14 is more future proof. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64477/new/

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia added a comment. In D62584#1583340 , @rjmccall wrote: > Oh, yes, it definitely can't be done to class types. I suppose we should > just forget about it. Ok, regarding address space qualifiers in template instantiation - is it still ok that

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

MyDeveloperDay added inline comments. Comment at: unittests/Format/SortIncludesTest.cpp:709 + "#include \"pathnames.h\"\n", + sort("#include \n" + "#include \n" should you add a test which has groups defined already, I'm

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

alexfh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/modernize-concat-nested-namespaces.h:1 +#pragma once + Please put the header under Inputs// directory to keep the tests directory a bit tidier. The header can then be renamed to

[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

balazske added a comment. The mentioned commit has a test that reproduces the same problem, so this revision is not needed (abandon it?). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64628/new/ https://reviews.llvm.org/D64628

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

MyDeveloperDay added a comment. In D64695#1584740 , @Manikishan wrote: > In D64695#1584706 , @MyDeveloperDay > wrote: > > > There also seems like alot of duplication between the existing > > sortCppIncludes > > >

[PATCH] D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists

jvikstrom updated this revision to Diff 209773. jvikstrom added a comment. Remove operator< and use std::unique. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64634/new/ https://reviews.llvm.org/D64634 Files:

[PATCH] D64415: Consistent types and naming for AArch64 target features (NFC)

peter.smith added a comment. FWIW I think this looks reasonable. The ARM equivalent uses bitfields such as unsigned CRC : 1; unsigned Crypto : 1; unsigned DSP : 1; unsigned Unaligned : 1; unsigned DotProd : 1; Which would make more sense than using unsigned for each individual field.

[PATCH] D59426: [PR41010][OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia added a comment. @rsmith, do you have any comments here? It would be quite useful to have this patch in Clang9. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59426/new/ https://reviews.llvm.org/D59426 ___ cfe-commits mailing

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: docs/LanguageExtensions.rst:1772 +``@_GLOBAL__sub_I_test.cl`` kernel to be enqueued. + + I think I should add something about dtors too. CHANGES SINCE LAST ACTION

r366059 - [OpenCL][PR41727] Prevent ICE on global dtors

Author: stulova Date: Mon Jul 15 04:58:10 2019 New Revision: 366059 URL: http://llvm.org/viewvc/llvm-project?rev=366059=rev Log: [OpenCL][PR41727] Prevent ICE on global dtors Pass NULL to pointer arg of __cxa_atexit if addr space is not matching with its param. This doesn't align yet with how

[PATCH] D64737: RISCV: Add support for floating point registers in inlineasm

simoncook created this revision. simoncook added a reviewer: asb. Herald added subscribers: cfe-commits, lenary, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, johnrusso,

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

Eugene.Zelenko added inline comments. Comment at: clang-tidy/bugprone/InfiniteLoopCheck.cpp:164 + + std::string Result = ""; + for (const Stmt *Child : Cond->children()) { Unnecessary initialization. See readability-redundant-string-init.

[PATCH] D64680: [analyzer] MallocChecker: Prevent Integer Set Library false positives

Charusso updated this revision to Diff 209849. Charusso added a comment. - Remove unnecessary `DoNothing` kind. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64680/new/ https://reviews.llvm.org/D64680 Files: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:323 while(a < ^1) -^a++; +[[a++]]; // do while SureYeaah wrote: > kadircet wrote: > > I thought extractor didn't handle this case(missing

[PATCH] D64680: [analyzer] MallocChecker: Prevent Integer Set Library false positives

Charusso marked 4 inline comments as done. Charusso added a comment. In D64680#1584315 , @NoQ wrote: > P.S. I think you should attach the report to Phabricator directly, as the > link will expire as soon as these reports get regenerated. Luckily the

[PATCH] D64742: Allow using -ftrivial-auto-var-init=zero in C mode without extra flags

glider created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Initially concerns have been raised that -ftrivial-auto-var-init=zero potentially defines a new dialect of C++, therefore this option was guarded with

[PATCH] D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM (I think @hokein 's comments were addressed too) > So it seems to be expected. (and looking at the documentation for > InitListExpr it seems to be difficult to change

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah added a comment. In D64717#1585632 , @sammccall wrote: > In D64717#1585542 , @SureYeaah wrote: > > > In D64717#1585512 , @sammccall > > wrote: > > > > > Are you

[PATCH] D58710: Added more detailed documentation for clangd

kadircet added inline comments. Comment at: clang-tools-extra/trunk/docs/clangd/Installation.rst:325 + + $ ln -s ~/myproject/compile_commands.json ~/myproject-build/ + thakis wrote: > Isn't the order of the arguments the wrong way round here? yeah that seems to

[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

balazske added a comment. I do not know how the AST import is relevant in this case, the 'implicit' function is not imported here. The test does something similar as the mentioned one, only the reported problem is after the imported function. Repository: rC Clang CHANGES SINCE LAST ACTION

r366063 - [OpenCL] Deduce addr space for pointee of dependent types in instantiation.

Author: stulova Date: Mon Jul 15 06:02:21 2019 New Revision: 366063 URL: http://llvm.org/viewvc/llvm-project?rev=366063=rev Log: [OpenCL] Deduce addr space for pointee of dependent types in instantiation. Since pointee doesn't require context sensitive addr space deduction it's easier to handle

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 209844. SureYeaah marked 5 inline comments as done. SureYeaah added a comment. Removed unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:299 // return statement return ^1; } kadircet wrote: > left out this one ? Since that's an IntegerLiteral, this patch doesn't apply to it?

[PATCH] D64737: RISCV: Add support for floating point registers in inlineasm

simoncook added a comment. As an aside, I've noticed a codegen issue when using floating point clobber lists, resulting in the implicit-defs not being added to INLINEASM instructions. I'm working on a fix for that now and will submit a second patch shortly. Repository: rG LLVM Github

[PATCH] D64745: [clangd] BackgroundIndex stores shards to the closest project

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Changes persistance logic to store shards at the directory of closest CDB. Previously we were storing all shards

[PATCH] D64477: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest.

balazske added a comment. In D64477#1585092 , @martong wrote: > Does it really matter if it is CXX11 or CXX14, in the child patch we use a > CXX11 using directive. Anyway, CXX14 is more future proof. Later there should follow the test with variable

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

This revision was automatically updated to reflect the committed changes. Closed by commit rL366063: [OpenCL] Deduce addr space for pointee of dependent types in instantiation. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:299 // return statement return ^1; } SureYeaah wrote: > kadircet wrote: > > left out this one ? > Since that's an IntegerLiteral, this patch doesn't

[PATCH] D64646: [OPENMP]Add support for analysis of if clauses.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366068: [OPENMP]Add support for analysis of if clauses. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

sammccall added a comment. In D64717#1585682 , @SureYeaah wrote: > In D64717#1585632 , @sammccall wrote: > > > In D64717#1585542 , @SureYeaah > > wrote: > > > > > In

r366061 - [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest.

Author: balazske Date: Mon Jul 15 05:16:30 2019 New Revision: 366061 URL: http://llvm.org/viewvc/llvm-project?rev=366061=rev Log: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest. Summary: These tests may work with C++14 language constructs in the future (variable templates and

[PATCH] D64477: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366061: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Modified ExtractVariable to stop extraction for MemberExprs and Assignment Expr - Fixed unittests

[PATCH] D64718: [clangd] Triggering indexing on each translation unit with an error

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Background indexing triggers indexing only on the first TU that includes a stale dependency. This patch extends

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 209809. SureYeaah added a comment. Fixed comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong added a comment. In D61333#1583173 , @teemperor wrote: > @martong Sorry for the delay, feel free to ping me in the future about these > patches. I'll review them ASAP now that I'm back in office, so these delay's > hopefully won't happen again.

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

sammccall added a comment. Are you sure we want to disable extraction here, rather than just do the extraction at a higher level? E.g. if `bar(1,2,3, f[[o]]o(4,5));` seems like it should extract the call too `foo(4,5)`, not fail to trigger entirely. Comment at:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah added a comment. In D64717#1585512 , @sammccall wrote: > Are you sure we want to disable extraction here, rather than just do the > extraction at a higher level? > > E.g. if `bar(1,2,3, f[[o]]o(4,5));` seems like it should extract the call too

[PATCH] D64477: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest.

martong added a comment. In D64477#1585218 , @balazske wrote: > In D64477#1585092 , @martong wrote: > > > Does it really matter if it is CXX11 or CXX14, in the child patch we use a > > CXX11 using directive.

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:83 static bool isExtractableExpr(const clang::Expr *Expr) { if (Expr) { // FIXME: check if we need to cover any other types nit: Could you reduce

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:302 void f() { - int a = 5 + [[4 ^* ^xyz^()]]; + int a = 5 + [[4 * [[xyz(); // multivariable initialization kadircet wrote: > how come these

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: aaron.ballman, lebedev.ri, alexfh. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: gamesh411, whisperity, mgorny. Herald added a project: clang. Although detecting infinite loops in

[PATCH] D64608: [OpenCL] Make TableGen'd builtin tables and helper functions static

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64608/new/ https://reviews.llvm.org/D64608

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/InitLocalVariablesCheck.cpp:21 + Finder->addMatcher( + varDecl(unless(hasInitializer(anything(.bind("vardecl"), this); +} I believe, this should skip matches within template

[PATCH] D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists

ilya-biryukov added a comment. Have we tried figuring out why `RecursiveASTVisitor` visits the argument lists twice? Is that an expected behavior? Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:37 +llvm::sort(Tokens, + [](const

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah marked an inline comment as done. SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:323 while(a < ^1) -^a++; +[[a++]]; // do while kadircet wrote: > I thought extractor didn't

[PATCH] D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists

jvikstrom added a comment. In D64634#1585521 , @ilya-biryukov wrote: > Have we tried figuring out why `RecursiveASTVisitor` visits the argument > lists twice? Is that an expected behavior? The comment for the function that traverses initialization

r366068 - [OPENMP]Add support for analysis of if clauses.

Author: abataev Date: Mon Jul 15 07:46:23 2019 New Revision: 366068 URL: http://llvm.org/viewvc/llvm-project?rev=366068=rev Log: [OPENMP]Add support for analysis of if clauses. Summary: Added support for analysis of if clauses in the OpenMP directives to be able to check for the use of

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

This revision was automatically updated to reflect the committed changes. Closed by commit rL366059: [OpenCL][PR41727] Prevent ICE on global dtors (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 209814. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong updated this revision to Diff 209832. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Thanks for working on this! You want to use `clang/Analysis/Analyses/ExprMutationAnalyzer.h`. See also: D51870 Repository: rCTE Clang

[PATCH] D64739: [SVE][Inline-Asm] Add support to clang for SVE inline assembly

kmclaughlin created this revision. kmclaughlin added reviewers: erichkeane, sdesmalen, cfe-commits. Herald added subscribers: psnobl, rkruppe, tschuett, javed.absar. Herald added a reviewer: rengolin. Herald added a project: clang. Adds the SVE vector and predicate registers to the list of known

[PATCH] D64646: [OPENMP]Add support for analysis of if clauses.

ABataev marked an inline comment as done. ABataev added a comment. Thanks for the review! Comment at: test/Analysis/cfg-openmp.cpp:58-67 #pragma omp distribute simd for (int i = 0; i < 10; ++i) argc = x; -// CHECK-NEXT: 27: x -// CHECK-NEXT: 28: [B1.27]

[PATCH] D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists

jvikstrom updated this revision to Diff 209852. jvikstrom marked an inline comment as done. jvikstrom added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64634/new/ https://reviews.llvm.org/D64634 Files:

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom created this revision. jvikstrom added reviewers: hokein, sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Adds semantic highlighting for tokens that are a macro argument. Example: #define D_V(X) int

[PATCH] D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO"

sberg updated this revision to Diff 209865. sberg added a comment. - Disallowed -fsanitize=function in combination with -fsanitize-minimal-runtime now. - Left the ubsan test's RUN lines and \#include magic as-is, if there's no clearly better way to avoid this unfortunate complexity. CHANGES

[PATCH] D58710: Added more detailed documentation for clangd

thakis added inline comments. Comment at: clang-tools-extra/trunk/docs/clangd/Installation.rst:325 + + $ ln -s ~/myproject/compile_commands.json ~/myproject-build/ + Isn't the order of the arguments the wrong way round here? Repository: rL LLVM CHANGES

[PATCH] D64747: [clangd] Skip implicit nodes when traversing for highlightings

ilya-biryukov created this revision. ilya-biryukov added reviewers: jvikstrom, hokein. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Implicit code adds corner cases to handle and does not provide any value as those nodes cannot be mapped back to

[PATCH] D64747: [clangd] Skip implicit nodes when traversing for highlightings

ilya-biryukov abandoned this revision. ilya-biryukov added a comment. Ah, sorry, that's actually the default... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64747/new/ https://reviews.llvm.org/D64747

[clang-tools-extra] r366070 - [clangd] Fix duplicate highlighting tokens appearing in initializer lists.

Author: jvikstrom Date: Mon Jul 15 08:08:27 2019 New Revision: 366070 URL: http://llvm.org/viewvc/llvm-project?rev=366070=rev Log: [clangd] Fix duplicate highlighting tokens appearing in initializer lists. Summary: The RecursiveASTVisitor sometimes visits exprs in initializer lists twice. Added

[PATCH] D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists

This revision was automatically updated to reflect the committed changes. Closed by commit rL366070: [clangd] Fix duplicate highlighting tokens appearing in initializer lists. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r366062 - Fix uninitialized variable analyzer warning. NFCI.

Author: rksimon Date: Mon Jul 15 06:00:43 2019 New Revision: 366062 URL: http://llvm.org/viewvc/llvm-project?rev=366062=rev Log: Fix uninitialized variable analyzer warning. NFCI. Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImporter.cpp URL:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 209853. SureYeaah marked 2 inline comments as done. SureYeaah added a comment. Added comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64744: Loop #pragma tail_predicate

SjoerdMeijer created this revision. https://reviews.llvm.org/D64744 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Parse/Parser.h clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h clang/lib/Parse/ParsePragma.cpp clang/lib/Sema/SemaStmtAttr.cpp

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

sammccall added a comment. In D64717#1585542 , @SureYeaah wrote: > In D64717#1585512 , @sammccall wrote: > > > Are you sure we want to disable extraction here, rather than just do the > > extraction at a higher

[clang-tools-extra] r366073 - [clangd] Fix doc

Author: kadircet Date: Mon Jul 15 08:16:57 2019 New Revision: 366073 URL: http://llvm.org/viewvc/llvm-project?rev=366073=rev Log: [clangd] Fix doc Modified: clang-tools-extra/trunk/docs/clangd/Installation.rst Modified: clang-tools-extra/trunk/docs/clangd/Installation.rst URL:

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1585754 , @rdwampler wrote: > I am not quite sure why this change is required to sort the headers for > NetBSD, you can set the priorities via `IncludeStyle.IncludeCategories`. Is > that not sufficient? It can be

r366084 - Use unique_ptr instead of manual delete in one place. No behavior change.

Author: nico Date: Mon Jul 15 10:12:08 2019 New Revision: 366084 URL: http://llvm.org/viewvc/llvm-project?rev=366084=rev Log: Use unique_ptr instead of manual delete in one place. No behavior change. Modified: cfe/trunk/lib/Driver/Compilation.cpp Modified:

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

rdwampler added a comment. > Sorry, my mistake I meant that I have added Regex for priorities while > sorting and If I am not wrong I think IncludeCategories are used while > Regrouping after sorting the Includes. In addition to that in my case I have > to sort the includes In a particular

[PATCH] D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

Nathan-Huckleberry marked 3 inline comments as done. Nathan-Huckleberry added inline comments. Comment at: clang/test/Sema/warn-uninitialized-statement-expression.c:21 +struct widget z = my_widget; // expected-warning{{variable 'my_widget' is uninitialized when used within

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

manojgupta added a comment. @dankm are you still working on this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ cfe-commits mailing list

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 209922. SureYeaah added a comment. Added fix for selecting the callExpr of a MemberExpr/Function DeclRefExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:185 return true; return coin(); // tracking-note{{Returning value}} } NoQ wrote: > Szelethus wrote: > >

  1   2   3   >