[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. I think this looks reasonable to me, though I am still not certain if the relative path in the python script will work with both the svn in-tree directory layout as well as the git monorepo layout (which I'm far less familiar with). Repository: rG LLVM Github

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added reviewers: mehdi_amini, rnk. ro added a comment. Ping? It's been a week and it would be good to get this patch and its companion into LLVM 9: it unbreaks `make check-all` with gcc 9 and restores g++ compatibility. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

sammccall added a comment. As discussed offline, it's a little scary that the highlight state for diffing lives in a separate map from TUScheduler's workers, but it's hard to fix without introducing lots of abstractions or layering violations. It does seem like a good idea to move the diffing

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong added inline comments. Comment at: include/clang/AST/ASTImporter.h:234 +/// The ASTUnit that this importer belongs to, if any. +ASTUnit *Unit; + `Unit->getASTContext` must be equal to `FromContext`, right? Then `FromUnit` would be a better

[PATCH] D64744: Loop #pragma tail_predicate

SjoerdMeijer added a comment. Thanks for taking a look and your suggestions! I noticed your comment here after I replied to the list. As I wrote there, and long story short, I thought I could kill 2 birds with 1 stone, but that doesn't seem to be the case. I agree that for the vectorizer an

[PATCH] D64791: [OpenCL] Fix sampler initialization for C++ mode

neil.hickey created this revision. neil.hickey added a reviewer: Anastasia. Herald added a subscriber: yaxunl. Sampler initialization from integer literal was broken in C++ mode for OpenCL. Fixing to allow functions that take a sampler to take an integer and for samplers to be initialized to

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein added a comment. based on the offline discussion, now I understand the patch better (thanks). some comments on the interface. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:60 + PathRef File, + std::vector>> Highlightings) + override;

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

martong added a comment. Thank you Endre, this patch is a great initiative. However, I think we can do better encapsulation then just the reorganization of the functions: We could encapsulate into a nested class `NameASTUnitMap` and the functions which operate on this

[PATCH] D64791: [OpenCL] Fix sampler initialization for C++ mode

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I expect the example from the bug is going to compile now: https://bugs.llvm.org/show_bug.cgi?id=41009 Can you please close the bug after the commit.

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini marked 10 inline comments as done. mantognini added a comment. Mind the fact that I've rebased the changes onto a more recent master version. If you look at the diff of v1 against v2 you might see some unrelated changes. Let me know if there's anything else that I need to change.

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210045. SureYeaah added a comment. Fixed wrong function name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64775: [Format/ObjC] Avoid breaking between unary operators and ObjC method invocations

sammccall added a subscriber: klimek. sammccall added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2427-2428 return 50; + if (Left.is(TT_UnaryOperator) && Right.is(TT_ObjCMethodExpr)) +return 60; This looks a little suspicious

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 210079. jvikstrom added a comment. Moved highlighting state to LSP layer. Removed class holding state. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/

[PATCH] D64415: Consistent types and naming for AArch64 target features (NFC)

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. Going to commit as obvious. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64415/new/ https://reviews.llvm.org/D64415 ___ cfe-commits

[PATCH] D64129: [clang-scan-view] Force utf-8 when handling report (python2 only)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366194: [clang-scan-view] Force utf-8 when handling report (python2 only) (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

This revision was automatically updated to reflect the committed changes. Closed by commit rL366197: [AArch64] Implement __jcvt intrinsic from Armv8.3-A (authored by ktkachov, committed by ). Changed prior to commit: https://reviews.llvm.org/D64495?vs=209149=210051#toc Repository: rL LLVM

[PATCH] D64789: [clangd] Handle windows line endings in QueryDriver

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. fixes second case of https://github.com/clangd/clangd/issues/93 Repository: rG LLVM Github Monorepo

[PATCH] D64493: [Driver] Don't pass --dynamic-linker to ld on Solaris

theraven added a comment. I think this was simply mirroring what gcc 4.something did on Solaris. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64493/new/ https://reviews.llvm.org/D64493 ___ cfe-commits mailing list

[PATCH] D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2332 S->isSemanticForm() ? S->getSyntacticForm() : S, Queue)); TRY_TO(TraverseSynOrSemInitListExpr( S->isSemanticForm()

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

baloghadamsoftware marked 5 inline comments as done. baloghadamsoftware added a comment. In D64736#1585484 , @lebedev.ri wrote: > Thanks for working on this! > You want to use `clang/Analysis/Analyses/ExprMutationAnalyzer.h`. > See also: D51870

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong added inline comments. Comment at: include/clang/AST/ASTImporter.h:317 +std::shared_ptr SharedState = nullptr, +ASTUnit *Unit = nullptr); balazske wrote: > balazske wrote: > > martong wrote: > > > What if we provided an

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Szelethus added a comment. In D64454#1587102 , @aaron.ballman wrote: > I think this looks reasonable to me, though I am still not certain if the > relative path in the python script will work with both the svn in-tree > directory layout as well as the

[PATCH] D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals

ilya-biryukov updated this revision to Diff 210052. ilya-biryukov added a comment. - Add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64762/new/ https://reviews.llvm.org/D64762 Files: clang/include/clang/AST/RecursiveASTVisitor.h

[clang-tools-extra] r366199 - [clangd] Don't rebuild background index until we indexed one TU per thread.

Author: sammccall Date: Tue Jul 16 03:17:06 2019 New Revision: 366199 URL: http://llvm.org/viewvc/llvm-project?rev=366199=rev Log: [clangd] Don't rebuild background index until we indexed one TU per thread. Summary: This increases the odds that the boosted file (cpp file matching header) will be

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro created this revision. ro added reviewers: fedor.sergeev, rsmith, mehdi_amini, rnk. Herald added subscribers: kadircet, jrtc27, ilya-biryukov, mgorny, jyknight. Herald added a project: clang. `Builtins-*-sunos :: compiler_rt_logbf_test.c` currently FAILs on Solaris, both SPARC and x86, 32 and

r366194 - [clang-scan-view] Force utf-8 when handling report (python2 only)

Author: serge_sans_paille Date: Tue Jul 16 01:56:47 2019 New Revision: 366194 URL: http://llvm.org/viewvc/llvm-project?rev=366194=rev Log: [clang-scan-view] Force utf-8 when handling report (python2 only) Original patch by random human Differential Revision: https://reviews.llvm.org/D64129

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. On my system clang-format has some complaints, so I think you need to rerun clang-format. Probably caused by the rebasing. I have some minor comments about the TestAST.py (see

[PATCH] D64754: [clangd] Added highlighting for the targets in typedefs.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:88 + bool VisitTypedefDecl(TypedefDecl *TD) { +if(const auto *TSI = TD->getTypeSourceInfo()) Do we plan to support the type alias `using Y = X;` as well?

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia added a comment. In D62584#1586640 , @rjmccall wrote: > In D62584#1585091 , @Anastasia wrote: > > > In D62584#1583340 , @rjmccall > > wrote: > > > > > Oh, yes, it

r366200 - [SemaTemplate] Fix uncorrected typos after pack expansion

Author: sammccall Date: Tue Jul 16 03:30:21 2019 New Revision: 366200 URL: http://llvm.org/viewvc/llvm-project?rev=366200=rev Log: [SemaTemplate] Fix uncorrected typos after pack expansion Summary: This case is particularly important for clangd, as it is triggered after inserting the snippet for

[PATCH] D64677: [SemaTemplate] Fix uncorrected typos after pack expansion

This revision was automatically updated to reflect the committed changes. Closed by commit rL366200: [SemaTemplate] Fix uncorrected typos after pack expansion (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D64677?vs=209631=210057#toc Repository: rL

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge marked an inline comment as done. nridge added a comment. (Changed reviewer to Kadir as he reviewed the previous version.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613

[clang-tools-extra] r366207 - [clangd] Added highlighting for the targets in typedefs and using.

Author: jvikstrom Date: Tue Jul 16 06:23:12 2019 New Revision: 366207 URL: http://llvm.org/viewvc/llvm-project?rev=366207=rev Log: [clangd] Added highlighting for the targets in typedefs and using. Summary: In `typedef int A` the `A` was not highlighted previously. This patch gives `A` the same

[PATCH] D64754: [clangd] Added highlighting for the targets in typedefs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366207: [clangd] Added highlighting for the targets in typedefs and using. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong added inline comments. Comment at: include/clang/AST/ASTImporter.h:317 +std::shared_ptr SharedState = nullptr, +ASTUnit *Unit = nullptr); martong wrote: > balazske wrote: > > balazske wrote: > > > martong wrote: > > > >

r366197 - [AArch64] Implement __jcvt intrinsic from Armv8.3-A

Author: ktkachov Date: Tue Jul 16 02:27:39 2019 New Revision: 366197 URL: http://llvm.org/viewvc/llvm-project?rev=366197=rev Log: [AArch64] Implement __jcvt intrinsic from Armv8.3-A The jcvt intrinsic defined in ACLE [1] is available when ARM_FEATURE_JCVT is defined. This change introduces the

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong added inline comments. Comment at: include/clang/AST/ASTImporter.h:317 +std::shared_ptr SharedState = nullptr, +ASTUnit *Unit = nullptr); What if we provided an additional constructor where we take over the ASTUnits

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

ktkachov added a comment. In D64495#1587266 , @sammccall wrote: > FYI, this change broke git-llvm for everyone with a different username :-) > Fixed in r366198 Ah sorry, I accidentally included it in the commit! Repository: rL LLVM CHANGES SINCE

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia updated this revision to Diff 210064. Anastasia marked 5 inline comments as done. Anastasia added a comment. Addressed some review comments. Refs are still to be fixed! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 Files:

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/InitLocalVariablesCheck.cpp:21 + Finder->addMatcher( + varDecl(unless(hasInitializer(anything(.bind("vardecl"), this); +} jpakkane wrote: > alexfh wrote: > > I believe, this

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

baloghadamsoftware updated this revision to Diff 210070. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64736/new/ https://reviews.llvm.org/D64736 Files: clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini updated this revision to Diff 210080. mantognini added a comment. - Refactored common bits from CheckConstructorDeclarator and CheckDestructorDeclarator. - Added as many "ThisTy" parameter I could. - Addressed issue with identifier format in tests (%N to %var.ascast). Repository:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210047. SureYeaah added a comment. Fixed crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:164 +if(Loc.isMacroID()) { + // If the location is not an argument it might be from a macro of the form + // "#define VAR var". In that case this would highlight "var" in

[PATCH] D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a tiny nit. Comment at: clang-tools-extra/clang-tidy/readability/ConvertMemberFunctionsToStatic.cpp:110 + assert(TSI); + auto FTL =

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

sammccall added a comment. FYI, this change broke git-llvm for everyone with a different username :-) Fixed in r366198 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64495/new/ https://reviews.llvm.org/D64495 ___

[PATCH] D64712: [clangd][NFC] Refactor background-index shard loading

sammccall added a comment. So I've stared at this refactoring for a while, and I still don't totally get it. It seems like a class that really wants to be a function. It's a complicated function though - maybe a separate cpp file does make sense. We discussed moving ShardVersions and Writes

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske marked an inline comment as done. balazske added inline comments. Comment at: include/clang/AST/ASTImporter.h:317 +std::shared_ptr SharedState = nullptr, +ASTUnit *Unit = nullptr); martong wrote: > What if we provided

r366202 - [Driver] Don't pass --dynamic-linker to ld on Solaris

Author: ro Date: Tue Jul 16 04:06:43 2019 New Revision: 366202 URL: http://llvm.org/viewvc/llvm-project?rev=366202=rev Log: [Driver] Don't pass --dynamic-linker to ld on Solaris I noticed that clang currently passes --dynamic-linker to ld. This has been the case since Solaris 11 support was

[PATCH] D64493: [Driver] Don't pass --dynamic-linker to ld on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL366202: [Driver] Dont pass --dynamic-linker to ld on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia added inline comments. Comment at: docs/LanguageExtensions.rst:1673 + +All builtin operators will be available in the specific address spaces, thus no conversion +to generic is performed. mantognini wrote: > "specific" seems to imply to the user will

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske marked an inline comment as not done. balazske added inline comments. Comment at: include/clang/AST/ASTImporter.h:317 +std::shared_ptr SharedState = nullptr, +ASTUnit *Unit = nullptr); balazske wrote: > martong wrote: >

[PATCH] D64754: [clangd] Added highlighting for the targets in typedefs.

jvikstrom updated this revision to Diff 210053. jvikstrom added a comment. Add support for using `A = ...`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64754/new/ https://reviews.llvm.org/D64754 Files:

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

ilya-biryukov added a comment. How should this behave when if the same token is used multiple times inside a macro and the uses are different? Could we add this to tests? E.g. #define W(a) class a { void test() { int a = 10; } } W(foo); // <-- `foo` is a variable of a class? Repository:

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

boga95 updated this revision to Diff 210073. boga95 marked 11 inline comments as done. boga95 added a comment. Report diagnostic error in case of an invalid filename or an ill-formed yaml file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

ilya-biryukov created this revision. ilya-biryukov added reviewers: rnk, sammccall. Herald added a subscriber: kadircet. Herald added a project: clang. Instead of asserting all typos are corrected in the sema destructor. The sema destructor is not run in the common case of running the compiler

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia updated this revision to Diff 210101. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 Files: docs/LanguageExtensions.rst docs/UsersManual.rst Index: docs/UsersManual.rst

[PATCH] D64804: [OpenCL][Sema] Minor refactoring and constraint checking

mantognini created this revision. Herald added subscribers: cfe-commits, Anastasia, yaxunl. Herald added a project: clang. Simplify code a bit and add assertion to address post-landing comments from D64083 . Repository: rG LLVM Github Monorepo

[PATCH] D64644: Fixes an assertion failure while instantiation a template with an incomplete typo corrected type

Mordante updated this revision to Diff 210128. Mordante marked an inline comment as done. Mordante retitled this revision from "Fixes a clang frontend assertion failure (bug 35682)" to "Fixes an assertion failure while instantiation a template with an incomplete typo corrected type". Mordante

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

I get that CMake does something different for PRIVATE, but the way we use CMake in LLVM we really can't make a private distinction reasonable. Because we don't sub-divide our headers per library, we don't support per-dependency include paths in LLVM or Clang's libraries. This behavior also

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

glider added inline comments. Comment at: llvm/lib/Transforms/Scalar/DeadStoreEliminationExpGlobal.cpp:27 +static const char GlobalArgumentMemAccess[] = { +// grep -P -o "(?<=FUNCTION_INFO: ).*" | sort -u > +//

r366212 - [OpenCL] Fixing sampler initialisations for C++ mode.

Author: neil.hickey Date: Tue Jul 16 07:57:32 2019 New Revision: 366212 URL: http://llvm.org/viewvc/llvm-project?rev=366212=rev Log: [OpenCL] Fixing sampler initialisations for C++ mode. Allow conversions between integer and sampler type. Differential Revision: https://reviews.llvm.org/D64791

[PATCH] D64791: [OpenCL] Fix sampler initialization for C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL366212: [OpenCL] Fixing sampler initialisations for C++ mode. (authored by neil.hickey, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r366231 - fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

Author: yhs Date: Tue Jul 16 10:24:33 2019 New Revision: 366231 URL: http://llvm.org/viewvc/llvm-project?rev=366231=rev Log: fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic The original commit is r366076. It is temporarily reverted (r366155) due to test

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall added a comment. Minor comment then LGTM Comment at: lib/Sema/SemaType.cpp:7418 + // Expect for pointer or reference types because the addr space in + // template argument can only belong to a pointee. + (T->isDependentType() && !T->isPointerType() &&

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

Szelethus added a comment. Starting to look real good! Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:807 + "", + Released>, + ]>, We mark options that are not yet ready for used with `InAlpha`, rather then

r366211 - [OPENMP]Add support for analysis of if clauses.

Author: abataev Date: Tue Jul 16 07:51:46 2019 New Revision: 366211 URL: http://llvm.org/viewvc/llvm-project?rev=366211=rev Log: [OPENMP]Add support for analysis of if clauses. Summary: Added support for analysis of if clauses in the OpenMP directives to be able to check for the use of

[PATCH] D64765: [OPENMP]Add support for analysis of firstprivate variables.

ABataev updated this revision to Diff 210100. ABataev added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64765/new/ https://reviews.llvm.org/D64765 Files: include/clang/AST/OpenMPClause.h test/Analysis/cfg-openmp.cpp

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

aganea added a comment. Ping! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63648/new/ https://reviews.llvm.org/D63648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64644: Fixes an assertion failure while instantiation a template with an incomplete typo corrected type

lebedev.ri added inline comments. Comment at: clang/test/SemaTemplate/instantiate-incomplete-typo-suggested-error-limit.cpp:9-10 + +#include +#include + Please don't pull in any external headers - just mock what you need. CHANGES SINCE LAST ACTION

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

jdenny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61466/new/ https://reviews.llvm.org/D61466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64775: [Format/ObjC] Avoid breaking between unary operators and ObjC method invocations

benhamilton marked an inline comment as done. benhamilton added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2427-2428 return 50; + if (Left.is(TT_UnaryOperator) && Right.is(TT_ObjCMethodExpr)) +return 60; sammccall wrote: > This

[PATCH] D64801: [analyzer] Add CTU user docs

martong created this revision. martong added reviewers: dkrupp, a_sidorin, Szelethus, NoQ. Herald added subscribers: cfe-commits, Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang. Repository:

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet added a comment. In D61634#1586047 , @tejohnson wrote: > Checking in to see where we are on this issue. I haven't had any time to work > on 4 but hopefully can start on that soon. But it needs the first part done > to be effective. Thx for

[PATCH] D64804: [OpenCL][Sema] Minor refactoring and constraint checking

mantognini added reviewers: Anastasia, rjmccall. mantognini added a comment. This should address the minor refactoring requesting in D64083 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64804/new/

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

Makes sense, thanks. Seems like INTERFACE is the way to go then. From: on behalf of Chris Bieneman Date: Tuesday, July 16, 2019 at 10:32 AM To: Shoaib Meenai Cc: Alex Bradbury , cfe-commits Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies I get that CMake does

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein added a comment. the code looks clearer now! Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:609 FixItsMap.erase(File); +std::lock_guard HLock(HighlightingsMutex); +FileToPrevHighlightings.erase(File); nit: I would create a new

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

ilya-biryukov updated this revision to Diff 210105. ilya-biryukov added a comment. Fix a typo (xD) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64799/new/ https://reviews.llvm.org/D64799 Files: clang/lib/Sema/Sema.cpp

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL366267: [clang-format] Dont detect call to ObjC class method as C++11 attribute… (authored by benhamilton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane marked an inline comment as done. jpakkane added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/InitLocalVariablesCheck.cpp:21 + Finder->addMatcher( + varDecl(unless(hasInitializer(anything(.bind("vardecl"), this); +} alexfh

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

benhamilton added a comment. Submitted as r366267. Thanks! Comment at: clang/lib/Format/TokenAnnotator.cpp:389 bool isCpp11AttributeSpecifier(const FormatToken ) { if (!Style.isCpp() || !Tok.startsSequence(tok::l_square, tok::l_square)) return false;

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed extraneous matches of non-NullStmt Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64838 Files: clang/include/clang/Basic/Attr.td

[PATCH] D41412: [libcxx] implement concat() and split()

timshen added a comment. In D41412#1586966 , @grosser wrote: > Hi @timshen, > > I am very interested in these patches. Any chance you can take up the > upstreaming process again? I'm glad to spend time upstreaming these patches. Now we just need a

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan marked an inline comment as done. ziangwan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:11429 + S.Context.getFloatTypeSemantics(QualType(TargetBT, 0))); +TargetFloatValue.convertFromAPInt(SourceInt, +

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

ldionne added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1307 + HasStdlibxxIsystem ? TC.AddClangCXXStdlibIsystemArgs(Args, CmdArgs) + : TC.AddClangCXXStdlibIncludeArgs(Args, CmdArgs); +}); So,

Re: r366123 - ARM MTE stack sanitizer.

Hi, thanks for letting me know! Is this reproducible on Linux? It is possible to extract a reproducer from the bot? On Mon, Jul 15, 2019 at 9:30 PM Amara Emerson wrote: > > Hi Evgeniy, > > This commit looks like it broke the lldb bot: > http://green.lab.llvm.org/green/job/lldb-cmake/31011/ > >

[PATCH] D48680: Add missing visibility annotation for __base

pcc added a comment. In D48680#1587967 , @ldionne wrote: > @pcc In your reproducer, what is `~/l3/ra-cmake/bin/clang++`? That's just clang built from trunk at the time that I posted my comment. > Are you able to reproduce without `-fuse-ld=lld`? I'm

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

lebedev.ri added reviewers: JonasToth, gribozavr. lebedev.ri added a comment. Thanks. Are there any tests missing for `volatile`, atomics? I'm not really current on clang-tidy state of affairs, so i'm gonna leave most of the review for others.. Comment at:

[PATCH] D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions

ymandel updated this revision to Diff 210148. ymandel added a comment. tweaks in response to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64518/new/ https://reviews.llvm.org/D64518 Files: clang/lib/Tooling/Refactoring/Transformer.cpp

[PATCH] D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions

ymandel marked 2 inline comments as done. ymandel added a comment. In D64518#1585917 , @ilya-biryukov wrote: > This clearly increases the utility of the library, but also seems to add > corner cases that the library won't handle (see the comment about

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

tlively added a comment. LGTM apart from one last comment Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:193 + +if (!Features[WebAssembly::FeatureBulkMemory]) Stripped |= stripThreadLocals(M); quantum wrote: > tlively wrote: >

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum updated this revision to Diff 210166. quantum added a comment. More fine-grainted stripping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files:

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

tlively accepted this revision. tlively added a comment. Nice work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 ___ cfe-commits mailing list

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366272: [WebAssembly] Implement thread-local storage (local-exec model) (authored by quantum, committed by ). Changed prior to commit: https://reviews.llvm.org/D64537?vs=210188=210191#toc Repository:

r366272 - [WebAssembly] Implement thread-local storage (local-exec model)

Author: quantum Date: Tue Jul 16 15:00:45 2019 New Revision: 366272 URL: http://llvm.org/viewvc/llvm-project?rev=366272=rev Log: [WebAssembly] Implement thread-local storage (local-exec model) Summary: Thread local variables are placed inside a `.tdata` segment. Their symbols are offsets from

[PATCH] D64828: AMDGPU: Add some missing builtins

arsenm created this revision. arsenm added reviewers: rampitec, yaxunl, kzhuravl, b-sumner. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely. https://reviews.llvm.org/D64828 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp

r366276 - Fix a typo in target features

Author: gbiv Date: Tue Jul 16 15:32:17 2019 New Revision: 366276 URL: http://llvm.org/viewvc/llvm-project?rev=366276=rev Log: Fix a typo in target features There was a slight typo in r364352 that ended up causing our backend to complain on some x86 Android builds. This CL fixes that.

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

rnk added a comment. I'm in favor of this as is. We should loop in and get confirmation from @rsmith though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64799/new/ https://reviews.llvm.org/D64799

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry added a comment. Revival of https://reviews.llvm.org/D63260 and https://reviews.llvm.org/D63299. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838

  1   2   >