[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

plotfi added a comment. In D65176#1598431 , @compnerd wrote: > This looks good to me generally. I don't fully understand the reason for `u` > being kept, is that something you intend to clean up in a subsequent patch? I’d like to remove it but I don’t

[PATCH] D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: clang-tidy/performance/NoexceptMoveConstructorCheck.cpp:57 + assert(Decl->getNumParams() > 0); + SourceLocation NoexceptLoc = Decl->getParamDecl(Decl->getNumParams() - 1) +

[PATCH] D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

zinovy.nis updated this revision to Diff 211429. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65104/new/ https://reviews.llvm.org/D65104 Files: clang-tidy/performance/NoexceptMoveConstructorCheck.cpp test/clang-tidy/performance-noexcept-move-constructor-fix.cpp Index:

[PATCH] D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

zinovy.nis updated this revision to Diff 211428. zinovy.nis added a comment. - Fixed tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65104/new/ https://reviews.llvm.org/D65104 Files: clang-tidy/performance/NoexceptMoveConstructorCheck.cpp

[clang-tools-extra] r366875 - [clangd] Update a stale comment, NFC.

Author: hokein Date: Wed Jul 24 00:57:25 2019 New Revision: 366875 URL: http://llvm.org/viewvc/llvm-project?rev=366875=rev Log: [clangd] Update a stale comment, NFC. Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/ExpandAutoType.cpp Modified:

[PATCH] D65182: [analyzer] WIP: Add fix-it hint support.

Szelethus added a comment. Woah, nice! How does an `-analyzer-config fixits-as-warnings` option sound like for more readable tests? 01 Obj obj6 = /**/; // expected-warning{{Value stored to 'obj6' during its initialization is never read}} 02 // expected-warning@-1{{FixIt:

[clang-tools-extra] r366882 - [clangd] Fix SelectionTree traversal of qualified types

Author: sammccall Date: Wed Jul 24 02:39:11 2019 New Revision: 366882 URL: http://llvm.org/viewvc/llvm-project?rev=366882=rev Log: [clangd] Fix SelectionTree traversal of qualified types Summary: QualifiedTypeLoc isn't treated like a regular citizen by RecursiveASTVisitor. This meant we weren't

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 marked 11 inline comments as done. gamesh411 added a comment. Thanks for pointing out these issues. Most of them are agreed. Merging the RAII counter with the threshold checker class, however, does not seem like a good decision for me. What would be the benefits of merging the two?

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! Comment at: include/clang/Frontend/LangStandards.def:177 LANGSTANDARD_ALIAS_DEPR(opencl20, "CL2.0") +LANGSTANDARD_ALIAS_DEPR(openclcpp, "CLC++") It

[PATCH] D65196: [CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, Charusso, dcoughlin, rnkovacs, a_sidorin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp. Previously, collecting `CFGElement`s in a set was practially

[clang-tools-extra] r366873 - [clangd] Implement "prepareRename"

Author: hokein Date: Wed Jul 24 00:49:23 2019 New Revision: 366873 URL: http://llvm.org/viewvc/llvm-project?rev=366873=rev Log: [clangd] Implement "prepareRename" Summary: - "prepareRename" request is added in LSP v3.12.0 - also update the vscode-client dependency to pick-up the rename bug

[PATCH] D65154: [clangd] Reformat use of cl::opt: use unqualified name and don't bin-pack attributes. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL366880: [clangd] Reformat use of cl::opt: use unqualified name and dont bin-pack… (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D63126: [clangd] Implement "prepareRename"

This revision was automatically updated to reflect the committed changes. Closed by commit rL366873: [clangd] Implement prepareRename (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65183: [Format] Make it easy to add new format::FormatStyle::LanguageStandard. NFCI

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I haven't really understood D65043 yet, but I think this is a good change either way. Comment at: lib/Format/TokenAnnotator.cpp:2862

[PATCH] D65183: [Format] Make it easy to add new format::FormatStyle::LanguageStandard. NFCI

MaskRay updated this revision to Diff 211436. MaskRay added a comment. Change to `< Cpp11` Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65183/new/ https://reviews.llvm.org/D65183 Files: lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp Index:

[PATCH] D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list

This revision was automatically updated to reflect the committed changes. Closed by commit rL366878: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list (authored by s.desmalen, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[clang-tools-extra] r366880 - [clangd] Reformat use of cl::opt: use unqualified name and don't bin-pack attributes. NFC

Author: sammccall Date: Wed Jul 24 02:33:27 2019 New Revision: 366880 URL: http://llvm.org/viewvc/llvm-project?rev=366880=rev Log: [clangd] Reformat use of cl::opt: use unqualified name and don't bin-pack attributes. NFC Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous,

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

martong added a comment. I have a feeling that LoadPass and LoagGuard could be (should be) merged together, other than that we are getting close. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:185 + + /// Cached access to ASTUnit mapping information is

r366883 - [Format] getFormattingLangOpts: make LS_Auto uses LS_Cpp11 lexing rule

Author: maskray Date: Wed Jul 24 02:50:56 2019 New Revision: 366883 URL: http://llvm.org/viewvc/llvm-project?rev=366883=rev Log: [Format] getFormattingLangOpts: make LS_Auto uses LS_Cpp11 lexing rule Suggested by sammccall in post-commit review of D65183 Reviewed By: sammccall Differential

[PATCH] D65194: [Format] Make getFormattingLangOpts clear LS_Auto uses LS_Cpp11 lexing rule

This revision was automatically updated to reflect the committed changes. Closed by commit rL366883: [Format] getFormattingLangOpts: make LS_Auto uses LS_Cpp11 lexing rule (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D65101: [clangd] SelectionTree treats TranslationUnitDecl consistently with other containers.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp:47 // Narrow the traversal scope to the selected node. Inputs.AST.getASTContext().setTraversalScope(

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Yay! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65180/new/ https://reviews.llvm.org/D65180 ___ cfe-commits mailing list

[PATCH] D65183: [Format] Make it easy to add new format::FormatStyle::LanguageStandard. NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rL366876: [Format] Make it easy to add new format::FormatStyle::LanguageStandard. NFCI (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D65194: [Format] Make getFormattingLangOpts clear LS_Auto uses LS_Cpp11 lexing rule

MaskRay created this revision. MaskRay added reviewers: modocache, sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Suggested by sammccall in post-commit review of D65183 Repository: rC Clang https://reviews.llvm.org/D65194

[PATCH] D65100: [clangd] Fix SelectionTree traversal of qualified types

This revision was automatically updated to reflect the committed changes. Closed by commit rL366882: [clangd] Fix SelectionTree traversal of qualified types (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r366884 - [CrossTU] Add a function to retrieve original source location.

Author: balazske Date: Wed Jul 24 03:16:37 2019 New Revision: 366884 URL: http://llvm.org/viewvc/llvm-project?rev=366884=rev Log: [CrossTU] Add a function to retrieve original source location. Summary: A new function will be added to get the original SourceLocation for a SourceLocation that was

[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366884: [CrossTU] Add a function to retrieve original source location. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r366876 - [Format] Make it easy to add new format::FormatStyle::LanguageStandard. NFCI

Author: maskray Date: Wed Jul 24 01:04:29 2019 New Revision: 366876 URL: http://llvm.org/viewvc/llvm-project?rev=366876=rev Log: [Format] Make it easy to add new format::FormatStyle::LanguageStandard. NFCI Preparatory change for D65043. We current use `!=LS_Cpp03` to enable language standards

[PATCH] D65183: [Format] Make it easy to add new format::FormatStyle::LanguageStandard. NFCI

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2862 return Right.is(TT_TemplateCloser) && Left.is(TT_TemplateCloser) && - (Style.Standard != FormatStyle::LS_Cpp11 || Style.SpacesInAngles); +

[PATCH] D65183: [Format] Make it easy to add new format::FormatStyle::LanguageStandard. NFCI

MaskRay updated this revision to Diff 211437. MaskRay added a comment. Fix another place that should use `< FormatStyle::LS_Cpp11` instead` Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65183/new/ https://reviews.llvm.org/D65183 Files: lib/Format/Format.cpp

[clang-tools-extra] r366877 - [clangd] Bump vscode-clangd v0.0.16

Author: hokein Date: Wed Jul 24 01:14:29 2019 New Revision: 366877 URL: http://llvm.org/viewvc/llvm-project?rev=366877=rev Log: [clangd] Bump vscode-clangd v0.0.16 CHANGELOG: - detect C++ language based on some well-known file paths - upgrade the lsp-client and lsp-server dependencies Modified:

[PATCH] D65183: [Format] Make it easy to add new format::FormatStyle::LanguageStandard. NFCI

sammccall added inline comments. Comment at: lib/Format/Format.cpp:2369 LangOpts.CPlusPlus = 1; - LangOpts.CPlusPlus11 = Style.Standard == FormatStyle::LS_Cpp03 ? 0 : 1; - LangOpts.CPlusPlus14 = Style.Standard == FormatStyle::LS_Cpp03 ? 0 : 1; - LangOpts.CPlusPlus17 =

r366878 - [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list

Author: s.desmalen Date: Wed Jul 24 01:42:34 2019 New Revision: 366878 URL: http://llvm.org/viewvc/llvm-project?rev=366878=rev Log: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list Adds the SVE vector and predicate registers to the list of known registers. Patch by

[PATCH] D65194: [Format] Make getFormattingLangOpts clear LS_Auto uses LS_Cpp11 lexing rule

MaskRay added a comment. `getFormattingLangOpts` is called with unadjusted FormatStyle (`deriveLocalStyle` doesn't modify `Style`). For example, GoogleStyle uses `FormatStyle::LS_Auto`. We're relying on `FormatStyle::LS_Auto` being larger than `FormatStyle::LS_Cpp11`, which is brittle. Below

[PATCH] D65043: [Format] Add C++20 standard to style options

sammccall added a comment. So there's precedent for this in rL185149 (D1028 ). @klimek may have historical context. Overall, this makes sense. Since the coroutines flag flip landed on the 9.x release branch, we may want this

[PATCH] D65194: [Format] Make getFormattingLangOpts clear LS_Auto uses LS_Cpp11 lexing rule

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! (Sorry for the comment arriving late, didn't expect you to be awake!) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65194/new/

[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

balazske updated this revision to Diff 211454. balazske added a comment. Update diff to one commit with all changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65064/new/ https://reviews.llvm.org/D65064 Files:

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus updated this revision to Diff 211457. Szelethus added a comment. Rebase on top of D65196 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64991/new/ https://reviews.llvm.org/D64991 Files:

[PATCH] D65101: [clangd] SelectionTree treats TranslationUnitDecl consistently with other containers.

sammccall updated this revision to Diff 211458. sammccall added a comment. Reverted commonAncestor() back to a pointer, return null if ancestor is TUDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65101/new/ https://reviews.llvm.org/D65101

[PATCH] D65101: [clangd] SelectionTree treats TranslationUnitDecl consistently with other containers.

sammccall updated this revision to Diff 211459. sammccall marked 3 inline comments as done. sammccall added a comment. doc selectiontree's interactions with preprocessor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65101/new/

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1772 Opts.TimeTrace = Args.hasArg(OPT_ftime_trace); + Opts.TimeTraceGranularity = + getLastArgIntValue(Args,

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

klimek added a comment. So, I did like the more exhaustive doc, I thought you'd move it to the code so it also shows up in the generated doc page :) (sorry for not being clearer here) Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2637

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2672 + BaseName, 1) { + assert(!BaseName.empty()); + return isDirectlyDerivedFrom(hasName(BaseName)) I don't think this assertion is reasonable

[PATCH] D65209: [analyzer] Fix a SARIF exporter crash with macro expansions

jranieri-grammatech created this revision. jranieri-grammatech added reviewers: NoQ, george.karpenkov, aaron.ballman. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang.

[PATCH] D65211: [analyzer] Update the SARIF exporter to SARIF 2.1

jranieri-grammatech created this revision. jranieri-grammatech added reviewers: NoQ, george.karpenkov, aaron.ballman. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang.

[PATCH] D65210: [clangd] Fix the annotate tweak after rL366893

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. After rL366893 , the annoate tweak is not activated when we select the whole file

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev updated this revision to Diff 211489. anton-afanasyev marked an inline comment as done. anton-afanasyev added a comment. Remove default repeat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65202/new/ https://reviews.llvm.org/D65202

[PATCH] D65043: [Format] Add C++20 standard to style options

Quuxplusone added a comment. Peanut gallery says: A priori, I don't see any reason for clang-format's `LanguageStandard` options to diverge from Clang's own `-std=` options. It sounds like currently they're very different, and you're proposing to make them basically the same. I think that's a

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1951 + +Minimum time granularity (in microseconds) traced by time profiler + anton-afanasyev wrote: > sammccall wrote: >

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

jranieri-grammatech created this revision. jranieri-grammatech added reviewers: NoQ, jordan_rose, dcoughlin, george.karpenkov, aaron.ballman. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald

[PATCH] D65210: [clangd] Fix the annotate tweak after rL366893

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp:31 InterestedDecl = N->ASTNode.get(); return InterestedDecl; }

[PATCH] D64914: Implement P1771

erichkeane updated this revision to Diff 211504. erichkeane added a comment. Casting implementation had to happen in SemaStmt, because other 'warn unused result' stuff depends on them being the way they are. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64914/new/

[PATCH] D58531: [clang] Specify type of pthread_create builtin

probinson added a reviewer: jdoerfert. probinson added a comment. We've started running into this too in building the PS4 system. +jdoerfert who added pthread_create to the builtin list. Looking at the patch, it seems straightforward enough although clearly needs clang-format-diff run over it.

[PATCH] D65043: [Format] Add C++20 standard to style options

sammccall added a comment. In D65043#1599148 , @Quuxplusone wrote: > Peanut gallery says: A priori, I don't see any reason for clang-format's > `LanguageStandard` options to diverge from Clang's own `-std=` options. It > sounds like currently they're

[PATCH] D65101: [clangd] SelectionTree treats TranslationUnitDecl consistently with other containers.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65101/new/ https://reviews.llvm.org/D65101

[PATCH] D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65104/new/ https://reviews.llvm.org/D65104 ___ cfe-commits mailing

Re: [PATCH] D59254: [RFC] Implementation of Clang randstruct

On Tue, Jul 23, 2019 at 9:17 PM Connor Kuehl via Phabricator wrote: > > connorkuehl added a comment. > > In D59254#1429401 , @jfb wrote: > > > I find it easier to understand the code by looking at the tests. When you > > add tests, please make sure you

[PATCH] D65201: [clangd] Provide help text to users who run `clangd` in a terminal.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:430 + if (llvm::outs().is_displayed() && llvm::errs().is_displayed()) +llvm::errs() << Overview << "\n";

[PATCH] D65200: [clangd] Add categories to help options, and only show clangd options.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:59 + +opt CompileCommandsDir{ "compile-commands-dir", maybe also group these options by

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ClangCommandLineReference.rst:1951 + +Minimum time granularity (in microseconds) traced by time profiler + is there any

[PATCH] D65200: [clangd] Add categories to help options, and only show clangd options.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:59 + +opt CompileCommandsDir{ "compile-commands-dir", hokein wrote: > maybe also group these options by the their

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

lebedev.ri added a comment. Looks ok Comment at: clang/docs/ClangCommandLineReference.rst:1943-1947 .. option:: -ftime-report +.. option:: -ftime-trace + +Turn on time profiler lebedev.ri wrote: > While there add a description to `-ftime-report` and

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: include/clang/Frontend/LangStandards.def:177 LANGSTANDARD_ALIAS_DEPR(opencl20, "CL2.0") +LANGSTANDARD_ALIAS_DEPR(openclcpp, "CLC++") svenvh wrote: > It surprised me that

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64744/new/ https://reviews.llvm.org/D64744 ___ cfe-commits mailing

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: llvm/trunk/lib/Support/TimeProfiler.cpp:27 +static cl::opt TimeTraceGranularity( +"time-trace-granularity", sammccall wrote: > I know this is late, but...

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

lebedev.ri added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1943-1947 .. option:: -ftime-report +.. option:: -ftime-trace + +Turn on time profiler While there add a description to `-ftime-report` and document how they are

[PATCH] D65203: [ASTImporter] Do not import FunctionTemplateDecl in record twice.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. For functions there is a check to not duplicate the

[PATCH] D65200: [clangd] Add categories to help options, and only show clangd options.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366900: [clangd] Add categories to help options, and only show clangd options. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64914: Implement P1771

erichkeane updated this revision to Diff 211482. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64914/new/ https://reviews.llvm.org/D64914 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D64914: Implement P1771

erichkeane added a comment. Disregard that last commit... i ended up breaking stuff apparently. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64914/new/ https://reviews.llvm.org/D64914 ___ cfe-commits mailing list

[clang-tools-extra] r366893 - [clangd] SelectionTree treats TranslationUnitDecl (mostly) consistently with other containers.

Author: sammccall Date: Wed Jul 24 05:14:56 2019 New Revision: 366893 URL: http://llvm.org/viewvc/llvm-project?rev=366893=rev Log: [clangd] SelectionTree treats TranslationUnitDecl (mostly) consistently with other containers. Summary: Previously TranslationUnitDecl would never be selected. This

[PATCH] D63954: Add lifetime categories attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2771 + let Spellings = [CXX11<"gsl", "Owner">]; + let Subjects = SubjectList<[CXXRecord]>; + let Args = [TypeArgument<"DerefType", /*opt=*/1>]; This subject should be `Struct`

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev added a comment. Manuel, would you mind taking another look at the change please? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 ___ cfe-commits mailing list

[PATCH] D65201: [clangd] Provide help text to users who run `clangd` in a terminal.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65201 Files:

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1951 + +Minimum time granularity (in microseconds) traced by time profiler + sammccall wrote: > is there any possibility of wanting a granularity <1ms in the future? This

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev updated this revision to Diff 211481. anton-afanasyev marked 8 inline comments as done. anton-afanasyev added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65202/new/ https://reviews.llvm.org/D65202 Files:

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev marked an inline comment as done. anton-afanasyev added a subscriber: aras-p. anton-afanasyev added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1943-1947 .. option:: -ftime-report +.. option:: -ftime-trace + +Turn on time profiler

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Types.def:39-45 +// Some of the options in Flags have been removed, so far those are: +// a - The type should only be assembled: Now, check that Phases contains +// phases::Assemble but not

[PATCH] D65200: [clangd] Add categories to help options, and only show clangd options.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Restricting the categories prevents extra unwanted options from creeping into help (D60663

[PATCH] D65101: [clangd] SelectionTree treats TranslationUnitDecl consistently with other containers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366893: [clangd] SelectionTree treats TranslationUnitDecl (mostly) consistently with… (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a comment request. Comment at: clang/lib/Sema/SemaDecl.cpp:11258 // are handled by a dataflow analysis. - if (!VDecl->hasLocalStorage() || VDecl->getType()->isRecordType() || -

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev created this revision. anton-afanasyev added a reviewer: sammccall. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Move `-ftime-trace-granularity` option to frontend options. Without patch this option is showed up in the help

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

balazske added a comment. The Frontend is needed because "ASTUnit.h" is added now into PlistDiagnostics.cpp. The `ASTUnit` object is used to pass information out from `getImportedFromSourceLocation`. The StaticAnalyzerCore library uses CrossTU library, and CrossTU uses Frontend, so I think it

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:210 +// - we don't look inside macro expansions in the subexpressions +// - we only adjust the extracted range, so references in the unselected parts +//of the AST

[PATCH] D60663: Time profiler: small fixes and optimizations

sammccall added inline comments. Comment at: llvm/trunk/lib/Support/TimeProfiler.cpp:27 +static cl::opt TimeTraceGranularity( +"time-trace-granularity", anton-afanasyev wrote: > sammccall wrote: > > I know this is late, but... this shows up in the help for

[clang-tools-extra] r366900 - [clangd] Add categories to help options, and only show clangd options.

Author: sammccall Date: Wed Jul 24 05:41:52 2019 New Revision: 366900 URL: http://llvm.org/viewvc/llvm-project?rev=366900=rev Log: [clangd] Add categories to help options, and only show clangd options. Summary: Restricting the categories prevents extra unwanted options from creeping into help

[PATCH] D65206: [analyzer] Fix text range end columns in SARIF to be exclusive

jranieri-grammatech created this revision. jranieri-grammatech added reviewers: george.karpenkov, NoQ, aaron.ballman. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang.

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Hi all! Could it be accepted or reviewed more? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 ___ cfe-commits mailing list

r366904 - Test commit. NFC.

Author: sjoerdmeijer Date: Wed Jul 24 06:30:36 2019 New Revision: 366904 URL: http://llvm.org/viewvc/llvm-project?rev=366904=rev Log: Test commit. NFC. Removed 2 trailing whitespaces in 2 files that used to be in different repos to test my new github monorepo workflow. Modified:

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Hi @lebedev.ri, could you please lgtm this or elaborate on possible issue with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325

[PATCH] D64386: CodeGen: Use memset in initializers for non-zeros

hfinkel added inline comments. Comment at: clang/test/CodeGen/init-memset.c:29 char a[] = "aa"; - // CHECK: call void @llvm.memcpy.{{.*}} + // CHECK: call void @llvm.memset.{{.*}} use(a); I'd be

r366911 - [Support] Fix `-ftime-trace-granularity` option

Author: anton-afanasyev Date: Wed Jul 24 07:55:40 2019 New Revision: 366911 URL: http://llvm.org/viewvc/llvm-project?rev=366911=rev Log: [Support] Fix `-ftime-trace-granularity` option Summary: Move `-ftime-trace-granularity` option to frontend options. Without patch this option is showed up in

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2672 + BaseName, 1) { + assert(!BaseName.empty()); + return isDirectlyDerivedFrom(hasName(BaseName)) aaron.ballman wrote: > I don't think this

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus updated this revision to Diff 211509. Szelethus added a comment. Use the correct sorting for the GEN, KILL, IN and OUT sets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64991/new/ https://reviews.llvm.org/D64991 Files:

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

This revision was automatically updated to reflect the committed changes. Closed by commit rL366911: [Support] Fix `-ftime-trace-granularity` option (authored by anton-afanasyev, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211508. AntonBikineev marked an inline comment as done. AntonBikineev added a comment. Thanks for the comments! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 Files:

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2672 + BaseName, 1) { + assert(!BaseName.empty()); + return isDirectlyDerivedFrom(hasName(BaseName)) AntonBikineev wrote: > aaron.ballman

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211513. AntonBikineev marked an inline comment as not done. AntonBikineev added a comment. Missed that, thanks for the point! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

compnerd added inline comments. Comment at: clang/include/clang/Driver/Types.def:39-45 +// Some of the options in Flags have been removed, so far those are: +// a - The type should only be assembled: Now, check that Phases contains +// phases::Assemble but not

[PATCH] D65149: [Format] Add test demonstrating PR42722

MyDeveloperDay added a comment. We don't normally commit a failing test alone, otherwise the build machines will be broken until it gets fixed.. just add this test with your fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65149/new/

  1   2   >