[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

vzakhari added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:226 +// Add this function to global destructors. +appendToGlobalDtors(M, Func, 0); + } FYI, llvm.global_dtors does not work on Windows. The symbol

Re: LLVM Types

To avoid confusion, there's both a LLVM Type and a Clang Type. The LLVM Type is used in the LLVM IR while the Clang Type represents types in a language, like C++. The Clang Doxygen pages have this hierarchy, although it's truncated because Type is so large, but you can click through to get the

[PATCH] D65846: Improve error message from FrontendAction

jfb planned changes to this revision. jfb added a comment. There's a failure in `clang/test/Index/pch-from-libclang.c`. @thakis disabled that test for all but Darwin in r352809, and with my change I now get: Internal compiler error: LFS error for

[PATCH] D65846: Improve error message from FrontendAction

jfb created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. jfb planned changes to this revision. jfb added a comment. There's a failure in `clang/test/Index/pch-from-libclang.c`. @thakis disabled that test for all but Darwin in r352809, and with

[PATCH] D65839: [Driver] Add verbatim dry run option

compnerd added inline comments. Comment at: clang/include/clang/Driver/Options.td:333 HelpText<"Print (but do not run) the commands to run for this compilation">; +def _HASH_HASH_HASH_VERBATIM : Flag<["-"], "###-verbatim">, +Flags<[DriverOption, CoreOption]>,

[PATCH] D65738: [clangd] Added a TextMate theme parser that updates when the current theme changes.

hokein added a comment. thanks, looks simpler now, just a few more nits. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:7 +interface TokenColorRule { + scope: string, textColor: string, +} nit: we need documentation

Re: [clang-tools-extra] r368019 - [clangd] Compute scopes eagerly in IncludeFixer

+Hans Wennborg , could we merge this into the release? On Tue, Aug 6, 2019 at 1:36 PM Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ibiryukov > Date: Tue Aug 6 04:37:50 2019 > New Revision: 368019 > > URL: http://llvm.org/viewvc/llvm-project?rev=368019=rev > Log:

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. One important comment about somehow distinguishing multiple decls with the same name. Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:110 +template +void f(T) {} +

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

gribozavr added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't start watching. In such - /// case

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || xazax.hun wrote: > gribozavr wrote: >

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

SureYeaah updated this revision to Diff 213614. SureYeaah added a comment. use fileID instead of hash in map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65754/new/ https://reviews.llvm.org/D65754 Files: clang-tools-extra/clangd/SourceCode.cpp

LLVM Types

Hello, Can I dump LLVM Type hierarchies somehow ?? Types which are declared in this file ("clang/AST/Type.h " ) Regards, Mona ___ cfe-commits mailing list cfe-commits@lists.llvm.org

AST for For loop

Hello, While dumping the AST for For loop, Why do I get <<>> ?? Source code: void func() { for (int i = 0; i < 5; i++) break; } AST FunctionDecl 0x4a4ac10 line:2:6 func 'void ()' `-CompoundStmt 0x4a4ae1c `-ForStmt 0x4a4adf8 |-DeclStmt 0x4a4ad38 | `-VarDecl 0x4a4acd0 col:11 used

[PATCH] D65804: Fixed toHalfOpenFileRange assertion fail

SureYeaah created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. - Added new function that gets Expansion range with both ends in the same file. - Fixes the crash at https://github.com/clangd/clangd/issues/113

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

jvikstrom updated this revision to Diff 213608. jvikstrom marked an inline comment as done. jvikstrom added a comment. Added tests for making sure explicit specializations, explicit instantiations, partial instantiations, explicit declarations and template variables are in topLevelDecls. Also

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

jvikstrom marked 2 inline comments as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:110 +template +void f(T) {} +void s() { ilya-biryukov wrote: > Could you also check that: > > 1.

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 6 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea added a comment. Thanks for the update Alex! Just a few more comments and we should be good to go: Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:117 +std::mutex CacheLock; +llvm::StringMap> Cache; + };

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript ||

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

lebedev.ri added a comment. In D65065#1617031 , @gribozavr wrote: > > This suggestion would result another strange behavior: if the user disables > > cert-err09-cpp because he or she doesn't want to see its reports, the other > > one (cert-err61-cpp)

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

tycho added a comment. Two things: - I'm curious why we would want to force `-O2`/`-O3` instead of just allowing `-Os`/`-Oz` to be used with LTO. Is optimizing for size combined with LTO really that unusual? I've built several projects using GCC with `-Os -flto` and the size reduction over

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:283 /*waitForInitialSync=*/true); + if (!DW) return; gribozavr wrote: > plotfi wrote: > > jkorous wrote: > > >

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

bruntib added a comment. Not exactly. The problem is that it is non-deterministic which checker reports the issue. For example before this patch, in the test file above there was only one report. However, sometimes the report message is: throw expression should throw anonymous temporary values

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

rjmccall added a comment. I doubt "CTAD" is going to survive as a term that people recognize and remember, and I don't think `-Wclass-template-argument-deduction` is outrageously wordy compared to some of our other diagnostic groups. With that change, this would be fine with me. Repository:

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

rjmccall added a comment. Oh, I see this review might be dead in the water; I'm not sure why I was just added as a reviewer to it (by a non-author, no less). I personally have no problem with pulling out specific features as sub-groups of the compatibility warning. I agree with Richard,

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

gribozavr added a comment. Producing the message two times is worse user experience than producing one. Most users don't care which checker produced the message. However, the output should be deterministic. Therefore, a better fix would be making deduplication deterministic, instead of

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

bruntib added a comment. This suggestion would result another strange behavior: if the user disables cert-err09-cpp because he or she doesn't want to see its reports, the other one (cert-err61-cpp) will still report the issue. So he or she has to disable both (or as many aliases it has). As

Re: AST for For loop

On Tue, Aug 6, 2019 at 11:15 AM Monalisa Rout via cfe-commits wrote: > > Hello, > While dumping the AST for For loop, Why do I get <<>> ?? > > Source code: > void func() > { > for (int i = 0; i < 5; i++) > break; > } > > AST > > FunctionDecl 0x4a4ac10 > line:2:6 > func 'void ()' >

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

gribozavr added a comment. > This suggestion would result another strange behavior: if the user disables > cert-err09-cpp because he or she doesn't want to see its reports, the other > one (cert-err61-cpp) will still report the issue. So he or she has to disable > both (or as many aliases it

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:307 +// the same file id. +static SourceRange getExpansionRangeInSameFiles(SourceLocation Loc, +const SourceManager , nit:

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript ||

Re: r367889 - [docs] document -Weveything more betterer

Thanks! On Mon, Aug 5, 2019 at 3:58 PM JF Bastien wrote: > Ugh this is silly… fixed again. > > On Aug 5, 2019, at 12:55 PM, Nico Weber wrote: > > Still sad, now with a different message: > http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45220 > >

[PATCH] D65693: [driver][riscv] Support riscv64-linux-gnu multiarch paths

asb requested changes to this revision. asb added a comment. This revision now requires changes to proceed. Many thanks for the patch. Could you please add some tests for this behaviour? I imagine you'll want to add a new directory in test/Driver/Inputs with a Debian tree skeleton. See D63497

[PATCH] D65663: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

Charusso updated this revision to Diff 213610. Charusso marked 4 inline comments as done. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65663/new/ https://reviews.llvm.org/D65663 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

r368029 - Improve MSVC visualizations so the parser shows where we are in the code

Author: mps Date: Tue Aug 6 06:29:35 2019 New Revision: 368029 URL: http://llvm.org/viewvc/llvm-project?rev=368029=rev Log: Improve MSVC visualizations so the parser shows where we are in the code Also provide a visualizer for lambda introducers Modified:

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

SureYeaah updated this revision to Diff 213599. SureYeaah marked 8 inline comments as done. SureYeaah added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65754/new/ https://reviews.llvm.org/D65754 Files:

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

gribozavr added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:283 /*waitForInitialSync=*/true); + if (!DW) return; plotfi wrote: > jkorous wrote: > > jkorous wrote: > > > IIUC this is silently dropping errors.

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

gribozavr added a comment. So the problem you're trying to solve is that the output is non-deterministic, is that correct? > However, it is random which checker name is included in the warning. If that is indeed the problem, then I think the solution should be making the output deterministic

[PATCH] D65663: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

Charusso added a comment. Here is an example of the new `MemberExpr::getBase()` based report: F9736772: report-Driver.cpp-operator()-6-1.html Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2420 + if (!IsAssuming) { +

r368052 - [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro

Author: ibiryukov Date: Tue Aug 6 08:46:12 2019 New Revision: 368052 URL: http://llvm.org/viewvc/llvm-project?rev=368052=rev Log: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro Summary: Instead of traversing inside the TraverseDecl() function. Previously the attributes were traversed

[clang-tools-extra] r368058 - Fixed toHalfOpenFileRange assertion fail

Author: sureyeaah Date: Tue Aug 6 10:01:12 2019 New Revision: 368058 URL: http://llvm.org/viewvc/llvm-project?rev=368058=rev Log: Fixed toHalfOpenFileRange assertion fail Summary: - Added new function that gets Expansion range with both ends in the same file. - Fixes the crash at

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante added a comment. Unfortunately I'm not able to quickly find the Doxygen output of Swift online. When I process: `A limited variant of \c @objc that's used for classes with generic ancestry.` with Doxygen I get: `A limited variant of that's used for classes with generic ancestry.` Since

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry, should have accepted this in the last round. Great stuff, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65754/new/

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev marked 4 inline comments as done. sdmitriev added inline comments. Comment at: clang/include/clang/Driver/Action.h:74 OffloadUnbundlingJobClass, +OffloadWrapperJobClass, ABataev wrote: > Do we really need this new kind of job here, can we

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

mehdi_amini added a comment. > I assume I might be missing something here, though, since someone mentioned > this above (I don't understand the response to it though). There are two invocations in LTO: the first phase where we compile from source to bitcode, and the second phase which is

[PATCH] D64907: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro

This revision was automatically updated to reflect the committed changes. Closed by commit rL368052: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

lebedev.ri added a comment. In D65065#1617079 , @gribozavr wrote: > `-Weverything` is not recommended for anything except compiler testing, and > similarly with clang-tidy, enabling all checkers is not a good idea. I don't > think improving this

Re: AST for For loop

Awesome, thanks! On Tue, Aug 6, 2019 at 5:18 PM Aaron Ballman wrote: > On Tue, Aug 6, 2019 at 11:15 AM Monalisa Rout via cfe-commits > wrote: > > > > Hello, > > While dumping the AST for For loop, Why do I get <<>> ?? > > > > Source code: > > void func() > > { > > for (int i = 0; i < 5; i++)

[PATCH] D65690: [clang-doc] Add index in each info html file

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65690/new/ https://reviews.llvm.org/D65690 ___ cfe-commits mailing list

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

fhahn added a comment. In D65776#1615834 , @Meinersbur wrote: > Mmmh, I would have expected this to work the same way as `vectorize_width`. > According to the docs: > > > The following example implicitly enables vectorization and interleaving by > >

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

This revision was automatically updated to reflect the committed changes. Closed by commit rL368058: Fixed toHalfOpenFileRange assertion fail (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

gribozavr added a comment. `-Weverything` is not recommended for anything except compiler testing, and similarly with clang-tidy, enabling all checkers is not a good idea. I don't think improving this particular point will make enabling all checks more usable. Repository: rCTE Clang Tools

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:7077 +// someContainer.add(std::move(localOWner)); +// return p; +if (!IsTempGslOwner && pathOnlyInitializesGslPointer(Path) &&

[PATCH] D64576: [Syntax] Do not add a node for 'eof' into the tree

This revision was automatically updated to reflect the committed changes. Closed by commit rL368062: [Syntax] Do not add a node for eof into the tree (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r368062 - [Syntax] Do not add a node for 'eof' into the tree

Author: ibiryukov Date: Tue Aug 6 10:07:58 2019 New Revision: 368062 URL: http://llvm.org/viewvc/llvm-project?rev=368062=rev Log: [Syntax] Do not add a node for 'eof' into the tree Summary: While useful as a sentinel value when iterating over tokens, having 'eof' in the tree, seems to do more

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

tycho added a comment. OK, that makes sense. So this change would not enforce `-O2`/`-O3` for the bitcode emission, but would enforce one of the two for the LTO phase. This may be a stupid question, but aren't there some optimization passes that can emit functions during the LTO phase that

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev created this revision. ABataev added reviewers: yaxunl, tra, jlebar, hfinkel. Herald added a reviewer: jdoerfert. Herald added a project: clang. Previously, object files were bundled using partial linking. It resulted in the following structure of the bundled objects:

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM, thank you! In D63907#1617417 , @arphaman wrote: > Just for reference, this patch still doesn't reuse the FileManager across > invocations in a

[PATCH] D65648: [clang-format] Add support to SpacesBeforeTrailingComments to add spaces before Block comments.

Manikishan marked an inline comment as done. Manikishan added inline comments. Comment at: unittests/Format/FormatTest.cpp:3663 + FormatStyle Style = getGoogleStyle(); + Style.SpacesBeforeTrailingComments = 0; EXPECT_EQ("#define MACRO() \\\n"

[PATCH] D65688: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65688/new/ https://reviews.llvm.org/D65688 ___

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:76 +CachedFileSystemEntry +CachedFileSystemEntry::createDirectoryEntry(llvm::vfs::Status Stat) { +

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:69 + + using MemoryBuffersVector = SmallVectorImpl>; + Why not `ArrayRef`? Comment at:

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

jkorous added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't start watching. In such - /// case

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

mehdi_amini added a comment. > with a funny command line like `clang -Oz -flto -o foo a.o b.c`, where one > (or all) of the input arguments is a source file? Would it invoke the bitcode > compile of the source files with the requested `-Oz` and then invoke the LTO > linker plugin with

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman added a comment. Just for reference, this patch still doesn't reuse the FileManager across invocations in a thread. We expect to get even better performance once we reuse it, but I'm going have to improve its API first. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D65690: [clang-doc] Add index in each info html file

This revision was automatically updated to reflect the committed changes. Closed by commit rL368070: [clang-doc] Add index in each info html file (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r368072 - Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

Author: xazax Date: Tue Aug 6 12:13:29 2019 New Revision: 368072 URL: http://llvm.org/viewvc/llvm-project?rev=368072=rev Log: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes This patch extends some existing warnings to utilize the knowledge about the gsl::Pointer and

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL368072: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes (authored by xazax, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:287 /*waitForInitialSync=*/true); + if (!DW) return; gribozavr wrote: > plotfi wrote: > > gribozavr wrote:

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

gribozavr added inline comments. Comment at: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:287 /*waitForInitialSync=*/true); + if (!DW) return; plotfi wrote: > gribozavr wrote: > > plotfi wrote: > > > gribozavr wrote: > > > > Why? This

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman updated this revision to Diff 213664. arphaman marked 6 inline comments as done. arphaman added a comment. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63907/new/ https://reviews.llvm.org/D63907 Files:

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:117 +std::mutex CacheLock; +llvm::StringMap> Cache; + }; aganea wrote: > Why not use a bump allocator here? (it would be

[clang-tools-extra] r368070 - [clang-doc] Add index in each info html file

Author: diegoastiazaran Date: Tue Aug 6 11:31:46 2019 New Revision: 368070 URL: http://llvm.org/viewvc/llvm-project?rev=368070=rev Log: [clang-doc] Add index in each info html file An index structure is created while generating the output file for each info. This structure is parsed to JSON and

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

gribozavr added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't start watching. In such - /// case

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:7077 +// someContainer.add(std::move(localOWner)); +// return p; +if (!IsTempGslOwner && pathOnlyInitializesGslPointer(Path) && xazax.hun wrote: > gribozavr wrote: > > Why

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

SjoerdMeijer added a comment. Hi Florian, thanks for your input! > IMO it would make sense to have the more specific pragmas imply > vectorize(enable) here (or update the docs accordingly). Yep, fully agree with that, as I also wrote in my previous comment. And thanks for digging up that PR.

[PATCH] D65753: Builtins: Add some v2f16 variants

scanon added a comment. Strongly agree with what @rjmccall said. If we can make these generic builtins instead of ending up with O(100) variants of each math operation, that would make life immensely nicer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65753/new/

[PATCH] D65753: Builtins: Add some v2f16 variants

scanon added a comment. (Ideally we would just call them e.g. __builtin_floor, but that would be source-breaking. __builtin_tgmath_floor seems like a good compromise.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65753/new/ https://reviews.llvm.org/D65753

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: cfe/trunk/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:329 + assert(!Path.empty() && "Path.empty()"); const int InotifyFD = inotify_init1(IN_CLOEXEC); @gribozavr

[clang-tools-extra] r368083 - [clangd] Unfold SourceLocation flattening from findNameLoc in preparation for adding more overloads. NFC

Author: sammccall Date: Tue Aug 6 13:25:59 2019 New Revision: 368083 URL: http://llvm.org/viewvc/llvm-project?rev=368083=rev Log: [clangd] Unfold SourceLocation flattening from findNameLoc in preparation for adding more overloads. NFC Modified: clang-tools-extra/trunk/clangd/AST.cpp

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

This revision was automatically updated to reflect the committed changes. Closed by commit rL368086: [clang-scan-deps] Implementation of dependency scanner over minimized sources (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:287 /*waitForInitialSync=*/true); + if (!DW) return; gribozavr wrote: > plotfi wrote: > > gribozavr wrote:

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:287 /*waitForInitialSync=*/true); + if (!DW) return; plotfi wrote: > gribozavr wrote: > > plotfi wrote: > >

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

Hahnfeld added a comment. Can you detail what "incorrect linking" means? AFAIK the additional sections were just bloating the executable, but how do they affect correctness? Will this patch change the ability to consume a bundled object file without calling the unbundler? Using known ELF tools

[PATCH] D65827: [clang-doc] Fix paths of js in import tags

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM (let's make sure we double check this next time) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65827/new/ https://reviews.llvm.org/D65827

[PATCH] D65827: [clang-doc] Fix paths of js in import tags

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM (let's make sure we double check this

[PATCH] D65000: [ARM] Set default alignment to 64bits

thegameg added a comment. In D65000#1616368 , @dnsampaio wrote: > I have tested this in our MacOS and linux environments. @thakis @thegameg > @phosek, would it be possible for you to check if this works for you? I just built trunk with this patch

[clang-tools-extra] r368087 - [clang-doc] Fix paths of js in import tags

Author: diegoastiazaran Date: Tue Aug 6 13:59:14 2019 New Revision: 368087 URL: http://llvm.org/viewvc/llvm-project?rev=368087=rev Log: [clang-doc] Fix paths of js in import tags HTML requires posix-style paths. Differential Revision: https://reviews.llvm.org/D65827 Modified:

[PATCH] D65828: [clang-tidy] Add check to linuxkernel for unbalanced irq calls

Nathan-Huckleberry created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65828 Files: clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.txt

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi created this revision. plotfi added reviewers: jkorous, compnerd, gribozavr. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Also I went ahead and replaced all the instances of "auto DW = DirectoryWatcher::create" with "llvm::Expected> DW =

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:323 + /*waitForInitialSync=*/false); + // llvm::Expected will throw an error if DW is an Error. + if (!DW)

[PATCH] D65203: [ASTImporter] Do not import FunctionTemplateDecl in record twice.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65203/new/ https://reviews.llvm.org/D65203

[PATCH] D65684: [WebAssembly] Lower ASan constructor priority on Emscripten

This revision was automatically updated to reflect the committed changes. Closed by commit rL368101: [WebAssembly] Lower ASan constructor priority on Emscripten (authored by quantum, committed by ). Changed prior to commit: https://reviews.llvm.org/D65684?vs=213720=213730#toc Repository: rL

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

jkorous added a comment. I was about to suggest something similar. SGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65829/new/ https://reviews.llvm.org/D65829 ___ cfe-commits mailing list

r368102 - hwasan: Instrument globals.

Author: pcc Date: Tue Aug 6 15:07:29 2019 New Revision: 368102 URL: http://llvm.org/viewvc/llvm-project?rev=368102=rev Log: hwasan: Instrument globals. Globals are instrumented by adding a pointer tag to their symbol values and emitting metadata into a special section that allows the runtime to

r368086 - [clang-scan-deps] Implementation of dependency scanner over minimized sources

Author: arphaman Date: Tue Aug 6 13:43:25 2019 New Revision: 368086 URL: http://llvm.org/viewvc/llvm-project?rev=368086=rev Log: [clang-scan-deps] Implementation of dependency scanner over minimized sources This commit implements the fast dependency scanning mode in clang-scan-deps: the

[PATCH] D65827: [clang-doc] Fix paths of js in import tags

This revision was automatically updated to reflect the committed changes. Closed by commit rL368087: [clang-doc] Fix paths of js in import tags (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev added a comment. In D65819#1617736 , @Hahnfeld wrote: > Can you detail what "incorrect linking" means? AFAIK the additional sections > were just bloating the executable, but how do they affect correctness? > > Will this patch change the ability

  1   2   >