[clang-tools-extra] r369238 - [clangd] Added special HighlightingKind for function parameters.

Author: jvikstrom Date: Mon Aug 19 00:51:39 2019 New Revision: 369238 URL: http://llvm.org/viewvc/llvm-project?rev=369238&view=rev Log: [clangd] Added special HighlightingKind for function parameters. Summary: This means that function parameters are no longer highlighted as variable.other.cpp bu

[PATCH] D66335: [clangd] Added special HighlightingKind for function parameters.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369238: [clangd] Added special HighlightingKind for function parameters. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D66206: [CodeGen] Don't keep stale pointers to LoopInfos

ebevhan added a comment. Thanks! I don't have commit access, so it would be great if you could commit this for me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66206/new/ https://reviews.llvm.org/D66206 ___ cfe-co

[PATCH] D66406: [clangd] Update themeRuleMatcher when color theme changes in vscode extension.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Add event listener that listens to configuration changes and reloads the ThemeRuleMatcher when the theme c

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

hokein added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:389 llvm::sort(References, [](const Reference &L, const Reference &R) { - return std::tie(L.Loc, L.CanonicalTarget, L.Role) < - std::tie(R.Loc, R.CanonicalTarget, R.Role); + re

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:389 llvm::sort(References, [](const Reference &L, const Reference &R) { - return std::tie(L.Loc, L.CanonicalTarget, L.Role) < - std::tie(R.Loc, R.CanonicalTarget, R.Role); +

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:389 llvm::sort(References, [](const Reference &L, const Reference &R) { - return std::tie(L.Loc, L.CanonicalTarget, L.Role) < - std::tie(R.L

[PATCH] D66137: [OpenCL][PR42385] Improve addr space deduction for pointers/references to arrays

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, but please clang-format your patch before committing (esp. spacing around binary operators). Comment at: lib/Sema/SemaType.cpp:7396 + // For pointers/references to ar

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom added a comment. @ilya-biryukov @hokein ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64741/new/ https://reviews.llvm.org/D64741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:54 + if (Conflicting.size() > 1) { +Tokens.erase(Tokens.begin() + I, + Tokens.begin() + I + Conflicting.size()); This is potentiall

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:332 + #define DEF_CLASS(T) class T {}; + DEF_MULTIPLE(XYZ); + DEF_MULTIPLE(XYZW); Unrelated to the change: do we plan to highlight mac

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:144 +// sends. +export class Colorizer { + private files: Map> = new Map(); The generic `T` doesnt seem to be used? Regarding the name, the w

[PATCH] D66406: [clangd] Update themeRuleMatcher when color theme changes in vscode extension.

hokein added a comment. the change looks good, but I'd wait until D66219 is finished. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66406/new/ https://reviews.llvm.org/D66406 ___

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. @Meinersbur up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://reviews.llvm.org/D61446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

serge-sans-paille added a reviewer: hfinkel. serge-sans-paille added a subscriber: hfinkel. serge-sans-paille added a comment. Adding @hfinkel to the thread to confirm it's okay to add this behavior, as he authored an RFC on the subject (see https://lists.llvm.org/pipermail/llvm-dev/2016-Novembe

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

mantognini added inline comments. Comment at: docs/ReleaseNotes.rst:209 +Implemented features are: +- Address space behavior is improved in majority of C++ features: + I think Sphinx/RST wants an empty line here. Nitpicking for consistency, could you have a `;`

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65456/new/ https://reviews.llvm.org/D65456 ___ cfe-commits mailing lis

r369251 - [OpenCL] Fix addr space deduction for pointers/references to arrays.

Author: stulova Date: Mon Aug 19 04:43:16 2019 New Revision: 369251 URL: http://llvm.org/viewvc/llvm-project?rev=369251&view=rev Log: [OpenCL] Fix addr space deduction for pointers/references to arrays. Rewrite the logic for detecting if we are deducing addr space of a pointee type to take into a

[PATCH] D66137: [OpenCL][PR42385] Improve addr space deduction for pointers/references to arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rL369251: [OpenCL] Fix addr space deduction for pointers/references to arrays. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

r369253 - [OpenCL] Add generic type handling for builtin functions

Author: svenvh Date: Mon Aug 19 04:56:03 2019 New Revision: 369253 URL: http://llvm.org/viewvc/llvm-project?rev=369253&view=rev Log: [OpenCL] Add generic type handling for builtin functions Generic types are an abstraction of type sets. It mimics the way functions are defined in the OpenCL speci

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL369253: [OpenCL] Add generic type handling for builtin functions (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

kpn added a comment. I don't believe I have any further comments. What do the front-end guys say? Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case LangOptions::FPM_Fast: +break; andrew.w.kaylor wrote: > mibintc

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

russell.gallop accepted this revision. russell.gallop added a comment. This revision is now accepted and ready to land. I don't know a lot about the structure of clang but it LGTM from the point of view of the code and traces coming out. I'm not very keen on having two "Frontend" sections, but I

[PATCH] D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Sorry for the long delay, this LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56343/new/ https://reviews.llvm.org/D56343 _

r369259 - Don't keep stale pointers to LoopInfos.

Author: aaronballman Date: Mon Aug 19 06:37:41 2019 New Revision: 369259 URL: http://llvm.org/viewvc/llvm-project?rev=369259&view=rev Log: Don't keep stale pointers to LoopInfos. CGLoopInfo was keeping pointers to parent loop LoopInfos, but when the loop info vector grew, it reallocated the stor

[PATCH] D66206: [CodeGen] Don't keep stale pointers to LoopInfos

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit for you in r369259, thank you for the patch! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66206/new/ https://reviews.llvm.org/D66206 ___

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

jvikstrom updated this revision to Diff 215886. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Renamed colorizer to highlighter and added FIXME about highlightings below eof. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6621

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

Anastasia updated this revision to Diff 215894. Anastasia added a comment. - Added empty line and ; as requested on the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66294/new/ https://reviews.llvm.org/D66294 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso updated this revision to Diff 215893. Charusso retitled this revision from "[analyzer] CastValueChecker: Store the dynamic types in DynamicTypeMap" to "[analyzer] CastValueChecker: Store the dynamic types and casts". Charusso added a comment. This patch introduces `DynamicCastInfo` simi

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:14 let Component = "Sema" in { -let CategoryName = "Semantic Issue" in { +def warn_stack_exhausted : Warning< + "stack nearly exhausted; compilation time may suffer, and " --

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

MaskRay added a comment. In D65616#1634966 , @serge-sans-paille wrote: > Adding @hfinkel to the thread to confirm it's okay to add this behavior, as > he authored an RFC on the subject (see > https://lists.llvm.org/pipermail/llvm-dev/2016-November/10762

[PATCH] D66365: [clang-tidy] [readability-convert-member-functions-to-static] ignore functions that hide base class methods

aaron.ballman added a comment. I'd like some help in understanding the motivation for this change. The bug report says `But the intention behind this is clearly that there is a member function A::foo which derived classes overwrite.` and I'm not certain that's so clear. It's been my experience

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

Romain-Geissler-1A added a comment. Hi, The only group I know which uses -fsemantic-interposition is the company I work for: Amadeus. Since for now the flag doesn't exist on clang, no we don't know that the future clang implementation doesn't match the gcc one ;) But then we have to wonder if

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:389 llvm::sort(References, [](const Reference &L, const Reference &R) { - return std::tie(L.Loc, L.CanonicalTarget, L.Role) < - std::tie(R.Loc, R.CanonicalTarget, R.Role); +

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom updated this revision to Diff 215907. jvikstrom marked 2 inline comments as done. jvikstrom added a comment. Rewrote conflicting token removal code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64741/new/ https://reviews.llvm.org/D64741

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:54 + if (Conflicting.size() > 1) { +Tokens.erase(Tokens.begin() + I, + Tokens.begin() + I + Conflicting.size()); ilya-biryukov wrote: >

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

Prince781 updated this revision to Diff 215912. Prince781 added a comment. I think this should order the initializers deterministically according to their var declaration order. Let me know if there's something I haven't considered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D66423: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Charusso added a parent revision: D66325: [analyzer] CastValueCh

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM from my side (and a few NIT, but up to you whether to apply them) Comment at: clang-tools-extra/clangd/Sema

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Thanks for addressing my comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66294/new/ https://reviews.llvm.org/D66294 ___

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia updated this revision to Diff 215922. Anastasia added a comment. Added small corrections in various parts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 Files: docs/LanguageExtensions.rst docs/UsersManual.rst Index: docs/UsersMa

[clang-tools-extra] r369275 - [clangd] Added highlighting for tokens that are macro arguments.

Author: jvikstrom Date: Mon Aug 19 09:27:49 2019 New Revision: 369275 URL: http://llvm.org/viewvc/llvm-project?rev=369275&view=rev Log: [clangd] Added highlighting for tokens that are macro arguments. Summary: Adds semantic highlighting for tokens that are a macro argument. Example: ``` D_V(SomeV

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

This revision was automatically updated to reflect the committed changes. jvikstrom marked 2 inline comments as done. Closed by commit rL369275: [clangd] Added highlighting for tokens that are macro arguments. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a sub

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

Prince781 added a comment. In D66122#1633990 , @efriedma wrote: > I think we should send a defect report to the C++ standards committee to > clarify the ambiguity here. I followed the instructions on this page and

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

svenvh accepted this revision. svenvh added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 215938. paulkirth edited the summary of this revision. paulkirth added a comment. - Update CodeGenOptions to remove -fmisexpect - Access the LLVMContext directly - Add -line-tables-only for more accurate diagnostics Fixes various issues with tests and clean

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 215940. paulkirth added a comment. Fix missing context in prior diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basi

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

tejohnson added a comment. Herald added a reviewer: jdoerfert. I had some time to work on this finally late last week. I decided the most straightforward thing was to implement the necessary interface changes to the TLI analysis to make it require a Function (without any changes yet to how that

[PATCH] D52524: Add -Wno-poison-system-directories flag

denik updated this revision to Diff 215945. denik added a comment. Changed Wpoison-system-directories warning to be disabled by default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

r369281 - Implement P1668R1

Author: erichkeane Date: Mon Aug 19 10:39:59 2019 New Revision: 369281 URL: http://llvm.org/viewvc/llvm-project?rev=369281&view=rev Log: Implement P1668R1 Allow inline assembly statements in unexecuted branches of constexpr functions. Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp

[PATCH] D52524: Add -Wno-poison-system-directories flag

denik marked 2 inline comments as done. denik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1071 +// cross-compiling. +def PoisonSystemDirectories : DiagGroup<"poison-system-directories">; + manojgupta wrote: > Please verify tha

[PATCH] D52524: Add -Wno-poison-system-directories flag

manojgupta added inline comments. Comment at: clang/test/Frontend/warning-poison-system-directories.c:12 +// Missing target but included sysroot still causes the warning. +// RUN: %clang -Wpoison-system-directories -I/usr/include --sysroot %S/Inputs/sysroot_x86_64_cross_linux_tr

Re: r369217 - [Diagnostics] Diagnose misused xor as pow

Hi, this results in a false positive on webrtc, on this code: https://cs.chromium.org/chromium/src/third_party/libwebp/src/enc/picture_csp_enc.c?q=picture_csp_enc.c&sq=package:chromium&dr&l=1002 The code does this: #ifdef WORDS_BIGENDIAN #define ALPHA_OFFSET 0 // uint32_t 0xff00 is 0xff,0

r369282 - Update cxx_status.html with P1668 status.

Author: erichkeane Date: Mon Aug 19 10:57:27 2019 New Revision: 369282 URL: http://llvm.org/viewvc/llvm-project?rev=369282&view=rev Log: Update cxx_status.html with P1668 status. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm

Re: r369217 - [Diagnostics] Diagnose misused xor as pow

On Mon, Aug 19, 2019 at 1:53 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi, > > this results in a false positive on webrtc, on this code: > > > https://cs.chromium.org/chromium/src/third_party/libwebp/src/enc/picture_csp_enc.c?q=picture_csp_enc.c&sq=package:chromium&dr&l=

r369284 - Fix test where diagnostics changed in P1668 implementation

Author: erichkeane Date: Mon Aug 19 11:08:52 2019 New Revision: 369284 URL: http://llvm.org/viewvc/llvm-project?rev=369284&view=rev Log: Fix test where diagnostics changed in P1668 implementation Modified: cfe/trunk/test/SemaCXX/cxx1z-constexpr-lambdas.cpp Modified: cfe/trunk/test/SemaCXX/cx

r369286 - Fix poorly formatted HTML in the cxx_status.html file caused by adding

Author: erichkeane Date: Mon Aug 19 11:14:22 2019 New Revision: 369286 URL: http://llvm.org/viewvc/llvm-project?rev=369286&view=rev Log: Fix poorly formatted HTML in the cxx_status.html file caused by adding 1668. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.htm

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

probinson added a comment. "debug-info-no-location.cpp" is an extremely generic name for a very specific case. "debug-info-atexit-stub.cpp" would be better. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. From post commit discussion, Nico Weber: 1. Hi, 2. 3. this results in a false positive on webrtc, on this code: 4. 5. https://cs.chromium.org/chromium/src/third_party/libwebp/src/enc/picture_csp_enc.c?q=picture_csp_enc.c&sq=package:chromium&dr&l=1002 6. 7. The code does

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a subscriber: jfb. xbolva00 added a comment. I agree what @tkanis suggested and be silent if RHS is macro as real world code shows it. Opinions? @jfb @aaron.ballman Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 215957. xbolva00 added a comment. Do not warn if RHS is macro. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: lib/Sema/SemaExpr.cpp test/SemaCXX/warn-xor-as-pow.cpp Index: test/SemaCXX/warn-xor

Re: r369281 - Implement P1668R1

Not sure if this was caught by upstream bots already, but we're seeing a failing test ob our x64 bots: ``` FAIL: Clang :: SemaCXX/cxx1z-constexpr-lambdas.cpp (9574 of 15387) TEST 'Clang :: SemaCXX/cxx1z-constexpr-lambdas.cpp' FAILED Script: -- : 'RUN: at l

RE: r369281 - Implement P1668R1

Yeah, sorry about that. I fixed it in 369284. From: Leonard Chan [mailto:leonardc...@google.com] Sent: Monday, August 19, 2019 11:33 AM To: Keane, Erich Cc: cfe-commits cfe Subject: Re: r369281 - Implement P1668R1 Not sure if this was caught by upstream bots already, but we're seeing a failin

[PATCH] D52524: Add -Wno-poison-system-directories flag

denik updated this revision to Diff 215958. denik marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/include/clang/Basic/DiagnosticGroups.td clang

[PATCH] D52524: Add -Wno-poison-system-directories flag

denik added a comment. Manoj, please check updated diff. Comment at: clang/test/Frontend/warning-poison-system-directories.c:12 +// Missing target but included sysroot still causes the warning. +// RUN: %clang -Wpoison-system-directories -I/usr/include --sysroot %S/Inputs/sysr

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

aaron.ballman added a comment. In D66397#1635715 , @xbolva00 wrote: > I agree what @tkanis suggested and be silent if RHS is macro as real world > code shows it. Opinions? > > @jfb @aaron.ballman I suspect we can come up with examples where the macro on

Re: r369281 - Implement P1668R1

👍 Thanks On Mon, Aug 19, 2019 at 11:34 AM Keane, Erich wrote: > Yeah, sorry about that. I fixed it in 369284. > > > > *From:* Leonard Chan [mailto:leonardc...@google.com] > *Sent:* Monday, August 19, 2019 11:33 AM > *To:* Keane, Erich > *Cc:* cfe-commits cfe > *Subject:* Re: r369281 - Impleme

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. I think it is too soon to jump and disable all macros. We still catch all motivating cases, it found bugs in Chromium. Chromium's case makes sense but on the other hand, LHS does not make much sense to be a macro. #define TWO 2 and res = TWO ^ 32? And even for this

[PATCH] D52524: Add -Wno-poison-system-directories flag

manojgupta added reviewers: rtrieu, aaron.ballman. manojgupta added a comment. Thanks, Adding a few more reviewers since I am not very familiar with this part of clang. Please also update the patch description as suggested by @thakis CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/

Re: r369217 - [Diagnostics] Diagnose misused xor as pow

Yes, #define ALPHA_OFFSET 0x3 should turn off the diagnostic. (We skip hex decimals). Dňa 19. 8. 2019 o 20:06 užívateľ Arthur O'Dwyer napísal: >> On Mon, Aug 19, 2019 at 1:53 PM Nico Weber via cfe-commits >> wrote: > >> Hi, >> >> this results in a false positive on webrtc, on this cod

[PATCH] D66365: [clang-tidy] [readability-convert-member-functions-to-static] ignore functions that hide base class methods

mgehre added a comment. I struggle myself to fully understand the motivation behind the bug report. This is certainly not code that I would write. So I don't really care about that kind of code and I didn't want to be in the way of other people's way of writing C++. Alternatively, we could ask

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

aaron.ballman added a comment. In D66397#1635745 , @xbolva00 wrote: > I think it is too soon to jump and disable all macros. We still catch all > motivating cases, it found bugs in Chromium. I think it's too soon to disable any macros. The workaround fo

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a subscriber: hans. xbolva00 added a comment. >> I think it's too soon to disable any macros. It is hard to say (this was discussed a lot). @tkanis or @hans what do you think? Maybe you could do experiments for us. Comment the code which disables this warning in macros and try i

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

rsmith added a comment. In D66364#1633981 , @aaron.ballman wrote: > My motivation is for portability. _Thread_local (and all the rest) do not > exist in C99 or earlier (or C++), so having some way to warn users of that is > useful. I agree that we shoul

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

fhahn added a comment. I think it would be slightly better to split off the change to disable vectorization via `llvm.loop.vectorize.enable=false` instead of width=1. This changes the behaviour from "disable vectorization, but allow interleaving in the vectoriser" to "disable the vectoriser". I

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Szelethus accepted this revision. Szelethus added a comment. In D66267#1632344 , @Charusso wrote: > I would upstream my hotfix of nullability without any tests as the comment > says the intention and also we have plenty of tests of > `TrackConstraintBR

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

aaron.ballman added reviewers: mclow.lists, ldionne. aaron.ballman added a comment. Herald added a subscriber: dexonsmith. In D66364#1635795 , @rsmith wrote: > In D66364#1633981 , @aaron.ballman > wrote: > > > My m

[PATCH] D66423: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

Szelethus added a comment. Whoa, the test cases look AMAZING! I admit that I haven't read much of the other code just yet, but I like the results in any case. Comment at: clang/test/Analysis/cast-value-notes.cpp:5-27 namespace llvm { template const X *cast(Y Value); tem

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

rnk added a comment. I'd be happy to take this patch, address the comments, and land it, if you don't want to deal with all the nits. Comment at: test/CodeGen/debug-info-no-location.cpp:1 +// RUN: %clang -cc1 -emit-llvm %s -gcodeview -debug-info-kind=limited -o - | FileCheck

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

Quuxplusone added a comment. In D66397#1635796 , @xbolva00 wrote: > Now, Chromium disabled this warning :( until we “fix” it. If Chromium is willing to make build-system changes to add `-Wno-xor-as-pow`, then surely they should also be willing to make t

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. >> suggested source-code fixit of #define ALPHA_OFFSET 0x3 No, there is a note “replace with 0x2 ^ ALPHA_OFFSET” to silence it. While we can suggest as you wrote: #define ALPHA_OFFSET 0x3 I really dont think it is worth to do. CHANGES SINCE LAST ACTION https://revi

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

ldionne added a comment. In D66364#1635814 , @aaron.ballman wrote: > [ ...] > > Adding some libc++ maintainers to see if they have opinions. > > `__extension__` is one option. Could we get away with push/pop disabling of > the diagnostic? Or perhaps this

[PATCH] D66437: Sema: Create a no-op implicit cast for lvalue function conversions.

pcc created this revision. pcc added a reviewer: rsmith. Herald added a project: clang. This fixes an assertion failure in the case where an implicit conversion for a function call involves an lvalue function conversion, and makes the AST for initializations involving implicit lvalue function conv

[PATCH] D66394: clang-cl: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm! I can't believe we didn't notice this for a year. Not long ago a Firefox developer filed a bug for a crash with `-fdelayed-template-parsing`, and if this works for them, we won't have to debug

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aprantl added inline comments. Comment at: test/CodeGen/debug-info-no-location.cpp:4 +// CHECK-NEXT: ret void, !dbg !51 +// CHECK: !48 = distinct !DISubprogram(name: "`dynamic atexit destructor for 'f'", scope: !3, file: !3, line: 16, type: !49, scopeLine: 16, spFlags: DISPFlag

[PATCH] D65453: [analyzer] Improve the accuracy of the Clang call graph analysis

jcranmer-intel updated this revision to Diff 215999. jcranmer-intel added a comment. I think there are use cases for having a callgraph that errs on the side of adding edges that might not exist, but I'm happy enough to leave that for a later patch. This does remind me that we need a real clang

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:363 + OS << "IfsVersion: 1.0\n"; + OS << "Triple: " << T.str() << "\n"; + OS << "Symbols:\n"; This is missing O

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

NoQ added a comment. Yay! I understand the rough idea and it looks perfectly reasonable to start with. Please add FIXMEs/TODOs on how we eventually want to support more complicated inheritance hierarchies. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/Dyn

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:363 +

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

plotfi updated this revision to Diff 216004. plotfi added a comment. Adding ObjectFileFormat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66446/new/ https://reviews.llvm.org/D66446 Files: clang/include/clang/Frontend/FrontendActions.h clang/i

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeMap.h:32 +/// A set of dynamic cast informations. +REGISTER_SET_WITH_PROGRAMSTATE(DynamicCastSet, clang::ento::DynamicCastInfo) NoQ wrote: > Emm, so yo

[PATCH] D66423: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:183 + if (Body) +DRE = dyn_cast(Body); + A body of a function is always either a `CompoundStmt` or (shockingly) a `CXXTryStmt`. This cast will always fail. =

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeMap.h:32 +/// A set of dynamic cast informations. +REGISTER_SET_WITH_PROGRAMSTATE(DynamicCastSet, clang::ento::DynamicCastInfo) Charusso wrote: > NoQ wrote:

[PATCH] D65453: [analyzer] Improve the accuracy of the Clang call graph analysis

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! I'll try to land again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65453/new/ https://reviews.llvm.org/D65453 ___ cfe-commits maili

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeMap.h:32 +/// A set of dynamic cast informations. +REGISTER_SET_WITH_PROGRAMSTATE(DynamicCastSet, clang::ento::DynamicCastInfo) NoQ wrote: > Charusso w

[PATCH] D66068: cmake: Make building clang-shlib optional

jvesely added a comment. Hi, sorry for the delay. I fully understand the need to reduce the number of options. Having always used SHARED_LIBS build I remember weekly shared build breakages. That said, forcing everyone to build one huge library effectively makes debug builds unusable in any pra

r369308 - [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

Author: anton-afanasyev Date: Mon Aug 19 15:58:26 2019 New Revision: 369308 URL: http://llvm.org/viewvc/llvm-project?rev=369308&view=rev Log: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks Summary: Add `Frontend` time trace entry to `HandleTranslationUnit()` function

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL369308: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks (authored by anton-afanasyev, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://r

[PATCH] D52524: Add -Wpoison-system-directories warning

denik updated this revision to Diff 216021. denik added a comment. Removed check for libraries. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/include/clang/Basic/DiagnosticGro

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

pcc added a comment. In D63932#1610182 , @ostannard wrote: > > Partial linking will indeed prevent dropping the virtual functions, but it > > should not prevent clearing the pointer to the virtual function in the > > vtable. The linker should then be abl

  1   2   >