[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

sammccall updated this revision to Diff 218432. sammccall added a comment. fix accidental reverted change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66751/new/ https://reviews.llvm.org/D66751 Files: clang-tools-extra/clangd/CMakeLists.txt

r370744 - [OpenCL] Drop spurious semicolon in generated file; NFC

Author: svenvh Date: Tue Sep 3 04:23:24 2019 New Revision: 370744 URL: http://llvm.org/viewvc/llvm-project?rev=370744=rev Log: [OpenCL] Drop spurious semicolon in generated file; NFC Modified: cfe/trunk/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp Modified:

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

sammccall updated this revision to Diff 218436. sammccall added a comment. describe refactoring features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67092/new/ https://reviews.llvm.org/D67092 Files:

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

gribozavr added inline comments. Comment at: llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp:5836-5837 if (VT.getSizeInBits() == 128) return std::make_pair(0U, ::FPR128_loRegClass); +case 'y': + if (!Subtarget->hasFPARMv8()) ```

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

hokein updated this revision to Diff 218422. hokein marked an inline comment as done. hokein added a comment. Use a matcher to catch all template arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66945/new/ https://reviews.llvm.org/D66945

[clang-tools-extra] r370750 - Fix MSVC "not all control paths return a value" warning. NFCI.

Author: rksimon Date: Tue Sep 3 06:05:13 2019 New Revision: 370750 URL: http://llvm.org/viewvc/llvm-project?rev=370750=rev Log: Fix MSVC "not all control paths return a value" warning. NFCI. Modified: clang-tools-extra/trunk/clangd/FindTarget.cpp Modified:

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks for working on this! Comment at: clang-tools-extra/clangd/clients/clangd-vscode/README.md:5 -## Usage + - code completion + - compile errors and warnings

[clang-tools-extra] r370746 - [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

Author: sammccall Date: Tue Sep 3 04:35:50 2019 New Revision: 370746 URL: http://llvm.org/viewvc/llvm-project?rev=370746=rev Log: [clangd] Add targetDecl(), which determines what declaration an AST node refers to. Summary: This is the first part of an effort to "unbundle" our libIndex use into

[PATCH] D65863: [ARM] Add support for the s,j,x,N,O inline asm constraints

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM with one small change. Comment at: clang/test/Sema/arm_inline_asm_constraints.c:47 +// I: An immediate integer valid for a data-processing instruction.

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Will commit for you as requested soon. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added a comment. In D66042#1655119 , @sylvestre.ledru wrote: > @Charusso This probably should be added to the release notes: > https://clang.llvm.org/docs/ReleaseNotes.html#static-analyzer > and detailed in the doc. > Please let me know if

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk created this revision. kousikk added a reviewer: arphaman. Herald added subscribers: cfe-commits, jfb, dexonsmith. Herald added a project: clang. Scan deps tool crashes when called on a C++ file, containing an include that has the same name as a directory. For example: test.cpp: #include

[PATCH] D66572: [analyzer] NFC: BugReporter Separation Ep.I.

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:108 + + StringRef getDescription() const { return Description; } + gribozavr wrote: > What's the difference between description and short

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp:105 } // Mark using declarations as used by setting FoundDecls' value to zero. As // the AST is walked in order, usages are only marked after a the

r370716 - [ARM NEON] Avoid duplicated decarations

Author: dnsampaio Date: Tue Sep 3 02:16:44 2019 New Revision: 370716 URL: http://llvm.org/viewvc/llvm-project?rev=370716=rev Log: [ARM NEON] Avoid duplicated decarations Summary: The declaration of arm neon intrinsics that are "big endian safe" print the same code for big and small endian

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL370716: [ARM NEON] Avoid duplicated decarations (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r370740 - Fixit for -Wfinal-dtor-non-final-class

Author: xbolva00 Date: Tue Sep 3 03:54:25 2019 New Revision: 370740 URL: http://llvm.org/viewvc/llvm-project?rev=370740=rev Log: Fixit for -Wfinal-dtor-non-final-class Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp cfe/trunk/test/SemaCXX/warn-final-dtor-non-final-class.cpp Modified:

[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370746: [clangd] Add targetDecl(), which determines what declaration an AST node refers… (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

hokein added a comment. could we move the png files to a separate directory like `clangd/clients/clangd-vscode/assets`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67092/new/ https://reviews.llvm.org/D67092

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

sammccall updated this revision to Diff 218437. sammccall added a comment. mention rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67092/new/ https://reviews.llvm.org/D67092 Files:

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

dnsampaio updated this revision to Diff 218412. dnsampaio added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66588/new/ https://reviews.llvm.org/D66588 Files: clang/utils/TableGen/NeonEmitter.cpp Index:

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

hokein updated this revision to Diff 218423. hokein added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66945/new/ https://reviews.llvm.org/D66945 Files: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

xbolva00 added a comment. rL370737 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66711/new/ https://reviews.llvm.org/D66711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/README.md:95 + - use raw strings + - rerame (bound to ``, rather than a contextual code action) + s/rerame/rename Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/README.md:5 -## Usage + - code completion + - compile errors and warnings kadircet wrote: > can we also have links to

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

sammccall updated this revision to Diff 218438. sammccall marked an inline comment as done. sammccall added a comment. move images into doc-assets/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67092/new/ https://reviews.llvm.org/D67092 Files:

r370737 - Added fixit notes for -Wfinal-dtor-non-final-class

Author: xbolva00 Date: Tue Sep 3 03:32:21 2019 New Revision: 370737 URL: http://llvm.org/viewvc/llvm-project?rev=370737=rev Log: Added fixit notes for -Wfinal-dtor-non-final-class Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp cfe/trunk/test/SemaCXX/warn-final-dtor-non-final-class.cpp

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:1 +//===- unittest/AST/ASTImporterTest.cpp - AST node import test ===// +// Change the file name here? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

sammccall created this revision. sammccall added reviewers: hokein, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Relegate "updating the extension" docs to a separate file. Repository: rG LLVM Github Monorepo

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/README.md:9 + - include management + - code formatting sammccall wrote: > kadircet wrote: > > what about code-actions(and also some screenshots) > Added a section for

[PATCH] D66796: [clang] Loop pragma vectorize(disable)

SjoerdMeijer added a comment. friendly ping. Shall we get this in, so that I can commit this and D66290 ? Then, we can perhaps continue the interleave discussion separately? I will then return to the doc patch first in D66199

[PATCH] D66042: [analyzer] Analysis: Silence checkers

sylvestre.ledru added a comment. @Charusso This probably should be added to the release notes: https://clang.llvm.org/docs/ReleaseNotes.html#static-analyzer and detailed in the doc. Please let me know if you need help! Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D66591: [RISCV] Correct Logic around ilp32e macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL370709: [RISCV] Correct Logic around ilp32e macros (authored by lenary, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

ilya-biryukov added a comment. In D66990#1655030 , @nridge wrote: > I was hoping though that a patch like this, which would bring us largely to > parity with Eclipse CDT's highlightings, wouldn't need to blocked on a change > to the upstream protocol

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

lenary added a comment. Backported to 9.0 in rL370181 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57450/new/ https://reviews.llvm.org/D57450 ___ cfe-commits mailing list

r370709 - [RISCV] Correct Logic around ilp32e macros

Author: lenary Date: Tue Sep 3 01:47:58 2019 New Revision: 370709 URL: http://llvm.org/viewvc/llvm-project?rev=370709=rev Log: [RISCV] Correct Logic around ilp32e macros Summary: GCC seperates the `__riscv_float_abi_*` macros and the `__riscv_abi_rve` macro. If the chosen abi is ilp32e, `gcc

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113 const semanticHighlightingFeature = - new semanticHighlighting.SemanticHighlightingFeature(); + new semanticHighlighting.SemanticHighlightingFeature( +

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67096 Files:

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc

erichkeane added a comment. I prefer this to be in the place where the ifunc gets created, otherwise we definitely need tests. There are sufficient tests for this that show the ifunc having been created, so I'd suggest just adding to them. Comment at:

[clang-tools-extra] r370763 - [clangd] Remove redundant semi-colon.

Author: hliao Date: Tue Sep 3 08:02:46 2019 New Revision: 370763 URL: http://llvm.org/viewvc/llvm-project?rev=370763=rev Log: [clangd] Remove redundant semi-colon. Modified: clang-tools-extra/trunk/clangd/FindTarget.cpp Modified: clang-tools-extra/trunk/clangd/FindTarget.cpp URL:

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

hokein updated this revision to Diff 218450. hokein marked 3 inline comments as done. hokein added a comment. Update the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66945/new/ https://reviews.llvm.org/D66945 Files:

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp:105 } // Mark using declarations as used by setting FoundDecls' value to zero. As // the AST is walked in order, usages are only marked after a the

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

hokein closed this revision. hokein added a comment. committed in rL370760 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66945/new/ https://reviews.llvm.org/D66945

[PATCH] D67095: [SVE][Inline-Asm] Fix -Wimplicit-fallthrough in AArch64ISelLowering.cpp

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, rovka, cameron.mcinally, greened, gribozavr, ruiu. Herald added subscribers: psnobl, rkruppe, kristof.beyls, tschuett, javed.absar. Herald added a project: LLVM. Adds break to 'x' case in getRegForInlineAsmConstraint

[clang-tools-extra] r370758 - [clangd] Fix a data race in test code

Author: ibiryukov Date: Tue Sep 3 06:56:03 2019 New Revision: 370758 URL: http://llvm.org/viewvc/llvm-project?rev=370758=rev Log: [clangd] Fix a data race in test code Found by TSan, thanks bkramer for pointing this out. Modified:

[clang-tools-extra] r370760 - [clang-tidy] Fix a false positive in unused-using-decl check

Author: hokein Date: Tue Sep 3 07:13:00 2019 New Revision: 370760 URL: http://llvm.org/viewvc/llvm-project?rev=370760=rev Log: [clang-tidy] Fix a false positive in unused-using-decl check The previous matcher "hasAnyTemplateArgument(templateArgument())" only matches the first template argument,

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

hokein updated this revision to Diff 218452. hokein marked 2 inline comments as done. hokein added a comment. address the comment, don't register the feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67096/new/ https://reviews.llvm.org/D67096

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113 const semanticHighlightingFeature = - new semanticHighlighting.SemanticHighlightingFeature(); + new semanticHighlighting.SemanticHighlightingFeature(

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

sammccall updated this revision to Diff 218444. sammccall added a comment. Fix mailing list link again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67092/new/ https://reviews.llvm.org/D67092 Files:

[clang-tools-extra] r370757 - [clangd] Wrong attribute on debug function in r370746

Author: sammccall Date: Tue Sep 3 06:54:27 2019 New Revision: 370757 URL: http://llvm.org/viewvc/llvm-project?rev=370757=rev Log: [clangd] Wrong attribute on debug function in r370746 Modified: clang-tools-extra/trunk/clangd/FindTarget.cpp Modified:

[PATCH] D67095: [SVE][Inline-Asm] Fix -Wimplicit-fallthrough in AArch64ISelLowering.cpp

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67095/new/ https://reviews.llvm.org/D67095 ___

[clang-tools-extra] r370759 - [clangd] Decouple macro/decl-under-cursor finding. Don't pretend there can be multiple macros. NFC.

Author: sammccall Date: Tue Sep 3 07:12:48 2019 New Revision: 370759 URL: http://llvm.org/viewvc/llvm-project?rev=370759=rev Log: [clangd] Decouple macro/decl-under-cursor finding. Don't pretend there can be multiple macros. NFC. Modified: clang-tools-extra/trunk/clangd/XRefs.cpp

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113 const semanticHighlightingFeature = - new semanticHighlighting.SemanticHighlightingFeature(); + new semanticHighlighting.SemanticHighlightingFeature(

[PATCH] D66524: [SVE][Inline-Asm] Add constraints for SVE predicate registers

greened added inline comments. Comment at: docs/LangRef.rst:3818 +- ``Upl``: One of the low eight SVE predicate registers (P0 to P7) +- ``Upa``: Any of the SVE predicate registers (P0 to P15) What do these names mean? " predicate lower|all?" I see they are

r370767 - [analyzer] Add a checker option to detect nested dead stores

Author: szelethus Date: Tue Sep 3 08:22:43 2019 New Revision: 370767 URL: http://llvm.org/viewvc/llvm-project?rev=370767=rev Log: [analyzer] Add a checker option to detect nested dead stores Enables the users to specify an optional flag which would warn for more dead stores. Previously it

r370773 - [LifetimeAnalysis] Fix some false positives

Author: xazax Date: Tue Sep 3 09:17:24 2019 New Revision: 370773 URL: http://llvm.org/viewvc/llvm-project?rev=370773=rev Log: [LifetimeAnalysis] Fix some false positives Differential Revision: https://reviews.llvm.org/D66806 Modified: cfe/trunk/lib/Sema/SemaInit.cpp

[PATCH] D66806: [LifetimeAnalysis] Fix some false positives

This revision was automatically updated to reflect the committed changes. Closed by commit rL370773: [LifetimeAnalysis] Fix some false positives (authored by xazax, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2957 +if (!AliasFunc) { + auto *IFunc = cast(GetOrCreateLLVMFunction( + AliasName, DeclTy, GD, /*ForVTable=*/false, /*DontDefer=*/true, erichkeane wrote: > I

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp:31-32 + + if (!MatchedDecl->isLocalVarDecl()) +return; + jpakkane wrote: > aaron.ballman wrote: > > I think this should be made into a

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 218478. dgatwood added a comment. Incorporated feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65917/new/ https://reviews.llvm.org/D65917 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt

[PATCH] D66699: [PowerPC][Altivec] Fix constant argument for vec_dss

jsji marked 2 inline comments as done. jsji added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-error.c:78 +void testDSS(int index) { + vec_dss(index); //expected-error {{argument to '__builtin_altivec_dss' must be a constant integer}} + wuzish

[PATCH] D66699: [PowerPC][Altivec] Fix constant argument for vec_dss

jsji updated this revision to Diff 218479. jsji added a comment. Add range check and test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66699/new/ https://reviews.llvm.org/D66699 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 +- New :doc:`google-objc-require-category-method-prefixes + ` check. Please sort new checks list alphabetically. CHANGES SINCE LAST ACTION

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113 const semanticHighlightingFeature = - new semanticHighlighting.SemanticHighlightingFeature(); + new semanticHighlighting.SemanticHighlightingFeature(

[clang-tools-extra] r370768 - [clangd] Move getBeginningOfIdentifier from ClangdUnit to SourceCode. Drop dependencies on ClangdUnit from some headers. NFC

Author: sammccall Date: Tue Sep 3 08:34:47 2019 New Revision: 370768 URL: http://llvm.org/viewvc/llvm-project?rev=370768=rev Log: [clangd] Move getBeginningOfIdentifier from ClangdUnit to SourceCode. Drop dependencies on ClangdUnit from some headers. NFC Modified:

[PATCH] D50294: [Driver] Use -gdwarf-3 by default for FreeBSD

MaskRay abandoned this revision. MaskRay added a comment. Abandon due to D66760 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50294/new/ https://reviews.llvm.org/D50294 ___

r370779 - clang: default to DWARF 4 for FreeBSD 12.0 and later

Author: emaste Date: Tue Sep 3 09:30:21 2019 New Revision: 370779 URL: http://llvm.org/viewvc/llvm-project?rev=370779=rev Log: clang: default to DWARF 4 for FreeBSD 12.0 and later Older FreeBSD versions included GDB 6.1 and had other tools that were unable to handle debug information newer than

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

This revision was automatically updated to reflect the committed changes. Closed by commit rL370767: [analyzer] Add a checker option to detect nested dead stores (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113 const semanticHighlightingFeature = - new semanticHighlighting.SemanticHighlightingFeature(); + new

[PATCH] D67095: [SVE][Inline-Asm] Fix -Wimplicit-fallthrough in AArch64ISelLowering.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL370769: [SVE][Inline-Asm] Fix -Wimplicit-fallthrough in AArch64ISelLowering.cpp (authored by kmclaughlin, committed by ). Changed prior to commit: https://reviews.llvm.org/D67095?vs=218443=218463#toc

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

kmclaughlin marked an inline comment as done. kmclaughlin added a subscriber: ruiu. kmclaughlin added a comment. Thank you to @gribozavr & @ruiu for spotting the warning caused by this patch, and the suggestions to use -Wimplicit-fallthrough! Comment at:

r370792 - [CUDA] Use activemask.b32 instruction to implement __activemask w/ CUDA-9.2+

Author: tra Date: Tue Sep 3 10:31:58 2019 New Revision: 370792 URL: http://llvm.org/viewvc/llvm-project?rev=370792=rev Log: [CUDA] Use activemask.b32 instruction to implement __activemask w/ CUDA-9.2+ vote.ballot instruction is gone in recent CUDA versions and vote.sync.ballot can not be used

[PATCH] D67113: ICK_Function_Conversion and ICK_Qualification are third kind conversions

aaronpuchert created this revision. aaronpuchert added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Not sure if this has any effect, but it was inconsistent before. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67113 Files:

r370795 - [www] Mark items complete in Clang 9 as 'Clang 9' rather than 'SVN'.

Author: rsmith Date: Tue Sep 3 10:49:51 2019 New Revision: 370795 URL: http://llvm.org/viewvc/llvm-project?rev=370795=rev Log: [www] Mark items complete in Clang 9 as 'Clang 9' rather than 'SVN'. Don't turn the boxes green yet, since Clang 9 hasn't been released. Modified:

r370798 - [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

Author: szelethus Date: Tue Sep 3 10:57:01 2019 New Revision: 370798 URL: http://llvm.org/viewvc/llvm-project?rev=370798=rev Log: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message There are some functions which can't be given a null pointer as parameter

[PATCH] D67119: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher

dim created this revision. dim added reviewers: emaste, jhibbits, hfinkel. Herald added subscribers: steven.zhang, shchenz, jsji, MaskRay, kbarton, krytarowski, nemanjai. Herald added a project: clang. In https://svnweb.freebsd.org/changeset/base/349351, FreeBSD 13 and higher transitioned to

r370807 - Unbreak the build after r370798

Author: d0k Date: Tue Sep 3 11:24:56 2019 New Revision: 370807 URL: http://llvm.org/viewvc/llvm-project?rev=370807=rev Log: Unbreak the build after r370798 Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/NonNullParamChecker.cpp Modified:

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

leonardchan added a comment. Hi! We've noticed that for our arm bots, we're getting some flaky builds that sometimes fail with `error: array designators are a C99 extension [-Werror,-Wc99-designator]` and sometimes don't fail. 2 questions: 1. I can't see it off the patch immediately, but do

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 218511. jpakkane added a comment. Updated patch as per review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane marked 6 inline comments as done. jpakkane added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp:31-32 + + if (!MatchedDecl->isLocalVarDecl()) +return; + aaron.ballman wrote: > jpakkane wrote: > >

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

nridge added a comment. In D66990#1655175 , @ilya-biryukov wrote: > In D66990#1655030 , @nridge wrote: > > > I was hoping though that a patch like this, which would bring us largely to > > parity with Eclipse

Re: [PATCH] D66361: Improve behavior in the case of stack exhaustion.

On Tue, Sep 03, 2019 at 06:02:28PM +, Richard Smith - zygoloid via Phabricator via cfe-commits wrote: > rsmith added a comment. > > In D66361#1655903 , @krytarowski > wrote: > > > This change broke on NetBSD. > > > >

[PATCH] D66830: Consumed checker: various improvements

dblaikie added a comment. Likely best to separate these changes into separate/standalone patches - easier to review/see what's changing, what the motivation is, etc. (I'm probably OK with some breakage here - to the best of my knowledge these attributes haven't achieved widespread adoption, so

[PATCH] D66572: [analyzer] NFC: BugReporter Separation Ep.I.

Szelethus added a comment. Also, thank you @gribozavr for your comments -- its very nice to have someone review a bigger part of our development interface who is knowledgeable about Clang, but not the Static Analyzer specifically. Looking at your inlines, these are very fair criticisms, I

[PATCH] D67117: [clangd] Split Preamble.h out of ClangdUnit.h. NFC

sammccall created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, MaskRay, javed.absar, ilya-biryukov, mgorny. Herald added a project: clang. Add comment describing use of preamble in clangd. Remove deps on ClangdUnit.h where possible. Repository:

r370801 - Disable stack exhaustion test on NetBSD, where either the detection or

Author: rsmith Date: Tue Sep 3 11:00:44 2019 New Revision: 370801 URL: http://llvm.org/viewvc/llvm-project?rev=370801=rev Log: Disable stack exhaustion test on NetBSD, where either the detection or recovery mechanism does not appear to work. Modified:

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri added a comment. In D67122#1656189 , @aaron.ballman wrote: > One fear I have with this is in expansions of the `offsetof` macro, where it > is a common implementation strategy to cast a null pointer to be of the > correct type when

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:240 + Arg = Arg->IgnoreImpCasts(); + if (isa(Arg)) + Arg = cast(Arg)->getSubExpr(); The bug claims that this is only for handling negative

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

Szelethus accepted this revision. Szelethus added a comment. Other then the things @gribozavr mentioned, LGTM. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:458 +public: + typedef llvm::SmallVector, 4> ReportList; + using iterator =

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood marked 17 inline comments as done. dgatwood added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:57 + } + std::string method_name = method_declaration->getNameAsString(); + auto owning_objc_class_interface =

[PATCH] D46791: Make -gsplit-dwarf generally available

emaste added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46791/new/ https://reviews.llvm.org/D46791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66988/new/ https://reviews.llvm.org/D66988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

tlively abandoned this revision. tlively added a comment. Abandoning in favor of @sunfish's idea for introducing a cost mechanism for shuffle masks in DAGCombiner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66983/new/

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

aaron.ballman added a comment. One fear I have with this is in expansions of the `offsetof` macro, where it is a common implementation strategy to cast a null pointer to be of the correct type when calculating member offsets. Do you think you will be able to distinguish between null pointer

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

xbolva00 added inline comments. Comment at: compiler-rt/test/ubsan/TestCases/Pointer/index-overflow.cpp:15 + // ERR2: runtime error: pointer index expression with base {{.*}} overflowed to + // ERR1: runtime error: subtracting integral value of non-null pointer 0x{{.*}} from

[PATCH] D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

aganea marked an inline comment as done. aganea added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3581 +llvm::DILocalScope *PrevScope = +!LexicalBlockStack.empty() +? dyn_cast(LexicalBlockStack.back()) aganea wrote: > rnk

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri updated this revision to Diff 218519. lebedev.ri added a comment. Add test that show that `__builtin_offsetof()` / `((uintptr_t)(&(((S *)nullptr)->y)))` are already not sanitized. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67122/new/

[PATCH] D67052: Add reference type transformation builtins

Mordante added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1095 + default: +assert(false && "Not a reference type specifier"); + } Wouldn't it be better to use `llvm_unreachable("Not a reference type specifier");` Maybe also move this

[PATCH] D66572: [analyzer] NFC: BugReporter Separation Ep.I.

NoQ marked 2 inline comments as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:186 + /// ranges. + void addRange(SourceRange R) { +assert((R.isValid() || Ranges.empty()) && "Invalid range can only be used "

[PATCH] D67135: Support proto repeated field in performence-inefficient-vector-operation

Eugene.Zelenko added a comment. Please mention new option in Release Notes. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-inefficient-vector-operation.rst:9 +When EnableProto, also finds calls that add element to protobuf repeated field +in a loop without

  1   2   >