[clang] ccfab8e - [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

Author: Raphael Isemann Date: 2019-12-17T09:40:36+01:00 New Revision: ccfab8e4596e59c8eea6b3610cd163c5d0312193 URL: https://github.com/llvm/llvm-project/commit/ccfab8e4596e59c8eea6b3610cd163c5d0312193 DIFF:

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:556 +// FIXME: Drop default arguments. +HI.Name = "Foo"; +HI.Kind = index::SymbolKind::Class;

[clang] df5a905 - [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387)

Author: Sven van Haastregt Date: 2019-12-17T11:10:06Z New Revision: df5a905aa8a868bdb700d88e427491ee56243e30 URL: https://github.com/llvm/llvm-project/commit/df5a905aa8a868bdb700d88e427491ee56243e30 DIFF: https://github.com/llvm/llvm-project/commit/df5a905aa8a868bdb700d88e427491ee56243e30.diff

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 234262. serge-sans-paille added a comment. Take remarks into account: - support sprintf when the buffer has a known static size - use llvm::Optional - some extra minor tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille marked 7 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:370 // FIXME: There are some more useful checks we could be doing here: // - Analyze the format string of sprintf to see how much of

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:372 +T.print(OS, Policy); +OS.flush(); + } NIT: is flush redundant? I believe it's called in destructor Comment at:

[PATCH] D71598: [clangd] Filter implicit references from index while renaming

kbobyrev created this revision. kbobyrev added reviewers: ilya-biryukov, kadircet. kbobyrev added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman, mgrang, jkorous, MaskRay. When asked for references during cross-file rename, index might return implicit references to

[PATCH] D71597: [clangd][NFC] Make use of TagDecl inside type for hover on auto

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. We were traversing AST twice to get the Decl in case of sugared types(auto, decltype). They seem to be same in

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

Ka-Ka updated this revision to Diff 234268. Ka-Ka marked 2 inline comments as done. Ka-Ka added a comment. Updated patch according to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70527/new/ https://reviews.llvm.org/D70527 Files:

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1787571 , @ABataev wrote: > In D71241#1787265 , @hfinkel wrote: > > > In D71241#1786959 , @jdoerfert > > wrote: > > > > > In

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2519-2520 return VarLinkage; + // On Windows, WeakODR is a no-op, boiling down to the same as normal external + // linkage. + if

[PATCH] D71597: [clangd][NFC] Make use of TagDecl inside type for hover on auto

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60932 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers comdat on Windows

mstorsjo updated this revision to Diff 234269. mstorsjo retitled this revision from "[ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows" to "[ItaniumCXXABI] Make tls wrappers comdat on Windows". mstorsjo edited the summary of this revision. mstorsjo added a

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

This revision was automatically updated to reflect the committed changes. Closed by commit rG4becf68c6f17: [ASTImporter] Friend class decl should not be visible in its context (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. In D71451#1786517 , @dblaikie wrote: > Do you have any particular users/use case for this? A case when shared library built without debug info and executable with debug info. And while debugging we want to know the types of

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:392 + EstimateSizeFormatHandler H(StrE); + StringRef StrRef = StrE->getString(); + const char *Str = StrRef.data();

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 234282. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. - Prevent assert upon wide string format - More test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

hokein added a comment. @ilya-biryukov thanks for taking it during my OOO, just a drive-by comment :) Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:86 +// Add macro references. +for (const auto : MacroRefsToIndex->MacroRefs) { + for (const auto :

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

thakis added a comment. Mordante, do you need someone to land this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68913/new/ https://reviews.llvm.org/D68913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71598: [clangd] Filter implicit references from index while renaming

hokein added a comment. (apologies, the FIXME may imply this approach...) this approach is based on an assumption: the index results are matched to the latest file content, but this is not always true in practice, our index maybe stale (index results came from an old snapshot of the file),

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60932 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:353 /// Generate a \p Hover object given the type \p T. HoverInfo getHoverContents(QualType T, const Decl *D, ASTContext , + const SymbolIndex *Index) {

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 updated this revision to Diff 234273. Jac1494 added a comment. Separate clang patch with test cases . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/ https://reviews.llvm.org/D71451 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

This revision was automatically updated to reflect the committed changes. Closed by commit rGddd0bb8dba2a: [lit] Remove lits REQUIRES-ANY directive (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71408/new/

[clang] 4becf68 - [ASTImporter] Friend class decl should not be visible in its context

Author: Gabor Marton Date: 2019-12-17T14:48:55+01:00 New Revision: 4becf68c6f17fe143539ceac954b21175914e1c1 URL: https://github.com/llvm/llvm-project/commit/4becf68c6f17fe143539ceac954b21175914e1c1 DIFF: https://github.com/llvm/llvm-project/commit/4becf68c6f17fe143539ceac954b21175914e1c1.diff

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1787265 , @hfinkel wrote: > In D71241#1786959 , @jdoerfert wrote: > > > In D71241#1786530 , @ABataev wrote: > > > > > Most probably, we

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:329 + +def non_faulting_load : + PatFrag<(ops node:$ptr, node:$pred, node:$def), This duplicates a lot of code, maybe it makes sense to combine this into a multiclass.

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

SouraVX added a comment. > It looks like this implementation is a bit buggy in one way and incomplete in > another: > > 1. even if the auto-returning function is defined, that function definition > doesn't describe the concrete return type. Compare GCC and Clang's output for > your example

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

adalava created this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, steven.zhang, shchenz, jsji, jfb, krytarowski, arichardson, nemanjai, emaste. Herald added a reviewer: jfb. Herald added projects: clang, Sanitizers, LLVM. adalava added a reviewer: dim. Herald added

[PATCH] D71133: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387)

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf5a905aa8a8: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387) (authored by svenvh). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Clangd didn't fill documentation for `auto` when it wasn't available in index. Also it wasn't showing any

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

Ka-Ka added a comment. In D70527#1786718 , @rnk wrote: > In D70527#1785552 , @ikudrin wrote: > > > Personally, I would prefer to see the file name and path to be changed as > > little as possible because that

[PATCH] D71476: [OpenCL] Add builtin function extension handling

svenvh marked 2 inline comments as done. svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:51 +// Extension associated to a builtin function. +class FunctionExtension : AbstractExtension<_Ext>; + Anastasia wrote: > Are we planning to add

[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

ilya-biryukov added a comment. In addition to that, NFC is also often used as a way to tag commits that should not cause any problems. wrt to this change, I don't think anything was done wrong. It even went through review, although often we don't send reviews for NFC changes. Downstream

[PATCH] D71586: [clangd] Add a test case that verifies -fimplicit-modules work in Clangd when building the AST

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. +1, please add a unit test instead. We prefer to keep the number of lit tests in clangd minimal. They're mostly testing the LSP layer and other things which are hard to

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

ilya-biryukov added a comment. In D71543#1785842 , @kadircet wrote: > I've got D71545 to reduce that regression. D71545 seems to be pretty small, yet depends on this change. Maybe add

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:353 /// Generate a \p Hover object given the type \p T. HoverInfo getHoverContents(QualType T, const Decl *D, ASTContext , + const SymbolIndex *Index) {

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:556 +// FIXME: Drop default arguments. +HI.Name = "Foo"; +HI.Kind = index::SymbolKind::Class; NIT: Maybe remove default

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

kadircet updated this revision to Diff 234250. kadircet added a comment. - Delete fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71543/new/ https://reviews.llvm.org/D71543 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

kadircet updated this revision to Diff 234249. kadircet added a comment. - Squash follow-ups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71543/new/ https://reviews.llvm.org/D71543 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:353 /// Generate a \p Hover object given the type \p T. HoverInfo getHoverContents(QualType T, const Decl *D, ASTContext , +

[PATCH] D70157: Align branches within 32-Byte boundary

annita.zhang added a comment. In D70157#1787160 , @MaskRay wrote: > > There is a precedant: .pushsection/.popsection (MCStreamer::SectionStack). > With .push_align_branch/.pop_align_branch, we probably don't need the > 'switch-to-default' action. >

[clang] ddd0bb8 - [lit] Remove lit's REQUIRES-ANY directive

Author: Thomas Preud'homme Date: 2019-12-17T10:36:36Z New Revision: ddd0bb8dba2a367c6aa8a25e98915509847745ce URL: https://github.com/llvm/llvm-project/commit/ddd0bb8dba2a367c6aa8a25e98915509847745ce DIFF: https://github.com/llvm/llvm-project/commit/ddd0bb8dba2a367c6aa8a25e98915509847745ce.diff

[PATCH] D71586: [clangd] Add a test case that verifies -fimplicit-modules work in Clangd when building the AST

kadircet added a comment. Can we add a unit test instead of(or in addition to) this one? I suppose it should be easy to right one using `TestTU` with `ExtraArgs` and `AdditionalFiles` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71586/new/

[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1786901 , @reames wrote: > Noting another issue we found in local testing (with an older version of this > patch). This interacts badly with the implicit exception mechanism in LLVM. > For that mechanism, we end up

[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

kbobyrev added a comment. In D71455#1787266 , @MaskRay wrote: > Renaming `handleDeclOccurence`, `handleMacroOccurence` and > `handleModuleOccurence` are definitely not NFC because they are public APIs > that can be used by downstream projects. I'm

[PATCH] D71476: [OpenCL] Add builtin function extension handling

Nicola accepted this revision. Nicola added a comment. Just a minor comment, can you address it before you submit? Thanks! Comment at: clang/lib/Sema/OpenCLBuiltins.td:1095 // OpenCL v2.0 s9.17.3: Additions to section 6.13.1: Work-Item Functions +def FuncExtKhrSubgroups :

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

labath added a comment. In D71508#1785767 , @probinson wrote: > Do we have a similar problem if the filespec has an embedded ./ or ../ in it? > I'm thinking some broader canonicalization ought to be done here. > $ clang ./dir1/dir2/../dir3/file.c >

[PATCH] D71594: testing clang-tidy

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. goncharov removed subscribers: jkorous, arphaman, kadircet, usaxena95, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D71400: [RFC] [MinGW] Implicitly add .exe suffix if not provided

This revision was automatically updated to reflect the committed changes. Closed by commit rGee0a3b5c776c: [MinGW] Implicitly add .exe suffix if not provided (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71400/new/

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

mstorsjo marked 2 inline comments as done. mstorsjo added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2519-2520 return VarLinkage; + // On Windows, WeakODR is a no-op, boiling down to the same as normal external + // linkage. + if

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

This revision was automatically updated to reflect the committed changes. Closed by commit rGccfab8e4596e: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60932 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71607: Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Many C++ programmers are unaware that an expression of unsigned - signed will promote the signed argument to unsigned, and the resulting underflow produces a large positive rather than negative

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

kadircet abandoned this revision. kadircet marked an inline comment as done. kadircet added a comment. integrated into D71543 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71545/new/

[PATCH] D71597: [clangd][NFC] Make use of TagDecl inside type for hover on auto

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:353 - if (D) { + if (const auto *D = T->getAsTagDecl()) { HI.Kind = index::getSymbolInfo(D).Kind; This might be a functional change in case of typedefs. Could you check

[PATCH] D71544: [clangd] Improve printing of lambda names

kadircet abandoned this revision. kadircet added a comment. Integrated into D71543 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71544/new/ https://reviews.llvm.org/D71544

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy ) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, , - ), + :

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

uweigand added a comment. It looks like this caused build bot failures: http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/28928/steps/ninja%20check%201/logs/FAIL%3A%20lit%3A%3A%20shtest-format.py

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { What's the purpose of this function? I don't think its

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1787998 , @jdoerfert wrote: > In D71241#1787888 , @ABataev wrote: > > > Hal, are we going to support something like this? > > > I'm not Hal but I will answer anyway. > > > void

[PATCH] D70157: Align branches within 32-Byte boundary

jyknight added a comment. > .push_align_branch_boundary [N,] [instruction,]* I'd like to raise again the possibility of using a more general region directive to denote "It is allowable to add prefixes/nops before instructions in this region if the assembler wants to", as I'd started discussing

[PATCH] D71598: [clangd] Filter implicit references from index while renaming

kbobyrev added a comment. (also, this should eliminate unwanted changes caused by the index being stale, wouldn't it?) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71598/new/ https://reviews.llvm.org/D71598 ___ cfe-commits mailing list

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60981 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build

[PATCH] D71597: [clangd][NFC] Make use of TagDecl inside type for hover on auto

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d15605358eb: [clangd][NFC] Make use of TagDecl inside type for hover on auto (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ab15f303efd: [clangd] Fix handling of inline/anon namespaces and names of deduced types in… (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { ilya-biryukov wrote: >

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1128 + (A == OMPC_firstprivate && (Data.Attributes == OMPC_lastprivate || + Data.Attributes == OMPC_linear)) ||

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1787888 , @ABataev wrote: > Hal, are we going to support something like this? I'm not Hal but I will answer anyway. > void cpu() { asm("nop"); } > > #pragma omp declare variant(cpu) match(device =

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1787652 , @hfinkel wrote: > In D71241#1787571 , @ABataev wrote: > > > In D71241#1787265 , @hfinkel wrote: > > > > > In D71241#1786959

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71543/new/ https://reviews.llvm.org/D71543

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60978 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

ABataev added a comment. Here is more proper fix. We don't need to capture just `k` here, instead, we need to capture the whole expression. Linear clause has a little bit different processing rather than all other clauses caused by a non-perfect design. Add codegen tests for all combined

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

jdenny added a comment. This breaks the lit test suite. `llvm/utils/lit/tests/shtest-format.py` needs to be updated for the removed tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71408/new/ https://reviews.llvm.org/D71408

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy ) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, , -

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1128 + (A == OMPC_firstprivate && (Data.Attributes == OMPC_lastprivate || + Data.Attributes == OMPC_linear)) || (A == OMPC_lastprivate &&

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton updated this revision to Diff 234308. s.egerton added a comment. Add test that march 'b' flag enables __riscv_bitmanip. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 Files:

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong created this revision. martong added reviewers: NoQ, Szelethus. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity, mgorny. Herald added a project: clang. This checker

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1128 + (A == OMPC_firstprivate && (Data.Attributes == OMPC_lastprivate || + Data.Attributes == OMPC_linear)) || (A == OMPC_lastprivate &&

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1788003 , @jdoerfert wrote: > In D71241#1787652 , @hfinkel wrote: > > > In D71241#1787571 , @ABataev wrote: > > > > > In D71241#1787265

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

sdesmalen added a comment. In D71556#1786465 , @efriedma wrote: > I'm not sure it's legal to transform a non-faulting load to a load with a > non-faulting flag? At least, we'd need to consider the implications of that > very carefully. In particular,

[PATCH] D71598: [clangd] Filter implicit references from index while renaming

kbobyrev added a comment. In D71598#1787806 , @hokein wrote: > (apologies, the FIXME may imply this approach...) > > this approach is based on an assumption: the index results are matched to the > latest file content, but this is not always true in

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234288. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ https://reviews.llvm.org/D71596 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:86 +// Add macro references. +for (const auto : MacroRefsToIndex->MacroRefs) { + for (const auto : IDToRefs.second) { hokein wrote: > ilya-biryukov

[PATCH] D71598: [clangd] Filter implicit references from index while renaming

ilya-biryukov added a comment. If we go with the solution proposed by @hokein, it looks like using the current patch is an improvement of what we have now. One big issue with the adding a new ref kind/ref modifier is that it requires modifications to Kythe-based index implementation, something

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234293. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ https://reviews.llvm.org/D71596 Files: clang-tools-extra/clangd/Hover.cpp

[clang] 1ed832e - Reland [NFC-I] Remove hack for fp-classification builtins

Author: Erich Keane Date: 2019-12-17T06:58:29-08:00 New Revision: 1ed832e42446ef8c4afe08f980db2e54ac316bf3 URL: https://github.com/llvm/llvm-project/commit/1ed832e42446ef8c4afe08f980db2e54ac316bf3 DIFF: https://github.com/llvm/llvm-project/commit/1ed832e42446ef8c4afe08f980db2e54ac316bf3.diff

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

kadircet updated this revision to Diff 234292. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71543/new/ https://reviews.llvm.org/D71543 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj updated this revision to Diff 234294. sorenj added a comment. Address requested whitespace changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 Files:

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. Hal, are we going to support something like this? void cpu() { asm("nop"); } #pragma omp declare variant(cpu) match(device = {kind(cpu)}) void wrong_asm() { asm ("xxx"); } Currently, there is an error when we try to emit the assembler output.

[PATCH] D71597: [clangd][NFC] Make use of TagDecl inside type for hover on auto

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60932 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60980 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

Eugene.Zelenko added a comment. Please add documentation and mention new check in Release Notes. Comment at: clang-tools-extra/clang-tidy/bugprone/UnsignedSubtractionCheck.cpp:10 +#include "UnsignedSubtractionCheck.h" + +#include "../utils/Matchers.h"

[PATCH] D71597: [clangd][NFC] Make use of TagDecl inside type for hover on auto

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71597/new/ https://reviews.llvm.org/D71597

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

kadircet updated this revision to Diff 234287. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments - Get rid of deduced decl in decltype/auto case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71543/new/

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:353 /// Generate a \p Hover object given the type \p T. HoverInfo getHoverContents(QualType T, const Decl *D, ASTContext , + const SymbolIndex *Index) {

[PATCH] D71597: [clangd][NFC] Make use of TagDecl inside type for hover on auto

kadircet updated this revision to Diff 234291. kadircet marked an inline comment as done. kadircet added a comment. - Added alias tests, behavior stayed the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71597/new/

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60977 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build

[clang-tools-extra] 3d15605 - [clangd][NFC] Make use of TagDecl inside type for hover on auto

Author: Kadir Cetinkaya Date: 2019-12-17T16:33:22+01:00 New Revision: 3d15605358ebadcbd7740a61c92b4fea4d6241e5 URL: https://github.com/llvm/llvm-project/commit/3d15605358ebadcbd7740a61c92b4fea4d6241e5 DIFF:

  1   2   3   >