[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun updated this revision to Diff 234341. xazax.hun added a comment. - Added string argument to specify the handle type. - Only AcquireHandleAttr can be a type attribute and it can only be applied to function types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnsignedSubtractionCheck.cpp:21 + +void UnsignedSubtractionCheck::registerMatchers(MatchFinder *Finder) { + const auto UnsignedIntType = hasType(isUnsignedInteger()); sorenj

[PATCH] D71585: [perf-training] Change profile file pattern string to use %4m instead of %p

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm. Separately, if you have the bandwidth to test out the new '%c%m' mode (https://clang.llvm.org/docs/SourceBasedCodeCoverage.html#running-the-instrumented-program /

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

thakis added a comment. Reverted in 55c55f8eb86ba3e77fe for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71020/new/ https://reviews.llvm.org/D71020

[PATCH] D71585: [perf-training] Change profile file pattern string to use %4m instead of %p

xiaobai added a reviewer: vsk. xiaobai added a subscriber: vsk. xiaobai added a comment. Adding @vsk since he added the code that you're referencing in your summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71585/new/

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

probinson added a comment. @dblaikie let me reflect this back to make sure I get it: Template members (methods or variables) would never appear in the *metadata* description of the struct; but metadata descriptions of the instances would refer back to that struct (as the scope for the

[clang] 55c55f8 - Revert "[ASTImporter] Friend class decl should not be visible in its context"

Author: Nico Weber Date: 2019-12-17T13:43:50-05:00 New Revision: 55c55f8eb86ba3e77fe73ccdf7c861e2c2c7ae92 URL: https://github.com/llvm/llvm-project/commit/55c55f8eb86ba3e77fe73ccdf7c861e2c2c7ae92 DIFF: https://github.com/llvm/llvm-project/commit/55c55f8eb86ba3e77fe73ccdf7c861e2c2c7ae92.diff

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

probinson added a comment. > "DW_TAG_unspecified_type auto" should be emitted for the function > declared/defined as auto returnning. Do you have other test cases in mind, > where above points diverges ?? The declaration would have DW_AT_type point to DW_TAG_unspecified_type, but the

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. Looks good for D/U, but looks like --help and --version options are also supported as combined short args; do you mind adding those too while you're here? Thanks for the patch!

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

thakis added a comment. Looks like this breaks building on Windows in general: http://45.33.8.238/win/4247/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71020/new/ https://reviews.llvm.org/D71020

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG25ce33a6e4f3: [driver][darwin] Pass -platform_version flag to the linker instead of the… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 25ce33a - [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

Author: Alex Lorenz Date: 2019-12-17T10:26:32-08:00 New Revision: 25ce33a6e4f3b13732c0f851e68390dc2acb9123 URL: https://github.com/llvm/llvm-project/commit/25ce33a6e4f3b13732c0f851e68390dc2acb9123 DIFF: https://github.com/llvm/llvm-project/commit/25ce33a6e4f3b13732c0f851e68390dc2acb9123.diff

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj marked an inline comment as done. sorenj added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnsignedSubtractionCheck.cpp:21 + +void UnsignedSubtractionCheck::registerMatchers(MatchFinder *Finder) { + const auto UnsignedIntType =

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

kamleshbhalui created this revision. kamleshbhalui added reviewers: rsmith, aaron.ballman, dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Apply attributes on anonymous records. This Fixes https://bugs.llvm.org/show_bug.cgi?id=43983. Repository: rG LLVM Github

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1772141 , @rjmccall wrote: > This is a major new language feature, and code review is probably not the > right venue for reviewing it; there should be a thread on cfe-dev. My > apologies if that's already been

[PATCH] D71594: testing clang-tidy

Eugene.Zelenko added a comment. Where set of Clang-tidy checks come from? .clang-tidy? Could stricter set of custom rules be used? Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:527 -#endif // LLVM_CLANG_ANALYSIS_ANALYSISDECLCONTEXT_H +#endif

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

ABataev added a comment. The fixed patch. Several codegen tests require some adjustment. diff --git a/clang/lib/Sema/SemaOpenMP.cpp b/clang/lib/Sema/SemaOpenMP.cpp index afe0f1a..ecb0fb2 100644 --- a/clang/lib/Sema/SemaOpenMP.cpp +++ b/clang/lib/Sema/SemaOpenMP.cpp @@ -919,6 +919,11 @@

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnsignedSubtractionCheck.cpp:21 + +void UnsignedSubtractionCheck::registerMatchers(MatchFinder *Finder) { + const auto UnsignedIntType = hasType(isUnsignedInteger()); The

[PATCH] D70764: build: reduce CMake handling for zlib

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. I think this is good, and it has been sitting a while. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70764/new/ https://reviews.llvm.org/D70764

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60748 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno added a comment. In D58579#1788125 , @xbolva00 wrote: > Maybe @aaron.ballman / @rsmith could take a look? This patch blocks the whole > patch stack. I rebased it on top of the others already accepted patches. I just need to get back +w

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. Note that I am not entirely sure that the implementation in `getMemoryLocation`/`MemoryLocation` is the right way to do this; I think that this patch should be considered a work-in-progress. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno added a comment. In D58579#1788164 , @riccibruno wrote: > In D58579#1788125 , @xbolva00 wrote: > > > Maybe @aaron.ballman / @rsmith could take a look? This patch blocks the > > whole patch stack. > > >

[PATCH] D69088: [Lex] #pragma clang transform

greened added a comment. In D69088#1772141 , @rjmccall wrote: > This is a major new language feature, and code review is probably not the > right venue for reviewing it; there should be a thread on cfe-dev. My > apologies if that's already been

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { kadircet wrote: > ilya-biryukov wrote: > > What's the purpose

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno updated this revision to Diff 234326. riccibruno edited the summary of this revision. riccibruno added a comment. I have factored out various NFCs which were present in this patch. This should make review easier. Also addressed some inline comments. Repository: rC Clang CHANGES

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

stella.stamenova added a comment. This broke the windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/11751 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71020/new/ https://reviews.llvm.org/D71020

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

xbolva00 added a comment. Maybe @aaron.ballman / @rsmith could take a look? This patch blocks the whole patch stack. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58579/new/ https://reviews.llvm.org/D58579 ___

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 234327. serge-sans-paille added a comment. Support %% and %c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 Files:

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

xbolva00 added a comment. Hello @aaron.ballman / @rsmith, can you please take a look so this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 ___ cfe-commits mailing

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno updated this revision to Diff 234323. riccibruno added a comment. Rebased on top of current master and D58297 . Friendly ping ! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58579/new/ https://reviews.llvm.org/D58579

[PATCH] D58297: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=

riccibruno updated this revision to Diff 234322. riccibruno added a comment. Rebased on top of current master and D57747 . No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58297/new/

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno updated this revision to Diff 234320. riccibruno added a comment. Rebased on top of current master and D57659 . No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1128 + (A == OMPC_firstprivate && (Data.Attributes == OMPC_lastprivate || + Data.Attributes == OMPC_linear)) || (A == OMPC_lastprivate &&

[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

riccibruno updated this revision to Diff 234317. riccibruno edited the summary of this revision. riccibruno added a comment. Rebased on top of current master. No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57659/new/

[PATCH] D71615: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir

mgorny created this revision. mgorny added reviewers: arichardson, aaron.ballman, rsmith, compnerd. Use correct directory to put gen_ast_dump_json_test.py instead of LLVM_BINARY_DIR. This fixes attempting to write to /usr when building clang standalone. https://reviews.llvm.org/D71615 Files:

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen marked an inline comment as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:585 +const llvm::opt::ArgList , +llvm::opt::ArgStringList ) { + // -mabi is not encoded

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen added a comment. In D71387#1786518 , @efriedma wrote: > My primary concern with this is that I'm not sure you should be passing this > information separately, as opposed to encoding it into the bitcode. > > On ARM, the ABI for a file is generally

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan updated this revision to Diff 234312. skan retitled this revision from "Align branches within 32-Byte boundary" to "Align branches within 32-Byte boundary(NOP padding)". skan edited the summary of this revision. skan added a comment. **Simplify** 1. Drop prefix padding support 2. Drop

[PATCH] D71612: [analyzer] Add PlacementNewChecker

whisperity added a comment. Are buffers otherwise modelled by the Analyser, such as results of the `malloc` family and `alloca` intentionally not matched, or are there some tests missing regarding this? Comment at:

[PATCH] D71588: [objc_direct] fix uniquing when re-declaring a readwrite-direct property

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, But we should also have a test in Sema that verifies it works, and also covers class properties in addition to the instance ones. I can add one when committing (@MadCoder still

[PATCH] D71613: [cmake] Use 'llvm-config --components' to determine components

mgorny created this revision. mgorny added reviewers: dberris, justinkb. Herald added projects: LLVM, Sanitizers. Herald added subscribers: llvm-commits, Sanitizers. Use 'llvm-config --components' to determine available components rather than relying on '--libs' to fail for non-available. This

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

mgorny added a comment. I've tried fixing llvm-config but that's non-trivial. If I fix it to correctly recognize which components are included in dylib, and return other libraries directly, it just uncovers other problems. Please see if D71613 fixes your

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1128 + (A == OMPC_firstprivate && (Data.Attributes == OMPC_lastprivate || + Data.Attributes == OMPC_linear)) || (A == OMPC_lastprivate &&

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen added a comment. In D71475#1787914 , @ABataev wrote: > Here is more proper fix. We don't need to capture just `k` here, instead, we > need to capture the whole expression. > Linear clause has a little bit different processing rather than all other

[PATCH] D70157: Align branches within 32-Byte boundary

jyknight added a comment. > .push_align_branch_boundary [N,] [instruction,]* I'd like to raise again the possibility of using a more general region directive to denote "It is allowable to add prefixes/nops before instructions in this region if the assembler wants to", as I'd started discussing

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1128 + (A == OMPC_firstprivate && (Data.Attributes == OMPC_lastprivate || + Data.Attributes == OMPC_linear)) || (A == OMPC_lastprivate &&

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong created this revision. martong added reviewers: NoQ, Szelethus. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity, mgorny. Herald added a project: clang. This checker

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1788003 , @jdoerfert wrote: > In D71241#1787652 , @hfinkel wrote: > > > In D71241#1787571 , @ABataev wrote: > > > > > In D71241#1787265

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1128 + (A == OMPC_firstprivate && (Data.Attributes == OMPC_lastprivate || + Data.Attributes == OMPC_linear)) || (A == OMPC_lastprivate &&

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1787652 , @hfinkel wrote: > In D71241#1787571 , @ABataev wrote: > > > In D71241#1787265 , @hfinkel wrote: > > > > > In D71241#1786959

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1787998 , @jdoerfert wrote: > In D71241#1787888 , @ABataev wrote: > > > Hal, are we going to support something like this? > > > I'm not Hal but I will answer anyway. > > > void

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1787888 , @ABataev wrote: > Hal, are we going to support something like this? I'm not Hal but I will answer anyway. > void cpu() { asm("nop"); } > > #pragma omp declare variant(cpu) match(device =

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton updated this revision to Diff 234308. s.egerton added a comment. Add test that march 'b' flag enables __riscv_bitmanip. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 Files:

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1128 + (A == OMPC_firstprivate && (Data.Attributes == OMPC_lastprivate || + Data.Attributes == OMPC_linear)) || (A == OMPC_lastprivate &&

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1128 + (A == OMPC_firstprivate && (Data.Attributes == OMPC_lastprivate || + Data.Attributes == OMPC_linear)) ||

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { ilya-biryukov wrote: >

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

jdenny added a comment. This breaks the lit test suite. `llvm/utils/lit/tests/shtest-format.py` needs to be updated for the removed tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71408/new/ https://reviews.llvm.org/D71408

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy ) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, , -

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

uweigand added a comment. It looks like this caused build bot failures: http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/28928/steps/ninja%20check%201/logs/FAIL%3A%20lit%3A%3A%20shtest-format.py

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { What's the purpose of this function? I don't think its

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ab15f303efd: [clangd] Fix handling of inline/anon namespaces and names of deduced types in… (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71597: [clangd][NFC] Make use of TagDecl inside type for hover on auto

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d15605358eb: [clangd][NFC] Make use of TagDecl inside type for hover on auto (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 3d15605 - [clangd][NFC] Make use of TagDecl inside type for hover on auto

Author: Kadir Cetinkaya Date: 2019-12-17T16:33:22+01:00 New Revision: 3d15605358ebadcbd7740a61c92b4fea4d6241e5 URL: https://github.com/llvm/llvm-project/commit/3d15605358ebadcbd7740a61c92b4fea4d6241e5 DIFF:

[clang-tools-extra] 9ab15f3 - [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

Author: Kadir Cetinkaya Date: 2019-12-17T16:33:22+01:00 New Revision: 9ab15f303efdfc841f475918535ab4e13960491b URL: https://github.com/llvm/llvm-project/commit/9ab15f303efdfc841f475918535ab4e13960491b DIFF:

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy ) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, , - ), + :

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

ABataev added a comment. Here is more proper fix. We don't need to capture just `k` here, instead, we need to capture the whole expression. Linear clause has a little bit different processing rather than all other clauses caused by a non-perfect design. Add codegen tests for all combined

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60981 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60978 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60977 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71543/new/ https://reviews.llvm.org/D71543

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj updated this revision to Diff 234294. sorenj added a comment. Address requested whitespace changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 Files:

[PATCH] D71597: [clangd][NFC] Make use of TagDecl inside type for hover on auto

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71597/new/ https://reviews.llvm.org/D71597

[PATCH] D71597: [clangd][NFC] Make use of TagDecl inside type for hover on auto

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60932 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. Hal, are we going to support something like this? void cpu() { asm("nop"); } #pragma omp declare variant(cpu) match(device = {kind(cpu)}) void wrong_asm() { asm ("xxx"); } Currently, there is an error when we try to emit the assembler output.

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

kadircet updated this revision to Diff 234292. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71543/new/ https://reviews.llvm.org/D71543 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234293. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ https://reviews.llvm.org/D71596 Files: clang-tools-extra/clangd/Hover.cpp

[clang] 1ed832e - Reland [NFC-I] Remove hack for fp-classification builtins

Author: Erich Keane Date: 2019-12-17T06:58:29-08:00 New Revision: 1ed832e42446ef8c4afe08f980db2e54ac316bf3 URL: https://github.com/llvm/llvm-project/commit/1ed832e42446ef8c4afe08f980db2e54ac316bf3 DIFF: https://github.com/llvm/llvm-project/commit/1ed832e42446ef8c4afe08f980db2e54ac316bf3.diff

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

Eugene.Zelenko added a comment. Please add documentation and mention new check in Release Notes. Comment at: clang-tools-extra/clang-tidy/bugprone/UnsignedSubtractionCheck.cpp:10 +#include "UnsignedSubtractionCheck.h" + +#include "../utils/Matchers.h"

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60980 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build

[PATCH] D71597: [clangd][NFC] Make use of TagDecl inside type for hover on auto

kadircet updated this revision to Diff 234291. kadircet marked an inline comment as done. kadircet added a comment. - Added alias tests, behavior stayed the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71597/new/

[PATCH] D71598: [clangd] Filter implicit references from index while renaming

ilya-biryukov added a comment. If we go with the solution proposed by @hokein, it looks like using the current patch is an improvement of what we have now. One big issue with the adding a new ref kind/ref modifier is that it requires modifications to Kythe-based index implementation, something

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:86 +// Add macro references. +for (const auto : MacroRefsToIndex->MacroRefs) { + for (const auto : IDToRefs.second) { hokein wrote: > ilya-biryukov

[PATCH] D71544: [clangd] Improve printing of lambda names

kadircet abandoned this revision. kadircet added a comment. Integrated into D71543 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71544/new/ https://reviews.llvm.org/D71544

[PATCH] D71607: Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Many C++ programmers are unaware that an expression of unsigned - signed will promote the signed argument to unsigned, and the resulting underflow produces a large positive rather than negative

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

kadircet abandoned this revision. kadircet marked an inline comment as done. kadircet added a comment. integrated into D71543 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71545/new/

[PATCH] D71597: [clangd][NFC] Make use of TagDecl inside type for hover on auto

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:353 - if (D) { + if (const auto *D = T->getAsTagDecl()) { HI.Kind = index::getSymbolInfo(D).Kind; This might be a functional change in case of typedefs. Could you check

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234288. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ https://reviews.llvm.org/D71596 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

kadircet updated this revision to Diff 234287. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments - Get rid of deduced decl in decltype/auto case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71543/new/

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:353 /// Generate a \p Hover object given the type \p T. HoverInfo getHoverContents(QualType T, const Decl *D, ASTContext , + const SymbolIndex *Index) {

[PATCH] D71598: [clangd] Filter implicit references from index while renaming

kbobyrev added a comment. (also, this should eliminate unwanted changes caused by the index being stale, wouldn't it?) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71598/new/ https://reviews.llvm.org/D71598 ___ cfe-commits mailing list

[PATCH] D71598: [clangd] Filter implicit references from index while renaming

kbobyrev added a comment. In D71598#1787806 , @hokein wrote: > (apologies, the FIXME may imply this approach...) > > this approach is based on an assumption: the index results are matched to the > latest file content, but this is not always true in

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

sdesmalen added a comment. In D71556#1786465 , @efriedma wrote: > I'm not sure it's legal to transform a non-faulting load to a load with a > non-faulting flag? At least, we'd need to consider the implications of that > very carefully. In particular,

[PATCH] D71598: [clangd] Filter implicit references from index while renaming

hokein added a comment. (apologies, the FIXME may imply this approach...) this approach is based on an assumption: the index results are matched to the latest file content, but this is not always true in practice, our index maybe stale (index results came from an old snapshot of the file),

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

thakis added a comment. Mordante, do you need someone to land this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68913/new/ https://reviews.llvm.org/D68913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

This revision was automatically updated to reflect the committed changes. Closed by commit rG4becf68c6f17: [ASTImporter] Friend class decl should not be visible in its context (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4becf68 - [ASTImporter] Friend class decl should not be visible in its context

Author: Gabor Marton Date: 2019-12-17T14:48:55+01:00 New Revision: 4becf68c6f17fe143539ceac954b21175914e1c1 URL: https://github.com/llvm/llvm-project/commit/4becf68c6f17fe143539ceac954b21175914e1c1 DIFF: https://github.com/llvm/llvm-project/commit/4becf68c6f17fe143539ceac954b21175914e1c1.diff

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:392 + EstimateSizeFormatHandler H(StrE); + StringRef StrRef = StrE->getString(); + const char *Str = StrRef.data();

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 234282. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. - Prevent assert upon wide string format - More test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

hokein added a comment. @ilya-biryukov thanks for taking it during my OOO, just a drive-by comment :) Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:86 +// Add macro references. +for (const auto : MacroRefsToIndex->MacroRefs) { + for (const auto :

<    1   2   3   >