[PATCH] D72144: Treat C# `using` as a control statement

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72144/new/ https://reviews.llvm.org/D72144 ___ cfe-commits mailing

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

junparser added a comment. In D71903#1804016 , @modocache wrote: > I'm currently working on ensuring that CGSCC optimizations are rerun to > optimize coroutine funclets -- the primary feedback I received on this and on > D71899

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

ztamas added a comment. Thanks for the review! I applied for the renewal of my commit access. I had commit access only for the SVN repo. After I get access to the GitHub repo I'll push this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72150: Allow space after C-style cast in C# code

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch, really good to have others working on C# support. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71939: clang-format: fix conflict between FormatStyle::BWACS_MultiLine and BeforeCatch/BeforeElse

pastey added a comment. Guys, sorry for a dumb question – so the fix can be pushed now? If yes, then there's one issue – I don't think I have write access to push the fix – may I ask one of you to push it? ERROR: Permission to llvm/llvm-project.git denied to pastey12. Repository: rC Clang

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] b7ecf1c - NFC: Fix trivial typos in comments

Author: Kazuaki Ishizaki Date: 2020-01-04T10:28:41-05:00 New Revision: b7ecf1c1c373c53183ef6ef66efbe4237ff7b96d URL: https://github.com/llvm/llvm-project/commit/b7ecf1c1c373c53183ef6ef66efbe4237ff7b96d DIFF:

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

aaron.ballman added a comment. In D70638#1803364 , @xbolva00 wrote: > (re-ping; I think this false positive for goto label case is important to be > fixed before 10 release) I agree -- @Tyker, are you planning to work on that fix? Repository: rG

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-values.cpp:608 +} + +template 0x8000- wrote: > JonasToth wrote: > > JonasToth wrote: > > > 0x8000- wrote: > > > > Please

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked 2 inline comments as done. JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-values.cpp:608 +} + +template 0x8000- wrote: > Please insert the this test code here: >

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-values.cpp:608 +} + +template JonasToth wrote: > JonasToth wrote: > > 0x8000- wrote: > > > Please insert the this test code here:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked 2 inline comments as done. JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-values.cpp:608 +} + +template JonasToth wrote: > 0x8000- wrote: > > Please insert the

[PATCH] D72140: [clang-tools-extra] NFC: Fix trivial typos in comments

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've committed on your behalf in b7ecf1c1c373c53183ef6ef66efbe4237ff7b96d . Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D71659: [clang-format] Added new option to allow setting spaces before and after the operator

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3359 + // nuanced as aggressive line breaks are placed when the lambda is not the + // last arg. if ((Style.Language ==

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. This patch does not build on top of current tree: /usr/bin/ld: lib/libclangTidyCppCoreGuidelinesModule.a(ConstCorrectnessCheck.cpp.o): in function `clang::tidy::cppcoreguidelines::ConstCorrectnessCheck::registerMatchers(clang::ast_matchers::MatchFinder*)':

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker added a comment. In D70638#1804138 , @aaron.ballman wrote: > In D70638#1803364 , @xbolva00 wrote: > > > (re-ping; I think this false positive for goto label case is important to > > be fixed before 10

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

fhahn added a comment. There seems to be a problem with this patch on macOS. I've XFAIL'd it in rGdb82fc5dd80ff14798e7f1c35dd7e593f6409ba3 . This should unblock the macOS builders, but please take a look at the problem.

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:46 +} +CharSourceRange getFixitRange(const VarDecl *Var) { + return CharSourceRange::getTokenRange(Var->getBeginLoc(), Please separate with empty

[PATCH] D72221: Support function attribute patchable_function_entry

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61253 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,M]

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/altera/KernelNameRestrictionCheck.cpp:13 +#include "clang/Lex/Preprocessor.h" + +using namespace clang::ast_matchers; Please include string, vector Comment at:

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/altera/KernelNameRestrictionCheck.cpp:21 +namespace { +class KernelNameRestrictionPPCallbacks : public PPCallbacks { +public: Please separate with empty line. Comment at:

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

Eugene.Zelenko added a comment. May be check belong to LLVM module? Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:69 + if (auto Var = Result.Nodes.getNodeAs("auto_ptr")) { + +if

[PATCH] D72221: Support function attribute patchable_function_entry

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61253 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

lebedev.ri added a comment. Oh, thank you for working on this one, i've always missed this particular check. Given that there's finally progress on const-correctness check, should this only handle adding `*`/`&`, and leave `const` alone? In D72217#1804628

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska updated this revision to Diff 236188. Bouska added a comment. Updated unittest to check under the column limit and over the column limit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71512/new/ https://reviews.llvm.org/D71512 Files:

[PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

MaskRay added a comment. In D71857#1804307 , @Mordante wrote: > In D71857#1800663 , @MaskRay wrote: > > > I think there is a false positive. > > > >

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

Mordante created this revision. Mordante added reviewers: aaron.ballman, xbolva00, MaskRay. Mordante added a project: clang. No longer generate a diagnostic when a small trivially copyable type is used without a reference. Before the test looked for a POD type and had no size restriction. Since

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

logan-5 added a comment. @Eugene.Zelenko +1 to @Mordante 's question. Otherwise, happy to address most of those nits, though I think I will gently push back on a couple of them (in the inline comments). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

logan-5 added a comment. In D72213#1804394 , @Mordante wrote: > I wonder what happens if the project already contains a suggested fix, for > example: > > #define __FOO(X) ... > #define _FOO(X) __FOO(X) > #define FOO(X) _FOO(X) > > > will it

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies created this revision. ffrankies added reviewers: alexfh, hokein, aaron.ballman. ffrankies added projects: clang-tools-extra, clang, LLVM. Herald added subscribers: mgehre, ormris, arphaman, xazax.hun, Anastasia, mgorny. This lint check is part of the FLOCL (FPGA Linters for OpenCL)

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

logan-5 updated this revision to Diff 236216. logan-5 added a comment. Change double-underscore fix-it finding algorithm to correctly collapse any number of >=2 underscores in a row, not just exactly 2 (or multiples of 2). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72213/new/

[PATCH] D72221: Support function attribute patchable_function_entry

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61253 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,M]

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61253 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72221: Support function attribute patchable_function_entry

MaskRay updated this revision to Diff 236225. MaskRay added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72221/new/ https://reviews.llvm.org/D72221 Files: clang/include/clang/Basic/Attr.td

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. side note when creating this, the add_new_check.py file hasn't been updated in relation to this commit https://github.com/llvm/llvm-project/commit/d2c9c9157b0528436d3b9f5e22c872f0ee6509a2. This results in a malformed rst file. In this patch I have just manually set

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-values.cpp:608 +} + +template JonasToth wrote: > 0x8000- wrote: > > 0x8000- wrote: > > > JonasToth wrote: > > > > JonasToth

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

Mordante added a comment. I like this change, but I don't feel qualified to fully review the patch. I wonder what happens if the project already contains a suggested fix, for example: #define __FOO(X) ... #define _FOO(X) __FOO(X) #define FOO(X) _FOO(X) will it suggest: #define FOO(X)

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

Mordante added a subscriber: eugene. Mordante added a comment. @eugene `Please don't use auto when type is spelled in same statement or iterator.` do you mean `type is not spelled` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72213/new/

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

logan-5 marked an inline comment as done. logan-5 added a comment. @Eugene.Zelenko never mind about pushing back on the nits; I had misread some of them. They all sound good, will address. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp:70 +

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

JonasToth added a comment. i think it would be easier to review if there are two patches, one refactoring and one new check. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:59 + struct FailureInfo { +std::string KindName; // Tag or misc info to be

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

Eugene.Zelenko added a comment. In D72213#1804447 , @Mordante wrote: > @eugene `Please don't use auto when type is spelled in same statement or > iterator.` do you mean `type is not spelled` ? Yes, you are correct. Sorry for mistake. Repository: rG

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61248 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2806 - // constructors. - if (VariableType.isPODType(SemaRef.Context)) return; assert it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72221: Support function attribute patchable_function_entry

MaskRay created this revision. MaskRay added reviewers: dberris, kristof.beyls, nickdesaulniers, rnk, rsmith, void. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay added a parent revision: D72220: [X86] Support function attribute "patchable-function-entry". MaskRay

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,M]

MaskRay created this revision. MaskRay added reviewers: dberris, kristof.beyls, nickdesaulniers, rnk, rsmith, void. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay added a parent revision: D72221: Support function attribute patchable_function_entry. MaskRay added

[PATCH] D72053: [RFC] Handling implementation limits

craig.topper added inline comments. Comment at: clang/docs/ImplementationQuantities.rst:70 + +These limits are defined in the standards, but are imposed in Clang. + should this say ‘not defined’? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72053/new/

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2806 - // constructors. - if (VariableType.isPODType(SemaRef.Context)) return; xbolva00 wrote: > assert it? Sorry I don't understand what

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

logan-5 marked an inline comment as done. logan-5 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:59 + struct FailureInfo { +std::string KindName; // Tag or misc info to be used as derived classes need +std::string Fixup;

[PATCH] D67224: [clangd] Enable completions with fixes in VSCode

nridge added a comment. Just throwing a wild idea out there: what if we used `textDocument/onTypeFormatting` to replace the `.` with `->` as soon as it's typed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67224/new/

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,M]

MaskRay updated this revision to Diff 236222. MaskRay added a comment. Forgot to add test/Driver/fpatchable-function-entry.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https://reviews.llvm.org/D7 Files:

[PATCH] D72221: Support function attribute patchable_function_entry

MaskRay updated this revision to Diff 236221. MaskRay added a comment. Move a line from D7 to D72221 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72221/new/

[PATCH] D72053: [RFC] Handling implementation limits

Mordante updated this revision to Diff 236190. Mordante added a comment. Added support for some additional features: - Allow limits from the C standard, either sharing the C++ constants or separately. - Allow to document the design choices for the limit. - Allow to track the status of the

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

hubert.reinterpretcast added a comment. Is building `check-all` immediately after configuration expected to be clean? I have a build configured to build LLVM with just `clang` and just with the `PowerPC` target, and it seems `check-all` (under such a configuration) does not trigger the

[PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante added a comment. In D71857#1800663 , @MaskRay wrote: > I think there is a false positive. > > https://github.com/llvm/llvm-project/tree/master/lld/ELF/Relocations.cpp#L1622 > > for (const std::pair ts : isd->thunkSections) > Removing the

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

logan-5 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-reserved-identifier-invert.cpp:21 +// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: declaration uses identifier 'Helper', which is not a reserved identifier [bugprone-reserved-identifier]

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

JonasToth added a comment. Herald added a subscriber: mgehre. any news here? do you plan to finish this patch @Quolyk ? Do you mind if someone comandeers this patch? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56644/new/

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 created this revision. njames93 added a reviewer: aaron.ballman. njames93 added projects: clang, clang-tools-extra. Herald added subscribers: xazax.hun, whisperity, mgorny. njames93 added a comment. side note when creating this, the add_new_check.py file hasn't been updated in relation

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#1804183 , @0x8000- wrote: > This patch does not build on top of current tree: > > /usr/bin/ld: > lib/libclangTidyCppCoreGuidelinesModule.a(ConstCorrectnessCheck.cpp.o): in > function >

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-values.cpp:608 +} + +template 0x8000- wrote: > 0x8000- wrote: > > JonasToth wrote: >

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp:49 +} +static Optional getDoubleUnderscoreFixup(StringRef Name) { + if (hasDoubleUnderscore(Name)) { Please separate with empty line.

[PATCH] D72053: [RFC] Handling implementation limits

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/docs/ImplementationQuantities.rst:70 + +These limits are defined in the standards, but are imposed in Clang. + craig.topper wrote: > should this say ‘not defined’? Yes,

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2806 - // constructors. - if (VariableType.isPODType(SemaRef.Context)) return; Mordante wrote: > xbolva00 wrote: > > assert it? > Sorry I don't understand what you mean. What do you

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#1804291 , @JonasToth wrote: > In D54943#1804183 , @0x8000- > wrote: > > > This patch does not build on top of current tree: > > > > /usr/bin/ld: > >

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-values.cpp:608 +} + +template 0x8000- wrote: > JonasToth wrote: > > 0x8000- wrote: >

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

logan-5 updated this revision to Diff 236210. logan-5 marked 39 inline comments as done. logan-5 added a comment. Addressed formatting issues, and tweaked handling of the names `__` and `::_`: the check now flags these but doesn't suggest a fix. CHANGES SINCE LAST ACTION