[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a minor testing request, thank you! Comment at: clang/test/Sema/attr-capabilities.c:12 -// Test an invalid capability name -struct

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

NoQ added a comment. @ddcc, sure, np! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28955/new/ https://reviews.llvm.org/D28955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj added a comment. Okay, but as you can see the majority of my test cases are intentionally false negatives `- -Wsign-conversion` triggers so often than many people don't use it. And, `unsigned x = 2;` does not trigger a sign conversion warning despite there being a conversion form 2 to

[PATCH] D71612: [analyzer] Add PlacementNewChecker

NoQ added a comment. This looks fantastic. Let's enable by it default! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71612/new/ https://reviews.llvm.org/D71612 ___ cfe-commits mailing list

[PATCH] D72979: [Codegen] Emit both AssumeAlignedAttr and AllocAlignAttr assumptions if they exist

lebedev.ri created this revision. lebedev.ri added reviewers: erichkeane, jdoerfert, aaron.ballman. lebedev.ri added a project: clang. lebedev.ri edited the summary of this revision. We shouldn't be just giving up if we find one of them (like we currently do with `AssumeAlignedAttr`), we should

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

rnk added a comment. I posted a patch to speed things up: https://reviews.llvm.org/D72984 The numbers are different, since 9 seconds is measured in a local linux build with no debug info, vs. 28s I measured when building at work, on Windows, with debug info. Repository: rG LLVM Github

[PATCH] D72984: [TableGen] Use a table to lookup MVE intrinsic names

rnk created this revision. rnk added reviewers: simon_tatham, dmgreen, ostannard, MarkMurrayARM. Herald added a project: clang. Speeds up compilation of SemaDeclAttr.cpp by nine seconds: 0m49.555s - > 0m40.249s Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72984 Files:

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

xazax.hun added a comment. There might be other tools parsing the output of `-###`. I think adding a line break in the output is better/easier than updating all those tools (amd making them potentially slower, not profiting from this patch). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

aganea added inline comments. Comment at: clang/lib/Sema/Sema.cpp:984 + +PerformPendingInstantiations(); } All tests pass if you add `if (LangOpts.BuildingPCHWithObjectFile)` here. But if a specialization occurs inside a .CPP which includes the .PCH, not

[clang] 80146fc - [test] clang/test/InterfaceStubs/externstatic.c requires x86-registered-target

Author: Fangrui Song Date: 2020-01-18T09:54:35-08:00 New Revision: 80146fc13adaf3a523c03a1ff8693ed157a29138 URL: https://github.com/llvm/llvm-project/commit/80146fc13adaf3a523c03a1ff8693ed157a29138 DIFF: https://github.com/llvm/llvm-project/commit/80146fc13adaf3a523c03a1ff8693ed157a29138.diff

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. Thanks for your report. I think it's similar to https://bugs.llvm.org/show_bug.cgi?id=44556. I'll look for a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912

[PATCH] D50360: [Concepts] Requires Expressions

thakis added a comment. This breaks tests on non-Win, see e.g. http://45.33.8.238/linux/7846/step_7.txt http://45.33.8.238/mac/6120/step_7.txt Please watch http://lab.llvm.org:8011/console for a bit after landing changes. Please take a look, and if the fix isn't obvious please revert while you

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added a comment. @thakis landed a patch to control this behavior on the cmd-line, adding `-fno-integrated-cc1` would solve your issue (ie. revert to old behavior). @NoQ @xazax.hun is that an acceptable solution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added inline comments. Comment at: clang/lib/Sema/Sema.cpp:984 + +PerformPendingInstantiations(); } aganea wrote: > All tests pass if you add `if (LangOpts.BuildingPCHWithObjectFile)` here. But > if a specialization occurs inside a .CPP which

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante marked 14 inline comments as done. Mordante added a comment. Thanks for the review! I only answered to the larger issues to get a better feeling of the direction the patch should go. Once that's clear I'll make a new patch and also address the smaller issues.

[PATCH] D72984: [TableGen] Use a table to lookup MVE intrinsic names

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61989 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

NoQ added a comment. In D69825#1827826 , @xazax.hun wrote: > This patch breaks scan-build-py which parses the output of "-###" to get -cc1 > command. Uh-oh, thanks for catching this. The same applies to the regular `scan-build`. Unfortunately, neither

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

aganea created this revision. aganea added reviewers: xazax.hun, NoQ, thakis, hans. Herald added subscribers: cfe-commits, Charusso, rnkovacs. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72982 Files: clang/lib/Driver/Job.cpp

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

wenlei added a comment. @aganea, @hans This patch broke response file expansion for preprocessor via `-Wp` - all our internal builds failed with this patch because we invoke clang with response file passed to preprocessor, e.g. `clang++ ... -Wp,@pp.rsp @cc.rsp`. Looks like we can't just call

[clang] e68c1e0 - [Concepts] Fix name-type conflict compilation issues

Author: Saar Raz Date: 2020-01-19T00:45:25+02:00 New Revision: e68c1e00eba4ae64d38e62eebebd581e3d3d6bd4 URL: https://github.com/llvm/llvm-project/commit/e68c1e00eba4ae64d38e62eebebd581e3d3d6bd4 DIFF: https://github.com/llvm/llvm-project/commit/e68c1e00eba4ae64d38e62eebebd581e3d3d6bd4.diff

[PATCH] D50360: [Concepts] Requires Expressions

thakis added a comment. Doesn't this still break check-clang everywhere? See e.g. http://45.33.8.238/linux/7860/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50360/new/ https://reviews.llvm.org/D50360