[PATCH] D69933: [ASTImporter] Limit imports of structs

jarin updated this revision to Diff 239235. jarin added a comment. Herald added a subscriber: lldb-commits. I changed the diff so that it does not touch Clang's AST importer, instead it patches LLDB's wrapper of the AST importer. The idea is to only import complete a record if the current

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 239242. serge-sans-paille added a comment. More tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 Files:

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM [with the caveat that we need to revisit the modelling of the `FFR` register and get rid fo the `PseudoInstExpansion` at a later point, as discussed during the previous sync-up

[PATCH] D71566: New checks for fortified sprintf

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62043 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D72825: Remove unused option that gcc ignored

Jim updated this revision to Diff 239246. Jim retitled this revision from "[NFC] Fix options name typo" to "Remove unused option that gcc ignored". Jim edited the summary of this revision. Jim added a comment. Address the comment. Delete the options. Repository: rG LLVM Github Monorepo

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 239253. njames93 added a comment. - Fix assertion causing failing tests in debug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 Files:

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62041 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 239257. serge-sans-paille added a comment. Update warning category Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 Files:

[PATCH] D68720: Support -fstack-clash-protection for x86

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62059 tests passed, 1 failed and 783 were skipped. failed: Clang.CodeGen/stack-clash-protection.c {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please

[PATCH] D73087: [Alignment][NFC] Use Align with CreateMaskedLoad

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type. See this thread for context:

[PATCH] D72867: [clangd] Support renaming designated initializers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:639 +void VisitDesignatedInitExpr(const DesignatedInitExpr *DIE) { + for (const DesignatedInitExpr::Designator : DIE->designators()) { +if (!D.isFieldDesignator())

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

MyDeveloperDay added a comment. @krasimir Thanks for fixing this, as it looks like I broke it.. its much appreciated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

gribozavr2 added a comment. Let me know if you want me to commit this change for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71001/new/ https://reviews.llvm.org/D71001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73088: [clangd] Capture the missing injected class names in findExplicitReferences.

hokein created this revision. hokein added reviewers: kadircet, kbobyrev. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/237. Repository: rG LLVM Github Monorepo

[PATCH] D73088: [clangd] Capture the missing injected class names in findExplicitReferences.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62043 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

sammccall added a comment. Thanks for fixing this. I think it could maybe use a further tweak, LMK if I'm missing something as my intuition around macros is pretty bad. Comment at: clang-tools-extra/clangd/Selection.cpp:261 + // consider it selected. + if

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware added a comment. In D71001#1830792 , @gribozavr2 wrote: > Let me know if you want me to commit this change for you. Thank you! I will commit it today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71001/new/

[PATCH] D73088: [clangd] Capture the missing injected class names in findExplicitReferences.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:736 + template + class $1^$2^Bar { +~$3^Bar(); looks like we are getting duplicates here Repository: rG LLVM Github

[PATCH] D73088: [clangd] Capture the missing injected class names in findExplicitReferences.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:736 + template + class $1^$2^Bar { +~$3^Bar();

[PATCH] D72581: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:228 + /// multiple times and this function will return multiple results in those + /// cases. This

[clang] bc29069 - [analyzer] Enable PlacementNewChecker by default

Author: Gabor Marton Date: 2020-01-21T13:23:10+01:00 New Revision: bc29069dc401572ba62f7dd692a3474c1ead76c9 URL: https://github.com/llvm/llvm-project/commit/bc29069dc401572ba62f7dd692a3474c1ead76c9 DIFF: https://github.com/llvm/llvm-project/commit/bc29069dc401572ba62f7dd692a3474c1ead76c9.diff

[PATCH] D73088: [clangd] Capture the missing injected class names in findExplicitReferences.

kbobyrev added a comment. It would also be great to have the original rename test from the linked issue since something might potentially go wrong in-between `findExplicitReferences` and rename action (and also to expand the testset because the existing one is not really extensive :().

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong added a comment. In D71612#1828059 , @NoQ wrote: > This looks fantastic. Let's enable by it default! Ok, I've done that: https://github.com/llvm/llvm-project/commit/bc29069dc40 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bc8a1ab - [Alignment][NFC] Use Align with CreateMaskedLoad

Author: Guillaume Chatelet Date: 2020-01-21T14:13:22+01:00 New Revision: bc8a1ab26fba5d5635467b9d0fd7ad9a0fd5bc6e URL: https://github.com/llvm/llvm-project/commit/bc8a1ab26fba5d5635467b9d0fd7ad9a0fd5bc6e DIFF:

[PATCH] D22221: Decide whether to enable plugin tests based on cmake variables

john.brawn abandoned this revision. john.brawn added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Abandoning this old obsolete patch. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1/new/ https://reviews.llvm.org/D1

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 239286. serge-sans-paille added a comment. Take into account review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files:

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille added a comment. > Linkages which were not interposable before and can be interposable now: > available_externally, linkonce_odr, weak_odr, external, and appending. @MaskRay I understand the motivation behind that sentence, but do we want that change to be non-conditional,

[PATCH] D73087: [Alignment][NFC] Use Align with CreateMaskedLoad

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc8a1ab26fba: [Alignment][NFC] Use Align with CreateMaskedLoad (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73087/new/

[clang-tools-extra] fccd0da - [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

Author: Adam Balogh Date: 2020-01-21T14:38:15+01:00 New Revision: fccd0da5ee6f4e337395f287edcf824a009e1b7e URL: https://github.com/llvm/llvm-project/commit/fccd0da5ee6f4e337395f287edcf824a009e1b7e DIFF: https://github.com/llvm/llvm-project/commit/fccd0da5ee6f4e337395f287edcf824a009e1b7e.diff

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

This revision was automatically updated to reflect the committed changes. Closed by commit rGfccd0da5ee6f: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D71001?vs=239103=239290#toc

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62055 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73097: [AArch64][SVE] Add intrinsics for FFR manipulation

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, dancgr. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the following intrinsics: -

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn updated this revision to Diff 239292. john.brawn added reviewers: erichkeane, aaron.ballman, rjmccall. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a subscriber: llvm-commits. john.brawn added a comment. Herald added a project: clang.

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 created this revision. njames93 added reviewers: aaron.ballman, JonasToth, alexfh, hokein. njames93 added projects: clang, clang-tools-extra. Herald added subscribers: kristof.beyls, xazax.hun. Typically most main functions have the signature: int main(int argc, char *argv[]) To

[PATCH] D73099: [Alignment][NFC] Deprecate Align::None()

gchatelet created this revision. gchatelet added reviewers: xbolva00, courbet. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, Jim, jsji, atanasyan, jrtc27, kbarton, hiraditya, nhaehnle, jvesely, nemanjai, sdardis, dylanmckay, arsenm. Herald added a reviewer: bollu. Herald added

[clang-tools-extra] f651c40 - [clangd] Capture the missing injected class names in findExplicitReferences.

Author: Haojian Wu Date: 2020-01-21T15:09:23+01:00 New Revision: f651c402a221a20f3bc6ea43f70b29326a357010 URL: https://github.com/llvm/llvm-project/commit/f651c402a221a20f3bc6ea43f70b29326a357010 DIFF: https://github.com/llvm/llvm-project/commit/f651c402a221a20f3bc6ea43f70b29326a357010.diff

[PATCH] D73088: [clangd] Capture the missing injected class names in findExplicitReferences.

hokein added a comment. In D73088#1830960 , @kbobyrev wrote: > It would also be great to have the original rename test from the linked issue > since something might potentially go wrong in-between > `findExplicitReferences`. Done. > and rename action

[PATCH] D73088: [clangd] Capture the missing injected class names in findExplicitReferences.

hokein updated this revision to Diff 239296. hokein marked 2 inline comments as done. hokein added a comment. - add fixme - add rename test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73088/new/ https://reviews.llvm.org/D73088 Files:

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn updated this revision to Diff 239295. john.brawn retitled this revision from "Move ParsedAttrInfos into a registry and point to one in AttributeList" to "Move ParsedAttrInfos into a registry and point to one in ParsedAttr". john.brawn added reviewers: erichkeane, aaron.ballman,

[PATCH] D73088: [clangd] Capture the missing injected class names in findExplicitReferences.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf651c402a221: [clangd] Capture the missing injected class names in findExplicitReferences. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62026 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 added a comment. For the record this convention appears everywhere in LLVM even though LLVM style is to have parameters starting with uppercase letters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/

[PATCH] D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62026 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

xazax.hun added a comment. Do you have commit access or need someone to commit on your behalf? Also, in case your change made it into the clang 10 release branch this will need to be cherry picked there as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73101 Files:

[PATCH] D73088: [clangd] Capture the missing injected class names in findExplicitReferences.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62042 tests passed, 1 failed and 783 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_sharedtimedmutex_requirements/thread_sharedtimedmutex_class/try_lock.pass.cpp {icon

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62058 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn updated this revision to Diff 239299. john.brawn edited the summary of this revision. john.brawn added reviewers: erichkeane, aaron.ballman, rjmccall. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a subscriber: cfe-commits. john.brawn added

[PATCH] D31343: Add an attribute plugin example

john.brawn updated this revision to Diff 239307. john.brawn added reviewers: erichkeane, aaron.ballman, rjmccall. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a subscriber: cfe-commits. john.brawn added a comment. Herald added a project: clang.

[PATCH] D73102: [clangd] Handle the missing injectedClassNameType in targetDecl.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73102 Files:

[PATCH] D73025: [AArch64][SVE] Add first-faulting load intrinsic

kmclaughlin updated this revision to Diff 239303. kmclaughlin added a comment. - Rebased patch after changes made to parent revision CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73025/new/ https://reviews.llvm.org/D73025 Files: llvm/include/llvm/IR/IntrinsicsAArch64.td

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

baloghadamsoftware added a comment. Hello, This checker is an alternative approach to our not yet published statistics-based checkers in a way: 2019 EuroLLVM Developers’ Meeting: A. Balogh “Statistics Based Checkers in the Clang Static Analyzer”

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:584 +void VisitRedeclarableTemplateDecl(const RedeclarableTemplateDecl *TD) { + // {Class,Function,Var,TypeAlias}TemplateDecls are visited as part of the + // NamedDecl below, we skip

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet updated this revision to Diff 239310. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73101/new/ https://reviews.llvm.org/D73101 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D73102: [clangd] Handle the missing injectedClassNameType in targetDecl.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62057 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73104: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation

bader created this revision. bader added reviewers: aaron.ballman, Fznamznon. Herald added subscribers: cfe-commits, ebevhan. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73104 Files: clang/include/clang/Basic/AttrDocs.td Index:

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@" tejohnson wrote: > evgeny777

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:584 +void VisitRedeclarableTemplateDecl(const RedeclarableTemplateDecl *TD) { + // {Class,Function,Var,TypeAlias}TemplateDecls are visited as

[PATCH] D73062: [analyzer] Simplify BoolAssignmentChecker

NoQ added a comment. Thanks!!! Small patches are so nice to review. Comment at: clang/lib/StaticAnalyzer/Checkers/BoolAssignmentChecker.cpp:91 - if (!greaterThanEqualToZero) { -// The SValBuilder cannot construct a valid SVal for this condition. -// This means we

[PATCH] D71612: [analyzer] Add PlacementNewChecker

NoQ added a comment.  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71612/new/ https://reviews.llvm.org/D71612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

NoQ added a comment. Thanks for picking this up!~ Hmm, why did the change in `MallocChecker` tests disappear? > clang is trying to match some strings printed by the ranged constraint manager Are these state dump tests / `exploded-graph-rewriter` tests? We'll need to ignore/silence them in Z3

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:584 +void VisitRedeclarableTemplateDecl(const RedeclarableTemplateDecl *TD) { + // {Class,Function,Var,TypeAlias}TemplateDecls are visited as

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

erichkeane added inline comments. Comment at: clang/lib/Sema/ParsedAttr.cpp:143 + // otherwise return a default ParsedAttrInfo. + const ParsedAttrInfo *Info = AttrInfoMap[A.getKind()]; + if (Info) I don't think you can do this. The only way to get Info as

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type. See this thread for context:

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

bjope added a comment. When I build the clang on trunk, using clang 8.0 with asan enabled, and then run the clang lit tests I see lots of failures in Clang :: InterfaceStubs/driver-test.c and Clang :: InterfaceStubs/driver-test2.c (and maybe the faults I get in Clang ::

[PATCH] D73108: [docs][mips] 10.0 Release notes

atanasyan created this revision. atanasyan added reviewers: hans, ruiu, Petar.Avramovic, mstojanovic, arichardson. Herald added subscribers: jfb, sdardis. Herald added projects: clang, LLVM. MIPS specific part of LLVM 10.0 Release notes for LLVM, Clang and LLD. Repository: rG LLVM Github

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62057 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet updated this revision to Diff 239320. kadircet marked an inline comment as done. kadircet added a comment. - Filter out templateddecls in VisitNamedDecls, instead of defining a new Visit method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62058 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] 6a24339 - [ARM] Follow AACPS standard for volatile bit-fields access width

Author: Diogo Sampaio Date: 2020-01-21T15:23:38Z New Revision: 6a24339a45246b66bd3de88cc9c6a5b5e77c0645 URL: https://github.com/llvm/llvm-project/commit/6a24339a45246b66bd3de88cc9c6a5b5e77c0645 DIFF: https://github.com/llvm/llvm-project/commit/6a24339a45246b66bd3de88cc9c6a5b5e77c0645.diff

[clang] 2147703 - Revert "[ARM] Follow AACPS standard for volatile bit-fields access width"

Author: Diogo Sampaio Date: 2020-01-21T15:31:33Z New Revision: 2147703bde1e1a7a1b89ccb66f55d36fd17620f1 URL: https://github.com/llvm/llvm-project/commit/2147703bde1e1a7a1b89ccb66f55d36fd17620f1 DIFF: https://github.com/llvm/llvm-project/commit/2147703bde1e1a7a1b89ccb66f55d36fd17620f1.diff

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

courbet added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2907 Value *Addr = I.getArgOperand(1); -const MaybeAlign Alignment( +const Align Alignment( cast(I.getArgOperand(2))->getZExtValue()); I

[PATCH] D73104: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62057 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6a24339a4524: [ARM] Follow AACPS standard for volatile bit-fields access width (authored by dnsampaio). Repository: rG

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio reopened this revision. dnsampaio added a comment. Sorry, submitted using ide by mistake. Already reverted it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

alanphipps added a comment. This test is still failing on the arm bots and also with my downstream ARM compiler validation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72897/new/ https://reviews.llvm.org/D72897

[PATCH] D73109: [clang][index] Index the injected class name types.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, ilya-biryukov. Herald added a project: clang. Currently, we (clangd) are missing this kind of references. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73109

[PATCH] D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement

kpn marked an inline comment as done. kpn added inline comments. Comment at: clang/test/CodeGen/builtins-systemz-vector2-constrained.c:25 + // CHECK: [[NEG:%[^ ]+]] = fneg <2 x double> {{.*}} + // CHECK: [[RES:%[^ ]+]] = call <2 x double>

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4479 +const Expr *Arg = Args[AA->getParamIndex().getASTIndex()]; +if (!Arg->isTypeDependent() && !Arg->isValueDependent()) { + llvm::APSInt I(64); Does this need to be

[PATCH] D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement

kpn updated this revision to Diff 239324. kpn added a comment. Update for review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72722/new/ https://reviews.llvm.org/D72722 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-systemz-vector-constrained.c

[PATCH] D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement

kpn updated this revision to Diff 239325. kpn added a comment. Eliminate a blank line I thought I had already had gotten. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72722/new/ https://reviews.llvm.org/D72722 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D73110: [clangd] Drop returntype/type when hovering over type-ish names

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Some names, e.g. constructor/destructor/conversions, already contain the type info, no need to duplicate

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62057 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

erichkeane added a comment. In D72998#1828571 , @lebedev.ri wrote: > In D72998#1828559 , @hfinkel wrote: > > > Can we, at least, put this constant in a header file so we don't repeat it > > in several places? > >

[PATCH] D73109: [clang][index] Index the injected class name types.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62058 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

evgeny777 added inline comments. Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:762 +bool ReadOnly, bool WriteOnly, bool Constant, +GlobalObject::VCallVisibility Vis = GlobalObject::VCallVisibilityPublic) : MaybeReadOnly(ReadOnly),

[PATCH] D73110: [clangd] Drop returntype/type when hovering over type-ish names

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62057 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

evgeny777 added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:676 + bool ShouldEmitWPDInfo = CGM.getCodeGenOpts().WholeProgramVTables && + CGM.HasHiddenLTOVisibility(RD); llvm::Value *VirtualFn = nullptr; Why are

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

lebedev.ri added a comment. In D72998#1831377 , @erichkeane wrote: > In D72998#1828571 , @lebedev.ri > wrote: > > > In D72998#1828559 , @hfinkel wrote: > > > > > Can we, at

[PATCH] D73109: [clang][index] Index the injected class name types.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks this LG (please apply clang-format fixes though) Have you checked if this class is missing any other typelocs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 1fbb1d6 - [clangd] Drop returntype/type when hovering over type-ish names

Author: Kadir Cetinkaya Date: 2020-01-21T17:10:09+01:00 New Revision: 1fbb1d6df0113ca341f6d257bc72e07343dd861a URL: https://github.com/llvm/llvm-project/commit/1fbb1d6df0113ca341f6d257bc72e07343dd861a DIFF:

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindTarget.cpp:585 + // We choose to only visit TemplatedDecls for {Class, Function, Var, + // TypeAlias} TemplateDecls.

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 239328. hliao marked 2 inline comments as done. hliao added a comment. - revise comment. - add tests requiring tempate instantiation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/

[PATCH] D73110: [clangd] Drop returntype/type when hovering over type-ish names

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fbb1d6df011: [clangd] Drop returntype/type when hovering over type-ish names (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao marked 2 inline comments as done. hliao added a comment. Sorry for the late reply. Really appreciate your feedback. Thanks! Comment at: clang/include/clang/Sema/Sema.h:11198-11206 + SmallVector CUDANonLocalVariableStack; + + void pushCUDANonLocalVariable(const Decl

[PATCH] D73108: [docs][mips] 10.0 Release notes

mstojanovic added a comment. Initial MIPS support was also added to `llvm-exegesis`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73108/new/ https://reviews.llvm.org/D73108 ___ cfe-commits mailing

[PATCH] D73108: [docs][mips] 10.0 Release notes

atanasyan added a comment. In D73108#1831442 , @mstojanovic wrote: > Initial MIPS support was also added to `llvm-exegesis`. Oh, sorry. Good point, I'll add this note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73108: [docs][mips] 10.0 Release notes

atanasyan updated this revision to Diff 239333. atanasyan added a reviewer: mbrkusanin. atanasyan added a comment. - Add `llvm-exegesis` note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73108/new/ https://reviews.llvm.org/D73108 Files:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

Ruyk added a comment. Maybe we should use the year of issue (2015 instead of 1.2.1) for the -sycl-std version? That would be more stable for the upcoming SYCL versions, and match somehow the C++ versioning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >