[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

Mordante added a comment. In D73007#1829597 , @aaron.ballman wrote: > LGTM! Do you think this should also be pushed onto the release branch? Thanks for the review. Yes the bug has been marked as a release blocker. Repository: rG LLVM Github

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else { cchen wrote: >

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2703-2704 // suggest the const reference type that would do so. // For instance, given "for (const : Range)", suggest // "for (const Foo : Range)" to denote a

[PATCH] D69933: [ASTImporter] Limit imports of structs

teemperor added a comment. I really don't think the ASTImporter should ever manipulate records in the source context (effectively the source context should be considered immutable). It also seems *very* wrong that what we import depends in any way on a previous expression so I agree we should

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62080 tests passed, 1 failed and 784 were skipped. failed: Clang.Driver/cc-print-options.c {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2537 +if (!Actions.CurContext->isTranslationUnit()) { +//FIXME this seems to be the wrong way to check file-scope +//since the token immediately following a

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay added inline comments. Comment at: llvm/lib/IR/Globals.cpp:101 +return true; + return isInterposableLinkage(getLinkage()); +} MaskRay wrote: > MaskRay wrote: > > Checking `isInterposableLinkage(getLinkage())` first may be more efficient. > `if

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

NoQ added a comment. In D72982#1832058 , @xazax.hun wrote: > In D72982#1832029 , @aganea wrote: > > > In D72982#1832000 , @xazax.hun > > wrote: > > > > > Thanks!

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

ABataev updated this revision to Diff 239399. ABataev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73128/new/ https://reviews.llvm.org/D73128 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D73072: [Driver][CodeGen] Support -fpatchable-function-entry=N,M where M>0

MaskRay updated this revision to Diff 239400. MaskRay added a comment. Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73072/new/ https://reviews.llvm.org/D73072 Files: clang/include/clang/Basic/AttrDocs.td

[clang] 41fcd17 - [Sema] Avoid Wrange-loop-analysis false positives

Author: Mark de Wever Date: 2020-01-21T21:14:10+01:00 New Revision: 41fcd17250fa0526e4b7fd2c7df7721b0f79b683 URL: https://github.com/llvm/llvm-project/commit/41fcd17250fa0526e4b7fd2c7df7721b0f79b683 DIFF: https://github.com/llvm/llvm-project/commit/41fcd17250fa0526e4b7fd2c7df7721b0f79b683.diff

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4489 +// Alignment calculations can wrap around if it's greater than 2**29. +unsigned MaximumAlignment = 536870912; +if (I > MaximumAlignment) erichkeane wrote:

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62080 tests passed, 1 failed and 784 were skipped. failed: Clang.Driver/cc-print-options.c {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rG41fcd17250fa: [Sema] Avoid Wrange-loop-analysis false positives (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 020ed67 - [clang-tidy] Fix check for Abseil internal namespace access

Author: Eric Fiselier Date: 2020-01-21T15:21:53-05:00 New Revision: 020ed6713d889a95f8c98d7725c87b458d99f6b3 URL: https://github.com/llvm/llvm-project/commit/020ed6713d889a95f8c98d7725c87b458d99f6b3 DIFF: https://github.com/llvm/llvm-project/commit/020ed6713d889a95f8c98d7725c87b458d99f6b3.diff

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

Mordante added a comment. Would it make sense to also allow wmain with wchar_t? https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?view=vs-2019 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

aaronpuchert added a comment. I also still think that `warn_for_range_copy` //should be// emitted even in templates. These aren't false positives in my opinion, especially since we're now pretty conservative about that warning. Comment at:

[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

EricWF closed this revision. EricWF added a comment. Committed in 020ed6713d889a95f8c98d7725c87b458d99f6b3 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72484/new/ https://reviews.llvm.org/D72484

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge planned changes to this revision. nridge added a comment. Thanks for taking a look! In D72874#1831977 , @sammccall wrote: > - it triggers on almost every word, even words that plainly don't refer to > any decl like `format [[lazily]], in case

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

tejohnson updated this revision to Diff 239406. tejohnson added a comment. Remove stale change that didn't belong here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71907/new/ https://reviews.llvm.org/D71907 Files:

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:676 + bool ShouldEmitWPDInfo = CGM.getCodeGenOpts().WholeProgramVTables && + CGM.HasHiddenLTOVisibility(RD); llvm::Value

[PATCH] D73072: [Driver][CodeGen] Support -fpatchable-function-entry=N,M where M>0

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62081 tests passed, 2 failed and 784 were skipped. failed: Clang.Driver/cc-print-options.c failed: Clang.Driver/fpatchable-function-entry.c {icon question-circle color=gray} clang-tidy: unknown. {icon

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 239409. mibintc added a comment. Respond to review from @sepavloff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst

[clang] 5260bc2 - Allow arbitrary capability name in Thread Safety Analysis

Author: Etienne Pierre-Doray Date: 2020-01-21T15:43:17-05:00 New Revision: 5260bc2497bb593ed4a01de5cfe84ed6f7b529b1 URL: https://github.com/llvm/llvm-project/commit/5260bc2497bb593ed4a01de5cfe84ed6f7b529b1 DIFF:

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaron.ballman closed this revision. aaron.ballman added a comment. In D72635#1831782 , @eti-p-doray wrote: > Thanks! > I don't I have commit access. Can you commit on my behalf? Happy to do so! I've commit on your behalf in

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

phosek added a comment. We're seeing `Driver/cc-print-options.c` test failures after this change: TEST 'Clang :: Driver/cc-print-options.c' FAILED Script: -- : 'RUN: at line 1'; env CC_PRINT_OPTIONS=1

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13129 if (FunctionDecl *F = dyn_cast(CurContext)) { + // If the expression occurs inside an internal global_var_init_function + // then the

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson updated this revision to Diff 239412. tejohnson added a comment. Address comment and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 Files:

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else { cchen wrote: >

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

vvereschaka added a comment. Hi Richard, http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l builder has been broken by this patch during few days (failed "Clang::virtual-compare.cpp" test). Sorry, but I'm going to revert these changes. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

aganea added a comment. In D72982#1832209 , @phosek wrote: > We're seeing `Driver/cc-print-options.c` test failures after this change: Yes, seeing it too, I will commit a fix in a minute! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] a8c2f76 - Removing an accidentally duplicated line of test code to fix bots.

Author: Aaron Ballman Date: 2020-01-21T16:03:22-05:00 New Revision: a8c2f76cd258ea03f82a1fc12953ca8af6b7832b URL: https://github.com/llvm/llvm-project/commit/a8c2f76cd258ea03f82a1fc12953ca8af6b7832b DIFF: https://github.com/llvm/llvm-project/commit/a8c2f76cd258ea03f82a1fc12953ca8af6b7832b.diff

[clang] b0b2b7e - Revert "[Clang] Un-break scan-build after integrated-cc1 change"

Author: Alexandre Ganea Date: 2020-01-21T16:06:36-05:00 New Revision: b0b2b7e09926cdde4d82978a7c14b5e2d38db35c URL: https://github.com/llvm/llvm-project/commit/b0b2b7e09926cdde4d82978a7c14b5e2d38db35c DIFF:

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Mechanically, this looks fine. There's an ongoing discussion in the committee as to whether this kind of caching is permissible. But if this is necessary for acceptable performance, let's

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4489 +// Alignment calculations can wrap around if it's greater than 2**29. +unsigned MaximumAlignment = 536870912; +if (I > MaximumAlignment) jdoerfert wrote:

[PATCH] D73060: [Clang] Fix expansion of response files in -Wp after integrated-cc1 change

aganea abandoned this revision. aganea added a comment. Abandoning this in favor of D73120 . Please take a look at the other patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73060/new/

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

lebedev.ri updated this revision to Diff 239421. lebedev.ri added a comment. Add constants to `Sema` class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72998/new/ https://reviews.llvm.org/D72998 Files: clang/include/clang/Sema/Sema.h

[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

aganea updated this revision to Diff 239420. aganea added a comment. Remove `Reenter` flag as requested by @hans here . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73120/new/ https://reviews.llvm.org/D73120 Files:

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4479 +const Expr *Arg = Args[AA->getParamIndex().getASTIndex()]; +if (!Arg->isTypeDependent() && !Arg->isValueDependent()) { + llvm::APSInt

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked 5 inline comments as done. tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@"

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 239428. tejohnson marked 2 inline comments as done. tejohnson added a comment. Address comments and rebase. Also apply modified change to ItaniumCXXABI.cpp and a change to an associated test (cfi-mfcall.cpp) here as discussed in child revision D71907

[PATCH] D71566: New checks for fortified sprintf

aaron.ballman added a comment. (There are still some minor whitespace nits to resolve as well.) Comment at: clang/lib/Sema/SemaChecking.cpp:743 + } + assert(UsedSize && "Found a size estimate"); + if (UsedSize.getValue().ule(ObjectSize)) I think this

[clang] 133a7e6 - [PATCH] Reland [Clang] Un-break scan-build after integrated-cc1 change

Author: Alexandre Ganea Date: 2020-01-21T17:03:00-05:00 New Revision: 133a7e631cee97965e310f0d110739217427fd3d URL: https://github.com/llvm/llvm-project/commit/133a7e631cee97965e310f0d110739217427fd3d DIFF:

[PATCH] D73140: [clangd] Add C++20 concepts support to TargetFinder

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73140 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D72434: Support offset of member designator with the arrow for __builtin_offsetof

efriedma added a comment. Testcase? I assume we give appropriate errors if you try to use "->" on a member that's not an array? Comment at: clang/lib/Parse/ParseExpr.cpp:2168 -// FIXME: This loop leaks the index expressions on error. while (1) {

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:474 if (const auto *Decl = dyn_cast(D)) { +if (isParamInMainLikeFunction(*Decl)) + return SK_Invalid; I think a better approach may

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2703-2704 // suggest the const reference type that would do so. // For instance, given "for (const : Range)", suggest // "for (const Foo : Range)" to denote a copy is made for the loop. If //

[clang] 89e43f0 - Revert "List implicit operator== after implicit destructors in a vtable."

Author: Vladimir Vereschaka Date: 2020-01-21T13:07:56-08:00 New Revision: 89e43f04ba87a0da6e94863db149669c7536486b URL: https://github.com/llvm/llvm-project/commit/89e43f04ba87a0da6e94863db149669c7536486b DIFF:

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else { cchen wrote: >

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

BillyONeal created this revision. BillyONeal added reviewers: ldionne, EricWF, mclow.lists. Herald added subscribers: dexonsmith, christof. I'm not sure if this was a change in the standard behavior or if it was a typo in libcxx from the beginning. http://eel.is/c++draft/span.sub#10 says that if

[PATCH] D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test.

BillyONeal abandoned this revision. BillyONeal added a comment. It looks like someone already fixed this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61365/new/ https://reviews.llvm.org/D61365 ___ cfe-commits mailing list

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

vvereschaka added a comment. > You mean, instead of ninja check-cxx just invoke LIT directly and pass this > argument? No, a little bit different. Probably we need something like 'LIBCXX_LLVM_LIT_ARGS` and pass the LIT arguments into the libc++ tests through that kind of parameter (and most

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

arphaman added a comment. Please add a test that exercises path without ARC enabled. Comment at: clang/lib/Sema/SemaExprObjC.cpp:3019 +if (ReceiverType->isObjCClassType() && !isImplicit && +(!Receiver->isObjCSelfExpr() || !getLangOpts().ObjCAutoRefCount)) {

[PATCH] D73140: [clangd] Add C++20 concepts support to TargetFinder

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62082 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

aganea added a comment. In D72982#1832233 , @aganea wrote: > In D72982#1832209 , @phosek wrote: > > > We're seeing `Driver/cc-print-options.c` test failures after this change: > > > Yes, seeing it too, I will

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 marked an inline comment as done. njames93 added a comment. In D73098#1832131 , @Mordante wrote: > Would it make sense to also allow wmain with wchar_t? > https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?view=vs-2019

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 239437. modocache added a comment. Rebase past D72547 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files:

[PATCH] D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on call-site function return value

jdoerfert added inline comments. Comment at: clang/test/CodeGen/assume-aligned-and-alloc-align-attributes.c:12 // CHECK-NEXT:[[MASKCOND:%.*]] = icmp eq i64 [[MASKEDPTR]], 0 // CHECK-NEXT:call void @llvm.assume(i1 [[MASKCOND]]) // CHECK-NEXT:ret i8* [[CALL]]

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4489 +// Alignment calculations can wrap around if it's greater than 2**29. +unsigned MaximumAlignment = 536870912; +if (I > MaximumAlignment) erichkeane wrote:

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. @jyknight Do you think you'll have time to review this patch this week? I'd like to get it into the 10.0 release if possible. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868

[PATCH] D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on call-site function return value

lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: clang/test/CodeGen/assume-aligned-and-alloc-align-attributes.c:12 // CHECK-NEXT:[[MASKCOND:%.*]] = icmp eq i64 [[MASKEDPTR]], 0 // CHECK-NEXT:call void @llvm.assume(i1

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hctim added a comment. In D69825#1831691 , @plotfi wrote: > In the meantime I could -fno-integrated-cc1 the driver.c InterfaceStubs > tests to quite the bots if that is what people want (and file a bug on > bugzilla). Yes, please. A temporary

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

jdoerfert added a comment. @kkwli0 I propose you can merge the parts where discussion has reached a consensus while the other parts are resolved. I'm generally fine with this, we can always improve on it further. Comment at: clang/docs/OpenMPSupport.rst:194

<    1   2   3