[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

yaxunl updated this revision to Diff 241877. yaxunl added a comment. Fix SYCL version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGenCUDA/norecurse.cu

[clang] 70c9867 - [clang-format] Add option for not breaking line before ObjC params

Author: mydeveloperday Date: 2020-02-01T17:39:34Z New Revision: 70c98671fa7b395a52829b91782393f4c2613562 URL: https://github.com/llvm/llvm-project/commit/70c98671fa7b395a52829b91782393f4c2613562 DIFF: https://github.com/llvm/llvm-project/commit/70c98671fa7b395a52829b91782393f4c2613562.diff

[PATCH] D73434: [Sema] Remove a -Wrange warning from -Wall

This revision was automatically updated to reflect the committed changes. Closed by commit rGc03349e40f21: [Sema] Remove a -Wrange warning from -Wall (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73434/new/

[PATCH] D67113: ICK_Function_Conversion is a third kind conversion

aaronpuchert added a comment. @rsmith Could you have a look at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67113/new/ https://reviews.llvm.org/D67113 ___ cfe-commits mailing list

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

This revision was automatically updated to reflect the committed changes. Closed by commit rG70c98671fa7b: [clang-format] Add option for not breaking line before ObjC params (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73841: [clang-tidy] Fixed crash 44745 in readability-else-after-return

njames93 updated this revision to Diff 241902. njames93 added a comment. - new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73841/new/ https://reviews.llvm.org/D73841 Files:

[PATCH] D29692: [clang-tidy] add check modernize-use-const-instead-of-define

AlexanderLanin abandoned this revision. AlexanderLanin added a comment. This is now detected by cppcoreguidelines-macro-usage, so this seems out of date. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D29692/new/ https://reviews.llvm.org/D29692

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:47 +CheckFactories.registerCheck( +"cppcoreguidelines-prefer-member-initializer"); CheckFactories.registerCheck(

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

aaron.ballman added a comment. In D71973#1817941 , @gbencze wrote: > Another option that came to my mind is using a BitVector to (recursively) > flag bits that are occupied by the fields. This solution would be slightly > slower and uses more memory but

[PATCH] D73834: Update for Clang 10 release notes

Mordante created this revision. Mordante added a reviewer: hans. Mordante added a project: clang. Herald added a subscriber: cfe-commits. This contains the update for the release notes for D73007 and D73434 . You already

[PATCH] D73834: Update for Clang 10 release notes

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D73434: [Sema] Remove a -Wrange warning from -Wall

Mordante added a comment. Created D73834 to cherry-pick the changes to the release branch and updates the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73434/new/ https://reviews.llvm.org/D73434

[PATCH] D72730: [clang-tidy] run-clang-tidy -export-fixes exports only fixes, not all warnings

AlexanderLanin updated this revision to Diff 241895. AlexanderLanin added a comment. Review findings applied (no real measurable difference in speed, maybe 100ms) but it's indeed more readable. Without this fix the export took 12.96 seconds, with this patch 11.07 seconds. Difference is even

[PATCH] D73841: [clang-tidy] Fixed crash 44745 in readability-else-after-return

njames93 created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73841 Files: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Wawha updated this revision to Diff 241875. Wawha marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44609/new/ https://reviews.llvm.org/D44609 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaronpuchert added a comment. Thanks for the reviews! Do you think it makes sense to bring this to Clang 10? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68923/new/ https://reviews.llvm.org/D68923

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaron.ballman added a comment. In D68923#1853302 , @aaronpuchert wrote: > Thanks for the reviews! Do you think it makes sense to bring this to Clang 10? I think it's a simple enough fix that it may be worth it, but it isn't fixing a regression in

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Wawha updated this revision to Diff 241874. Wawha marked an inline comment as done. Wawha added a comment. @MyDeveloperDay I launch docs/tools/dump_style.py on ClangFormatStyleOptions.rst (it seems to generate the same result as the previous diff) and add an entry in the Release Note. Tell me

[PATCH] D73768: clang-format: [JS] document InsertTrailingCommas.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73768/new/ https://reviews.llvm.org/D73768

[clang] c03349e - [Sema] Remove a -Wrange warning from -Wall

Author: Mark de Wever Date: 2020-02-01T18:44:27+01:00 New Revision: c03349e40f21f0375278138992a32694a99c830e URL: https://github.com/llvm/llvm-project/commit/c03349e40f21f0375278138992a32694a99c830e DIFF: https://github.com/llvm/llvm-project/commit/c03349e40f21f0375278138992a32694a99c830e.diff

[clang] 268e57b - [clang][driver] Remove an unused parameter. NFC.

Author: Michael Liao Date: 2020-02-01T16:18:05-05:00 New Revision: 268e57bd35d7e05928820ad90f325e19e7a809d0 URL: https://github.com/llvm/llvm-project/commit/268e57bd35d7e05928820ad90f325e19e7a809d0 DIFF: https://github.com/llvm/llvm-project/commit/268e57bd35d7e05928820ad90f325e19e7a809d0.diff

[PATCH] D73841: [clang-tidy] Fixed crash 44745 in readability-else-after-return

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62371 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73841: [clang-tidy] Fixed crash 44745 in readability-else-after-return

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62371 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

ianlevesque created this revision. ianlevesque added reviewers: hiraditya, smeenai, dberris. Herald added a project: clang. Herald added a subscriber: cfe-commits. The function attributes xray-skip-entry, xray-skip-exit, and xray-ignore-loops were only being applied if a function had an

[PATCH] D73090: [clang-tidy] Fix PR#44528 'modernize-use-using and enums'

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp:74 if (ReplaceRange.getBegin().isMacroID() || - ReplaceRange.getBegin() >= LastReplacementEnd) { + (Result.SourceManager->getFileID(ReplaceRange.getBegin()) !=

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1103 Opts.XRayIgnoreLoops = - Args.hasArg(OPT_fxray_ignore_loops, OPT_fno_xray_ignore_loops, false); + Args.hasFlag(OPT_fxray_ignore_loops, OPT_fno_xray_ignore_loops, false);

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:172-174 + lineMatcher = re.compile('Renamed checks') + nextSectionMatcher = re.compile('Improvements to include-fixer') + checkMatcher = re.compile('- The \'(.*)') What's

[PATCH] D73841: [clang-tidy] Fixed crash 44745 in readability-else-after-return

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73841/new/ https://reviews.llvm.org/D73841

[PATCH] D73843: [clang-tidy] Fix false positive for cppcoreguidelines-init-variables

njames93 created this revision. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. njames93 retitled this revision from "[clang-tidt] Fix false positive for cppcoreguidelines-init-variables" to "[clang-tidy] Fix false positive for

[PATCH] D73843: [clang-tidy] Fix false positive for cppcoreguidelines-init-variables

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp:37 + optionally(hasParent(declStmt(hasParent( +

[PATCH] D73843: [clang-tidy] Fix false positive for cppcoreguidelines-init-variables

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62371 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 241872. bader added a comment. Fix clang-format and clang-tidy issues reported by merge_guards_bot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62372 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] 1acf129 - [Frontend] Delete a redundant check of -pg for setFramePointer()

Author: Fangrui Song Date: 2020-02-01T00:29:29-08:00 New Revision: 1acf129bcf9a1b51e301a9fef151254ec4c7ec43 URL: https://github.com/llvm/llvm-project/commit/1acf129bcf9a1b51e301a9fef151254ec4c7ec43 DIFF: https://github.com/llvm/llvm-project/commit/1acf129bcf9a1b51e301a9fef151254ec4c7ec43.diff

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

njames93 added a comment. So I tried to ran `./rename_check.py readability-braces-around-statements readability-braces` and results were less than desirable. It renamed the `readability-braces-around-statements` but it also renamed the google alias to `google-readability-braces`. In the

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:75 + continue; +if (AnyHeader || File->NamePart.equals_lower(ThisFile->NamePart)) + return; // Found a