[PATCH] D73357: [ARM,MVE] Add intrinsics for v[id]dupq and v[id]wdupq.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8d4afc49ad2: [ARM,MVE] Add intrinsics for v[id]dupq and v[id]wdupq. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D73357?vs=240207=242011#toc Repository: rG LLVM

[PATCH] D73786: [ARM,MVE] Fix vreinterpretq in big-endian mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rG961530fdc9f7: [ARM,MVE] Fix vreinterpretq in big-endian mode. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D73786?vs=241727=242012#toc Repository: rG LLVM Github

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet updated this revision to Diff 241988. gchatelet marked 3 inline comments as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 Files:

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2252 + + * ``__builtin_memcpy_inline`` + efriedma wrote: > This is in the wrong section of the documentation. We could > constant-evaluate __builtin_memcpy_inline, I guess, but that

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr marked 11 inline comments as done. alexeyr added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:363 + ASTContext ) { + const auto OpKind = getOp(TheExpr); + // if there are no nested operators of the

[PATCH] D73869: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

hokein created this revision. hokein added a reviewer: gribozavr2. Herald added a project: clang. misc-unused-using clang-tidy check needs this matcher to fix a false positive of C++17 deduced class template types. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73869 Files:

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:32 + // + // class Foo {}; + // ^ Foo declaration hokein wrote: > could you confirm with it? this looks like a `Foo` class definition. Good point, I thought it should be

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr updated this revision to Diff 242000. alexeyr added a comment. Followed Eugene Zelenko's comments and fixed a false positive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73775/new/ https://reviews.llvm.org/D73775 Files:

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62406 tests passed, 0 failed and 839 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[clang] bdbdf74 - [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

Author: Haojian Wu Date: 2020-02-03T12:11:44+01:00 New Revision: bdbdf748225525bb18cd0ffeb51c3e713f7b8e1b URL: https://github.com/llvm/llvm-project/commit/bdbdf748225525bb18cd0ffeb51c3e713f7b8e1b DIFF: https://github.com/llvm/llvm-project/commit/bdbdf748225525bb18cd0ffeb51c3e713f7b8e1b.diff

[PATCH] D73869: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62408 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73536: [analyser][taint] Remove taint from symbolic expressions if used in comparisons

Szelethus added a comment. In D73536#1845031 , @NoQ wrote: > > Describing value constraints in the taint config file is unfeasible. > > This is the only correct way to go, because, as you yourself point out, every > sink function (or other use of tainted

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey updated this revision to Diff 241984. awpandey marked 2 inline comments as done. awpandey added a comment. Thanks, @aprantl, and @dblaikie. I have added two new test cases as per your suggestions. I have to update // dityperefs-3.8.ll// and //dityperefs-3.8.ll.bc// because they are no

[PATCH] D73869: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6043 +/// \endcode +/// \c deducedTemplateSpecializationType() matches the type in \c c. +extern const

[PATCH] D73356: [ARM,MVE] Add intrinsics for vdupq.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf7e98e6f780: [ARM,MVE] Add intrinsics for vdupq. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73356/new/

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst closed this revision. mprobst marked an inline comment as done. mprobst added a comment. This has landed as https://reviews.llvm.org/rGa324fcf1ae6 (not sure why this hasn't closed automatically). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. Friendly ping. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] b79cb54 - [clangd] Refactor TUScheduler options into a struct. NFC

Author: Sam McCall Date: 2020-02-03T11:20:48+01:00 New Revision: b79cb547121dbd9f4bd4eaaf05354829ab74ac8e URL: https://github.com/llvm/llvm-project/commit/b79cb547121dbd9f4bd4eaaf05354829ab74ac8e DIFF: https://github.com/llvm/llvm-project/commit/b79cb547121dbd9f4bd4eaaf05354829ab74ac8e.diff

[clang-tools-extra] 6b15a3d - [clangd] TUScheduler::run() (i.e. workspace/symbol) counts towards concurrent threads

Author: Sam McCall Date: 2020-02-03T11:32:33+01:00 New Revision: 6b15a3d722a98c8c4f99ac45cae118e4af9244af URL: https://github.com/llvm/llvm-project/commit/6b15a3d722a98c8c4f99ac45cae118e4af9244af DIFF: https://github.com/llvm/llvm-project/commit/6b15a3d722a98c8c4f99ac45cae118e4af9244af.diff

[clang] cf7e98e - [ARM,MVE] Add intrinsics for vdupq.

Author: Simon Tatham Date: 2020-02-03T11:20:06Z New Revision: cf7e98e6f7805f4e2693a6dbbd12c10fe06fde70 URL: https://github.com/llvm/llvm-project/commit/cf7e98e6f7805f4e2693a6dbbd12c10fe06fde70 DIFF: https://github.com/llvm/llvm-project/commit/cf7e98e6f7805f4e2693a6dbbd12c10fe06fde70.diff LOG:

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

tonyelewis added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:75 + continue; +if (AnyHeader || File->NamePart.equals_lower(ThisFile->NamePart)) + return; // Found a good candidate for matching decl

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61851 tests passed, 6 failed and 780 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[PATCH] D73869: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbdbdf7482255: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73869: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62408 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73834: Update for Clang 10 release notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me, go a head and commit it to the branch. > Can you cherry-pick c03349e40f21 > for > D73434

Re: [clang] 1f3f8c3 - PR44721: Don't consider overloaded operators for built-in comparisons

Yes, go ahead. On Fri, Jan 31, 2020 at 2:19 AM Richard Smith wrote: > > Hi Hans, > > This is a pretty safe bugfix for a new feature in Clang 10. OK for branch? > > On Thu, 30 Jan 2020 at 17:17, Richard Smith via cfe-commits > wrote: >> >> >> Author: Richard Smith >> Date:

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good, a few nits. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:249 + llvm::SmallVector + RebuildTimes; /* GUARDED_BY(Mutex) */ /// File that ASTWorker

[clang-tools-extra] 7d4c23b - [clang-tidy] Fix a false positive about C++17 deduced class template types in unused-using-decl check.

Author: Haojian Wu Date: 2020-02-03T16:25:10+01:00 New Revision: 7d4c23b349f8d0575304182650850f2594935d7c URL: https://github.com/llvm/llvm-project/commit/7d4c23b349f8d0575304182650850f2594935d7c DIFF: https://github.com/llvm/llvm-project/commit/7d4c23b349f8d0575304182650850f2594935d7c.diff

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62418 tests passed, 0 failed and 845 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3412-3414 +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group, Flags<[CC1Option]>,

[clang] 6c3252e - [OPENMP][DOCS]Update status of conditional lastprivate, NFC.

Author: Alexey Bataev Date: 2020-02-03T12:43:40-05:00 New Revision: 6c3252e5211b0c6ce6eb4a1123d60bb74faec0be URL: https://github.com/llvm/llvm-project/commit/6c3252e5211b0c6ce6eb4a1123d60bb74faec0be DIFF: https://github.com/llvm/llvm-project/commit/6c3252e5211b0c6ce6eb4a1123d60bb74faec0be.diff

[PATCH] D69781: [analyzer] Add test directory for scan-build

NoQ reopened this revision. NoQ added a comment. This revision is now accepted and ready to land. I'll try to re-land this. I heard there were a lot more issues than just honoring `CLANG_INSTALL_SCANBUILD=NO` (which i'll do my best to test before pushing), so i'll monitor the buildbots

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62099 tests passed, 5 failed and 784 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62298 tests passed, 121 failed and 845 were skipped. failed: Clang.CXX/modules-ts/basic/basic_link/p3.cppm failed: Clang.CXX/modules-ts/codegen-basics.cppm failed: Clang.CodeGen/arm-aapcs-vfp.c failed:

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik added a comment. Also note that blocks are an clang extension and also work in C whereas lambdas are a standard C++ feature and naming although implementation defined mostly falls out of the fact that C++ has member functions and so can be placed inside class as `operator()`. CHANGES

[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

This revision was automatically updated to reflect the committed changes. Closed by commit rG398b4ed87d48: [clang] detect switch fallthrough marked by a comment (PR43465) (authored by llunak). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

dmgreen added a comment. I added some `This?`'s around, which may or may not be needed too. Comment at: llvm/include/llvm/Support/ARMTargetParser.h:196 unsigned DefaultFPU; unsigned ArchBaseExtensions; T ID; This? Comment at:

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

jkorous added a comment. We should either simplify the implementation to reflect that we don't support e. g. `*:42` (seems preferable to me) or have the codepaths that are currently not accessible through `-fverify` tested by other means. Comment at:

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim updated this revision to Diff 242144. fghanim added a comment. Addressing errors/warnings from commit build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304 Files:

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl updated this revision to Diff 242145. yaxunl added a comment. revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaCUDA.cpp

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert marked 4 inline comments as done. jdoerfert added a comment. In D71830#1854989 , @kiranchandramohan wrote: > Had a quick look today. Will spend some more time tomorrow. > Please see a few comments inline. Thanks! I'll rebase asap to address

[PATCH] D73900: [BPF] use base lvalue type for preserve_{struct,union}_access_index metadata

yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Linux commit

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/Driver/Options.td:3412-3414 +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; +def sycl_std_EQ : Joined<["-"], "sycl-std=">,

[PATCH] D73903: [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, dancgr, efriedma, c-rhodes. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. kmclaughlin added a parent revision: D73719:

[clang] a781521 - [OPENMP50]Codegen support for order(concurrent) clause.

Author: Alexey Bataev Date: 2020-02-03T12:27:33-05:00 New Revision: a781521867e9952e8d5856e10bf900b37f8ec4e8 URL: https://github.com/llvm/llvm-project/commit/a781521867e9952e8d5856e10bf900b37f8ec4e8 DIFF: https://github.com/llvm/llvm-project/commit/a781521867e9952e8d5856e10bf900b37f8ec4e8.diff

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

miyuki created this revision. miyuki added reviewers: simon_tatham, eli.friedman, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch changes the underlying type of the ARM::ArchExtKind enumeration to

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:411 + if (ExplodedNode *N = C.generateErrorNode(State)) { +// FIXME Add detailed diagnostic. +std::string Msg = "Function argument constraint is not

[PATCH] D73900: [BPF] use base lvalue type for preserve_{struct,union}_access_index metadata

anakryiko accepted this revision. anakryiko added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73900/new/ https://reviews.llvm.org/D73900

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

peter.smith added a comment. I think this is the right thing to do. According to https://sourceware.org/binutils/docs/ld/Options.html#Options Add the archive or object file specified by namespec to the list of files to link. This option may be used any number of times. If namespec is of the

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

kiranchandramohan added a comment. Had a quick look today. Will spend some more time tomorrow. Please see a few comments inline. Comment at: clang/include/clang/AST/OpenMPClause.h:6429 +/// and an ordered collection of properties. +struct OpenMPTraitInfo { + struct

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ added a comment. Also, yay, thanks for using the new API! Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:41 const SVal = UndefinedVal()) const; - void handleAssign(CheckerContext , const SVal ) const; - void

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:731 + } + return C.getNoteTag([Text, Name](BugReport ) -> std::string { + SmallString<256> Msg; You'll need to check whether the container is actually of

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

miyuki updated this revision to Diff 242114. miyuki added a comment. Fix one missing unsigned->uint64_t occurrence CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73906/new/ https://reviews.llvm.org/D73906 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG789a46f2d742: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition (authored by MaskRay). Repository:

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp:114 if (P.a[X++] != P.a[X++]) return 1; + if (X && X++ && X) return 1; alexeyr wrote: > aaron.ballman wrote: > > What do you think

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

ianlevesque marked 2 inline comments as done. ianlevesque added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:832 +Fn->addFnAttr("xray-skip-exit"); + } + if (!CGM.getCodeGenOpts().XRayInstrumentationBundle.has( @hiraditya I

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson marked 3 inline comments as done. tejohnson added inline comments. Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:830 enum Kind { +Unknown, ///< Unknown (analysis not performed, don't lower) Unsat, ///< Unsatisfiable type (i.e. no global has

[PATCH] D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration.

yamauchi updated this revision to Diff 242103. yamauchi added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69591/new/ https://reviews.llvm.org/D69591 Files: clang/test/CodeGenCXX/member-function-pointer-calls.cpp

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof created this revision. christof added reviewers: peter.smith, jroelofs. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the clang baremetal driver selects the rt.builtins static library it prefix with "-l" and appends ".a". The result is a nonsense option

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

NoQ added a comment. This looks fantastic, i didn't think of this originally. All hail type safety! Nits below. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:182 + +FunctionSummaryTy (ValueRangeSet VRS) { + Ranges.push_back(VRS);

[libunwind] 221c5af - Fix a -Wbitwise-conditional-parentheses warning in _LIBUNWIND_ARM_EHABI libunwind builds

Author: Nico Weber Date: 2020-02-03T14:17:50-05:00 New Revision: 221c5af4e4f4a504a4d1f352dd7b76d305e56a62 URL: https://github.com/llvm/llvm-project/commit/221c5af4e4f4a504a4d1f352dd7b76d305e56a62 DIFF: https://github.com/llvm/llvm-project/commit/221c5af4e4f4a504a4d1f352dd7b76d305e56a62.diff

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

merge_guards_bot added a comment. Herald added subscribers: wuzish, dexonsmith. {icon times-circle color=red} Unit tests: fail. 62284 tests passed, 121 failed and 839 were skipped. failed: Clang.CXX/modules-ts/basic/basic_link/p3.cppm failed: Clang.CXX/modules-ts/codegen-basics.cppm

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

MaskRay created this revision. MaskRay added reviewers: peter.smith, rnk, serge-sans-paille, sfertile. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jsji, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan,

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

peter.smith added a comment. If I've understood correctly this would make LLVM more aggressive for PIC relocation models, but perhaps more honest in an inter procedural optimisation context? The code changes look fine to me, I'm wondering if we've discussed this widely enough with the

[PATCH] D73876: [clang-tidy] Fix a false positive about C++17 deduced class template types in unused-using-decl check.

hokein created this revision. hokein added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73876 Files: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp

[PATCH] D73856: [docu] Improve docu of misc-misplaced-const

aaron.ballman added a comment. > East const makes the problem more obvious. With west const people were > telling me the const is on the wrong side. I don't see how this makes the problem more obvious and it seems odd to me that we'd mix styles in code and prose. I prefer leaving this as a

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp:114 if (P.a[X++] != P.a[X++]) return 1; + if (X && X++ && X) return 1; What do you think about the following? ``` bool foo(int&);

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook created this revision. simoncook added reviewers: asb, lenary, PaoloS, s.egerton. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay,

[PATCH] D71155: [analyzer] CERT: STR30-C

NoQ added a comment. Let's separate `CStringChecker` improvements into a separate patch and have a separate set of tests for it. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2097-2098 +void CStringChecker::evalCharPtrCommon(CheckerContext , +

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

martong created this revision. martong added a reviewer: NoQ. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang. Repository: rG LLVM

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong created this revision. martong added a reviewer: NoQ. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang. Repository: rG LLVM

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

NoQ added a comment. Other than the packaging debate, i think this check looks good! Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:641 -} // end: "optin.cplusplus" - -let ParentPackage = CplusplusAlpha in { - -def ContainerModeling :

[clang] 0ce5773 - [clang] Add a missing change of bdbdf748225525bb18cd0ffeb51c3e713f7b8e1b, fix the buildbot.

Author: Haojian Wu Date: 2020-02-03T13:43:26+01:00 New Revision: 0ce57731da9bf5967d0332b0b1d35790b65007d7 URL: https://github.com/llvm/llvm-project/commit/0ce57731da9bf5967d0332b0b1d35790b65007d7 DIFF: https://github.com/llvm/llvm-project/commit/0ce57731da9bf5967d0332b0b1d35790b65007d7.diff

[PATCH] D72954: [clang-doc] Improving Markdown Output

Clayton updated this revision to Diff 242066. Clayton added a comment. build error fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/D72954 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D73876: [clang-tidy] Fix a false positive about C++17 deduced class template types in unused-using-decl check.

hokein updated this revision to Diff 242065. hokein marked an inline comment as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73876/new/ https://reviews.llvm.org/D73876 Files:

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. In D72705#1854641 , @baloghadamsoftware wrote: > Please add tests for all the functions in the list. How to handle the combinatoric explosion in test code? It is too much code to add all functions to

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3412-3414 +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group, Flags<[CC1Option]>,

[PATCH] D72954: [clang-doc] Improving Markdown Output

Clayton reopened this revision. Clayton added a comment. This revision is now accepted and ready to land. Fixing build error CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/D72954 ___ cfe-commits mailing

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 241994. kbobyrev added a comment. Remove unnecessary include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 Files: clang-tools-extra/clangd/index/Ref.h

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 241993. kbobyrev marked 14 inline comments as done. kbobyrev added a comment. Address a number of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 Files:

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61851 tests passed, 6 failed and 780 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[PATCH] D73869: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

hokein updated this revision to Diff 242007. hokein marked an inline comment as done. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73869/new/ https://reviews.llvm.org/D73869 Files:

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. Currently we delay AST rebuilds by 500ms after each edit, to wait for further

[PATCH] D73876: [clang-tidy] Fix a false positive about C++17 deduced class template types in unused-using-decl check.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62415 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

aganea added a comment. In D73742#1854773 , @hans wrote: > > Evidently I can cut the patch in smaller pieces, let me know. > > Yes, I think this would be good. There's a lot going on in this patch, and it > would be good to separate the simple stuff from

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Reverted in 9dcfc7cd64abb301124cafaa95661b76a1fc5032 because of breakages and warnings:

[PATCH] D73876: [clang-tidy] Fix a false positive about C++17 deduced class template types in unused-using-decl check.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unused-using-decls-cxx17.cpp:10 +}; +// Deduction hint (CTAD) +template Foo(T t) -> Foo;

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 242064. balazske added a comment. - Bug fixes in the generic code. - Added new check types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 Files:

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr marked an inline comment as done. alexeyr added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp:114 if (P.a[X++] != P.a[X++]) return 1; + if (X && X++ && X) return 1; aaron.ballman wrote: >

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

hans added a comment. I think so, but I need to look closer at the CrashRecoveryContext changes, and it would help to do that separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73742/new/ https://reviews.llvm.org/D73742

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

simoncook updated this revision to Diff 242082. simoncook added a comment. Rebase changes on top of experimental feature support (D73891 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72901/new/ https://reviews.llvm.org/D72901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:195 + + static const char *getTag() { return "FindLastStore"; } + Charusso wrote: > I have made every tag a small-string. This way it's harder to

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook updated this revision to Diff 242080. simoncook added a comment. Don't put option in m_riscv_Features_Group, we don't want it being handled like a feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/ https://reviews.llvm.org/D73891 Files:

[PATCH] D71433: [analyzer] CERT: POS34-C

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/PutenvWithAutoChecker.cpp:57-58 +bugreporter::trackExpressionValue(Report->getErrorNode(), ArgExpr, *Report); + } else if (const SymbolRef Sym = + ArgV.getAsSymbol()) { // It is

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:194 +--+--+--+---+ -|

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

emilio added a comment. Could anyone update me with how do they want me to proceed here? Is fixing the coercions enough to allow this to land? Do I need to make it target-specific? If so, which targets should keep the current behavior? Another slightly more backwards-compatible alternative

[PATCH] D72867: [clangd] Support renaming designated initializers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62405 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ca740387b9b: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder. (authored by fghanim, committed by jdoerfert). Changed prior to commit:

  1   2   >