[PATCH] D74050: [clang-format] Do not merge short C# class definitions into one line

This revision was automatically updated to reflect the committed changes. Closed by commit rGf40a7972cb42: [clang-format] Do not merge short C# class definitions into one line (authored by Jonathan Coe jb...@google.com). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

This revision was automatically updated to reflect the committed changes. Closed by commit rG428583dd22fd: [DebugInfo] Fix debug-info generation for block invocations so that we set the… (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

NoQ added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-no-recursion.cpp:153 +// CHECK-NOTES: :[[@LINE-7]]:3: note: Frame #1: function 'boo' calls function 'bar' here: +// CHECK-NOTES: :[[@LINE-14]]:18: note: Frame #2: function 'bar' calls

[clang] ca1fd46 - [clang-format] Do not treat C# attribute targets as labels

Author: Jonathan Coe Date: 2020-02-05T17:30:24Z New Revision: ca1fd460f1f5bc4c200f557b63d69a93e3722175 URL: https://github.com/llvm/llvm-project/commit/ca1fd460f1f5bc4c200f557b63d69a93e3722175 DIFF: https://github.com/llvm/llvm-project/commit/ca1fd460f1f5bc4c200f557b63d69a93e3722175.diff LOG:

[PATCH] D73636: [AArch64][SVE] SVE2 intrinsics for complex integer arithmetic

kmclaughlin updated this revision to Diff 242683. kmclaughlin edited the summary of this revision. kmclaughlin added a comment. Changed misleading intrinsic class names used with cadd, sqcadd, cmla & sqrdcmlah CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73636/new/

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware marked 5 inline comments as done. baloghadamsoftware added a comment. In D70818#1860115 , @Szelethus wrote: > I dont think any of my comments were addressed -- could you follow up? I addressed two, added fixme for another one. Now I

[clang] 428583d - [DebugInfo] Fix debug-info generation for block invocations so that we set the LinkageName

Author: shafik Date: 2020-02-05T11:07:30-08:00 New Revision: 428583dd22fdc8f789390822e7b8ef4a5534721d URL: https://github.com/llvm/llvm-project/commit/428583dd22fdc8f789390822e7b8ef4a5534721d DIFF: https://github.com/llvm/llvm-project/commit/428583dd22fdc8f789390822e7b8ef4a5534721d.diff LOG:

[PATCH] D73903: [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations

kmclaughlin marked an inline comment as done. kmclaughlin added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1852 -// SVE2 MLA LANE. -def int_aarch64_sve_smlalb_lane : SVE2_3VectorArg_Indexed_Intrinsic; sdesmalen wrote: > nit: why

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. My apologies for being a pest, but I wanted to know the status of reviews for this bug. @jyknight & @rnk, do you have further comments or need more time? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/

[PATCH] D74043: [clang-format] Do not treat C# attribute targets as labels

This revision was automatically updated to reflect the committed changes. Closed by commit rGca1fd460f1f5: [clang-format] Do not treat C# attribute targets as labels (authored by Jonathan Coe jb...@google.com). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

aganea added a comment. In D73742#1854810 , @hans wrote: > I think so, but I need to look closer at the CrashRecoveryContext changes, > and it would help to do that separately. I split this into smaller pieces. Please take a look at D74063

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

Ericson2314 added a comment. Do I need to do anything more with this, or will somebody else just merge this at come point? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. In the absence of any other comments, This LGTM, this may help to resolve D68569: [clang-format] Also look for .{ext}.clang-format file , I

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:731 + } + return C.getNoteTag([Text, Name](BugReport ) -> std::string { + SmallString<256> Msg;

[PATCH] D74028: [clang] Add release notes for the 10.x branch for things I've done

mstorsjo closed this revision. mstorsjo added a comment. Committed in https://reviews.llvm.org/rG7e518f3159bd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74028/new/ https://reviews.llvm.org/D74028

[clang] da45bd2 - [VFS] More consistent support for Windows

Author: Adrian McCarthy Date: 2020-02-05T11:38:20-08:00 New Revision: da45bd232165eab5d6ec4f1f4f18db8644289142 URL: https://github.com/llvm/llvm-project/commit/da45bd232165eab5d6ec4f1f4f18db8644289142 DIFF:

[PATCH] D69868: Allow "callbr" to return non-void values

MaskRay accepted this revision. MaskRay added a comment. I think this is fine, but want to hear from @jyknight and @rnk. Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:1039 + auto = BB->back(); + for (unsigned i = 0; i < Last.getNumOperands(); ++i)

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

aganea created this revision. aganea added reviewers: hans, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. When `#pragma clang __debug crash` is used, currently `Driver::generateCompilationDiagnostics()` doesn't work. The `clang -E` created for diagnostics would

[PATCH] D74071: [Profile] Avoid deadlock in multithreaded context when forking with coverage enabled

calixte created this revision. calixte added a reviewer: marco-c. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, jfb, hiraditya. Herald added projects: clang, Sanitizers, LLVM. When a program is forked with code coverage enabled, all the counters are flushed. To avoid data

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

NoQ added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-no-recursion.cpp:153 +// CHECK-NOTES: :[[@LINE-7]]:3: note: Frame #1: function 'boo' calls function 'bar' here: +// CHECK-NOTES: :[[@LINE-14]]:18: note: Frame #2: function 'bar' calls

[PATCH] D74081: [clang][Analysis] CallGraph: store the actual call `Expr*` in the CallGraphNode::CallRecord

lebedev.ri created this revision. lebedev.ri added reviewers: NoQ, erichkeane. lebedev.ri added a project: clang. Herald added a subscriber: Charusso. Storing not just the callee, but the actual call may be interesting for some use-cases. In particular, D72362

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp:21 + +inline bool operator==(const CallGraphNode::CallRecord , + const CallGraphNode::CallRecord ) { NoQ wrote: > lebedev.ri wrote: > >

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri updated this revision to Diff 242713. lebedev.ri marked 11 inline comments as done. lebedev.ri added a comment. @NoQ Thank you for taking a look! Rebased, addressed most of the review notes (some tests could be added), split callgraph changes into a separate review. Repository:

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri updated this revision to Diff 242725. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Fixup disclaimer printing, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72362/new/ https://reviews.llvm.org/D72362

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-no-recursion.cpp:153 +// CHECK-NOTES: :[[@LINE-7]]:3: note: Frame #1: function 'boo' calls function 'bar' here: +// CHECK-NOTES: :[[@LINE-14]]:18: note: Frame #2: function 'bar' calls

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri marked an inline comment as not done. lebedev.ri added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-no-recursion.cpp:153 +// CHECK-NOTES: :[[@LINE-7]]:3: note: Frame #1: function 'boo' calls function 'bar' here: +// CHECK-NOTES:

[PATCH] D74087: [Sema] Fix Sema checkArgCount function

bsaleil created this revision. bsaleil added a reviewer: rsmith. bsaleil added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes the checkArgCount function in Sema that is used to check the number of arguments of a call when doing custom type-checking. The patch fixes

[clang] f40a797 - [clang-format] Do not merge short C# class definitions into one line

Author: Jonathan Coe Date: 2020-02-05T17:38:33Z New Revision: f40a7972cb42e130c6e954f21acf9b66bf5bcad7 URL: https://github.com/llvm/llvm-project/commit/f40a7972cb42e130c6e954f21acf9b66bf5bcad7 DIFF: https://github.com/llvm/llvm-project/commit/f40a7972cb42e130c6e954f21acf9b66bf5bcad7.diff LOG:

[PATCH] D74076: [Clang][Driver] Remove -M group options before generating crash diagnostics

aganea created this revision. aganea added reviewers: hans, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. aganea edited the summary of this revision. When using `-MF file.d` on the command line, `file.d` would not be deleted after a compiler crash. Previously, the

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

Szelethus added a comment. I dont think any of my comments were addressed -- could you follow up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818 ___

[PATCH] D31343: Add an attribute plugin example

sorawee added inline comments. Comment at: clang/test/Frontend/plugin-attribute.cpp:16 +void fn3() { + // BADATTRIBUTE: error: 'example' attribute only allowed at file scop + int var2 __attribute__((example)); Typo: scope Repository: rG LLVM Github

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 242723. lewis-revill added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp

[PATCH] D74043: [clang-format] Do not treat C# attribute targets as labels

MyDeveloperDay added a comment. LGTM, thanks for the patch (I've seen this in the wild where the AssemblyInfo.cs gets a bit messed up. Comment at: clang/lib/Format/FormatTokenLexer.cpp:287 + auto = *(Tokens.end() - 2); + auto = *(Tokens.end() - 1); + +1

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Due to a recent (but retroactive) C++ rule change, only sufficiently C-compatible classes are permitted to be given a typedef name for linkage purposes. Add an

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

xazax.hun added inline comments. Comment at: clang/docs/ReleaseNotes.rst:405 +- New checker: ``fuchsia.HandleChecker`` to detect leaks related to Fuchsia + handles. NoQ wrote: > D74004 > > 1) The checker is now in alpha. > 2) This checker wasn't enabled in

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson added a comment. In D73242#186 , @thakis wrote: > This makes lld crash when linking chromium's base_unittests and probably does > the same for most other binaries that use both thinlto and cfi: >

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, thegameg, rsmith. Herald added subscribers: ributzka, dexonsmith, jkorous. These temporaries are only used in the callee, and their memory can be reused after the call is complete. rdar://58552124

[PATCH] D74003: [analyzer] Prevent assertion failure in PThreadLockChecker when the implementations of the locking functions are available

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4f4a6c0f5bb: [analyzer] Prevent an assertion failure in PThreadLockChecker (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D74003?vs=242447=242778#toc Repository: rG LLVM

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

rsmith added a comment. Have you considered how this would interact with our other language extensions? Can we form a vector of `_ExtInt(N)`? A `_Complex _ExtInt(N)`? I expect for some of that to just fall out of the implementation, but we should have documentation and test coverage either

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

NoQ added inline comments. Comment at: clang/docs/ReleaseNotes.rst:405 +- New checker: ``fuchsia.HandleChecker`` to detect leaks related to Fuchsia + handles. D74004 1) The checker is now in alpha. 2) This checker wasn't enabled in the release either, as far

[PATCH] D74081: [clang][Analysis] CallGraph: store the actual call `Expr*` in the CallGraphNode::CallRecord

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74081/new/ https://reviews.llvm.org/D74081

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

rsmith added a comment. In D68896#1861040 , @rsmith wrote: > In D68896#1778193 , @kianm wrote: > > > Hi, I am still seeing problems with this assertion. Could we please get a > > fix? I've posted the reduced test

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

rsmith added a comment. In D68896#1778193 , @kianm wrote: > Hi, I am still seeing problems with this assertion. Could we please get a > fix? I've posted the reduced test case and reproducible command on this > Phabricator patch. Are you still seeing

[clang] e4f4a6c - [analyzer] Prevent an assertion failure in PThreadLockChecker

Author: Gabor Horvath Date: 2020-02-05T15:56:56-08:00 New Revision: e4f4a6c0f5bbda5dc0b922816b3fdfce4b75f404 URL: https://github.com/llvm/llvm-project/commit/e4f4a6c0f5bbda5dc0b922816b3fdfce4b75f404 DIFF: https://github.com/llvm/llvm-project/commit/e4f4a6c0f5bbda5dc0b922816b3fdfce4b75f404.diff

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

thakis added a comment. This makes lld crash when linking chromium's base_unittests and probably does the same for most other binaries that use both thinlto and cfi: https://bugs.chromium.org/p/chromium/issues/detail?id=1049434 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69868: Allow "callbr" to return non-void values

void updated this revision to Diff 242752. void added a comment. Use iterator for machine operands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 Files: llvm/docs/LangRef.rst

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

rnk added a comment. In D73675#1858688 , @shafik wrote: > I forgot to mention this earlier but LLDB is a major user of the > `ASTImporter` and so in general it is a good idea to run `check-lldb` as well. I ran the LLDB tests on Linux, but I get 42

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

ianlevesque updated this revision to Diff 242800. ianlevesque added a comment. Address code review nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73842/new/ https://reviews.llvm.org/D73842 Files: clang/include/clang/Driver/XRayArgs.h

[PATCH] D74104: Remove test dependency on the presence of an assembler

dyung created this revision. dyung added a reviewer: NoQ. dyung added a project: clang. Herald added a subscriber: Charusso. These tests currently call -c which requires an assembler, and will fail if your target defaults to an external assembler that is not present in the test environment. It

[PATCH] D74004: [analyzer] Move fuchsia.Lock checker to alpha

xazax.hun added a comment. In D74004#1858185 , @NoQ wrote: > Also you'll need to update release notes (D73966 > ) :) I think this was merged after the release branch was created

[clang] 643dee9 - [analyzer] Move fuchsia.Lock checker to alpha

Author: Gabor Horvath Date: 2020-02-05T16:11:06-08:00 New Revision: 643dee903cebdfc5e0101d305add6a5235211465 URL: https://github.com/llvm/llvm-project/commit/643dee903cebdfc5e0101d305add6a5235211465 DIFF: https://github.com/llvm/llvm-project/commit/643dee903cebdfc5e0101d305add6a5235211465.diff

[PATCH] D74009: [clang] Improve diagnostic note for implicit conversions that are disallowed because they involve more than one user-defined conversion.

logan-5 added a comment. In D74009#1858353 , @rsmith wrote: > Have you looked into whether you can defer the check for conversion via > multiple user-defined conversions until we come to call > `CompleteNonViableCandidate` after finding no viable

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

rnk added a comment. Oh, here's the linker it has found: $ find ../clang/ -iname '*lld-link2' ../clang/test/Driver/Inputs/Windows/ARM/8.1/usr/bin/ld.lld-link2 So this is truly a test of the `ld.otherlinker` feature pattern, not some special case driver feature. I guess we should leave the

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

rnk added a comment. I applied this locally, but the test doesn't pass. I can look into it tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763 ___

[PATCH] D74004: [analyzer] Move fuchsia.Lock checker to alpha

This revision was automatically updated to reflect the committed changes. Closed by commit rG643dee903ceb: [analyzer] Move fuchsia.Lock checker to alpha (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D74004?vs=242452=242781#toc Repository: rG LLVM Github Monorepo

[PATCH] D72746: [clangd] Add a flag for spelled references in the Index

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61852 tests passed, 5 failed and 780 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 242809. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address another round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 Files:

[PATCH] D72746: [clangd] Add a flag for spelled references in the Index

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6860c1af457: [clangd] Add a flag for spelled references in the Index (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D72746?vs=242809=242811#toc Repository: rG LLVM Github

[clang-tools-extra] a6860c1 - [clangd] Add a flag for spelled references in the Index

Author: Kirill Bobyrev Date: 2020-02-06T08:18:14+01:00 New Revision: a6860c1af45776e349eaed3e8f0bb7e97abccd89 URL: https://github.com/llvm/llvm-project/commit/a6860c1af45776e349eaed3e8f0bb7e97abccd89 DIFF:

[clang] 6bfc45c - Fix build after D72746

Author: Kirill Bobyrev Date: 2020-02-06T08:55:19+01:00 New Revision: 6bfc45cf60d2a82e659d3911c26169ad02cf78c0 URL: https://github.com/llvm/llvm-project/commit/6bfc45cf60d2a82e659d3911c26169ad02cf78c0 DIFF:

[clang] b198f16 - [Analyzer] Model STL Algoirthms to improve the iterator checkers

Author: Adam Balogh Date: 2020-02-05T17:59:08+01:00 New Revision: b198f16e1e1c8ee849008c1b886199eae5bc2e01 URL: https://github.com/llvm/llvm-project/commit/b198f16e1e1c8ee849008c1b886199eae5bc2e01 DIFF: https://github.com/llvm/llvm-project/commit/b198f16e1e1c8ee849008c1b886199eae5bc2e01.diff

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rGb198f16e1e1c: [Analyzer] Model STL Algoirthms to improve the iterator checkers (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D70818?vs=242607=242647#toc

[PATCH] D74063: [Clang] Remove #pragma clang __debug handle_crash

aganea created this revision. aganea added a reviewer: hans. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. As discussed in D70568 , remove this because it isn't used anywhere, and I think it's better to go

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

This revision was automatically updated to reflect the committed changes. Closed by commit rG748bb5a0f196: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74025 Files:

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. Ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73966: [analyzer][WIP] Add 10.0.0 release notes.

Charusso added inline comments. Comment at: clang/docs/ReleaseNotes.rst:408 + +- New checker: ``alpha.plusplus.PlacementNew`` to detect whether the storage + provided for default placement new is sufficiently large. balazske wrote: > Szelethus wrote: > > NoQ

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet closed this revision. kadircet added a comment. closed by 6e8d6bc9ec8739ec22b73a23f740f171f452e234 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

evgeny777 added inline comments. Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:1678 +// breaks any uses on assumes. +if (TypeIdMap.count(TypeId)) + continue; tejohnson wrote: > evgeny777 wrote: > > tejohnson wrote: > > > evgeny777

[PATCH] D73966: [analyzer][WIP] Add 10.0.0 release notes.

balazske added inline comments. Comment at: clang/docs/ReleaseNotes.rst:408 + +- New checker: ``alpha.plusplus.PlacementNew`` to detect whether the storage + provided for default placement new is sufficiently large. Szelethus wrote: > NoQ wrote: > > I think

[clang-tools-extra] 6e8d6bc - [clangd] Preserve -nostdinc and --sysroot when calling query driver

Author: Kadir Cetinkaya Date: 2020-02-05T09:58:06+01:00 New Revision: 6e8d6bc9ec8739ec22b73a23f740f171f452e234 URL: https://github.com/llvm/llvm-project/commit/6e8d6bc9ec8739ec22b73a23f740f171f452e234 DIFF:

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62441 tests passed, 0 failed and 845 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[clang-tools-extra] ca1c21d - [clangd] Use printf instead of `echo -e` to be compliant with dash

Author: Kadir Cetinkaya Date: 2020-02-05T10:21:32+01:00 New Revision: ca1c21d4b659bfa5edb38c4a54b3050e43c4b51a URL: https://github.com/llvm/llvm-project/commit/ca1c21d4b659bfa5edb38c4a54b3050e43c4b51a DIFF:

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

hokein added a comment. thanks, mostly good. the only concern from my side is about the `SymbolRole::Implicit`, I think we should get rid of it. Comment at: clang-tools-extra/clangd/index/Ref.h:53 + // The reference explicitly spells out declaration's name. Such references

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74028: [clang] Add release notes for the 10.x branch for things I've done

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74028 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

Szelethus added inline comments. Comment at: clang/docs/ReleaseNotes.rst:408 + +- New checker: ``alpha.plusplus.PlacementNew`` to detect whether the storage + provided for default placement new is sufficiently large. Charusso wrote: > balazske wrote: > >

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

Szelethus updated this revision to Diff 242539. Szelethus marked 10 inline comments as done. Szelethus retitled this revision from "[analyzer][WIP] Add 10.0.0 release notes." to "[analyzer] Add 10.0.0 release notes.". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73966/new/

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/SourceCode.cpp:1139 + // Double check that this is an actual protobuf header. + if

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein updated this revision to Diff 242543. hokein added a comment. address a final comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.org/D73780 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D74033: [clang-tidy] Fix PR#44620 'readability-redundant-string-cstr quick-fix causes invalid code'

f00kat created this revision. f00kat added reviewers: aaron.ballman, alexfh. f00kat added projects: clang-tools-extra, clang. Herald added subscribers: cfe-commits, xazax.hun. #include static void f2(std::string&&) { } static void f() { std::string const s;

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[clang-tools-extra] f8865c0 - [clangd] Pull out a isProtoFile function.

Author: Haojian Wu Date: 2020-02-05T12:04:03+01:00 New Revision: f8865c01944fe409857eeb30e0963bfa5ced294d URL: https://github.com/llvm/llvm-project/commit/f8865c01944fe409857eeb30e0963bfa5ced294d DIFF: https://github.com/llvm/llvm-project/commit/f8865c01944fe409857eeb30e0963bfa5ced294d.diff

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8865c01944f: [clangd] Pull out a isProtoFile function. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/

[PATCH] D74036: [clangd] don't rename on protobuf symbols.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[clang] 6198e1c - Fix MSVC signed/unsigned warning. NFCI.

Author: Simon Pilgrim Date: 2020-02-05T11:53:16Z New Revision: 6198e1c40abce7135ce68e2b91d433ec02454a50 URL: https://github.com/llvm/llvm-project/commit/6198e1c40abce7135ce68e2b91d433ec02454a50 DIFF: https://github.com/llvm/llvm-project/commit/6198e1c40abce7135ce68e2b91d433ec02454a50.diff

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein updated this revision to Diff 242536. hokein added a comment. update based on the offline discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.org/D73780 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

Abpostelnicu created this revision. Abpostelnicu added a reviewer: hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. Abpostelnicu edited the summary of this revision. Abpostelnicu edited the summary of this revision. Abpostelnicu added a subscriber: sylvestre.ledru.

[PATCH] D73693: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. if it is trivial, it would be nice to add some unittests in `clang/unittests/AST/DeclPrinterTest.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74036: [clangd] don't rename on protobuf symbols.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74036 Files:

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

This revision was automatically updated to reflect the committed changes. AlexeySotkin marked an inline comment as done. Closed by commit rGf780e15caf1b: [OpenCL] Fix support for cl_khr_mipmap_image_writes (authored by AlexeySotkin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

hans added a comment. lgtm, but if you want it wouldn't hurt to include even more details from the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74031/new/ https://reviews.llvm.org/D74031

[clang-tools-extra] eaf0c89 - [clangd] Add the missing elaborated types in FindTarget.

Author: Haojian Wu Date: 2020-02-05T14:03:36+01:00 New Revision: eaf0c89ec5f866b6cef296c542c030bb2cf8481d URL: https://github.com/llvm/llvm-project/commit/eaf0c89ec5f866b6cef296c542c030bb2cf8481d DIFF: https://github.com/llvm/llvm-project/commit/eaf0c89ec5f866b6cef296c542c030bb2cf8481d.diff

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

Abpostelnicu added a comment. In D74031#1859084 , @hans wrote: > lgtm, but if you want it wouldn't hurt to include even more details from the > commit message. This is a good idea, in my latest patch you will see that I've added more context present

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

Abpostelnicu updated this revision to Diff 242562. Abpostelnicu added a comment. Adding extra comments to the release patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74031/new/ https://reviews.llvm.org/D74031 Files:

[PATCH] D73547: [Analyzer] Split container modeling from iterator modeling

Szelethus added a comment. I'm late to the party, but have looked at the code and I really, really-really like what you did in this patch! It solves one of my biggest complaints about this project. LGTM! Comment at:

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf0c89ec5f8: [clangd] Add the missing elaborated types in FindTarget. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D74025?vs=242524=242566#toc Repository: rG LLVM Github

  1   2   >