[PATCH] D74834: [clangd] Expose the rename LimitFiles option to the C++ API, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG34d0e1bd6d05: [clangd] Expose the rename LimitFiles option to the C++ API, NFC. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D74834?vs=246640=246641#toc Repository: rG

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille abandoned this revision. serge-sans-paille added a comment. Obsoleted by https://reviews.llvm.org/D74878 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/ https://reviews.llvm.org/D74871

[PATCH] D75134: [clang-tidy] Improved renamer check logic

njames93 updated this revision to Diff 246653. njames93 added a comment. - Moved shared code into __init__ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75134/new/ https://reviews.llvm.org/D75134 Files:

[PATCH] D75159: [clang-tidy] Fix PR#37210 'Out-of-class template constructor only half-fixed with modernize-pass-by-value'

f00kat created this revision. f00kat added reviewers: aaron.ballman, alexfh. f00kat added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Existing 'modernize-pass-by-value' check works only with non template values in initializers. Now we also skip cases

[PATCH] D75160: [AArch64][SVE] Add SVE2 intrinsic for xar

kmclaughlin created this revision. kmclaughlin added reviewers: andwar, c-rhodes, dancgr, efriedma. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the @llvm.aarch64.sve.xar intrinsic

[PATCH] D75019: Strip preceeding -Xclang when stripping -fcolor-diagnostics or -fdiagnostics-color

This revision was automatically updated to reflect the committed changes. Closed by commit rGda236f235028: Strip preceeding -Xclang when stripping -fcolor-diagnostics or -fdiagnostics… (authored by kadircet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[clang-tools-extra] 34d0e1b - [clangd] Expose the rename LimitFiles option to the C++ API, NFC.

Author: Haojian Wu Date: 2020-02-26T09:33:58+01:00 New Revision: 34d0e1bd6d05ee11f638ca085f4755e75e18adfc URL: https://github.com/llvm/llvm-project/commit/34d0e1bd6d05ee11f638ca085f4755e75e18adfc DIFF: https://github.com/llvm/llvm-project/commit/34d0e1bd6d05ee11f638ca085f4755e75e18adfc.diff

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

hans added a comment. Thanks for writing notes! Go ahead and push directly to the branch when you're ready. Comment at: clang/docs/ReleaseNotes.rst:288 +OpenCL Kernel Language Changes in Clang -- For the formatting to work,

[PATCH] D74962: [clang][Tooling] Add a way to tokenize a FileRange

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:335 clang::Token T; - while (!L.LexFromRawLexer(T)) + while (!L.LexFromRawLexer(T) && L.getCurrentBufferOffset() < FR.endOffset()) AddToken(T);

[PATCH] D74962: [clang][Tooling] Add a way to tokenize a FileRange

kadircet updated this revision to Diff 246646. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74962/new/ https://reviews.llvm.org/D74962 Files: clang/include/clang/Tooling/Syntax/Tokens.h

[PATCH] D75134: [clang-tidy] Improved renamer check logic

njames93 updated this revision to Diff 246650. njames93 added a comment. - Changed naming to what appears to be llvm python style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75134/new/ https://reviews.llvm.org/D75134 Files:

[clang] da236f2 - Strip preceeding -Xclang when stripping -fcolor-diagnostics or -fdiagnostics-color

Author: Kadir Cetinkaya Date: 2020-02-26T09:05:05+01:00 New Revision: da236f235028c82c2f0e00eea1f6f9c689bcae4a URL: https://github.com/llvm/llvm-project/commit/da236f235028c82c2f0e00eea1f6f9c689bcae4a DIFF:

[PATCH] D74834: [clangd] Expose the rename LimitFiles option to the C++ API, NFC.

hokein updated this revision to Diff 246640. hokein added a comment. keep the old clangdServer::rename around temporarily to make internal integration life easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74834/new/

[clang] e058667 - Support -fuse-ld=lld for riscv

Author: serge-sans-paille Date: 2020-02-26T10:20:20+01:00 New Revision: e058667a2e017d3225a9bb067dbac7f2159576f7 URL: https://github.com/llvm/llvm-project/commit/e058667a2e017d3225a9bb067dbac7f2159576f7 DIFF:

[clang] 19c664f - Fix typo in clang lit config

Author: serge-sans-paille Date: 2020-02-26T10:37:04+01:00 New Revision: 19c664f71e887111298e49e416511f8be7b2b15f URL: https://github.com/llvm/llvm-project/commit/19c664f71e887111298e49e416511f8be7b2b15f DIFF:

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

hokein added inline comments. Comment at: clang/include/clang/AST/DependencyFlags.h:57 + struct NAME##Scope { \ +enum NAME { \ + UnexpandedPack = 1,

[clang-tools-extra] 4feca71 - Fix the clangd-fuzzer build error.

Author: Haojian Wu Date: 2020-02-26T10:13:13+01:00 New Revision: 4feca71df0ca96237342d0e3ef41e3cdbfa0e27c URL: https://github.com/llvm/llvm-project/commit/4feca71df0ca96237342d0e3ef41e3cdbfa0e27c DIFF: https://github.com/llvm/llvm-project/commit/4feca71df0ca96237342d0e3ef41e3cdbfa0e27c.diff

[PATCH] D74704: Support -fuse-ld=lld for riscv

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe058667a2e01: Support -fuse-ld=lld for riscv (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo

[PATCH] D75158: [analyzer][StreamChecker] Using function description objects - NFC.

Szelethus accepted this revision. Szelethus added reviewers: baloghadamsoftware, NoQ, martong, Charusso, xazax.hun. Szelethus added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Cool! Though this patch says little without followups, so maybe we

[PATCH] D75048: [ASTImporter] Improved import of AlignedAttr.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7944 + if (auto ToEOrErr = Import(From->getAlignmentExpr())) +To = AlignedAttr::Create(ToContext, true, *ToEOrErr, ToRange, +

[PATCH] D75158: [analyzer][StreamChecker] Using function description objects - NFC.

balazske created this revision. Herald added subscribers: cfe-commits, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Have a description object for

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

hans added a comment. Thanks! Cherry-picked to 10.x as 6f4f4f2c8ce1ad17bdec9fe2071d3fe439eca9eb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske added a comment. Code is not reformatted and tests are to be added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75163/new/ https://reviews.llvm.org/D75163 ___ cfe-commits mailing list

[PATCH] D74962: [clang][Tooling] Add a way to tokenize a FileRange

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c2cf499e611: [clang][Tooling] Add a way to tokenize a FileRange (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74962/new/

[clang] 6e34a9a - [OpenMP] Fix the test by generating output file in temporary directory

Author: Kirill Bobyrev Date: 2020-02-26T14:07:13+01:00 New Revision: 6e34a9a838c150b968b05b76d545969d1ddeee90 URL: https://github.com/llvm/llvm-project/commit/6e34a9a838c150b968b05b76d545969d1ddeee90 DIFF:

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

kmclaughlin added a comment. Thanks for reviewing this, @sdesmalen & @efriedma! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74912/new/ https://reviews.llvm.org/D74912 ___ cfe-commits mailing list

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:293 +- Allowed ``__private`` to be printed explicitly in diagnostics, AST, etc +- Fixed declaration of ``enqueue_marker``, c11 atomic fetch max/min in the + standard header. Suggesting to

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c859fc54d92: [AArch64][SVE] Add SVE2 intrinsics for bit permutation table lookup (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D74912?vs=246487=246661#toc Repository:

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske created this revision. Herald added subscribers: cfe-commits, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. The validity checks are

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

Szelethus added a comment. Aha, so we're moving every check as to whether the stream is closed to `preCall`? Makes sense, if not much else changed. Could you please run `clang-format-diff.py` after adding the tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

RobRich999 added a comment. I too can see how SMT might not afford much performance difference for LTO codegen. CMT appears to be more significant. I do not have exact numbers right now as my build box is busy, but the change added like an hour to locally building the Chromium browser with

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

mehdi_amini added a comment. There is something puzzling to me in this patch in the way the ThreadPool was modified: the client of the thread pool cannot request a number of threads anymore, but only a *maximum* number of threads. I don't really understand why? Using the OS reported

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

aganea added a comment. @thakis I think this is a side-effect of implementing `computeHostNumPhysicalCores()` for Windows, which previously returned -1, which in turn made `llvm::heavyweight_hardware_concurrency()` previously behave like `llvm::hardware_concurrency()` (on Windows only). At

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

pratlucas created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Half-precision floating point arguments and returns are currently promoted to either float or int32 in clang's CodeGen. As such promotions are implemented as coercion through

[PATCH] D75166: [clangd] Clean-up locateSymbolAt

kadircet updated this revision to Diff 246682. kadircet added a comment. Add more cleaning. getDeclAtPosition builds a SelectionTree underneath and it only operates on spelling locations inside main file. So it is invalid to pass any expansion locations to it. There is no need to call

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

RKSimon created this revision. RKSimon added reviewers: craig.topper, spatel. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. This removes everything but int_x86_avx512_mask_vcvtph2ps_512 which provides the SAE variant, but even this can use the fpext

[PATCH] D75166: [clangd] Clean-up locateSymbolAt

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Get rid of calls to lexer and unnecessary source location transformations. Repository: rG LLVM

[clang-tools-extra] 5560a78 - [clangd] Bump index version number.

Author: Haojian Wu Date: 2020-02-26T13:43:16+01:00 New Revision: 5560a78820ee7cecd1ad14f5a96889459dd36766 URL: https://github.com/llvm/llvm-project/commit/5560a78820ee7cecd1ad14f5a96889459dd36766 DIFF: https://github.com/llvm/llvm-project/commit/5560a78820ee7cecd1ad14f5a96889459dd36766.diff

[clang] 8c2cf49 - [clang][Tooling] Add a way to tokenize a FileRange

Author: Kadir Cetinkaya Date: 2020-02-26T13:50:41+01:00 New Revision: 8c2cf499e6119be8f3f1a0d42c4bb7e45b0d615d URL: https://github.com/llvm/llvm-project/commit/8c2cf499e6119be8f3f1a0d42c4bb7e45b0d615d DIFF:

[clang] 546918c - Revert "[compiler-rt] Add a critical section when flushing gcov counters"

Author: Hans Wennborg Date: 2020-02-26T13:27:44+01:00 New Revision: 546918cbb4b2231c65cf91fceb738a59d03af7bf URL: https://github.com/llvm/llvm-project/commit/546918cbb4b2231c65cf91fceb738a59d03af7bf DIFF: https://github.com/llvm/llvm-project/commit/546918cbb4b2231c65cf91fceb738a59d03af7bf.diff

[PATCH] D74127: [clangd] Bump index version number.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5560a78820ee: [clangd] Bump index version number. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74127/new/

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske updated this revision to Diff 246687. balazske added a comment. Reformat code and fixed errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75163/new/ https://reviews.llvm.org/D75163 Files:

[PATCH] D75165: [ARM,MVE] Add predicated intrinsics for many unary functions.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75165/new/ https://reviews.llvm.org/D75165

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: martong, steakhal, Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. Iterator checkers (and

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

mitchell-stellar accepted this revision. mitchell-stellar added a comment. Assuming this passes all existing tests, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 ___ cfe-commits mailing list

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

ymandel updated this revision to Diff 246706. ymandel added a comment. Fix failing test under msvc compatibility. Adds -fno-delayed-template-parsing to compilation arguments in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72153/new/

[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:329 // CHECK-NOTES: [[@LINE-3]]:7: note: move occurred here + // CHECK-NOTES: [[@LINE-6]]:7: note: std::move of the const expression {{.*}} };

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

ymandel reopened this revision. ymandel added a comment. This revision is now accepted and ready to land. Reopening for fix to failing tests that resulted in revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72153/new/

[clang-tools-extra] 02323a3 - [clangd] use printQualifiedName to skip the inlinenamespace qualifiers.

Author: Haojian Wu Date: 2020-02-26T16:22:45+01:00 New Revision: 02323a3d5f9ea676865f78d603e68fa4b4b62608 URL: https://github.com/llvm/llvm-project/commit/02323a3d5f9ea676865f78d603e68fa4b4b62608 DIFF: https://github.com/llvm/llvm-project/commit/02323a3d5f9ea676865f78d603e68fa4b4b62608.diff

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

cameron.mcinally accepted this revision. cameron.mcinally added a comment. This revision is now accepted and ready to land. LGTM, with the TODO to be handled under a separate patch. Thank you for taking care of this, Simon. Comment at:

[PATCH] D75174: [clangd] use printQualifiedName to skip the inlinenamespace qualifiers.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. symbols in libcpp are inside the inline namespace, printQualifierAsString will print the inline namespace, which is

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

kadircet updated this revision to Diff 246701. kadircet added a comment. - Handle llvm::Expected failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166 Files: clang-tools-extra/clangd/XRefs.cpp Index:

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn marked 2 inline comments as done. john.brawn added inline comments. Comment at: clang/lib/Sema/ParsedAttr.cpp:144 + // otherwise return a default ParsedAttrInfo. + if (A.getKind() < sizeof(AttrInfoMap)/sizeof(AttrInfoMap[0])) +return *AttrInfoMap[A.getKind()];

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rG38b4516de8a4: [libTooling] Add function to determine associated text of a declaration. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 41a6612 - Put microsoft template parameter shadow warning behind separate flag (PR44794)

Author: Hans Wennborg Date: 2020-02-26T16:04:40+01:00 New Revision: 41a6612ea8afc5254e4de3aca55628d37f0be433 URL: https://github.com/llvm/llvm-project/commit/41a6612ea8afc5254e4de3aca55628d37f0be433 DIFF: https://github.com/llvm/llvm-project/commit/41a6612ea8afc5254e4de3aca55628d37f0be433.diff

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

christophe-calmejane added a comment. In D44609#1875172 , @Wawha wrote: > In D44609#1871612 , @MyDeveloperDay > wrote: > > > Correct follow that description on how to request commit access > > > It's done. I have

[PATCH] D75174: [clangd] use printQualifiedName to skip the inlinenamespace qualifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG02323a3d5f9e: [clangd] use printQualifiedName to skip the inlinenamespace qualifiers. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D75174?vs=246699=246720#toc Repository:

[PATCH] D75129: [clang-format] Special handling of spaces for C# code

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8c5fea243ce: [clang-format] Special handling of spaces for C# code (authored by Jonathan Coe jb...@google.com). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske added a comment. Plan: - Add an error state to `StreamState`. - Model every stream function that can fail. Split the state into failed and non-failed and set the return value accordingly (as done at //fopen// now, but not only for stream return values). This is needed here to have a

[PATCH] D75166: [clangd] Clean-up locateSymbolAt

kadircet updated this revision to Diff 246690. kadircet added a comment. - Also clean usage in getSymbolInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

mitchell-stellar added a subscriber: mxbOctasic. mitchell-stellar added a comment. Digging through the history, it seems this behavior was explicitly desired: https://reviews.llvm.org/D19028. @mxbOctasic was the original author and perhaps could comment. Regardless, I think there should be a

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

danielkiss updated this revision to Diff 246685. danielkiss added a reviewer: olista01. danielkiss added a comment. rebased and test is updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 Files: clang/lib/CodeGen/TargetInfo.cpp

[clang] 319ea2d - [OpenCL] Add atomic type builtins

Author: Sven van Haastregt Date: 2020-02-26T14:08:23Z New Revision: 319ea2dd9e32cd10415e1f5060e84febf7c606c6 URL: https://github.com/llvm/llvm-project/commit/319ea2dd9e32cd10415e1f5060e84febf7c606c6 DIFF: https://github.com/llvm/llvm-project/commit/319ea2dd9e32cd10415e1f5060e84febf7c606c6.diff

[clang] 38b4516 - [libTooling] Add function to determine associated text of a declaration.

Author: Yitzhak Mandelbaum Date: 2020-02-26T09:56:48-05:00 New Revision: 38b4516de8a4a791d17085d37f95e3cc15c359f9 URL: https://github.com/llvm/llvm-project/commit/38b4516de8a4a791d17085d37f95e3cc15c359f9 DIFF:

[PATCH] D75121: Put microsoft template parameter shadow warning behind separate flag (PR44794)

hans added a comment. In D75121#1891879 , @rnk wrote: > code lgtm > > Should we have a standalone test for this? Something that compiles with > `clang -cc1 -Wno-microsoft -Wmicrosoft-template-shadow` and looks for the > shadowing warnings? Adding one

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske updated this revision to Diff 246711. balazske added a comment. Really reformat, bugfixes, and updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75163/new/ https://reviews.llvm.org/D75163 Files:

[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

sammccall added a comment. Hooray! Comment at: clang-tools-extra/clangd/Hover.cpp:537 + // We prefer the identifiers if any, otherwise make use of the first token. + SourceLocation SourceLocationBeg = TokensAroundCursor.front().location(); first -> last I

[PATCH] D75121: Put microsoft template parameter shadow warning behind separate flag (PR44794)

This revision was automatically updated to reflect the committed changes. Closed by commit rG41a6612ea8af: Put microsoft template parameter shadow warning behind separate flag (PR44794) (authored by hans). Herald added a project: clang. Changed prior to commit:

[clang] e8c5fea - [clang-format] Special handling of spaces for C# code

Author: Jonathan Coe Date: 2020-02-26T15:27:03Z New Revision: e8c5fea243ce30640ec9707fabdb635a49b3153c URL: https://github.com/llvm/llvm-project/commit/e8c5fea243ce30640ec9707fabdb635a49b3153c DIFF: https://github.com/llvm/llvm-project/commit/e8c5fea243ce30640ec9707fabdb635a49b3153c.diff LOG:

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

jdoerfert created this revision. jdoerfert added reviewers: erichkeane, aaron.ballman, rjmccall, john.brawn. Herald added a subscriber: bollu. Herald added a project: clang. ParsedAttr is used for `clang attribute push/pop` a utility that is reusable in other contexts as well. This allows us to

[PATCH] D75056: [Driver] Default to -fno-common for all targets

jyknight added a comment. Are there any tests remaining that check that with -fcommon, IR generation creates "common" variables, now that all these tests have been modified? If there are not, one should be added. Comment at: clang/docs/ClangCommandLineReference.rst:1311

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 246826. hliao added a comment. Rebase to the latest trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

jdoerfert marked an inline comment as done. jdoerfert added a comment. In D75210#1894370 , @erichkeane wrote: > I don't see anything glaring here, but I would love some better explanation > as to the goal here. I don't see this used anywhere, the commit

[PATCH] D75056: [Driver] Default to -fno-common for all targets

hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:87 +- -fno-common has been enabled as the default for all targets. jyknight wrote: > Might be nice to expand upon this somewhat, to give users a clue what it > means to

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. Unsure if my reply was sent over email so copying it here. Yup, adding `// REQUIRES: platform-linker` to both `*-extra.c` files seems to fix it. Thanks. Will you be sending out the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions.

ABataev created this revision. ABataev added reviewers: tra, hfinkel. Herald added a subscriber: guansong. Herald added a project: clang. Inherited support for complex math functions from CUDA implementation. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75209 Files:

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl added a comment. Also, we cannot remove traversing of RecordDecl and CapturedDecl encountered in function body since we have OpenMP test like this: int main() { #pragma omp target { t1(0); } return 0; } This results in a kernel function embedded in a captured

[PATCH] D75056: [Driver] Default to -fno-common for all targets

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Hope @tstellar and @jyknight can confirm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. Submitted fixes in d2cbaf1755ffa90300365c0d71400a5ee4ada3bd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/test/OpenMP/target_update_codegen.cpp:371-372 + // CK6-DAG: store i32* [[ADD_PTR:%.+]], i32** [[PC0]] + // CK6-DAG: [[ADD_PTR]] = getelementptr inbounds i32, i32* [[ONE:%.+]], i{{32|64}} [[IDX_EXT:%.+]] + // CK6-DAG:

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/ https://reviews.llvm.org/D74941

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson added a comment. Sent fix for review in D75201 . If the new problem showed up later and not when this one first went in, then it seems likely it is different than this issue. I'll see if I can reproduce and take a look. Repository: rG LLVM Github

[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Did you want to delete the lexer check in getDeducedType or is that another patch? Comment at: clang-tools-extra/clangd/Hover.cpp:533 + } + auto TokensAroundCursor

[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes hasName AST matcher is confused by extern "C" in namespace. Repository: rG

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

erichkeane added a comment. I don't see anything glaring here, but I would love some better explanation as to the goal here. I don't see this used anywhere, the commit message is a bit underwhelming in its reasoning, and there is no test/etc showing why I would want this.

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Wawha added a comment. In D44609#1893390 , @christophe-calmejane wrote: > Nice to finally see this patch integrated! > > But, it looks like you didn't include all the test case I posted 1.5y ago in > this post, that are still problematic and not

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9965 "memory order clause '%0' is specified here">; +def err_omp_non_lvalue_in_map_or_motion_clauses: Error< + "expected lvalue with no function

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

On Wed, Feb 26, 2020 at 08:08:49PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Unsure if my reply was sent over email so copying it here. > > Yup, adding `// REQUIRES: platform-linker` to both `*-extra.c` files seems to > fix it. Thanks. Will you be sending out

[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:518 +// Linkage Spec can just be ignored +// FIXME: Any other DeclContext kinds that

[clang] 7848a3c - Update the ARC docs for non-trivial ownership in structs.

Author: John McCall Date: 2020-02-26T16:42:08-05:00 New Revision: 7848a3c8ab54570f5875e63606ff75b5736750b4 URL: https://github.com/llvm/llvm-project/commit/7848a3c8ab54570f5875e63606ff75b5736750b4 DIFF: https://github.com/llvm/llvm-project/commit/7848a3c8ab54570f5875e63606ff75b5736750b4.diff

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang created this revision. akhuang added reviewers: rnk, asmith. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This change checks for the return type in the frontend and adds a flag to the DISubroutineType to indicate that the option

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao added a comment. @rjmccall @rsmith @tra, could you review on this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 ___ cfe-commits mailing list

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 > > might've broken our toolchain again: s***t. Can

[clang] ca50f09 - [clang] fix error detection in consteval calls

Author: Tyker Date: 2020-02-26T21:09:31+01:00 New Revision: ca50f09db9f86eb5ac7aa0cb53c52637f2b7effa URL: https://github.com/llvm/llvm-project/commit/ca50f09db9f86eb5ac7aa0cb53c52637f2b7effa DIFF: https://github.com/llvm/llvm-project/commit/ca50f09db9f86eb5ac7aa0cb53c52637f2b7effa.diff LOG:

[PATCH] D74418: [clang] fix error detection in consteval calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGca50f09db9f8: [clang] fix error detection in consteval calls (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] d2cbaf1 - Fix for the test failues introduced in https://reviews.llvm.org/D74704.

Author: Leonard Chan Date: 2020-02-26T12:23:15-08:00 New Revision: d2cbaf1755ffa90300365c0d71400a5ee4ada3bd URL: https://github.com/llvm/llvm-project/commit/d2cbaf1755ffa90300365c0d71400a5ee4ada3bd DIFF: https://github.com/llvm/llvm-project/commit/d2cbaf1755ffa90300365c0d71400a5ee4ada3bd.diff

Re: r355698 - Re-fix _lrotl/_lrotr to always take Long, no matter the platform.

I believe this commit is wrong. These intrinsics were originally implemented to support Windows code which expects _lrot{l,r}'s first argument to be 32 bits, it's a breaking change to change these definitions. I'm fine with adding the Intel version of these intrinsics, but you can't just break the

[PATCH] D75198: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75198/new/ https://reviews.llvm.org/D75198 ___

[PATCH] D75198: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.

epastor created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. epastor added a child revision: D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM.. ParsingInlineAsm was a misleading name. These values are

  1   2   >