[PATCH] D76587: [BPF] support 128bit int explicitly in layout spec

yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. Currently, bpf does not specify 128bit alignment in its layout spec. So for a structure like struct ipv6_key_t

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

jdoerfert added a comment. Did you add the warning @lebedev.ri mentioned? (@lebedev.ri I assume/hope a warning is sufficient here?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun,

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

baloghadamsoftware added a comment. Supersedes D62688 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76590/new/ https://reviews.llvm.org/D76590 ___ cfe-commits

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:359 State = State->BindExpr(CE, LCtx, RetVal); } Maybe I should move these lines into a

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check

vingeldal added a comment. In D69560#1935071 , @whisperity wrote: > @aaron.ballman I've gone over LLVM (and a few other projects). Some general > observations: > > - Length of `2` **is vile**. I understand that the C++CG rule says even > lengths of 2

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

baloghadamsoftware abandoned this revision. baloghadamsoftware added a comment. Herald added subscribers: ASDenysPetrov, martong, steakhal. Superseded by D76590 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62688/new/

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

lebedev.ri added a comment. In D75591#1936116 , @jdoerfert wrote: > Did you add the warning @lebedev.ri mentioned? (@lebedev.ri I assume/hope a > warning is sufficient here?) It should be handled consistently with how other newer openmp features are

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko updated this revision to Diff 251968. hlopko added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files: clang/include/clang/Tooling/Syntax/Tree.h

[PATCH] D76595: [clangd-vscode] NFC; Improve wording in documentation and update VSCode tasks

hokein added a comment. thanks. regarding files in `.vscode`, I think they are just local configs in VSCode, we can probably remove the whole directory from git since we already ignore them in the `llvm/.gitignore`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

Szelethus updated this revision to Diff 251973. Szelethus added a comment. Unbreak clang-tidy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76509/new/ https://reviews.llvm.org/D76509 Files: clang/include/clang/StaticAnalyzer/Core/Analyses.def

[PATCH] D76541: [clang-tidy][NFC] Add missing check group docs and order entries

whisperity added a comment. In D76541#1935163 , @njames93 wrote: > Forgive me if I'm wrong, but these kinds of changes typically don't require a > review. Ah, pardon me. This is the first time I'm touching the insides of Tidy. Repository: rG LLVM

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

jbcoe added a comment. That's right David, this typo was fixed in a reverted and re-applied commit: https://reviews.llvm.org/D75856, https://reviews.llvm.org/D75747 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75747/new/

[PATCH] D76541: [clang-tidy][NFC] Add missing check group docs and order entries

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf5fa4873976: [clang-tidy][NFC] Add missing check group docs and order entries (authored by whisperity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

whisperity added a comment. In D76545#1935603 , @aaron.ballman wrote: > I think we want to keep the experimental checks grouped to their parent > module rather than being in a module of their own. For this, wouldn't the fact that telling Tidy to

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:173 +private: + // Keys are either Stmt* or Decl*. + llvm::DenseMap Nodes; The comment is not needed anymore. Comment at:

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

gribozavr2 closed this revision. gribozavr2 added a comment. Superseded by https://reviews.llvm.org/D76355. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72446/new/ https://reviews.llvm.org/D72446 ___

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

grandinj added a comment. Libreoffice has a similar clang-tidy-style cast-checker here: https://cgit.freedesktop.org/libreoffice/core/tree/compilerplugins/clang/cstylecast.cxx https://cgit.freedesktop.org/libreoffice/core/tree/compilerplugins/clang/test/cstylecast.cxx Repository: rG LLVM

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

hokein updated this revision to Diff 251966. hokein marked 7 inline comments as done. hokein added a comment. address some comments, add missing tree-transform testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69330/new/

[PATCH] D76595: [clangd-vscode] NFC; Improve wording in documentation and update VSCode tasks

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. VSCode tasks are updated to the latest supported versions: deprecated values are removed and

[PATCH] D76594: [clang][AST] User relative offsets inside AST file

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: rsmith, dexonsmith. DmitryPolukhin added a project: clang. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. Clang uses 32-bit integers for storing bit offsets from the beginning of the file that results in 512M

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

jhenderson added a comment. @Quuxplusone - did you see that there are several clang-format warnings reported against these changes? Please could you fix them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76572/new/

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

hokein added inline comments. Comment at: clang/include/clang/AST/Expr.h:5920 +/// +/// RecoveryExpr is type-, value- and instantiation-dependent to take advantage +/// of existing machinery to deal with dependent code in C++, e.g. RecoveryExpr sammccall wrote:

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

pratlucas added a comment. Hi @leonardchan , I've double-checked the Neon intrinsics reference and it indeed confirms that the only allowed value for the lane argument for `vdupq_lane_f64` is `0`: Argument Preparation vec → Vn.1D 0 << lane << 0

Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

Hi! On Mon, 2020-03-23 at 08:56 +0100, Djordje wrote: > (+ CCing some debug info folks as well) > > Hi David, > > OK, I agree, my apologize. > > The patch enables the whole feature by default and removes the experimental > option that has been used during the implementation. > We tested the

[PATCH] D76592: [Parser] Fix the assertion crash in ActOnStartOfSwitch stmt.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. After we parse the switch condition, we don't do the type check for type-dependent expr (e.g. TypoExpr) (in Sema::CheckSwitchCondition),

[PATCH] D76295: [clang][AST] Use 64 bit integers for bit offsets inside AST file

DmitryPolukhin abandoned this revision. DmitryPolukhin added a comment. Relative 32-bit offsets in https://reviews.llvm.org/D76594 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76295/new/ https://reviews.llvm.org/D76295

[clang-tools-extra] df5fa48 - [clang-tidy][NFC] Add missing check group docs and order entries

Author: Whisperity Date: 2020-03-23T11:05:34+01:00 New Revision: df5fa48739769d6876a56ca35eb350652130f0fc URL: https://github.com/llvm/llvm-project/commit/df5fa48739769d6876a56ca35eb350652130f0fc DIFF: https://github.com/llvm/llvm-project/commit/df5fa48739769d6876a56ca35eb350652130f0fc.diff

[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

owenpan added a comment. The culprit is `AnnotatingParser::parseAngle()` in clang/lib/Format/TokenAnnotator.cpp. This commit merely uncovered it. :) Upon reading a `<` token, `parseAngle()` tries to scan the rest of the line to find a matching `>`. If found, it's given the type

[PATCH] D75109: Apply function attributes through array declarators

This revision was automatically updated to reflect the committed changes. Closed by commit rG6081ccf4a3b6: Apply function attributes through array declarators (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

Yes, it does. isIntegerConstantExpr assigns a value to CoprocNoAP. -- Regards, Mikhail Maltsev From: David Blaikie Sent: Sunday, March 22, 2020 03:32 To: Mikhail Maltsev; Mikhail Maltsev Cc: cfe-commits Subject: Re: [clang] 43606ef - Suppress an

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:570 + auto *N = new (allocator()) syntax::SimpleDeclarator; + Builder.foldNode(Builder.getRange(R.getBegin(), R.getEnd()), N, D); + Builder.markChild(N,

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko updated this revision to Diff 251993. hlopko marked 6 inline comments as done. hlopko added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files:

[PATCH] D76549: [clang-tidy] Fix RenamerClangTidy handling qualified TypeLocs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76549/new/ https://reviews.llvm.org/D76549

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check

aaron.ballman added a comment. In D69560#1936153 , @vingeldal wrote: > In D69560#1935071 , @whisperity > wrote: > > > @aaron.ballman I've gone over LLVM (and a few other projects). Some general > > observations:

[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

aaron.ballman added a comment. In D76545#1936389 , @whisperity wrote: > In D76545#1935603 , @aaron.ballman > wrote: > > > I think we want to keep the experimental checks grouped to their parent > > module rather

[PATCH] D70411: [analyzer] CERT: STR31-C

Szelethus added inline comments. Comment at: clang/docs/analyzer/checkers.rst:1935 + +alpha.security.cert.str.31c +""" balazske wrote: > There are already more checkers that can check for CERT related problems but > not specially made

[clang] 6081ccf - Apply function attributes through array declarators

Author: Momchil Velikov Date: 2020-03-23T11:03:13Z New Revision: 6081ccf4a3b6289717c8ae558ac210c36ddcbfbe URL: https://github.com/llvm/llvm-project/commit/6081ccf4a3b6289717c8ae558ac210c36ddcbfbe DIFF: https://github.com/llvm/llvm-project/commit/6081ccf4a3b6289717c8ae558ac210c36ddcbfbe.diff

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

andwar added a comment. Thanks for the updates @kmclaughlin ! Would you mind adding a comment to clearly mark the negative tests? E.g. for `@reinterpret_reductions_1`? Maybe also a comment `why` a particular case is not optimised? You've already done that for some tests, but not all of them.

[clang] fa0320d - Add ParsedAttrInfo::handleDeclAttribute

Author: John Brawn Date: 2020-03-23T13:23:11Z New Revision: fa0320dd8d5aa6ea920ac78224d5044398ba50b4 URL: https://github.com/llvm/llvm-project/commit/fa0320dd8d5aa6ea920ac78224d5044398ba50b4 DIFF: https://github.com/llvm/llvm-project/commit/fa0320dd8d5aa6ea920ac78224d5044398ba50b4.diff LOG:

[PATCH] D76599: Represent FP options in AST by special Statement node

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, andrew.w.kaylor, efriedma, mibintc, kpn, sammccall, hokein. Herald added subscribers: martong, arphaman. Herald added a project: clang. Now FPOption object is stored in the bits of Stmt class. The space there is

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. Ping. I find it a bit uncool to revert commits and then be away for a month. I guess it's my fault for not making the patch perfect in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/

[PATCH] D70411: [analyzer] CERT: STR31-C

balazske added inline comments. Comment at: clang/docs/analyzer/checkers.rst:1935 + +alpha.security.cert.str.31c +""" There are already more checkers that can check for CERT related problems but not specially made for these. These

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Sun, Mar 22, 2020 at 3:31 PM David Blaikie wrote: > > On Sun, Mar 22, 2020 at 9:34 AM Aaron Ballman wrote: >> >> On Sun, Mar 22, 2020 at 12:19 PM David Blaikie wrote: >> > >> > On Sun, Mar 22, 2020 at 6:34 AM Aaron Ballman >> > wrote: >> >> >> >> On Sat, Mar 21, 2020 at 11:31 PM David

[PATCH] D76597: [clang-format] Reflow long C# generic type constraints correctly

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Awesome! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76597/new/ https://reviews.llvm.org/D76597

[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

whisperity added a comment. @aaron.ballman @njames93 Should I write up a pitch mail to cfe-dev about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76545/new/ https://reviews.llvm.org/D76545 ___

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon updated this revision to Diff 251982. Fznamznon edited the summary of this revision. Fznamznon added a comment. Fix the test by adding the target with __float128 support and make sure that no diagnostic are emitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76597: [clang-format] Reflow long C# generic type constraints correctly

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Align sequential generic type constraints on a type. Indent sequential generic type constraints on different types as

Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

(+ CCing some debug info folks as well) Hi David, OK, I agree, my apologize. The patch enables the whole feature by default and removes the experimental option that has been used during the implementation. We tested the code (and the assertions regarding the feature itself) by using the

[PATCH] D76551: [Alignment][NFC] Use TargetFrameLowering::getStackAlign()

gchatelet updated this revision to Diff 251969. gchatelet marked 3 inline comments as done. gchatelet added a comment. Herald added subscribers: libc-commits, openmp-commits, libcxx-commits, cfe-commits, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg,

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

Apologies for the confusion. I wrote the commit message after looking into this and I though the issue was related to the capture by copy in the inner llvm::any_of and the reuse in the outer. Looking back at the code I cannot say anymore how I got that impression. If you think the reference is

[PATCH] D76551: [Alignment][NFC] Use TargetFrameLowering::getStackAlign()

gchatelet updated this revision to Diff 251971. gchatelet added a comment. Herald added a reviewer: jdoerfert. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76551/new/ https://reviews.llvm.org/D76551 Files:

Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

Hi David, Thanks for the heads-up! On 23.3.20. 11:02, David Stenberg wrote: > Hi! > > On Mon, 2020-03-23 at 08:56 +0100, Djordje wrote: >> (+ CCing some debug info folks as well) >> >> Hi David, >> >> OK, I agree, my apologize. >> >> The patch enables the whole feature by default and removes the

[PATCH] D76054: [clang-apply-replacements] No longer deduplucates replacements from the same TU

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks for the example and, generally, explanation. Just a few small comments. Comment at:

[PATCH] D76606: [clang-tidy] Warn on invalid "case" configurations for readability-identifier-naming

njames93 added a comment. I'm not too sure how many other checks are like this, but I feel that this functionality could maybe be brought out of this check and into the Options to let more checks that take enum like configurations to use it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D76604: [Analyzer] Model `size()` member function of containers

baloghadamsoftware added a comment. Supersedes D62724 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76604/new/ https://reviews.llvm.org/D76604 ___ cfe-commits

[PATCH] D76054: [clang-apply-replacements] No longer deduplucates replacements from the same TU

njames93 updated this revision to Diff 252017. njames93 marked 5 inline comments as done. njames93 added a comment. - Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76054/new/ https://reviews.llvm.org/D76054 Files:

[PATCH] D76605: [analyzer] Display the checker name in the text output

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp:98 const PathDiagnostic *PD = *I; + std::string WarningMsg = + (ShouldDisplayCheckerName ? " [" + PD->getCheckerName() + "]" : "") `StringRef`?

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1934785 , @rjmccall wrote: > Let's make this patch be purely a representation change. I wouldn't expect > *any* test changes from that; if there are, we should understand why. You > can then add the stuff about

[clang] 5e1a026 - [clang-format] Do not indent C# array initialisers as continuations

Author: Jonathan Coe Date: 2020-03-23T14:33:10Z New Revision: 5e1a026c2d81e83e2b88cc6b6f27fbefbfe0de16 URL: https://github.com/llvm/llvm-project/commit/5e1a026c2d81e83e2b88cc6b6f27fbefbfe0de16 DIFF: https://github.com/llvm/llvm-project/commit/5e1a026c2d81e83e2b88cc6b6f27fbefbfe0de16.diff LOG:

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus marked 3 inline comments as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp:98 const PathDiagnostic *PD = *I; + std::string WarningMsg = + (ShouldDisplayCheckerName ? " [" + PD->getCheckerName()

[PATCH] D75760: [clang-format] Do not indent C# array initialisers as continuations

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e1a026c2d81: [clang-format] Do not indent C# array initialisers as continuations (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

Quuxplusone updated this revision to Diff 252031. Quuxplusone added a comment. @jhenderson: Updated! clang-format's suggested linebreaks look horrendous to me, but if this makes that buildbot happy, okay... I guess the moral of the story is "deeply nested expressions that also use lots of

[PATCH] D76361: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

This revision was automatically updated to reflect the committed changes. baloghadamsoftware marked 4 inline comments as done. Closed by commit rG60bad941a1c1: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std… (authored by baloghadamsoftware). Repository: rG LLVM

[PATCH] D76534: [clang/docs] Fix various sphinx warnings/errors in docs.

fhahn added a comment. In D76534#1934943 , @rjmccall wrote: > Is the option issue causing the documentation to be wrong in any way, or does > it just produce a warning? If the latter, we could raise this issue with > them. I think it just produces a

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

grandinj added a comment. In D76572#1936861 , @Quuxplusone wrote: > Nice. Does LibreOffice have anything (either in clang-tidy or in a paper > guideline) against `T(x)`-style casts? E.g. No, we don't have very many of those in our codebase, so we have

[PATCH] D76604: [Analyzer] Model `size()` member function of containers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus, martong. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun,

[PATCH] D62724: [Analyzer] Iterator Checkers - Model `size()` method of containers

baloghadamsoftware abandoned this revision. baloghadamsoftware added a comment. Herald added subscribers: ASDenysPetrov, martong, steakhal. Superseded by D76604 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62724/new/

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko updated this revision to Diff 252006. lolleko added a comment. Adressed 2nd Review The problem with the changes you proposed is that it doesn't handle paragraphs (\n\n). I think the conditionals required to make that work wouldn't be much cleaner than the current solution. And I do

[PATCH] D76606: [clang-tidy] Warn on invalid "case" configurations for readability-identifier-naming

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:154 + llvm::errs() << "warning: Invalid case style '" << CaseValue + << "' for

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus created this revision. Szelethus added reviewers: NoQ, baloghadamsoftware, balazske, martong, xazax.hun, dcoughlin, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[PATCH] D76606: [clang-tidy] Warn on invalid "case" configurations for readability-identifier-naming

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 marked 2 inline comments as done. njames93 added a project: clang-tools-extra. njames93 added a comment. I'm not too sure how

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder marked an inline comment as done. tbaeder added a comment. Thanks, I'll take a look at the tests. Comment at: clang/test/SemaCXX/switch-implicit-fallthrough.cpp:110-114 +case 26: + return 0; +__attribute__((fallthrough)); // expected-warning{{fallthrough

[clang] 78e2a3c - [clang-format] Reflow long C# generic type constraints correctly

Author: Jonathan Coe Date: 2020-03-23T13:38:21Z New Revision: 78e2a3c678463caeec1524baa96cdeb6fcdb48be URL: https://github.com/llvm/llvm-project/commit/78e2a3c678463caeec1524baa96cdeb6fcdb48be DIFF: https://github.com/llvm/llvm-project/commit/78e2a3c678463caeec1524baa96cdeb6fcdb48be.diff LOG:

[PATCH] D76607: [clang-query] Add replace command

altimin updated this revision to Diff 252016. altimin added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76607/new/ https://reviews.llvm.org/D76607 Files: clang-tools-extra/clang-query/Query.cpp

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/Analyses.def:17 -ANALYSIS_STORE(RegionStore, "region", "Use region-based analyzer store", CreateRegionStoreManager) +ANALYSIS_STORE(RegionStore, "region", "Use region-based analyzer store", +

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna marked an inline comment as done. anna added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1172 + if (NumInstChecked++ > MaxInstCheckedForThrow || + isGuaranteedToTransferExecutionToSuccessor()) +return true;

[PATCH] D76054: [clang-apply-replacements] No longer deduplucates replacements from the same TU

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-apply-replacements/identical2.cpp:3 +// RUN: grep -Ev "// *[A-Z-]+:" %S/Inputs/identical2/identical2.cpp > %T/Inputs/identical2/identical2.cpp +// RUN: sed "s#\$(path)#%/T/Inputs/identical2#"

[clang] 60bad94 - [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

Author: Adam Balogh Date: 2020-03-23T15:29:55+01:00 New Revision: 60bad941a1c1b745f570da8251f2ba9ee8b7d06e URL: https://github.com/llvm/llvm-project/commit/60bad941a1c1b745f570da8251f2ba9ee8b7d06e DIFF: https://github.com/llvm/llvm-project/commit/60bad941a1c1b745f570da8251f2ba9ee8b7d06e.diff

[PATCH] D31343: Add an attribute plugin example

Jasmin added a comment. Hello John! I was encouraged by Erich after a talk I had with him and Aaron on IRC to contact you about an use case for this plugin. I wanted to use user-specified/unknown attributes to annotate code and was told that they are not propagated through the AST and

[PATCH] D76610: [ARM,CDE] Implement predicated Q-register CDE intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, ostannard, dmgreen. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. This patch implements the following CDE intrinsics: T __arm_vcx1q_m(int coproc, T

[PATCH] D75760: [clang-format] Do not indent C# array initialisers as continuations

jbcoe updated this revision to Diff 252028. jbcoe added a comment. Rebase and update patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75760/new/ https://reviews.llvm.org/D75760 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTestCSharp.cpp Index:

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

Quuxplusone added a comment. In D76572#1936191 , @grandinj wrote: > Libreoffice has a similar clang-tidy-style cast-checker [for C-style casts] > here: > > https://cgit.freedesktop.org/libreoffice/core/tree/compilerplugins/clang/cstylecast.cxx > >

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

erik.pilkington added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:6365 +const llvm::fltSemantics = Info.Ctx.getFloatTypeSemantics(Ty); +unsigned NumBits = APFloat::semanticsSizeInBits(Semantics); +assert(NumBits % 8 == 0); ldionne

[PATCH] D75760: [clang-format] Do not indent C# array initialisers as continuations

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. This is OK with the comment in the code. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75760/new/ https://reviews.llvm.org/D75760

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

hokein updated this revision to Diff 252046. hokein added a comment. - add -frecovery-ast cc1 option - defer changes for existing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69330/new/ https://reviews.llvm.org/D69330 Files:

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL, error if an output loc is missing for PathDiagConsumers that need it

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:26 #include "clang/CrossTU/CrossTranslationUnit.h" +#include "clang/Driver/DriverDiagnostic.h" #include

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko updated this revision to Diff 252045. hlopko marked 5 inline comments as done. hlopko added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files:

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 252043. fhahn added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72281/new/ https://reviews.llvm.org/D72281 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko added a comment. PTAL. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:173 +private: + // Keys are either Stmt* or Decl*. + llvm::DenseMap Nodes; gribozavr2 wrote: > The comment is not needed anymore. Clang tidy complains when I remove it :/

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa0320dd8d5a: Add ParsedAttrInfo::handleDeclAttribute (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31342/new/

[PATCH] D76607: [clang-query] Add replace command

altimin created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DO NOT SUBMIT: Early prototype Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76607 Files: clang-tools-extra/clang-query/Query.cpp clang-tools-extra/clang-query/Query.h

[clang-tools-extra] 7693a9b - [clang-tidy] Fix RenamerClangTidy handling qualified TypeLocs

Author: Nathan James Date: 2020-03-23T13:45:34Z New Revision: 7693a9b9314083eafd9b5b1e19b02aac06962eb2 URL: https://github.com/llvm/llvm-project/commit/7693a9b9314083eafd9b5b1e19b02aac06962eb2 DIFF: https://github.com/llvm/llvm-project/commit/7693a9b9314083eafd9b5b1e19b02aac06962eb2.diff LOG:

[PATCH] D76549: [clang-tidy] Fix RenamerClangTidy handling qualified TypeLocs

This revision was automatically updated to reflect the committed changes. Closed by commit rG7693a9b93140: [clang-tidy] Fix RenamerClangTidy handling qualified TypeLocs (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76549/new/

[PATCH] D76597: [clang-format] Reflow long C# generic type constraints correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rG78e2a3c67846: [clang-format] Reflow long C# generic type constraints correctly (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

erik.pilkington updated this revision to Diff 252023. erik.pilkington marked 5 inline comments as done. erik.pilkington added a comment. Add tests for `bit_cast((char)1)`; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76323/new/ https://reviews.llvm.org/D76323 Files:

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

yaxunl added a comment. In D76520#1934341 , @tra wrote: > Does it handle options with values? E.g. if I want to pass > `-mframe-pointer=none` ? I vaguely recall the current -Xarch_* implementation > had some limitations. > It may be worth adding a

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

yaxunl updated this revision to Diff 252024. yaxunl added a comment. Add a test for passing options with value CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76520/new/ https://reviews.llvm.org/D76520 Files: clang/include/clang/Driver/Options.td

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:129 + void SetRole(NodeRole NR); + `setRole()` (in new code). Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:975 + const syntax::Token

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

Szelethus marked 15 inline comments as done. Szelethus added a comment. Thanks, @martong! Comment at: clang/include/clang/StaticAnalyzer/Core/Analyses.def:61 + +ANALYSIS_DIAGNOSTICS(TEXT_MINIMAL, "text-minimal", + "Emits minimal diagnostics to stderr,

  1   2   3   >