[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

nikic added a comment. @arsenm If the `null-pointer-is-valid` attribute is moved into the data layout, I'm wondering how Clang's `-fno-delete-null-pointer-checks` option would work or what it would be replaced with. In Rust it is possible to define a custom target, which also defines a custom

[PATCH] D76197: clang-format: Use block indentation for braced initializations

DaanDeMeyer abandoned this revision. DaanDeMeyer added a comment. Turns out this is already possible by disabling Cpp11BracedListStyle. The proposed change introduced too many changes regardless so I'm abandoning this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76197/new/

[PATCH] D78874: [clang] Add vendor identity for Hygon Dhyana processor

fanjinke created this revision. Herald added subscribers: cfe-commits, cryptoad. Herald added a project: clang. fanjinke added a reviewer: clayborg. fanjinke added a comment. Hi Clayborg, Please help with the patch review. Thanks! The vendor id is used to determine whether the processor

[PATCH] D78874: [clang] Add vendor identity for Hygon Dhyana processor

fanjinke added a reviewer: clayborg. fanjinke added a comment. Hi Clayborg, Please help with the patch review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78874/new/ https://reviews.llvm.org/D78874

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer updated this revision to Diff 260157. DaanDeMeyer added a comment. Fixed formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78869/new/ https://reviews.llvm.org/D78869 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

Author: David Zarzycki Date: 2020-04-26T07:16:42-04:00 New Revision: 665471907a5c072c6653a38c35f35e5d54cef220 URL: https://github.com/llvm/llvm-project/commit/665471907a5c072c6653a38c35f35e5d54cef220 DIFF:

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer updated this revision to Diff 260161. DaanDeMeyer added a comment. - Moved docs to Format.h and re-generated rst file using dump_format_style.py - Expanded comment with an explanation for why you might want to not have a space before the parens of a ForEach macro This isn't

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay added a comment. Let me look into this a little, I'd prefer we fixed the corner cases than reverted the lot (https://bugs.llvm.org/show_bug.cgi?id=45357) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

dmgreen added inline comments. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Comment at: llvm/lib/Target/ARM/ARMInstrNEON.td:4846 + VDOT { + let hasNoSchedulingInfo = 1; + LukeGeeson wrote: > dmgreen wrote: > > I don't think that

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

MyDeveloperDay added a comment. Could you add to the review description a link to the systemd style guide that says it should be like this? Comment at: clang/docs/ClangFormatStyleOptions.rst:2311 + * ``SBPO_ControlStatementsExceptForEachMacros`` (in configuration: +

[PATCH] D75068: libclang: Add static build support for Windows

davezarzycki added a comment. Rather than wholly reverting this, I committed a fix: 665471907a5c072c6653a38c35f35e5d54cef220 The problem is that "NOT LIBCLANG_BUILD_STATIC" does not imply PIC, so there is no point in trying

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/13855/step_9.txt Please take a look and revert while you do if it takes a while to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/

[PATCH] D77597: [SveEmitter] Add IsAppendSVALL and builtins for svptrue and svcnt[bhwd]

This revision was automatically updated to reflect the committed changes. Closed by commit rG3817ca7dbf8d: [SveEmitter] Add IsAppendSVALL and builtins for svptrue and svcnt[bhwd] (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D77597?vs=259555=260160#toc Repository:

[clang] 3817ca7 - [SveEmitter] Add IsAppendSVALL and builtins for svptrue and svcnt[bhwd]

Author: Sander de Smalen Date: 2020-04-26T12:44:26+01:00 New Revision: 3817ca7dbf8d360fd6a2ff44722af1405722ad38 URL: https://github.com/llvm/llvm-project/commit/3817ca7dbf8d360fd6a2ff44722af1405722ad38 DIFF:

[clang-tools-extra] 6d7637d - [clangd] Disable delayed template parsing in the main file

Author: Sam McCall Date: 2020-04-26T14:29:38+02:00 New Revision: 6d7637dc460a3602d725eca8698fa0ecd920031b URL: https://github.com/llvm/llvm-project/commit/6d7637dc460a3602d725eca8698fa0ecd920031b DIFF: https://github.com/llvm/llvm-project/commit/6d7637dc460a3602d725eca8698fa0ecd920031b.diff

[PATCH] D78848: [clangd] Disable delayed template parsing in the main file

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d7637dc460a: [clangd] Disable delayed template parsing in the main file (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78848/new/

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

sammccall added a comment. In D76451#2004069 , @thakis wrote: > This breaks tests on Windows: http://45.33.8.238/win/13855/step_9.txt > > Please take a look and revert while you do if it takes a while to investigate. @nridge hold off on the revert, I

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer marked 3 inline comments as done. DaanDeMeyer added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2311 + * ``SBPO_ControlStatementsExceptForEachMacros`` (in configuration: +``ControlStatementsExceptForEachMacros``)

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

sammccall added a comment. Yes, looks fixed by 6d7637d . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451

[clang-tools-extra] c758181 - [clang-tidy] Use StringSwitch in a bunch of places. NFCI.

Author: Benjamin Kramer Date: 2020-04-26T17:24:47+02:00 New Revision: c758181525cbd4a603d6fd518ed33d9f324a7009 URL: https://github.com/llvm/llvm-project/commit/c758181525cbd4a603d6fd518ed33d9f324a7009 DIFF:

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:982 + " BOOST_FOREACH(Item *item, itemlist) {}\n" + " UNKNOWN_FORACH(Item * item, itemlist) {}\n" + "}", UNKNOWN_FOREACH?

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

MyDeveloperDay updated this revision to Diff 260171. MyDeveloperDay added a comment. More test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78879/new/ https://reviews.llvm.org/D78879 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: sylvestre.ledru, mitchell-stellar, sammccall. MyDeveloperDay added projects: clang, clang-format. Herald added a subscriber: cfe-commits. MyDeveloperDay updated this revision to Diff 260171. MyDeveloperDay added a comment.

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

MyDeveloperDay added a comment. I've added a couple of others reviewers to comment, I don't personally mind as I don't use the ForEach Macros. It feels kind of funny to me to differentiate just the for macros from for,if,while,for.. (I guess I'm struggling to understand why you wouldn't just

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

kbobyrev updated this revision to Diff 260188. kbobyrev added a comment. Slightly adjust the CMake scripts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78885/new/ https://reviews.llvm.org/D78885 Files:

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added projects: clang, LLVM. Generated Protobuf library has to be in CLANG_EXPORTS and should

[PATCH] D78874: [clang] Add vendor identity for Hygon Dhyana processor

clayborg added a comment. I am not sure I am the right person to review? I work on LLDB and LLVM mostly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78874/new/ https://reviews.llvm.org/D78874 ___

[clang-tools-extra] 6880c4d - [clangd] Fold buildAST into ParsedAST::build. NFCI

Author: Sam McCall Date: 2020-04-27T00:14:03+02:00 New Revision: 6880c4dfa3981ec26d44b5f4844b641342a4e3e8 URL: https://github.com/llvm/llvm-project/commit/6880c4dfa3981ec26d44b5f4844b641342a4e3e8 DIFF: https://github.com/llvm/llvm-project/commit/6880c4dfa3981ec26d44b5f4844b641342a4e3e8.diff

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

Szelethus added a comment. I think you can go ahead and commit. You seem to have a firm grasp on this project, I believe your experience with ASTImporter has more then prepared you for digging functions out of the `std` namespace, or whatever else that might come up :^) Repository: rG LLVM

[PATCH] D78843: [clangd] Remove unused bits after 67b2dbd5a33583. NFC

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:12 #include "index/remote/marshalling/Marshalling.h" #include "llvm/ADT/Optional.h" #include "llvm/ADT/StringRef.h" This can also be removed.

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2980 -return (Ty->isPromotableIntegerType() ? ABIArgInfo::getExtend(Ty) - : ABIArgInfo::getDirect()); +if (!Ty->isExtIntType()) + return

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:119 + + Checks all calls resolve to functions within __llvm_libc namespace. + Please enclose __llvm_libc in double back-ticks. Comment at:

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks added a comment. In D78836#2003696 , @kadircet wrote: > thanks, lgtm. do you have commit access? Yep :) Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

PaulkaToast created this revision. PaulkaToast added reviewers: aaron.ballman, njames93. PaulkaToast added projects: clang-tools-extra, libc-project. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This check will ensure that all calls to functions resolve

[PATCH] D78874: [clang] Add vendor identity for Hygon Dhyana processor

fanjinke added reviewers: joerg, rsmith. fanjinke added a comment. Hi, Please help with the patch review. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78874/new/ https://reviews.llvm.org/D78874

[PATCH] D78874: [clang] Add vendor identity for Hygon Dhyana processor

fanjinke added a comment. Hi Clayborg, Thanks for your replay! I will add more reviewers who have previously reviewed this file. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78874/new/ https://reviews.llvm.org/D78874

[PATCH] D62368: Add support for Hygon Dhyana processor

craig.topper added inline comments. Comment at: compiler-rt/lib/scudo/scudo_utils.cpp:85 + (Ecx == signature_HYGON_ecx); + if (!IsIntel && !IsAMD && !IsHygon) return false; What's the rationale for the vendor check here anyway? Why

[PATCH] D78874: [clang] Add vendor identity for Hygon Dhyana processor

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78874/new/ https://reviews.llvm.org/D78874

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

nemanjai marked an inline comment as done. nemanjai added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:277 break; case 'Q': // Memory operand that is an offset from a register (it is // usually better to use `m' or `es' in asm statements)

[clang] 8000d50 - [clangd] Strip /showIncludes in clangd compile commands

Author: Arthur Eubanks Date: 2020-04-26T18:57:39-07:00 New Revision: 8000d506afcdbb3aee7aa8f876688dd094c6eb85 URL: https://github.com/llvm/llvm-project/commit/8000d506afcdbb3aee7aa8f876688dd094c6eb85 DIFF:

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG8000d506afcd: [clangd] Strip /showIncludes in clangd compile commands (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/

[clang] 06bdffb - [AMDGPU] Expose llvm fence instruction as clang intrinsic

Author: Saiyedul Islam Date: 2020-04-27T09:39:03+05:30 New Revision: 06bdffb2bb45d8666ec86782d21214ef545a71fd URL: https://github.com/llvm/llvm-project/commit/06bdffb2bb45d8666ec86782d21214ef545a71fd DIFF:

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 updated this revision to Diff 260205. zhuhan0 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/ https://reviews.llvm.org/D78534 Files: clang/cmake/modules/AddClang.cmake Index:

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rG06bdffb2bb45: [AMDGPU] Expose llvm fence instruction as clang intrinsic (authored by saiislam, committed by sameerds). Changed prior to commit: https://reviews.llvm.org/D75917?vs=260053=260207#toc

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 added a comment. Hello @beanz @phosek @smeenai any comment on this patch? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/ https://reviews.llvm.org/D78534 ___ cfe-commits mailing