[PATCH] D79395: [clang][codegen] Hoist parameter attribute setting in function prolog.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79395/new/ https://reviews.llvm.org/D79395 __

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

vsavchenko updated this revision to Diff 262158. vsavchenko added a comment. Add parent change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79434/new/ https://reviews.llvm.org/D79434 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.c

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. vsavchenko added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. vsavchenko up

[PATCH] D79433: [analyzer] StdLibraryFunctionsChecker: Add summaries for POSIX

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a projec

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

rjmccall added a comment. The reason we call FP contraction "fast" instead of "on" when it's cross-statement is because "on" is supposed to be consistent with the C language rules, whereas "fast" is stronger. There's no analogous situation with reassociation; I don't think the C standard is li

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4938 +if (EIT->getNumBits() > 128) + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); + erichkeane wrote: > rjmccall wrote: > > rjmccall wrote: > > > erichkeane wrote: > > >

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a projec

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

This revision was automatically updated to reflect the committed changes. Closed by commit rG55b9b11fea3e: Don't assert about missing profile info in createProfileWeightsForLoop (authored by hans). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. In D78190#2020701 , @stuij wrote: > In D78190#2018685 , @fpetrogalli > wrote: > > > 3. Do you need those changes in the Hexagon and x86 backend? Could they be > > submitted separately, with

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

thakis added a comment. Fair enough :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79417/new/ https://reviews.llvm.org/D79417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. So are we happy with the patch as it is? Anybody else wants to LGTM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190 ___ cfe-commits mail

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a projec

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

hans added a comment. In D79417#2020607 , @thakis wrote: > Could there be a test for this? Or is that difficult? I think it would be a bit of a pain, which is why I skipped it. It also wouldn't be a very interesting test, just "don't assert here", reall

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

krasimir added a comment. I have an example where this goes wrong in ObjC (modulo indentation): struct Stuff stuff[] = {

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

rjmccall accepted this revision. rjmccall added a comment. Anyway, LGTM. Comment at: clang/lib/Sema/SemaExprObjC.cpp:948 +checkOneKey(IntegralKeys, Result.Val.getInt(), Loc); + } +} erik.pilkington wrote: > bendjones wrote: > > rjmccall wrote:

[PATCH] D79430: [analyzer] StdLibraryFunctionsChecker: Add LazyRanges to support type dependent Max

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a projec

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2401 // The actual identifier can be a nested name specifier, and in macros // it is often token-pasted. while (FormatTok->isOneOf(tok::identifier, tok::coloncolon, tok::hashhash, --

[clang] 55b9b11 - Don't assert about missing profile info in createProfileWeightsForLoop

Author: Hans Wennborg Date: 2020-05-05T18:59:00+02:00 New Revision: 55b9b11fea3e18b6826c39842bc43877d9eb57fd URL: https://github.com/llvm/llvm-project/commit/55b9b11fea3e18b6826c39842bc43877d9eb57fd DIFF: https://github.com/llvm/llvm-project/commit/55b9b11fea3e18b6826c39842bc43877d9eb57fd.diff

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. In D78190#2018685 , @fpetrogalli wrote: > 1. Shouldn't we test also that the parser is happy with the following > expressions? Added. Thanks. > 2. Would it make sense to to split this patch into 2 separate patches? One > that de

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

Szelethus added a comment. It would be nice to have a user-facing option that lists the functions this checker is **capable** of modeling in another patch :) Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:299 + "DisplayLoadedSummaries", +

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fa13a3dac1e: [clang][OpenMP] Fix getNDSWDS for aarch64. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews

[PATCH] D79276: [FileCheck] Support comment directives

jdenny added inline comments. Comment at: llvm/lib/Support/FileCheck.cpp:1928 static const char *DefaultCheckPrefixes[] = {"CHECK"}; +static const char *DefaultCommentPrefixes[] = {"COM", "RUN"}; jhenderson wrote: > Similar to what I mentioned in D79375, perha

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1041 + EvalCallAsPure) + .ArgConstra

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song updated this revision to Diff 262140. yonghong-song edited the summary of this revision. yonghong-song added a comment. change buitin flag to the following spec: flag == 0: a local relocation against bpf_prog BTF change flag == 1: a remote relocation against kernel Repository:

[PATCH] D78655: [HIP] Add -fhip-lambda-host-device

tra added a comment. > I agree with Richard that just making lambdas HD by default in all modes > seems like the right rule. Ack. Let's give it a try. I'll test this on our code and see what falls out. Stay tuned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://revie

[PATCH] D79276: [FileCheck] Support comment directives

jdenny updated this revision to Diff 262141. jdenny marked 14 inline comments as done. jdenny added a comment. Applied most reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79276/new/ https://reviews.llvm.org/D79276 Files: clang/test/CodeGen/default-address-space.c

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Could there be a test for this? Or is that difficult? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79417/new/ https://reviews.llvm.org/D79417 _

[clang] 4fa13a3 - [clang][OpenMP] Fix getNDSWDS for aarch64.

Author: Francesco Petrogalli Date: 2020-05-05T16:27:20Z New Revision: 4fa13a3dac1e0ff4dbab8810ae0dc413ce6bc927 URL: https://github.com/llvm/llvm-project/commit/4fa13a3dac1e0ff4dbab8810ae0dc413ce6bc927 DIFF: https://github.com/llvm/llvm-project/commit/4fa13a3dac1e0ff4dbab8810ae0dc413ce6bc927.dif

[PATCH] D79426: [clangd] Change PreambleOnlyAction with content truncation

kadircet updated this revision to Diff 262132. kadircet added a comment. - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79426/new/ https://reviews.llvm.org/D79426 Files: clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/

[PATCH] D78190: Add Bfloat IR type

fpetrogalli accepted this revision. fpetrogalli added a comment. Hi @stuij, thank you for adding the vector tests. I can say the patch LGTM now :) Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190

[PATCH] D79358: [analyzer] CERT: STR37-C

Szelethus added a comment. I'm afraid so. The patch otherwise looked really clean, sorry to ruin the day! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79358/new/ https://reviews.llvm.org/D79358 __

[PATCH] D79420: [analyzer] Make NonNullParamChecker as dependency for StdCLibraryFunctionsChecker

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. I'm a bit unsure about the naming, because it's not technically true that `NonNullParamChecker` is a dependency of `StdCLibraryFunctionsChecker`. The actual relationship is different, be

[PATCH] D79426: [clangd] Change PreambleOnlyAction with content truncation

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet updated this revision to Diff 262132. kadircet added a comment. - Add test Lexing until the

[PATCH] D79425: [analyzer] StdLibraryFunctionsChecker: Add overload for adding the same summary for different names

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a projec

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

yonghong-song added a comment. In D74668#2019558 , @anakryiko wrote: > what's the use case for flag==0 (no relocation)? why using built-in at all in > such case? Also flag==1 means relocate to local BTF ID or remote (kernel) BTF > ID? Do you plan to add

[PATCH] D78190: Add Bfloat IR type

stuij updated this revision to Diff 262122. stuij added a comment. added vector tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190 Files: clang/lib/Sema/SemaOpenMP.cpp llvm/docs/BitCodeFormat.rst l

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems reasonable, especially since none of the other tests break. I don't fully remember the reason for the special case, and if it ever turns up, we can address it then. CHANGES SINCE

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

MyDeveloperDay added a comment. In D79388#2020320 , @JakeMerdichAMD wrote: > Sure, I'll get started on that. It mainly comes from charging headfirst into > the edge cases, but I think I have a decent grasp of clang-format internals > now, and I'm defini

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a projec

[PATCH] D79380: [clang-tidy] In TransformerClangTidyCheck, support option IncludeStyle.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5b1a0352535: [clang-tidy] In TransformerClangTidyCheck, support option IncludeStyle. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79

[PATCH] D78546: Enable bugprone-argument-comments check in llvm.

hokein added a comment. In D78546#2005306 , @sammccall wrote: > > LLVM code style encourages this > > Not very strongly, it just says it can be helpful (and tells you how to do it > if you do it). So I'm wary of making it mandatory in cases where it isn't

[PATCH] D79420: [analyzer] Make NonNullParamChecker as dependency for StdCLibraryFunctionsChecker

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a projec

[PATCH] D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3

kwk created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. kwk edited the summary of this revision. kwk added reviewers: djasper, dsanders. kwk edited the summary of this revision. kwk edited the summary of this revision. This fixes https://bugs.llvm.org/show

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

mibintc added a comment. I checked with FPGA folks and confirm what @scanon says is correct, the reassoc fast math flag enables reassociation across multiple statements, so i changed the syntax to use 'fast' and 'off', and changed the documentation Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 262108. mibintc retitled this revision from "Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associati

[PATCH] D78743: [clangd] Preserve line information while build PreamblePatch

kadircet updated this revision to Diff 262107. kadircet marked 5 inline comments as done. kadircet added a comment. - Rebase and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78743/new/ https://reviews.llvm.org/D78743 Files: cla

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4317 + if (isAggregateTypeForABI(RetTy)) +return getNaturalAlignIndirect(RetTy); + Xiangling_L wrote: > jasonliu wrote: > > Xiangling_L wrote: > > > This method uses the ABI alig

[clang-tools-extra] c5b1a03 - [clang-tidy] In TransformerClangTidyCheck, support option IncludeStyle.

Author: Yitzhak Mandelbaum Date: 2020-05-05T10:38:31-04:00 New Revision: c5b1a0352535e138af867f7b63cf5b4793fd6de7 URL: https://github.com/llvm/llvm-project/commit/c5b1a0352535e138af867f7b63cf5b4793fd6de7 DIFF: https://github.com/llvm/llvm-project/commit/c5b1a0352535e138af867f7b63cf5b4793fd6de7.

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

ASDenysPetrov added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:103-110 + enum class CompareResult { +unknown, +identical, +less, +less_equal, +greater, +greater_equal Can

[PATCH] D79380: [clang-tidy] In TransformerClangTidyCheck, support option SourceNamingStyle.

ymandel updated this revision to Diff 262105. ymandel added a comment. renamed option to IncludeStyle, for consistency w/ existing checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79380/new/ https://reviews.llvm.org/D79380 Files: clang-tool

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA abandoned this revision. ZarkoCA added a comment. This work is included in https://reviews.llvm.org/D79035. Abandoning this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.llvm.org/D76360 _

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

JakeMerdichAMD added a comment. Sure, I'll get started on that. It mainly comes from charging headfirst into the edge cases, but I think I have a decent grasp of clang-format internals now, and I'm definitely interested in both contributing to and reviewing for it. Repository: rG LLVM Github

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:229-234 BufferSizeConstraint(ArgNo BufArgN, ArgNo SizeArgN) : ValueConstraint(BufArgN), SizeArgN(SizeArgN) {} +

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4317 + if (isAggregateTypeForABI(RetTy)) +return getNaturalAlignIndirect(RetTy); + jasonliu wrote: > Xiangling_L wrote: > > This method uses the ABI alignment of the given aggreg

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

martong updated this revision to Diff 262098. martong marked 2 inline comments as done. martong added a comment. - Rebase to latest parent patch - Create BufSize constraints in a more descriptive way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D771

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong updated this revision to Diff 262095. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77066/new/ https://reviews.llvm.org/D77066 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/Dynam

[PATCH] D78980: Elaborate more on --rocm-path flag.

arsenm closed this revision. arsenm added a comment. 684dc1bebe5cb70cfd27923940f9f8cba4f13195 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78980/new/ https://reviews.llvm.org/D78980 __

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

hans created this revision. hans added reviewers: thakis, rnk. The compiler shouldn't crash if the profile info is slightly off. We hit this in Chromium. https://reviews.llvm.org/D79417 Files: clang/lib/CodeGen/CodeGenPGO.cpp Index: clang/lib/CodeGen/CodeGenPGO.cpp

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77066/new/ https://reviews.llvm.org/D77066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 684dc1b - Elaborate more on --rocm-path flag.

Author: Matt Arsenault Date: 2020-05-05T09:33:18-04:00 New Revision: 684dc1bebe5cb70cfd27923940f9f8cba4f13195 URL: https://github.com/llvm/llvm-project/commit/684dc1bebe5cb70cfd27923940f9f8cba4f13195 DIFF: https://github.com/llvm/llvm-project/commit/684dc1bebe5cb70cfd27923940f9f8cba4f13195.diff

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane updated this revision to Diff 262093. erichkeane added a comment. Extracted out a function for PPC64's coerce to array. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79118/new/ https://reviews.llvm.org/D79118 Files: clang/lib/Basic/Targets/AArch64.h clang/lib/Basic/Targe

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4938 +if (EIT->getNumBits() > 128) + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); + rjmccall wrote: > rjmccall wrote: > > e

[PATCH] D79414: [clang-format] C# always regards && as a binary operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG047898c9aa1d: [clang-format] C# always regards && as a binary operator (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Math looks good to me :) Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:388 + /// it will return the range [x_0, y_N]. + static Range roughen(RangeSet Origi

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaExprObjC.cpp:948 +checkOneKey(IntegralKeys, Result.Val.getInt(), Loc); + } +} bendjones wrote: > rjmccall wrote: > > Does `Eva

[PATCH] D79415: [analyzer][MalloChecker] When modeling realloc-like functions, don't early return if the argument is symbolic

Szelethus created this revision. Szelethus added reviewers: NoQ, balazske, martong, baloghadamsoftware, vsavchenko, xazax.hun, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.s

[PATCH] D79380: [clang-tidy] In TransformerClangTidyCheck, support option SourceNamingStyle.

ymandel added a comment. In D79380#2020135 , @gribozavr2 wrote: > > It's only effect is to determine how a given file is related to header > > files, specifically how to determine that a header "corresponds" to a the > > file being examined -- that is, i

[PATCH] D79414: [clang-format] C# always regards && as a binary operator

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79414/new/ https://reviews.llvm.org/D79414

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

MyDeveloperDay added a comment. In D78869#2019933 , @DaanDeMeyer wrote: > (I don't have commit access so it'd be great if someone could merge this for > me, at least that's how my other contributions have been handled) You really should think about gett

[PATCH] D79414: [clang-format] C# always regards && as a binary operator

jbcoe created this revision. jbcoe added reviewers: krasimir, MyDeveloperDay. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to

[PATCH] D78444: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

rdwampler added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78444/new/ https://reviews.llvm.org/D78444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4368 + + return emitVoidPtrVAArg(CGF, VAListAddr, Ty, /*Indirect*/ false, TypeInfo, + SlotSize, /*AllowHigher*/ true); Is there a reason why Indirect is set to `

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

MyDeveloperDay added a comment. In D79388#2019985 , @JakeMerdichAMD wrote: > @MyDeveloperDay, you're right about what this issue addresses: it surprised > me a lot when an unrelated edit caused something to 'randomly' add spaces > elsewhere, since it's

[clang] 047898c - [clang-format] C# always regards && as a binary operator

Author: Jonathan Coe Date: 2020-05-05T14:05:00+01:00 New Revision: 047898c9aa1d8858fa0d87f7e349749222cabf22 URL: https://github.com/llvm/llvm-project/commit/047898c9aa1d8858fa0d87f7e349749222cabf22 DIFF: https://github.com/llvm/llvm-project/commit/047898c9aa1d8858fa0d87f7e349749222cabf22.diff

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:814 +Optional RangeConstraintManager::tryAssumeSymSymOp( +ProgramStateRef State, BinaryOperator::Opcode Op, SymbolRef LHSSym, I believe you don't need to return

[PATCH] D79380: [clang-tidy] In TransformerClangTidyCheck, support option SourceNamingStyle.

gribozavr2 added a comment. > It's only effect is to determine how a given file is related to header files, > specifically how to determine that a header "corresponds" to a the file being > examined -- that is, it is _this_ file's header rather than some arbitrary > header. ... and the results

[PATCH] D79411: [VE] Clang toolchain for VE

simoll created this revision. simoll added reviewers: arsenm, k-ishizaka, kaz7. simoll added a project: VE. Herald added subscribers: cfe-commits, jfb, krytarowski, mgorny, wdng. Herald added a project: clang. This patch enables compilation of C code for the VE target with Clang. Repository: r

[PATCH] D79412: buildkite test

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79412 Files: clang-tools-extra/clangd/RIFF.cpp Index: clang-tools-extra/clangd/RIFF.c

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ba329059f9c: [SveEmitter] Add builtins for svreinterpret (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78756/new/ https://reviews.

[PATCH] D79380: [clang-tidy] In TransformerClangTidyCheck, support option SourceNamingStyle.

ymandel added a comment. In D79380#2019570 , @gribozavr2 wrote: > LGTM, but I don't understand why this option is called "SourceNamingStyle". > Existing ClangTidy checkers call it "IncludeStyle". Thanks for the review! Good question. I'd planned to cal

[clang] 5ba3290 - [SveEmitter] Add builtins for svreinterpret

Author: Sander de Smalen Date: 2020-05-05T13:04:44+01:00 New Revision: 5ba329059f9c28dcbba912685d00a7982833abcf URL: https://github.com/llvm/llvm-project/commit/5ba329059f9c28dcbba912685d00a7982833abcf DIFF: https://github.com/llvm/llvm-project/commit/5ba329059f9c28dcbba912685d00a7982833abcf.di

[PATCH] D76646: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the formatting nits. I think this is a nice cleanup, thanks! Comment at: clang/include/clang/AST/Expr.h:503 - /// isIntegerConstantExpr - Ret

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

dnsampaio added a comment. I believe we can avoid creating some blocks for latter removing them, no? Comment at: clang/lib/CodeGen/CGExprCXX.cpp:2042-2049 // Null check the pointer. llvm::BasicBlock *DeleteNotNull = createBasicBlock("delete.notnull"); llvm::BasicBlock

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

JakeMerdichAMD added a comment. @MyDeveloperDay, you're right about what this issue addresses: it surprised me a lot when an unrelated edit caused something to 'randomly' add spaces elsewhere, since it's in a different ifdef block (whether or not it has the same condition). The code that's alig

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4938 +if (EIT->getNumBits() > 128) + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); + rjmccall wrote: > erichkeane wrote: > > rjmccall wrote: > > > Does this need to consid

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal created this revision. pdhaliwal added reviewers: chandlerc, beanz, pcc. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. The AddLLVM.cmake file exposes a function find_first_existing_vc_file which in case of git repository looks for .git/

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane updated this revision to Diff 261922. erichkeane marked 2 inline comments as done. erichkeane added a comment. For PPC64, better emulate structs by passing _ExtInt as an array. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79118/new/ https://reviews.llvm.org/D79118 Files:

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer added a comment. (I don't have commit access so it'd be great if someone could merge this for me, at least that's how my other contributions have been handled) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78869/new/ https://reviews.llvm.org/D78869 __

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:39 SrcMgr::CharacteristicKind FileKind) override { -if (isInsideMainFile(HashLoc, SM)) { +auto AddMainFileInc = [&](SourceLocation HashLoc) { Out->MainFileIn

[PATCH] D79358: [analyzer] CERT: STR37-C

zukatsinadze added a comment. In D79358#2019755 , @Szelethus wrote: > Adding @martong, because I fear that this is colliding with > StdLibraryFunctionsChecker. The warnings added here seem to be, in essence, > identical to D73898

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet updated this revision to Diff 262057. kadircet marked 13 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78740/new/ https://reviews.llvm.org/D78740 Files: clang-tools-e

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske updated this revision to Diff 262058. balazske marked 2 inline comments as done. balazske added a comment. Small review related fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78374/new/ https://reviews.llvm.org/D78374 Files: clang

[PATCH] D79315: [clangd] Get rid of Inclusion::R

This revision was automatically updated to reflect the committed changes. Closed by commit rGd870016bfce8: [clangd] Get rid of Inclusion::R (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79315/new/ https://reviews.llvm.org/D79

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. If there is no additional comments from others then I'm fine giving this a LGTM, if it means we can encourage other big projects to go full clang-format CHANGES SINCE LAST ACT

[clang-tools-extra] d870016 - [clangd] Get rid of Inclusion::R

Author: Kadir Cetinkaya Date: 2020-05-05T12:23:58+02:00 New Revision: d870016bfce8135c8b004c671697d091345463f0 URL: https://github.com/llvm/llvm-project/commit/d870016bfce8135c8b004c671697d091345463f0 DIFF: https://github.com/llvm/llvm-project/commit/d870016bfce8135c8b004c671697d091345463f0.dif

[PATCH] D79313: [clangd] NFC: Cleanup unused headers and libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rG07f8ca6ab19b: [clangd] NFC: Cleanup unused headers and libraries (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79313/new/ https://re

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Can we abandon this review now we have the style=file:? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68569/new/ https

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. You need to regenerate the ClangFormatStyleOption.rst file using docs/tools/dump_format_style.py Comment at: clang/include/clang/Format/Format.h:965 bool AfterExternBlock; +enum ExternBlock { + /// Break extern blocks before the cu

[PATCH] D71239: [clang-format] Fix ObjC keywords following try/catch getting split.

MyDeveloperDay added a comment. bool FormatTokenLexer::tryMergeAtTry() { if (Tokens.size() < 2) return false; auto &At = *(Tokens.end() - 2); auto &Try = *(Tokens.end() - 1); if (!At->is(tok::at) || !String->is(tok::try)) return false; At->Tok.setKind(tok::try);

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

hokein updated this revision to Diff 262044. hokein marked 4 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79160/new/ https://reviews.llvm.org/D79160 Files: clang/include/clang/A

<    1   2   3   >