[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129

[PATCH] D79411: [VE] Clang toolchain for VE

simoll updated this revision to Diff 263638. simoll added a comment. - Simplified: stripped down to a basic C GNU Linux toolchain hard-float, no C++ stdlib. - rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/

[PATCH] D79830: Add support of __builtin_expect_with_probability

lebedev.ri added a reviewer: erichkeane. lebedev.ri added a comment. Thanks for working on this. Please upload patch with full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830

[clang] ad60ff7 - [NFC] Code cleanup in TargetInfo.cpp

Author: Shengchen Kan Date: 2020-05-13T14:48:46+08:00 New Revision: ad60ff70eb56a7d198e613152f9974d5d4baabd4 URL: https://github.com/llvm/llvm-project/commit/ad60ff70eb56a7d198e613152f9974d5d4baabd4 DIFF: https://github.com/llvm/llvm-project/commit/ad60ff70eb56a7d198e613152f9974d5d4baabd4.diff

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

chandlerc added inline comments. Comment at: clang/test/Misc/loop-opt-setup.c:12 +// Check br i1 to make sure that the loop is fully unrolled // CHECK-NOT: br i1 This is dead now that you have different prefixes... Comment at:

[PATCH] D79843: [analyzer] Fix crash for non-pointers annotated as nonnull

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Perfect, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79843/new/ https://reviews.llvm.org/D79843

[PATCH] D79843: [analyzer] Fix crash for non-pointers annotated as nonnull

This revision was automatically updated to reflect the committed changes. Closed by commit rG855f0ce79bf3: [analyzer] Fix crash for non-pointers annotated as nonnull (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79843/new/

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. I'm sorry for the late review -- please know that this isn't the first time me taking a look, this is a complex issue. I find navigating your phabricator comments a bit

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Yeah, this patch should definitely have unit tests. All similar patches should. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/

[PATCH] D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI

speidy created this revision. speidy added a reviewer: miyuki. speidy added a project: libunwind. Herald added subscribers: libcxx-commits, llvm-commits, kristof.beyls. Herald added a project: LLVM. Herald added a reviewer: libunwind. speidy edited the summary of this revision. speidy edited the

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 263686. DavidSpickett added a comment. - Fix spelling - Rework explanatory comments to be a bit clearer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files: clang/lib/Driver/Driver.cpp

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 263796. dang added a comment. Upload the right patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

jkorous added a comment. IIUC the issue is that `SourceManager::translateFile()` basically consists of two blocks of code: // First, check the main file ID, since it is common to look for a // location in the main file. if (MainFileID.isValid()) { bool Invalid = false; const

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 263795. dang added a comment. Rebase on top of llvm/master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Frontend/CompilerInvocation.h

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with one small comment. Comment at: clang/include/clang/Basic/arm_sve.td:1249 +def SVSUDOT_S: SInst<"svsudot[_s32]","ddqb", "i", MergeNone,

[PATCH] D78120: [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a12acda4c9f: [analyzer][StreamChecker] Dont make StreamTestChecker depend on StreamChecker… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79866: [CUDA][HIP] Do not emit debug info for stub function

yaxunl added a comment. In D79866#2034460 , @tra wrote: > I do not see the behavior the patch is supposed to fix in CUDA. > If I compile a simple program, host-side debugger does not see the `kernel`, > sees `__device_stub_kernel` and, if the breakpoint

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

ahatanak updated this revision to Diff 263792. ahatanak marked an inline comment as done. ahatanak added a comment. Check function types in `DefaultLvalueConversion`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78134/new/

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. In D79330#2034414 , @martong wrote: > I am not sure if I can follow your concern here. > `sizeof(size_t)` is typically 8, so that is not a bug,

[clang] bd541b2 - [NewPassManager] Add assertions when getting statefull cached analysis.

Author: Alina Sbirlea Date: 2020-05-13T12:38:38-07:00 New Revision: bd541b217f4d750391677144ccaa586874236f38 URL: https://github.com/llvm/llvm-project/commit/bd541b217f4d750391677144ccaa586874236f38 DIFF: https://github.com/llvm/llvm-project/commit/bd541b217f4d750391677144ccaa586874236f38.diff

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid added a comment. In D79743#2034792 , @jyu2 wrote: > Two questions: > 1> What happen under SLH, will asm goto gets removed, or a runtime problem? > 2> Should we emit error or warning in the Parser instead? 1. SLH crashes with an unhelpful

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

ldionne added a comment. @Tyker @rsmith You might be interested in reading https://llvm.org/PR45912, which describes what I believe to be an issue with this patch (or another related patch for `consteval` -- not sure). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman added a comment. In D79834#2034666 , @jkorous wrote: > IIUC the issue is that `SourceManager::translateFile()` basically consists of > two blocks of code: > > // First, check the main file ID, since it is common to look for a > // location

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked 3 inline comments as done. mibintc added a comment. added some inline explanation Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat =

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274 ___ cfe-commits mailing list

[PATCH] D79895: Fix warning about using uninitialized variable as function const reference parameter

rnk added a comment. Arthur recently went through the process of refining a diagnostic, so he should be able to help guide you in this if you have more questions. Comment at: clang/lib/Analysis/UninitializedValues.cpp:425 if ((*I)->getType().isConstQualified()) -

[PATCH] D79866: [HIP] Do not emit debug info for stub function

yaxunl added a comment. In D79866#2034748 , @tra wrote: > In D79866#2034683 , @yaxunl wrote: > > > can you try set bp by using file name and line number on the kernel? > > > In regular gdb it is set on the stub. >

[clang] 2a12acd - [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

Author: Kirstóf Umann Date: 2020-05-13T20:05:11+02:00 New Revision: 2a12acda4c9fad4d69dce7a43e99690df357648c URL: https://github.com/llvm/llvm-project/commit/2a12acda4c9fad4d69dce7a43e99690df357648c DIFF: https://github.com/llvm/llvm-project/commit/2a12acda4c9fad4d69dce7a43e99690df357648c.diff

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak updated this revision to Diff 263838. llunak edited the summary of this revision. llunak added a comment. Updated commit message. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 Files:

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 263830. yroux added a comment. I found a last issue when doing a full bootstrap with -moutline used to build clang, there was a case of thunk outlining where the original was call a `BLX LR` which was broken by the outlining call `BL OUTLINE_FUNCTION_X` I

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak updated this revision to Diff 263839. llunak edited the summary of this revision. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 Files: clang/lib/Serialization/ASTReader.cpp

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak added a comment. In D69778#2032363 , @dblaikie wrote: > So the original commit ( cbc9d22e49b4 > ) was > reverted at some point, and now you're proposing recommitting it with a

[PATCH] D79905: [clang-format] [PR44476] Add space between template and attribute

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, sammccall. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay added a reviewer: abrachet. https://bugs.llvm.org/show_bug.cgi?id=44476 template [[nodiscard]] int

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 263843. Xiangling_L added a comment. Fix a minor issue in the testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/include/clang/AST/Mangle.h

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

martong accepted this revision. martong added a comment. In D79330#2033990 , @Szelethus wrote: > > Variable-length array (VLA) should have a size that fits into a size_t > > value. At least if the size is queried with sizeof, but it is better (and > >

[PATCH] D78120: [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

Szelethus added a comment. In D78120#1983756 , @balazske wrote: > LGTM > But a better approach can be to make a new kind of dependency. (Or split the > StreamChecker.) Definitely the latter, I just didn't wanna mess with your project :) But I'd be

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth updated this revision to Diff 263790. amccarth added a comment. Addressed feedback, specifically: - Distinction is now on CodeView generation rather than -fms-compatibility. - Tests two --std= levels plus the default one. CHANGES SINCE LAST ACTION

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

JakeMerdichAMD added a comment. Thanks for the commit and review @MyDeveloperDay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/ https://reviews.llvm.org/D79388 ___ cfe-commits mailing list

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth marked 2 inline comments as done. amccarth added a comment. Made the requested changes after an in-person conversation to clear up my earlier confusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274

[PATCH] D78190: Add Bfloat IR type

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. Nothing much has changed here: there was already broad consensus on this change and direction, and the last few weeks we have only seen a few rounds of minor comments and nits, so still LGTM. Please wait a day with committing to

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, efriedma, david-arm. Herald added subscribers: cfe-commits, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. fpetrogalli added a parent revision: D79639: [SveEmitter] Builtins for

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware updated this revision to Diff 263748. baloghadamsoftware added a comment. Herald added a subscriber: mgorny. Unit test added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 Files:

[PATCH] D79866: [HIP] Do not emit debug info for stub function

yaxunl updated this revision to Diff 263831. yaxunl retitled this revision from "[CUDA][HIP] Do not emit debug info for stub function" to "[HIP] Do not emit debug info for stub function". yaxunl added a comment. limit change to HIP CHANGES SINCE LAST ACTION

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 263832. atmnpatel added a comment. Addresses inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd541b217f4d: [NewPassManager] Add assertions when getting statefull cached analysis. (authored by asbirlea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

rnk added inline comments. Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1305 +if (const auto *CB1 = dyn_cast(I1)) + if (CB1->cannotMerge()) +return Changed; zequanwu wrote: > rnk wrote: > > It seems inconsistent that we don't apply the

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

nikic added a comment. In D75936#2032090 , @craig.topper wrote: > In D75936#2032078 , @sconstab wrote: > > > In D75936#2032027 , @nikic wrote: > > > > > This change causes

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske marked 2 inline comments as done. balazske added a comment. The intent is to model the fread-fwrite function failure by returning the error value and set the stream into error state. The error state is a composite of **ferror** and **feof**. The questions are now, at what case do these

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/deprecated-copy.cpp:7 +#ifdef NO_USER_PROVIDED +// expected-no-diagnostics +#endif xbolva00 wrote: > xbolva00 wrote: > > Quuxplusone wrote: > > > I'm fairly confident this should just be two

[clang] b2eb439 - [clang-format] Fix AlignConsecutive on PP blocks

Author: mydeveloperday Date: 2020-05-13T18:31:51+01:00 New Revision: b2eb439317576ce718193763c12bff9fccdfc166 URL: https://github.com/llvm/llvm-project/commit/b2eb439317576ce718193763c12bff9fccdfc166 DIFF:

[clang] 7a8edcb - [Clang] Restore replace_path_prefix instead of startswith

Author: Sylvain Audi Date: 2020-05-13T13:49:14-04:00 New Revision: 7a8edcb2124b60941ef6ea4bb4b38a9eb0d70137 URL: https://github.com/llvm/llvm-project/commit/7a8edcb2124b60941ef6ea4bb4b38a9eb0d70137 DIFF: https://github.com/llvm/llvm-project/commit/7a8edcb2124b60941ef6ea4bb4b38a9eb0d70137.diff

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese added a comment. I mostly just need to rebase this patch now. I'll try to get to that soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ https://reviews.llvm.org/D70351 ___

[PATCH] D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79852/new/ https://reviews.llvm.org/D79852

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

NoQ added a comment. In D79704#2032947 , @Szelethus wrote: > In D79704#2032271 , @NoQ wrote: > > > Blanket reply! `ParamRegion` is not a `DeclRegion` because it does not > > necessarily have a corresponding

[PATCH] D79830: Add support of __builtin_expect_with_probability

xbolva00 added a comment. In D79830#2034380 , @RKSimon wrote: > Add a description in our documentation? And Ideally add a note to release notes too.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79894: [clang][slh] Add test for SLH feature checking macro

zbrid created this revision. zbrid added reviewers: craig.topper, mattdr. Herald added a project: clang. Herald added a subscriber: cfe-commits. I forgot to include a test in this commit: https://reviews.llvm.org/rG379e68a763097bed6c6dc7453e4b732e3d68 Here's the test. It passes after that

[PATCH] D79866: [CUDA][HIP] Do not emit debug info for stub function

tra added a comment. In D79866#2034683 , @yaxunl wrote: > can you try set bp by using file name and line number on the kernel? In regular gdb it is set on the stub. In cuda-gdb the behavior is interesting -- it initially gets set and breaks on the

[PATCH] D79895: Fix warning about using uninitialized variable as function const reference parameter

zequanwu created this revision. zequanwu added reviewers: rsmith, rnk. zequanwu added a project: clang. Herald added a subscriber: cfe-commits. bug filed here: https://bugs.llvm.org/show_bug.cgi?id=45624 Uninitialized variable as function const reference parameter should be use. Repository:

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added a comment. In D79830#2033367 , @lebedev.ri wrote: > Thanks for working on this. > Please upload patch with full context. Hi, sorry but I'm not sure what does full context means, is that means I need to show more lines(for example 10

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

dexonsmith added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:162 // The option identifier name. -OS << ", "<< getOptionName(R); +OS << ", " << getOptionName(R); This whitespace fixup LGTM, but you should commit it

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. In D79830#2034779 , @LukeZhuang wrote: > In D79830#2033367 , @lebedev.ri > wrote: > > > Thanks for working on this. > > Please upload patch with full context. > > > Hi, sorry but I'm

[PATCH] D79830: Add support of __builtin_expect_with_probability

lebedev.ri added a comment. In D79830#2034779 , @LukeZhuang wrote: > In D79830#2033367 , @lebedev.ri > wrote: > > > Thanks for working on this. > > Please upload patch with full context. > > > Hi, sorry but I'm

[PATCH] D79879: [clangd] Change getSymbolID to accept macro location instead of macro info

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a child revision: D79881: [clangd] locateMacroAt returns definition range instead of MacroInfo. Repository: rG LLVM Github

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

SjoerdMeijer added inline comments. Comment at: clang/include/clang/Basic/arm_bf16.td:1 +//===--- arm_fp16.td - ARM FP16 compiler interface ===// +// typo: fp16 - > bf16? Here, and a few more places, or is it intentional? If so, I guess

[PATCH] D79881: [clangd] locateMacroAt returns definition range instead of MacroInfo

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D79879 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79881 Files:

[PATCH] D79869: [clang][BFloat] Add reinterpret cast intrinsics

LukeGeeson added a comment. As I was an author of this patch (among others) please could you add a list of authors to the commit message. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79869/new/ https://reviews.llvm.org/D79869

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

ahatanak updated this revision to Diff 263753. ahatanak marked 6 inline comments as done. ahatanak added a comment. Address review comments. Handle derived-to-base cast expressions and array subscript expressions that don't have constant indices. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

LukeGeeson added a comment. I was an author for part of this patch. Please add all authors as a list of authors to this commit message. Thanks! As an aside, it would be worth doing this for all the patches in this series Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78120: [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

Szelethus added a comment. In D78120#2034455 , @Szelethus wrote: > In D78120#1983756 , @balazske wrote: > > > LGTM > > But a better approach can be to make a new kind of dependency. (Or split > > the

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13122 +if (Base->isVirtual()) { + BaseAlignment = Ctx.getTypeAlignInChars(Base->getType()); + Offset = CharUnits::Zero(); Oh, this — and all the other places that do

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. In D79830#2034400 , @davidxl wrote: > Is it possible to overload __builtin_expect(..)? No OP, but... First, Overloading builtins is a bit of a pain. You end up having to do custom type checking. Second, GCC already made the

[PATCH] D79866: [CUDA][HIP] Do not emit debug info for stub function

tra added a comment. I do not see the behavior the patch is supposed to fix in CUDA. If I compile a simple program, host-side debugger does not see the `kernel`, sees `__device_stub_kernel` and, if the breakpoint is set on `kernel`, it treats it as a yet-to-be-loaded one and does end up

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

yaxunl added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7899 +if (FpPragmaCurrentLocation.isInvalid()) { + assert(*FpPragmaCurrentValue == SemaObj->FpPragmaStack.DefaultValue && + "Expected a default pragma float_control value");

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

martong accepted this revision. martong added a comment. Herald added a subscriber: rnkovacs. In D79072#2026553 , @balazske wrote: > This change is relatively small and the refactoring like part (introduction > of `checkVLA` if I think correct?) is

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

Szelethus added a comment. In D78374#2033826 , @balazske wrote: > I think this is a expected way of how it works, failure of a stream operation > does not necessarily depend on result of a previous operation. So any > operation can fail or not,

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

tambre updated this revision to Diff 263759. tambre added a comment. Simplify code, improve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79800/new/ https://reviews.llvm.org/D79800 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

[clang] c82243d - [clang-format] : Fix additional pointer alignment for overloaded operators

Author: mydeveloperday Date: 2020-05-13T18:33:57+01:00 New Revision: c82243d0675bad130d22a9301d3dc1e7cfb05c2f URL: https://github.com/llvm/llvm-project/commit/c82243d0675bad130d22a9301d3dc1e7cfb05c2f DIFF:

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu marked an inline comment as done. jasonliu added inline comments. Comment at: clang/test/Frontend/aix-unsupported.c:10 +// RUN: -c %s 2>&1 | FileCheck %s +// CHECK: unsupported option Xiangling_L wrote: > One thing I am not so sure about is that for

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman updated this revision to Diff 263781. arphaman added a comment. fix assertion in the unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79834/new/ https://reviews.llvm.org/D79834 Files: clang/include/clang/Basic/SourceManager.h clang/lib/Basic/SourceManager.cpp

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2eb43931757: [clang-format] Fix AlignConsecutive on PP blocks (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

This revision was automatically updated to reflect the committed changes. Closed by commit rGc82243d0675b: [clang-format] : Fix additional pointer alignment for overloaded operators (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc created this revision. mibintc added reviewers: rjmccall, scanon. Herald added a project: clang. mibintc marked 3 inline comments as done. mibintc added a comment. added some inline explanation Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

sammccall added a comment. It's tedious, but we really should have tests for this now. Comment at: clang-tools-extra/clangd/index/remote/Index.proto:68 -// FIXME(kirillbobyrev): Properly serialize symbols and refs instead of passing -// YAML. -message Ref { string

[PATCH] D79830: Add support of __builtin_expect_with_probability

davidxl added a comment. Is it possible to overload __builtin_expect(..)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list

[PATCH] D79830: Add support of __builtin_expect_with_probability

RKSimon added a comment. Add a description in our documentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

martong added a comment. In D79330#2026564 , @balazske wrote: > I do not know if it would me **much** cleaner. > > - First part: Move calculation of `ArraySize` into `checkVLA` and rename > `checkVLASize` to `checkVLAIndexSize`. > - Second part: Add the

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson added a comment. I authored some of the code for this patch, please update the commit message with my name on the list :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

jyu2 added a comment. Two questions: 1> What happen under SLH, will asm goto gets removed, or a runtime problem? 2> Should we emit error or warning in the Parser instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid updated this revision to Diff 263819. zbrid added a comment. Update to fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

This revision was automatically updated to reflect the committed changes. Closed by commit rGa549c0d00486: Fix template class debug info for Visual Studio visualizers (authored by amccarth). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79914: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79914/new/ https://reviews.llvm.org/D79914

[PATCH] D78129: Add Marvell ThunderX3T110 support

This revision was automatically updated to reflect the committed changes. Closed by commit rG382d3a85e2a9: [AARch64] Add Marvell ThunderX3T110 support (authored by wxz2020, committed by joelkevinjones). Changed prior to commit: https://reviews.llvm.org/D78129?vs=263582=263896#toc Repository:

[clang] a549c0d - Fix template class debug info for Visual Studio visualizers

Author: Adrian McCarthy Date: 2020-05-13T14:20:18-07:00 New Revision: a549c0d00486bf01cb485e343d778fe4a3649a43 URL: https://github.com/llvm/llvm-project/commit/a549c0d00486bf01cb485e343d778fe4a3649a43 DIFF:

[PATCH] D79914: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple.

huihuiz created this revision. huihuiz added reviewers: efriedma, ekatz, rjmccall, rsmith, luismarques. huihuiz added a project: LLVM. Herald added subscribers: cfe-commits, jfb, kristof.beyls. Herald added a project: clang. Use explicit target triple to match more accurately the output for

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

craig.topper added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2632 +.. option:: -mseses, -mno-seses + This file is in alphabetical order and is normally generated by a running clang-tblgen. See comment at the top of the file.

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

mattdr added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:248-249 + def warn_slh_does_not_support_gcc_asm_goto : Warning< +"speculative load hardening does not support use of GCC asm goto. asm goto " +"detected with SLH">,

[PATCH] D79914: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd842d362662: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple. (authored by huihuiz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

mehdi_amini added a comment. LGTM, probably want @pcc to approve as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79919/new/ https://reviews.llvm.org/D79919 ___ cfe-commits mailing list

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

rjmccall added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79631/new/ https://reviews.llvm.org/D79631 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 1b7bf1b - [HIP] Do not emit debug info for stub function

Author: Yaxun (Sam) Liu Date: 2020-05-13T17:55:40-04:00 New Revision: 1b7bf1bd75dcc4a362a83e4abc1200aaa75a38be URL: https://github.com/llvm/llvm-project/commit/1b7bf1bd75dcc4a362a83e4abc1200aaa75a38be DIFF:

  1   2   >