[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcc0c894f38f: Add cet.h for writing CET-enabled assembly code (authored by xiangzhangllvm). Changed prior to commit: https://reviews.llvm.org/D79617?vs=264772=264799#toc Repository: rG LLVM Github

[PATCH] D80154: [AST] Fix recovery-AST crash: dependent overloaded call exprs are now possible.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80154/new/ https://reviews.llvm.org/D80154

[PATCH] D80015: [Analyzer][StreamChecker] Added support for 'fread' and 'fwrite'.

balazske added a comment. If the unit of the change is adding `fread` and `fwrite` completely, the warning with FEOF at `fread` is correct to add because it belongs to `fread`. I was planning to add some file handling functions to the checker that have a basic functionality implemented. In

[PATCH] D80174: [WebAssembly] Implement i64x2.mul and remove i8x16.mul

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:690 defm "" : SIMDBinary; } Can we delete this now then?

[clang] bcc0c89 - Add cet.h for writing CET-enabled assembly code

Author: Xiang1 Zhang Date: 2020-05-19T14:03:17+08:00 New Revision: bcc0c894f38fd8b43af521e356a167b1a12dd497 URL: https://github.com/llvm/llvm-project/commit/bcc0c894f38fd8b43af521e356a167b1a12dd497 DIFF: https://github.com/llvm/llvm-project/commit/bcc0c894f38fd8b43af521e356a167b1a12dd497.diff

[clang] dbb0349 - Add support of the next Ubuntu (Ubuntu 20.10 - Groovy Gorilla)

Author: Sylvestre Ledru Date: 2020-05-19T08:30:25+02:00 New Revision: dbb034947cc16d26164be1e78d95249d60738dc6 URL: https://github.com/llvm/llvm-project/commit/dbb034947cc16d26164be1e78d95249d60738dc6 DIFF:

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

MyDeveloperDay added a comment. In D80144#2042926 , @JakeMerdichAMD wrote: > This is a great improvement in readability. I think this will get in here > before it does for clang proper :D > > Likely/unlikely also seem to be supported on while, do-while,

[clang] d94bacb - [WebAssembly] Handle exception specifications

Author: Heejin Ahn Date: 2020-05-19T01:16:09-07:00 New Revision: d94bacbcf87a06abc0c1fc3405406399460debc3 URL: https://github.com/llvm/llvm-project/commit/d94bacbcf87a06abc0c1fc3405406399460debc3 DIFF: https://github.com/llvm/llvm-project/commit/d94bacbcf87a06abc0c1fc3405406399460debc3.diff

[clang] 4c09289 - [clang] Add an API to retrieve implicit constructor arguments.

Author: Martin Böhme Date: 2020-05-19T09:21:26+02:00 New Revision: 4c09289f635c4291c41fe4396afba4ba839d265b URL: https://github.com/llvm/llvm-project/commit/4c09289f635c4291c41fe4396afba4ba839d265b DIFF: https://github.com/llvm/llvm-project/commit/4c09289f635c4291c41fe4396afba4ba839d265b.diff

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added subscribers: Abpostelnicu, sylvestre.ledru. MyDeveloperDay added a comment. This is totally fine, now I'm just concerned by the choice of defaults, I really don't know if we want to change the defaults for all the styles, I don't want to break all those people using it One

[PATCH] D80160: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for remembering this :D Comment at: clang/test/Tooling/fixed-database.cpp:6 // RUN: cp "%S/Inputs/fixed-header.h" "%t/Include/" +// RUN: echo '# this is a

[PATCH] D79942: [clang] Add an API to retrieve implicit constructor arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c09289f635c: [clang] Add an API to retrieve implicit constructor arguments. (authored by mboehme, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

This revision was automatically updated to reflect the committed changes. Closed by commit rG51bb2128ef03: [Analyzer][VLASizeChecker] Check for VLA size overflow. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79330/new/

[clang] 48aa781 - [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

Author: Sam McCall Date: 2020-05-19T11:20:02+02:00 New Revision: 48aa781ae44a611967084ca031fdbb3a0712c40c URL: https://github.com/llvm/llvm-project/commit/48aa781ae44a611967084ca031fdbb3a0712c40c DIFF: https://github.com/llvm/llvm-project/commit/48aa781ae44a611967084ca031fdbb3a0712c40c.diff

[clang] 51bb212 - [Analyzer][VLASizeChecker] Check for VLA size overflow.

Author: Balázs Kéri Date: 2020-05-19T09:44:46+02:00 New Revision: 51bb2128ef03985fddf2a84f17d3276f4ae2c6ad URL: https://github.com/llvm/llvm-project/commit/51bb2128ef03985fddf2a84f17d3276f4ae2c6ad DIFF: https://github.com/llvm/llvm-project/commit/51bb2128ef03985fddf2a84f17d3276f4ae2c6ad.diff

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev marked 2 inline comments as done. hyd-dev added a comment. Any reply? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79967: Fix debug info for NoDebug attr

djtodoro added a comment. This seems reasonable, so this change looks good to me! @dblaikie Thanks for pointing out to the potential problems of the usage of the func decl !dbg in the purpose of call sites debug info. It is currently being stored into CU's retainedTypes field. > That's why

[PATCH] D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. The LGTM (nit: clang-format) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80176/new/ https://reviews.llvm.org/D80176

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

klimek added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:46-49 +enum class MatchDirection { + Ancestors, + Descendants +}; loic-joly-sonarsource wrote: > klimek wrote: > > Nice find! Why don't we need more states though? > > 1.

[PATCH] D80061: [WebAssembly] Handle exception specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rGd94bacbcf87a: [WebAssembly] Handle exception specifications (authored by aheejin). Changed prior to commit: https://reviews.llvm.org/D80061?vs=264466=264821#toc Repository: rG LLVM Github Monorepo

[clang] 1d579f5 - [AST] Fix recovery-AST crash: dependent overloaded call exprs are now possible.

Author: Sam McCall Date: 2020-05-19T11:11:09+02:00 New Revision: 1d579f54d720dcc53e11386fdec59e07614599a5 URL: https://github.com/llvm/llvm-project/commit/1d579f54d720dcc53e11386fdec59e07614599a5 DIFF: https://github.com/llvm/llvm-project/commit/1d579f54d720dcc53e11386fdec59e07614599a5.diff

[PATCH] D80160: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/test/Tooling/fixed-database.cpp:6 // RUN: cp "%S/Inputs/fixed-header.h" "%t/Include/" +// RUN: echo '# this is a comment' >> %t/compile_flags.txt // -I flag is relative to %t (where

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D79992 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80198 Files:

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

miscco added a comment. Awesome, Thank you very much, I dragged my feet on starting to implement something for real. As a high level comment I think we need to handle requires expressions to get this correct, as `requires requires` would otherwise to bad things. From my early brainstorming i

[PATCH] D80160: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG48aa781ae44a: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines (authored by sammccall). Changed prior to commit:

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos updated this revision to Diff 264827. nigelp-xmos added a comment. As suggested by FIXME comment in code, and review comment, moved the EmitTargetMetadata loop into XCore target. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 264839. MarcusJohnson91 added a comment. Ok, I've removed the inherited ones, and also removed the times I was setting a style when there wasn't one before. also I moved the `IEBS_AfterExternBlock` line to right underneath the

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay planned changes to this revision. MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3499 return true; if (Right.Previous->ClosesTemplateDeclaration &&

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 marked 4 inline comments as done. MarcusJohnson91 added inline comments. Comment at: clang/lib/Format/Format.cpp:714 case FormatStyle::BS_Mozilla: +Expanded.IndentExternBlock = FormatStyle::IEBS_AfterExternBlock; Expanded.BraceWrapping.AfterClass =

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

melver added a comment. This seems to be causing problems for the Linux kernel with ASan instrumentation enabled: https://lkml.kernel.org/r/20200518180513.ga114...@google.com Still investigating if it's the kernel, KASAN, or Clang that's doing something wrong. Any pointers welcome. Many

[clang-tools-extra] e408b54 - [clangd] Fix gcc compiler warning by removing extra ";" [NFC]

Author: Mikael Holmen Date: 2020-05-19T11:57:15+02:00 New Revision: e408b54290bd5dc35b02ef4270292d52c89d9751 URL: https://github.com/llvm/llvm-project/commit/e408b54290bd5dc35b02ef4270292d52c89d9751 DIFF: https://github.com/llvm/llvm-project/commit/e408b54290bd5dc35b02ef4270292d52c89d9751.diff

[clang] 56079e1 - [Analyzer][VLASizeChecker] Try to fix vla.c test problems.

Author: Balázs Kéri Date: 2020-05-19T12:12:28+02:00 New Revision: 56079e1de1129837aa7569d8b3bb5e50afc0f1ea URL: https://github.com/llvm/llvm-project/commit/56079e1de1129837aa7569d8b3bb5e50afc0f1ea DIFF: https://github.com/llvm/llvm-project/commit/56079e1de1129837aa7569d8b3bb5e50afc0f1ea.diff

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

miscco added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3499 return true; if (Right.Previous->ClosesTemplateDeclaration && Right.Previous->MatchingParen && I think that your change should actually come in here where we

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

sammccall added a subscriber: ABataev. sammccall added a comment. This seems vaguely reasonable to me, but I don't really know what an OpenMP capture is. @ABataev, @jdoerfert : Any thoughts or concerns here? Some context: an expression that contains errors can exist after certain types of

[PATCH] D80015: [Analyzer][StreamChecker] Added support for 'fread' and 'fwrite'.

balazske updated this revision to Diff 264843. balazske marked 5 inline comments as done. balazske added a comment. Renamed "Count" to "NMemb", fixed `operator !=`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80015/new/

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80200/new/ https://reviews.llvm.org/D80200

[PATCH] D79921: [OPENMP] Fix mixture of omp and clang pragmas

hishiguro updated this revision to Diff 264836. hishiguro retitled this revision from "[OpenMP] Fix omp and clang pragmas" to "[OPENMP] Fix mixture of omp and clang pragmas". hishiguro added a comment. Herald added a reviewer: a.sidorin. I checked that your comments are correct. I modified the

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

Szelethus added a comment. In D75430#2028456 , @NoQ wrote: > Sorry i'm not very responsive these days >.< No worries, thanks! ^-^ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1052 +/// This is a call

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry for the delay. I think this is good though I have a nagging feeling I don't understand all the implications yet :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D79930: [clangd] Add buildPreamble to TestTU

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/TestTU.h:71 ParsedAST build() const; + std::shared_ptr buildPreamble() const; ParseInputs inputs() const;

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

njames93 created this revision. njames93 added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. A simple optimization to avoid unnecessary copies of BoundNodesTreeBuilders when querying the cache for memoized matchers. This hasn't been benchmarked as I'm

[PATCH] D80154: [AST] Fix recovery-AST crash: dependent overloaded call exprs are now possible.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d579f54d720: [AST] Fix recovery-AST crash: dependent overloaded call exprs are now possible. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay marked 6 inline comments as done. MyDeveloperDay added a subscriber: STL_MSFT. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1566 Current.Type = TT_TrailingReturnArrow; - +} else if (Current.is(tok::arrow) &&

[PATCH] D78990: [analyzer] Allow bindings of the CompoundLiteralRegion

vsavchenko updated this revision to Diff 264831. vsavchenko added a comment. Fix code review remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78990/new/ https://reviews.llvm.org/D78990 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. With recovery expr, it is possible that we have a value-dependent expr within non-dependent context. Repository: rG

[clang-tools-extra] 032727f - [clangd] Complete filenames after < / ".

Author: Sam McCall Date: 2020-05-19T13:32:26+02:00 New Revision: 032727f4f839a28ae449d2f38814857780c7453d URL: https://github.com/llvm/llvm-project/commit/032727f4f839a28ae449d2f38814857780c7453d DIFF: https://github.com/llvm/llvm-project/commit/032727f4f839a28ae449d2f38814857780c7453d.diff

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. All this confusion over the defaults is because we don't have the unit tests to check the default of each style. If we had that we could have a before/after conversation more easily Nit: also please mark comments done once you have addressed them.

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. > btw, in .BraceWrapping = {true, false); blocks, AfterExternBlock is the 9th > option, I checked the BraceWrapping enum. This will become clearer I hope when I land D79325: [clang-format] [PR42164] Add Option to Break before While

[PATCH] D79921: [OPENMP] Fix mixture of omp and clang pragmas

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1735 + // If attributes are attached, push to the basic block with them. + const OMPExecutableDirective *OMPED = dyn_cast(); + const CapturedStmt *ICS = OMPED->getInnermostCapturedStmt();

[clang-tools-extra] 61559d0 - [clangd] Squash GCC error with StringRef + gtest MatchesRegex()

Author: Sam McCall Date: 2020-05-19T13:58:23+02:00 New Revision: 61559d045868e3980deca6cf5d30ad8816951960 URL: https://github.com/llvm/llvm-project/commit/61559d045868e3980deca6cf5d30ad8816951960 DIFF: https://github.com/llvm/llvm-project/commit/61559d045868e3980deca6cf5d30ad8816951960.diff

[clang-tools-extra] 6e99199 - Fix "not all control paths return a value" warning on MSVC builds.

Author: Simon Pilgrim Date: 2020-05-19T13:16:24+01:00 New Revision: 6e99199419d95f39ae9d8a11d8632caac7b405b4 URL: https://github.com/llvm/llvm-project/commit/6e99199419d95f39ae9d8a11d8632caac7b405b4 DIFF: https://github.com/llvm/llvm-project/commit/6e99199419d95f39ae9d8a11d8632caac7b405b4.diff

[clang-tools-extra] 9b88a19 - [clangd] Add CSV export for trace metrics

Author: Sam McCall Date: 2020-05-19T13:35:31+02:00 New Revision: 9b88a190b42a03753b9c49ccea34514cb40ba4ab URL: https://github.com/llvm/llvm-project/commit/9b88a190b42a03753b9c49ccea34514cb40ba4ab DIFF: https://github.com/llvm/llvm-project/commit/9b88a190b42a03753b9c49ccea34514cb40ba4ab.diff

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay updated this revision to Diff 264851. MyDeveloperDay added a comment. Move break before concept into correct clause Add `requires requires` test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 Files:

[PATCH] D79992: [WIP][clangd] Patch PP directives to use stale preambles while building ASTs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:419 + if (DirectivesChanged) { +// We need to patch all the directives, since they are order dependent. e.g: +// #define BAR(X) NEW(X) // Newly introduced in Modified

[PATCH] D79678: [clangd] Add CSV export for trace metrics

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b88a190b42a: [clangd] Add CSV export for trace metrics (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79678/new/

[PATCH] D78454: [clangd] Highlight related control flow.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:907 +// Highlight the loop keyword itself. +Result.push_back(P->ASTNode.getSourceRange().getBegin()); +

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. Sorry to "go around the houses" but we'll get there in the end...I think we are close CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits mailing list

[PATCH] D79456: [clangd] Complete filenames after < / ".

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG032727f4f839: [clangd] Complete filenames after / . (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2e5e42d - [analyzer][MallocChecker] When modeling realloc-like functions, don't early return if the argument is symbolic

Author: Kirstóf Umann Date: 2020-05-19T13:59:29+02:00 New Revision: 2e5e42d4aeab98636346db558e89ab9b122c9dc3 URL: https://github.com/llvm/llvm-project/commit/2e5e42d4aeab98636346db558e89ab9b122c9dc3 DIFF: https://github.com/llvm/llvm-project/commit/2e5e42d4aeab98636346db558e89ab9b122c9dc3.diff

[PATCH] D80015: [Analyzer][StreamChecker] Added support for 'fread' and 'fwrite'.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This patch is great. LGTM! In D80015#2043263 , @balazske wrote: > If the unit of the change is adding `fread` and `fwrite` completely, the >

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko updated this revision to Diff 264863. vsavchenko added a comment. Fix code review remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/new/ https://reviews.llvm.org/D80117 Files:

[PATCH] D79415: [analyzer][MallocChecker] When modeling realloc-like functions, don't early return if the argument is symbolic

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e5e42d4aeab: [analyzer][MallocChecker] When modeling realloc-like functions, dont early… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

miscco added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2281 + if (FormatTok->Tok.is(tok::kw_requires)) +parseRequires(); +} I believe this should be `parseConstraintExpression` because that is the term of art in the standard.

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

miscco added a comment. You are missing to check the boolean in `CHECK_PARSE_BOOL` in FormatTest.cpp Comment at: clang/lib/Format/TokenAnnotator.cpp:1566 Current.Type = TT_TrailingReturnArrow; - +} else if (Current.is(tok::arrow) && Current.Previous && +

[clang] 2e499ee - [OPENMP50]Add initial support for 'affinity' clause.

Author: Alexey Bataev Date: 2020-05-19T08:19:09-04:00 New Revision: 2e499eee5884456f3dd068662ee1785f24bd88cc URL: https://github.com/llvm/llvm-project/commit/2e499eee5884456f3dd068662ee1785f24bd88cc DIFF: https://github.com/llvm/llvm-project/commit/2e499eee5884456f3dd068662ee1785f24bd88cc.diff

[PATCH] D72531: Set traversal explicitly where needed in tests

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/unittests/Tooling/StencilTest.cpp:63 ASTContext = AstUnit->getASTContext(); - auto Matches =

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

xazax.hun added inline comments. Comment at: clang/test/Analysis/loop-unrolling.cpp:503 + +void arg_as_loop_counter(int i) { + for (i = 0; i < 10; ++i) { nit: we usually use `arg` for actual arguments at the call site, and use `param` for formal parameters.

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

xazax.hun added reviewers: NoQ, vsavchenko. xazax.hun added a comment. Thanks for finding this bug! Adding some reviewers. I think it would be perfectly fine to unroll loops where the loop counter is a pass-by-value parameter. That should not be considered escaped. I think in case of

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

grandinj added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:78 + const BoundNodesTreeBuilder + const TraversalKind Traversal; + note that making fields const tends to disable various move optimisations, so better to mark the whole

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:633 + + // Check if LHS is 0. It's a special case when the result is guaranteed + // to be 0 no matter what RHS is (we put to the side the case when RHS is I

[PATCH] D80148: [OPENMP50]Add initial support for 'affinity' clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e499eee5884: [OPENMP50]Add initial support for affinity clause. (authored by ABataev). Herald added a subscriber: sstefan1. Changed prior to commit:

[clang] 2395431 - [AST][RecoveryExpr] Fix an assertion crash on openMP.

Author: Haojian Wu Date: 2020-05-19T15:09:26+02:00 New Revision: 23954318f49f1b96cb5c4b76921bea4f7ac0d5f3 URL: https://github.com/llvm/llvm-project/commit/23954318f49f1b96cb5c4b76921bea4f7ac0d5f3 DIFF: https://github.com/llvm/llvm-project/commit/23954318f49f1b96cb5c4b76921bea4f7ac0d5f3.diff

[clang] 6f56599 - [AST] Fix the PrintQualifiedName for ObjC instance variable in class extension.

Author: Haojian Wu Date: 2020-05-19T15:17:36+02:00 New Revision: 6f56599c14af0a4b7a4d4b2c4f6ae44bc2754c0c URL: https://github.com/llvm/llvm-project/commit/6f56599c14af0a4b7a4d4b2c4f6ae44bc2754c0c DIFF: https://github.com/llvm/llvm-project/commit/6f56599c14af0a4b7a4d4b2c4f6ae44bc2754c0c.diff

[clang-tools-extra] 0320ce8 - [clangd] Add a flag to preserve type for recovery expression.

Author: Haojian Wu Date: 2020-05-19T15:21:57+02:00 New Revision: 0320ce8916a815d10a0449f5581e0f3ca7183922 URL: https://github.com/llvm/llvm-project/commit/0320ce8916a815d10a0449f5581e0f3ca7183922 DIFF: https://github.com/llvm/llvm-project/commit/0320ce8916a815d10a0449f5581e0f3ca7183922.diff

[clang] e4e1080 - [analyzer][Nullability] Don't emit under the checker name NullabilityBase

Author: Kirstóf Umann Date: 2020-05-19T17:04:06+02:00 New Revision: e4e1080a5837e4a4f38c46b9974f2b2402bb021a URL: https://github.com/llvm/llvm-project/commit/e4e1080a5837e4a4f38c46b9974f2b2402bb021a DIFF: https://github.com/llvm/llvm-project/commit/e4e1080a5837e4a4f38c46b9974f2b2402bb021a.diff

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 264926. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Fix the linkage types; Adjust the formatting; Update the testcase; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/

[clang] 575c59c - [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

Author: mydeveloperday Date: 2020-05-19T16:47:38+01:00 New Revision: 575c59cf6a32889c5f1131af39e07bbdde27e8da URL: https://github.com/llvm/llvm-project/commit/575c59cf6a32889c5f1131af39e07bbdde27e8da DIFF:

Re: [clang-tools-extra] 9b88a19 - [clangd] Add CSV export for trace metrics

Sorry about that Matthew, I think 5bc0c8f009261425a should have fixed this (giving up on stringview entirely). It fixed the other windows based bots. If it's no good, please do revert if you can, I'll check on it shortly too. On Tue, May 19, 2020, 6:14 PM Voss, Matthew wrote: > Hi Sam, > >

[clang] 500479d - [analyzer][DirectIvarAssignment] Turn DirectIvarAssignmentForAnnotatedFunctions into a checker option

Author: Kirstóf Umann Date: 2020-05-19T15:41:43+02:00 New Revision: 500479dba33ae03644313e34d10c013371b5215b URL: https://github.com/llvm/llvm-project/commit/500479dba33ae03644313e34d10c013371b5215b DIFF: https://github.com/llvm/llvm-project/commit/500479dba33ae03644313e34d10c013371b5215b.diff

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

jdoerfert added a comment. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80200/new/ https://reviews.llvm.org/D80200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80211: [analyzer] SATestBuild.py: Optionally override compiler

vsavchenko added a comment. I agree, but I think we should refactor a bit how we process command line arguments before that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80211/new/ https://reviews.llvm.org/D80211

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Sorry about the hassle with the tests. Comment at: clang-tools-extra/clangd/unittests/remote/CMakeLists.txt:2 +set(LLVM_LINK_COMPONENTS + Support + )

[PATCH] D80211: [analyzer] SATestBuild.py: Optionally override compiler

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. NoQ accepted this revision. NoQ

[PATCH] D80211: [analyzer] SATestBuild.py: Optionally override compiler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ideally we should be able to control it on per-project basis(?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80211/new/

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. This is what I was thinking about D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791

[PATCH] D80212: [clangd] Handle references for patched macros

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D80198 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80212 Files:

[clang] 5d82cb3 - [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

Author: mydeveloperday Date: 2020-05-19T16:50:24+01:00 New Revision: 5d82cb3c3a6af8d12b87bcbdc6abd3b7f4b01652 URL: https://github.com/llvm/llvm-project/commit/5d82cb3c3a6af8d12b87bcbdc6abd3b7f4b01652 DIFF:

Re: [clang-tools-extra] 9b88a19 - [clangd] Add CSV export for trace metrics

Hi Sam, This commit's tests are failing to compile on the PS4 Windows bot and our internal CI. Could you take a look? Just FYI, I may end up reverting this after an hour or so to unclog our CI. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32433

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. Thanks, Just sent Tom an email. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___ cfe-commits mailing list

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

stefanp accepted this revision as: stefanp. stefanp added a comment. Other than the two missing `K`s in the test case as Amy pointed out LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77542/new/ https://reviews.llvm.org/D77542

[PATCH] D78121: [analyzer][DirectIvarAssignment] Turn DirectIvarAssignmentForAnnotatedFunctions into a checker option

Szelethus added a comment. Taking a look as I'm speaking! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78121/new/ https://reviews.llvm.org/D78121 ___ cfe-commits mailing list

[PATCH] D79576: [AST] Fix the PrintQualifiedName for ObjC instance variable in class extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f56599c14af: [AST] Fix the PrintQualifiedName for ObjC instance variable in class extension. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

JakeMerdichAMD accepted this revision. JakeMerdichAMD added a comment. This revision is now accepted and ready to land. LGTM assuming CI tests pass. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80144/new/ https://reviews.llvm.org/D80144

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

This revision was automatically updated to reflect the committed changes. Closed by commit rG23954318f49f: [AST][RecoveryExpr] Fix an assertion crash on openMP. (authored by hokein). Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. In D75791#2043758 , @MyDeveloperDay wrote: > Sorry to "go around the houses" but we'll get there in the end...I think we > are close I think we're close too. Your other comment was interesting, about testing the

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 marked 5 inline comments as done. MarcusJohnson91 added inline comments. Comment at: clang/lib/Format/Format.cpp:812 true, true}; + LLVMStyle.IndentExternBlock = FormatStyle::IEBS_AfterExternBlock;

[PATCH] D79938: [clangd] Add a flag to preserve type for recovery expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0320ce8916a8: [clangd] Add a flag to preserve type for recovery expression. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79938/new/

[PATCH] D79678: [clangd] Add CSV export for trace metrics

thakis added a comment. This broke tests on Windows: http://45.33.8.238/win/15539/step_9.txt Please take a look, and revert if it takes a while to investigate. (I'll note that the presubmit bot now has a win/msvc bot that failed compile and reported this on this review before it got merged:

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/remote/CMakeLists.txt:2 +set(LLVM_LINK_COMPONENTS + Support + ) kbobyrev wrote: > sammccall wrote: > > Can we conditionally include these tests into the main ClangdTests, instead >

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

vsavchenko added a comment. Thanks for taking your time to find and resolve the bug. I agree that this solution seems a bit too harsh. Technically there is no difference between local variable declaration and a parameter declaration (if we are talking about value types as pointed out by

  1   2   3   >