[PATCH] D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils

NoQ added a comment. > Reverted in 1108f5c737dbdab0277874a7e5b237491839c43a > for now. Uh-oh. Thank you for reverting! > Project-specific checks like this usually go in clang-tidy, not in the static > analyzer (which ships

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. This record is constructed by hashing the bytes of the AST block in a similiar fashion to the SIGNATURE record. This new signature only means anything if

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

fpetrogalli added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:2198 +static void emitNeonTypeDefs(const std::string& types, raw_ostream ) { + std::string TypedefTypes(types); stuij wrote: > fpetrogalli wrote: > > Is this related to the

[PATCH] D79993: Place control block after AST block in PCM files (Patch series 1/3)

dang abandoned this revision. dang added a comment. Herald added a subscriber: sstefan1. After some further discussion offline with @Bigcheese the cleaner course of action is to make the AST block relocatable see revision D80383 Repository: rG LLVM Github

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay added a comment. > As @MyDeveloperDay said, I'd like it mean C++ only. I find it confusing that > it means C++ or ObjC (even if the latter is a superset of the former). I'd > rather see it spelt as `isCppOrObjC()` even if it's verbose but at least > removes all confusion IMO.

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

dang abandoned this revision. dang added a comment. This revision is superseded by D80383 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79998/new/ https://reviews.llvm.org/D79998

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

tra added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1418 + /// Whether floating point atomic fetch add/sub is supported. + virtual bool isFPAtomicFetchAddSubSupported() const { return false; } + I think it should be predicated on

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

ctetreau updated this revision to Diff 265542. ctetreau added a comment. address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80323/new/ https://reviews.llvm.org/D80323 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:1069 + /// qualifiers. + bool isAddressSpaceOverlapping(const QualType ) const { +Qualifiers Q = getQualifiers(); rjmccall wrote: > It's

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang marked 6 inline comments as done. LukeZhuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1805 +const Expr *ProbArg = TheCall->getArg(2); +if (ProbArg->isValueDependent()) + return ExprError(); erichkeane wrote: >

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. I've responded to the llvmdev thread, which I missed before. I would like us to hold off on this line or work until we come to a resolution there. Repository: rG LLVM Github

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay created this revision. MaskRay added reviewers: aprantl, dblaikie, echristo, JDevlieghere, jhenderson, probinson, thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. RFC: http://lists.llvm.org/pipermail/cfe-dev/2020-May/065430.html Agreement from GCC:

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2204 +if (CGM.getCodeGenOpts().OptimizationLevel == 0) + return RValue::get(ArgValue); + erichkeane wrote: > Do you still need to evaluate this for side-effects even when

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 265530. dang added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, ormris. Formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

ctetreau added a comment. In D80323#2048457 , @rjmccall wrote: > I'm sympathetic to wanting to get rid of the boolean flag, but this is a > really invasive change for pretty minimal benefit. Why not leave > `VectorType::get` as meaning a non-scalable

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

rjmccall added a comment. Please add a C test case just using the address_space attribute. Comment at: clang/include/clang/AST/Type.h:1069 + /// qualifiers. + bool isAddressSpaceOverlapping(const QualType ) const { +Qualifiers Q = getQualifiers(); It's

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

fpetrogalli added a comment. In D80323#2048457 , @rjmccall wrote: > I'm sympathetic to wanting to get rid of the boolean flag, but this is a > really invasive change for pretty minimal benefit. Why not leave > `VectorType::get` as meaning a

[PATCH] D80295: [Sema] Diagnose static data members in classes nested in unnamed classes

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6904 << Name << RD->getTagKind(); Invalid = true; +} else if (RD->isLocalClass()) { john.brawn wrote: > rjmccall wrote: > > This diagnostic actually ignores

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:2416 +" *\n" +" * Permission is hereby granted, free of charge, to any person " +"obtaining a copy\n" stuij wrote: >

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson added inline comments. Comment at: clang/test/CodeGen/arm-mangle-16bit-float.cpp:4 + +// CHECK64: define {{.*}}void @_Z3foou6__bf16(half %b) +// CHECK32: define {{.*}}void @_Z3foou6__bf16(i32 %b.coerce) SjoerdMeijer wrote: > LukeGeeson wrote: > >

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

joerg added a comment. I see that more as a short-coming in the existing DEFAULT_SYSROOT behavior and less an argument for making more cases like it. So the general idea is that for turnkey toolchains, we want to allow customizing the "default" target of the toolchain to hard-code options like

[PATCH] D56456: [Driver] Default to -fno-addrsig on Android.

thakis added a comment. Do we still need this? I was surprised by clang not using faddrsing on Andriod by default. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56456/new/ https://reviews.llvm.org/D56456 ___

[clang] 396bbae - [libTooling][NFC]Fix typo in comment in RangeSelectors

Author: Yitzhak Mandelbaum Date: 2020-05-21T16:13:02-04:00 New Revision: 396bbae41604637008bd5102e1d02d4543f1c3c9 URL: https://github.com/llvm/llvm-project/commit/396bbae41604637008bd5102e1d02d4543f1c3c9 DIFF:

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2197 +const Expr *ProbArg = E->getArg(2); +ProbArg->EvaluateAsFloat(Probability, CGM.getContext()); +llvm::Type *Ty = ConvertType(ProbArg->getType()); You likely need to

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. Fix typos in the summary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov added a comment. @NoQ many thanks. I'll land it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77802/new/ https://reviews.llvm.org/D77802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra added a comment. Great! Can someone take care of merging it? I believe I don't have access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80171/new/ https://reviews.llvm.org/D80171 ___

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 265524. stuij added a comment. addressed review comments, most of all changed license header on the generated bfloat file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708

[PATCH] D56456: [Driver] Default to -fno-addrsig on Android.

danalbert added a comment. The NDK still supports linkers other than LLD, but we are changing the default to LLD in the next release. I'd prefer to keep this for the time being, but don't feel strongly about it. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

bader updated this revision to Diff 265579. bader marked an inline comment as done. bader added a comment. Fix formatting in clang/test/Sema/address_spaces.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80317/new/ https://reviews.llvm.org/D80317

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

joerg added a comment. I do agree with the feature request, but I'm not sure about the implementation. It doesn't seem to work well with the cross-compiling support in the driver as clearly shown by the amount of tests that need patching. Is cross-compiling a concern for you at all? Otherwise

[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

jkorous added a comment. Hi Owen, Do you plan to land the functionality for emitting documentation URLs in clang too? Comment at: clang/lib/Frontend/SerializedDiagnosticReader.cpp:323 + // A documentation URL has an ID and path size. + if (Record.size() != 2) +

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

hubert.reinterpretcast added a comment. In D80300#2049181 , @joerg wrote: > It doesn't seem to work well with the cross-compiling support in the driver > as clearly shown by the amount of tests that need patching. I don't see the test changes as

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2202 +// won't use it for anything. +// Note, we still IRGen ExpectedValue because it could have side-effects. +if (CGM.getCodeGenOpts().OptimizationLevel == 0) erichkeane

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

RKSimon added a comment. Can we add -Wsign-conversion checks to the tests? That was mentioned on PR45931 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80251/new/ https://reviews.llvm.org/D80251 ___ cfe-commits mailing list

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. FYI: I'm more of a clang contributor, so I'm unable to review the LLVM code, hopefully someone will come along who can check on that. Comment at: clang/lib/Sema/SemaChecking.cpp:1805 +const Expr *ProbArg = TheCall->getArg(2); +if

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

dblaikie added a comment. I think it's probably best to keep this subject on the cfe-dev thread until there's agreement there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80391/new/ https://reviews.llvm.org/D80391

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

Quuxplusone added inline comments. Comment at: clang/include/clang/Format/Format.h:1632 + bool isCppOnly() const { return Language == LK_Cpp; } + bool isObjectiveC() const { return Language == LK_ObjC; } + bool isCpp() const { return isCppOnly() || isObjectiveC(); }

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 265535. dang added a comment. Accidently deleted a line in the previous update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/ https://reviews.llvm.org/D80383 Files:

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

jyknight added a comment. It's worrying to me that there number of places in LLVM that at the exact argument value of "-fuse-ld=". E.g. in the windows and PS4 toolchains. We already claim to support arbitrary values and full paths, but if you specify "-fuse-ld=/path/to/lld-link" on Windows

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. I feel like there might something of a concencus forming.. If I take the time to redo following the suggestions @sammccall do you think you could live with it? Comment at:

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

bader updated this revision to Diff 265547. bader added a comment. - Added C test case with address_space attribute. - Move isAddressSpaceOverlapping from PointerType to QualType. - Move C++ test case to clang/test/SemaCXX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

rjmccall added a comment. In D80323#2049374 , @ctetreau wrote: > In D80323#2048457 , @rjmccall wrote: > > > I'm sympathetic to wanting to get rid of the boolean flag, but this is a > > really invasive change for

[clang] 1108f5c - Revert "[Analyzer][WebKit] RefCntblBaseVirtualDtorChecker"

Author: Nico Weber Date: 2020-05-21T15:49:46-04:00 New Revision: 1108f5c737dbdab0277874a7e5b237491839c43a URL: https://github.com/llvm/llvm-project/commit/1108f5c737dbdab0277874a7e5b237491839c43a DIFF: https://github.com/llvm/llvm-project/commit/1108f5c737dbdab0277874a7e5b237491839c43a.diff

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij marked 6 inline comments as done. stuij added inline comments. Comment at: clang/include/clang/Basic/arm_bf16.td:1 +//===--- arm_fp16.td - ARM FP16 compiler interface ===// +// SjoerdMeijer wrote: > typo: fp16 - > bf16? > Here, and

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added a comment. > libomp used to pass until I changed it to us getOrCreateRuntimeFunction I > think. Those tests are flaky, I think. Just run them a few times. I don't expect this to influence them at all. Comment at:

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, it would be great if you could address the two comments I added, before submitting. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10775 - llvm::VectorType

[PATCH] D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils

thakis added a comment. About the patch itself: Project-specific checks like this usually go in clang-tidy, not in the static analyzer (which ships with the compiler binary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77177/new/

[PATCH] D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils

thakis added a comment. This breaks the build everywhere (e.g. http://45.33.8.238/linux/18283/step_4.txt) and has been in for over an hour. Please watch bots after landing. (I think changes that are created more recently automatically get presubmit compile testing on phab.) Reverted in

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

efriedma added a comment. I think the preferred solution is something like https://bugs.llvm.org/show_bug.cgi?id=37545#c4, which is slightly different from both this patch and D46665 . Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. How are you going to pass this non-contiguous data in the runtime? Are you going to map it in a loop or convert this non-contiguous data into the contiguous and map it as a contiguous chunk of data? Your presentation provides interface only interface changes but has

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

hubert.reinterpretcast added a comment. In D80300#2049679 , @joerg wrote: > So the general idea is that for turnkey toolchains, > we want to allow customizing the "default" target of the toolchain to > hard-code options like --sysroot, --target,

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2132 + + assert(!isDependency(Registry, bt.getCheckerName()) && + "Some checkers depend on this

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

stuij added a comment. In D79710#2041418 , @LukeGeeson wrote: > Can you update the commit message in this differential as well please? Same > for the other commits :) done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80369: WIP: [DebugInfo] Remove decl subprograms from 'retainedTypes:'

djtodoro updated this revision to Diff 265481. djtodoro retitled this revision from "[DebugInfo] Remove decl subprograms from 'retainedTypes:'" to "WIP: [DebugInfo] Remove decl subprograms from 'retainedTypes:'". djtodoro added a comment. Still have test failing: Clang ::

[PATCH] D79921: [OPENMP] Fix mixture of omp and clang pragmas

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79921/new/ https://reviews.llvm.org/D79921 ___ cfe-commits mailing list

[clang] 1c8f999 - [analyzer][CallAndMessage] Add checker options for each bug type

Author: Kirstóf Umann Date: 2020-05-21T15:31:37+02:00 New Revision: 1c8f999e0b59731a4214f76528f83e4196e1fcc3 URL: https://github.com/llvm/llvm-project/commit/1c8f999e0b59731a4214f76528f83e4196e1fcc3 DIFF: https://github.com/llvm/llvm-project/commit/1c8f999e0b59731a4214f76528f83e4196e1fcc3.diff

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 265479. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Added TargetInfo::isFPAtomicFetchAddSubSupported to guard fp atomic. CHANGES SINCE LAST

[clang] 361e4f1 - Fix debug info for NoDebug attr

Author: Yaxun (Sam) Liu Date: 2020-05-21T09:02:56-04:00 New Revision: 361e4f14e35981e7498a38ab7c31da7fb7414fb8 URL: https://github.com/llvm/llvm-project/commit/361e4f14e35981e7498a38ab7c31da7fb7414fb8 DIFF:

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

bader updated this revision to Diff 265487. bader added a comment. Enable diagnostics for non-OpenCL modes and applied refactoring proposed by John. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80317/new/ https://reviews.llvm.org/D80317 Files:

[PATCH] D79967: Fix debug info for NoDebug attr

This revision was automatically updated to reflect the committed changes. Closed by commit rG361e4f14e359: Fix debug info for NoDebug attr (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79967/new/

[PATCH] D80295: [Sema] Diagnose static data members in classes nested in unnamed classes

john.brawn updated this revision to Diff 265486. john.brawn marked an inline comment as done. john.brawn added a comment. Use the tag of the anonymous struct when emitting a diagnostic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80295/new/ https://reviews.llvm.org/D80295 Files:

[clang] 3ef1134 - Fix DeferredDiagnosticsEmitter for bug#45987

Author: Yaxun (Sam) Liu Date: 2020-05-21T11:01:40-04:00 New Revision: 3ef11346f391e6e3da0cfa25f9f7dac22771438e URL: https://github.com/llvm/llvm-project/commit/3ef11346f391e6e3da0cfa25f9f7dac22771438e DIFF:

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:483 +__OMP_RTL(__kmpc_push_num_teams, false, /* Void? */ Int32, IdentPtr, Int32, + Int32, Int32) For this one there's

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

bader marked 2 inline comments as done. bader added a comment. Thanks for the review. I've enabled the diagnostics for all the modes. I also applied the refactoring suggested by @rjmccall. Hopefully I understand it correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80295: [Sema] Diagnose static data members in classes nested in unnamed classes

john.brawn added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6904 << Name << RD->getTagKind(); Invalid = true; +} else if (RD->isLocalClass()) { rjmccall wrote: > This diagnostic actually ignores the tag kind that

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl added a comment. Ah, you're right. I don't see the clause in the C11 standard. I'll see what I can do. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945

[PATCH] D77866: [analyzer][CallAndMessage] Add checker options for each bug category

Szelethus marked 4 inline comments as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:66 + // convert these to actual checkers. + enum CheckKind { +CK_FunctionPointer, martong wrote: > So, we

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

curdeius added a comment. I like these changes. I have mixed feelings about `isCpp()` & co. As @MyDeveloperDay said, I'd like it mean C++ only. I find it confusing that it means C++ or ObjC (even if the latter is a superset of the former). I'd rather see it spelt as `isCppOrObjC()` even if it's

[PATCH] D80294: Add support for vmsumudm

saghir added a comment. In D80294#2048049 , @amyk wrote: > I think this overall looks good, but just curious, why was the builtin > support removed? I was hitting some errors with that, so removed it and would add that later on. CHANGES SINCE LAST

[PATCH] D77866: [analyzer][CallAndMessage] Add checker options for each bug category

This revision was automatically updated to reflect the committed changes. Szelethus marked an inline comment as done. Closed by commit rG1c8f999e0b59: [analyzer][CallAndMessage] Add checker options for each bug type (authored by Szelethus). Changed prior to commit:

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:452 CmdArgs.push_back("-dynamic-linker"); - CmdArgs.push_back(Args.MakeArgString(Loader)); + CmdArgs.push_back(Args.MakeArgString(Twine(D.DyldPrefix) + +

<    1   2