[PATCH] D80461: HIP: Try to deal with more llvm package layouts

arsenm closed this revision. arsenm added a comment. 1d96dca9491e3d75c11c3cd1acff5fcda8c2f613 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80461/new/ https://reviews.llvm.org/D80461

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin updated this revision to Diff 265874. BRevzin added a comment. Herald added a subscriber: martong. - A few more changes from tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938 Files:

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin updated this revision to Diff 265875. BRevzin added a comment. - Adding missing return. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938 Files: clang/include/clang/AST/StmtIterator.h

[clang] 1d96dca - HIP: Try to deal with more llvm package layouts

Author: Matt Arsenault Date: 2020-05-23T13:28:24-04:00 New Revision: 1d96dca9491e3d75c11c3cd1acff5fcda8c2f613 URL: https://github.com/llvm/llvm-project/commit/1d96dca9491e3d75c11c3cd1acff5fcda8c2f613 DIFF:

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin marked 2 inline comments as done. BRevzin added a comment. I hadn't build the tests before, updated with a few more changes. Some of the tests require `u8` literals, whose type changes in C++20. I had no idea what to do with that, so I just `#ifdef`-ed out those tests with the

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 265907. pestctrl added a comment. Both extension and extwarn need to be in the c99-extensions group Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files:

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 265908. pestctrl added a comment. Rebase on master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80425/new/ https://reviews.llvm.org/D80425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] e60de8c - Add missing test

Author: Stephen Kelly Date: 2020-05-24T22:50:50+01:00 New Revision: e60de8c825d3087dca26d97985febbf97e179311 URL: https://github.com/llvm/llvm-project/commit/e60de8c825d3087dca26d97985febbf97e179311 DIFF: https://github.com/llvm/llvm-project/commit/e60de8c825d3087dca26d97985febbf97e179311.diff

[clang-tools-extra] 2be92b7 - Fix ignore-traversal to call correct method

Author: Stephen Kelly Date: 2020-05-24T22:33:10+01:00 New Revision: 2be92b7f7e41037e051096df8a9c4de35502c036 URL: https://github.com/llvm/llvm-project/commit/2be92b7f7e41037e051096df8a9c4de35502c036 DIFF: https://github.com/llvm/llvm-project/commit/2be92b7f7e41037e051096df8a9c4de35502c036.diff

[PATCH] D80472: [clangd] Add access specifier information to hover contents

danielmartin updated this revision to Diff 265942. danielmartin added a comment. Move clang::getAccess to Specifiers.h and refactor logic in clang-doc to use that function instead of its own. Also changes where "public", "private" etc. is shown in the hover contents. Now it's shown at the

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

DerWaschbar added a comment. In D79437#2052109 , @aaron.ballman wrote: > Thank you for working on this check, I think it's useful functionality. One > concern I have, though, is that it's not flow-sensitive and should probably > be implemented as a

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

DerWaschbar updated this revision to Diff 265930. DerWaschbar marked 3 inline comments as done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79437/new/ https://reviews.llvm.org/D79437 Files:

[PATCH] D80492: Avoid linking libdl unless needed

mstorsjo added a reviewer: beanz. mstorsjo added a subscriber: beanz. mstorsjo added a comment. I think this is ok, but adding @beanz who knows the cmake conventions better than me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/

[PATCH] D80492: Avoid linking libdl unless needed

thieta created this revision. thieta added a reviewer: mstorsjo. thieta added a project: clang. Herald added subscribers: cfe-commits, mgorny. This fixes cross-compilation when targeting a platform not using libdl and mirrors libdl linking in other parts of the code. Repository: rG LLVM

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. Sounds good - I'll close this one and open three new ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80425/new/ https://reviews.llvm.org/D80425 ___ cfe-commits mailing list

[PATCH] D71155: [analyzer] CERT STR rule checkers: STR30-C

Charusso added a comment. In D71155#1854908 , @NoQ wrote: > Let's separate `CStringChecker` improvements into a separate patch and have a > separate set of tests for it. I was thinking about creating tests, but I cannot figure out any better testing

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso abandoned this revision. Charusso added a comment. Herald added subscribers: ASDenysPetrov, martong, steakhal. Way more sophisticated matching: https://reviews.llvm.org/D77745 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70805/new/ https://reviews.llvm.org/D70805

[PATCH] D80440: [OpenCL] Prevent fused mul and add by default

sepavloff added a comment. Contraction is just an optimization technique. Unless a user explicitly requests strict FP semantics, contraction does not break C++ semantics. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80440/new/ https://reviews.llvm.org/D80440

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

Charusso updated this revision to Diff 265959. Charusso retitled this revision from "[analyzer] CERT: STR31-C" to "[analyzer] CERT STR rule checkers: STR31-C". Charusso added a comment. - Refactor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/

[PATCH] D71155: [analyzer] CERT STR rule checkers: STR30-C

Charusso updated this revision to Diff 265963. Charusso retitled this revision from "[analyzer] CERT: STR30-C" to "[analyzer] CERT STR rule checkers: STR30-C". Charusso added a comment. Herald added subscribers: ASDenysPetrov, martong, steakhal. - Refactor. CHANGES SINCE LAST ACTION

[PATCH] D71033: [analyzer] CERT STR rule checkers: STR32-C

Charusso updated this revision to Diff 265962. Charusso retitled this revision from "[analyzer] CERT: STR32-C" to "[analyzer] CERT STR rule checkers: STR32-C". Charusso added a comment. Herald added subscribers: ASDenysPetrov, martong, steakhal. - Refactor. - State out explicitly whether the

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

MyDeveloperDay added a comment. > I know that we didn't have a test for this in ObjC land, but the regression > seems severe enough to revert this Sure go ahead, that's the process. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80144/new/

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type.cpp:550 + +#if __cplusplus > 201703L /* C++2a and later */ + bernhardmgruber wrote: > How do you want to handle these tests which require

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

sammccall updated this revision to Diff 266059. sammccall marked an inline comment as done. sammccall added a comment. Tweak names, style, comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80296/new/ https://reviews.llvm.org/D80296 Files:

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/test/symbols-modules.test:1 +# Verify that we do not crash and correctly find the definition of a macro that +# was imported from a module and then #undef-ed in preamble. Generally, we prefer

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

sammccall marked 5 inline comments as done. sammccall added a comment. In D80296#2053189 , @adamcz wrote: > Correct me if I'm wrong, but this might lead to a file never being updated in > the index, even after edit, right? > Let's say you have file

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:123 +// Spells directive in \p DirectiveRange while prepending it with \p Prefix. +// Returned string can be used with a #line directive on line \p DirectiveLine > Spells

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

melver updated this revision to Diff 266057. melver added a comment. Add missing -target to sanitize-coverage-bounds test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 Files:

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber updated this revision to Diff 266060. bernhardmgruber added a comment. moved C++20 tests to a new file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 Files:

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

sammccall added a comment. (BTW this looks miles better to me, thanks for persistence!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews.llvm.org/D80198 ___ cfe-commits mailing

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber marked 2 inline comments as done. bernhardmgruber added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type.cpp:550 + +#if __cplusplus > 201703L /* C++2a and later */ + njames93 wrote: >

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266064. serge-sans-paille added a comment. Update profile data hash entries due to hash function update, unless the version used is V1, in which case we keep the buggy behavior for backward compatibility. CHANGES SINCE LAST ACTION

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille reopened this revision. serge-sans-paille added a subscriber: bkramer. serge-sans-paille added a comment. This revision is now accepted and ready to land. @bkramer rightfully reverted this, faster than I could patch it :-) Here is the patch though, with the updated test case.

[PATCH] D79121: Add nomerge statement attribute to clang

zequanwu closed this revision. zequanwu added a comment. landed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79121/new/ https://reviews.llvm.org/D79121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

stevewan updated this revision to Diff 266081. stevewan added a comment. Pass 'clang-format' checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://reviews.llvm.org/D80532 Files: clang/test/Driver/aix-ld.c Index:

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 266085. stuij added a comment. add bfloat header test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/clang/Basic/arm_bf16.td

[clang] 3a2df3b - [Clang][test] fix tests when using external assembler.

Author: Yuanfang Chen Date: 2020-05-25T16:47:50-07:00 New Revision: 3a2df3bad07f7e5fc22538ad782e08ee55f29e41 URL: https://github.com/llvm/llvm-project/commit/3a2df3bad07f7e5fc22538ad782e08ee55f29e41 DIFF: https://github.com/llvm/llvm-project/commit/3a2df3bad07f7e5fc22538ad782e08ee55f29e41.diff

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 266087. Xiangling_L added a comment. Adjust `mangleDynamicDestructor`; Add assertion and FIXME for getUniqueModuleId Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/

[PATCH] D80454: [Clang][test] fix tests when using external assembler

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a2df3bad07f: [Clang][test] fix tests when using external assembler. (authored by ychen). Changed prior to commit: https://reviews.llvm.org/D80454?vs=265792=266088#toc Repository: rG LLVM Github

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay updated this revision to Diff 265847. MyDeveloperDay added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 265848. dang added a comment. This should address the Windows test failure as well as some offline feedback - Ensure that DeclOffset instances can only be read by providing an offset to the AST block - Simplify ASTSignature test by using -fdisable-module-hash

[PATCH] D79800: [Sema] Implement DR2233

tambre updated this revision to Diff 265855. tambre marked an inline comment as done. tambre added a comment. Improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79800/new/ https://reviews.llvm.org/D79800 Files:

[PATCH] D79800: [Sema] Implement DR2233

tambre added a comment. Thanks for the reviews! I believe this now handles all cases and with this we're standards-conforming in regard to DR777 and DR2233. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1987 + +if (Function->getNumParams() >=

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

aaron.ballman added a comment. In D69764#2050226 , @steveire wrote: > I like the approach of using clang-format to implement this. It's much faster > than a `clang-tidy` approach. > > The broader C++ community has already chosen `East`/`West` and it has

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri added a comment. In D80344#2051804 , @tentzen wrote: > > It may be helpful (even for the reviewers) to first specify their behavior, > > instead of writing that after-the-fact "backwardly" based on the > > implementation. > > For reviewers,

[PATCH] D80239: [libTooling] In Transformer, allow atomic changes to span multiple files.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Transformer/Transformer.cpp:65 - for (const auto : Case.AddedIncludes) { -auto = I.first; -switch (I.second) { -

[clang] 2e43bab - [docs] Fix warnings in ConstantInterpreter

Author: Jinsong Ji Date: 2020-05-23T19:36:05Z New Revision: 2e43bab1c161a97df4883def3c4c4a8b92883377 URL: https://github.com/llvm/llvm-project/commit/2e43bab1c161a97df4883def3c4c4a8b92883377 DIFF: https://github.com/llvm/llvm-project/commit/2e43bab1c161a97df4883def3c4c4a8b92883377.diff LOG:

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

dyung added a comment. Hi, we noticed an issue with the GDB test suite that was bisected back to this change and I have put the details in PR46052. Can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76801/new/

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 265949. MyDeveloperDay retitled this revision from "[clang-format] Add Left/Right Const fixer capability" to "[clang-format] Add East/West Const fixer capability". MyDeveloperDay added a comment. Add more test cases Cover more template and namespace

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

steveire updated this revision to Diff 265946. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72534/new/ https://reviews.llvm.org/D72534 Files: clang/docs/ReleaseNotes.rst

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

davidstone added a comment. I noticed the missing return because there is a warning (not as error) that caught it, I think the warning about falling off the end of a non-void-returning function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

jfb accepted this revision. jfb added a comment. One suggestions, otherwise looks good. Thanks for doing this :) Comment at: llvm/include/llvm/ADT/DirectedGraph.h:97 + } + friend bool operator!=(const NodeType , const NodeType ) { !(M == N); } davidstone

[PATCH] D80472: [clangd] Add access specifier information to hover contents

danielmartin marked 6 inline comments as done. danielmartin added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:680 +StringRef getAccessString(AccessSpecifier AS) { + switch (AS) { kadircet wrote: > it is annoying to have this function

[clang] d0da5d2 - Change default traversal in AST Matchers to ignore invisible nodes

Author: Stephen Kelly Date: 2020-05-25T00:18:54+01:00 New Revision: d0da5d2bbe8305d06dc01a98706fd73e11e24a9f URL: https://github.com/llvm/llvm-project/commit/d0da5d2bbe8305d06dc01a98706fd73e11e24a9f DIFF: https://github.com/llvm/llvm-project/commit/d0da5d2bbe8305d06dc01a98706fd73e11e24a9f.diff

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. > I would like to reiterate my discomfort with using East/West as the > identifiers here I'd like to think that I can see it from both angles, @steveire is correct, if I just supply Left/Right then we'll have a

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay planned changes to this revision. MyDeveloperDay added a comment. @steveire I'm still working on this I have just one issue from your lit that is failing (see below), but I wanted to capture the other changes in the review. const Foo>* p = const_cast>*>(); CHANGES SINCE LAST

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:399 - return true; + return; } Non needed. See readability-redundant-control-flow. Comment at:

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2024 + if (!ChecksEnabled[CK_MallocChecker] && !ChecksEnabled[CK_NewDeleteChecker]) { +

[PATCH] D78099: [analyzer][RetainCount] Tie diagnostics to osx.cocoa.RetainCount rather then RetainCountBase, for the most part

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LG! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78099/new/ https://reviews.llvm.org/D78099 ___ cfe-commits mailing list

[clang] 2b8d6fa - Revert "[PGO] Fix computation of function Hash"

Author: Benjamin Kramer Date: 2020-05-25T20:14:28+02:00 New Revision: 2b8d6fa0acacba4dee31ed618a5596414b2279d5 URL: https://github.com/llvm/llvm-project/commit/2b8d6fa0acacba4dee31ed618a5596414b2279d5 DIFF:

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

melver updated this revision to Diff 266054. melver added a comment. -triple -> -target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 Files: clang/lib/Driver/SanitizerArgs.cpp

[clang] 5bf2409 - [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

Author: stevewan Date: 2020-05-25T13:44:15-04:00 New Revision: 5bf2409a4e4d23018ecffe4eff39988a957e76f7 URL: https://github.com/llvm/llvm-project/commit/5bf2409a4e4d23018ecffe4eff39988a957e76f7 DIFF: https://github.com/llvm/llvm-project/commit/5bf2409a4e4d23018ecffe4eff39988a957e76f7.diff

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

ldionne added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-atomic-ops.cu:26 + // CHECK: atomicrmw fsub double* {{.*}} monotonic + return __atomic_fetch_sub(p, 1.0, memory_order_relaxed); +} Nitpick, but this should be `1.0L` to be consistent.

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

melver updated this revision to Diff 266048. melver added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Address failing tests: - Set -triple for test. - Some existing tests now pass under TSAN, and can be enabled. Repository: rG LLVM Github Monorepo

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bf2409a4e4d: [AIX] Add -bcdtors:all:0:s to linker to gather static init functions (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

nemanjai updated this revision to Diff 266092. nemanjai added a comment. Remove handling for explicit `_Complex __float128`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/ https://reviews.llvm.org/D80374 Files:

[PATCH] D80533: [Clang] Enable _Complex __float

nemanjai created this revision. nemanjai added reviewers: rjmccall, rsmith, PowerPC. Herald added a subscriber: kbarton. Herald added a project: clang. When I added `__float128` a while ago, I neglected to add support for the complex variant of the type. This patch just adds that. Repository:

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

nemanjai added a comment. The support for `_Complex __float128` in https://reviews.llvm.org/D80533 I will repurpose leave only the addition of the `KF/KC` modes in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/

[PATCH] D69585: Add option to instantiate templates already in the PCH

rnk added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5610 + if (Args.hasFlag(options::OPT_fpch_instantiate_templates, + options::OPT_fno_pch_instantiate_templates, false)) +CmdArgs.push_back("-fpch-instantiate-templates");

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 265872. tambre marked 4 inline comments as done. tambre added a comment. Remove memcpy overload tests from warn-fortify-source.c, which relied on identifier-based builtin identification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 265871. tambre marked 6 inline comments as done. tambre added a comment. Weakened noexcept checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files:

[PATCH] D69585: Add option to instantiate templates already in the PCH

llunak marked an inline comment as done. llunak added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5610 + if (Args.hasFlag(options::OPT_fpch_instantiate_templates, + options::OPT_fno_pch_instantiate_templates, false)) +

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8880 + } +} + rjmccall wrote: > tambre wrote: > > rjmccall wrote: > > > Hmm. I'm concerned about not doing any sort of semantic compatibility > > > check here before we assign the

[PATCH] D80472: [clangd] Add access specifier information to hover contents

danielmartin created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. danielmartin edited the summary of this revision. For https://github.com/clangd/clangd/issues/382 This commit adds access

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mati865 added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:967 CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) - elseif(LINKER_IS_LLD_LINK) + elseif(LINKER_IS_LLD_LINK AND NOT MINGW)

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay updated this revision to Diff 265885. MyDeveloperDay added a comment. switch function to unsigned CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mstorsjo added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:967 CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) - elseif(LINKER_IS_LLD_LINK) + elseif(LINKER_IS_LLD_LINK AND NOT MINGW)

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

Hi, should we submit this CL, adding the option to prepend classes and struct fully qualified names with "::"? This can then allow people to slowly switch to the new function, and I can close my fix/close my bug in CLIF. I can do more on this CL if it is needed, but I would like to be sure this

[PATCH] D80472: [clangd] Add access specifier information to hover contents

kadircet added a comment. thanks for taking a look at this, this looks great! mostly nits, but the one in tests is important and annoying (it might require you to update some existing cases) Comment at: clang-tools-extra/clangd/Hover.cpp:680 +StringRef

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80425/new/ https://reviews.llvm.org/D80425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 3ed8ebc - Fix return values of some matcher functions

Author: Stephen Kelly Date: 2020-05-24T12:37:44+01:00 New Revision: 3ed8ebc2f6b8172bed48cc5986d3b7af4cfca1bc URL: https://github.com/llvm/llvm-project/commit/3ed8ebc2f6b8172bed48cc5986d3b7af4cfca1bc DIFF: https://github.com/llvm/llvm-project/commit/3ed8ebc2f6b8172bed48cc5986d3b7af4cfca1bc.diff

[PATCH] D69585: Add option to instantiate templates already in the PCH

llunak updated this revision to Diff 265918. llunak edited the summary of this revision. llunak added a comment. Enabled the option by default for clang-cl to match MSVC. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585

[PATCH] D69585: Add option to instantiate templates already in the PCH

llunak marked an inline comment as done. llunak added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5610 + if (Args.hasFlag(options::OPT_fpch_instantiate_templates, + options::OPT_fno_pch_instantiate_templates, false)) +

[clang] 04ed532 - Fix skip-invisible with overloaded method calls

Author: Stephen Kelly Date: 2020-05-24T12:36:16+01:00 New Revision: 04ed532ef0ce76d53ca456cbc581756bb01d30e7 URL: https://github.com/llvm/llvm-project/commit/04ed532ef0ce76d53ca456cbc581756bb01d30e7 DIFF: https://github.com/llvm/llvm-project/commit/04ed532ef0ce76d53ca456cbc581756bb01d30e7.diff

[clang-tools-extra] 5e9392d - Add explicit traversal mode to matchers for implicit constructors

Author: Stephen Kelly Date: 2020-05-24T12:36:15+01:00 New Revision: 5e9392deaf5bfa43846334e9b07a126ae3410a38 URL: https://github.com/llvm/llvm-project/commit/5e9392deaf5bfa43846334e9b07a126ae3410a38 DIFF: https://github.com/llvm/llvm-project/commit/5e9392deaf5bfa43846334e9b07a126ae3410a38.diff

[PATCH] D80486: [clang-format][PR46043] Parse git config w/ implicit values

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80486/new/ https://reviews.llvm.org/D80486

[clang] 72210ce - Fix Wdocumentation warnings after argument renaming. NFC.

Author: Simon Pilgrim Date: 2020-05-24T11:18:20+01:00 New Revision: 72210ce7f57192652414ebbdf9f643f86532d700 URL: https://github.com/llvm/llvm-project/commit/72210ce7f57192652414ebbdf9f643f86532d700 DIFF: https://github.com/llvm/llvm-project/commit/72210ce7f57192652414ebbdf9f643f86532d700.diff

[PATCH] D80490: Check for rule of five and zero.

vrnithinkumar created this revision. vrnithinkumar added reviewers: aaron.ballman, alexfh, jbcoe, dblaikie, rsmith. Herald added subscribers: cfe-commits, kbarton, mgorny, nemanjai. Herald added a project: clang. New check to check if a class defines all special members of none of them. This

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

chandlerc created this revision. Herald added subscribers: cfe-commits, mcrosier. Herald added a project: clang. No idea if this is 'correct' or the right way to fix this, so just sending this mostly as an FYI. Someone who works more closely on the sanitizers might need to take it over and figure

[clang-tools-extra] b752a27 - [clangd] Log use of heuristic go-to-def. NFC

Author: Sam McCall Date: 2020-05-25T10:19:34+02:00 New Revision: b752a2743ab0d24d8da5d97c07fbdb996df78b1f URL: https://github.com/llvm/llvm-project/commit/b752a2743ab0d24d8da5d97c07fbdb996df78b1f DIFF: https://github.com/llvm/llvm-project/commit/b752a2743ab0d24d8da5d97c07fbdb996df78b1f.diff

[clang-tools-extra] 72c5ea1 - [clangd] Enable cross-file-rename by default.

Author: Haojian Wu Date: 2020-05-25T10:46:57+02:00 New Revision: 72c5ea1d73bb89af6f82c14ddb0b7f4c2510bab7 URL: https://github.com/llvm/llvm-project/commit/72c5ea1d73bb89af6f82c14ddb0b7f4c2510bab7 DIFF: https://github.com/llvm/llvm-project/commit/72c5ea1d73bb89af6f82c14ddb0b7f4c2510bab7.diff

[PATCH] D80507: [clangd] Enable cross-file-rename by default.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I suspect we're going to get some complaints from people whose index is perpetually behind and missing files, but this is the tradeoff of the design, we have to accept that or refine

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. Up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80507: [clangd] Enable cross-file-rename by default.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The cross-file rename feature is stable enough to enable it (has been rolled out internally for a few weeks).

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

sammccall added a comment. In D80079#2049459 , @MyDeveloperDay wrote: > I feel like there might something of a concencus forming.. If I take the time > to redo following the suggestions @sammccall do you think you could live with > it? Yeah, LGTM.

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

klimek added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. MyDeveloperDay wrote: > aaron.ballman wrote: > > MyDeveloperDay wrote: > > > klimek wrote: > > >

[PATCH] D79426: [clangd] Change PreambleOnlyAction with content truncation

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:125 auto ContentsBuffer = llvm::MemoryBuffer::getMemBuffer(Contents); + auto Bounds = +

  1   2   3   >