[clang] 9081fa2 - [Analyzer][StreamChecker] Added check for "indeterminate file position".

Author: Balázs Kéri Date: 2020-05-28T08:21:57+02:00 New Revision: 9081fa20991d101728434b354a96283b26495b71 URL: https://github.com/llvm/llvm-project/commit/9081fa20991d101728434b354a96283b26495b71 DIFF: https://github.com/llvm/llvm-project/commit/9081fa20991d101728434b354a96283b26495b71.diff

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

This revision was automatically updated to reflect the committed changes. Closed by commit rG9081fa20991d: [Analyzer][StreamChecker] Added check for indeterminate file position. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D80018?vs=266440=266752#toc Repository:

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale added a comment. In D80315#2058914 , @rjmccall wrote: > In D80315#2058735 , > @michele.scandale wrote: > > > In D80315#2058549 , @rjmccall > > wrote: > >

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. aeubanks added reviewers: vitalybuka, leonardchan. This was attempted once before in https://reviews.llvm.org/D79698, but was reverted due to the coverage pass

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rGd20bf5a7258d: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays (authored by alok, committed by SouraVX). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1138 + if (!wait(Lock, RequestsCV, Timeout, +[&] { return Requests.empty() && !CurrentRequest; })) +return false; I'd consider pulling out an IsIdle lambda

[PATCH] D80668: [Clang][Sanitizers] Expect test failure on {arm,thumb}v7

glider added inline comments. Comment at: clang/test/CodeGen/sanitize-coverage.c:8 +// +// XFAIL: armv7, thumbv7 Is there a Bugzilla entry for this? Please add a link to the code and to the patch description. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D80668: [Clang][Sanitizers] Expect test failure on {arm,thumb}v7

This revision was automatically updated to reflect the committed changes. Closed by commit rG69935d86aed1: [Clang][Sanitizers] Expect test failure on {arm,thumb}v7 (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80668/new/

[PATCH] D79411: [VE] Clang toolchain for VE

simoll added a comment. Ping. Anything i can do to get this reviewed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 ___ cfe-commits mailing list

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

ASDenysPetrov added a comment. I suddenly discovered you unnoticed revision. I'd advise you to add more reviewers or subscribers here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro updated this revision to Diff 266776. djtodoro added a comment. -Tests clean up CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/ https://reviews.llvm.org/D80369 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-info-extern-call.c

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. After an

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Transformer/RewriteRule.cpp:154 +const RewriteRule , +ast_type_traits::TraversalKind DefaultTraversalKind) { // Map the cases into buckets of matchers -- one for each

[clang] 69935d8 - [Clang][Sanitizers] Expect test failure on {arm, thumb}v7

Author: Marco Elver Date: 2020-05-28T11:33:32+02:00 New Revision: 69935d86aed1b691c5f33a2141f15cb3aaee1af6 URL: https://github.com/llvm/llvm-project/commit/69935d86aed1b691c5f33a2141f15cb3aaee1af6 DIFF: https://github.com/llvm/llvm-project/commit/69935d86aed1b691c5f33a2141f15cb3aaee1af6.diff

[clang] d20bf5a - [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

Author: Alok Kumar Sharma Date: 2020-05-28T13:46:41+05:30 New Revision: d20bf5a7258d4b6a7f017a81b125275dac1aa166 URL: https://github.com/llvm/llvm-project/commit/d20bf5a7258d4b6a7f017a81b125275dac1aa166 DIFF:

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. In D80369#2057866 , @dblaikie wrote: > Not sure I follow - why was it a problem that there was no DISubprogram at > all? Actually, since the DISubprograms from the retained types don't affect the final DWARF, it's not a

[PATCH] D80697: [clang-tidy] Reworked TransformerClangTidyCheck to simplify usage of Options

gribozavr2 added a reviewer: ymandel. gribozavr2 added a subscriber: ymandel. gribozavr2 added a comment. @ymandel owns transformers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80697/new/ https://reviews.llvm.org/D80697

[PATCH] D80685: [ASTMatchers] Add traversal-kind support to `DynTypedMatcher`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:234 +DynTypedMatcher::constructWithTraversalKind(DynTypedMatcher InnerMatcher, +

[PATCH] D80668: [Clang][Sanitizers] Expect test failure on {arm,thumb}v7

melver updated this revision to Diff 266773. melver added a comment. Add link to bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80668/new/ https://reviews.llvm.org/D80668 Files: clang/test/CodeGen/sanitize-coverage.c Index:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

whisperity resigned from this revision. whisperity added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:26 +#include "llvm/ADT/Triple.h" +#include "llvm/Option/ArgList.h" #include

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:40-44 + // FIXME(tdl-g): These options are being parsed redundantly with the + // constructor because TransformerClangTidyCheck forces us to provide MakeRule + //

[PATCH] D80697: [clang-tidy] Reworked TransformerClangTidyCheck to simplify usage of Options

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Changed `TransformerClangTidyCheck` to have a virtual method generate the rule. This has the advantages of making handling

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko added a comment. Performance-wise, I've investigated huge slowdowns on `tmux` and `pytorch`. - `pytorch` build produces a lot of warnings and simply trashed my terminal. I guess one time it had more troubles with displaying all that than the other. Here is a table with new times:

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

nemanjai updated this revision to Diff 266820. nemanjai added a comment. Handled invalid uses of `KI` as there is no corresponding integer mode and added testing for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

danielkiss added a comment. Related ticket for gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94891 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 ___ cfe-commits mailing list

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk added a comment. @njames93 and @Eugene.Zelenko do you guys think this patch is ready to be approved and land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llvm.org/D80531

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:101 + + // We always receive FileNotFound followed by InclusionDirective. + // We want the former, so we're completely sure the file was missing. kadircet wrote: > is there

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

nemanjai marked 3 inline comments as done. nemanjai added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3970 + DestWidth = 128; + break; case 'T': rjmccall wrote: > rjmccall wrote: > > Are there interactions with the other mode

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall updated this revision to Diff 266822. sammccall marked 6 inline comments as done. sammccall added a comment. Finally address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77942/new/ https://reviews.llvm.org/D77942 Files:

[PATCH] D80533: [Clang] Enable _Complex __float

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9e94eb8688d: [Clang] Enable _Complex __float128 (authored by nemanjai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80533/new/

[PATCH] D78990: [analyzer] Allow bindings of the CompoundLiteralRegion

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! Comment at: clang/unittests/StaticAnalyzer/StoreTest.cpp:66 -Store StInit = StMgr.getInitialStore(SFC).getStore(); -SVal Zero =

[PATCH] D80508: [AST] Fix the source range for TagDecl if there is no matched } brace.

sammccall added a comment. Argh I never submitted these comments, sorry. Comment at: clang/lib/AST/Decl.cpp:4129 SourceRange TagDecl::getSourceRange() const { - SourceLocation RBraceLoc = BraceRange.getEnd(); - SourceLocation E = RBraceLoc.isValid() ? RBraceLoc :

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal updated this revision to Diff 266794. pdhaliwal marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79400/new/ https://reviews.llvm.org/D79400 Files: llvm/cmake/modules/AddLLVM.cmake

[clang-tools-extra] a56141b - [clangd] Highlight related control flow.

Author: Sam McCall Date: 2020-05-28T13:25:11+02:00 New Revision: a56141b8f9fea112c1ea078c974d91949b6e7a5c URL: https://github.com/llvm/llvm-project/commit/a56141b8f9fea112c1ea078c974d91949b6e7a5c DIFF: https://github.com/llvm/llvm-project/commit/a56141b8f9fea112c1ea078c974d91949b6e7a5c.diff

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

martong added inline comments. Comment at: clang/unittests/StaticAnalyzer/TestReturnValueUnderConstruction.cpp:24 +public: + void checkPostCall(const CallEvent , CheckerContext ) const { +if (!Call.getOriginExpr()) I assume this tests this call expression:

[PATCH] D80704: Remove WrapperMatcherInterface

gribozavr created this revision. Herald added subscribers: cfe-commits, arichardson. Herald added a project: clang. gribozavr2 added a reviewer: ymandel. WrapperMatcherInterface is an abstraction over a member variable -- in other words, not much of an abstraction at all. I think it makes code

[clang] d283fc4 - [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

Author: Sam McCall Date: 2020-05-28T12:30:38+02:00 New Revision: d283fc4f9d07a5f3334fe682ccabfc16e8d2933b URL: https://github.com/llvm/llvm-project/commit/d283fc4f9d07a5f3334fe682ccabfc16e8d2933b DIFF: https://github.com/llvm/llvm-project/commit/d283fc4f9d07a5f3334fe682ccabfc16e8d2933b.diff

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 266799. MyDeveloperDay added a comment. Minor change for the simpler review comments before refactoring some of the more involved ones CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files:

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

This revision was automatically updated to reflect the committed changes. Closed by commit rGd283fc4f9d07: [DebugInfo] Use SplitTemplateClosers (foobarbaz ) in DWARF too (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, so performance regressions on real code weren't real, that's a relief :) > I believe that as of now we can submit these modifications as is and explore > performance optimizations later if

[clang] bd06c41 - [analyzer] Allow bindings of the CompoundLiteralRegion

Author: Valeriy Savchenko Date: 2020-05-28T14:11:57+03:00 New Revision: bd06c417e6c717cbe33b566d7bbaf27fb47e763a URL: https://github.com/llvm/llvm-project/commit/bd06c417e6c717cbe33b566d7bbaf27fb47e763a DIFF:

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

thakis added a comment. This breaks check-llvm on Windows: http://45.33.8.238/win/16214/step_11.txt Please take a look and revert if it takes a while to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80197/new/

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/EastWestConstFixer.cpp:130 + +static void swapFourTokens(const SourceManager , + tooling::Replacements , curdeius

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

krasimir added a comment. In D50078#2053324 , @krasimir wrote: > I'm happy with this patch! > > We found a couple of rough edges: > > - alignment after `?:` and > - new formatting of `_ ? _ ? _ : _ : _` patterns is bad > > These are illustrated as

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet updated this revision to Diff 266814. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80293/new/ https://reviews.llvm.org/D80293 Files:

[PATCH] D78454: [clangd] Highlight related control flow.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGa56141b8f9fe: [clangd] Highlight related control flow. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D78454?vs=264734=266817#toc

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1945 + if (NOT touch_head_result EQUAL 0) +return() + endif() scott.linder wrote: > This seems to implement the behavior that when the log is not present

[PATCH] D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names

mstorsjo added a reviewer: rjmccall. mstorsjo added a comment. Adding some more Apple reviewers on this one - who can give it a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79117/new/ https://reviews.llvm.org/D79117

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, baloghadamsoftware wrote: > baloghadamsoftware

[PATCH] D78990: [analyzer] Allow bindings of the CompoundLiteralRegion

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd06c417e6c7: [analyzer] Allow bindings of the CompoundLiteralRegion (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78990/new/

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet marked 22 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:724 std::move(Req.WantDiags)); +// Set it after notifying ASTPeer about the preamble to prevent any races. +

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

martong added inline comments. Comment at: clang/unittests/StaticAnalyzer/TestReturnValueUnderConstruction.cpp:28 + +Optional RetVal = Call.getReturnValueUnderConstruction(0); +assert(RetVal); How do we know that `0` is the proper block count? CHANGES

[clang] f9e94eb - [Clang] Enable _Complex __float128

Author: Nemanja Ivanovic Date: 2020-05-28T06:55:49-05:00 New Revision: f9e94eb8688d1fe1727360462e957fbbfb754e59 URL: https://github.com/llvm/llvm-project/commit/f9e94eb8688d1fe1727360462e957fbbfb754e59 DIFF:

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

martong added a comment. In D80366#2059765 , @martong wrote: > In this version of the patch you are using `handleConstructionContext` to > "retrieve" or read an SVal for the construction. However, it seems like that > function was designed to store

[PATCH] D80492: Avoid linking libdl unless needed

thieta added a comment. @mstorsjo mind landing this for me as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 ___ cfe-commits mailing list

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

martong added a comment. In this version of the patch you are using `handleConstructionContext` to "retrieve" or read an SVal for the construction. However, it seems like that function was designed to store values in the GDM for individual construction context items. To mix a read-only

[PATCH] D80685: [ASTMatchers] Add traversal-kind support to `DynTypedMatcher`

ymandel updated this revision to Diff 266828. ymandel marked 2 inline comments as done. ymandel added a comment. Herald added a subscriber: mgorny. updated per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80685/new/

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

alok marked an inline comment as done. alok added a comment. In D80197#2059591 , @thakis wrote: > This breaks check-llvm on Windows: http://45.33.8.238/win/16214/step_11.txt > > Please take a look and revert if it takes a while to investigate. Fixed in

[PATCH] D80685: [ASTMatchers] Add traversal-kind support to `DynTypedMatcher`

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:234 +DynTypedMatcher::constructWithTraversalKind(DynTypedMatcher InnerMatcher, +

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:506-507 + /// + /// where abs(Origin) is the maximal absolute value of any possible values + /// from Origin, and min(T)

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

melver added inline comments. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1522 static uint64_t rotateSign(int64_t I) { uint64_t U = I; rotateSign() is no longer used in this file. If there are no plans to use it again, please remove it. Thanks!

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

sylvestre.ledru added a comment. Well done! For Firefox, we decided to go ahead and reformat everything at once. I has been way easier this way. You should run flake8 & autopep8 on your python code. it isn't idomatic Python code (";" are useless on python for example)

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson created this revision. LukeGeeson added reviewers: fpetrogalli, SjoerdMeijer. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. LukeGeeson added a parent revision: D79869: [clang][BFloat] Add reinterpret cast

[PATCH] D80016: [analyzer] StdLibraryFunctionsChecker: Add support to lookup types

martong updated this revision to Diff 266834. martong marked an inline comment as done. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80016/new/ https://reviews.llvm.org/D80016 Files:

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

ymandel updated this revision to Diff 266831. ymandel added a comment. updated per comments and after rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80606/new/ https://reviews.llvm.org/D80606 Files:

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

ymandel updated this revision to Diff 266835. ymandel marked 2 inline comments as done. ymandel added a comment. typo fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80606/new/ https://reviews.llvm.org/D80606 Files:

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. > I will check tomorrow whether we could remove `DeclRegion` without too much > code duplication. It turns out that `DeclRegion` is used in 7 different checkers plus in `BugReporterVisitor`s. One typical

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

MyDeveloperDay planned changes to this revision. MyDeveloperDay added a comment. I'm running through flake8... almost every line is changing ;-) ...let me update before wasting any more of your time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D78454: [clangd] Highlight related control flow.

On Thu, May 28, 2020 at 4:35 PM Russell Gallop via Phabricator < revi...@reviews.llvm.org> wrote: > russell.gallop added a comment. > > Hi Sam, > > It looks like this is causing a failure on the Windows PS4 buildbot: >

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon marked 2 inline comments as done. Fznamznon added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1727 + + QualType Ty = D->getType(); + auto CheckType = [&](QualType Ty) { jdoerfert wrote: > Nit: Move below `CheckType` to avoid shadowing and

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

martong updated this revision to Diff 266879. martong marked an inline comment as done. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77658/new/ https://reviews.llvm.org/D77658 Files:

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay added a comment. > @MyDeveloperDay , @Typz -- could you please take a look at these two issues > and give your feedback? (E) looks pretty bad. I'm not familiar enough with > this patch to judge how easy / hard would it be to mitigate these. I agree 'E' is a regression from

[clang-tools-extra] 7cfdff7 - [clang-tidy] Add abseil-string-find-str-contains checker.

Author: Tom Lokovic Date: 2020-05-28T12:35:57-04:00 New Revision: 7cfdff7b4a6704b8ef2a1b594e1ec19d2d89f385 URL: https://github.com/llvm/llvm-project/commit/7cfdff7b4a6704b8ef2a1b594e1ec19d2d89f385 DIFF: https://github.com/llvm/llvm-project/commit/7cfdff7b4a6704b8ef2a1b594e1ec19d2d89f385.diff

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. Did you think about implementing it in the compiler instead of the runtime? Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8397-8400 + if (OASE || OAShE || + dyn_cast(I->getAssociatedExpression())) { +DimSize++; + }

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

martong updated this revision to Diff 266918. martong marked 4 inline comments as done. martong added a comment. - Rename: validate -> checkValidity, sanityCheck -> checkSpecificValidity - Rename: Summary::checkValidity -> validateByConstraints - Add more docs to the Summary class - Rename

[PATCH] D80733: [AST][RecoveryExpr] Build RecoveryExpr for "undef_var" cases.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/lib/Sema/SemaExprCXX.cpp:8310 +// to RecoveryExpr. +// FIXME: we lose source locations for RecoveryExpr, as TypoExpr doesn't +//

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. Indeed, I saw the emails, but I didn't have time to check or investigate the issues. As for E, this is more tricky than this. At the moment, the code does not look at what is in the first "branch" of the ternary operator : it does not care if this is a nested ternary

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

martong marked 7 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:697 if (auto *FD = dyn_cast(D)) { - if (S.matchesSignature(FD)) { + if (S.Sign.matches(FD) &&

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 added a comment. In D80222#2060420 , @jdoerfert wrote: > Take a look at D80735 , it works fine for me > locally. Is that what you did? What problems do you observe now? That's pretty much what I did. If I kept

[PATCH] D80221: [AST][RecoveryExpr] Make DeduceAutoType fail if the auto is deduced from recovery exprs.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:4658 bool IgnoreConstraints) { + // FIXME: continue the following steps if the type is

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

JakeMerdichAMD added a comment. Great idea on this! I may borrow this idea and make something similar for some migrations I'm working on. Sanity check: is this going to be run automatically when docs are generated or done offline with results committed? I don't have a preference, either has

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

sylvestre.ledru added inline comments. Comment at: clang/docs/tools/generate_formatted_state.py:48 +if "/test/" in path: +print root +continue print xx is python 2 please use print(xx) Comment at:

[libclc] cf4d4e3 - libclc: Compile with -nostdlib

Author: Matt Arsenault Date: 2020-05-28T10:41:31-04:00 New Revision: cf4d4e366a2165f0e93948f166d76ae650aecc98 URL: https://github.com/llvm/llvm-project/commit/cf4d4e366a2165f0e93948f166d76ae650aecc98 DIFF:

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon updated this revision to Diff 266877. Fznamznon marked 2 inline comments as done. Fznamznon added a comment. Applied comments from Johannes. Fixed failing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/

Re: [PATCH] D78454: [clangd] Highlight related control flow.

Added workaround in 6dd1629770d686831bdb2649650b86c37f0f7091 - will look at disabling tests properly tomorrow. On Thu, May 28, 2020 at 4:55 PM Sam McCall wrote: > On Thu, May 28, 2020 at 4:35 PM Russell Gallop via Phabricator < > revi...@reviews.llvm.org> wrote: > >> russell.gallop added a

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 266921. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. Regarding `?:`, this is definitely not considered, and should be relatively easy to handle. Regarding case `D`, this looks like a bug... The break in the first operand is kind of unexpected (as in "not the usual case"), and I had many such corner cases while making and

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

ymandel added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:286 + + virtual llvm::Optional TraversalKind() const { +return {}; aaron.ballman wrote: > `traversalKind()` Stephen -- What was the resolution on this comment? I

[PATCH] D78454: [clangd] Highlight related control flow.

russell.gallop added a comment. Hi Sam, It looks like this is causing a failure on the Windows PS4 buildbot: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32606 Please could you take a look? PS4 target disables RTTI, hence exceptions, by default so

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall marked 5 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:108 +// (We have some false negatives if PP recovered e.g. -> "foo") +if (File == nullptr) + return; kadircet wrote:

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: openmp/runtime/test/tasking/kmp_taskloop.c:100 th_counter[i] = 0; -#pragma omp parallel num_threads(N) +#pragma omp parallel // num_threads(N) { jhuber6

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall updated this revision to Diff 266868. sammccall marked 2 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77942/new/ https://reviews.llvm.org/D77942 Files:

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 266883. MyDeveloperDay added a comment. That's a rotate! Remove the multiple swap functions for a single rotateTokens function (Thanks for the inspiration @curdeius) extract the various combination of 2,3,4,5 qualifier types to a simple begin and

[clang] 04a96aa - [ASTMatchers] Add traversal-kind support to `DynTypedMatcher`

Author: Yitzhak Mandelbaum Date: 2020-05-28T11:18:37-04:00 New Revision: 04a96aa3e430a66767732f44acea00c6e13c9f78 URL: https://github.com/llvm/llvm-project/commit/04a96aa3e430a66767732f44acea00c6e13c9f78 DIFF:

RE: [PATCH] D78454: [clangd] Highlight related control flow.

Hi Sam, Thanks for looking at this. You could use something like in clang/ ./unittests/Tooling/RecursiveASTVisitorTests/LambdaExpr.cpp: if (llvm::Triple(llvm::sys::getDefaultTargetTriple()).isPS4()) return; // PS4 does not support fastcall. Regards Russ From: Sam McCall Sent: 28 May

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

scott.linder accepted this revision. scott.linder added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: llvm/cmake/modules/AddLLVM.cmake:1916 endif() - if(EXISTS "${path}/.svn") -set(svn_files Nit: can this be in a

[clang] ce5780b - [libTooling] Fix Transformer to work with ambient traversal kinds.

Author: Yitzhak Mandelbaum Date: 2020-05-28T11:42:07-04:00 New Revision: ce5780b88c6e2f3303afd266e5e29c1badd9eb3b URL: https://github.com/llvm/llvm-project/commit/ce5780b88c6e2f3303afd266e5e29c1badd9eb3b DIFF:

[PATCH] D80685: [ASTMatchers] Add traversal-kind support to `DynTypedMatcher`

This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rG04a96aa3e430: [ASTMatchers] Add traversal-kind support to `DynTypedMatcher` (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80508: [AST] Fix the source range for TagDecl if there is no matched } brace.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/AST/Decl.cpp:4129 SourceRange TagDecl::getSourceRange() const { - SourceLocation RBraceLoc = BraceRange.getEnd(); - SourceLocation E = RBraceLoc.isValid() ? RBraceLoc : getLocation();

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko updated this revision to Diff 266890. vsavchenko added a comment. Fix code review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/new/ https://reviews.llvm.org/D80117 Files:

  1   2   3   >