[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/N

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

njames93 updated this revision to Diff 268378. njames93 added a comment. Hopefully fixed windows buildn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80887/new/ https://reviews.llvm.org/D80887 Files: clang-tools-extra/clang-tidy/cppcoreguideline

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 268375. tentzen marked an inline comment as done. tentzen edited the summary of this revision. tentzen added a comment. update a couple of changes per David Majnemer's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

zinovy.nis added a comment. @njames93, @aaron.ballman do you have any other comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 ___

[PATCH] D81107: Make syntax tree test print the line number when it fails

hlopko accepted this revision. hlopko added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81107/new/ https://reviews.llvm.org/D81107 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules.

mboehme added a comment. Committed as https://github.com/llvm/llvm-project/commit/8d74de9de6d6cca552d7de7d0bfd36b6dd7d58dc. I thought I had added a "Differential Revision:" to the commit message, but something must have gone wrong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80781/n

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268382. eduucaldas added a comment. Add support for IntegerLiteral in SyntaxTree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

MyDeveloperDay added a comment. @sammccall in the example LOG_IF(DFATAL, exp_await_calls < num_await_calls_) << "Equality condition can never be satisfied:" << " exp_await_calls=" << exp_await_calls << " num_await_calls_=" << num_await_calls_; I agree this is more pleasing,

[clang] 06cf7ad - Make syntax tree test print the line number when it fails

Author: Dmitri Gribenko Date: 2020-06-04T10:42:44+02:00 New Revision: 06cf7adcc88178f887984fa74cdefb20cd8cd124 URL: https://github.com/llvm/llvm-project/commit/06cf7adcc88178f887984fa74cdefb20cd8cd124 DIFF: https://github.com/llvm/llvm-project/commit/06cf7adcc88178f887984fa74cdefb20cd8cd124.dif

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 + } + syntax::Leaf *literal(); +}; "literalToken"? Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:706 +void test() { + 42; +} -

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

MyDeveloperDay added a comment. Just to add, I also think although because there are no tests to enforce it the primary reason is for when we see '\n', breaking the stream on endl but this is actually covered by another rule this also in mustBreak() if (Current.is(tok::lessless) && ((Pr

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp:31 +struct Bar2 { + static_assert((... && (sizeof(Values) > 0)) || (... && (sizeof(Values) > 0))); + // CHECK-MESSAGES: :[[@LINE-1]]:47: warning: both sides of

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss updated this revision to Diff 268383. danielkiss edited the summary of this revision. danielkiss added a comment. Patch is refactored, the new pass smooth out the attribute issues. This version fixes issues with _clang_call_terminate, sanitisers and the CFI. New pass might need a new f

[PATCH] D81107: Make syntax tree test print the line number when it fails

This revision was automatically updated to reflect the committed changes. Closed by commit rG06cf7adcc881: Make syntax tree test print the line number when it fails (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81107/new/ ht

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

uabelho added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1034 const PreambleData &Preamble; - const PreamblePatch &Patch; + llvm::Optional Patch; llvm::StringRef Contents; Hi! When compiling with gcc 7.4 I see a warning that I

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

sammccall added a comment. In D80950#2072926 , @MyDeveloperDay wrote: > The same function with smaller variables isn't quite so readable > > LOG_IF(DFATAL, a < b) << "Equality condition can never be satisfied:" > << " foo=" << a

[PATCH] D81136: Define rules for naming NodeRole and apply them.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81136 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/N

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

sammccall added a comment. I couldn't quite parse the last comment about \n, but yes the endl handling (didn't realize it also covered \n!) is implemented separately but falls under the same "heuristic formatting" umbrella I think. > LOG_IF(DFATAL, a < b) << "Equality condition can never be s

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268397. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/T

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

krasimir added a comment. Another //weak// argument about why the current rule makes sense (break before `<<` between two string literals) is: suppose you don't want such a break. Then you can //change your code// to concatenate the two string literals into a single one, avoiding the problem al

[clang-tools-extra] 4f4a8ae - [clangd] Fix build for gcc 7.4

Author: Kadir Cetinkaya Date: 2020-06-04T12:02:49+02:00 New Revision: 4f4a8ae72e95f2c7fa5e4ca56dd6b1a83a304680 URL: https://github.com/llvm/llvm-project/commit/4f4a8ae72e95f2c7fa5e4ca56dd6b1a83a304680 DIFF: https://github.com/llvm/llvm-project/commit/4f4a8ae72e95f2c7fa5e4ca56dd6b1a83a304680.dif

Re: [PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

Hi Mikael, sent out 4f4a8ae72e95f2c7fa5e4ca56dd6b1a83a304680, please let me know if it helps! On Thu, Jun 4, 2020 at 12:40 PM Mikael Holmén via Phabricator < revi...@reviews.llvm.org> wrote: > uabelho added inline comments. > > > > Comment at: clang-tools-extra/clangd/CodeComple

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

labrinea added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:6989 + false, + getTarget().hasBFloat16Type()); llvm::Type *Ty = VTy; shouldn't this be `getTargetHooks().getA

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268403. eduucaldas added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Synta

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

klimek added a comment. In D80961#2068865 , @ymandel wrote: > Thank you for bringing up this issue. I think it highlights an underlying > problem -- editing templates is quite difficult -- that neither setting will > address, as Dmitri expanded on above.

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

klimek added a comment. Without jumping into the discussion whether it should be the default, I think we should be able to control template instantiation visitation separately from other implicit nodes. Having to put AsIs on a matcher every time you need to match template instantiations is a ra

[PATCH] D80490: [clang-tidy] Check for rule of five and zero.

njames93 added a comment. It would take more complex matching and diagnostics logic, but it would be so much nicer if the diagnostics were grouped. So instead of having a diagnostic about class `X` defining a copy construct and another about it defining a copy assignment operator, It could just

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll marked 2 inline comments as done. simoll added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4710 if (!CGF.CGM.getCodeGenOpts().PreserveVec3Type) { - auto *Vec4Ty = llvm::FixedVectorType::get( + auto Vec4Ty = llvm::VectorType::get(

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

miyuki added inline comments. Comment at: llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp:4675 + SDValue Ops[] = { Src, Pred, Reg0 }; + CurDAG->SelectNodeTo(N, ARM::BF16_VCVT, MVT::v4i16, Ops); + return; Why does it return `MVT::v4i16`, not `MVT::v4bf16`?

[clang] a7c6bec - [Sema] Remove unused matrix_begin/end helpers (NFC).

Author: Florian Hahn Date: 2020-06-04T11:29:01+01:00 New Revision: a7c6bec228ca28e9eee77433292ac86d77b67790 URL: https://github.com/llvm/llvm-project/commit/a7c6bec228ca28e9eee77433292ac86d77b67790 DIFF: https://github.com/llvm/llvm-project/commit/a7c6bec228ca28e9eee77433292ac86d77b67790.diff

Re: [PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

On 6/4/20 6:58 AM, Sean Silva wrote: Can we revert this? In our downstream project we were bitten by this: https://github.com/google/mlir-npcomp/commit/cd7258dbd48bd9254c6741cab2d3f4e36cbd3c84 It seems that now by default anybody that depends on LLVM with CMake will globally get a `-w` passe

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:439-441 + // Do not handle untracked stream. It is probably escaped. + if (!State->get(StreamSym)) +return; How does this interact with D78280? ==

[PATCH] D81138: [SemaOverload] Use iterator_range to iterate over VectorTypes (NFC).

fhahn created this revision. fhahn added reviewers: rjmccall, arphaman, jfb, Bigcheese. Herald added a subscriber: dexonsmith. Herald added a project: clang. We can simplify the code a bit by using iterator_range instead of plain iterators. Matrix type support here (added in 6f6e91d19337

[PATCH] D80725: [Analyzer][StreamChecker] Updated initialization of BugType's.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Yay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80725/new/ https://reviews.llvm.org/D80725 _

[PATCH] D78280: [Analyzer][StreamChecker] Track streams that were not found to be opened.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:36 + /// (False if the stream was first encountered in a non-opening function.) + bool OpenEncountered; baloghadamsoftware wrote: > Maybe `SawOpened` or `Explicit

[PATCH] D77062: [analyzer] Added check for unacceptable equality operation between Loc and NonLoc types

ASDenysPetrov marked 3 inline comments as done. ASDenysPetrov added a comment. @NoQ You concerns are absolutly justified. I agree with you. Let me tell what I'm thinking in inlines. If you are interested in why the assertion happens, please, look D77062#1977613

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

nemanjai added a comment. According to https://clang.llvm.org/docs/CrossCompilation.html (under `Toolchain Options` option 2) it is quite likely that a user that desires to cross-compile will have the necessary toolchain installed into a directory that will not require the use of `--sysroot`.

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 268412. reikdas marked an inline comment as done. reikdas retitled this revision from "Integral template argument suffix printing" to "Integral template argument suffix and cast printing". reikdas edited the summary of this revision. reikdas added a comment.

Re: [PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

On Thu, 2020-06-04 at 13:06 +0300, Kadir Çetinkaya wrote: > Hi Mikael, > > sent out 4f4a8ae72e95f2c7fa5e4ca56dd6b1a83a304680, please let me know > if it helps! Hi, Yes, now it's silent. Thank you! /Mikael > > On Thu, Jun 4, 2020 at 12:40 PM Mikael Holmén via Phabricator < > revi...@reviews.l

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268420. eduucaldas added a comment. answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/li

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:718 +} +)cpp", + R"txt( Could you remove the whitespace in front of `)cpp"` for

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit Mask in LLVM/Clang

nemanjai added a comment. Amy, I am really sorry. I initially did not read the description of the instructions in the ISA carefully. The semantics of these instructions are not actually `(op (and a, b))`. The mask is used to determine if a leading/trailing zero is counted or skipped. Take for e

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:642 // TODO: add accessors for specifiers. - syntax::Leaf *arrow(); + syntax::Leaf *arrowToken(); syntax::SimpleDeclarator *declarator(); Could you move this change t

[PATCH] D77062: [analyzer] Added check for unacceptable equality operation between Loc and NonLoc types

ASDenysPetrov updated this revision to Diff 268424. ASDenysPetrov added a comment. Removed `V.getAs()` from `if`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 Files: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp clang/test/Analysis

[clang] 3b73969 - Add support for IntegerLiteral in SyntaxTree

Author: Eduardo Caldas Date: 2020-06-04T14:05:31+02:00 New Revision: 3b739690b01e595f6da412316b58a0a291702049 URL: https://github.com/llvm/llvm-project/commit/3b739690b01e595f6da412316b58a0a291702049 DIFF: https://github.com/llvm/llvm-project/commit/3b739690b01e595f6da412316b58a0a291702049.diff

cfe-commits@lists.llvm.org

LukeGeeson added a comment. Besides from rebasing to get @pratlucas changes upstream. @stuij please could you confirm if you are happy with this, so I can merge CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268428. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. Fix nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clan

[PATCH] D80210: [analyzer] Turn off reports in system headers

NoQ added a comment. Eg., suppress this report: // system_header.h int bar() { int *x = NULL; return *x; } // user_file.c void foo() { bar(); } but don't suppress this report: // system_header.h int bar(int *x) { return *x; } // user_file.c void foo() {

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b739690b01e: Add support for IntegerLiteral in SyntaxTree (authored by eduucaldas, committed by gribozavr). Changed prior to commit: https://reviews.llvm.org/D81135?vs=268428&id=268435#toc Repository:

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

erichkeane updated this revision to Diff 268433. erichkeane marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80947/new/ https://reviews.llvm.org/D80947 Files: llvm/docs/CodingStandards.rst Index: llvm/docs/CodingStandards.rst

[PATCH] D81150: Use libClangTesting in the unittest for AST matchers

gribozavr created this revision. Herald added subscribers: cfe-commits, sstefan1, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: clang. The unittest for AST matchers has its own way to specify language standards. I unified it with the shared infrastructure from libClangTesting

[clang] bd42582 - [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

Author: Vince Bridgers Date: 2020-06-04T07:25:35-05:00 New Revision: bd425825411af1b340134b0e8c9c03733ee87d66 URL: https://github.com/llvm/llvm-project/commit/bd425825411af1b340134b0e8c9c03733ee87d66 DIFF: https://github.com/llvm/llvm-project/commit/bd425825411af1b340134b0e8c9c03733ee87d66.diff

[clang] 4a4402f - [OpenCL] Add cl_khr_extended_subgroup extensions.

Author: Anastasia Stulova Date: 2020-06-04T13:29:30+01:00 New Revision: 4a4402f0d72167477a6252e4c3daf5089ebc8f9a URL: https://github.com/llvm/llvm-project/commit/4a4402f0d72167477a6252e4c3daf5089ebc8f9a DIFF: https://github.com/llvm/llvm-project/commit/4a4402f0d72167477a6252e4c3daf5089ebc8f9a.d

[PATCH] D80903: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd425825411a: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D79781: [OpenCL] Add cl_khr_extended_subgroup extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a4402f0d721: [OpenCL] Add cl_khr_extended_subgroup extensions. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D81154: [AST][RecoveryExpr] Populate the dependence bits from CompoundStmt result expr to StmtExpr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. We lost errorBit for StmtExpr if a recoveryExpr is the result expr of a CompoundStmt, which will lead to crashes. // `-StmtExpr // `-CompoundStmt // `-RecoveryExp ({ invalid(); }); Rep

[PATCH] D80979: [clang] Implement VectorType logic not operator.

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2746 + if (E->getType()->isVectorType() && + E->getType()->castAs()->getVectorKind() == + VectorType::GenericVector) { erichkeane wrote: > junparser wrote: > > erichke

[PATCH] D81150: Use libClangTesting in the unittest for AST matchers

gribozavr updated this revision to Diff 268440. gribozavr added a comment. Changed C++20-only tests to C++20-or-later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81150/new/ https://reviews.llvm.org/D81150 Files: clang/include/clang/Testing/Co

[PATCH] D80979: [clang] Implement VectorType logic not operator.

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2746 + if (E->getType()->isVectorType() && + E->getType()->castAs()->getVectorKind() == + VectorType::GenericVector) { junparser wrote: > erichkeane wrote: > > Why lim

[PATCH] D81155: Rename arrow -> arrowToken for unified naming

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81155 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/N

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

hans added a comment. > The only absolute paths that remain are: a. the compiler path > (`D:\llvm-project\buildninjaDebMSVC\bin\clang-cl.exe` in the yaml below) and > b. the `-internal-isystem` paths. However that is not an issue on our end, as > we're building with `-nostdinc` + nuget packages

[clang] 3c191ae - [OPENMP]Fix PR45383: type dependent array subscripts are diagnosed erroneously.

Author: Alexey Bataev Date: 2020-06-04T09:34:59-04:00 New Revision: 3c191ae555cce6896f40b75ca031eadf675c5fb8 URL: https://github.com/llvm/llvm-project/commit/3c191ae555cce6896f40b75ca031eadf675c5fb8 DIFF: https://github.com/llvm/llvm-project/commit/3c191ae555cce6896f40b75ca031eadf675c5fb8.diff

[PATCH] D81157: Propose naming principle for NodeRole and apply it

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81157 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/N

[PATCH] D78637: [OPENMP]Fix PR45383: type dependent array subscripts are diagnosed erroneously.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c191ae555cc: [OPENMP]Fix PR45383: type dependent array subscripts are diagnosed erroneously. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:439-441 + // Do not handle untracked stream. It is probably escaped. + if (!State->get(StreamSym)) +return; Szelethus

[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

bjope added inline comments. Comment at: clang/test/Driver/wasm-toolchain.c:116 +// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]" +// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc" "{{.*[/\\]}}libclang_rt.builtins-wasm32.a" "-o" "a.out" + -

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

Naghasan added a comment. In D80932#2072064 , @Anastasia wrote: > In D80932#2071321 , @bader wrote: > > > In D80932#2068863 , @Anastasia > > wrote: > > > > > > > > > > > > >

[PATCH] D81150: Use libClangTesting in the unittest for AST matchers

hlopko accepted this revision. hlopko added a comment. This revision is now accepted and ready to land. Nice! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81150/new/ https://reviews.llvm.org/D81150 ___

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

balazske updated this revision to Diff 268459. balazske added a comment. Using range-based for loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80699/new/ https://reviews.llvm.org/D80699 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.

[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

bjope added inline comments. Comment at: clang/test/Driver/wasm-toolchain.c:116 +// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]" +// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc" "{{.*[/\\]}}libclang_rt.builtins-wasm32.a" "-o" "a.out" + -

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

lenary added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D80725: [Analyzer][StreamChecker] Updated initialization of BugType's.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bfd70bdad7e: [Analyzer][StreamChecker] Updated initialization of BugType's. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80725/new/

[clang] 0bfd70b - [Analyzer][StreamChecker] Updated initialization of BugType's.

Author: Balázs Kéri Date: 2020-06-04T16:06:07+02:00 New Revision: 0bfd70bdad7e4ac22d96503fa78a5dd55d4b430e URL: https://github.com/llvm/llvm-project/commit/0bfd70bdad7e4ac22d96503fa78a5dd55d4b430e DIFF: https://github.com/llvm/llvm-project/commit/0bfd70bdad7e4ac22d96503fa78a5dd55d4b430e.diff L

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. This LGTM. I believe we have not heard back from @arsenm on the response to some of their comments though. Comment at: llvm/docs/CodingStanda

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll marked an inline comment as done. simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +o

[clang] 62305f6 - Rename arrow -> arrowToken for unified naming

Author: Eduardo Caldas Date: 2020-06-04T16:12:16+02:00 New Revision: 62305f6db4ed642c6b2b005dcb7951eb38342dca URL: https://github.com/llvm/llvm-project/commit/62305f6db4ed642c6b2b005dcb7951eb38342dca DIFF: https://github.com/llvm/llvm-project/commit/62305f6db4ed642c6b2b005dcb7951eb38342dca.diff

[PATCH] D81157: Propose naming principle for NodeRole and apply it

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:94 /// a binary expression'. Used for implementing accessors. +// How to name NodeRole: +// If the child node is a token/keyword, end its name with 'Token'/'Keyword' I'd sug

[PATCH] D81163: [AST][RecoveryExpr] Preserve the AST for invalid conditions.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Tested with enabling "-frecovery-ast", only 1 failure, which is an improvement of secondary diagnostic. -- error: 'error' diagnostics seen but not expected: File /workspace/llvm-project/clang/

[PATCH] D81155: Rename arrow -> arrowToken for unified naming

This revision was automatically updated to reflect the committed changes. Closed by commit rG62305f6db4ed: Rename arrow -> arrowToken for unified naming (authored by eduucaldas, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69987/new/ https://reviews.llvm.org/D69987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jhuber6 added a comment. The failure message is pretty much always this assertion as far as I can tell clang-11: /home/jhuber/Documents/llvm-project/llvm/lib/IR/Instructions.cpp:439: void llvm::CallInst::init(llvm::FunctionType*, llvm::Value*, llvm::ArrayRef, llvm::ArrayRef >, const llvm::T

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert added a comment. In D80735#2073639 , @jhuber6 wrote: > The failure message is pretty much always this assertion as far as I can tell > > clang-11: > /home/jhuber/Documents/llvm-project/llvm/lib/IR/Instructions.cpp:439: void > llvm::CallInst::

[clang] 9520bf1 - [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide

Author: Jonathan Coe Date: 2020-06-04T15:48:00+01:00 New Revision: 9520bf146dd3baae8608755d7de0855db4664c77 URL: https://github.com/llvm/llvm-project/commit/9520bf146dd3baae8608755d7de0855db4664c77 DIFF: https://github.com/llvm/llvm-project/commit/9520bf146dd3baae8608755d7de0855db4664c77.diff

[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

sunfish marked an inline comment as done. sunfish added inline comments. Comment at: clang/test/Driver/wasm-toolchain.c:116 +// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]" +// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc" "{{.*[/\\]}}libclang_rt.bui

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

sylvestre.ledru added a comment. @zequanwu could you please update the release notes? thanks https://github.com/llvm/llvm-project/blob/master/clang/docs/ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.llvm.

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit Mask in LLVM/Clang

amyk updated this revision to Diff 268470. amyk added a comment. Revert back to the initial implementation of the patch. Thanks Nemanja for clarifying. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80941/new/ https://reviews.llvm.org/D80941 Files

[PATCH] D77168: Add a flag to debug automatic variable initialization

jfb added a comment. Can you add a test for the diagnostic firing after the correct number of initializations? This should include a few types of auto-init, including VLAs. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:489 + "-ftrivial-auto-var-init-stop-afte

[PATCH] D79781: [OpenCL] Add cl_khr_extended_subgroup extensions

PiotrFusik marked 2 inline comments as done. PiotrFusik added inline comments. Comment at: clang/lib/Headers/opencl-c.h:15594 +int __ovld sub_group_elect(void); +int __ovld sub_group_non_uniform_all( int predicate ); +int __ovld sub_group_non_uniform_any( int predicat

[PATCH] D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide

This revision was automatically updated to reflect the committed changes. Closed by commit rG9520bf146dd3: [clang-format] Update GoogleStyle for C# code to match Google's internal C#… (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81168: Add support for id-expression in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a subscriber: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added inline comments. eduucaldas marked an inline comment as not done. Comm

[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

bjope added inline comments. Comment at: clang/test/Driver/wasm-toolchain.c:116 +// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]" +// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc" "{{.*[/\\]}}libclang_rt.builtins-wasm32.a" "-o" "a.out" + -

[PATCH] D81168: Add support for id-expression in SyntaxTree

eduucaldas added a subscriber: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:829 +| | | | | `-:: +| | | | `-TypeSpecifier +| | | | |-S Perhaps we sh

[clang] b5fc1de - Use libClangTesting in the unittest for AST matchers

Author: Dmitri Gribenko Date: 2020-06-04T17:40:39+02:00 New Revision: b5fc1deb5ba1f3cd432ecb8b86c2536470463163 URL: https://github.com/llvm/llvm-project/commit/b5fc1deb5ba1f3cd432ecb8b86c2536470463163 DIFF: https://github.com/llvm/llvm-project/commit/b5fc1deb5ba1f3cd432ecb8b86c2536470463163.dif

[PATCH] D81169: [clangd] Improve hover on arguments to function call

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. In cases like: foo(a, ^b); We now additionally show the name and type of the parameter to foo that corre

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 268488. simoll added a comment. - Improved documentation for the size argument of vector_size. - Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/d

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

arsenm added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:62-63 BUILTIN(__builtin_amdgcn_fence, "vUicC*", "n") +BUILTIN(__builtin_amdgcn_atomic_inc, "iiD*iUicC*", "n") +BUILTIN(__builtin_amdgcn_atomic_dec, "iiD*iUicC*", "n") My mai

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fixes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80887/new/ https://reviews.llvm.org/D80887 ___

[PATCH] D81150: Use libClangTesting in the unittest for AST matchers

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5fc1deb5ba1: Use libClangTesting in the unittest for AST matchers (authored by gribozavr). Changed prior to commit: https://reviews.llvm.org/D81150?vs=268440&id=268495#toc Repository: rG LLVM Github

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jhuber6 added a comment. Here's one of the stack traces. Calling `InternalOMPBuilder.initialize()` is what triggers it to start failing, which is confusing because all that function does is initialize the named types from OMPConstants, which should be working or else the old solution wouldn't w

  1   2   3   >