[clang] ead7a8b - [update_cc_test_checks.py] Correctly skip function definitions

Author: Alex Richardson Date: 2020-06-18T18:09:21+01:00 New Revision: ead7a8beccc18c2cbcde980d2f593267d63c5dc2 URL: https://github.com/llvm/llvm-project/commit/ead7a8beccc18c2cbcde980d2f593267d63c5dc2 DIFF: https://github.com/llvm/llvm-project/commit/ead7a8beccc18c2cbcde980d2f593267d63c5dc2.dif

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/tools/driver/driver.cpp:518 + CRC.DumpStackAndCleanupOnFailure = true; + CRC.RunSafely([&]() { abort(); }); } aganea wrote: > The only concern I have i

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e59dfc30124: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81304/new/ h

[PATCH] D82026: [OPENMP50]Allow nonmonotonic modifier for all schedule kinds.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4971d0b8ec6e: [OPENMP50]Allow nonmonotonic modifier for all schedule kinds. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82026/new/

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:345 +// rarely. +Weights = nullptr; + } else if (Kind == GuardKind::VariableGuard && !D->isLocalVarDecl()) { jasonliu wrote: > Do we need to change/complicate the interface fo

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; eduucaldas wrote: > gribozavr2 wrote: > > Should there be getters

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 271747. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Removed a redundant header file; Addressed comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/incl

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. Failing on Windows too, actually: http://45.33.8.238/win/17931/step_10.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 ___ cfe-commi

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271744. eduucaldas marked 12 inline comments as done. eduucaldas added a comment. Aswering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/in

[PATCH] D78190: Add Bfloat IR type

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm-c/Core.h:149 LLVMHalfTypeKind,/**< 16 bit floating point type */ + LLVMBFloatTypeKind, /**< 16 bit brain floating point type */ LLVMFloatTypeKind, /**< 32

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff added a comment. Thank you @aganea ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

stuij accepted this revision. stuij added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81304/new/ https://reviews.llvm.org/D81304 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D81885: [Coroutines] Return false on error of buildSuspends

modocache requested changes to this revision. modocache added a comment. This revision now requires changes to proceed. I don't have a preference as to whether `Sema::ActOnCoroutineBodyStart` returns `true` or `false` to indicate failure, although I think returning `true` for failures is a bit o

[clang] 3e59dfc - [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

Author: Francesco Petrogalli Date: 2020-06-18T16:36:31Z New Revision: 3e59dfc301240ffb5e82bc43e05225d0d51d5cfa URL: https://github.com/llvm/llvm-project/commit/3e59dfc301240ffb5e82bc43e05225d0d51d5cfa DIFF: https://github.com/llvm/llvm-project/commit/3e59dfc301240ffb5e82bc43e05225d0d51d5cfa.dif

[clang] 4971d0b - [OPENMP50]Allow nonmonotonic modifier for all schedule kinds.

Author: Alexey Bataev Date: 2020-06-18T12:30:50-04:00 New Revision: 4971d0b8ec6e8d3b9ea5980d96cf5812886671df URL: https://github.com/llvm/llvm-project/commit/4971d0b8ec6e8d3b9ea5980d96cf5812886671df DIFF: https://github.com/llvm/llvm-project/commit/4971d0b8ec6e8d3b9ea5980d96cf5812886671df.diff

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. In D80833#2101057 , @thakis wrote: > Looks like this breaks tests on mac: http://45.33.8.238/mac/15751/step_10.txt > > Please take a look. Checking now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ec469cf4c20: [OPENMP50]Codegen for scan directives in parallel for regions. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81478/new/

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

jdoerfert added a comment. LGTM, @rjmccall wdyt? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81311/new/ https://reviews.llvm.org/D81311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:64-65 +"-shared", +"-mllvm", +"-amdgpu-internalize-symbols", +"-o

[clang] 1ec469c - [OPENMP50]Codegen for scan directives in parallel for regions.

Author: Alexey Bataev Date: 2020-06-18T11:56:55-04:00 New Revision: 1ec469cf4c20a0f80ab6507e3838cfcc3e4f9595 URL: https://github.com/llvm/llvm-project/commit/1ec469cf4c20a0f80ab6507e3838cfcc3e4f9595 DIFF: https://github.com/llvm/llvm-project/commit/1ec469cf4c20a0f80ab6507e3838cfcc3e4f9595.diff

[libunwind] 2d865cc - unwind: EHABISectionIterator `operator!=`, constify `operator-`

Author: Saleem Abdulrasool Date: 2020-06-18T08:54:34-07:00 New Revision: 2d865ccbd8c47fe94af04a6cffd02c45a24e2ffb URL: https://github.com/llvm/llvm-project/commit/2d865ccbd8c47fe94af04a6cffd02c45a24e2ffb DIFF: https://github.com/llvm/llvm-project/commit/2d865ccbd8c47fe94af04a6cffd02c45a24e2ffb.

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

arsenm updated this revision to Diff 271732. arsenm retitled this revision from "[RFC] LangRef: Define inmem parameter attribute" to "[RFC] LangRef: Define byref parameter attribute". arsenm added a comment. Rename to byref. Specify more explicitly this is for the ABI, and should not be inferred

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

tahonermann added a comment. @Kai, I'm afraid I won't be able to assist much in reviews of most z/OS related patches (due to lack of time and lack of expertise with various parts of z/OS), but please do copy me on anything related to source and execution character set encoding or conversions, h

[PATCH] D81912: [AST] Dump containsErrors bit for the Type.

hokein updated this revision to Diff 271733. hokein added a comment. address comment: emit the error-bit with color. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81912/new/ https://reviews.llvm.org/D81912 Files: clang/lib/AST/JSONNodeDumper.cpp

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9b8aada8288: [clang-tidy] Add --use-color command line option and UseColor option to control… (authored by hyd-dev, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D82103: [analyzer] Remove forbidden characters from a SourceLocation filename for a graph dump on Windows

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: Charusso, NoQ. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Windows forbidden file path characters

[PATCH] D82102: [AST][RecoveryExpr] Populate the error-bit from template arguments to TemplateSepcializationType.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82102 Files: clang/lib/AST/Type.cpp clang/test/SemaCXX/invalid-template-base-specifier.cpp Index: clang/test/SemaCXX/invalid-temp

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

ambroyz added a comment. topic, please, don't die CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27651/new/ https://reviews.llvm.org/D27651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] b4c7a75 - Don't require shell in clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_adda.c

Author: Hans Wennborg Date: 2020-06-18T17:21:48+02:00 New Revision: b4c7a7542f482b4e1ac1d3936314fafd30b3b8db URL: https://github.com/llvm/llvm-project/commit/b4c7a7542f482b4e1ac1d3936314fafd30b3b8db DIFF: https://github.com/llvm/llvm-project/commit/b4c7a7542f482b4e1ac1d3936314fafd30b3b8db.diff

[clang-tools-extra] d9b8aad - [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

Author: hyd-dev Date: 2020-06-18T16:16:14+01:00 New Revision: d9b8aada8288ca4aff4a1d70bf5eb4d579c79036 URL: https://github.com/llvm/llvm-project/commit/d9b8aada8288ca4aff4a1d70bf5eb4d579c79036 DIFF: https://github.com/llvm/llvm-project/commit/d9b8aada8288ca4aff4a1d70bf5eb4d579c79036.diff LOG:

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 accepted this revision. njames93 added a comment. LG, I have nothing else to add here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 271723. njames93 marked 4 inline comments as done. njames93 added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-

[PATCH] D82059: [clang-tidy] RenamerClangTidy group redecls into 1 warning.

This revision was automatically updated to reflect the committed changes. Closed by commit rG850bb889a56c: [clang-tidy] RenamerClangTidy group redecls into 1 warning. (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82059?vs=271509&id=271722#toc Repository: rG LLVM

[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests

thakis added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_adda.c:3 // RUN: %clang_cc1 -D__ARM_FEATURE_SVE -DSVE_OVERLOADED_FORMS -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -S -O1 -Werror -Wall -emit

[PATCH] D81601: [analyzer] SATest: Use logger in single-threaded mode as well

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/SATestBuild.py:650 Logger = logging.getLogger(test_info.project.name) LOCAL.stdout = StreamToLogger(Logger, logging.INFO) --

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

erichkeane updated this revision to Diff 271713. erichkeane marked 9 inline comments as done. erichkeane added a comment. @AaronBallman's suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/ https://reviews.llvm.org/D79755 Files: clang/lib/AST/ExprConstant.cpp clan

[PATCH] D81598: [analyzer] SATest: Add an easy option to connect to docker for debugging

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/entrypoint.py:23 +while True: +sleep(3600) + NoQ wrote: > I request comments (: Yeah, I guess it can be quite confusing when you read only

[PATCH] D79249: [NOT FOR REVIEW] Experimental support for zero-or-trap behavior foruninitialized variables.

jdoerfert added a comment. FWIW, I tried to solve something similar the other day. My solution sketch looked like this: https://godbolt.org/z/bRQPjd The idea would be that we teach DSE (and others) to remove the `llvm.undef.init` intrinsic if the location is overwritten. In the example above onl

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/projects/box2d/run_static_analyzer.cmd:1 +cmake . -DCMAKE_BUILD_TYPE=Release -Bbuild -GNinja +cmake --build build NoQ wrote: > Is there a flag to enabl

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. Looks like this breaks tests on mac: http://45.33.8.238/mac/15751/step_10.txt Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 _

[PATCH] D82099: [AST][RecoveryAST] Populate error-bit from Type to Expr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Looks like this is a fallout when we introduce the error-bit in Type. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82099 Files: clang/include/clang/AST/DependenceFlags.h clan

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. Thanks for taking the time @hans, @amccarth! I've split this into several smaller patches, to ease bisect if needs be: rGa45409d8855a1e4538990507ef25e9b51c090193 - [Clang] Move clang::Job::printArg to

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

vsavchenko marked 5 inline comments as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/Dockerfile:10 + +# newer CMake is required by LLVM +RUN wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | tee /etc/apt/

[clang-tools-extra] 850bb88 - [clang-tidy] RenamerClangTidy group redecls into 1 warning.

Author: Nathan James Date: 2020-06-18T15:50:16+01:00 New Revision: 850bb889a56ccf3252792c6d3db59542e94753ae URL: https://github.com/llvm/llvm-project/commit/850bb889a56ccf3252792c6d3db59542e94753ae DIFF: https://github.com/llvm/llvm-project/commit/850bb889a56ccf3252792c6d3db59542e94753ae.diff

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

jasonliu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:345 +// rarely. +Weights = nullptr; + } else if (Kind == GuardKind::VariableGuard && !D->isLocalVarDecl()) { Do we need to change/complicate the interface for this function, just

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:383 +# when directory name starts with the letter `l`. +if sys.platform == 'win32': +# Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`, ---

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

NoQ added a comment. Nice catch! Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:383 +# when directory name starts with the letter `l`. +if sys.platform == 'win32': +# Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`, ---

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

NoQ added a comment. In D82092#2100973 , @vsavchenko wrote: > Additionally, I want to make a note that we are not really working hard on > keeping all the scripts and the analyzer itself to be fully functional on > Windows. Yup. See also D76768

[PATCH] D81599: [analyzer] SATest: Add 5 more projects for testing

NoQ added a comment. Like in D81592 , we should take a look at enabling assertions. If this boils down to `-DCMAKE_BUILD_TYPE=Debug` then so be it(?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81599/new/ https:

[PATCH] D81600: [analyzer] SATest: Fix package versions for test dependencies

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yes please! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81600/new/ https://reviews.llvm.org/D81600 __

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

NoQ added inline comments. Comment at: clang/utils/analyzer/Dockerfile:15 +# test system dependencies +RUN apt-get update && apt-get install -y \ +git \ NoQ wrote: > Maybe put `apt-get update` on a separate line? > > Also i think you mentioned offline that y

[PATCH] D81595: [analyzer] SATest: Make main script Python2 compatible

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Woohoo! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81595/new/ https://reviews.llvm.org/D81595 ___ cf

[PATCH] D81596: [analyzer] SATest: Do not re-run CMake in Docker if not needed

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yeet! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81596/new/ https://reviews.llvm.org/D81596 ___ cfe-

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

vsavchenko added a comment. Even though it doesn't seem that necessary, I would still vote to comply with `clang-format` in tests as well. Other then that looks good to me! Additionally, I want to make a note that we are not really working hard on keeping all the scripts and the analyzer itself

[PATCH] D81601: [analyzer] SATest: Use logger in single-threaded mode as well

NoQ added inline comments. Comment at: clang/utils/analyzer/SATestBuild.py:650 Logger = logging.getLogger(test_info.project.name) LOCAL.stdout = StreamToLogger(Logger, logging.INFO) Now that you have a global `Logger`, is this

[PATCH] D82019: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I agree it is not a good idea. Let's hope no one will complain :) LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82019/new/ https://r

[PATCH] D81598: [analyzer] SATest: Add an easy option to connect to docker for debugging

NoQ added inline comments. Comment at: clang/utils/analyzer/entrypoint.py:23 +while True: +sleep(3600) + I request comments (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81598/new/ https://reviews.l

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. I don't have commit access. @njames93 Could you please commit it for me (`hyd-dev `)? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cf

[PATCH] D81593: [analyzer] SATest: Make docker interfaces transparent

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay transparency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81593/new/ https://reviews.llvm.org/D81593

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

martong added a comment. In D77658#2065174 , @MaskRay wrote: > `arc` adds many unneeded tags from Phabricator. You can drop `Reviewers:` > `Subscribers:` `Tags:` and the text `Summary:` with the following script: > > arcfilter () { > arc amend >

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

NoQ added inline comments. Comment at: clang/utils/analyzer/.dockerignore:2 +./projects \ No newline at end of file NO NeWlINE At EnD oF fILE Comment at: clang/utils/analyzer/projects/box2d/run_static_analyzer.cmd:1 +cmake . -DCMAKE_BUILD_TYPE

[PATCH] D81572: [analyzer] SATest: Add convenience 'docker' command

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81572/new/ https://reviews.llvm.org/D81572 ___ cfe-c

[PATCH] D78903: [Driver] Add option -fproc-stat-report

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. Thanks again for the changes @sepavloff! Looks good to me! You might wait a bit before commiting, if there are further comments. Comment at: clang/lib/Driver/Driver.cpp:3806

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

NoQ added inline comments. Comment at: clang/utils/analyzer/Dockerfile:10 + +# newer CMake is required by LLVM +RUN wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | tee /etc/apt/trusted.gpg.d/kitware.gpg >/dev/null --

[PATCH] D82026: [OPENMP50]Allow nonmonotonic modifier for all schedule kinds.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82026/new/ https://reviews.llvm.org/D82026 _

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM and cleaner than my sketch, thanks a lot :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81478/new/ https://reviews.llvm.org/D81478

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

NoQ added a comment. Here are some examples: void test1(int *a, int index1, int index2) { int x = a[index1]; a[index2] = 0; int y = a[index1]; // In reality we don't know but after your patch // we're confident that this is "TRUE". clang_analyzer_eval(x == y); }

[clang] cab3fc5 - Fix linker error in clang-fuzzer following 89ea0b05207d45c145fb525df554b3b986ae379b.

Author: Alexandre Ganea Date: 2020-06-18T10:07:31-04:00 New Revision: cab3fc53d2e173243a462e9c8e914af58ddbeaba URL: https://github.com/llvm/llvm-project/commit/cab3fc53d2e173243a462e9c8e914af58ddbeaba DIFF: https://github.com/llvm/llvm-project/commit/cab3fc53d2e173243a462e9c8e914af58ddbeaba.dif

[clang] 8374bf4 - [CodeView] Fix generated command-line expansion in LF_BUILDINFO. Fix the 'pdb' entry which was previously a null reference, now an empty string.

Author: Alexandre Ganea Date: 2020-06-18T10:07:30-04:00 New Revision: 8374bf43634725dc02a262a77b5f940fca25938c URL: https://github.com/llvm/llvm-project/commit/8374bf43634725dc02a262a77b5f940fca25938c DIFF: https://github.com/llvm/llvm-project/commit/8374bf43634725dc02a262a77b5f940fca25938c.dif

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff marked 2 inline comments as done. sepavloff added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3814 + llvm::raw_fd_ostream OS(StatReportFile, EC, llvm::sys::fs::OF_Append); + if (!EC) { +if (auto L = OS.tryToLock()) ---

[PATCH] D77062: [analyzer] Added check for unacceptable equality operation between Loc and NonLoc types

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok, this simplification is obviously correct. I don't mind landing it regardless of the crash. If it gets rid of the crash, even better. I'm still worried about the root cause of the crash though. I

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, vsavchenko. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Handle `\l` separately for

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:258 return CGOpts.DataSections && !CGOpts.DisableIntegratedAS; + case Triple::GOFF: +llvm::report_fatal_error("ASan not implemented for GOFF."); Minor nit: GOFF

[PATCH] D81930: [AArch64] Add -mbti flag.

danielkiss planned changes to this revision. danielkiss added a comment. I got some comment internally, the -mbti might suggest it enables the bti feature so I'm going to rename the flag to -mmark-bti-property. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

Eugene.Zelenko added a comment. It'll be interesting to run improved check over LLVM code base. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:983 +const LangOptions &LangOpts) +: IsEnabled(false), UseCxx20IfAvailable(UseCxx20IfAvailable), +

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

NoQ added a comment. > Balázs, could you please add the checker option within this patch? I'd rather have this decision made globally. Like, for all //leaks//, or something like that. Our behavior should be consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D82059: [clang-tidy] RenamerClangTidy group redecls into 1 warning.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:383 +{ + const auto *Canonical = cast(Decl->getCanonicalDecl()); -

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commi

Re: [clang] eb4c758 - [Matrix] Pass darwin tripe to SeamObjc test to fix windows bot failure.

Thanks! I see it also fails on ARM (http://lab.llvm.org:8011/builders/clang-cmake-armv8-lld/builds/4438), so my sneaky change to fix the test (d8c612b7eabcc7ec399fad533d5beefa4ae08ac9) was not enough. On Thu, Jun 18, 2020 at 2:36 PM Florian Hahn via cfe-commits wrote: > > > Author: Florian Hahn >

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

This revision was automatically updated to reflect the committed changes. Closed by commit rG403f9537924b: [CodeView] Add full repro to LF_BUILDINFO record (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D80833?vs=268906&id=271698#toc Repository: rG LLVM Github Monore

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM; thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81972/new/ https://reviews.llvm.org/D81972 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2699 +RHSValue.getInt(), Result); + assert(LHSValue.getKind() == APValue::Float && "SHhuld be no other options"); + return handleLogicalOpForVector(LHSValue.getFl

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

foad added a comment. > markTails function set IsTailcall bit for functions which are not > last calls: It's OK to set "tail" on any call that satisfies these requirements (from https://llvm.org/docs/LangRef.html#call-instruction): "Both markers [tail and musttail] imply that the callee does n

[PATCH] D82086: [AST][RecoveryExpr] Fix a crash: don't attach error-type base specifiers.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/test/SemaCXX/invalid-template-base-specifier.cpp:6 +template +struct Crash : decltype(Foo(T())) { // expected-error {{no matching function for call to 'Foo'}} + Crash(){};

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 created this revision. njames93 added reviewers: alexfh, Eugene.Zelenko, angelgarcia, aaron.ballman, klimek. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Enables support for transforming loops of the form for (auto I = Cont.rbegin(), E = Cont.rend()

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. **Ping?** CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 403f953 - [CodeView] Add full repro to LF_BUILDINFO record

Author: Alexandre Ganea Date: 2020-06-18T09:17:15-04:00 New Revision: 403f9537924b8910ed4f741ed96c61f5e657915b URL: https://github.com/llvm/llvm-project/commit/403f9537924b8910ed4f741ed96c61f5e657915b DIFF: https://github.com/llvm/llvm-project/commit/403f9537924b8910ed4f741ed96c61f5e657915b.dif

[clang] a45409d - [Clang] Move clang::Job::printArg to llvm::sys::printArg. NFCI.

Author: Alexandre Ganea Date: 2020-06-18T09:17:13-04:00 New Revision: a45409d8855a1e4538990507ef25e9b51c090193 URL: https://github.com/llvm/llvm-project/commit/a45409d8855a1e4538990507ef25e9b51c090193 DIFF: https://github.com/llvm/llvm-project/commit/a45409d8855a1e4538990507ef25e9b51c090193.dif

[clang] 89ea0b0 - [MC] Pass down argv0 & cc1 cmd-line to the back-end and store in MCTargetOptions

Author: Alexandre Ganea Date: 2020-06-18T09:17:14-04:00 New Revision: 89ea0b05207d45c145fb525df554b3b986ae379b URL: https://github.com/llvm/llvm-project/commit/89ea0b05207d45c145fb525df554b3b986ae379b DIFF: https://github.com/llvm/llvm-project/commit/89ea0b05207d45c145fb525df554b3b986ae379b.dif

[PATCH] D81786: [clang][utils] Modify make-ast-dump-check.sh to generate AST serialization dump tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7350a3bab14: [clang][utils] Modify make-ast-dump-check.sh to generate AST serialization dump… (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D81787: [clang] Fix the serialization of LambdaExpr and the bogus mutation in LambdaExpr::getBody

This revision was automatically updated to reflect the committed changes. riccibruno marked an inline comment as done. Closed by commit rG05843dc6ab97: [clang] Fix the serialization of LambdaExpr and the bogus mutation in… (authored by riccibruno). Changed prior to commit: https://reviews.llvm.

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

This revision was automatically updated to reflect the committed changes. Closed by commit rG92d8ad02e92f: [HIP] Fix rocm not found on rocm3.5 (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D81713?vs=270298&id=271689#toc Repository: rG

[PATCH] D82086: [AST][RecoveryExpr] Fix a crash: don't attach error-type base specifiers.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein edited the summary of this revision. otherwise we'll run into code path which expects a good base specifiers, and lead to crashes. The crash only occurs in template instantiations (in non-templ

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

arsenm created this revision. arsenm added reviewers: yaxunl, rampitec, b-sumner, foad, nhaehnle. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, wdng, jvesely, kzhuravl. I wasn't sure what the best strategy was for the wave size difference. I went for an explicit, enforced builtin for

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

modocache added a reviewer: junparser. modocache added a subscriber: junparser. modocache added a comment. Excellent, thank you! The test failures on the diff appear to be legitimate, they reproduce for me when I apply this patch to my local checkout and run `ninja check-clang`. Could you take a

[clang] 92d8ad0 - [HIP] Fix rocm not found on rocm3.5

Author: Yaxun (Sam) Liu Date: 2020-06-18T08:40:09-04:00 New Revision: 92d8ad02e92fed3884169ba5d98056fe4fa5660d URL: https://github.com/llvm/llvm-project/commit/92d8ad02e92fed3884169ba5d98056fe4fa5660d DIFF: https://github.com/llvm/llvm-project/commit/92d8ad02e92fed3884169ba5d98056fe4fa5660d.dif

[clang] c7350a3 - [clang][utils] Modify make-ast-dump-check.sh to generate AST serialization dump tests

Author: Bruno Ricci Date: 2020-06-18T13:37:29+01:00 New Revision: c7350a3bab14eb633f39a949f85ac0e690cd9b4d URL: https://github.com/llvm/llvm-project/commit/c7350a3bab14eb633f39a949f85ac0e690cd9b4d DIFF: https://github.com/llvm/llvm-project/commit/c7350a3bab14eb633f39a949f85ac0e690cd9b4d.diff L

[clang] 05843dc - [clang] Fix the serialization of LambdaExpr and the bogus mutation in LambdaExpr::getBody

Author: Bruno Ricci Date: 2020-06-18T13:37:24+01:00 New Revision: 05843dc6ab97a00cbde7aa4f08bf3692eb83109d URL: https://github.com/llvm/llvm-project/commit/05843dc6ab97a00cbde7aa4f08bf3692eb83109d DIFF: https://github.com/llvm/llvm-project/commit/05843dc6ab97a00cbde7aa4f08bf3692eb83109d.diff L

[clang] eb4c758 - [Matrix] Pass darwin tripe to SeamObjc test to fix windows bot failure.

Author: Florian Hahn Date: 2020-06-18T13:35:03+01:00 New Revision: eb4c758fe4b60ae3779d3e9401d00ee1450ae41b URL: https://github.com/llvm/llvm-project/commit/eb4c758fe4b60ae3779d3e9401d00ee1450ae41b DIFF: https://github.com/llvm/llvm-project/commit/eb4c758fe4b60ae3779d3e9401d00ee1450ae41b.diff

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

This revision was automatically updated to reflect the committed changes. Closed by commit rGada4c9dc4a63: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from… (authored by pratlucas). Changed prior to commit: https://reviews.llvm.org/D81451?vs=269453&id=271677#toc R

<    1   2   3   >