[PATCH] D82943: [SVE] Add more warnings checks to clang and LLVM SVE tests

david-arm created this revision. david-arm added reviewers: sdesmalen, ctetreau, kmclaughlin. Herald added subscribers: llvm-commits, cfe-commits, psnobl, arphaman, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a reviewer: efriedma. Herald added projects: clang, LLVM. There

[PATCH] D81787: [clang] Fix the serialization of LambdaExpr and the bogus mutation in LambdaExpr::getBody

martong added a comment. This patch causes a regression (crash) during the deserialization of certain functions. Please see the details and review the supposed fix here: https://reviews.llvm.org/D82940 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82288/new/ https://reviews.llvm.org/D82288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

yaxunl updated this revision to Diff 274774. yaxunl marked 4 inline comments as done. yaxunl added a comment. revised by Artem's and Paul's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 Files:

[PATCH] D82924: [clang-tidy] fix cppcoreguidelines-init-variables with catch variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG669494e9c06c: [clang-tidy] fix cppcoreguidelines-init-variables with catch variables (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

yaxunl marked 10 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:750 +bool Sema::CUDACheckLambdaCapture(CXXMethodDecl *Callee, + const sema::Capture ) { tra wrote: > What does the

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82954 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprCXX.cpp clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:108 + signed char *__c) { + // CHECK-BE: store i8 %{{.+}}, i8* %{{.+}}, align 1 + // CHECK-LE: store i8 %{{.+}}, i8* %{{.+}}, align 1 amyk wrote: > lei

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D79972#2124108 , @cchen wrote: > @ABataev , I'm considering emitting an extra dimension for a non-contiguous > descriptor to support stride in this patch (stride = 1 in array section is > just a special case for computing

[clang] c79745e - [Analyzer] Quick fix for broken tests on Windows

Author: Adam Balogh Date: 2020-07-01T12:52:47+02:00 New Revision: c79745ed48f3e22e9c5fdfa070bceecf7590896c URL: https://github.com/llvm/llvm-project/commit/c79745ed48f3e22e9c5fdfa070bceecf7590896c DIFF: https://github.com/llvm/llvm-project/commit/c79745ed48f3e22e9c5fdfa070bceecf7590896c.diff

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, I think the complexity argument is reasonable (and I appreciate the information showing this also reduces binary size at the same time). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82946: [Driver][ARM] Disable bf16 when hardware FP support is missing

vhscampos created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. vhscampos abandoned this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82946 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D82729: [clangd] Make sure headers are available in FS inside FindSymbolsTests

kadircet abandoned this revision. kadircet added a comment. abandoning in favor of D82944 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82729/new/ https://reviews.llvm.org/D82729

[PATCH] D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:501 WalkUpFromStmt IntegerLiteral(1) -WalkUpFromBinaryOperator BinaryOperator(+) - WalkUpFromExpr BinaryOperator(+) -

[PATCH] D82924: [clang-tidy] fix cppcoreguidelines-init-variables with catch variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82924/new/ https://reviews.llvm.org/D82924

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

fpallares added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2362 + } + if (TargetFlags & RISCV::VMConstraint) { +// vadc, vsbc are special cases. Given that this constraint has no effect when `DestReg != RISCV::V0`, we

[clang] 36aaffb - Fix Wdocumentation warnings due to outdated parameter list. NFC.

Author: Simon Pilgrim Date: 2020-07-01T12:01:18+01:00 New Revision: 36aaffbf56913ebe1e3987d7d0ac76573be65cbc URL: https://github.com/llvm/llvm-project/commit/36aaffbf56913ebe1e3987d7d0ac76573be65cbc DIFF: https://github.com/llvm/llvm-project/commit/36aaffbf56913ebe1e3987d7d0ac76573be65cbc.diff

[PATCH] D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing

vhscampos created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. vhscampos retitled this revision from "Disable bf16 when hardware FP support is missing" to "[Driver][ARM] Disable bf16 when hardware FP support is missing". vhscampos edited the summary of

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. vhscampos added a child revision: D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing. vhscampos added a reviewer: chill. A list of target features

[PATCH] D82947: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. vhscampos abandoned this revision. A list of target features is disabled when there is no hardware floating-point support. This is the case when one of the following

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

riccibruno added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; `i128` and `Ui128` are not valid integer literal suffix. The output of `StmtPrinter` is intended to be valid C++.

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

riccibruno added a comment. > I'm not certain I understand, but I'm removing my LG while we figure it out. > Can you expound a bit further? Take a look at the AST dump of a small modification of the reduced test case which doesn't trigger the assertion: void

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas updated this revision to Diff 274769. eduucaldas added a comment. better comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82937/new/ https://reviews.llvm.org/D82937 Files: clang/lib/AST/ExprCXX.cpp

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

riccibruno added a comment. In D82940#2124955 , @aaron.ballman wrote: > LGTM, thank you for the fix! Wait, I am not sure that it is the right fix. The body of the lambda should not be different from the body of the `CXXMethodDecl`. Repository: rG

[PATCH] D82844: [clangd] Set gRPC deadlines to all remote index requests

kbobyrev updated this revision to Diff 274744. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82844/new/ https://reviews.llvm.org/D82844 Files:

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG070acb1d1e51: [Driver][ARM] parse version of arm/thumb architecture correctly (authored by danielkiss). Repository: rG

[PATCH] D82659: Fix missing build dependency on omp_gen.

simon_tatham updated this revision to Diff 274739. simon_tatham added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Here's a completely different patch, which adds all the missing dependencies on `OMP.h.inc` in the `clang` subdirectory in one go. Repository:

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev updated this revision to Diff 274743. kbobyrev added a comment. Remove unused variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/ https://reviews.llvm.org/D82436 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev updated this revision to Diff 274741. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/ https://reviews.llvm.org/D82436 Files:

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

riccibruno added a comment. Let me take a look. Reduced test case: class C {} b; void should_not_crash_with_switch_in_lambda() { switch (1) default:; auto f = [] { switch (1) default:; }; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:281 + Range.startCharacter = Symbol.range.start.character; + Range.endLine = Symbol.range.end.line; + Range.endCharacter = Symbol.range.end.character; sammccall wrote: > How

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 274742. baloghadamsoftware added a comment. Rebased on `master` which now contains the handling of pointers as iterators. All tests passed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files:

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82940/new/ https://reviews.llvm.org/D82940

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

thakis added a comment. This (or a follow-up) broke tests on windows: http://45.33.8.238/win/18877/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82185/new/

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dang updated this revision to Diff 274736. dang added a comment. Remove the need for the merger and extractor to be macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files:

[PATCH] D82944: [clangd] Switch FindSymbolsTests to use TestTU

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This gets rid of the dependency on ClangdServer and a bunch of extra infrastructure coming with it.

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

danielkiss added a comment. @j0le patch is landed but I just realised the review is still blocked by @compnerd. So it won't be closed I think, that is my bad. https://github.com/llvm/llvm-project/commit/070acb1d1e51ffd289a46b8f93e993635d0053b7 CHANGES SINCE LAST ACTION

[clang] 070acb1 - [Driver][ARM] parse version of arm/thumb architecture correctly

Author: Daniel Kiss Date: 2020-07-01T12:13:52+02:00 New Revision: 070acb1d1e51ffd289a46b8f93e993635d0053b7 URL: https://github.com/llvm/llvm-project/commit/070acb1d1e51ffd289a46b8f93e993635d0053b7 DIFF: https://github.com/llvm/llvm-project/commit/070acb1d1e51ffd289a46b8f93e993635d0053b7.diff

[PATCH] D81728: [InstCombine] Add target-specific inst combining

lattner requested changes to this revision. lattner added a comment. This revision now requires changes to proceed. This looks like a great direction, but please make sure to minimize public implementation details. We don't want the vast majority of instcombine to be visible outside of its

[clang-tools-extra] 22a3e40 - [clangd] Set gRPC deadlines to all remote index requests

Author: Kirill Bobyrev Date: 2020-07-01T12:46:29+02:00 New Revision: 22a3e4055f4382e8ebbf67705501e6969c6b398b URL: https://github.com/llvm/llvm-project/commit/22a3e4055f4382e8ebbf67705501e6969c6b398b DIFF:

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-member-initializer-assignment.cpp:29 +public: + Simple2() : n (0) { +x = 0.0; baloghadamsoftware wrote: > aaron.ballman wrote: > >

[PATCH] D82787: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:649 + case BO_##NAME: \ +if (isSameMethod(::TraverseBin##NAME,

[PATCH] D82844: [clangd] Set gRPC deadlines to all remote index requests

This revision was automatically updated to reflect the committed changes. Closed by commit rG22a3e4055f43: [clangd] Set gRPC deadlines to all remote index requests (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82844/new/

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:647-653 CmdLineOption ]>, Szelethus wrote: > Szelethus wrote: > > NoQ wrote: > > >

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

baloghadamsoftware added a comment. In D82185#2124948 , @thakis wrote: > This (or a follow-up) broke tests on windows: > http://45.33.8.238/win/18877/step_7.txt > > Please take a look and revert for now if it takes a while to fix. It was this one:

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D82940#2125005 , @riccibruno wrote: > In D82940#2124955 , @aaron.ballman > wrote:

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13540 CHECK_PARSE_BOOL(AlignConsecutiveMacros); + CHECK_PARSE_BOOL(AlwaysBreakBeforeConceptDeclarations);

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:124 +llvm::Optional getRegexFlag(llvm::StringRef Flag) { + for (auto : RegexMap) { +if (Flag == StringFlag.first) `const auto &` (same below)

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. In D79773#2124231 , @JohelEGP wrote: > constexpr plane(const plane& other) noexcept( > (detail::default_allocator_is_nothrow && >

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

vabridgers added a comment. This patch addresses a crash we started seeing in our CTU analysis runs as a result of 05843dc6ab97a00cbde7aa4f08bf3692eb83109d . Gabor, maybe I can generate a regression test for the problems that

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

balazske added a comment. The problem is that `PathDiagnostic::Profile` does not use the uniqueing locations. Two `PathDiagnostic` objects with different uniqueing location but otherwise same data are counted as "same" and only one is kept (`BugReporter::FlushReport`). How to fix this? - Add

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/AST/ExprCXX.cpp:82 + default: +return getNumArgs() == 1; + } riccibruno wrote: > This will be true for `operator->`. Thank you ! I had missed that! I'll

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis updated this revision to Diff 274855. ellis added a comment. Add `isLanguageVersionSupported` for Objective-C Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82904/new/ https://reviews.llvm.org/D82904 Files:

[clang] 2831a31 - Implement AVX ABI Warning/error

Author: Erich Keane Date: 2020-07-01T07:14:31-07:00 New Revision: 2831a317b689c7f005a29f008a8e4c24485c0711 URL: https://github.com/llvm/llvm-project/commit/2831a317b689c7f005a29f008a8e4c24485c0711 DIFF: https://github.com/llvm/llvm-project/commit/2831a317b689c7f005a29f008a8e4c24485c0711.diff

[PATCH] D82575: [OpenMP] Additional OpenMP test without version string after upgrading to 5.0

saiislam updated this revision to Diff 274792. saiislam added a comment. [Work in progress] 48 files inspected/corrected. Following 35 are yet to be checked: clang/test/OpenMP/target_parallel_depend_messages.cpp (26 lines) clang/test/OpenMP/target_parallel_for_depend_messages.cpp (53 lines)

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

martong added a comment. In case of the reproducer the problem is that we clear the switch ids in GetExternalDeclStmt. But we read the SwitchCase with the same ID twice from the same call of `GetExternalDeclStmt` (**//bold-italic//** in the below call stacks): - 1)

[PATCH] D82887: [ARM] Add Cortex-A77 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 274791. LukeGeeson marked 5 inline comments as done. LukeGeeson added a comment. - Added A77 CPU Part Number to Host.cpp - added case to AArch64Subtarget::initializeProperties - moved a77 test up in AArch64-cpu - formatted line for AArch64 Target Parser -

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

ArcsinX marked 3 inline comments as done. ArcsinX added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4539 +if (CXXRecordDecl *T2RecordDecl = +dyn_cast(T2RecordType->getDecl())) { + const auto = T2RecordDecl->getVisibleConversionFunctions();

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

ArcsinX updated this revision to Diff 274789. ArcsinX added a comment. Try conversion function only in C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82805/new/ https://reviews.llvm.org/D82805 Files: clang/lib/Sema/SemaInit.cpp

[PATCH] D82960: Add parenthesized expression to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82960 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D82930: [HIP] Fix rocm detection

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) I don't think the detection should fail if this is missing

[PATCH] D82960: Add parenthesized expression to SyntaxTree

eduucaldas updated this revision to Diff 274795. eduucaldas added a comment. Ordering nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82960/new/ https://reviews.llvm.org/D82960 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81728: [InstCombine] Add target-specific inst combining

nhaehnle added inline comments. Comment at: llvm/include/llvm/Transforms/InstCombine/InstCombiner.h:46 +/// combine them. +class LLVM_LIBRARY_VISIBILITY InstCombiner { +public: lattner wrote: > I would really rather not make this be a public class - this is a

[PATCH] D82891: [clangd] Fix race in FileIndex that sometimes temporarily lost updates.

sammccall marked 5 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:269 + +++this->Version; +if (Version) kadircet wrote: > Bumping the version in `update` and just exposing it in

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

saiislam added a comment. In D81098#2123559 , @clementval wrote: > In D81098#2112159 , @ABataev wrote: > > > LG > > > Since this revision landed two tests are failing. > > ` libomp.env::kmp_set_dispatch_buf.c` and

[PATCH] D82944: [clangd] Switch FindSymbolsTests to use TestTU

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:47 -ClangdServer::Options optsForTests() { - auto ServerOpts =

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Excellent, thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82928/new/ https://reviews.llvm.org/D82928

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

MadCoder added a comment. So the risk with that one is that if someone had say the `-didSomething` direct selector and that some UIKit/Apple SDK API now adds this as a thing that you use with CFNotification center for example, where you _need_ dynamism, then the uses of the API would warn all

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

riccibruno added a subscriber: aaron.ballman. riccibruno added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; davidstone wrote: > riccibruno wrote: > > `i128` and `Ui128` are not

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 274847. jfb edited the summary of this revision. jfb added a comment. Overload a new builtin instead. For now I only did memcpy, to get feedback on the approach. I'll add other mem* functions if this makes sense. Repository: rG LLVM Github Monorepo CHANGES

[clang] 19c3552 - Limit x86 test to require target to fix buildbot (from 2831a317b)

Author: Erich Keane Date: 2020-07-01T07:35:39-07:00 New Revision: 19c35526d98699db6917cf2a6f0dd3fe7da68926 URL: https://github.com/llvm/llvm-project/commit/19c35526d98699db6917cf2a6f0dd3fe7da68926 DIFF: https://github.com/llvm/llvm-project/commit/19c35526d98699db6917cf2a6f0dd3fe7da68926.diff

[PATCH] D82562: Implement AVX ABI Warning/error

This revision was automatically updated to reflect the committed changes. erichkeane marked an inline comment as done. Closed by commit rG2831a317b689: Implement AVX ABI Warning/error (authored by erichkeane). Herald added a project: clang. Changed prior to commit:

[PATCH] D82967: [analyzer][tests] Measure peak memory consumption for every project

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. Repository: rG LLVM

[PATCH] D82968: [VE] Rename VE toolchain source files

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Rename VE.cpp and VE.h to VEToolchain.cpp and VEToolchain.h respectively in order to avoid link warning message.

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. The Provider extension point is designed to also be implemented by ClangdLSPServer (to

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

aaron.ballman added a comment. In D82940#2125183 , @riccibruno wrote: > > I'm not certain I understand, but I'm removing my LG while we figure it > > out. Can you expound a bit further? > > Take a look at the AST dump of a small modification of the

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

ymandel accepted this revision. ymandel added a comment. +1 Especially given how trivial it was to fix clang/lib/ARCMigrate/TransProperties.cpp, this functionality seems unjustified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82921/new/

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas added a reviewer: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added a comment. Code that reproduces the crash Notice that when using a postfix unary operator ++ one argument is introduced to differ it from its prefix counterpart,

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

Szelethus accepted this revision. Szelethus added a comment. The changes proposed in mailing list thread (http://lists.llvm.org/pipermail/cfe-dev/2020-June/066017.html) seem ortogonal to this change. Sorry for the slack today, I just peeked around in MallocChecker to look for conflicts, but it

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:723 + // Parent map is invalidated after changing the AST. + ToDecl->getASTContext().getParentMapContext().clear(); + balazske

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

riccibruno added inline comments. Comment at: clang/lib/AST/ExprCXX.cpp:82 + default: +return getNumArgs() == 1; + } This will be true for `operator->`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] c5263a4 - [clangd] Fix race in FileIndex that sometimes temporarily lost updates.

Author: Sam McCall Date: 2020-07-01T16:47:04+02:00 New Revision: c5263a4e84cc7fb7135a7e9e0cf000af264b72c5 URL: https://github.com/llvm/llvm-project/commit/c5263a4e84cc7fb7135a7e9e0cf000af264b72c5 DIFF: https://github.com/llvm/llvm-project/commit/c5263a4e84cc7fb7135a7e9e0cf000af264b72c5.diff

[PATCH] D82659: Fix missing build dependency on omp_gen.

clementval accepted this revision. clementval added a comment. LGTM. So later the DEPENDS omp_gen that are in clang subdirectories could be removed right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659

[PATCH] D82659: Fix missing build dependency on omp_gen.

simon_tatham added a comment. In D82659#2125618 , @clementval wrote: > LGTM. So later the DEPENDS omp_gen that are in clang subdirectories could be > removed right? That seems likely. I'm thinking what I should probably do is to polish up my checking

[PATCH] D82659: Fix missing build dependency on omp_gen.

simon_tatham added a comment. [facepalm] Thank you. I carefully //wrote// a revised description, but forgot to upload it to this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659

[PATCH] D82388: move "basic" builtins to TableGen

froydnj added a comment. FWIW, an in-progress tree for the proposed move for all the architecture-specific builtins is: https://github.com/froydnj/llvm-project/tree/move-builtins-to-tablegen I don't know if the ARM/NEON/SVE builtins will be easily movable. It looks like they are separately

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

lxfind added a comment. In D82314#2124662 , @junparser wrote: > In D82314#2124661 , @junparser wrote: > > > @lxfind This patch causes some mismatch when variable is used in both > > resume and destroy function.

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

lxfind updated this revision to Diff 274836. lxfind added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82928/new/ https://reviews.llvm.org/D82928 Files: clang/lib/CodeGen/CoverageMappingGen.cpp

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 updated this revision to Diff 274846. njames93 added a comment. Small refactor based on comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

MadCoder added inline comments. Comment at: clang/lib/Sema/SemaExprObjC.cpp:1230 } - -static void HelperToDiagnoseDirectSelectorsExpr(Sema , SourceLocation AtLoc, -Selector Sel, +static void

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > I don't

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

Dor1s added a comment. What usecase(s) do you have for this in mind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82926/new/ https://reviews.llvm.org/D82926 ___ cfe-commits mailing list

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

MadCoder added inline comments. Comment at: clang/test/SemaObjC/potentially-direct-selector.m:84 + (void)@selector(inBaseCat); + (void)@selector(inBaseCatImpl); + (void)@selector(inDerived); I think this might be too weak, if we add a warning then maybe what

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

fpallares added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2367 +Opcode == RISCV::VADC_VIM || Opcode == RISCV::VSBC_VVM || +Opcode == RISCV::VSBC_VXM) { + if (DestReg == RISCV::V0) I think we might not

[PATCH] D82960: Add parenthesized expression to SyntaxTree

eduucaldas updated this revision to Diff 274796. eduucaldas added a comment. nitpick comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82960/new/ https://reviews.llvm.org/D82960 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D82887: [ARM] Add Cortex-A77 Support for Clang and LLVM

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82887/new/ https://reviews.llvm.org/D82887 ___ cfe-commits mailing list

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:125 +CheckFactories.registerCheck( +"bugprone-no-escape"); CheckFactories.registerCheck( ellis wrote: > Not sure if we want to lint this

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone marked an inline comment as done. davidstone added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; riccibruno wrote: > `i128` and `Ui128` are not valid integer literal

[PATCH] D82659: Fix missing build dependency on omp_gen.

clementval added a comment. @simon_tatham Can you just update the description so it is consistent with your fix when it lands? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

njames93 added a comment. Just my 2 cents, but would it not be wise to introduce a test case that runs the 2 aforementioned checks together demonstrating how they interact with each other. This will also force compliance if either check is updated down the line. CHANGES SINCE LAST ACTION

  1   2   3   >