[PATCH] D83143: [clangd] Fix hover crash on invalid decls

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This also changes the way we display Size and Offset to be independent. Repository: rG LLVM Github

[clang-tools-extra] 551092b - Revert AST Matchers default to AsIs mode

Author: Stephen Kelly Date: 2020-07-03T21:19:46+01:00 New Revision: 551092bc3dfb86f1e11a55f3bee0c8ee1be6fdd6 URL: https://github.com/llvm/llvm-project/commit/551092bc3dfb86f1e11a55f3bee0c8ee1be6fdd6 DIFF: https://github.com/llvm/llvm-project/commit/551092bc3dfb86f1e11a55f3bee0c8ee1be6fdd6.diff

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1884 + if (const BuiltinType *BTy = + Context.getBaseElementType(CTy->getElementType()) + ->getAs()) I don't think there's a reason

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

NoQ accepted this revision. NoQ added a comment. This looks great to me as long as other reviewers are happy. @vrnithinkumar, I think you should ask for commit access and honorably push the patch to master yourself ^.^ I guess we'll talk about this more, but i think the really good next step

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer created this revision. fmayer added a reviewer: george.burgess.iv. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some projects do not use the TEMP_FAILURE_RETRY macro but define their own one, as not to depend on glibc / Bionic details. By allowing the user to

[PATCH] D83143: [clangd] Fix hover crash on invalid decls

This revision was automatically updated to reflect the committed changes. Closed by commit rG50ba9f994c6f: [clangd] Fix hover crash on invalid decls (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83143/new/

[PATCH] D83143: [clangd] Fix hover crash on invalid decls

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83143/new/ https://reviews.llvm.org/D83143

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

stevewan accepted this revision. stevewan added a comment. LGTM with minor nit. I took a look at the failed tests in premerge checks, they didn't seem to be related, but please double check before you commit. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:195 + // Return

[PATCH] D82659: Fix missing build dependency on omp_gen.

clementval added a comment. In D82659#2130022 , @simon_tatham wrote: > @jdoerfert , @clementval : over in D83032 > is a polished-up version of the script I used to check where the missing deps > needed to go. Might be

[clang-tools-extra] 50ba9f9 - [clangd] Fix hover crash on invalid decls

Author: Kadir Cetinkaya Date: 2020-07-03T22:51:04+02:00 New Revision: 50ba9f994c6f9c51692282494c3b40dbc69b4abd URL: https://github.com/llvm/llvm-project/commit/50ba9f994c6f9c51692282494c3b40dbc69b4abd DIFF:

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. Aside from one comment; LGTM. Thanks. Comment at: clang/test/Driver/aix-toolchain-include.cpp:4 +// Check powerpc-ibm-aix, 32-bit/64-bit. +// RUN: %clangxx -### -no-canonical-prefixes %s

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

jaafar added a comment. It's been pointed out to me that 28546 preceded this commit... so it may only //appear// related. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52676/new/ https://reviews.llvm.org/D52676 ___

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar updated this revision to Diff 275434. vrnithinkumar marked 11 inline comments as done. vrnithinkumar added a comment. addressing review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81315/new/ https://reviews.llvm.org/D81315 Files:

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:3628 + // FIXME: This may not be the best approach, as the correct type (including + // address space) is available in D, but the type in D may not be reliable Is

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:41 + + bool checkDeferenceOps(const CallEvent , CheckerContext ) const; +}; NoQ wrote: > Looks like dead code. Thanks! removed. Comment at:

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1778 +if (FoundNonOverlappingEmptyField) + HandledFirstNonOverlappingEmptyField = true; + See my other comment for rationale on why

[PATCH] D81270: [XCOFF][AIX] Use 'L..' instead of '.L' for getPrivateGlobalPrefix in DataLayout

This revision was automatically updated to reflect the committed changes. Closed by commit rG572dde55eebb: [XCOFF][AIX] Use L.. instead of .L for getPrivateGlobalPrefix in DataLayout (authored by jasonliu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:12 +// RUN: -target-cpu pwr10 -triple powerpc64le-unknown-unknown -emit-llvm %s \ +// RUN: -o - | FileCheck %s -check-prefix=CHECK-LE + I just noticed this. There is no need

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/AIX.cpp:195 + // Return if -nostdlibinc is specified as a driver option. + if

[PATCH] D79279: Add overloaded versions of builtin mem* functions

gchatelet added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:489 BUILTIN(__builtin_memcpy_inline, "vv*vC*Iz", "nt") +BUILTIN(__builtin_overloaded_memcpy, "v*v*vC*z", "nt") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") jfb wrote: >

[PATCH] D83076: Revert AST Matchers default to AsIs mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG551092bc3dfb: Revert AST Matchers default to AsIs mode (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D83076?vs=275248=275458#toc Repository: rG LLVM Github Monorepo

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. It looks OK. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82585/new/ https://reviews.llvm.org/D82585 ___

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

baloghadamsoftware updated this revision to Diff 275406. baloghadamsoftware added a comment. Rebased. Tests added. Fixed to work on `std::vector`-like and `std::deque`-like containers as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77150/new/ https://reviews.llvm.org/D77150

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2706 + + For example: STRINGIZE + JakeMerdichAMD wrote: > curdeius wrote: > > Shouldn't there be a configuration example like what's in `ForEachMacros` > > doc? > > ``` >

[PATCH] D77125: [Analyzer] Model return values of container insert and delete operations

baloghadamsoftware updated this revision to Diff 275405. baloghadamsoftware added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77125/new/ https://reviews.llvm.org/D77125 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 275423. Conanap marked 3 inline comments as done. Conanap added a comment. Moved some code to the top of the file as per Lei's request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap marked 2 inline comments as done. Conanap added a comment. Addressed Lei's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 ___ cfe-commits

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

jaafar added a comment. Hi everyone, I've been investigating a bug and bisected it to this commit. The problem, in brief, is that lambdas passed as arguments can cause an extra line break before the first argument, but only if the lambda is neither the first nor the last argument. This

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith abandoned this revision. keith added a comment. https://reviews.llvm.org/D83015 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80660/new/ https://reviews.llvm.org/D80660 ___ cfe-commits mailing

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 275432. ShuhongL added a comment. Add clang -xc tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp

[clang] 572dde5 - [XCOFF][AIX] Use 'L..' instead of '.L' for getPrivateGlobalPrefix in DataLayout

Author: jasonliu Date: 2020-07-03T18:25:14Z New Revision: 572dde55eebbe54eb90398c16c71d4376ca754e3 URL: https://github.com/llvm/llvm-project/commit/572dde55eebbe54eb90398c16c71d4376ca754e3 DIFF: https://github.com/llvm/llvm-project/commit/572dde55eebbe54eb90398c16c71d4376ca754e3.diff LOG:

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82964/new/ https://reviews.llvm.org/D82964

[PATCH] D83095: [clangd] Config: compute config in TUScheduler and BackgroundIndex

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:748 +Context ClangdServer::createProcessingContext(PathRef File) const { + if (!ConfigProvider) sammccall wrote: > kadircet wrote: > > why not make this a free function in

[PATCH] D83143: [clangd] Fix hover crash on invalid decls

kadircet updated this revision to Diff 275448. kadircet added a comment. Inline OffsetBits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83143/new/ https://reviews.llvm.org/D83143 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:195 + // Return if -nostdlibinc is specified as a driver option. + if (DriverArgs.hasArg(options::OPT_nostdlibinc)) +return; stevewan wrote: > Can we rewrite this

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

jaafar added inline comments. Comment at: cfe/trunk/lib/Format/TokenAnnotator.cpp:3072 + return false; +if (!Next->isOneOf(TT_LambdaLSquare, tok::l_brace, tok::caret)) + return true; This is the clause that triggers the problem. Repository: rL

[PATCH] D83095: [clangd] Config: compute config in TUScheduler and BackgroundIndex

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83095/new/ https://reviews.llvm.org/D83095

[clang] 0939e04 - [PowerPC] Implement Vector Insert Builtins in LLVM/Clang

Author: Biplob Mishra Date: 2020-07-03T15:30:41-05:00 New Revision: 0939e04e417634f6d38ec4f06835fb80756afdd3 URL: https://github.com/llvm/llvm-project/commit/0939e04e417634f6d38ec4f06835fb80756afdd3 DIFF: https://github.com/llvm/llvm-project/commit/0939e04e417634f6d38ec4f06835fb80756afdd3.diff

[PATCH] D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG0939e04e4176: [PowerPC] Implement Vector Insert Builtins in LLVM/Clang (authored by biplmish, committed by lei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:1 +// RUN: %clang_cc1 -emit-llvm-only -triple powerpc-ibm-aix-xcoff \ +// RUN: -fdump-record-layouts -fsyntax-only %s 2>/dev/null | \ Xiangling_L wrote:

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1877 + CharUnits PreferredAlign = FieldAlign; + if (SupportsAIXPowerAlignment && FieldOffset == CharUnits::Zero() && + (IsUnion || FoundNonOverlappingEmptyField)) {

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

MaskRay created this revision. MaskRay added reviewers: calixte, marco-c, serge-sans-paille, vsk. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, hiraditya. Herald added projects: clang, Sanitizers, LLVM. GCC r187297 (2012-05) introduced __gcov_dump and __gcov_reset.

[clang] e359ab1 - [PowerPC][NFC] Fix indentation

Author: Lei Huang Date: 2020-07-03T16:47:24-05:00 New Revision: e359ab1eca5727ce4c688bb49323b8a09478d61c URL: https://github.com/llvm/llvm-project/commit/e359ab1eca5727ce4c688bb49323b8a09478d61c DIFF: https://github.com/llvm/llvm-project/commit/e359ab1eca5727ce4c688bb49323b8a09478d61c.diff

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

hiraditya added a comment. Herald added a subscriber: danielkiss. do we have a plan to follow up on this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith created this revision. keith added reviewers: vsk, arphaman, rnk. Herald added a subscriber: dexonsmith. Herald added a project: clang. keith added a comment. Open question: I don't know how all the toolchains fit together, but I noticed that only Clang.cpp handles -fmacro-prefix-map, but

[PATCH] D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

keith abandoned this revision. keith added a comment. https://reviews.llvm.org/D83154 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81122/new/ https://reviews.llvm.org/D81122 ___ cfe-commits mailing

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

tellenbach added a comment. In D68076#2131108 , @hiraditya wrote: > do we have a plan to follow up on this patch? Hi! I'm currently not working on this (and LLVM in general) anymore. However, the issue seems to be still present and this patch would fix

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added a comment. Open question: I don't know how all the toolchains fit together, but I noticed that only Clang.cpp handles -fmacro-prefix-map, but Clang.cpp, FreeBSD.cpp, and Gnu.cpp all handle -fdebug-prefix-map. I wasn't sure which pattern I should follow here, so right now this only

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:1 +// RUN: %clang_cc1 -emit-llvm-only -triple powerpc-ibm-aix-xcoff \ +// RUN: -fdump-record-layouts -fsyntax-only %s 2>/dev/null | \

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1908 // The align if the field is not packed. This is to check if the attribute // was unnecessary (-Wpacked). CharUnits UnpackedFieldAlign = FieldAlign;

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1235 + // Do not use AIX special alignment if current base is not the first member or + // the struct is not a union. hubert.reinterpretcast wrote: >

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas updated this revision to Diff 275317. eduucaldas added a comment. Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82937/new/ https://reviews.llvm.org/D82937 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprCXX.cpp

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas updated this revision to Diff 275316. eduucaldas added a comment. Herald added a subscriber: mgorny. Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files:

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas updated this revision to Diff 275318. eduucaldas added a comment. Revert mistake on last update, used `arc diff --update` with the wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas updated this revision to Diff 275315. eduucaldas added a comment. - Remove predicates in `CXXOperatorCallExpr`. - Implement getOperatorNodeKind to dispatch from `CXXOperatorCallExpr` to syntax constructs like `BinaryOperatorExpression`, `PrefixUnaryOperatorExpression`...

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Two CSA bug

[PATCH] D83074: [clang] Check ValueDependent instead of InstantiationDependent before executing the align expr for builtin align functions.

hokein updated this revision to Diff 275299. hokein marked an inline comment as done. hokein added a comment. add more test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83074/new/ https://reviews.llvm.org/D83074 Files:

[PATCH] D83114: [clang] Fix the incorrect dependence bits for DependentExtIntType.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. The error-bit was missing, and the unexpandedpack bit seemed to be set incorrectly. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83114 Files: clang/lib/AST/Type.cpp

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

balazske updated this revision to Diff 275311. balazske added a comment. Rebase, added a FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82845/new/ https://reviews.llvm.org/D82845 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. In D82314#2125713 , @lxfind wrote: > In D82314#2124662 , @junparser wrote: > > > In D82314#2124661 , @junparser > > wrote: > > > > > @lxfind This

[PATCH] D83076: Revert AST Matchers default to AsIs mode

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83076/new/ https://reviews.llvm.org/D83076 ___

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1605 + })); + }; + I am not a fan of this lambda style, not because I dislike lambdas, but because you've pulled a ton of code that's supporting one or two cases (that could

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing lifetime-extended temporaries created in conditional expressions

rjmccall added a comment. In D82999#2129417 , @ahatanak wrote: > In test case `test13` in clang/test/CodeGenCXX/exceptions.cpp, I think you > can turn `invoke void @_ZN6test131AC1Ev` into `call void @_ZN6test131AC1Ev`, > no? If the false expression

[clang] 283c8f7 - [clang] Check ValueDependent instead of InstantiationDependent before executing the align expr for builtin align functions.

Author: Haojian Wu Date: 2020-07-03T09:02:12+02:00 New Revision: 283c8f7f5ad0328ed99ec189ce3d6b3c7c877d36 URL: https://github.com/llvm/llvm-project/commit/283c8f7f5ad0328ed99ec189ce3d6b3c7c877d36 DIFF: https://github.com/llvm/llvm-project/commit/283c8f7f5ad0328ed99ec189ce3d6b3c7c877d36.diff

[PATCH] D83074: [clang] Check ValueDependent instead of InstantiationDependent before executing the align expr for builtin align functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG283c8f7f5ad0: [clang] Check ValueDependent instead of InstantiationDependent before executing… (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D83074?vs=275299=275306#toc

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings jdoerfert wrote: > fghanim wrote: > > jdoerfert wrote: > > > fghanim wrote: > > > >

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas updated this revision to Diff 275325. eduucaldas added a comment. Remove review formatting noise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82937/new/ https://reviews.llvm.org/D82937 Files: clang/include/clang/AST/ExprCXX.h

[PATCH] D83114: [clang] Fix the incorrect dependence bits for DependentExtIntType.

sammccall accepted this revision. sammccall added a subscriber: erichkeane. sammccall added a comment. This revision is now accepted and ready to land. Existing logic is odd. Error propagation change is definitely correct, and I suspect the other change is too, but let's ask just in case. (The

[PATCH] D83120: [Analyzer][StreamChecker] Using BugType::SuppressOnSink at resource leak report.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. The previous

[PATCH] D82659: Fix missing build dependency on omp_gen.

simon_tatham added a comment. @jdoerfert , @clementval : over in D83032 is a polished-up version of the script I used to check where the missing deps needed to go. Might be useful for the next problem of this kind. But I'm not sure who to get to review it;

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13540 CHECK_PARSE_BOOL(AlignConsecutiveMacros); + CHECK_PARSE_BOOL(AlwaysBreakBeforeConceptDeclarations);

[PATCH] D80911: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. As mentioned earlier, I think the patch is a nice, isolated fix for the `read_register` issue and it should not make addressing the bigger issue more difficult. LGTM, thanks! Repository:

[clang-tools-extra] 5c46fef - [clangd] Improve hover on arguments to function call

Author: Adam Czachorowski Date: 2020-07-03T11:51:15+02:00 New Revision: 5c46fefdba3b18329dc331e69d1d1d6550c4075f URL: https://github.com/llvm/llvm-project/commit/5c46fefdba3b18329dc331e69d1d1d6550c4075f DIFF:

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

baloghadamsoftware added inline comments. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:333 + if (XL.isValid() && YL.isInvalid()) +return false; std::pair XOffs = XL.getDecomposedLoc(); Why this asymmetry? Comment at:

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

olestrohm updated this revision to Diff 275345. olestrohm added a comment. Added a guard in deduceOpenCLAddressSpace to stop it from deducing address space for dependent types, as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82781/new/ https://reviews.llvm.org/D82781

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

balazske updated this revision to Diff 275343. balazske added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75740/new/ https://reviews.llvm.org/D75740 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D83121: [AMDGPU] Change Clang AMDGCN atomic inc/dec builtins to take unsigned values

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83121/new/ https://reviews.llvm.org/D83121

[PATCH] D82787: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b0be962d681: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post… (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:333 + if (XL.isValid() && YL.isInvalid()) +return false; std::pair XOffs = XL.getDecomposedLoc(); baloghadamsoftware wrote: > Why

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

This revision was automatically updated to reflect the committed changes. Closed by commit rG94454442c3c1: RecursiveASTVisitor: dont call WalkUp unnecessarily in post-order traversal (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

balazske added a comment. Basically this looks good in the current way too, but I can only assume that the code was copied correctly. A rule could be that the `CheckerRegistryData` is manipulated only by `CheckerRegistry` but get or print functions can be in `CheckerRegistryData`.

[PATCH] D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased

This revision was automatically updated to reflect the committed changes. Closed by commit rG79889691430d: Added tests for RecursiveASTVisitor for AST nodes that are special cased (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

olestrohm updated this revision to Diff 275351. olestrohm added a comment. Disregard the last comment, rolling back that diff for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82781/new/ https://reviews.llvm.org/D82781 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

[PATCH] D82889: Make RecursiveASTVisitor call WalkUpFrom for operators when the data recursion queue is absent

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bf4c40af813: Make RecursiveASTVisitor call WalkUpFrom for operators when the data recursion… (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83099: Revert "[clangd] Store index in '.clangd/index' instead of '.clangd-index'"

kadircet added inline comments. Comment at: .gitignore:56 .vs # clangd index +.clangd-index/ the comment above says `do not add trailing /`, we've got no choice for `.clangd/` but maybe drop that for `.clangd-index` ? Repository: rG LLVM Github Monorepo

[PATCH] D83121: [AMDGPU] Change Clang AMDGCN atomic inc/dec builtins to take unsigned values

saiislam created this revision. saiislam added reviewers: arsenm, sameerds, JonChesterfield. Herald added subscribers: cfe-commits, kerbowa, jfb, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl. Herald added a project: clang. saiislam added a parent revision: D80804: [AMDGPU]

[PATCH] D81169: [clangd] Improve hover on arguments to function call

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c46fefdba3b: [clangd] Improve hover on arguments to function call (authored by adamcz, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

saiislam added a comment. In D80804#2123183 , @JonChesterfield wrote: > This patch declares the clang builtin as acting on signed values, but the IR > intrinsic maps to an instruction which does an unsigned comparison. We don't > have ISA support for a

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigProvider.cpp:39 +auto Buf = FS.getBufferForFile(Path); +// If stat() succeeds but we failed to read, retry once and cache failure. +if (!Buf) why do we want to cache failure

[clang] 7988969 - Added tests for RecursiveASTVisitor for AST nodes that are special cased

Author: Dmitri Gribenko Date: 2020-07-03T13:03:18+02:00 New Revision: 79889691430d8e76e908706170102a8b46432a07 URL: https://github.com/llvm/llvm-project/commit/79889691430d8e76e908706170102a8b46432a07 DIFF:

[clang] 7b0be96 - Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode

Author: Dmitri Gribenko Date: 2020-07-03T13:03:19+02:00 New Revision: 7b0be962d681c408c8ecf7180c6ad8f9fbcdaf2d URL: https://github.com/llvm/llvm-project/commit/7b0be962d681c408c8ecf7180c6ad8f9fbcdaf2d DIFF:

[clang] 8bf4c40 - Make RecursiveASTVisitor call WalkUpFrom for operators when the data recursion queue is absent

Author: Dmitri Gribenko Date: 2020-07-03T13:03:19+02:00 New Revision: 8bf4c40af813e73de77739b33b8808f6bd13497b URL: https://github.com/llvm/llvm-project/commit/8bf4c40af813e73de77739b33b8808f6bd13497b DIFF:

[clang] 9445444 - RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

Author: Dmitri Gribenko Date: 2020-07-03T13:03:19+02:00 New Revision: 94454442c3c15a67ae70ef3a73616632968973fc URL: https://github.com/llvm/llvm-project/commit/94454442c3c15a67ae70ef3a73616632968973fc DIFF:

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:118 +syntax::NodeKind getOperatorNodeKind(const CXXOperatorCallExpr ) { + switch (E.getOperator()) { # Where to put this logic? The pro of having this function inside

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos updated this revision to Diff 275392. vhscampos added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. 1. Merged the second patch into this (handle bf16). 2. Do the same treatment for -mcpu. 3. Instead of doing string search once again, return

[clang] 53422e8 - [AMDGPU] Added support of new inline assembler constraints

Author: Dmitry Preobrazhensky Date: 2020-07-03T18:01:12+03:00 New Revision: 53422e8b4f65a6736896311b10ad8a22fbc9e372 URL: https://github.com/llvm/llvm-project/commit/53422e8b4f65a6736896311b10ad8a22fbc9e372 DIFF:

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1871 + // AIX ABI has this special rule that in aggregates, the first member of + // floating point data type(or aggregate type contains floating point data

[PATCH] D81657: [AMDGPU] Added support of new inline assembler constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rG53422e8b4f65: [AMDGPU] Added support of new inline assembler constraints (authored by dp). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D83088: Introduce CfgTraits abstraction

arsenm added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineCfgTraits.h:133 + ++m_def; + if (m_def == m_instr->defs().end()) { +++m_instr; != return early? Comment at:

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 275396. ShuhongL added a comment. - `nostdlibinc` should not suppress clang builtin headers - Add tests for `nostdlibinc` and `nobuiltininc` - fix lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/

  1   2   >